Commit Graph

478 Commits

Author SHA1 Message Date
devin doucette
c75cf0ed41 StallDetector: Fixed a compile error
#rb none
#rnx

[CL 24564480 by devin doucette in ue5-main branch]
2023-03-08 14:26:24 -05:00
devin doucette
8d7eba0c61 StallDetector: Fixed shadowing error caused by a poorly scoped global
#rb none
#rnx

[CL 24564467 by devin doucette in ue5-main branch]
2023-03-08 14:25:38 -05:00
Sebastian Thomeczek
dc2cf85e53 [Insights] Update Regions code to use custom trace events instead of hijacking regular bookmarks
#rb Ionut.Matasaru
#jira UE-148203
#preflight 64072d276e1dadfcda7352c9
#preflight 640731e4ba12ba641681363a

[CL 24538562 by Sebastian Thomeczek in ue5-main branch]
2023-03-07 08:00:11 -05:00
tyler staples
bf09d60d6b Add non-persistent metadata to the CsvProfiler.
By default csv metadata persists between captures which may be problematic if capturing different modes that have specific metadata since prior captures can pollute future ones.
This change adds a CSV_NON_PERSISTENT_METADATA macro which sets metadata that is cleared once the current capture ends.

For sake of review I've included the change to the FortLevelSaveComponent to update the creative metdata to use this macro. This will be submitted separately though.

#rb ben.woodhouse
[FYI] andrew.ladenberger

[CL 24436772 by tyler staples in ue5-main branch]
2023-02-27 20:55:32 -05:00
Johan Berg
a0d44a5237 Fix missing channel check for metadata restore scopes.
When creating the custom scope type, a check if the channel is active was missing causing the scopes to emit events regardless if the metadata channel was active.

#rb ionut.matasaru
#jira UE-178464
#preflight 63f8b471dd78dd50f66bbd55

[CL 24421297 by Johan Berg in ue5-main branch]
2023-02-27 06:43:17 -05:00
ionut matasaru
416b29771c [Insights] Fixed typo in warning message for SnapshotSend (trace command).
#rb trivial
#preflight 63e6627f8917c5deac736fa3

[CL 24119584 by ionut matasaru in ue5-main branch]
2023-02-10 10:43:24 -05:00
Johan Berg
2b44a347bb Fix for metadata scopes applied in tasks.
When launching a task, the metadata stack is captured at the calling site, and reapplied as a scope as soon as the task begins to execute. The macro that performed this reapplication was misnamed and didn't imply that it was actually creating a scope. This change removes the macro and adds a custom scope type which can be embedded in the inherited context for the task.

#rb ionut.matasaru, andriy.tylychko
#jira UE-167069
#preflight 63e64e153c247ccd13e986e4

[CL 24118353 by Johan Berg in ue5-main branch]
2023-02-10 09:31:37 -05:00
ionut matasaru
149f85440d [Insights] Fixed scope of metadata and mem tag for mem allocations made by the trace system (i.e. extends scope over the original allocator calls). So, heap allocations will inherit same "trace" tag.
#rb Johan.Berg
#preflight 63e646913d24a13d13b108c8

[CL 24117860 by ionut matasaru in ue5-main branch]
2023-02-10 08:42:47 -05:00
henrik karlsson
c8c3d0b8b2 [Core]
* Made code compatible with modules/header units. This includes following things:
   * Removed static in front of global functions/variables (static indicates it is hidden outside of module/header unit which is not what many places want...)
   * Moved dllexport from type to methods in order to get dllexport of static constexpr fields. This is supposed to work according to microsoft but since it is a good change I don't mind doing it anyway)
   * static constexpr -> static constexpr inline for member variables and methods (this makes them available outside module/headerunit)
   * Added HEADER_UNIT_IGNORE markup to includes that are circular
   * Added HEADER_UNIT_SKIP to files that can't compile by themselves

#preflight 63e2aeba3c44c83044bfcc75
#rb steve.robb

[CL 24066986 by henrik karlsson in ue5-main branch]
2023-02-08 00:25:15 -05:00
catalin dragoiu
83deb26fb5 Fix snapshot bugs in Insights Status Bar Widget.
#rb Ionut.Matasaru
#jira UE-175267,UE-175284,UE-175356
#preflight 63d7ea2fec3d1af4409128d3
#lockdown mark.lintott

[CL 23951418 by catalin dragoiu in ue5-main branch]
2023-02-01 12:28:50 -05:00
ionut matasaru
c9a44e6153 [Insights] Added the "screenshot" trace channel to the "default" channel preset.
#rb trivial
#preflight skip

[CL 23854487 by ionut matasaru in ue5-main branch]
2023-01-25 15:09:59 -05:00
Johan Berg
b0ba00dce1 Properly implement snapshot to server in Insights status bar
#preflight 63d12034033e457ba8c659af

[CL 23846388 by Johan Berg in ue5-main branch]
2023-01-25 07:35:06 -05:00
Martin Ridgers
35363002cd Moved modifications of settings based on context to a more appropriate location, in keeping with architectural intent.
#rb jb
#rnx
#preflight 63d111c6574ab9cae4a21415

[CL 23846108 by Martin Ridgers in ue5-main branch]
2023-01-25 06:44:17 -05:00
christopher waters
2285d21e63 Removing TaskGraphInterfaces.h include from CoreDelegates.h
[CL 23836502 by christopher waters in ue5-main branch]
2023-01-24 15:07:59 -05:00
Johan Berg
53cdfa5080 Add send trace snapshot command
Adds the ability to send a trace snapshot to a server. A snapshot is the contents of any events in the tail buffer along with the important events needed to analyze them. This feature exists but was only supported writing to local files.

#UE-161986
#rb
#preflight 63ce521dbb14367242e8de71

[CL 23809085 by Johan Berg in ue5-main branch]
2023-01-23 04:38:57 -05:00
Tim Smith
0fb5daa752 Removed HACK_HEADER_GENERATOR
#rb devin.doucette
#preflight 63cad02ca265157a6d5159af

[CL 23792667 by Tim Smith in ue5-main branch]
2023-01-20 12:47:21 -05:00
ionut matasaru
8dcfca1aea [Insights]
- MemoryTrace: Added CallstackId for all free events and also for HeapMarkAlloc, HeapUnmarkAlloc events.
  - MemoryTrace: Increased trace version to 2.

#rb Johan.Berg
#preflight 63cab54dee564281cdc111bf

[CL 23790801 by ionut matasaru in ue5-main branch]
2023-01-20 11:12:39 -05:00
Catalin Dragoiu
1ca2f5debb Fixes for the Insights Status Bar Widget on Mac.
#rb Ionut.Matasaru
#preflight 63c9607b0225f00e149be539

[CL 23773807 by Catalin Dragoiu in ue5-main branch]
2023-01-19 10:43:24 -05:00
bryan sefcik
13665b41ad Turned off VTune and ISPC when compiling windows arm64
#preflight 63b607132960b73220d02835

[CL 23583219 by bryan sefcik in ue5-main branch]
2023-01-04 18:23:39 -05:00
Catalin Dragoiu
4993a1a079 Add Trace Bookmark and Trace Screenshot buttons to the Insigths Status Bar Widget.
#jira UE-161773
#rb Ionut.Matasaru
#preflight 639b28bbc16855964d64326e

[CL 23527321 by Catalin Dragoiu in ue5-main branch]
2022-12-15 10:15:25 -05:00
Andriy Tylychko
bf70678509 minor renaming of global vars to avoid name clashes in unity builds
#preflight 6398644535203bc7aa5b5a5f

[CL 23490003 by Andriy Tylychko in ue5-main branch]
2022-12-13 06:44:27 -05:00
Martin Ridgers
3a2d557c40 Allow tracing to be started without sending the tail of historical events.
#rb im
#rnx
#preflight 637c9664f514e1ded9ee4db7

[CL 23233106 by Martin Ridgers in ue5-main branch]
2022-11-22 06:26:27 -05:00
David Harvey
1cab40981d Clang warning fixes
#jira UE-163945
#rnx
#rb Nuno.Leiria
#preflight 6374b4491c114bec05f01873

[CL 23151994 by David Harvey in ue5-main branch]
2022-11-16 05:12:39 -05:00
martin ridgers
afdc3f0e6e Allow backtrace captures to vary in size on a per-platform basis.
Some platforms have threads with very small stacks that we don't appear to be able to control. This places a limit on how much stack is available to capture a callstack in situations where memory hooks are in place. Curl's host name resolving threads an the CurlCalloc() hooks are one such example.

#rb cm
#rnx
#preflight 636d00ad376a9cd6a8f4e22c
#ushell-cherrypick of 23076081 by Martin.Ridgers

[CL 23101615 by martin ridgers in ue5-main branch]
2022-11-11 13:31:18 -05:00
Catalin Dragoiu
2c65745543 Add options to the Insights Status Bar Widget
#rb Ionut.Matasaru
#jira UE-161773
#preflight 636e5b00ee4d25f90af1325a

[CL 23097615 by Catalin Dragoiu in ue5-main branch]
2022-11-11 09:46:20 -05:00