Commit Graph

24 Commits

Author SHA1 Message Date
Dan Thompson
56d05caea1 Adding logs for bink audio encode errors.
#rb jeff.roberts
#preflight 63b87063763c6c106440532f

[CL 23603493 by Dan Thompson in ue5-main branch]
2023-01-06 16:37:28 -05:00
Dan Thompson
b4856d7914 Fix for some assets clicking on loop with bink audio.
#jira UE-168024
#rb jimmy.smith
#preflight 636aa7e04d3c1d9d92e5308b

[CL 23034020 by Dan Thompson in ue5-main branch]
2022-11-08 14:09:14 -05:00
Ben Marsh
32c2ff2e51 Use a quoted string for error message in BinkAudioInfo.cpp, to avoid invalid token caused by unpaired apostrophe (which would be parsed as a character literal).
See: https://gcc.gnu.org/onlinedocs/gcc-4.5.0/cpp/Diagnostics.html

#preflight none
#fyi Dan.Thompson

[CL 23011509 by Ben Marsh in ue5-main branch]
2022-11-07 10:59:53 -05:00
dan thompson
f46d2b2ada Fix for bink audio 96khz regression.
#jira UE-168185
#rb trivial
#preflight 63571e833d41a4455a72fd99

[CL 22788149 by dan thompson in ue5-main branch]
2022-10-26 16:14:53 -04:00
dan thompson
84999c3416 Fixes from the fuzz testing of bink audio encoder
#rb jeff.roberts
#jira UE-166765
#preflight 63473b178a0a7b2adc9deb3e

[CL 22489125 by dan thompson in ue5-main branch]
2022-10-12 20:06:15 -04:00
adam kinge
924d0087f2 Add tvOS as a compilable target for Bink Decoder lib. Note: lipo isn't used as we only support arm64 based AppleTVs
#jira UE-137693
#review-22122687 @dan.thompson
#fyi jack.porter, axel.riffard
#preflight 6345d277045315f96a31d835

[CL 22466036 by adam kinge in ue5-main branch]
2022-10-11 17:36:10 -04:00
adam kinge
75ab80e71a Add tvOS to the allowed platform Bink Audio Decoder list and include a tvOS compatible static lib.
#jira UE-137693
#rb dan.thompson, jack.porter, axel.riffard
#preflight 632cafe6d747fe52c86802ac

[CL 22151052 by adam kinge in ue5-main branch]
2022-09-22 22:17:14 -04:00
Dan Thompson
e6191e9102 Copyright boilerplate
#rb none
#preflight n/a

[CL 22083040 by Dan Thompson in ue5-main branch]
2022-09-19 18:29:45 -04:00
Dan Thompson
ab13eaa3b4 bink audio arm64 encoding consistency, and picking up a handful of minor tweaks/fixes. This also adds scripts for building the various apple libs that don't require cmake.
Currently we still rely on a handful of libm functions to be consistent across compilers/plaforms, however current consistency tests pass.

Due to the (very) narrow range we call log, a custom approximation is added to ensure consistency.

Additionally, we reset the floating point state on entry in case fp:fast has messed with it on our thread.

Note that the decoder libs are not currently updated as none of the fixes are worth the testing load due to lack of active bug reports.

#preflight 6328cf2af87253e021d862ad
#rb fabien.geisen jeff.roberts

[CL 22082773 by Dan Thompson in ue5-main branch]
2022-09-19 18:17:37 -04:00
jimmy smith
b92f1fdf0d Configuration support for AudioInfos / AudioFormats per platform
#jira UE-159832
#rb Aaron.mcleran Phil.Popp Dan.Thompson Josh.Adams
#preflight 62d260033c3df323907eaa93

[CL 21153330 by jimmy smith in ue5-main branch]
2022-07-18 17:47:55 -04:00
igor dallavanzi
89f3a3ede5 update sample count when seeking in Bink Audio Decoder #preflight 62b04a8e6965d8cf8de29b60 #jira UE-157059
[CL 20736080 by igor dallavanzi in ue5-main branch]
2022-06-20 08:52:14 -04:00
David Harvey
4edf0f812e use bink audio on windows-based platform extensions.
#jira UE-131865
#rnx
#rb trivial
#preflight 626bac525c220f34acdb251f

[CL 19976252 by David Harvey in ue5-main branch]
2022-04-29 05:17:07 -04:00
will damon
cd43d1bb9a Rebuild bink audio SDK libraries as universal binaries for macOS
- on macOS Catalina 10.15.7
- with Xcode 12.4
- as universal binaries with arm64 and x86_64 slices

- Add BuildForMac.command script
- Add CMakeLists.txt

#rb jeff.roberts, dan.thompson
#jira UE-145175
#rnx
#preflight 624efca5f94f766ffaad8ef3

[CL 19671743 by will damon in ue5-main branch]
2022-04-07 12:43:30 -04:00
jimmy smith
9cd4eba30c BinkAudio Error flag.
#jira UE-145912
#rb chris.caulfield dan.thompson aaron.mcleran
#preflight 623227baef5d0f0e8feebebc

#ROBOMERGE-AUTHOR: jimmy.smith
#ROBOMERGE-SOURCE: CL 19414022 in //UE5/Release-5.0/... via CL 19414687
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v928-19376421)

[CL 19417047 by jimmy smith in ue5-main branch]
2022-03-16 23:41:32 -04:00
aurel cordonnier
34f55d3a4a Merge from Release-Engine-Test @ 17946149 to UE5/Main
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17949667 by aurel cordonnier in ue5-main branch]
2021-10-27 15:14:40 -04:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
will damon
eb41f6ad9b Update bink audio decode library for iOS.
#rb dan.thompson
#jira UE-126490 UE-118568
#rnx
[FYI] jack.porter

#ROBOMERGE-AUTHOR: will.damon
#ROBOMERGE-SOURCE: CL 17551435 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17551458 by will damon in ue5-release-engine-test branch]
2021-09-17 09:44:30 -04:00
jack porter
5eb0af5a7d Temporarily disable BinkAudio on iOS due to link error
#jira UE-121822
#rb Will.Damon

#ROBOMERGE-SOURCE: CL 17412120 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17412134 by jack porter in ue5-release-engine-test branch]
2021-09-02 20:50:53 -04:00
dan thompson
b85672db7c Switching to a fat binary for OSX bink audio static libs, and adding osx arm 64 for M1
#ROBOMERGE-SOURCE: CL 17216787 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17218103 by dan thompson in ue5-release-engine-test branch]
2021-08-18 13:37:23 -04:00
dan thompson
52f17b8039 Bink Audio support for >48khz. Well... support in that they play, however Bink Audio (like most perceptual codecs) don't bother to send such high frequencies, so I add a warning to resample down prior to encoding. It's just a waste of performance.
This looks like a large change but the relevant change is binka_ue_file_header.h. Then rebuilt libs, and a bunch of source changes that never made it over in the initial checkin.

#jira UE-119962
#preflight 60fb20bc391d460001ff28a5

#ROBOMERGE-SOURCE: CL 16942270 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)

[CL 16942289 by dan thompson in ue5-release-engine-test branch]
2021-07-23 17:32:58 -04:00
dan thompson
d7eb3b2389 Removing IStreamedCompressedInfo::SampleRate as it was almost never set, was a bad bit depth, and never read globally.
#rb aaron.mcleron
#pf 60f9f43a1f926d0001f7d730

#ROBOMERGE-SOURCE: CL 16938497 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)

[CL 16938502 by dan thompson in ue5-release-engine-test branch]
2021-07-23 12:40:27 -04:00
dan thompson
642a54b83c Removing Stale Bink Audio Headers
#ROBOMERGE-SOURCE: CL 16684446 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16684453 by dan thompson in ue5-release-engine-test branch]
2021-06-16 01:11:38 -04:00
dan thompson
9778fd186b Moving Bink Audio SDK out of ThirdParty #pf 60c96e1ff7cffb00017213ef
#ROBOMERGE-SOURCE: CL 16684298 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16684303 by dan thompson in ue5-release-engine-test branch]
2021-06-16 00:36:49 -04:00
dan thompson
24825ae911 Bink Audio :: 2/4 :: Decoder :: #pf 60aea2116905a6000136901e #pf 60c8e2ae86ce760001d99596
Unreal part of the decoder, linking against the SDK from checkin 1/4. This code handles the file/block parsing, as well as seek table access.


#ROBOMERGE-SOURCE: CL 16677900 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16677902 by dan thompson in ue5-release-engine-test branch]
2021-06-15 15:25:50 -04:00