Commit Graph

255 Commits

Author SHA1 Message Date
phil popp
b5438f5ef5 Fix for CDO attempting to access MetaSound asset manager
#rnx
#jira UE-167130
#preflight 63487af4f622f6c4bbe1675e

[CL 22526957 by phil popp in ue5-main branch]
2022-10-14 10:55:37 -04:00
phil popp
07800695cd Replace use of FSoftObjectPath with UPROPERTY for dependent metasound assets.
#jira UE-156087
#rb rob.gay
#preflight 634841dffd22d1fbde5d7d73

[CL 22512918 by phil popp in ue5-main branch]
2022-10-13 17:38:11 -04:00
sondra moyls
b0598a048e - Fix for off by one on looping Sound Waves in MetaSounds
- Fixed typo in Nearly Finished tooltip
#jira UE-160453
#preflight 6340b297090af7205c2a1a35
#rb phil.popp

[CL 22488819 by sondra moyls in ue5-main branch]
2022-10-12 19:51:02 -04:00
phil popp
25b5881f1c Remove 5.0 channel format from MetaSoundSource and MetaSound WavePlayer node.
#jira UE-161170, UE-161172
#rnx
#preflight 63460236b757820b7aa1fdd2
#rb helen.yang

[CL 22482360 by phil popp in ue5-main branch]
2022-10-12 14:07:25 -04:00
rob gay
84771db13f Remove input receive node injection by implementing receive implementation within non-ctor input node operator
#rb phil.popp
[REVIEW] phil.popp
#rnx
#jira UE-166569
#preflight 63445c0f360ee7edea15afdb

[CL 22437484 by rob gay in ue5-main branch]
2022-10-10 15:44:28 -04:00
rob gay
4717e1f676 [MetaSounds] Fix sync not working in wavetable sampler.
- Minor clean-up & description updates
- Make sync advanced pin
#rb
#jira UE-160918
#rnx
#preflight 633629a02f447ea8dc330b41

[CL 22271333 by rob gay in ue5-main branch]
2022-09-30 11:18:31 -04:00
rob gay
08f64dc10a [MetaSounds] Param loop virtualization fixes
- Split default param transmitter to SoundCueTransmitter & ParameterTransmitterBase to avoid generating transmitters for SoundBase child classes that don't support/require one (ex. SoundWaves)
- Move param transmitter to sharedptrs to avoid a bunch of unnecessary copy/clone logic when virtualizing loops
- Remove DefaultParameters field on ActiveSound in favor of shared impl in FParameterTransmitterBase that caches current state of parameters
- Fix for move that clears out active sound's current parameters when sound could have multiple wave instances that need said parameters
#rb phil.popp
#jira UE-164898
#preflight 6334a0a1ee7b13756dcd20ea

[CL 22240385 by rob gay in ue5-main branch]
2022-09-28 22:19:31 -04:00
bryan sefcik
50d4fac9e0 Updated ../Engine/Plugins/... to inline gen.cpp files
Before:
3548 unity files
Total CPU Time: 47343.578125 s
Total time in Parallel executor: 494.60 seconds

After:
3445 unity files
Total CPU Time: 46044.671875 s
Total time in Parallel executor: 468.51 seconds

#jira
#preflight 63336159b20e73a098b7f24f

[CL 22218213 by bryan sefcik in ue5-main branch]
2022-09-28 01:06:15 -04:00
phil popp
2e184292d0 Fix for inconsistent metasound wave seek functionality
#jira UE-141007
#rb Max.Hayes
#preflight 6331d34ed747fe52c8ac4344

[CL 22191815 by phil popp in ue5-main branch]
2022-09-26 15:21:29 -04:00
rob gay
9dbc0c6693 [MetaSounds] Editor Graph Syncronization Upgrade
- Move synchronize/details panel flag to more generic ModifyContext
- Do not use MarkAsGarbage as means of enforcing not to show object in details panel to avoid leaving objects in invalid state if undo called. Check ed graph membership instead
- Get rid of leaky namechanged delegates
    - Allows for migration to isolated synchronization in the future
    - Removes conflation of having to synchronize and update views when modifying frontend document
    - Decouples concept of a specific view to update from generic frontend graph modifications
#rb helen.yang
#jira UE-151448
#preflight 632b7afdc7791417aa44126f

[CL 22142063 by rob gay in ue5-main branch]
2022-09-22 15:02:24 -04:00
phil popp
1cd4208860 Make MetaSound parameter error logs into warnings
Add log warning when constructor input value is ignored on runnign instance.
#jira UE-162285
#rb Rob.gay
#preflight 632b4cf72c7bc831f867d2c1

[CL 22121048 by phil popp in ue5-main branch]
2022-09-21 15:42:38 -04:00
rob gay
31435d69a5 Fix bug with synchronization not being completed prior to validation for referenced MetaSound graphs
TLBSRA (Too long but still read anyway)
This was due to validation moving to recursive behavior but sync not to support bubbling up referenced errors/warnings in 5.1.  This resulted in missing members after interface transforms are applied and potentially hitting ensures in validation.
...
But wait there's more!!! Synchronization on tick is now more efficient as it doesn't attempt to resynchronize/validate references already synchronized/validated in prior pass in same frame due to referencing graph needing to sync

#rb helen.yang
#rnx
#jira UE-162586
#preflight 63223e6c29254beccbf06119

[CL 22019580 by rob gay in ue5-main branch]
2022-09-14 18:49:46 -04:00
robert millar
aa6e458004 FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for Metasound.

#jira UE-161932
#rb none
#preflight https://horde.devtools.epicgames.com/job/631f7da6a9331c69c3aa4ac5

[CL 21976387 by robert millar in ue5-main branch]
2022-09-12 19:52:49 -04:00
rob gay
1a998981b7 Update details on MetaSound Editor synchronization
- Minor clean-up: remove unimplemented GetBlockRate declaration cruft
#rb trivial
[FYI] helen.yang
#jira UE-151420
#preflight 631a3fe3967ffc68fbea8026

[CL 21910442 by rob gay in ue5-main branch]
2022-09-08 21:27:29 -04:00
helen yang
d14412ac5b Rename MetaSound cvars for consistency, fix typos
#jira none
#rb trivial
#preflight 630d758d556fc14dce5ad10c

[CL 21707153 by helen yang in ue5-main branch]
2022-08-30 15:11:11 -04:00
Rob Gay
25826b9069 Summer Cleaning
- Rename MetasoundArchetype Source file to MetasoundFrontendInterface
- Move MetaSound interface files to subdirectory.
- Break out document versioning transforms to own impl/header
#rb todo
#rnx
#jira none
#preflight 62fed263200ff87e07d77340

[CL 21458865 by Rob Gay in ue5-main branch]
2022-08-19 12:14:31 -04:00
phil popp
5fc6f172c9 [MetaSound] Allow Constructor pin to be set from BP
#rb Rob.Gay
#jira UE-153913
#preflight 62fe6e68f7404b55a3fd49f9

[CL 21445924 by phil popp in ue5-main branch]
2022-08-18 13:55:13 -04:00
anna lantz
19aa2b8ac1 Adding tags to MetaSound nodes
#jira UE-157173
#rb Rob Gay
#preflight 62fd50f5830482fd822493e8

[CL 21431230 by anna lantz in ue5-main branch]
2022-08-17 16:42:56 -04:00
Rob Gay
6227019354 Tooltip fix
#rb trivial
#rnx
#preflight skip
#jira none

[CL 21417015 by Rob Gay in ue5-main branch]
2022-08-16 19:21:52 -04:00
Rob Gay
91f483272f Fix channel offset not updating/offset being incorrect when authoring wavetable entries
#rb trivial
#rnx
#jira UE-160801
#preflight 62fbe8930f2aefc97a78de2a

[CL 21412144 by Rob Gay in ue5-main branch]
2022-08-16 15:37:37 -04:00
phil popp
cf0b29a549 Support more audio channels in wave player node.
#rb Maxwell.Hayes, miles.flanagan
#jira UE-147036
#preflight 62fbbcb21e39eb26a0414cfb

[CL 21407206 by phil popp in ue5-main branch]
2022-08-16 12:39:27 -04:00
Rob Gay
3151e150fc Minor tooltip fix-up for the WaveTableEnvelopeNode
#rb trivial
#jira UE-160803
#rnx
#preflight skip

[CL 21397215 by Rob Gay in ue5-main branch]
2022-08-15 19:29:27 -04:00
phil popp
20d9fe84b6 MetaSound Source Surround Channel Format Support.
#rb Rob.Gay
#jira UE-150587
#preflight 62fa5557153b17e746323904

[CL 21386849 by phil popp in ue5-main branch]
2022-08-15 10:49:30 -04:00
Rob Gay
43065604d6 Rename UMetaSound to UMetaSoundPatch
#jira UE-150599
#rb helen.yang
#preflight 62f69d471e61d1ba0e8e37e5

[CL 21360370 by Rob Gay in ue5-main branch]
2022-08-12 14:54:54 -04:00
Rob Gay
87f810eadf MetaSound Template nodes
#rb phil.popp
#jira UE-160476
#preflight 62f3f49df75a2a539c8b4973

[CL 21322540 by Rob Gay in ue5-main branch]
2022-08-10 14:18:10 -04:00