Commit Graph

55 Commits

Author SHA1 Message Date
ben hoffman
f180f2cf58 Add a name validator to player mappable setting names. This makes it easier to avoid mistakes and possibly stomping a key binding.
The "Name" here is the FName that will be used as a key to save each key mapping during serialization, so they should be unique for each key mapping that you want the player to be able to set.

#jira UE-177248
#preflight 63f4ef2290198dffba48f6ee
#rb benjamin.fox
#rb nate.strohmyer
#rnx

[CL 24344605 by ben hoffman in ue5-main branch]
2023-02-21 13:37:27 -05:00
ben hoffman
c7be5a35ea Deprecate the old FPlayerMappableOptions struct in favor of the more extensible PlayerMappableKeySettings.
Automatically populate the newer player mappable key settings based on any old data in the player mappable options.

Clean up call sites to the now deprecated stuff

#jira UE-175936
#rb benjamin.fox
#rnx
#preflight 63e54d307250a911fa85d9f7

[CL 24135344 by ben hoffman in ue5-main branch]
2023-02-11 11:38:39 -05:00
ben hoffman
a7e0d55954 Only attempt to auto upgrade to Enhanced Input if the project has a name. This solves an issue where you would get toasts about EI from the project launcher.
#jira UE-176155
#rb justin.hare
#pf 63e1344b797b029c0a65d67c

[CL 24034353 by ben hoffman in ue5-main branch]
2023-02-06 13:38:52 -05:00
nate strohmyer
80a4c6d6b8 Combo trigger Improvements.
Fixing issues with combo triggers being overriden
Can specify events that progress/cancel combo
some smaller UX fixes

#Jira UE-170233, UE-169334
#rb ben.hoffman
#preflight 63bf4f87c543a64b7d7320f6

[CL 23747881 by nate strohmyer in ue5-main branch]
2023-01-17 18:37:06 -05:00
henrik karlsson
3c9aacb1ad [Engine/Plugins]
* Updated public headers for ~170 engine plugins using iwyu to remove includes not needed. Removed includes are still available behind UE_ENABLE_INCLUDE_ORDER_DEPRECATED_IN_5_2

#preflight 63c08f4a2a6acaf1622bcc73
#rb none

[CL 23674775 by henrik karlsson in ue5-main branch]
2023-01-13 01:54:01 -05:00
henrik karlsson
2f78497e67 [Engine/Plugins]
* Updated private files with IWYU for all plugins which had 3 or less changes made in ue5 main since last integration to fn

#preflight 63bf8d8b577437afe607dc72
#rb none

[CL 23659643 by henrik karlsson in ue5-main branch]
2023-01-12 01:48:34 -05:00
nate strohmyer
e9f8692c7c Fixing action value type toast showing up when modifying triggers
#Jira UE-171429, UE-171434
#rb ben.hoffman
#preflight 6397cb4c35203bc7aa2aaaec

[CL 23601507 by nate strohmyer in ue5-main branch]
2023-01-06 14:37:17 -05:00
bryan sefcik
d68153a097 Moved some of the logic from GatherClassDetailsCDOs to CustomizeDetails so the expensive operations that could be shared were done once.
Before: 359ms
After: 181ms

#jira
#rb nate.strohmyer
#preflight 638652a133774509007479bc

[CL 23316931 by bryan sefcik in ue5-main branch]
2022-11-29 15:52:36 -05:00
nate strohmyer
0687afefe8 Updating Input Mapping Contexts when Input Action triggers/modifiers are modifiied
#Jira UE-169062, UE-169058
#rb ben.hoffman
#preflight 63699ba57c2b50519067e1e2

[CL 23159625 by nate strohmyer in ue5-main branch]
2022-11-16 14:44:56 -05:00
nate strohmyer
c4b2e38146 Making a Drag/Drop action for Input Actions into the Blueprint Graph
#Jira UE-161947
#rb ben.hoffman
#preflight 635c52813c0af539fd66d17c

[CL 23040016 by nate strohmyer in ue5-main branch]
2022-11-08 16:28:09 -05:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
Zousar Shaker
0c39ca3ae9 Fix encountered instances of TObjectPtr<T> used with T that is not derived from UObject. A subsequent change will be disallowing this at compile time.
#rb none
#preflight 6362a7ae54471d10be04e7a9

[CL 22921150 by Zousar Shaker in ue5-main branch]
2022-11-02 13:45:42 -04:00
nate strohmyer
14f19c6143 Displaying Input Action Triggers/Modifiers in Input Mapping Contexts to improve clarity
#Jira UE-161060
#rb ben.hoffman
#preflight 63582216e9227c91a6b1d262

[CL 22890126 by nate strohmyer in ue5-main branch]
2022-11-01 16:01:14 -04:00
michel champoux
1e995ee48b - Created instanced mappable key settings that can be overridden to add per project functionality.
- Instanced mappable key settings are fetched based on a setting behavior enum.
    - InheritSettingsFromAction to use the setting defined by the action
    - OverrideSettings to override the settings defined in the action, and use the ones defined in the action key mapping.
    - IgnoreSettings to ignore settings completely for this action key mapping.
- Added blueprint facing helper functions to accessing mappable key settings.
- Shifted over data validation in to the Action Key Mapping.

#rb [at]Mic.Rooney, [at]Pamela.Figueroa, [at]Ben.Hoffman

[CL 22850406 by michel champoux in ue5-main branch]
2022-10-29 01:42:11 -04:00
ben hoffman
de0a9a868f Create a "Default Input Mapping Contexts" developer setting. This will let users specify a default set of Input mapping contexts without the trouble of getting the player controller in blueprints or c++
#rb ben.zeigler
#preflight 635804a866733d70593d6e2a

[CL 22803114 by ben hoffman in ue5-main branch]
2022-10-26 22:30:33 -04:00
henrik karlsson
4a5e13525d Fixed non-unity non-pch compile errors
#preflight skipped
#rb none

[CL 22788359 by henrik karlsson in ue5-main branch]
2022-10-26 16:22:34 -04:00
nick darnell
954d29b9f5 Editor - Beginning the process to no longer make loading all assets you right click in the content browser. The first step, is setting up the code to have a deprecation flag DEPRECATE_ASSET_TYPE_ACTIONS_NEEDING_LOADED_OBJECTS, this will make it illegal to implement GetActions on all AssetTypeAction implementations. Checked in disabled, enable it locally to begin trying to implement the recommended method detailed in the IAssetTypeActions header. WIP. One of the things this change does is outlaw (regardless of deprecation) the HasActions() function, this function is no longer used at all, and so we may as well remove its implementation, it also works well as a canary in finding other samples and things that need to be upgraded.
#jira UE-165574
[REVIEW] [at]Rex.Hill, [at]Lauren.Barnes
#preflight 63483c43ad0f7e2f20e44910

[CL 22534452 by nick darnell in ue5-main branch]
2022-10-14 16:59:41 -04:00
ben hoffman
5ca91ed034 Check to make sure there is a valid world on the Enhanced Input editor subsystem before attempting to input the key. The world can be invalid if you leave the subsystem processing input while you resave different maps in the editor.
#jira UE-156093
#rb david.hibbitts
#rnx
#preflight 633b2c22b12b8af5fdf7ada5

[CL 22323380 by ben hoffman in ue5-main branch]
2022-10-03 21:13:56 -04:00
nate strohmyer
e853e09d1b Renaming Combo Trigger Input Trigger to fix a compile error when opening Lyra
#Jira UE-165545
#rb ben.hoffman
#preflight 6337346fb34118b9b4b792c9
#rnx

[CL 22322193 by nate strohmyer in ue5-main branch]
2022-10-03 20:37:03 -04:00
bryan sefcik
50d4fac9e0 Updated ../Engine/Plugins/... to inline gen.cpp files
Before:
3548 unity files
Total CPU Time: 47343.578125 s
Total time in Parallel executor: 494.60 seconds

After:
3445 unity files
Total CPU Time: 46044.671875 s
Total time in Parallel executor: 468.51 seconds

#jira
#preflight 63336159b20e73a098b7f24f

[CL 22218213 by bryan sefcik in ue5-main branch]
2022-09-28 01:06:15 -04:00
Mike Beach
706505599a Providing a hook for external sources to override the editor's main window, much like the project browser does. Allows plugins to provide their own kind of "start up check" dialog.
Switching over the project browser dialog to use the new system.

#rb Lauren.Barnes
#preflight 63293e08b40000c8f04da02a
#preflight 6329eb72fc7f1efbdf479b84

[CL 22100188 by Mike Beach in ue5-main branch]
2022-09-20 15:34:49 -04:00
nate strohmyer
fad5ae0c44 Enhanced Input: Add class picker for Input Action and Input Mapping Context factories (Contributed by aquanox)
#Jira UE-163457
#rb ben.hoffman
#preflight 6329ef49f87253e0211ce2e9
#9557

[CL 22098175 by nate strohmyer in ue5-main branch]
2022-09-20 14:16:40 -04:00
bryan sefcik
0eeac455e0 Pass 3 on cleaning up build.cs files.
#jira
#preflight 631b9c15d31788ea3ab0f27b

[CL 21935601 by bryan sefcik in ue5-main branch]
2022-09-10 00:02:58 -04:00
nate strohmyer
8dbfbf8d97 Make mapped key tooltip more helpful when disabled from a combo trigger
#Jira UE-163036
#rb ben.hoffman
#preflight 631a47ea2b7fe03eb6c064b9

[CL 21929870 by nate strohmyer in ue5-main branch]
2022-09-09 18:18:06 -04:00
nate strohmyer
652f6fc5d2 Making it clear that a key is not necessary/usable for Combo actions
#Jira UE-159662
#rb ben.hoffman
#preflight 63042600a45b007ea25c622f

[CL 21767915 by nate strohmyer in ue5-main branch]
2022-09-02 17:16:33 -04:00