#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3780878 by Nick.Darnell
UMG - Providing more information when the compile fails to find a bindable widget.
Change 3780855 by Gil.Gribb
UE4 - Fixed a linear search in EDL that caused performance problems for very large maps. Saves half the load time in FN-BR.
Change 3780803 by Thomas.Sarkanen
Dont create animation tasks for skeletal meshes that have no anim instance
This avoids some wasted work for non-animated attachments, such as pickaxes
#jira FORT-61523 - Don't create anim worker tasks if no AnimBP
Change 3780741 by Yenal.Kal
#jira FORT-60177
Fixed the bug where the anim branching points (begin and end) may be triggered twice incorrectly.
Change 3780663 by Gil.Gribb
UE4 - Batching for audio thread commands.
Change 3780466 by Ben.Marsh
Add error matcher for generic Microsoft errors (eg. 'cl : Command line error D8049 : command line too long to fit in debug record')
Change 3779937 by Nick.Darnell
UMG - Adding an accessor on UUserWidget to get the owning player state easier, since it's a common operation.
Change 3779858 by Sam.Zamani
#http
use separate "-multihomehttp" instead of "-multihome" for routing http socket
#jira FORT-61666
#tests none
Change 3779288 by Michael.Trepka
Changed FMacConsoleOutputDevice::Serialize to use FString's GetNSString() instead of converting the string using FPlatformString::TCHARToCFString to make it safer in case of garbage text passed in Data
#jira FORT-59762
Change 3779062 by Mike.Fricker
Merged CL 3731188 and CL 3733311 from //UE4/Dev-Editor.
----
Improve responsiveness of Open Asset dialog.
On large projects, there's a noticeable delay when opening and searching/filtering assets.
Stopwatch measurements on my machine (seconds for ~122,000 assets):
before with this CL
ctrl-P 1.4 0.45
search 1.8 0.55
CollectionManagerModule was the main culprit for search/filter slowness.
Open Asset delay was due to filtering out plugin content. We were doing a lot of redundant work for what is essentially a read-only operation.
Change 3778954 by Nick.Darnell
Slate - Making the Horizontal and Vertical analog keys configurable in the navigation config. Tweaking how fast the navigation is with the analog stick, trying to tune the feeling.
Change 3778896 by Ben.Marsh
Separate FNameEntrySerialized from FNameEntry, rather than deriving from it. It has to be allocated differently, and many fields cannot be shared between the two.
#jira
Change 3778807 by Ben.Marsh
Fix Tencent include paths not registering if workspace directory contains a space.
Tencent include paths currently have a trailing backslash, and this is surrounded by quotes if the root directory contains a space. The backslash is interpreted as escaping the trailing double quote.
#jira
Change 3778686 by Luke.Thatcher
Reduced impact of dynamic vertex buffer RHI stall in D3D12
- In most cases we can avoid the stall if the vertex buffer has never been used before.
- Only when a buffer has an existing SRV do we need to stall.
- Also, delete copy and move constructors of FD3D12ResourceLocation. Moving or copying an instance of this class leads to double free crashes, so this is now a compile error rather than a runtime crash.
This saves an average of 2ms frame time in a StW lastperftest replay, with r.screenpercentage 10.
#jira FORT-61390
Change 3778679 by Thomas.Sarkanen
Fix Linux server crash - dont attempt to run threaded work in a single-threaded environment
We dont attempt to run animation update work multi-threaded in the same conditions that we didnt attempt to run animation eval work previously.
#jira FORT-61548
Change 3778591 by Ben.Woodhouse
Add build config to FPSChart HTML output
#jira FORT-56478
Change 3778175 by ben.marsh
Remove code to trigger an ensure on Arxan guards. We already send analytics for this, and don't need this legacy path. There is a large number of incoming ensures with this callstack that are clogging up crash reporter.
Will remove all the surrounding code in a later update to a development branch.
#jira
Change 3777750 by Chris.Gagnon
- Slate now supports a CustomBoundary Navigation type wich allows a custom handler if the boundary is hit.
- This provides the ability to have normal navigation while within the boundary and the custom function only on the boundary.
- This differs from Custom which is a full override of the navigation behavior.
Change 3777678 by Bob.Tellez
#UE4 Fix a bug that was causing fastpath nodes in non-nativized BPs to not be fastpath
Change 3776962 by Bob.Tellez
#UE4 Fix warning about missing virtual destructor by making a struct final (like other RHICommands)
Change 3776656 by Thomas.Sarkanen
Fix notifies not getting fired in cases where AlwaysTickPose was set on skeletal mesh components
This was causing AIs to get stuck in montage playback in some circumstances
#jira FORT-61324, FORT-60558
Change 3776655 by Bob.Tellez
#UE4 CIS fix after 3776629
Change 3776650 by Bob.Tellez
Counting uplugin and uproject files as code changes so UGS will trigger code builds on checkins containing these files
Change 3776649 by Nick.Darnell
UMG - Fixing a rare crash when destructing a widget in the designer. It's trying to remove widgets from a half garbage collected panel.
Change 3776629 by Bob.Tellez
#UE4 Using a more efficient data structure for keeping track of visited nodes when verifying EDL.
Change 3776328 by James.Golding
Add command line option (-statnamedevents) for enabling named events
Change 3776024 by Nick.Darnell
Slate - Adding an accessor to SSafeZone to get the amount of padding that will be added, given some scale.
Change 3775569 by Gil.Gribb
UE4 - Fixed bugs with r.DelaySceneRenderCompletion
Change 3775543 by Luke.Thatcher
[XBOXONE] [~] Remove stall in D3D12 CreateRHIBuffer
- Buffer update is enqueued as a task on the RHI thread instead of stalling the RHI thread for the duration of the update.
Change 3775488 by Thomas.Sarkanen
Prevented skeletal meshes that are not being ticked due to URO from dispatching tick tasks
#jira FORT-61157 - Run anim update on worker, even if not visible
Change 3775219 by Bob.Tellez
#UE4 Dont SerializeThumbnails when calling savepackage while editoronly data is excluded (cooking). This saves a lot of memory while cooking
Change 3774886 by Mike.Fricker
Fixed occasional crash when backing out to lobby
- Don't force DF data to be updated when the mesh isn't in the world or has no scene interface
#jira FORT-60863
Change 3774767 by Ori.Cohen
Fix race condition for creating statid in test configs
Change 3774682 by Bob.Tellez
#UE4 Don't bother clearing cached platform data during shutdown purge since there may be a lot of it and it takes a while to destroy it.
Change 3774621 by Bob.Tellez
#UE4 Move Tree rebuilding during cook from Serialize to PreSave to avoid building the tree multiple times for a single platform. Also properly clear out CacheMeshExtendedBounds.
Change 3774201 by Gil.Gribb
UE4 - Fixed rare crash caused by unmounting pak files.
Change 3773920 by Gil.Gribb
UE4 - Added experimental option r.StartPrepassParallelTranslatesImmediately which allows the parallel translate tasks from the prepass to start before we init shadows. Disabled by default.
Change 3773896 by Thomas.Sarkanen
Push non-rendered anim updates back onto the worker thread
Now when meshes are set to EMeshComponentUpdateFlag::AlwaysTickPose, we optionally kick of a task to perform parallel update only (no evaluation).
#jira FORT-61157 - Run anim update on worker, even if not visible
Change 3773886 by Gil.Gribb
UE4 - Reduced r.RHICmdMinCmdlistForParallelSubmit from 2 to 1.
Change 3773882 by Gil.Gribb
UE4 - Improved profiler markers when they are used without stats to cover the task graph and some things related to the parallel renderer.
Change 3773461 by Gil.Gribb
UE4 - Increased the granularity of the ParallelFor blocks for greater load balancing.
Change 3773459 by Gil.Gribb
UE4 - Adds TLS caches for MallocBinned2 to the Audio thread.
Change 3773458 by Gil.Gribb
UE4 - Added an experimental option to do the slate render before waiting for the rendering tasks.
Change 3773011 by Robert.Manuszewski
Header (uasset) and export (uexp) files will now be compared seperately when running cook commandlet with -diffonly to avoid situations where a mismatch in size of the header produces more differences between exports.
+ Renamed ini setting to ignore header differences from SkipHeaderDiff to IgnoreHeaderDiff
Change 3772867 by Thomas.Sarkanen
Nativization now correctly generates and builds code for "Client" builds
Overall this is a bunch of hacks, but necessary for nativization to work at present. Once the cooker and UAT both have a concept of "Client" targets, this can be implemented properly.
Instead of building to a "Client" directory, we build to "Game" for client-only platforms (like PS4, XboxOne)
Also we need to add "Client" targets to the whitelist for the nativized assets plugin, as UBT still thinks it is building for "Client"
#jira FORT-52823 - Nativizing Player Animation Blueprints
Change 3772408 by Robert.Manuszewski
Cook commandlet will now report full property name when running a diff against the existing cook (-diffonly)
Change 3772359 by Thomas.Sarkanen
Improvements to the Cpp backend to allow VC++ to compile nativized code more effectively
Added a new scoped helper to wrap areas of the code in PRAGMA_DISABLE_OPTIMIZATION. This helps with functions that are large tables or long lists of initializations.
Split anim node initialization up into functions, called from a seperate function dedicated to initializing anim nodes. This splits the 5k+ line constructor into mutiple smaller functions, which the compiler has no problems with.
Overall (along with splitting up the anim BP into functions in the asset) this reduces compilation time for the worst-case compilation unit from ~11m 40s to ~2m 32s.
#jira FORT-52823 - Nativizing Player Animation Blueprints
Change 3771975 by Zak.Middleton
Fix character proxies doing up to two floor check when only rotation changes. Add some optional verbose logging to FindFloor() and ComputeFloorDist().
#jira FORT-61134
Change 3771421 by Ori.Cohen
Fix CIS
Change 3771052 by Robert.Manuszewski
Package diff improvements (-diffonly mode for cooker). Exposed max diffs to report to ini and added the ability to suppress header differences reporting as they are usually a result of differences in exports anyway.
Change 3771039 by Bob.Tellez
#UE4 Allowing use of -FPS in PGO profile builds
Change 3770747 by Ori.Cohen
Added missing stat named events for anim bp
Change 3769616 by Arciel.Rekman
UBT: Use response files for compiler when compiling for Linux.
- Some command lines are too long when cross-compiling on Windows, which is a problem for non-unity builds (or local changes that result in exclusion of checked out files from the lumped units).
Change 3769457 by Gil.Gribb
UE4 - Added eviction to r.DoLazyStaticMeshUpdate. It just removes 10 prims a frame in a rolling fashion.
Change 3769136 by Michael.Noland
Engine: Improve IsServerDelegateForOSS to allow it to use the play world during PIE even if no context was passed in
Change 3768736 by Robert.Manuszewski
More debug info for ensure in FLinkerSave when a name that has not yet been mapped is being serialized
#jira FORT-60943
Change 3768634 by Robert.Manuszewski
Small optimization to FEDLCookChecker::Verify function
Change 3768603 by Robert.Manuszewski
Merging CL #3766740 by Steve.Robb
TMultiMap::Append added.
Change 3768586 by Ben.Woodhouse
csv profiler screen message
Change 3768506 by Thomas.Sarkanen
Duplicating CL 3764661 from Paragon:
Only update Children attached to Sockets in USkeletalMeshComponent::PostBlendPhysics().
Saves ~20% of STAT_UpdateChildTransforms and ~10% of STAT_UpdateLocalToWorldAndOverlaps in 5ofEach_Dusk_vs_Dusk automation test.
#jira OR-46341
#tests LaneMinionFXTests, monolith w/ full teams.
Change 3768504 by Thomas.Sarkanen
Duplicating CL 3758315 from Paragon:
Optimized PostAnimEvaluation when URO is skipping a frame with no interpolation. Skip unnecessary work.
PreEvaluateAnimation() is now only called if we're about to evaluate anims. PostEvaluateAnimation() is also called only if we have evaluated animations.
Therefore PostEvaluateAnimation() has been pulled inside of PostAnimEvaluation() instead of FinalizeTransforms.
Added a call to ConditionallyDispatchQueuedAnimEvents() in the event that we're not calling PostBlendPhysics because we have not evaluated or interpolated anims.
Added missing call to PostEvaluateAnimation() for PostProcessAnimInstance.
#jira OR-46341
#tests minion FX perf map, lane minion test map, monolith match with 2 full teams.
Change 3768097 by Bob.Tellez
#UE4 Fix non-editor CIS
Change 3767957 by Bob.Tellez
#UE4 Fix an issue that was causing FullLoadAndSave to fail to cache platform data for textures that were created by landscape on mobile and another issue that caused parallel saving to fail in landscape (when cooking for mobile targets)
Change 3767906 by Mike.Fricker
Add Blueprint functions to query parameters from MIC
- GetScalarParameterValue
- GetTextureParameterValue
- GetVectorParameterValue
MIDs already had these functions, but MICs did not.
Change 3767737 by Max.Preussner
Engine: Fix for external textures referenced by a material before being associated with a media player never having their uniform expressions recached
#author jack.porter
#jira FORT-59777
Change 3767735 by Bob.Tellez
#UE4 Setting Opened to false in FOutputDeviceFile::TearDown so if the device file gets initialized again it will do the same initialization logic as the first time.
#jira FORT-60918
Change 3767244 by Ethan.Geller
#jira FORT-60885 Merge in fix for memory leak from 4.18.1.
Change 3766567 by Marc.Audy
Fix initialization ordering warnings
Change 3766443 by Jian.Ru
Submit PSO locking fix again as it has passed local tests
Change 3766362 by Ori.Cohen
Added the ability to get concurrent captures in Test configurations without having to turn full stats on
Change 3766277 by Marc.Audy
Shrink Skinned and Skeletal Mesh Component, FBodyInstance, and UBodySetup
Change 3766275 by Marc.Audy
Better pack UTexture* classes
Change 3766272 by Thomas.Sarkanen
Fixes to enable auto-nativization for animation blueprints
For blend profiles in particular, I've added subobject support to the fake import table building for nativized assets:
- In FEmitterLocalContext::FindGloballyMappedObject, if we dont find the referenced asset then we traverse the object's outer chain if it is a subobject. We add it to UsedObjectInCurrentClass if we find its outer.
- Updated the structure used to build the fake import table to include a specified outer. Beforehand we assumed that all objects referenced by the import table were 'top-level'.
- Updated the fake import table building code in FLinkerLoad::CreateDynamicTypeLoader() to use the new specified outer if found. This asserts if it couldnt find the outer in the already-parsed dependencies (as it reverse-iterates). If in the general case thius turns out to be a problem we can move this to a two-pass system.
Disabled fast-path optimization when running a native anim BP, as native code is faster!
#jira FORT-52823 - Nativizing Player Animation Blueprints
#jira FORT-57378 - Perf optimization: animation blueprint improvements
Change 3766215 by Marc.Audy
Shink FFromatContainer from 88 bytes to 24 by storing in TSortedMap instead of TMap
Change 3765664 by Michael.Noland
Engine: Add support for sets to FJsonObjectConverter::JsonValueToUProperty
Change 3765624 by Marc.Audy
Create helper macro in Archive.h for encapsulating needed steps for serializing a bitpacked boolean
Change 3765200 by Nick.Darnell
Slate - Fixing a memory leak in the invalidation panel. It never cleared out the cached textures and materials it kept alive during retention.
Change 3764881 by Wes.Hunt
Fix FApp::Get/SetIdleTimeOvershoot. It was overwriting IdleTime, which made FrameTimeWithoutSleep look like FrameTimeWithSleep.
#jira FORT-60585
#review-3764882 @arciel.rekman
Change 3763872 by Max.Chen
Sequencer: Set default completion mode for all sections to project default.
Copy from Dev-Sequencer
#jira UE-49480
Change 3763871 by Max.Chen
Sequencer: Add config for default completion mode for movie scene sequences. The default for level sequences is RestoreState. All others, such as UMG are set to KeepState.
Copy from Dev-Sequencer
#jira UE-49480
Change 3763810 by Gil.Gribb
UE4 - remove some init timing spew in programs (i.e. UHT)
Change 3762939 by Robert.Manuszewski
Removing all locks from FEDLCookChecker to improve SavePackage performance
Change 3762851 by Bob.Tellez
Duplicating CL#3740778 from //UE4/Dev-Editor
Fixed issue with content browser column sorting
#jira UE-49460
Change 3762660 by Bob.Tellez
#UE4 Fix a few parallelsave threading problems.
Change 3761861 by Marc.Audy
Fix archive complaints about bitfield
Change 3761802 by Marc.Audy
Pack FTimeline, FHitResult, FAnimUpdateRateParameters, FMeshBuildSettings
Change 3761299 by Matt.Kuhlenschmidt
Fix levels not being lockable/unlockable if they are not checked out
#jira FORT-60086
Change 3760422 by Bob.Tellez
#UE4 Stop caching or clearing platform data when saving concurrently. This was causing threading problems in materials.
Change 3760113 by Jian.Ru
Back out changelist 3759715 as it causes a crash on UGS autotest
Change 3759761 by Jian.Ru
Clean up some debug comments
Change 3759715 by Jian.Ru
Removing excessive locking when accessing PSO caches.
Change 3759285 by Nick.Darnell
Editor - Fixing the length of the datatable row dropdown in the editor.
Change 3758334 by Alexis.Matte
Fix a crash when importing morph target there was a unsync between some buffer depending on the import options
#jira UE-52319
Change 3758332 by Ben.Marsh
Fix output subfolder being appended twice when generating project files. Causes incorrect command line when launching from Visual Studio.
#jira
Change 3758215 by Brian.Bekich
Make Tint property of FSlateBrush NotReplicated now that it is WITH_EDITORONLY_DATA so that cooked clients can connect to uncooked servers
Change 3757702 by Bob.Tellez
#UE4 Fix -NoConcurrentSave cook option in FullLoadAndSave
Change 3757545 by ben.marsh
Suppress Arxan warning about being unable to install a default guard at it's default location.
Change 3757452 by Aaron.McLeran
#jira FORT-59675 Client Crash in __delayLoadHelper2()
Fixing build error on linux.
Change 3757389 by Hongyi.Yu
Fixed the crash in UEditorEngine::CheckForWorldGCLeaks() when load a level (level A), PIE, load a sublevel of level A and then load another level.
#jira FORT-58283
Change 3757229 by Aaron.McLeran
#jira FORT-59675 Client Crash in __delayLoadHelper2()
Change 3757077 by Max.Preussner
MediaAssets: Fix for media texture crashing if media player is generated from GC clustered blueprint
#jira FORT-59774
#jira UE-51943
#tests none
Change 3756854 by Mike.Fricker
Fix "double-delete" crash when using level streaming
- Backed out unintentional network checksum change!
Change 3756790 by Bob.Tellez
#UE4 Fix inconsistency with how FSoftObjectPtr case is managed between FLinkerSave and FArchiveSaveTagImports, which would cause a cook ensure under some circumstances
Change 3756639 by Arciel.Rekman
Pool memory (only 64KB allocations) on servers (FORT-60342).
- Has a fixed cost of 1GB virtual memory usage.
#jira FORT-60342
Change 3755995 by Alexis.Matte
Fix crash when importing morph target with "built in" tangent option
#jira UE-52319
Change 3755896 by Arciel.Rekman
Remove unnecessary switch for profiling (part of FORT-58878).
- -fno-omit-stack-pointer is only needed when getting callstacks for perf.
#jira FORT-58878
Change 3755711 by Mike.Fricker
Fix "double-delete" crash when using level streaming
- Initialize network GuidCache entries as soon as Guids are registered on the server so that we can fill them out with valid information before the object is destroyed. Fixes issues when a guid is exported for the first time to send a destroy to clients. (from RyanG)
Change 3755701 by David.Ratti
FObjectReplicator no longer a GCObject since adding/removing from the global GCObject list is too slow. Managing FObjectReplciators's object references at the NetDriver level now.
#jira FORT-60317
#review-3755702 @Ryan.Gerleve
Change 3754928 by Arciel.Rekman
Linux: add LTO support and more.
- Adds ability to use link-time opitimization (reusing current target property bAllowLTCG).
- Supports using llvm-ar and lld instead of ar/ranlib and ld.
- More build information printed (and in a better organized way).
- Native scripts updated to install packages with the appropriate tools on supported systems
- AutoSDKs updated to require a new toolchain (already checked in).
- Required disabling OpenAL due to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219089
#jira FORT-58878
Change 3753986 by Ben.Zeigler
#jira UE-45505 Fix issue where FCoreUObjectDelegates::OnAssetLoaded was being called from an inner loop inside EndLoad. Maps would register components from that callback, and if those registers started their own loads, those objects would be returned in a partially loaded state. We now defer the asset loaded callback to the very end of the loop so recursive loads work properly
Change 3753274 by Ben.Marsh
Fix blank lines in errors and warnings being omitted from notification emails.
#jira
Change 3753175 by Thomas.Sarkanen
Fix hang in animation editor menus
Sound waves were being loaded by the visibility delegate for the 'play' button overlay. This caused major hangs as the ogg compressed data was built on the fly. Handled the unloaded asset case in the various delegates.
Also made the menu larger, as picking a sound wave was all but impossible when you couldnt even see one in the list.
#jira UE-52271 - Persona menu option locks up editor
Change 3752887 by Nick.Darnell
Slate - Adding automatic invalidation to a few more widgets that were found lacking when adding or removing children.
Change 3752785 by Marc.Audy
Avoid doing any work to evaluate streaming volumes if there are no player controllers using streaming volumes
Change 3752185 by Ben.Marsh
Reduce cook time regression caused by correcting package names to match case on disk (to fix deterministic cooking problems). Switched to use IPlatformFile::GetFilenameOnDisk(), and improved performance of FWindowsPlatformFile::GetFilenameOnDisk() by using GetFinalPathNameByHandle() instead of recursively searching up the directory tree.
#jira
Change 3751813 by Ben.Marsh
Improve parsing of diagnostics for deterministic cooking test. Now allows multiple lines in the generic EC error/warning matcher if indented more than the first line, and skips over empty lines.
#jira
Change 3750413 by Ben.Zeigler
Fixes for cook save performance regressions. Add GetAllMarks to object and use that to dramatically reduce contention for the object mark annotation. Implement ShouldLoadForServer/Client directly on some core classes to stop it from calling the slow generic one
Fix issue where refreshing tags for asset registry would do a very slow array delete/add
Improve speed of redirectcollector, there's no need to force-rehash the soft object path list as the remove handles it conditionally
Change 3750014 by Lina.Halper
- duplicate change from following changelists
CL 3669273 - delete all tracks option
- allow to opt out on bone track importing
- fixed pose preview for fullbody to select weights that has pose from asset.
CL 3672170 Remove track support for Animation Blueprint Library
This is required for facial pose retargeting
Change 3749714 by Brian.Bekich
Back out changelist 3748287
#jira FORT-60125
Change 3749377 by Robert.Manuszewski
Improved log formatting for reporting deterministic cook issues.
#jira FORT-59919
Change 3749360 by Robert.Manuszewski
Improved performance of -diffonly mode for cook commandlet for assets with hundreds of thousands of differences.
#jira FORT-59919
Change 3748746 by Hongyi.Yu
Fixed compiling error in Automation project
#jira FORT-59621
Change 3748530 by Mike.Fricker
Fixed non-determinism of landscape grass across platforms/compilers
This causes bushes to be located in different places depending on what platform you were playing on.
1) Random number reseeds were happening as part of function arguments to FVector(), but function argument evaluation order is unspecified, and behaved differently on Consoles/Mac/Windows. Fixed this bug.
2) Strings used for foliage CRCs could use different character sizes on different platforms. Now we always use ANSI.
3) Strings used for CRCs could have possibly have different case. Now forced lowercase.
#jira FORT-60109
Change 3748471 by Zak.Middleton
Added stats to NetDriver TickFlush and stats gathering within that function.
Change 3748287 by Brian.Bekich
Adding net.MaxStringSerializationSize to cap maximum string read from network, default to 4096, used by FNetBitReader
Deprecating MAX_STRING_SERIALIZE_SIZE in favor of the cvar
FInBunch defaults to prior behavior if cvar is 0
UPackageMap::SerializeName and UPackageMapClient::SerializeNameAsString will always cap at NAME_SIZE
Check for path name serialization error before tryng to read checksum
#jira FORT-57974
Change 3747980 by Bart.Hawthorne
In Oodle, only generate and write dictionaries on Windows, Mac, and Linux
Change 3747642 by Gil.Gribb
Fix CIS
Change 3747635 by Zak.Middleton
Avoid string alloc on every ServerMove() call on the server.
Change 3747560 by Gil.Gribb
UE4 - Fixed XBox and Windows thread priorities. Only 2 though -2 seem usable and some of the old values were being ignored.
Change 3747548 by Gil.Gribb
UE4 - Changed thread pool to be TPri_SlightlyBelowNormal so that they will not preempt HP task graph tasks.
Change 3747544 by Bart.Hawthorne
When detecting if Oodle is installed, use the newest version instad of the oldest one.
Change 3746440 by Robert.Manuszewski
Dterministic cook issues reporting improvements
- Huge performance improvements
- Added new metric to the summary: NumberOfDifferencesInPackages
- Diff stats have their own section now (Package.Diff)
- When running with -diffonly there commandlet will not log the Warning/Error summary anymore
- Callstacks are no longer logged with instruction addresses
- Because callstacks are no longer logged with addresses I can collapse them for structures that otherwise would be split into multiple separate callstacks
- Callstacks, Serialized Object and Serialized Property are now indented
- Each asset is capped at 5 entries. If there's more differences, they'll be logged as single warning.
- Replaced \r\n with \n in the callstack log to make it work better with EC
#jira FORT-59919
Change 3746426 by Gil.Gribb
UE4 - Tuned dispatch in the deferred renderer. Added r.DoPrepareDistanceFieldSceneAfterRHIFlush and defaulted it to on.
Change 3746348 by Mike.Fricker
Added new CVars to toggle level streaming behavior
- No effective change to engine yet. The defaults values enable the same default behavior.
- New CVar: "s.ForceGCAfterLevelStreamedOut" (Whether to force a GC after levels are streamed out to instantly reclaim the memory at the expensive of a hitch.)
- New CVar: "s.ContinuouslyIncrementalGCWhileLevelsPendingPurge" (Whether to repeatedly kick off incremental GC when there are levels still waiting to be purged.)
- New CVar: "s.AllowLevelRequestsWhileAsyncLoadingInMatch" (Enables level streaming requests while async loading (of anything) while the match is already in progress and no loading screen is up)
Change 3746127 by Gil.Gribb
UE4 - Slight tweak to more agressively batch occlusion queries.
Change 3746111 by Cecil.McRae
Change 3745681 by Bob.Tellez
#UE4 Prevent attempting to execute a remote process to get the metal shader compiler version if no remove process machine has been configured. (Fixes a warning)
Change 3745631 by Matt.Kuhlenschmidt
Fix details panel crash after compiling blueprints that have edit conditon properties
Change 3744544 by Gil.Gribb
UE4 - Downgraded a fatal error to a warning. Example: Found package without a linker, could find SceneComp in /Game/AIDirector/AIDirector_Fortnite, but somehow wasn't finished loading. This is a sort of cook mismatched caused by the fact that all PS4 cooks have server-only data in them.
#jira FORT-59879
Change 3744419 by Matt.Kuhlenschmidt
Fix opening color picker causing values to change. Was due to conversion between srgb and linear color.
Change 3744270 by Ben.Marsh
Merging change to include deterministic cooking summary from Dev-Core (CL 3743182).
#jira FORT-59919
Change 3743621 by Guillaume.Abadie
Fixes subsurface profile fallback to lit shading model when Opacity == 0, introduced by 3447144.
#jira UE-51569
Change 3743403 by Gil.Gribb
UE4 - Merged lockfree / taskgraph fix from //UE4 (CL 3732262)
Change 3743392 by Gil.Gribb
Merged IO fixed from //UE4 (CL 3641155)
Change 3743376 by Gil.Gribb
UE4 - Added r.WarningOnRedundantTransformUpdate to produce warnings on redundant transform updates.
Change 3743372 by Gil.Gribb
UE4 - Added a stat for distance field verification...which takes a very long time, but does not affect test or shipping config.
Change 3743030 by Bob.Tellez
#UE4 Revert some code the was accidentally merged to UE4Main
#jira UE-52032
Change 3742611 by Josh.Markiewicz
#UE4 - fix for crash in destructor probably related to the freeing of memory via default destructors AFTER CefShutdown() has been called
#tests crashes before, no crash after (not sure if it was a 100% crash but this seems better regardless)
Change 3742187 by Nick.Darnell
Slate - Adding a new optional parameter to direct routing for the widgets under the cursor in Slate Application. Essentially ProcessReply occasionally needs to know the widgets under the cursor, the previous implementation, just used the routing path, this results in missing sending mouse leave messages to widgets under the cursor when dragging begins, which often left things with hover effects in bad states.
Change 3742053 by Michael.Trepka
Copy of CL 3713881
Added -buildscw to Mac Build.sh script to build ShaderCompileWorker in addition to the requested target. Xcode passes it to the script when building non-program targets.
#jira UE-31093
Change 3742050 by Michael.Trepka
Copy of CL 3711085
Reenabled UBT makefiles on Mac
Change 3741924 by Josh.Markiewicz
#UE4 - delete EpicSurvey module
- working toward engine/plugins/online removal from game branch
Change 3741865 by Nick.Darnell
UMG - Fixing a High DPI bug that wasn't scaling the offset for DragDrop widgets when using In-Window rendering that games depend on for DragDrop effects.
Change 3741442 by Ryan.Gerleve
Fix initialization order warnings
Change 3741370 by Ryan.Gerleve
Back out changelist 3689397. The memcpy in one of the FInBunch constructors is not portable and causes this change to break networking on Android.
Change 3740914 by Peter.Knepley
Restore player name obsfuscation
Change 3740828 by Marc.Audy
Dynamically create FKey if the char code is unknown
#jira FORT-59735
Change 3740811 by Ben.Marsh
UAT: Fix double-spacing of lines output by Utils.RunLocalProcess, and use a non-local function to output them for more readable logs.
#jira
Change 3740328 by Bob.Tellez
#UE4 Fix FullLoadAndSave cook method
Change 3740327 by Bob.Tellez
#UE4 Minor movie scene cooking improvements
Change 3740280 by Bob.Tellez
#UE4 Fix shipping config CIS
Change 3740232 by Bob.Tellez
#UE4 Gave OodleHandlerComponent a short name so it doesnt hit maxpath length issues on build machines.
Change 3740209 by Nick.Darnell
UMG - Finishing the ability to add a "Custom" method for Navigation. Currently the editor implementation leaves me wanting, but it works for now. You can put the name of a function to call (needs to match a signature that returns a UWidget).
Change 3740207 by Nick.Darnell
Slate - Navigation attempts when the user claims they are doing custom or explicit, if those methods don't return a valid widget, we don't treat it like the attempt failed and fallback to default navigation methods. Instead we use it as a trigger to indicate that no navigation should occur and treat it like a stop.
Change 3740189 by Bob.Tellez
#UE4 Fix mouse cursor position being set when hovering over the viewport in windowed mode despite not having focus
Change 3740171 by Marc.Audy
Fix merge issue causing compile error for AutomationTool
Change 3739270 by Ben.Woodhouse
Use background task graph affinity on platforms that implement it (e.g. XB1). Saves 8ms on GC spikes and ~0.5ms on the renderthread
#jira FORT-56961
Change 3739244 by Ben.Woodhouse
-statunit commandline option
Change 3738920 by peter.knepley
Fix issue where simulated proxies had bad crouch state when re-entering relevancy
Change 3738904 by Gil.Gribb
UE4 - Moved audio decompression tasks to the background thread pool. Controlled by a cvar AudioThread.UseBackgroundThreadPool, which defaults to 1.
Change 3738378 by Ori.Cohen
Added better profiling for scene query hitches
Change 3736984 by Ben.Woodhouse
Dummy merge: Accept main version of windowsrunnablethread.h, so Windows gets the new priorities
#jira FORT-56700
Change 3736754 by Zak.Middleton
Remove engine hacks of K2_SetActorLocation etc for pending engine merge. Will replace with delegates on transform updates for relevant classes.
Change 3736282 by Hongyi.Yu
Don't check target file while doing iterative shared prebuild cooking.
#jira FORT-58911
Change 3736109 by Michael.Trepka
Updated FMallocLeakDetectionProxy to not use a critical section internally on top of thread safety measures performed by FMallocLeakDetection and the underlying FMalloc implementation. The improvements are biggest on Mac, in particular in low framerate situations, as Metal RHI uses malloc heavily on multiple threads, but it's also a nice 10% improvement on a high end PC.
#jira FORT-55309
Change 3735765 by Ben.Woodhouse
Fix GTSynctype logic when vsync is disabled. This was breaking profiling
Change 3734436 by Marcus.Wassmer
More reliable Aftermath data.
#jira FORT-45518
Change 3734103 by Bob.Tellez
#UE4 Exposing GetRefPosePosition on SkinnedMeshComponent to BPs
Change 3733985 by Saul.Abreu
#jira FORT-58816
"Special case zero-width space in the text shaper to avoid fonts rendering the fallback glyph" - Jamie Dale
Needed to workaround an issue with guillemets (weird arrow quotes).
Change 3733922 by Brian.Bekich
Setting max serialization size in FNetBitReader to prevent runaway string reads from replicated object paths
Check for path name serialization error before tryng to read checksum
#jira FORT-57974
Change 3733850 by Max.Chen
Sequencer: Return unhandled only if not dragged. This fixes a bug where dragging in the track area would sometimes leave the handled state with the time slider controller and not allow you to pop up a menu with the movement tool.
#jira FORT-56092
Change 3733299 by Ethan.Geller
#jira FORT-58943 Handle corner cases for repeated calls to precache buffers.
Change 3732907 by Gil.Gribb
UE4 - Removed slow HLOD code from frustum cull loop and set things up at AddPrim time instead. Saves 1-3ms.
Change 3732728 by Robert.Manuszewski
Fixing a crash when dumping stats with massive callstacks
#jira FORT-58901
Change 3732438 by Marc.Audy
When a client informs the server that it has loaded a streaming level force a net update on all dormant actors that have at one point replicated data to relevant clients and ensure that the connection's destroyed startup/dormant actors list is properly populated.
#jira FORT-56997
Change 3730413 by Lukasz.Furman
fixed PlayerName encryption key
#jira FORT-59066
Change 3729588 by Bob.Tellez
#UE4 Only calling FixupData on load. Fixes crash during parallel saving.
Change 3729475 by Marc.Audy
Fix missing ;
Change 3729444 by Marc.Audy
Fix cases where GetWorld() being called multiple times per function
Change 3729143 by Hongyi.Yu
Added support to extract pak files to mount point.
- Extract with "-ExtractToMountPoint" when extracting pak in DiffCookedContent()
#jira FORT-58635
Change 3728981 by Nick.Darnell
Slate - Fixing a bug with Slate turning on statid tracking even when the slate verbose stats are not being used.
Change 3728838 by Zak.Middleton
Compile out GetWorld() call in check() in Test and Shipping builds, to avoid skewing profiling.
Change 3728604 by Jian.Ru
Submit one render command rather than many in FScene::UpdateParameterCollections
Change 3728434 by Marc.Audy
PostSignificance should always fire when unregistering regardless of whether this is the last object in the tag.
Change 3728427 by Gil.Gribb
UE4 - reduce stat overhead when not collecting stats.
Change 3728197 by Marc.Audy
Properly call post significance on initial registration if the post significance type is sequential
Change 3726266 by Gil.Gribb
UE4 - Force HISMC trees to rebuild during cook. This allow us to change parameters without resaving maps.
Change 3724501 by Marc.Audy
Fix initialization order
Change 3724411 by Ben.Woodhouse
Point light shadow rendering optimization - Made per-triangle culling take Z into account.
In FortGPUTestbed (with grass shadow casting enabled), GSVerticesOut reduced from 464k to 234k.
On xbox one, a pointlight GPU cost reduced from 6.7 to 4.1ms.
On PS4, GPU cost went from 2.3 to 1.9ms.
#jira FORT-58921
Change 3724367 by Chad.Garyet
Downgrading lock warning about still waiting to a message instead of a warning.
Change 3723903 by Max.Preussner
MediaAssets: Merged workaround for uninitialized media sound waves from 4.17
#jira FORT-57260
Change 3723134 by Lukasz.Furman
added deprecation for PlayerState.PlayerName, it should remain accessible only through Get/Set functions to control obfuscation
Change 3722955 by Jian.Ru
Fix a compilation warning
#jira FORT-58749
Change 3722667 by Luke.Thatcher
[BUILD] [!] Fix PGO failures on build machines.
- The strings "Failed" and "error" are always treated as build failures, even if the build task returns a success code.
- Failure to reserve a device should not be fatal.
#jira FORT-58001
Change 3722291 by Lukasz.Furman
restored public access to PlayerName for now, current code will be going through accessor
Change 3721012 by Alicia.Cano
chunk title file generation
#jira FORT-53605
Change 3720961 by Marcus.Wassmer
Fix bad UVDensities on objects causing texture streaming to fail. Better fix will come with the engine merge.
#jira FORT-58240
Change 3719318 by Lukasz.Furman
replaced old branch name assertions
Change 3719047 by Lukasz.Furman
added branch name assertion to core headers to avoid duplicating it
Change 3718499 by peter.knepley
Fix for a crash when calling FSlateApplication::Get().FindPathToWidget in response to a widget destructing. Widget must be invalidated before the reference is cleared or else someone else might assign a shared reference to it during destruction.
Change 3716965 by Alicia.Cano
No sound was playing for Android.
#jira FORT-58302
#android
Change 3715746 by Ben.Marsh
Hide Arxan warnings about PDB files not being present.
#jira
Change 3715172 by Bob.Tellez
#UE4 FullLoadAndSave now does SavePackage in parallel.
Change 3715055 by Bob.Tellez
#UE4 Fix to actually use the precached streaming audio DDC data when cooking.
Change 3714130 by Bob.Tellez
#UE4 Core changes to allow SavePackage to be done concurrently
Change 3714099 by Bob.Tellez
#UE4 Pull the logic to initialize and uninitialize the physics scene for a world out into separate functions
Change 3713145 by Ben.Marsh
Disable an Arxan warning in EC.
#jira FORT-56926
Change 3712904 by Ben.Woodhouse
Fix for gpu profiler crash on pre-maxwell nvidia (or when r.gpuprofiler is set to false)
Change 3712693 by Ben.Woodhouse
Workaround for PS4 flip thread crash in dev builds. Caused by the flip thread/offset threads being shutdown before being initialized. The high level logic is now robust to that. We should fix the PS4 RHI ideally, but this is simpler for now.
#jira FORT-58409
Change 3712544 by Ben.Woodhouse
add missing skylight diffuse gpu stat
Change 3712515 by Ben.Woodhouse
CSV profiler GPU and pre-declared stat support
- refactor the GPU profiler so it's no longer dependent on the stats system and can work in Test builds
- add support for pre-declared CSV stats, using FNames (these are required for GPU stats)
- add DECLARE_GPU_STAT macro which handles STATS and CsvProfiler declarations
Note: still a few issues to resolve with GPU stats: these randomly go to 0 at times during a replay on XB1, the GPU total is lower than the stat unit number, and the unaccounted stat is too large due to missing stats
Change 3712297 by Mike.Fricker
Fixed huge client hitch when applying changes to in-game options
- Every component was being re-registered when r.SimpleForwardShading was updated by the scalability system, even if the value hadn't changed. Now, it only re-registers components if the value changes on the fly. (e.g. when turning Shadows off or on PC)
#jira FORT-57661
Change 3711501 by Ben.Marsh
Fix build failure on Linux.
#jira
Change 3710962 by David.Ratti
Add SCOPE_CYCLE_UOBJECT for SourceObject of GE - this will tell us what weaponw as applying the GE
Change 3710602 by Marc.Audy
Only create MIDs as a child of the calling object if construction script is running
Change 3710421 by Ben.Woodhouse
Bring over a couple of XB1 rendering fixes from 4.18
3692692: Integrate XB1 translucent lighting fix
3674543: D3D12 : Fix bug with non-CS version of UpdateTexture3D caused by bad depthstride. This was causing corruption in the indirect lighting cache
#jira UE-49416
Change 3710338 by Marc.Audy
Fix Json <-> Property converter to handle maps with struct keys
Merged from CL# 3521195
#jira UE-46616
Change 3710226 by Bob.Tellez
#UE4 Increase TaskGraph stack size in editor builds since. SavePackage uses a deep callstack which exceeds the 384 memory limit
Change 3709046 by andrew.grant
Added ALLOW_CONSOLE_IN_SHIPPING define that Target.cs files can set to turn on console in shipping builds
#jira FORT-57180
Change 3709040 by andrew.grant
Fixed issue where this could fail if a messagebox was spawned early during initialization
Change 3708830 by Bob.Tellez
#UE4 Commandline switches/options are no longer detected when found between quote characters. This causes options from not being incorrectly detected when passed in as a value from another options. i.e. -Option="-log" no longer causes -log to be picked up. This removes the syntax of specifying parameters like "Option=Value", which should now be replaced with -Option="Value"
#jira FORT-57833
Change 3708826 by Bob.Tellez
#UE4 Removed needless calls to RegisterSerializedShaders in the saving codepath of material serialization. This function is only relevant when loading shaders.
Change 3707905 by Ori.Cohen
Fix attached skinned mesh never being unhidden due to scale 0 and render tick optimization
#jira UE-51485
Change 3706450 by Chris.Bunner
Removing illegal material set on decal component in GameplayStatics.
Set a related JIRA, this doesn't actually fix the issue but contributes.
#jira FORT-51597
Change 3706223 by Marc.Audy
Shrink UPackage class size substantially
Change 3706221 by Marc.Audy
Store CustomVersions in array rather than set
Change 3705798 by Bob.Tellez
#UE4 ShadowDepthVertexShader.usf fix to fix Mac cook.
Change 3705613 by Uriel.Doyon
Texture streaming integration from Main.
#jira FORT-57376
Change 3705137 by Michael.Trepka
Fixed MetalRHI warning when compiling without MALLOC_LEAKDETECTION defined
#jira FORT-55309
Change 3704310 by Marcus.Wassmer
fix d3ddebug error with shadowcasting pointlights
also suppress spammy d3ddebug data about texture debug names
#jira FORT-58063
Change 3703477 by Marc.Audy
Minor tweak to keep Padding on one cache line.
Change 3703449 by Michael.Trepka
Don't use parallel RHI execute on Mac if MALLOC_LEAKDETECTION is enabled as this combination affects performance significantly due to mutex locking in FMallocLeakDetectionProxy
#jira FORT-55309
Change 3703217 by Marcus.Wassmer
Update PS signatures to match VS. Fixes crashes when running witih -d3ddebug which we need to catch real problems
#jira FORT-58021
Change 3702926 by Aaron.Eady
#JIRA na
Engine Code Improvements (that this project doesn't have yet);
Added engine code for drawing a debug 2D box.
Added engine code that allows for Keyboard Shortcuts to be special characters like backslash \.
-- Code --
DrawDebugHelpers:
DrawDebugCanvas2DBox() - Added this to allow us to draw debug 2D boxes.
RemoteConfigIni:
SpecialCharMap - Updated this TCHAR* property to be in the right order so you can use special characters like backslash as keyboard shortcuts.
Change 3701976 by Michael.Noland
Editor: Rewrote CallInEditor support and promoted it so it can be used on functions in any class, not just blueprints derived from AActor:
- CallInEditor used on native UFUNCTION() declarations will now show up without having to make a BP subclass
- CallInEditor can now be used as a top-level keyword in the UFUNCTION() declaration (e.g., UFUNCTION(Category=CoolCommands, CallInEditor))
- Now shows each function as a separate button, placed in the category associated with the function
- The button strip entry is now searchable by function name or tooltip
- Prevented operating on functions that have parameters or return values, which would crash before
- Removed the duplicate copies of properties placed in the Blutility section
- Added a scoped transaction around CallInEditor execution
- Allowed functions to be marked as CallInEditor in addition to custom events (currently we don't allow editing category or tooltip on custom events...)
Editor: Moved Experimental/EarlyAccessPreview details customizations up to UObject so it can be used on any class, not just actors/components
Edigrating CL# 3374995, 3375121, and 3375308 from Dev-Framework to FN main
Change 3700836 by Bob.Tellez
Modified commandline parse function, to detect when it is incorrectly parsing a parameter, from within another parameters value (not exhaustive).
For example, this commandline only contains the parameter ParamA. It should not be possible to parse ParamB, as it is part of ParamA's value:
-ParamA="-ParamB=Value"
#jira FORT-57833
Change 3700821 by Bob.Tellez
Merging CL#3461205 from //UE4/Dev-Core
Fixed parameter parsing so that arguments are not parsed if not preceeded by a whitespace (for example "-Log" was parsed in "TM-Log")
#jira UE-33790
Change 3699584 by Chad.Garyet
Upping the timeout on symstore to half an hour instead of 15 minutes. Symstore on xbox takes about ~22 minutes and if two builds are going simultaneously it can cause a job to fail due to the timeout being hit.
#jira FORT-0
Change 3698692 by Aaron.McLeran
#jira FORT-57582 crash in sound mix state code
- Removed the assert as it looks like that state is now possible.
Change 3698411 by Bob.Tellez
#UE4 One last correctness fix for when to not save generated base ini files.
#jira FORT-57315
Change 3698390 by Bob.Tellez
#UE4 Slightly more accurate logic to prevent writing of base ini files (old logic may have prevented writing of non-base ini files)
#JIRA FORT-57315
Change 3698369 by Bob.Tellez
#UE4 Ensure that Tcp/Udp messaging plugins are disabled in shipping config
Change 3698352 by Bob.Tellez
#UE4 Minor additional fix to make sure DISABLE_GENERATED_INI_WHEN_COOKED only affects cooked builds
#jira FORT-57315
Change 3698341 by Bob.Tellez
#UE4 DISABLE_GENERATED_INI_WHEN_COOKED now properly prevents all base ini file loads from happening from a generated folder. It also prevents writing generated ini files completely.
#JIRA FORT-57315
Change 3697553 by Nick.Darnell
Slate - When setting the content of an SBox it should always invalidate.
Change 3697330 by Bart.Hawthorne
APlayerController::ServerShortTimeout_Implementation now only iterates over the active object list instead of uisng an actor iterator, since non-replicated actors wont have a network object info to update.
#jira FORT-57099
#tests ran 100 player bot match
Change 3695578 by Bob.Tellez
#UE4 Fix Win32
Change 3695508 by Eric.Newman
Tweaked LogInit logging to clarify when the command line is being filtered
* Encountered this red herring when evaluating crash logs
#jira FORT-55839
#tests ran shipping & debug client builds, and editor game build
Change 3694898 by Michael.Trepka
Fixed Vorbis audio not playing on non-Windows platforms due to changes in CL 3668361
#jira FORT-57121
Change 3694655 by David.Ratti
Reimplement TweakObjetPtr optimizations with FObjectReplicator as an FGCObject instead of the owning channel being responsible for adding the replciator's ObjectPtr to the reference collection. (There are cases where object replicator ownership is transferred).
#JIRA FORT-57298
Change 3694491 by Ben.Woodhouse
Change courtesy of Gil: Drop the priority of the texture streamer using a new low-priority thread pool. This saves a 1-2ms in heavy combat in PVE (XB1 Test)
#jira FORT-57376
Change 3693609 by Ryan.Gerleve
Back out CL 3689050 since it was likely causing a crash.
#jira FORT-57298
Change 3693327 by Aaron.McLeran
#jira FORT-57416 Fixing PS4 cook.
Making sure zero pad bytes stays positive without a check.
Change 3693136 by David.Ratti
fix clang warning
Change 3692703 by Thomas.Sarkanen
Fix CIS warning on PS4/Linux
Change 3692589 by Thomas.Sarkanen
Moved exposed value handler bound function initialization to CDO postload
This means that FindPropertyByName and FindFunctionChecked dont incur any overhead when spawning in new anim instances
#jira FORT-56968 - Hitch - SkeletalMeshComponent initialization (110ms)
#tests PIE PvE, 20-bot BR game on PC/PS4.
Change 3692552 by Alex.Delesky
Change 3692495 by Bart.Hawthorne
Fix build
Change 3692488 by Bart.Hawthorne
Check for actor relevancy and level initialization when there's no channel first when prioritizing actors for replication. Dormancy checks in this case are useless because ShouldActorGoDormant will always be false, and if IsActorDormant is also true, then the result of skipping the actor is the same.
#jira FORT-57104
#tests played 100 player bot match
Change 3691819 by Bob.Tellez
#UE4 No longer conditionally including SlateDebug fonts in the cook based on configuraiton. When builds are produced that contain more than one configuration it changes what is cooked in unexpected ways so now we just always cook this font.
Change 3691805 by Bob.Tellez
#UE4 CIS fix
Change 3691784 by Bob.Tellez
#UE4 Optimization for exiting PIE. Texture streaming managers have an optimization for game worlds but were not using them for PIE worlds
Change 3691273 by Aaron.McLeran
#jira UE-50650 Fix memory/event leak in USoundWave::AudioDecompressor
Fix is to only delete the decompress/pre-cache task in game thread during FinishDestroy and not allow sounds to start playing unless the precache task has finished.
Change 3691268 by Aaron.McLeran
#jira FORT-56228 LogAudio:Warning: spam causes severe performance drop on the Mac Platform
Reducing log level
Change 3690547 by Ryan.Gerleve
Speculative fix#2 for a server crash/assert. If the timing is right, it's possible for the server to try to re-load a placed-in-map actor that was previously garbage collected. This was happening because CanClientLoadObject was always returning true for these (null) objects, even if the NetGUID corresponded to a map actor that shouldn't be loaded. Also added/improved some logging that will help in case this doesn't fix the issue.
#jira FORT-55763
Change 3690451 by Lukasz.Furman
changed branch name testing in engine hacks to use case insensitive match
Change 3690270 by David.Ratti
Cache weak object ptr in FNetworkObjectInfo to avoid reconstructing one every time we need to lookup its actor channel.
#jira FORT-57156
Change 3690227 by David.Ratti
Added optional TWeakObjectPtr parameter to packagemap functions GetOrAssignNetGUID, SUpportsObject. This allows you to pass in a weak ptr for an object if its already created. If you pass in null, the functions will create them internally.
This fixes some common cases where we were converting the same object into weak ptr multiple times in a frame.
#jira FORT-57156
Change 3690184 by David.Ratti
Cache net connection weakobjectptr when building consider list instead of constructing it again for every actor.
#jira FORT-57156
Change 3689805 by Peter.Knepley
Make ConditionalInitAxisProperties protected instead of private
#jira FORT-56414
Change 3689789 by Marcus.Wassmer
Hack workaround for missing shadowdepthps for XB1 until we get a handle on why things are exploding
#jira FORT-56792
Change 3689702 by Peter.Knepley
Allow games to have a custom MassageAxisInput function
#jira FORT-56414
Change 3689687 by Bob.Tellez
#UE4 Avoid copying the shaders array to avoid changing refcounts of shaders while serializing
Change 3689655 by Peter.Knepley
Make SmoothMouse virtual so games can have their own smoothing
#jira FORT-56417
Change 3689499 by Bart.Hawthorne
Fix Linux CIS warnings
Change 3689397 by Bart.Hawthorne
Changed FOutBunch and FInBunch uint8 entries to use bitfields instead of bytes which knocked 86% off of our net tick time
Change 3689056 by Lukasz.Furman
3rd attempt for branch name checking in engine code hacks
Change 3689050 by David.Ratti
First pass at removing use of TWeakObjectPtr from core replication classes. This should reduce FWeakObjectPtr::Get usage.
Still expecting to see FWeakObjectPtr::operator= come up a lot. Going to tackle this in a second pass which will require some deeper refactors.
#jira FORT-57156
Change 3688972 by Bob.Tellez
#UE4 Add build target flag to control DISABLE_GENERATED_INI_WHEN_COOKED
Change 3688864 by Ryan.Gerleve
Fix broken logic to find the "best" replay sample for character movement when we don't find two samples to interpolate between. Now uses the sample closest to the current time. Also added some debug drawing.
#jira FORT-56553
Change 3687654 by Bob.Tellez
#UE4 Added compile time option to disable reading generated ini files other than GameUserSettings in cooked builds.
Change 3686615 by Lukasz.Furman
Back out changelist 3686610
Change 3686592 by Matt.Kuhlenschmidt
Gave the CL description in the source control submit window more room
Change 3686020 by Ben.Marsh
Remove debug code that prints to logs while building.
#jira FORT-56923
Change 3684414 by Peter.Knepley
Back out changelist 3678336
#jira FORT-56512
Change 3683894 by Gil.Gribb
UE4 - By default, do not check for illegal calls to MarkPendingKill in the garbage collector in test and shipping configuations. This was slow.
Change 3683686 by peter.knepley
Raise MTU from 512 to 1024
#jira FORT-56756
Change 3683343 by Rob.Cannaday
Fixes insert disk popup
#jira FORT-56500
Change 3683156 by Peter.Knepley
Network optimizations to reduce alloc/free & memcpy churn saving about 10% of net tick time
Change 3682234 by Guillaume.Abadie
Cherrypick TAA refactor 3512696 and TAA fix 3668108
#jira FORT-56303
Change 3681494 by Bob.Tellez
#UE4 IsLoadedByEditorPropertiesOnly is not working properly so I removed it from FullLoadAndSave
Change 3681342 by Bob.Tellez
#UE4 Added a FullLoadAndSave option to cooking, which simply loads all content then saves it to avoid the overhead of managing which packages need to be cooked. Large perf improvement for those who cook by the book and can fit the entire game in memory
Change 3681014 by Yenal.Kal
#jira FORT-56209
#jira FORT-56272
Fixed a bug in the ability system where the ability ended callbacks could cause the ability end to be called again in the same call stack even though the ability is activated only once.
This was happening because we were broadcasting the event before we decrement the active count.
Change 3680739 by Michael.Trepka
Warn about NaN float literal values when translating HLSL to Metal instead of failing, plus added more detailed warning/error messages for NaN and unhandled values
#jira FORT-56425
Change 3679237 by Bob.Tellez
#UE4 Remove some debug logging
Change 3679187 by Bob.Tellez
#UE4 Dramatically imrpove speed of writing cookloadorder log file
Change 3678926 by Bob.Tellez
#UE4 Minor savepackage speed improvements
Change 3678336 by Aaron.McLeran
#jira UE-50650 Fix memory/event leak in USoundWave::AudioDecompressor
Fix is to only delete the decompress/pre-cache task in game thread during FinishDestroy and not allow sounds to start playing unless the precache task has finished.
Change 3676998 by Ben.Woodhouse
Fix XGE shader compilation so it doesn't crash randomly
Change 3676606 by Ori.Cohen
Update GC to be 61.1 to avoid heartbeat collision
Change 3676447 by Ori.Cohen
Fix CIS warning
Change 3676286 by Max.Preussner
Fixed client Crash UMediaSoundWave::GeneratePCMData (FORT-56107)
#jira FORT-56107
Change 3674591 by Ryan.Gerleve
Don't filter out PendingKillPending actors from FNetworkObjectList::Find. This was causing actors that get destroyed while dormant on the server to never be destroyed on clients.
#jira FORT-55802
Change 3674181 by Michael.Noland
Framework: DLL export LogGameplayTags
Change 3674138 by Billy.Bramer
#jira FORT-56138, FORT-56139
- Duplicate CL 3396590 from //Orion/Main re: ranged-base for iteration ensure from montage changes
Change 3672464 by Lukasz.Furman
removed recast layers crash tracking code
Change 3672153 by Daniel.Lamb
Added some debugging code to help track down why shaders are hashing poorly.
Change 3671498 by Luke.Thatcher
[~] Modify new frame syncing to reduce performance regression seen when the game is running over budget.
- Rather than forcing a flip sync after we kick off one frame early, we just continue to kick frames if we time out. This allows the game thread to get ahead when we're over budget.
- The game thread will naturally resync with the vsync when we return to being in budget.
#jira FORT-55842
Change 3671079 by Ryan.Gerleve
Fix an edge case where the PackageMap on the server would try to resolve objects from default NetGUIDs even if their outer has already been garbage collected. This could lead to a completely unrelated object being returned instead of null, leading to asserts and potentially other issues.
#jira FORT-55763
Change 3670487 by Zak.Middleton
Optimize some low level details of UNetConnection::ClientHasInitializedLevelFor() and UNetDriver::IsLevelInitializedForActor(). Add cached WorldPackage for NetDriver to avoid repeated GetOuterMost() and Casts. Remove rendundant virtual GetWorld() calls, and mark UNetDriver's version "final" to let it optimize away virtual call. Made UNetConnection::ClientVisibleLevelNames a TSet instead of TArray, since it is searched frequently when there are streaming levels present.
#jira FORT-55999
Change 3670351 by Zak.Middleton
Back out changelist 3669817 (networking optimizations). Would rather have more testing before it goes to Release-Next. Will resub just for main and RP.
#jira FORT-55999
Change 3670344 by Josh.Markiewicz
#UE4 - more verbose logging for SetExpectedClientLoginMsgType
Change 3670323 by Wes.Hunt
Fix for dedicated servers not flushing events in a timely manner.
#jira FORT-56015
Doh, using GFrameNumber was NOT a good idea on servers... :-/
Change 3669817 by Zak.Middleton
Optimize some low level details of UNetConnection::ClientHasInitializedLevelFor() and UNetDriver::IsLevelInitializedForActor(). Add cached WorldPackage for NetDriver to avoid repeated GetOuterMost() and Casts. Remove rendundant virtual GetWorld() calls, and mark UNetDriver's version "final" to let it optimize away virtual call. Made UNetConnection::ClientVisibleLevelNames a TSet instead of TArray, since it is searched frequently when there are streaming levels present.
#jira FORT-55999
Change 3668416 by Michael.Noland
Core: Changed FString::ParseIntoArray to use Reset instead of Empty on the passed in array, allowing it to be approximately resized
#jira FORT-55887
Change 3668411 by Olaf.Piesche
Always cache depth collision particle shader
#jira FORT-51307
Change 3668361 by Aaron.McLeran
#jira FORT-55628 Attempt to bypass crash and log an error if libvorbisdll fails to load.
Change 3667892 by Rob.Cannaday
libwebsocket libs to handle getprotobyname("TCP") failing the libwebsockets connection
#jira FORT-55917
Touch LwsWebSocket.cpp to ensure the module gets built with the new libs
Change 3667308 by Uriel.Doyon
Postponed the release of IO requests when canceling mip updates to prevent threading issue.
#jira FORT-54491
Change 3666835 by Lukasz.Furman
fixed overlapping index buffers when static mesh exports both convex and simple collisions for navigation
#jira UE-50370
Change 3665374 by Mike.Fricker
Fixed server crashing after hotfixes have re-imported curve table data
- The hotfix system is capable of replacing the content of a UCurveTable on the fly
- If any systems had references to inner curves on that curve table, they would become invalid
- This needs to be fixed in 1.6.4 (tonight) and also in 1.7
#jira FORT-55792
Change 3665063 by Daniel.Broder
Fixed crash in GameplayTagQueryCustomization when choosing "Save and Close" on GameplayTagQuery after setting a query due to nullptr NotifyHook in CloseWidgetWindow.
Added additional if (StructPropertyHandle.IsValid()) wrappers and one check(StructPropertyHandle.IsValid()); the former to be consistent with other code and prevent possible crashes, the latter to at least catch the cause of a possible crash properly without having to change the code more significantly to handle it gracefully.
Also changed some if( X ) to if (X) to match coding standards and provide consistency within the file.
Michael, I'm Reviewing you on this fix since you brought this change over from Framework. And Marc because you reviewed him on that change.
#UE4 #NoReleaseNotes #RNX
Change 3664948 by Lukasz.Furman
reduced number of allocations in StorePathfindingDebugData, optimized path length calculations to avoid recursion
#jira FORT-51111
Change 3664916 by John.Abercrombie
Copy CLs 3383318 & 3388506 from //Orion/Main/Engine/Source/Runtime/Engine/...
- Been testing with this for a while now
- This change makes particle effects show up on the current frame's pose for skel meshes as well
Removed my StopAllMontagesByGroupName temp hack
CL 3383318
Delay dispatching of AnimEvents (Notifies and Montage Events) until after we receive an updated animation pose (if applicable).
This fixes AnimNotifies playing particle effects using a socket location using last frame's pose. Now they use the current frame's pose.
CL 3388506
Delay clearing of MontageInstances and triggering 'OnAllMontageInstancesEnded' until all Montage Events have been dispatched.
Also fix SkelMeshComponent ticking on dedicated servers when rejoining in progress.
#jira FORT-55102 - Server Crash UAnimInstance::StopAllMontagesByGroupName
Change 3780616 by Gil.Gribb
Fixed and reenabled r.DelaySceneRenderCompletion
Change 3778979 by Gil.Gribb
UE4 - Improved the performance of grass updates and added the ability to not do all of them every frame.
Change 3778200 by Nick.Darnell
UMG - Making it possible to cancel delays and all animations on widgets. Useful when destroying a widget and needing to stop any async state.
Change 3777612 by Zak.Middleton
Perf: Added option to CharacterMovementComponent to skip immediate forward prediction for proxies on the frame they receive a network update (bNetworkSkipProxyPredictionOnNetUpdate). This avoids all forward prediction sweeps and floor checks on those updates. Intermediate frames will interpolate with prediction. This can also be disabled globally with the CVar "p.NetEnableSkipProxyPredictionOnNetUpdate 0".
Added NetworkSmoothingDisableProxyPredictionForPawnLOD to force disabling full simulation for LOD >= this value (currently 3, so bottom 75 pawns). This takes precedence over current distance and view angle checks for prediction (mesh interpolation is untouched).
Change 3774338 by Ben.Woodhouse
Convert the D3D12 PSO caches to use RwScopeLocks. This change is courtesy of a shelf from Gil, plus a couple of minor fixes.
Saves up to a millsecond of frame time in CPU-bound scenarios
Change 3773462 by Gil.Gribb
UE4 - Add particle batching. This is disabled by default but can improve thread scheduling when there are lots of very fast particle systems.
Change 3771375 by Hongyi.Yu
Fixed the crash where ability components are unregistered and then re-registered, which usually happens in PIE.
Change 3771368 by Ben.Zeigler
#jira UE-52670 Add project setting bValidateUnloadedSoftActorReferences that is true by default to match current behavior. If you set it to false it will no longer load packages to look for soft actor references when deleting/renaming actors.
Change 3771173 by Seth.Weedin
Auto manage attachment support for AudioComponent- An opt-in feature that allows AudioComponents to cache their AttachParent/AttachSocket and only attach themselves when playing audio, detaching after playback is completed. Set to false by default.
Change 3768811 by Ori.Cohen
Change animation scale collision code so that it uses the physics asset.
Change 3768148 by Brian.Bekich
Fix muting being unable to find remote player controller
Change 3768117 by Ori.Cohen
Prevent pawn collision from updating during animation
Change 3766554 by Gil.Gribb
UE4 - Added a new option to add and remove from static draw lists on demand. This is off by default.
Change 3766427 by Nick.Darnell
Slate - Finally adding Opacity to SWidget. Any widget can now be alpha animated at will, no more need to waste overhead by wrapping things with SBorder or making them userwidgets just to be able to animate a fade.
Change 3761682 by nick.darnell
Athena - Introducing a way to interrupt the request to scroll and item into view. In cases where you're animating, quickly showing and hiding, with the item widgets unavailable for a few frames, you enter cases where the deferred navigation is resolved after you've canceled showing a dialog stealing focus.
Change 3761416 by Ben.Zeigler
#jira UE-52287 Prevent cook metadata like DevelopmentAssetRegistry.bin from being packed into a shipping game, by moving it into a Metadata subdirectory and updating deployment scripts to avoid that directory.
Right now it doesn't package them at all, we could change it to package them as Debug Non-UFS if desired
Change it so the asset audit UI will only load DevelopmentAssetRegistry.bin files, the cooked registry files don't have enough information any more to be useful
Remove ability for runtime game to load DevelopmentAssetRegistry.bin, this ended up not being useful
Change 3750998 by Ethan.Geller
#jira FORT-60191 Allow -audiomixer command line arg to work on all platforms.
Change 3749540 by Marc.Audy
SignificanceManager now takes viewpoints in as TArrayView instead of const TArray&
Change 3748102 by Marc.Audy
Allow cheat cvars to work in Test builds by default
Can be overriden by defining ALLOW_CHEAT_CVARS_IN_TEST as 0 in Target.cs files
Change 3744756 by Bart.Hawthorne
Upgrade Oodle to version 2.5.5. Also, iOS, Android, and Switch platforms have been added. The new dictionary has been generated with old and local captures.
Change 3741168 by Max.Preussner
MediaUtils: Fixed movies not playing properly in Shipping builds
Change 3739256 by Jian.Ru
Set distance field self-shadow bias without recreating all render states
Change 3730756 by Ben.Woodhouse
HISM optimization:
Gil's change to skip trees with only one level of hierarchy (working around badly tuned content issues)
Change vert threshold to 2K.
1-2ms renderthread win without impacting GPU when rendering point lights
Change 3724029 by Zak.Middleton
Increase allowed time for movement substep duration. Don't want to lower between 2 iterations, as this is not used much in practice other than deflection and movement mode changes, and that will change behavior (lose momentum). This new setting will absorb longer hitches in the common case (moving without collision or falling).
Change 3723985 by Marc.Audy
SignificanceManager PostSignificanceUpdate functions can now be executed sequentially on the game thread as well as concurrently in the parallel for (old behavior)
Change 3722910 by Jian.Ru
Amortize shadow cache update caused by resolution change
Changed to use view distance vs. view space z when calculating whole scene shadow resolution which is less sensitive to camera rotation
Change 3718247 by Yenal.Kal
Fixed the bug where the gameplay effect durations can show incorrect values after rejoin or after server time drifting away from the client.
Change 3716343 by Jamie.Dale
Adding Korean and Turkish to the localization automation
Change 3710534 by Uriel.Doyon
Texture streaming optimization where a maximum texture resolution for each level streaming data is computed per view.
This is used to cull irrelevant levels and reduce the async task number of iterations.
The culled size is defined by the new r.Streaming.MinLevelTextureScreenSize.
This requires to remove primitives with big UV density from the level data.
Those primitives get moved to the dynamic lists.
This is controlled by r.Streaming.MaxTextureUVDensity
Change 3707207 by David.Ratti
Remove look ahead-vectors prediction in FNetViewer. This (requires) a line trace which is not desirable or really accurate anymore. This saves us a line trace per connection per multicast rpc.
unify reliable multicast rpc handling: these now do relevancy checks and are not sent to non relevant clients
Change 3706272 by Thomas.Sarkanen
Added utility/math functions to aid in optimizing anim blueprints
Added VectorLengthXY to get the 2D length of a 3D vector. Avoids unecessary conversions.
Added polar->cartesian->polar conversion helper functions for expensive frequently-used anim graph functionality.
Change 3706159 by David.Ratti
PlayerState/ASC replication optimizations from Polge: this puts the net update frequnecy on player state back to 1hz while forcing netupdates on the player state actor when the ability system component needs to update
Change 3692891 by David.Ratti
Optimizations for UNetConnection::ClientHasInitializedLevelFor: build acceleration map of actor outer's (ULevels) -> Visibility bool. Existing logic stays the same.
Change 3691392 by Aaron.McLeran
#jira UE-50628 Fix audio trying to sync load bulk data with EDL enabled
- Fix log error in BulkData.cpp
- Make the first stream chunk be force inline payload in bulk data flags so it loads immediately vs in async IO system
- Make audio stream chunks get as close to 256 k chunks as it can, zero-pad rest to be 256 k aligned
- Fix up DDC key, serialize AudioDataSize separately from chunk DataSize
Change 3682683 by Zak.Middleton
Add bOnlyTickMontageOnDedicatedServer variable to AnimInstance, to avoid anim bp updates on dedicated server. Turn on to fix hitching from queued ServerMove() calls, and some free perf during all montages on the server.
Change 3678771 by Ori.Cohen
Added the ability to turn on stack walk during hitching vs lightweight stats
Change 3676363 by Ori.Cohen
Added the ability to get callstacks as part of hitch detection
Change 3674877 by Keith.Judge
Move definition of GFailedToFindParamCollectionBufferQueue to ShaderBaseClasses.cpp so that all targets can successfully compile.
Change 3672515 by Bob.Tellez
Added code to play wind particle effects
Change 3670909 by Zak.Middleton
Fixed ForcePositionUpdate() not calling CheckJumpInput(). Added "p.NetForceClientServerMoveLossPercent" cvar to simulate loss of client->server movement RPCs (without hosing the rest of networking).
[CL 3791033 by Marc Audy in Main branch]
#lockdown Nick.Penwarden
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3372740 by Chris.Bunner
[Experimental] Partial compute post process pipeline (r.PostProcess.PreferCompute).
StencilSceneTexture added to deferred list.
A few known issues to be fixed in a follow-up CL.
Change 3374187 by Chris.Bunner
Volume texture support for CombineLUTs/Tonemap compute pass.
Refactored common param code to shared sub-class in CombineLUTs and Tonemap PS/CS.
Skip compute post process out-of-bounds writes.
Unsigned type conversion fixes.
Trimmed compute post process shader inputs.
Change 3441680 by Uriel.Doyon
Added units to point light intensity, to allow the user to specify the value in candelas or lumens.
New point light actors now configure the intensity in candelas by default.
Replaced viewport exposure settings by an EV100 slider.
Hidding the tone mapper in the show flag now still applies the exposure.
Added a new AutoExposure method called EV100 which allows to specify :
- MinEV100, MaxEV100
- Calibration Constnat
- Exposure Compensation
#jira UE-42783
Change 3454636 by Uriel.Doyon
Fixed point light having an extra scale of 16 in mobile
#jira UE-45272
Change 3454844 by Uriel.Doyon
Fixed extra X16 on some point lights
#jira UE-45250
Change 3454934 by Chris.Bunner
Backing out changelists 3441680, 3454636 and 3454844 for the sake of integration stability.
Change 3461206 by Guillaume.Abadie
Adds possibility to scene captures and player controller to render no primitives at all.
Change 3461207 by Guillaume.Abadie
Exposes showflag details to USceneCaptureComponent. This gives the possibility to configure scene capture's showflags in blueprint encapsulated compositing pipeline.
#jira UE-6810
Change 3461233 by Chris.Bunner
Added Log10 material expression.
Added tooltip for Log2 and Log10.
Change 3461434 by Michael.Trepka
Copy of CL 3456118
In Metal RHI report texture streaming as immediately successful as on D3D to avoid a race-condition leading to deadlock between the Main, Game, Render & RHI threads.
#jira UE-44961
Change 3461770 by Benjamin.Hyder
Submitting TM-RayTracedDistanceField map
Change 3461929 by Marc.Olano
Add Sobol blueprint and material node test maps to RenderTest project
Change 3462249 by Uriel.Doyon
Translucency after DoF is now disabled when showflag postprocess is disabled.
Change 3462371 by Brian.Karis
VT addressing is now 64bit to support huge sparse virtualized volumes
16bit page tables working.
Change 3462936 by Marc.Olano
Extend Sobol testing map with comparision between Random Sobol and Next Sobol functions
Change 3464394 by Uriel.Doyon
Improved synchronization for texture streaming commands.
This fixes an issue when accessing FStreamingTexture for pending textures.
Change 3464743 by Guillaume.Abadie
Adds .usf file extension on all shader's source file names and adds checks to verify them at engine load time.
Change 3464818 by Guillaume.Abadie
Fixes compilation error in FindShaderRelativePath
Change 3465184 by Daniel.Wright
r.Shadow.PreShadowResolutionFactor 1.0 on Epic shadow settings
Change 3465283 by Marc.Olano
Update Sobol Gray code tables to match random order tables
Change 3465976 by Arne.Schober
DR - [UE-44393] - The Canvas is using the Globalshaders for clearing but compilation is done asynconously at load time. Unfortunately there could be Code that uses a canvas to draw and cause this issue in between. There might be some plugins that do this. For now we need to wait and block for the shaqders to be compiled until we can allo the use of the canvas.
#RB none
Change 3467513 by Guillaume.Abadie
Fixes an issue where primitives would no longer draw in gameplay.
#jira UE-45550
Change 3471116 by Richard.Wallis
Mac OpenGL Is No Longer Supported - Remove All Code & Shader Platforms. Merge of CL 3327784 dev-editor stream from Michael Trepka with some extra changes.
- Also removed Metal shader platforms from PlatformSupportsDebugViewShaders() otherwise we get a compiler error. HLSL register binds not implemented in metal backend.
#jira UE-39108
Change 3471117 by Richard.Wallis
Drop down menus clip on 27" Screen iMacs. Disable viewport HDR rendering on macOS 10.12.x when in editor.
#jira UE-43026
Change 3471130 by Richard.Wallis
Mac GPU hang causes editor output log to be written to the wrong file. Try to emulate windows behaviour when opening a file for reading or writing. Tested against behaviour of windows log file with multiple instances running.
- Only defined in for Mac and non shipping.
#jira UE-44934
Change 3471224 by Guillaume.Abadie
Lets the ProjectFileGenerator to look at Shaders/ directories in plugin and game projects.
Change 3471646 by Daniel.Wright
Fixed ensure opening UT system settings
Change 3471862 by Arne.Schober
DR - revert accidently checked in changes.
#RB Chris.Bunner
Change 3472249 by Guillaume.Abadie
Implements virtual shader source directory mapping.
- /Engine/... maps to Engine/Shaders/...
- /Plugin/FooBar/... maps to FooBar plugin's Shaders/ directory
- /Project/... maps to project's Shaders/ directory
Change 3472443 by Daniel.Wright
Moved the Rendering category for lights to be just below the Light category, so the bVisible property is easily accessible
Change 3474537 by Uriel.Doyon
Fixed lighting needs rebuild happening after blueprint rescript and a non symetrical Quaterion != ToQuaternion(ToRotator(Quaternion)
Change 3475192 by Guillaume.Abadie
Implements LensDistortion engine plugin.
This CL import a polished version of Raven's lens distortion and undistortion from OpenCV parameters:
- It is implemented as the first engine plugin with its own shaders and render thread commands;
- Has feature tests in EngineTest with gold images directly extracted from OpenCV itself (GenerateLensDistortionUndistortReferences.py)
Change 3475209 by Guillaume.Abadie
Back out changelist 3475192
Change 3475252 by Guillaume.Abadie
Reland: Implements LensDistortion engine plugin.
This CL import a polished version of Raven's lens distortion and undistortion from OpenCV parameters:
- It is implemented as the first engine plugin with its own shaders and render thread commands;
- Has feature tests in EngineTest with gold images directly extracted from OpenCV itself (GenerateLensDistortionUndistortReferences.py)
Change 3475389 by Guillaume.Abadie
Adds LensDistortion plugin's feature tests.
Change 3475538 by Guillaume.Abadie
Adds the /Engine/* prefix on all of the renderer's USF file references.
Change 3475568 by Guillaume.Abadie
Adds a check for virtual shader source file path format in FShaderType::FShaderType()
Change 3475871 by Guillaume.Abadie
Fixes a bug in shader compile worker, were an error in a relative #include USF file would trigger an check failure in CheckVirtualShaderFilePath
Change 3475997 by Yujiang.Wang
Workaround for a compiler optimization bug introduced in VS2015 Update 3.
* The bug causes TSHVector<2>::CalcDiffuseTransfer to go to infinity at certain spot, making movable objects with ILCQ_Volume indirect lighting cache interpolation get very dark.
* Debug builds don't exhibit this bug.
* Semantics are exactly the same as the original code.
Change 3476203 by David.Hill
Compute SSAO: problem wiht AmbientOcclusionLevels and with various viewporttest sizes. Only seen when Levels >=2
#jira UE-45741
Change 3476536 by Benjamin.Hyder
adding player start to Ray Traced Distance Field Shadows Map
Change 3478298 by Benjamin.Hyder
disabling mesh distance fields in Tm-Raytraced_DistanceField_Shadows map
Change 3478948 by Rolando.Caloca
DR - Nicer check
Change 3478949 by Rolando.Caloca
DR - Default GPU morphs to enabled
Change 3478950 by Rolando.Caloca
DR - By default -vulkan will launch SM5
Change 3478984 by Rolando.Caloca
DR - Pass down -vulkan
Change 3479655 by Richard.Wallis
Video track does not switch in AVF Media Player. Need to disable unused video tracks to allow AVPlayerItemVideoOutput to decode the required track.
- Minimal change to allow video track changes/selection.
- Audio samples are extracted using AVAssetReaderTrackOutput but video uses AVPlayerItemVideoOutput. Video could also use AVAssetReaderTrackOutput to access the video data unless there is an iOS reason not to...
- Flush the audio sink sample buffers so we get instant audio track changes
#jira UE-39750, UE-39749
Change 3479834 by Rolando.Caloca
DR - Fix issue with bad vertex colors (per licensee)
Change 3480376 by Guillaume.Abadie
Disables ComputeLightGrid() if no volumetric fog and no lighting.
#jira UE-45377
Change 3480596 by Yujiang.Wang
Fix for dynamic shadows and raytraced distance field shadows of directional lights not appearing in planar reflection
* Bug caused by incorrect shadow culling volumes for cascaded shadow map and backface culling mode for WholeSceneShadowProjection
* Fixed by taking View.bReverseCulling into account
#jira UE-34452
Change 3480600 by Yujiang.Wang
Fix for UE-42376
* The bug is caused by post-processing ambient cubemaps not being supported in forward shading currently.
* This fix replaces all the occurences of them in CalcSceneView with a skylight using the cubemap
* If a CalcSceneView is used solely for setting the PP ambient cubemap, it is removed.
#jira UE-42376
Change 3480784 by Rolando.Caloca
DR - hlslcc - Initial support for [RW]StructuredBuffer
Change 3481690 by Uriel.Doyon
Attempt to fix static analysis warning
Change 3482012 by Simon.Tovey
Fixed issue when building distribution lookup tables where the final sample fell short of the max input time.
As sampling is done only over this range, under constant interpolation the final value was never actually sampled and so cut from the final optimized LUT.
#tests constant interpolation now works.
#jira UE-45614
Change 3482965 by Yujiang.Wang
Some quality of life changes for UE-42757
* The UV overlay in static mesh editor now has a darker background
* Selected edges are getting highlighted and bolder
* When some edges are selected others turn grey
#jira UE-42757
Change 3483014 by David.Hill
Change labels on bloom boost from x,y,z to min, max, mult.
#jira UE-43904
a PropertyRedirect in BaseEngine.ini allows this to work with older version.
Change 3484573 by Yujiang.Wang
Fix for shadow color not updated after light build when a texture is changed and reimported
* Bug caused by counter-intuitive design of UMaterial::GetReferencedFunctionIds and UMaterial::GetReferencedParameterCollectionIds, both of which will reset the OutIds parameter
* Renamed to AppendReferencedFunctionIdsTo and AppendReferencedParameterCollectionIdsTo, the resets are removed
#jira UE-45647
Change 3484969 by Yujiang.Wang
Fix for UE-39929 inconsistent type between C++ and shader code
* MeshDistanceFieldCasterIndices is declared as Buffer<uint> in CapsuleShadowShaders.usf, while created as PF_R32_SINT in CapsuleShadowRendering.cpp
* Changed PF_R32_SINT to PF_R32_UINT in CapsuleShadowRendering.cpp
#jira UE-39929
Change 3485012 by Yujiang.Wang
Fix for UE-39929 #2: Changed int32 to uint32 to match PF_R32_UINT
#jira UE-39929
Change 3485146 by Guillaume.Abadie
Destroyes scene capture's view states on the UnRegister, to avoid large memory usage cause by the ViewState's render targets when moving blueprints arround.
#jira UE-43455
Change 3486602 by Joe.Conley
Adding "texcoord" keyword to UMaterialExpressionTextureCoordinate so you can search for the name that is displayed on the node in the graph.
Change 3487471 by Yujiang.Wang
Github #3659: Improved performance of DumpUnbuiltLightInteractions
* Replaced TArrays with TSets
#jira UE-45783
Change 3487641 by Guillaume.Abadie
Fixes some shader file name casing issues in LPV.
Change 3488014 by Uriel.Doyon
New AllowAsyncLoading flag for UTexture::CachePlatformData().
It allows to load the source texture data in the async task if the source bulk data was not yet loaded.
Data loaded that way is not sharable between tasks and will be discarded.
This is required because updating the source data is not thread safe.
#jira UERNDR-190
#jira UE-33401
Change 3488249 by Uriel.Doyon
Fixed long stall in UpdateResourceStreaming() caused by Actor.GetComponents() not resetting the number of actors anymore.
Fixed inconsistent results in ALODActor::HasValidSubActors() caused by the same change.
#jira UE-46004
Change 3490228 by Mark.Satterthwaite
Fix the Nvidia driver bug with the old reversebits fallback function - you need to use the native reverse_bits intrinsic or use some uint(ushort()) casts to get the compiler to do the right thing, which means injecting the reverse_bits function in MetalBackend not the HLSL (as it has no such type).
#jira UE-46067
Change 3490538 by Arne.Schober
Back out changelist 3488249
#RB none
Change 3490551 by Arne.Schober
Back out changelist 3488249
#RB none
Change 3491828 by Guillaume.Abadie
Fixes another USf file reference casing issue in C++.
Change 3491924 by Yujiang.Wang
Fix for UE-43302 Crash when entering the DebugCreatePlayer console command with planar reflections in the level
* Crash caused by check(Views.Num() <= 2); in SceneCaptureRendering.cpp
* We still want to support at most 2 views for performance, but now instead of crash the planar reflections in additional views will simply turn black
#jira UE-43302
Change 3492359 by Guillaume.Abadie
Fixes non editor launches, failing in FGenericPlatformProcess::AddShaderSourceDirectoryMapping().
Change 3492367 by Marc.Olano
Change Sobol texture size to 32x16, tweak distribution
Change 3492599 by Marcus.Wassmer
PR #3669: -Fix logmessages ParticleModules_Location.cpp (Contributed by UpwindSpring01)
Change 3493473 by Uriel.Doyon
Back out changelist 3490538
Change 3493590 by Uriel.Doyon
Back out changelist 3490551
Fixed missing #pragma once
Change 3493911 by Marcus.Wassmer
Fix potential GPU crash/hang caused by out of bound subresource updates.
Added checks at cross-platform level to catch any instance earlier.
Change 3494139 by Uriel.Doyon
Fixed shadow variable issue on UE4Editor Linux.
Change 3494364 by Richard.Wallis
Mac OpenGL Is No Longer Supported - Remove All Code & Shader Platforms - Part 2: Remove some more areas and fixes for previous attempt. Also removed OpenGL based GPU performance checks in EditorEngine.cpp - assuming that any GPU that can run Metal is currently OK for UE4.
OpenGL left in the following areas:
- OpenGLShaderCompiler
- StandaloneRenderer
The following files need to be reviewed in conjunction with CL 3471116 as there were some logic errors made:
- OpenGLTexture.cpp
#jira UE-39108
Change 3494413 by Guillaume.Abadie
Updates r.InvalidateCachedShader and bump ShaderVersion.ush.
Change 3494422 by Guillaume.Abadie
Adds LensDistortion plugin's Private shader directory.
Change 3494717 by Guillaume.Abadie
Strengthens shader compiler with checks on generated file names and shader type file names.
Change 3494763 by Guillaume.Abadie
Removes a nolonger standing TODO in GlobalBeginCompileShader() that was automatically adding /Engine/ prefix to all relative virtual shader source file path.
Change 3494985 by Rolando.Caloca
DR - Integrate Vulkan Rewrite
Change 3495031 by Rolando.Caloca
DR - Delete file as it moved
Change 3495032 by Rolando.Caloca
DR - Show Vulkan SM5 instead of SM4 on windows packaging
- Also added support for Vulkan SM5_UB
Change 3495202 by Uriel.Doyon
Fixed static analysis warning with pointer dereferencing.
Change 3495342 by Rolando.Caloca
DR - clang compile fix
Change 3495354 by Rolando.Caloca
DR - clang compile fixes
Change 3495420 by Marc.Olano
Use Sobol sampling for PCSS
Change 3495799 by Rolando.Caloca
DR - Delete old dev assets
Change 3496202 by Mark.Satterthwaite
Switch to using actual Vector*Matrix intrinsic for Metal to avoid a problem whereby the Metal compiler reorders operations in such a way that it loses precision and ends up being different between pre-pass and base-pass.
#jira UE-46070
Change 3496253 by Uriel.Doyon
Fixed static analysis warning for IncludeTool
Change 3496631 by Guillaume.Abadie
Makes AScreenshotFunctionalTest::ScreenshotOptions blueprint readable.
Change 3496851 by Guillaume.Abadie
Fixes back slash issues in Platform.usf.
Change 3496852 by Guillaume.Abadie
Fixes other back slashes includes in PS4 specific usf files.
Change 3496941 by Guillaume.Abadie
Adds a check() for no backslash in virtual shader file paths.
Change 3497661 by Guillaume.Abadie
Lets FLensDistortionCameraModel::GetUndistortOverscanFactor() early return 1.0 if the camera model is does an identity transform.
Change 3497969 by Richard.Wallis
Fix for start Up Movies Are not Playing for iOS Devices. Handle case when movie is loading aysnc in background - need to wait for state changes otherwise it skips intermediate movies.
- Tested on iOS and Mac.
#jira UE-39585
Change 3498035 by Guillaume.Abadie
Polishes //Engine/Plugins/Compositing/LensDistortion/Shaders/Private/UVGeneration.usf from debuging artifacts.
Change 3498101 by Rolando.Caloca
DR - Compile fix
Change 3498254 by Guillaume.Abadie
Exposes comparing FLensDistortionCameraModel to blueprint with == and != operator nodes for cross frame uv displacement map caching.
Change 3498264 by Guillaume.Abadie
Integrate 3267269: Implements SceneCaptureComponent2D::bCameraCutThisFrame
Change 3498371 by Yujiang.Wang
Fix for UE-46149 Planar Reflections display screenspace info when viewports are >2
* Prevent planar reflections being rendered when ViewIndex >= GMaxPlanarReflectionViews
* Now planar reflections in >2 viewports will fallback to other reflection methods (SSR, reflection captures)
#jira UE-46149
Change 3498409 by Rolando.Caloca
DR - Swap resolves
Change 3498410 by Guillaume.Abadie
Adds support for opacity output alpha for post process material when doing a draw material to render target.
Change 3498705 by Rolando.Caloca
DR - Add UID for debugging mem allocations
Change 3498759 by Marcus.Wassmer
No post processing in vertexcolor view mode
#jira UE-44704
Change 3498891 by Rolando.Caloca
DR - Minor Vulkan per frame allocator refactor in prep for changes
Change 3499206 by Rolando.Caloca
DR - Fix temp frame allocator OOM on Vulkan
#jira UE-45913
Change 3499319 by Rolando.Caloca
DR - Vulkan support for StorageBuffer
Change 3499339 by Rolando.Caloca
DR - Remove deprecated typedef
Change 3499400 by Rolando.Caloca
DR - Remove some RHICmdList deprecated functions
Change 3499422 by Rolando.Caloca
DR - Allow buffer transitions inside render passes
Change 3500370 by Rolando.Caloca
DR - Compile fix
Change 3500474 by Rolando.Caloca
DR - Fix static analysis
Change 3500517 by Guillaume.Abadie
Exposes r.PostProcessing.PropagateAlpha to the renderer settings.
Change 3500537 by Guillaume.Abadie
Fixes a bug where scene capture WorldToView matrix would get scale != 1 when scaling the scene capture actor in the world.
#jira UE-39389
Change 3501069 by Mark.Satterthwaite
Bring back temporary 4.16 fix for iOS 9 (CL #3425995) into Dev-Rendering for 4.17 as a real fix will need to wait for 4.18.
temporary fix for skewed textures on IOS 9
#jira UE-44468
Change 3501164 by Michael.Lentine
PR #3402: UE-43131: Format argument count not equal to actual arguments (Contributed by projectgheist)
Change 3501222 by Benjamin.Hyder
Checking in Tm_SobolNoise map
Change 3501612 by zachary.wilson
Adding testing content for RTDF shadows on planar reflections
Change 3501708 by Guillaume.Abadie
Break FPostProcessSettings into smallers structs.
Change 3501830 by Olaf.Piesche
#jira UE-39628; using fix proposed in UDN, will investigate further
Change 3501954 by Marcus.Wassmer
Duplicate 3480903
Light culling safety measures.
Change 3502032 by Mark.Satterthwaite
Fix generation of Metal precompiled headers for the bytecode compiler when using Xcode 9.
Change 3502118 by Uriel.Doyon
Fixed shader compilation issues.
Change 3502191 by Guillaume.Abadie
Implements Composure plugin to make compositing in UE4 easier.
Change 3502192 by Guillaume.Abadie
Implements Composure feature testing in EngineTests
Change 3502196 by Guillaume.Abadie
Creates a dependency of Composure plugin over LensDistortion plugin.
Change 3502213 by Arciel.Rekman
Fix for loading shaders on Linux (UE-46276).
Change 3502243 by Brian.Karis
Bent normal map support.
Multibounce AO.
Spherical Gaussian based specular occlusion.
Change 3502506 by Guillaume.Abadie
Fixes compilation failure in Composure with unity build.
Change 3502507 by Guillaume.Abadie
Fixes composure Set Pass with Render Target blueprint helper.
Change 3502510 by Guillaume.Abadie
Attempts to fix ComposureUtils.cpp compile errors.
Change 3502515 by Guillaume.Abadie
Some other composure failure fixes.
Change 3502545 by Guillaume.Abadie
Fixes some unity build related error in Composure.
Change 3502548 by Guillaume.Abadie
Fixes last missing includes in ComposurePostProcessPass.cpp
Change 3502672 by Guillaume.Abadie
Fixes linux warning in Composure.
Change 3502790 by Ryan.Brucks
float4 PseudoVolumeTexture: Fixed frame layout being a float instead of float2. Now works correctly with non-square frame layouts. Only called in custom nodes and calling with a float still functions properly so no old content will break.
Change 3502836 by Guillaume.Abadie
Propagates scene capture engine showflag changes from blueprint editor to the blueprint instances.
#jira UE-6810
Change 3503096 by Guillaume.Abadie
Resave a unversioned asset.
Change 3503228 by Yujiang.Wang
Fix for UE-45646 Dynamic Light placed inside of a Dynamic Static Mesh doesn't pass through the geometry
* Bug caused by bReflectiveShadowmap not being passed into SetViewFlagsForShadowPass
* Replaced the true with bReflectiveShadowmap
#jira UE-45646
Change 3503284 by Rolando.Caloca
DR - Fixed initial clear on rendertargets
- Added support for r.Vulkan.EnableValidation 1, 2, 3 & 4
- Dump the vulkan log into VS output log
- Added validation for layouts when using dump log
Change 3503545 by Arciel.Rekman
Fix black UI on Linux (UE-46333)
- Rebuilt hlslcc with clang 3.7.0. Whatever issues we're running in with newer clangs still seem to persist.
#jira UE-46333
Change 3503638 by Daniel.Wright
[Copy] Changed DynamicBentNormalAO back to fp16, as PF_FloatR11G11B10 was not enough precision and introduced banding
Change 3503787 by Marcus.Wassmer
Fix difference between gpu/cpu morph target application
Change 3503902 by Marcus.Wassmer
Roll back TAA refactor until we have time to look into the bad interaction with DOF.
Change 3503953 by Arne.Schober
DR - UE-46319 - borked Reflections: The resource transition needs to be in this weired place for PS4 and switch until we teach the interface to know about subresources.
#RB Marcus.Wassmer
Change 3504131 by Rolando.Caloca
DR - Maintain a cache of pipeline and descriptor set layouts
- Fix marker dump
Change 3504462 by Guillaume.Abadie
Fixes an assertion failure that was failing because compute light grid was not done, but the shader used where not necessarily using compute light grid results.
#jira UE-46277
Change 3504779 by Chris.Bunner
Potential static analysis fix.
#jira UE-46360
Change 3504950 by Marc.Olano
Allow Sobol material nodes & textures only if feature level is at least ES3.1
#jira UE-46334
#jira UE-46317
Change 3505035 by Daniel.Wright
Increased MaxSearchCount in GetShaderIncludes. The previous limit of 20 is now getting hit in BasePassPixelShader.usf, causing compiles to fail erroneously.
Change 3505386 by Daniel.Wright
GetShaderIncludes handles infinite recursion gracefully, needed by Metal causing BasePassTessellation.usf to include BasePassVertexShader.usf
Change 3505491 by Rolando.Caloca
DR - Fix crash on first frame of particles on modern APIs
Change 3505557 by Chris.Bunner
[Duplicate] Workaround for outdated shader map crash.
#jira UE-46061
Change 3506071 by Rolando.Caloca
DR - Vulkan fixes
- Fix copy out of bounds reading textures to CPU
- Defer event deletion
- Split validation for errors and warnings
- Skip validation error about attachment not used
Change 3506698 by Guillaume.Abadie
Fixes Composure alpha channel clobering and performance regression in bloom and tonemapper passes caused by scene capture API compatibility breakage brought by Fortnite merge.
Change 3506797 by Rolando.Caloca
DR - Fix static analysis
#jira UE-46428
Change 3506861 by Rolando.Caloca
DR - Fix crash due to layering violation
#jira UE-46424
#jira UE-46431
Change 3508098 by Rolando.Caloca
DR - Fix for Vulkan ES31 crash
- Fix for AMD ensure
Change 3508123 by Rolando.Caloca
DR - Disable occlusion queries on Vulkan to avoid flickering
- Fix for bad HZB & cube mips on Vulkan (now using RHIGenerateMips)
- Fix for decal blending
#jira UE-46376
Change 3509064 by Uriel.Doyon
Changing the logic arround generating an error when HasHadBulkDataCleared() so that it only triggers if the DDC are not found.
#jira UE-46427
Change 3509854 by Marc.Olano
Fix 2D Sobol gray code numbers.
Just changes some numbers in initialization tables, so no effect on existing tests or content.
Change 3509920 by Marcus.Wassmer
Fix LPV fastvram ensure
Change 3509937 by Rolando.Caloca
DR - Fix crash due to deleted viewport
#jira UE-46281
Change 3509988 by Marcus.Wassmer
Roll back part of Sobol fix to avoid full shader recompile for integration.
Change 3510255 by Rolando.Caloca
DR - Fix popup window ensure
#jira UE-46511
Change 3510646 by Marcus.Wassmer
fix ios compiles
Change 3511442 by Rolando.Caloca
DR - Change mesh simplification check to ensure/checkslow to unblock
#jira UE-46538
DONE!
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
CHANGES WITH MULTIPLE PLATFORMS!!! YOU MUST COPY THESE INTO THE OTHER ONES AS MAKES SENSE!!
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
Change 3467095 by Guillaume.Abadie
Nukes all += TEXT(".usf")
#jira UE-45530
Change 3475084 by Guillaume.Abadie
Fixes compilation failure of the shader compiler on PS4 and XboxOne
Change 3477464 by Guillaume.Abadie
Fixes dumpshaderinfo that generate unecessary sub directory, breaking shell scripts.
Change 3494395 by Guillaume.Abadie
Moves all engine shader files into Public and Private directory, and introduce the .ush extensions for header file that do not contains entry points.
DONE!
[CL 3511602 by Marcus Wassmer in Main branch]
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3388286 on 2017/04/11 by Chris.Bunner
Fix mips in texture GnmUAV creation.
Change 3388287 on 2017/04/11 by Chris.Bunner
Improved PS/CS code sharing for TemporalAA.
Change 3388291 on 2017/04/11 by Chris.Bunner
HLODs now correctly hide their children in shadow maps.
Propagate bCastFarShadow flag on HLOD generation.
#jira UE-42254
Change 3388448 on 2017/04/11 by Brian.Karis
Better handle divide by zero
Change 3388449 on 2017/04/11 by Brian.Karis
Optimizations to shading model math.
PR #3340: Bug fixes related to shader TODOs (Contributed by vgfx)
Change 3388455 on 2017/04/11 by Uriel.Doyon
Changed Remove for RemoveSwap when clearing dynamic component references
Change 3388612 on 2017/04/11 by Simon.Tourangeau
Support shaders in projects and in plugins
When searching for a shader it will
- First look in Engine/Shaders as usual
- Then in project's Shader folder
- Then in all enabled plugin Shader folders
Project or plugin must be loaded in PostConfigInit phase
Tested in PIE, engine (cooked, packaged)
Change 3388819 on 2017/04/11 by Arne.Schober
DR - Faster MorpthTarget implementation. Changed the previous Gather aproach to a scatter based one. Reaching about 110GB/s on PS4 which is up to 4x faster than the previous implementation. On PC DX11 the impact is lower due to unecessary UAV barriers but still 2x faster on AMD and up to 6x faster on Nvidia Hardware.
#RB Lina.Halper, Rolando.Caloca
Change 3388862 on 2017/04/11 by Guillaume.Abadie
Allows Motion Blur and TAA in scene capture 2d.
Change 3388953 on 2017/04/11 by Uriel.Doyon
Fixed issue where lights from hidden levels where affecting the lighting build, by checking if the light is registered before adding it.
#UE-43220
Change 3389138 on 2017/04/11 by Arne.Schober
DR - Fix crash when opening a Level without Contentbrowser open.
#RB Matt.Kuhlenschmidt
Change 3389400 on 2017/04/11 by Uriel.Doyon
- Renamed FMaterialResource::IsSeparateTranslucencyEnabled() to FMaterialResource::IsTranslucencyAfterDOFEnabled()
- Removed different logic to determine if translucency after DOF was enabled, and centralized it into a single function: FSceneViewFamily::AllowTranslucencyAfterDOF()
- FSceneRenderTargets::FinishRenderingSeparateTranslucency() now only resolves a single view, allowing better Begin/Finish scopes.
- Renamed FSceneRenderTargets::SeparateTranslucencyDepthRT into FSceneRenderTargets::DownsampledTranslucencyDepthRT since this one is only allocated when rendering in downsampled mode.
- Standard translucency is now rendered in the same resolution than translucency after DOF. (downsampled or full resolution)
- Removed RenderTranslucencyParallel and merged it's logic into RenderTranslucency. Renamed DrawAllTranslucencyPasses to RenderViewTranslucency and added a parallel version RenderViewTranslucencyParallel.
- Moved all debug draw logic (VisualizeLPV, ViewMeshElements and SimpleElementCollector) to a common place.
- New option "r.AllowDownsampledStandardTranslucency" to control the downsampling of standard translucency. Affect blend module materials
#jira UE-39505
Change 3389860 on 2017/04/12 by Richard.Wallis
UE-41407 Cable actor does not render correctly in viewport on Mac.
Build the mesh at creation time - call into exisiting mesh create function.
Change 3390933 on 2017/04/12 by Arne.Schober
DR - potential fix for UE-43125 where the this pointer might get invalidated in the middle of the function
#RB Marcus.Wassmer
Change 3391010 on 2017/04/12 by Ben.Marsh
Compile UE4Game non-unity for Mac as part of nightly builds in //UE4/Dev-Rendering.
Change 3391412 on 2017/04/12 by Uriel.Doyon
Mesh Decals are now sorted according to the component TranslucencySortPriority.
#jira UE-43053
Change 3392117 on 2017/04/13 by Guillaume.Abadie
Integrates Raven's experimental PCSS for cascaded shadow map hidden behind a CVar.
Change 3392179 on 2017/04/13 by Guillaume.Abadie
Attempts to fix linux compilation by removing mistakenly submitted dead code.
Change 3392231 on 2017/04/13 by Guillaume.Abadie
Fixes a wrong enum value real quick in FRenderingObjectVersion I introduced after main integration... Oups...
Change 3393879 on 2017/04/14 by Guillaume.Abadie
Attempts to fix linux compilation warning.
Change 3393881 on 2017/04/14 by Guillaume.Abadie
Back out changelist 3393879
Change 3393882 on 2017/04/14 by Guillaume.Abadie
Attempts #2 to fix linux compilation error.
Change 3394100 on 2017/04/14 by Chris.Bunner
Corrected material shared sampler usage with mip-biasing.
Change 3394174 on 2017/04/14 by Rolando.Caloca
DR - Change ensure to warning
Change 3394221 on 2017/04/14 by Marcus.Wassmer
Fix poseable mesh bounds calculation.
Change 3396238 on 2017/04/17 by David.Hill
Fix Bloom with LensFlare
Duplicating fix - will also fix directly in 4.16
#jira 44050
Change 3397055 on 2017/04/17 by Joe.Graf
Fixed Windows specific assumptions in Slate File Dialog Window's file filtering that lead to crashes
#CodeReview: matt.kuhlenschmidt
#rb: n/a
Change 3397921 on 2017/04/18 by Joe.Graf
Rewrote SlateFileDlgWindow's file filtering to allow for extensionless file selection and to remove the O(n^2) file filtering
#CodeReview: arciel.rekman, matt.kuhlenschmidt
#rb: n/a
Change 3398406 on 2017/04/18 by Rolando.Caloca
DR - Fix shaders in plugins on Mac
Change 3399546 on 2017/04/19 by Benjamin.Hyder
Updating content for test levels (HDR, Bloom_FFT, DistanceFields_IndirectShadows)
Change 3399725 on 2017/04/19 by Guillaume.Abadie
Avoids compiling PCSS shaders for SM4.
Change 3400295 on 2017/04/19 by Michael.Trepka
Fixed metal shader compile errors in MorphTargets.usf
Change 3400457 on 2017/04/19 by Michael.Trepka
Merged Rolando's shader fixes
Change 3400473 on 2017/04/19 by Arne.Schober
DR - provide Aftermath Reason when init failed.
#RB none
Change 3400699 on 2017/04/19 by Arne.Schober
DR - Fixed Text macro
#RB none
Change 3402280 on 2017/04/20 by Simon.Tovey
Minor cascade fix
#tests no crash
#jira UE-41560
Change 3402517 on 2017/04/20 by Arne.Schober
DR - Fix static analysis warning
#RB none
Change 3403897 on 2017/04/21 by Arne.Schober
DR - [UE-43898] - Someone missed a shaderversion bump which poisoned the DCC
#RB None
#jira UE-43898
Change 3404591 on 2017/04/21 by Olaf.Piesche
#jira UE-41979
Should never be crashing there, unless the mesh is changed after Init of the effect instance; this change safeguards against the number of mesh sections (and hence materials) changing after creation of the dynamic data to avoid the crash.
Change 3407451 on 2017/04/25 by Daniel.Wright
Fixed Indirect Lighting Cache updates caused by capsule indirect shadows forcing point samples, breaking primitives using ILCQ_Volume
Change 3407452 on 2017/04/25 by Daniel.Wright
Added r.AOJitterConeDirections, although disabled by default because it requires the temporal filter to be much stronger
Change 3408397 on 2017/04/25 by Daniel.Wright
ViewFamily.bRealtimeUpdate is set to false if Slate is throttling (like when toggling show flags). Volumetric fog discards the temporal history when not realtime, so you can see changes immediately.
Change 3408428 on 2017/04/25 by Daniel.Wright
Changed 'r.AOMaxObjectsPerCullTile' default back to 512 as 256 causes artifacts with RTDF shadows
Change 3409764 on 2017/04/26 by Daniel.Wright
Force dumping shader debug info for Global shaders when r.ShaderDevelopmentMode is enabled. Most of the shaders you want to look at in a GPU capture are global shaders, and global shaders create few debug files. 'recompileshaders global' time 35s -> 38s for SM5.
Change 3411659 on 2017/04/27 by Daniel.Wright
[Copy] Set Xbox One engine default screen percentage to 83.33 (1600x900), as ESRAM choices are dependent on this
Change 3411660 on 2017/04/27 by Daniel.Wright
[Copy] Global distance field composite shader has a version for each flattened axis, which improves efficiency when updating a slab which is what camera movement typically causes
Change 3411667 on 2017/04/27 by Daniel.Wright
[Copy] Discard distance field AO history buffer if it doesn't match the new buffer size. This prevents reading uinitialized data after a scene render target resize.
Change 3411668 on 2017/04/27 by Daniel.Wright
[Copy] Better indirect capsule shadow draw event info
Change 3411669 on 2017/04/27 by Daniel.Wright
[Copy] Pass down FeatureLevel to AddSubjectPrimitive and GatherShadowsForPrimitiveInner instead of calling the scene's virtual function. Showed up prominently in a sampling profile.
Change 3411755 on 2017/04/27 by Daniel.Wright
[Copy] Occlusion queries are now always done before the base pass if a nearly full prepass is being used(DDM_AllOccluders or DDM_AllOpaque)
* Removed r.OcclusionQueryLocation
Change 3411827 on 2017/04/27 by Daniel.Wright
[Copy] Much cheaper implementation of IsForwardShadingEnabled which showed up prominently in sampling profiles - inlined function and no more unnecessary thread safety overhead
Change 3411829 on 2017/04/27 by Daniel.Wright
Added an ensure to console manager when doing FindTConsoleVariableData* on a FAutoConsoleVariableRef
Change 3411837 on 2017/04/27 by Daniel.Wright
[Copy] Worked around slow memcpy's being used to sort FSortedLightSceneInfo
Change 3411838 on 2017/04/27 by Daniel.Wright
[Copy] Skip tracking MaterialRenderProxyMap on cooked platforms
Change 3411843 on 2017/04/27 by Daniel.Wright
[Copy] Fixed r.ParallelShadows on PS4 and enabled by default engine-wide (saves 5ms RT with CSM)
* Gnm was not tracking DepthClearValue when a depth target was set but not cleared
* Gnm has a bug where TargetsNeedingEliminateFastClear does not persist across commandlist breaks. Moved FinishRenderingGBuffer before RenderShadowDepthMaps to workaround (accidentally not in this changelist)
* Shadow depth rendering was not using BindClearMRTValues to populate GNM parallel commandlist TargetsNeedingEliminateFastClear values
Change 3411873 on 2017/04/27 by Daniel.Wright
[Copy] Deferred uniform expression caching. Setting multiple parameters on a material only causes its uniform expressions to be recached once.
* 280 calls to CacheUniformExpressions -> 120 during Fortnite combat (6.5ms -> 3.4ms)
Change 3411891 on 2017/04/27 by Daniel.Wright
[Copy] GatherShadowPrimitives optimizations
* Total GatherShadowPrimivies went from 2.3ms -> 1.3ms on PS4 with these changes in GPUPerfTest (duplicated 3x)
* Much flatter primitive octree (16 -> 256 max primitives)
* Primitives are culled against the shadow frustum before FPrimitiveSceneInfo or FPrimitiveSceneProxy are dereferenced in FilterPrimitiveForShadows
* FilterPrimitiveForShadows work is done in a ParallelFor. Primitive octree nodes are processed in different jobs.
* StaticMeshWholeSceneShadowBatchVisibility now only stores entries for meshes with bRequiresPerElementVisibility (landscape). Previously it was allocating and zeroing 500Kb 3x per frame (main view + 2 cascades) which cost ~.8ms on PS4.
Change 3412192 on 2017/04/27 by Michael.Trepka
Fixed Clang compile errors in FortniteGame, partial copy of CL 3313426
Change 3412547 on 2017/04/27 by Daniel.Wright
Fixed leak of FShadowMapAllocation and FLightMapAllocation's found by licensee
Change 3414239 on 2017/04/28 by Arne.Schober
DR - UE-44500 - Removed use of Structured Buffer from MorphTargets due to HLSLCC not supporting it.
#RB none
#jira UE-44500
Change 3414754 on 2017/04/28 by Daniel.Wright
Added VolumetricFogEmissive to ExponentialHeightFogComponent
* Volumetric fog does not yet support precomputed lighting, so this is the only way to get an ambient lighting term
Change 3416859 on 2017/05/01 by Arne.Schober
DR - Remove FeatureLevel from the Clear Functions to reduce area of error
#RB Rolando.Caloca
Change 3420750 on 2017/05/03 by Arne.Schober
DR - [UE-44497] - Fix several PS4 validation layer issues
#RB Marcus.Wassmer
Change 3422869 on 2017/05/04 by Benjamin.Hyder
Fix compile error from merge.
Change 3423938 on 2017/05/04 by Marc.Olano
[UE-44453] Fix bloom problems by moving saturate after vector math
Change 3424494 on 2017/05/04 by Olaf.Piesche
#jira UE-44589
When using FindTCosoleVariableData, the CVar can not be an FAutoConsoleVariable.
#tests as described in jira ticket
Change 3424754 on 2017/05/04 by Uriel.Doyon
Fixed call to get texture compressor module outside the main thread.
#jira UE-42168
Change 3425447 on 2017/05/05 by Uriel.Doyon
#buildfix
Change 3427042 on 2017/05/05 by Arne.Schober
DR - Fix one of my typos
#RB none
Change 3428119 on 2017/05/08 by Marcus.Wassmer
Fix UE-44733
static analysis warning.
Change 3428222 on 2017/05/08 by Uriel.Doyon
Fixed bad condition in translucency rendering
#jira UE-44452
Change 3429794 on 2017/05/08 by Uriel.Doyon
Fixed issues with lightshafts and low res translucency.
#jira UE-44452
Change 3430921 on 2017/05/09 by Rolando.Caloca
DR - Get additional function pointers for D3DReflect, Compile and Disassemble instructions from the same DLL when compiling D3D11 shaders.
- Also fixes using the correct fxc.exe path to match the DLL we distribute.
Change 3431156 on 2017/05/09 by Rolando.Caloca
DR - Remove unused code
Change 3431396 on 2017/05/09 by David.Hill
Copy of changes made directly in 4.16 ( CL 341037 )
to be submitted to dev-rendering
#jira UE-44641
Change 3431400 on 2017/05/09 by Rolando.Caloca
DR - Fix typo
Change 3431527 on 2017/05/09 by David.Hill
#rb: none
Oops.
comment out r.ShaderDevelopmentMode =1
Change 3431590 on 2017/05/09 by Daniel.Wright
Removed early return landmine in USceneCaptureComponent2D::Serialize
Change 3431591 on 2017/05/09 by Daniel.Wright
Disallow map building while in PIE, or PIE while buildling lighting
Change 3431594 on 2017/05/09 by Daniel.Wright
Added RenderTargetFormat to UTextureRenderTarget2D, with choices of 8 bit, 16fp, 32fp and 1, 2 or 4 channels.
Change 3431667 on 2017/05/09 by Daniel.Wright
Volumetric fog now supersamples lighting when the history is not available, reducing noise on areas that just came on-screen or after a camera cut.
* The number of samples is controlled by r.VolumetricFog.HistoryMissSupersampleCount, defaults to 4, cinematic scalability uses 16
* Under fast camera movement, volumetric fog cost went from 1.79ms -> 1.97ms with 4 samples, on a 970GTX
Change 3432366 on 2017/05/10 by Richard.Wallis
Fix for MetalRHI Asserts When Using "Profile GPU" With RHI-Thread/Parallel-Execution. Don't insert events when not in RHIThread or the actual single-threaded-render thread.
#jira UE-36006
Change 3432367 on 2017/05/10 by Richard.Wallis
Fix for Metal ReStartRenderPass assert with profiling. macOS metal asserts when using "profileGPU" even with -norhithread argument set.
Added no action to the allowed render pass restart store actions for the depth buffer avoiding the assert. Interested to know the details if this is not a valid assumption to make - throwing away the depth buffer after a render pass I think would be a common case.
#jira UE-44322
Change 3432409 on 2017/05/10 by Richard.Wallis
Merged across CL 3415890 from Release-4.16 fix for (jira UE-43895)
Fix for deferred store actions getting cleared when we don't have a valid render target.
Change 3432833 on 2017/05/10 by Daniel.Wright
Fixed Ocean compile error
Change 3432874 on 2017/05/10 by Marc.Olano
Improved captions for Noise and VectorNoise material nodes
Change 3432947 on 2017/05/10 by Richard.Wallis
Fix for shared Material Native Shader Libraries Don't Function With Iterative Cooking. Keep latest versions of shader byte code in native shared material packaged build in an intermediate directory than can be reused on a later iterative cook.
- Doesn't handle deletion of the intermediate directory contents. Assumed to be a higher level requirement on non iterative cook flag.
#jira UE-44657
Change 3433484 on 2017/05/10 by Arne.Schober
DR - UE-44393 - Move ShaderPlatform into TShaderMap for extra debuginformation when it fails to find a proper shader. Also log when Gobalshaders are verified and recompiled.
#jira UE-44393
#RB Daniel.Wright
Change 3433515 on 2017/05/10 by Arne.Schober
DR - Fix a bug where recompileshaders changed while compiling causes a crash where the chached local vertex factories are mutated while been used.
#RB Daniel.Wright
Change 3433606 on 2017/05/10 by Daniel.Wright
Fixed static shadowing of volumetric fog and translucency causing shadowing past the lightmass importance volume.
Change 3433619 on 2017/05/10 by Daniel.Wright
Skip recapturing reflection captures when PropagateLightingScenarioChange is being called for a level unload. This leaves stale results in reflection captures around when hiding a level in the editor, but avoids the double recapture that happens when swapping lighting scenarios in game, and the unnecessary reflection capture update when exiting PIE.
Change 3433795 on 2017/05/10 by Arne.Schober
DR - add cmdline to select a GPU vendor when multiple GPUs from differnt Vendors are installed into the same Machine
#RB marcus.Wassmer
Change 3433941 on 2017/05/10 by Daniel.Wright
Cone vs tile bounding sphere intersection tests for Light Grid culling of spotlights, which provides much tighter culling than just View space tile AABB vs light bounding sphere.
* Forward shading BasePass 3.7ms -> 2.4ms in a scene with 24 spotlights on 970GTX
* Volumetric fog 2.87ms -> 2.09ms in the same scene
Change 3435139 on 2017/05/11 by Daniel.Wright
Restored GTextureRenderTarget2DMaxSizeX which is used by Ocean
Change 3435297 on 2017/05/11 by Arne.Schober
DR - Remove manual AlignOf and use C++11 keyword instead
#RB Steve.Robb
Change 3435367 on 2017/05/11 by Daniel.Wright
Circle vertex buffer for slightly tighter voxelization of volumetric fog shadowed lights
* 1.5ms -> 1.38ms on 970 GTX with 24 spotlights
Change 3435522 on 2017/05/11 by Brian.Karis
Dither opacity mask now stacks properly for non parallel polys. Dither is randomized by triangle normal.
Change 3436063 on 2017/05/11 by Daniel.Wright
Disabled CLB_AggressiveBatching for PC d3d12 as it causes flickering artifacts in lighting
Change 3436269 on 2017/05/11 by Uriel.Doyon
Fixed UVChannel data possibly not up-to-date depending on user manips.
Change 3436611 on 2017/05/12 by Simon.Tovey
Improved name and tooltip for static mesh property controlling generation of alias tables for uniform sampling.
Change 3436676 on 2017/05/12 by Simon.Tovey
Fix for fixed bounds being "invalid" unless set via the toolbar option.
Change 3436700 on 2017/05/12 by Simon.Tovey
Crash fix.
Issue found in https://udn.unrealengine.com/questions/355944/crash-in-fdynamicspriteemitterdatagetdynamicmeshel.html
Particle proxies would have stale material resource pointers if the material is changed while the system was invisible.
If the old material is freed during this time, the next time the system renders it will crash.
Change 3437367 on 2017/05/12 by Brian.Karis
Fixed bug with small UV charts not packing.
Change 3437860 on 2017/05/12 by Arne.Schober
DR - Fix alignment compile error in win32 where according to ABI alignment is 4 for int64
#RB none
Change 3437972 on 2017/05/12 by Arne.Schober
DR - Fix alignment compile error in win32 where according to ABI function calls cannot take alingned structures. In all of the cases the copy was completely unnecessary.
#RB none
Change 3437975 on 2017/05/12 by Chris.Bunner
Added calculation for MaterialParamsEx to MeshDecals.usf.
#jira UE-43052
Change 3438109 on 2017/05/12 by Rolando.Caloca
DR - Support for -nomcpp on SCW
Change 3438889 on 2017/05/15 by Chris.Bunner
Nullptr check in a few material uniform expressions.
Change 3439351 on 2017/05/15 by Chris.Bunner
Added tooltip to Power material expression.
Change 3439763 on 2017/05/15 by Daniel.Wright
Apply passed in DistanceBiasSqr to line lights - allows volumetric fog to reduce aliasing on line lights
Change 3439764 on 2017/05/15 by Daniel.Wright
Fixed order of operations with bTreatMaxDepthUnshadowed - manifested as unfiltered static shadow depth lookups
Change 3440722 on 2017/05/16 by Guillaume.Abadie
Exposes Scene capture's FOV to blueprints
Change 3441680 on 2017/05/16 by Uriel.Doyon
Added units to point light intensity, to allow the user to specify the value in candelas or lumens.
New point light actors now configure the intensity in candelas by default.
Replaced viewport exposure settings by an EV100 slider.
Hidding the tone mapper in the show flag now still applies the exposure.
Added a new AutoExposure method called EV100 which allows to specify :
- MinEV100, MaxEV100
- Calibration Constnat
- Exposure Compensation
#jira UE-42783
Change 3441884 on 2017/05/16 by Uriel.Doyon
Fixed StreamingDistanceMultiplier not being applied to the texture streaming data.
Change 3442800 on 2017/05/17 by Gil.Gribb
Fixed botched merge.
Change 3442896 on 2017/05/17 by Gil.Gribb
UE4 - Allowed the possibility of running the RHI "thread" on task threads instead and cleaned up and unified the conditionals involved. By default we still have a dedicated RHI thread because it tested slightly faster.
Change 3443951 on 2017/05/17 by Richard.Wallis
Added Apple override allocator macro - each command encoder type needs it's own allocator queue.
Change 3444787 on 2017/05/17 by Daniel.Wright
Fixed DBuffer decal default normal (used when DBuffer decals enabled, but not decals rendered) not reconstructing zero properly, adding -.008 to WorldNormal which then caused artifacts with forward lighting specular on materials with roughness near 0.
Change 3444882 on 2017/05/17 by Daniel.Wright
Added comment to FClearValueBinding::DefaultNormal8Bit to make the dependency on shader decode clear
Change 3444883 on 2017/05/17 by Brian.Karis
Improved contact shadows
Change 3445048 on 2017/05/17 by Daniel.Wright
Fixed particle lights in forward shading, they were not setting the lighting channel mask properly
Change 3445107 on 2017/05/17 by Michael.Trepka
Changed the order of operations in FMetalStateCache::SetRenderState to work around an issue with some Intel drivers where they would not recalculate the raster state in some edge cases.
#jira UE-43725
Change 3445212 on 2017/05/17 by Uriel.Doyon
Added a -CSV option to ListTextures command
Change 3445947 on 2017/05/18 by Richard.Wallis
Clone of Release-4.16 Stream CL 3437181 and CL 3442450 - fix(s) for black rendering on macOS El Cap with Nvidia GPU. Move sampling of EyeAdaption texture to pixel shader for Mac Metal using shader language version <= 1 only.
Change 3446545 on 2017/05/18 by Chris.Bunner
Removed hardcoded (and unused) MRT write from Decal shaders.
#jira UE-45095
Change 3446568 on 2017/05/18 by Marc.Olano
Sobol and image-based importance sampling C++ functions and blueprint nodes
Change 3446988 on 2017/05/18 by Marc.Olano
Fix build error: missing include
Change 3446990 on 2017/05/18 by Marc.Olano
Cell-indexed Sobol sampling for shaders (in MonteCarlo.usf) and materials (Sobol and TemporalSobol nodes)
Change 3447142 on 2017/05/18 by Rolando.Caloca
DR - RWLock instead of mutex for PSO cache
Change 3447144 on 2017/05/18 by Uriel.Doyon
Moved shading model code to SetGBufferFromShadingModel(). This allows the code to be reused in other shader files.
Change 3447794 on 2017/05/18 by Brian.Karis
Virtual texturing foundation code
Change 3448944 on 2017/05/19 by Arciel.Rekman
Fix non-unity Linux (and Mac, etc) builds.
- Mac fix is tentative, did not try.
Change 3449183 on 2017/05/19 by Marcus.Wassmer
Duplicate fix for reflection captures to happen after sequencer updates.
Change 3449196 on 2017/05/19 by Uriel.Doyon
Handling RCM_MinMax when reading FloatRGBA textures.
This fixes pixel inspector always reading 1 for scene color values greater than one.
Change 3451652 on 2017/05/22 by Rolando.Caloca
DR - Compile fix
#jira UE-45245
Change 3451660 on 2017/05/22 by Chris.Bunner
Additional compile fix.
#jira UE-45245
Change 3451897 on 2017/05/22 by Daniel.Wright
Moved RTDF shadow project back after the base pass, since it samples the GBuffer for subsurface shadowing. Removed r.DFShadowAsyncCompute which was relying on the previous ordering.
Change 3452055 on 2017/05/22 by Rolando.Caloca
DR - Switch compile fix
#jira UE-45265
Change 3452089 on 2017/05/22 by Rolando.Caloca
DR - Compile fix
#jira UE-45246
Change 3452108 on 2017/05/22 by Rolando.Caloca
DR - Compile fix
#jira UE-45246
Change 3452179 on 2017/05/22 by Brian.Karis
Exposed dimensions. Fixed static analysis.
Change 3452734 on 2017/05/22 by Daniel.Wright
When post processing is disabled, TPT_TranslucencyAfterDOF translucency gets forced into the standard translucency pass.
Change 3452770 on 2017/05/22 by Daniel.Wright
Static light source shapes drawn into reflection captures handle SourceLength via scaled sphere
Change 3452861 on 2017/05/22 by Rolando.Caloca
DR - Switch compile fix
Change 3452952 on 2017/05/22 by Brian.Karis
Small VT fixes
Change 3453647 on 2017/05/23 by Richard.Wallis
Fix for tessellation shaders on Mac (Metal v1.2) failing to compile.
#jira UE-45227
Change 3454844 on 2017/05/23 by Uriel.Doyon
Fixed extra X16 on some point lights
#jira UE-45250
Change 3454934 on 2017/05/23 by Chris.Bunner
Backing out changelists 3441680, 3454636 and 3454844 for the sake of integration stability.
Change 3457131 on 2017/05/24 by Arne.Schober
DR - [UE-45317] - Fix Depthbuffer not available for resolve in Forward mode
#jira UE-45317
#RB Chris.Bunner
Change 3457141 on 2017/05/24 by Marc.Olano
Sobol bug fixes
Change 3457953 on 2017/05/24 by Brian.Karis
Fix static analysis
#jira UE-45315
#jira UE-45314
#jira UE-45313
Change 3459064 on 2017/05/25 by Chris.Bunner
Fix for out of bounds material translation crash.
#jira UE-45406
Change 3459700 on 2017/05/25 by Brian.Karis
Revert using sprite index buffer because the vert order is different.
Change 3459847 on 2017/05/25 by Chris.Bunner
Fixing ensure in RenderTestMap.
[CL 3461201 by Chris Bunner in Main branch]
Ben Marsh
Marc Audy
Marcus Wassmer
Chris Bunner