Commit Graph

1630 Commits

Author SHA1 Message Date
luke thatcher
8bcaa1fff8 Remove use of SwitchPipeline at the bottom-of-pipe (i.e. during RHI command list execution).
- This was mainly used for bindless descriptor updates, where updates need to be applied to all GPU pipelines.
 - Switching pipeline can change the current active breadcrumb on the new pipeline. Doing this at the bottom-of-pipe is not possible as the start/end breadcrumbs for each command list must be known at dispatch time (before execution / translation).
 - Added EnqueueLambdaMultiPipe which passes an array of RHI contexts to the lambda. This generally replaces the FRHICommandListBase& which is handed down through the platform RHI.
 - EnqueueLambdaMultiPipe may only be called at the top-of-pipe.

Replace RHITransfer[...]UnderlyingResource with RHIReplaceResources on FDynamicRHI / platform implementations
 - Old function was always bottom-of-pipe, so couldn't call EnqueueLambdaMultiPipe. New function takes the RHICmdList and is called at top-of-pipe.
 - All resource types are merged into the same function (currently buffers and raytracing geometry).

Remove use of RHILockBuffer and RHIUnlockBuffer at the bottom-of-pipe
 - Since platform RHIs need to use EnqueueLambdaMultiPipe for buffer locks/unlocks, it is no longer possible to call RHILock/UnlockBuffer at the bottom-of-pipe.
 - Also, buffers locked on parallel translating command lists are broken. Lock/unlock calls RHIThreadFence(true), which flags the command list for single-thread translate, however calling this at the bottom-of-pipe is too late, as the decision to dispatch the command list in parallel has already been made.
 - Added checks in these functions to catch future use.

#rb zach.bethel
#jira UE-208823
[FYI] christopher.waters

[CL 32220227 by luke thatcher in ue5-main branch]
2024-03-13 13:49:59 -04:00
ronald koppers
d48fdfab3e Moved the new alert icons from the core to the editor style.
#jira UE-206167
#rb aditya.ravichandran, Patrick.Boutot

[CL 32183264 by ronald koppers in ue5-main branch]
2024-03-12 12:42:19 -04:00
ronald koppers
1ff5d795f2 Updated the UI style for the alert widget.
Besides updating the style, the following changes were made:
- Added support for alert actions. A new column can be added next to the action column with a TFunction. If such a column exists, the widget will add a transparent button behind the widget stack that will call the action when pressed.
- Added new icons for solid alerts, a badge overlay and a matching background.
- Fixed a bug where adding a row with an alert to a row with an alert and a parent would cause the parent to be incorrectly updated. The updates to the alerts was happening too frequently. This would also have caused issues with other updates such as a label rename. Instead now the updates only happen when it's explicitly required by an updated to the alert.

#jira UE-206167
#rb logan.buchy

[CL 32094522 by ronald koppers in ue5-main branch]
2024-03-07 13:51:05 -05:00
nick edwards
1f88ebd696 FSlateDrawElement::MakeGradient - pass along InGradientStops array to FSlateGradientElement::SetGradient to avoid a copy.
[CL 32087579 by nick edwards in ue5-main branch]
2024-03-07 11:07:29 -05:00
devin doucette
cc9e787c79 Deprecated fields on FPropertyTag that are now represented by its TypeName
#rb Steve.Robb
#rnx

[CL 31959452 by devin doucette in ue5-main branch]
2024-03-01 17:32:43 -05:00
jordan cristiano
f038bf6aeb Added profiler scope around new FSlateElementBatcher::AddCachedElements logic from 31164434.
#rb daren.cheng

[CL 31957898 by jordan cristiano in ue5-main branch]
2024-03-01 17:01:44 -05:00
luke thatcher
01203093c6 Deprecate:
- FRHITexture2D
 - FRHITexture2DArray
 - FRHITexture3D
 - FRHITextureCube
 - FTexture2DRHIRef
 - FTexture2DArrayRHIRef
 - FTexture3DRHIRef
 - FTextureCubeRHIRef

Replaced with FRHITexture and FTextureRHIRef

These types were unified in UE 5.1 and have been defined via "using" statements to the same underlying texture type for several engine releases.

#rb christopher.waters

[CL 31724002 by luke thatcher in ue5-main branch]
2024-02-22 11:38:35 -05:00
steve robb
148d4c61d5 Deprecated TIsTriviallyDestructible.
#rb devin.doucette

[CL 31695997 by steve robb in ue5-main branch]
2024-02-21 15:55:03 -05:00
steve robb
f8d47335a4 Replaced RemoveAt(N, 1, EAllowShrinking::*) with RemoveAt(N, EAllowShrinking::*).
[CL 31626444 by steve robb in ue5-main branch]
2024-02-19 16:51:58 -05:00
steve robb
f6dbc2efe2 Added RemoveAt*(Index, AllowShrinking) overloads to TObservableArray, TIndirectArray and FPreviewAssetAttachContainer to match TArray.
#rb robert.manuszewski

[CL 31623882 by steve robb in ue5-main branch]
2024-02-19 16:01:48 -05:00
batlam987
e1cebd117a Retainer: fix an issue with clipping that was not working in case Stencil clipping was used on elements inside the the retainer (which when using shear or non axis aligned rotation).
It was for instance preventing the display of the fill of the progress bar, if shear/rotation was applyed on it and it was used in a retainer.
It's not using the change of the PR as it was working only in some case: the clipping zone we use always start from 0,0, so using the size of the Retainer (like in the PR) if it was smaller than the window would lead to the element being clipped out if the retainer was too far from 0,0.
#11455
#jira UE-206460
#tests In PIE, put a progress bar inside a retainer and played with shear and rotation on both the retainer and the progress bar: the blue fill is now always displayed. Engine test retainer test still succeed. Validated curve editor was still working as expected. Tested that animation are still played properly on windows (in case of drag n drop).
#rb daren.cheng

[CL 31521994 by batlam987 in ue5-main branch]
2024-02-15 11:30:57 -05:00
jordan cristiano
e837f7542e Fixed FScopeCycleCounterSWidget not working in insights captures.
#rb evgenii.babinets, ionut.matasaru

[CL 31453349 by jordan cristiano in ue5-main branch]
2024-02-13 18:22:52 -05:00
jamie dale
c61859e22a Fix missing virtual destructor on ISlateBrushSource
#rb Derek.Truong
#rnx

[CL 31446143 by jamie dale in ue5-main branch]
2024-02-13 16:16:43 -05:00
mikko mononen
0c74f6c57c LayoutUtils: Change use of c++ concept to a template
#rb Mieszko.Zielinski

[CL 31417529 by mikko mononen in ue5-main branch]
2024-02-13 04:50:51 -05:00
sebastian arleryd
94576910cb Reduce vertical space consumed by title bar
The intent of this change is twofold. First, it fixes a bug where the min/max/close buttons overlapped the row of tabs in windows with a main menu. Second, it reduces the vertical space consumed by our windows in the area around the title bar, main menu, and tabs.

* Reduced height of SVG images used for the min/max/restore/close window buttons from 34 pixels to 23 pixels. This avoids an overlap of the min/max/close buttons and the row of tabs in windows with a main menu.
* Rebalanced padding around the Unreal icon in windows with or without a main menu. There is now at most 1 pixel more spacing below the logo than above where before it could be 3 to 8 pixels more below than above.
* Reduced padding between tabs and main menu.

Note that these changes are all within #if !PLATFORM_MAC, so the Mac should not be affected.

#jira UE-204349
#rb brooke.hubert

[CL 31377239 by sebastian arleryd in ue5-main branch]
2024-02-12 04:34:41 -05:00
mikko mononen
97baff6d1f Added layout new layout sizing rule SizeRule_StretchContent
- widgets size starts at desired size and is adjusted proportionally based in available space

#rb Patrick.Boutot, Vincent.Gauthier

[CL 31376889 by mikko mononen in ue5-main branch]
2024-02-12 03:37:58 -05:00
helge mathee
c2fe81f2fc Slate: move animated attribute from slatecore to slate
#rb sara.schvartzman
#jira UE-204843
#rnx

[CL 31286549 by helge mathee in ue5-main branch]
2024-02-08 05:59:30 -05:00
yohann dossantos
ad8c5d10f4 Font settings: hide monospace width when monospacing is disabled.
#tests Played with bForceMonospaced (aka Monospacing) bool (from text, common text, or rich text style in a datatable), MonospacedWidth visibility was updated accordingly.
#rb yohann.dossantos

[CL 31186922 by yohann dossantos in ue5-main branch]
2024-02-05 15:23:58 -05:00
daren cheng
6c08ae2bdf Fix Post Buffer updates not triggering with global invalidation due cached batch buffer use not being considered.
#rb daren.cheng
[FYI] alex.battista, Brian.Sprague

[CL 31164446 by daren cheng in ue5-main branch]
2024-02-04 18:03:48 -05:00
ben hoffman
0a6de35a5b Editor | Add functionality for automatic fixes in tokenized messages
This allows you to attach an automatic fix to any error or warning that may arise from eg. validation.

#jira none
#rb Julien.StJean

#ushell-cherrypick of 31124509 by gabriel.wreczycki

[CL 31126352 by ben hoffman in ue5-main branch]
2024-02-02 10:58:45 -05:00
aditya ravichandran
b5b88730c0 Details Panel Overrides UX updates:
Move icons into an editor folder so they don't get cooked
Change the override combo button to match the desired behavior

#jira UE-192063, UE-204831, UE-205036
#rb logan.buchy

[CL 31099835 by aditya ravichandran in ue5-main branch]
2024-02-01 15:41:22 -05:00
aditya ravichandran
2bfa482416 Submit missing stylesheet updates with overrides support
#jira UE-204605
#rb logan.buchy

[CL 31051148 by aditya ravichandran in ue5-main branch]
2024-01-31 11:43:42 -05:00
benoit gadreau
d38d726911 Constraints: move constraints related styles from core to control rig plugin
#rb aditya.ravichandran
#rnx

[CL 31045570 by benoit gadreau in ue5-main branch]
2024-01-31 09:13:24 -05:00
cody albert
265776bba1 Fixed issue where window would grow over time when launching PIE in a new editor window
#jira UE-189405

[CL 31018674 by cody albert in ue5-main branch]
2024-01-30 15:31:32 -05:00
benoit gadreau
ddbf3820d9 Constraints: enable setting properties when creating a new constraint
#jira UE-181854
#rb Mike.Zyracki

[CL 31003360 by benoit gadreau in ue5-main branch]
2024-01-30 08:13:23 -05:00