Commit Graph

11372 Commits

Author SHA1 Message Date
Devin Doucette
3d43db2d10 Fixed a crash on exit when init fails early
If PreInit fails before setting the command line, AppExit will fail in its last step because it attempts to access the command line.

#preflight 63755f97232e3d12cb57a744
#rb Joe.Pribele

[CL 23184789 by Devin Doucette in ue5-main branch]
2022-11-17 17:09:36 -05:00
Stu McKenna
11b83585ef - Sanitize asin / acos inputs to avoid NaNs
#rb patrick.kelly
#jira UE-170199
#preflight 637671c9aa7d7f87a699e8b0

[CL 23179974 by Stu McKenna in ue5-main branch]
2022-11-17 13:47:46 -05:00
carlmagnus nordin
f815a8a92f IoDispatcher: Fixed crash when requesting reads of 0 bytes
#preflight 6375edf0953c19d43557cb97
#rb per.larsson

[CL 23174498 by carlmagnus nordin in ue5-main branch]
2022-11-17 07:44:38 -05:00
bryan sefcik
d608130583 Tweaked unity sizes.
#jira
[FYI] joe.kirchoff
#preflight 63757482b6636838283838da

[CL 23172508 by bryan sefcik in ue5-main branch]
2022-11-17 00:29:06 -05:00
Jamie Dale
dfa485e6c8 Split the FText comparison API out of FText so that it can be used for FString
FTextComparison now exists to provide static access to the collated comparison functions of FText, without needing to actually create an FText to do the comparison.

This follows the pattern of things like FTextTransformer and FTextChronoFormatter.

#jira
#preflight 6374fd521d25fe8b932dac1d
#rb Leon.Huang

[CL 23164251 by Jamie Dale in ue5-main branch]
2022-11-16 17:37:18 -05:00
steve robb
1f445a2f7a Applied the same SupportsFreezeMemoryImage changes to TArray as to the other containers as in CL# 23153171.
#rb devin.doucette
#jira UE-170263
#preflight 6374edf3ee4d25f90a92d45f

[CL 23154837 by steve robb in ue5-main branch]
2022-11-16 11:14:41 -05:00
steve robb
2723aedc4a Moved all container-level instances of SupportsFreezeMemoryImage out of the class definition so that they can't require the full type definition.
Unified all container freezing function definitions to not use a helper class - neater and removes some PDB symbols.

#rb devin.doucette
#jira UE-170263
#preflight 6374311a32484253055217ef

[CL 23154078 by steve robb in ue5-main branch]
2022-11-16 10:21:23 -05:00
David Harvey
1cab40981d Clang warning fixes
#jira UE-163945
#rnx
#rb Nuno.Leiria
#preflight 6374b4491c114bec05f01873

[CL 23151994 by David Harvey in ue5-main branch]
2022-11-16 05:12:39 -05:00
Helge Mathee
ea718104dd RigVMN: lazy compute - core side
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/6374ab540c74adb48bd8bf96

[CL 23151939 by Helge Mathee in ue5-main branch]
2022-11-16 05:05:12 -05:00
florin pascu
76d38017d7 Added ECVF_ExcludeFromPreview to exclude ECVF_Scalability Cvars from the preview
#rb Josh.Adams, Jack.Porter
#jira UE-170009
#preflight 63749013953c19d435dc0d1b

[CL 23151913 by florin pascu in ue5-main branch]
2022-11-16 05:02:20 -05:00
daren cheng
4499f56eda Make PropertyPathHelpers call setters / getters.
Add support for generic structs to be passed to PropertyPathHelpers.
Fix PropertyPath Not working with TEnumAsByte types
Add TIsTEnumAsByte type trait.

#rb Patrick.Boutot Steve.Robb
[FYI] asil.karatas
#preflight 6373e45c953c19d435992ade

[CL 23148054 by daren cheng in ue5-main branch]
2022-11-15 19:45:22 -05:00
joe pribele
bc8fcc7f23 deprecating PRAGMA_DISABLE_OPTIMIZATION and PRAGMA_ENABLE_OPTIMIZATION replaced with
`UE_DISABLE_OPTIMIZATION` for temporary development and `UE_ENABLE_OPTIMIZATION_SHIP` to submit

`UE_DISABLE_OPTIMIZATION` will be an error on the farm in a future changelist
#p4v-preflight-copy 23129238
#preflight 6373dd34ee4d25f90a45aea4

[CL 23139676 by joe pribele in ue5-main branch]
2022-11-15 13:54:44 -05:00
carlmagnus nordin
72c3c99cf1 IoStoreReader: Fixed incorrect data being returned when reading partial chunks
#preflight 63735d0ab663683828ae8c34
#rb per.larsson

[CL 23133948 by carlmagnus nordin in ue5-main branch]
2022-11-15 06:20:34 -05:00
Rafa Lecina
df001c1d21 Support enable ARC in modules
#jira UE-107891
#review @Sam.Zamani @Bertrand.Carre @Chris.Varnsverry @Roman.Dzieciol @Josh.Adams  @Jack.Porter
#preflight

[CL 23133821 by Rafa Lecina in ue5-main branch]
2022-11-15 06:02:36 -05:00
henrik karlsson
5b96352978 Fixes for c++ headerunits/modules.
* Adding forward declarations
* Adding "inline" in front of const/constexpr variables in headers
* Adding includes
* A few moves of ctor/dtor to cpp file

#preflight 6372b3ac0c74adb48b49f313
#rb none

[CL 23130896 by henrik karlsson in ue5-main branch]
2022-11-14 19:59:41 -05:00
joe pribele
1d8537f20b changed PRAGMA_DISABLE_OPTIMIZATION to UE_DISABLE_OPTIMIZATION_SHIP
#preflight 6372ba60ee4d25f90ae3d207

[CL 23128414 by joe pribele in ue5-main branch]
2022-11-14 17:31:05 -05:00
henrik karlsson
56e354a63e [Core]
* Fixed so all headers that are supposed to be included independently can compile (there are headers that must be included through other headers)

* Added HEADER_UNIT_SKIP to headers that must be included through others

* Added HEADER_UNIT_UNSUPPORTED to headers that are not supported by platform but is part of the include list anyway (files in Clang folder and pthread files).

* Added HEADER_UNIT_UNSUPPORTED to headers that have bad dependencies and include files from modules they don't depend on. (KeyChainUtilities.h and PackageWriter.h)

#preflight 637281309e3bea8079feb733
#rb devin.doucette

[CL 23127795 by henrik karlsson in ue5-main branch]
2022-11-14 17:08:04 -05:00
joe pribele
242962a719 added new macro UE_DISABLE_OPTIMIZATION_SHIP to replace PRAGMA_DISABLE_OPTIMIZATION
will deprecate `PRAGMA_DISABLE_OPTIMIZATION `in a following changelist after converting code to use `UE_DISABLE_OPTIMIZATION_SHIP`

added `UE_CHECK_DISABLE_OPTIMIZATION` to check for
`UE_DISABLE_OPTIMIZATION` being left in by accident

will enable `UE_CHECK_DISABLE_OPTIMIZATION` in a following changelist
#preflight 6372b159953c19d43537b088

[CL 23126725 by joe pribele in ue5-main branch]
2022-11-14 16:37:00 -05:00
joe pribele
4e92aea636 fix for PrintScriptCallStack crashing when called from the immedieate window
changed `FWindowsPlatformMisc::IsLocalPrintThreadSafe` to return true if attached in the debugger this allows log calls to immediately print to the debug window

a follow up change is necessary to allow for attaching after the process has started
#preflight 63727f813248425305e8a6a1

[CL 23121763 by joe pribele in ue5-main branch]
2022-11-14 13:16:47 -05:00
martin ridgers
afdc3f0e6e Allow backtrace captures to vary in size on a per-platform basis.
Some platforms have threads with very small stacks that we don't appear to be able to control. This places a limit on how much stack is available to capture a callstack in situations where memory hooks are in place. Curl's host name resolving threads an the CurlCalloc() hooks are one such example.

#rb cm
#rnx
#preflight 636d00ad376a9cd6a8f4e22c
#ushell-cherrypick of 23076081 by Martin.Ridgers

[CL 23101615 by martin ridgers in ue5-main branch]
2022-11-11 13:31:18 -05:00
Catalin Dragoiu
2c65745543 Add options to the Insights Status Bar Widget
#rb Ionut.Matasaru
#jira UE-161773
#preflight 636e5b00ee4d25f90af1325a

[CL 23097615 by Catalin Dragoiu in ue5-main branch]
2022-11-11 09:46:20 -05:00
tiago costa
3512c8c0eb Support remainder operator in IntVector.
#rb Andrew.Davidson
#preflight 636e38dcbf76990b713835ab

[CL 23096095 by tiago costa in ue5-main branch]
2022-11-11 07:18:18 -05:00
brandon schaefer
68c446a297 Add support for an Allow Syscall filter file to be passed into the Engine (supports x64 and arm64)
This will cause any syscall *not* in the allow list to cause SIGSYS and then we will exit from our signal handler (unless our signal handler uses a syscall that is not supported in which case we will crash, though a core dump will need to be checked)

Requires explicitly calling this function where you want to actually *setup* the filters:
FPlatformMisc::SetupSyscallFilters();

To use:
-allowsyscallfilterfile=<path/to/allow_filter_file.txt>

Example of file:
read
write
open
mprotect 2 4 0 1

There are only two supported rules for the file:
<syscall_name>
<syscall_name> <syscall_arg_number_zero_based_index> <value> <allow> <check bit only>

#jira UE-169652
#rb Josh.Adams, Robert.Seiver, Calvin.Zheng
#preflight 636d44e81c14fe450503f5cf

[CL 23091532 by brandon schaefer in ue5-main branch]
2022-11-10 20:45:09 -05:00
edwin maynard
c4d4d16da4 [Backout] - CL23087318
[FYI] edwin.maynard
Original CL Desc
-----------------------------------------------------------------
Setting NetCL for 23.00

[FYI] stan.hormell

[CL 23091022 by edwin maynard in ue5-main branch]
2022-11-10 19:57:58 -05:00
edwin maynard
e6aa9476bc Setting NetCL for 23.00
[FYI] stan.hormell

[CL 23091017 by edwin maynard in ue5-main branch]
2022-11-10 19:57:53 -05:00