Commit Graph

4512 Commits

Author SHA1 Message Date
Jamie Dale
5e600ede87 Fixed FText::IdenticalTo comparing two instances with null localized strings as identical
Invariant and generated FText instances will have null localized strings unless they're persisted, and should never be considered identical to anything else.

#codereview Nick.Darnell
#rb none

[CL 8930134 by Jamie Dale in Dev-Editor branch]
2019-09-20 12:52:48 -04:00
Jamie Dale
3f2ecf7b57 Collection UX improvements
Revamped collection UI:
 - Uses a more modern design.
 - Adds the asset count to the collection view.
 - Adds the collections more prominently in asset tooltips.

Revamped sources panel UI:
 - Added a unified search for all aspects of the sources panel (paths, favorites, and collections).
 - Added a switcher for the paths and collections views, which auto-switches as you browse to paths or collections.
 - Collections are now visible by default, rather than hidden behind a View Option.

Improved Content Browser auto-complete:
 - Now lists collection and meta-data tag names, as well as the old class names.
 - Tokenizes the search terms to allow auto-complete on partial statements.
 - Note: Involves some breaking API changes to SAssetSearchBox to allow more complex filtering and auto-complete rules.

Added scripting API support:
 - Collections can now be created, destroyed, and manipulated via Python or Editor Utilities (editor-only, see the AssetTagsSubsystem API).
 - Collections can be queried both in-editor and at runtime (if cooked).

Added support for optionally "cooking" collections for use at runtime:
 - This only works for static collections, and adds their information to the asset registry meta-data.
 - See the AssetRegistry settings in BaseEngine.ini (bTagAllCollections, CollectionsToIncludeAsTags, and CollectionsToExcludeAsTags).
 - No collections are cooked by default.

#rb Chris.Gagnon

[CL 8847950 by Jamie Dale in Dev-Editor branch]
2019-09-18 16:53:27 -04:00
drichardson
d009e6a818 PR #6224: Shared pointer test fixes (Contributed by drichardson)
#jira UE-80468
#rb rex.hill

[CL 8760479 by Rex Hill in Dev-Editor branch]
2019-09-17 15:12:00 -04:00
Rex Hill
64d7948e9c Fix compile error with UnEdMode PostMessage on windows due to a window headers defining PostMessage
#rb none
#rnx
#fyi Ryan.Schmidt

[CL 8696305 by Rex Hill in Dev-Editor branch]
2019-09-16 14:06:18 -04:00
sebastian nordgren
e370eba6d1 FName::NameToDisplayString functionality reverted to its state prior to CL 7252282.
This has some poor behaviour around abbreviations followed by words (eg. "FBXEditor" -> "FBXEditor"), but behaves better for plurals of abbreviations (eg. "ImportLODs" -> "Import LODs").

The former can be worked around by adding an underscore to the variable name ("FBX_Editor"), or introducing an explicit meta DisplayName=.

Added a test to ensure that the "ImportLODs" behaviour is retained.

#jira UE-79834

#rb paul.chipchase

[CL 8634945 by sebastian nordgren in Dev-Editor branch]
2019-09-11 09:20:09 -04:00
Ryan Schmidt
27b45cfd8f Add the concept of being "Expired" to FChange custom changes that are emebedded inside Transactions.
If all FChange's in a Transaction are Expired, then Undo/Redo skips over that change.
Codepaths not using FChange are unaffected, and default FChange behavior is to never be expired, so this path should only be taken for new code.
#rb richard.talbotwatkins
#rnx

[CL 8618086 by Ryan Schmidt in Dev-Editor branch]
2019-09-10 14:23:12 -04:00
Cody Albert
e741c14bd9 Added ability to pass flags in to LoadFileTostring
Updated CSV reader to be able to read write-locked files

#rb none
#jira UE-58513

[CL 8614475 by Cody Albert in Dev-Editor branch]
2019-09-10 12:53:44 -04:00
Chris Gagnon
8388cba784 Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor) prep for copy up.
#rb none

[CL 8573147 by Chris Gagnon in Dev-Editor branch]
2019-09-09 11:59:53 -04:00
brandon schaefer
5fa2025616 Fix static analytics
#jira UE-79893
#rb Arciel.Rekman
#lockdown cristina.riveron

#ROBOMERGE-SOURCE: CL 8572145 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v407-8568993)

[CL 8572148 by brandon schaefer in Main branch]
2019-09-09 10:14:39 -04:00
David Harvey
9ce3fd38c3 ensure there are no null llm tags. hopefully temporary until a good repro is found for the null tag that's occuring in CIS.
#jira FORT-205487
#rb ben.woodhouse

[CL 8572066 by David Harvey in Main branch]
2019-09-09 09:59:30 -04:00
justin marcus
b54a538f4a Fix FIOSPlatformFile::ConvertToIOSPath not handling paths without trailing slashes.
[REVIEW] [at]Daniel.Lamb


#ROBOMERGE-SOURCE: CL 8569328 via CL 8569329 via CL 8569330 via CL 8569331 via CL 8569430
#ROBOMERGE-BOT: (v407-8568993)

[CL 8569433 by justin marcus in Main branch]
2019-09-08 20:58:50 -04:00
daniel lamb
ea07678e23 AddAdditionalRootDirectory now enforces a slash at the end.
[REVIEW] Justin.Marcus, Peter.Sauerbrei


#ROBOMERGE-SOURCE: CL 8568220 via CL 8568221 via CL 8568222 via CL 8568223 via CL 8568275
#ROBOMERGE-BOT: (v406-8472469)

[CL 8568283 by daniel lamb in Main branch]
2019-09-07 14:07:11 -04:00
Andriy Tylychko
e97da5606f missed a cosmetic improvement suggested during code review: static_cast<uint32>(-1) -> ~uint32(0)
#rb none
#fyi stefan.boberg

[CL 8568013 by Andriy Tylychko in Main branch]
2019-09-07 07:34:50 -04:00
Chris Gagnon
6f65d35a7a Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor) in prep for copy up
#rb none

[CL 8563299 by Chris Gagnon in Dev-Editor branch]
2019-09-06 19:11:19 -04:00
thomas engel
44d61ec364 fixed up case in which command line was queried before being initialized
#rb none


#ROBOMERGE-SOURCE: CL 8559438 via CL 8559452 via CL 8563016
#ROBOMERGE-BOT: (v406-8472469)

[CL 8563110 by thomas engel in Main branch]
2019-09-06 19:01:37 -04:00
Ben Marsh
78706bfd46 Move the Build.h include into Platform.h to prevent non-unity compile errors in Thread.h when HAL/Platform.h is included first.
#rb none
#jira UE-79906
#fyi Andriy.Tylychko

[CL 8560467 by Ben Marsh in Main branch]
2019-09-06 17:17:02 -04:00
dmitriy dyomin
7435c81e4c Undo CL 8486172. Issues with debug config and global constants initialization order
#ROBOMERGE-SOURCE: CL 8550156 via CL 8550171 via CL 8556025
#ROBOMERGE-BOT: (v406-8472469)

[CL 8556214 by dmitriy dyomin in Main branch]
2019-09-06 15:27:35 -04:00
michael trepka
365956a860 Fixed error message in CharTest
#jira UE-78951
#rb none
[FYI] Johan.Torp
#lockdown cristina.riveron

#ROBOMERGE-SOURCE: CL 8553363 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v406-8472469)

[CL 8553367 by michael trepka in Main branch]
2019-09-06 13:39:05 -04:00
Andriy Tylychko
105f8598b9 disabled false static analysis warning
#jira UE-79910
#rb none

[CL 8551669 by Andriy Tylychko in Main branch]
2019-09-06 11:36:55 -04:00
Andriy Tylychko
9c791155d7 added/fixed copyright notice
#jira UE-79907
#rb none

[CL 8551252 by Andriy Tylychko in Main branch]
2019-09-06 11:30:54 -04:00
brandon schaefer
b071fbe103 Only the token can be in the paren
#jira UE-79893
#rb none
#lockdown cristina.riveron

#ROBOMERGE-SOURCE: CL 8550616 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v406-8472469)

[CL 8550640 by brandon schaefer in Main branch]
2019-09-06 11:24:54 -04:00
brandon schaefer
8204f528c9 Fix static analytic warning
#jira UE-79893
#rb none
#lockdown cristina.riveron

#ROBOMERGE-SOURCE: CL 8547664 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v406-8472469)

[CL 8547705 by brandon schaefer in Main branch]
2019-09-06 10:49:58 -04:00
ben woodhouse
10b655d3f0 Add a delegate which fires when the startup loading screen is shown
Also add support for overriding the startup pak mount wildcard
#rb daniel.lamb,dan.phillips


#ROBOMERGE-OWNER: ben.woodhouse
#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 8511857 via CL 8511859 via CL 8511866 via CL 8512599 via CL 8513780
#ROBOMERGE-BOT: (v406-8472469)

[CL 8513797 by ben woodhouse in Main branch]
2019-09-05 20:16:57 -04:00
Andriy Tylychko
b8846758ac FThread as a simpler API for system threads compared with FRunnable/FRunnableThread.
The API modeled after `std::thread`.
The implementation is based on `FRunnableThread`.

#rb steve.robb stefan.boberg johan.torp

[CL 8511278 by Andriy Tylychko in Main branch]
2019-09-05 17:04:23 -04:00
peter sauerbrei
ef605bff84 fix for app flavor symbol naming
#rb thomas.ross


#ROBOMERGE-SOURCE: CL 8505679 via CL 8506436 via CL 8506461 via CL 8507328 via CL 8509623
#ROBOMERGE-BOT: (v406-8472469)

[CL 8510521 by peter sauerbrei in Main branch]
2019-09-05 16:04:36 -04:00