Commit Graph

158 Commits

Author SHA1 Message Date
cedric caillaud
95f4ca7bb6 Fix crash when loading some geometry collection asset missing mass/inertia attributes
- When attributes are missing we regenerate them   ( editor time only , so assets will be fixed next cook )
- in the future we should revise the way we cook those assets

#rb Jimmy.Andrews

[CL 33649235 by cedric caillaud in ue5-main branch]
2024-05-14 22:36:52 -04:00
cedric caillaud
c6f2fc4c7b Geometry Collection : Fix Nanite Index attribute being created with the wrong type (FBox) but being used as an int32
Note : this attribute does not seem to be used anywhere , will likely remove it in future changes

#rb Jimmy.Andrews
#jira UE-214890

[CL 33640820 by cedric caillaud in ue5-main branch]
2024-05-14 19:54:20 -04:00
sarah noonan
a586204e3f Update GeometryCollection memory count to be more accurate in obj lists.
#rb cedric.caillaud

[CL 33604206 by sarah noonan in ue5-main branch]
2024-05-13 10:37:06 -04:00
cedric caillaud
604109c3a3 Geometry collection : when loading geometry collection with older version of the implicits / sharedimplicits attributes, make sure to account for the fact that the collection may contains multiple of those
#rb vincent.robert
#jira UE-213338

[CL 33283210 by cedric caillaud in ue5-main branch]
2024-04-26 19:09:00 -04:00
jimmy andrews
9124ea5c41 Fix failed check on undo of geometry collection changes in fracture mode
#rb cedric.caillaud

[CL 32859852 by jimmy andrews in ue5-main branch]
2024-04-10 12:22:12 -04:00
michael forot
b6168a808d Boolean on the geometry collection to enable the convex optimization
#rb cedric.caillaud

[CL 32445886 by michael forot in ue5-main branch]
2024-03-22 15:20:59 -04:00
cedric caillaud
9c986f33b9 Geometry Collection : Fix potential crash in FillAutoInstanceMeshesInstancesIfNeeded if the index attribute is not fopund but the asset has auto instance meshes assigned
#jira UE-207298

[CL 31788798 by cedric caillaud in ue5-main branch]
2024-02-23 22:27:38 -05:00
shaun kime
a39e29500d Filtering out geometry collection editor data from memory calculations
#rb cedric.caillaud, benn.gallagher

[CL 31696127 by shaun kime in ue5-main branch]
2024-02-21 15:57:23 -05:00
cedric caillaud
81ed0d764e Fix crash in FillAutoInstanceMeshesInstancesIfNeeded if the AutoInstanceMeshIndex is missing while there's auto instanced mnesh assign to the asset
#jira UE-207298

[CL 31604478 by cedric caillaud in ue5-main branch]
2024-02-17 21:38:07 -05:00
arciel rekman
b34e7d240b Rename StripData methods to better reflect their semantics.
- Done in anticipation of adding new StripData flags.

[REVIEW] [at]Josh.Adams
#rb Josh.Adams

[CL 30384206 by arciel rekman in ue5-main branch]
2023-12-18 17:47:34 -05:00
Brice Criswell
76564a4230 Dataflow : GeometryCollection
- Crash when TransformStarts or InstanceCounts are empty.
#rb cedric.caillaud
#jira none

[CL 30363726 by Brice Criswell in ue5-main branch]
2023-12-15 17:46:59 -05:00
matt peters
d96bd0db63 GeometryCollection Indeterminism: Fix crash due to not calling ValidateSizeSpecificDataDefaults when it is saved; the validation done during serialize is needed in some cases.
Crash repro instructions: create a new worldpartition level, add cube, create a level instance from that cube.
#rnx
#rb matt.peters
#rbself Fixing build break

[CL 30293351 by matt peters in ue5-main branch]
2023-12-13 10:30:16 -05:00
matt peters
944e81486e GeometryCollection Indeterminism: Prevent ValidateSizeSpecificDataDefaults from being called on the default GeometryCollection object when it is serialized. Validate only needs to be called when loading and calling it other times (e.g. ObjectCollector archives) can incorrectly trigger it on the default object. If the default object has ValidateSizeSpecificDataDefaults, then it will afterwards change the save serialization of instances that have SizeSpecificData equal to the default values constructed by ValidateSizeSpecificDataDefaults.
#jira UE-202374
#rnx
#rb cedric.caillaud

[CL 30274488 by matt peters in ue5-main branch]
2023-12-12 15:31:22 -05:00
jeremy moore
1850f5c0e5 [Backout] - CL28697429
[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL28695704
[FYI] Jeremy.Moore
Original CL Desc
-----------------------------------------------------------------
Store transform remap array for AutoInstanceMeshes in the geometry collection object.
This allows it to be calculated and stored once, for reference by multiple component instances.

[CL 28699292 by jeremy moore in ue5-main branch]
2023-10-11 23:17:16 -04:00
bob tellez
d776ae3ea2 [Backout] - CL28695704
[FYI] Jeremy.Moore
Original CL Desc
-----------------------------------------------------------------
Store transform remap array for AutoInstanceMeshes in the geometry collection object.
This allows it to be calculated and stored once, for reference by multiple component instances.

[CL 28697464 by bob tellez in ue5-main branch]
2023-10-11 21:57:26 -04:00
jeremy moore
5fc0e30c40 Store transform remap array for AutoInstanceMeshes in the geometry collection object.
This allows it to be calculated and stored once, for reference by multiple component instances.

[CL 28695736 by jeremy moore in ue5-main branch]
2023-10-11 20:57:17 -04:00
cedric caillaud
06fe2a2f03 fix comment as per review
#rb trivial

[CL 28686640 by cedric caillaud in ue5-main branch]
2023-10-11 18:11:54 -04:00
cedric caillaud
919458fb26 Make sure auto instance meshes array does not contain duplicates when generating geometry collection from Dataflow
- Add a SetAutoInstanceMeshes method to geometry collection asset that rem,ove duplicates and re-assign the auto instance indices as well as consolidating per instance primitive data
- call this method when setting the array when creating the asset in the geometry collection terminal node

#rb jeremy.moore

[CL 28686547 by cedric caillaud in ue5-main branch]
2023-10-11 18:10:36 -04:00
cedric caillaud
86dd65778d Compute component space transform optimization
Store breadth first order indices for transform on the rest collection

#rb benn.gallagher, vincent.robert, brice.criswell
[FYI] jeremy.moore

[CL 27652487 by cedric caillaud in ue5-main branch]
2023-09-06 17:00:17 -04:00
louisphilippe seguin
36c722f3c4 Fix wrong printf parameters in checkf & ensuremsgf found in engine code
#rb Fabian.Giesen, Kirill.Zorin
#rnx

[CL 27519547 by louisphilippe seguin in ue5-main branch]
2023-08-31 08:56:30 -04:00
cedric caillaud
61000b99b1 Add damage modifier to physics material and an option in Geometry Collection asset to opt for it
#rb steven.barnett

[CL 26918152 by cedric caillaud in ue5-main branch]
2023-08-08 11:31:47 -04:00
michael forot
6e4094da3e Chaos implicit object ref counted ptr + union simple shapes (WIP)
#rb chris.caulfield

[CL 26722951 by michael forot in ue5-main branch]
2023-07-31 17:46:47 -04:00
michael bao
5e026e9749 fix nullptr access on PhysicsMaterial instead of PhysicsMaterialForDensity in caching/computing mass/density in the geometry collection
[FYI] cedric.caillaud

[CL 26689621 by michael bao in ue5-main branch]
2023-07-28 17:50:05 -04:00
cedric caillaud
c7fa6954f0 Fix mass calculation for geometry collections when overriding materials on the component
#rb michael.bao, steven.barnett

[CL 26679228 by cedric caillaud in ue5-main branch]
2023-07-28 13:39:56 -04:00
robomerge
2e34b6a655 Make geometry collection convert vertex colors to sRGB when converting from FLinearColor to the render buffer FColor for new geometry collections.
For old geometry collections, keep the old behavior so that vertex colors are not changed unexpectedly on existing assets.  Add a bool on the UGeometryCollection asset object to let user control whether the conversion is performed.

#rb brice.criswell

[CL 25934820 by robomerge in ue5-main branch]
2023-06-12 15:24:20 -04:00