Commit Graph

359 Commits

Author SHA1 Message Date
Josh Adams
aa9705149b Copying Private-LoadTimes-4.24 stream to Main. Biggest changes are in Materials/Shader memory freezing.
#rb none

[CL 11282608 by Josh Adams in Main branch]
2020-02-06 13:13:41 -05:00
Stefan Boberg
55a8b15f1f Copying //UE4/Dev-Core to Main (//UE4/Main)
#rb none

[CL 11258477 by Stefan Boberg in Main branch]
2020-02-05 14:26:36 -05:00
Per Larsson
b4835a2192 IoDispatcher: Added validation errors when using I/O store container files w/o Pak files.
Currently this is needed because I/O store container uses the same manifest/response files as Pak files.

#jira UE-87370
#rb CarlMagnus.Nordin

[CL 11128119 by Per Larsson in Dev-Core branch]
2020-01-28 07:08:44 -05:00
Max Chen
b4881d8bf8 Copying //UE4/Dev-Editor to Dev-Tools-Staging (//UE4/Dev-Tools-Staging) @11123875
#rb none
#jira none

[CL 11123880 by Max Chen in Dev-Tools-Staging branch]
2020-01-27 20:11:15 -05:00
Per Larsson
5e6d91c5ad Enable the new optimized loader from edtor
#rb triival


#ushell-cherrypick of 10787117 by Per.Larsson

[CL 11042059 by Per Larsson in Dev-Core branch]
2020-01-17 08:08:48 -05:00
JeanMichel Dignard
7130d293f2 Merging main @ cl 11028482
#rb none
#rnx

[CL 11029060 by JeanMichel Dignard in Dev-Tools-Staging branch]
2020-01-16 10:24:38 -05:00
mike fricker
df265f4abc UE4: Expose support for overriding the application title (part 2)
Fixed non-unity compile error



#ROBOMERGE-SOURCE: CL 10996634 via CL 10996636 via CL 10996641
#ROBOMERGE-BOT: (v633-10983880)

[CL 10996643 by mike fricker in Main branch]
2020-01-15 15:36:01 -05:00
mike fricker
a3072a7a0f UE4: Expose support for overriding the application title
Added new IMainFrame module interface function to override the application title.

IMainFrameModule::SetOverrideApplicationTitle(FText)



#ROBOMERGE-SOURCE: CL 10996086 via CL 10996091 via CL 10996095
#ROBOMERGE-BOT: (v633-10983880)

[CL 10996097 by mike fricker in Main branch]
2020-01-15 14:44:42 -05:00
gines hidalgo
7c63f58332 #jira UE-86076
Bug fixed: Editor used to stall on Mac after key up, mouse up. Real issue: Every time a key is pressed on Mac, all menus are re-generated, making it very slow. Workaround: Disabled capability to know whether a UI layout was being currently selected to speed up the generation of the 3 layout menus.

#rb none
#lockdown cristina.riveron

#ROBOMERGE-SOURCE: CL 10983337 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v632-10940481)

[CL 10983339 by gines hidalgo in Main branch]
2020-01-14 12:32:07 -05:00
JeanMichel Dignard
70d074639f Merging //UE4/Dev-Main @ 10886849 to Dev-Tools-Staging (//UE4/Dev-Tools-Staging)
#rb none
#rnx

[CL 10906274 by JeanMichel Dignard in Dev-Tools-Staging branch]
2020-01-08 13:26:18 -05:00
ryan durand
627baf970a Updating copyright for Engine Editor.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869241 via CL 10869527 via CL 10869904
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870586 by ryan durand in Main branch]
2019-12-26 15:33:43 -05:00
Chris Gagnon
346a4b05ea Copy up from Dev-Editor @10681378
#rb none

[CL 10837446 by Chris Gagnon in Dev-Tools-Staging branch]
2019-12-19 18:07:47 -05:00
Jason Stasik
66231d1a8d Add tooltips to Save As error labels
#jira UE-84345
#rb none

[CL 10489924 by Jason Stasik in Dev-Editor branch]
2019-12-02 16:28:46 -05:00
Ryan Schmidt
d53c4df497 Merging //UE4/Dev-Tools-Staging down to //UE4/Dev-Editor at CL 10372033 (part 1 of 2)
#rb none
#rnx

[CL 10384788 by Ryan Schmidt in Dev-Editor branch]
2019-11-23 00:35:50 -05:00
gines hidalgo
b5e3ab6e96 Copied CL# 10289192
#jira UE-84627

Bug fixed: The "Save Layout As..." button (in "Window" --> "Save Layout" --> "Save Layout As...") was not localizing the text of the Layout Description field, only the one from the Layout Name field. It should localize both texts automatically. Fixed.

#rb jamie.dale
#lockdown cristina.riveron

#ROBOMERGE-SOURCE: CL 10291651 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v593-10286020)

[CL 10291653 by gines hidalgo in Main branch]
2019-11-18 17:09:51 -05:00
Gines Hidalgo
ebb6a4a6a5 #jira UE-84627
Bug fixed: The "Save Layout As..." button (in "Window" --> "Save Layout" --> "Save Layout As...") was not localizing the text of the Layout Description field, only the one from the Layout Name field. It should localize both texts automatically. Fixed.

#rb none

[CL 10289192 by Gines Hidalgo in Dev-Editor branch]
2019-11-18 14:44:38 -05:00
Gines Hidalgo
f1dcb5578a Added comments to help update the default values of the Editor layout (i.e., if changes are applied to "LevelEditor_Layout_v1.1" or "UnrealEd_Layout_v1.4").
#fyi matt.kuhlenschmidt
#rb none

[CL 10227617 by Gines Hidalgo in Dev-Editor branch]
2019-11-14 16:54:43 -05:00
Gines Hidalgo
13729602be #jira UE-84347
Bug fix: Close Asset Editors warning while loading layout had 2 identical options: No and Cancel. Removed the Cancel option to avoid the duplicated option.

#rb none

[CL 10125714 by Gines Hidalgo in Dev-Editor branch]
2019-11-13 10:55:29 -05:00
gines hidalgo
357d9d7b53 Copied CL# 10119067
#jira UE-80569

Solved mini-bug when saving a layout with path too long: It was wrongly checking the relative path length rather than the fulll one.

#rb none
[FYI] laura.klinefelter

#ROBOMERGE-SOURCE: CL 10119125 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v587-10111126)

[CL 10119134 by gines hidalgo in Main branch]
2019-11-12 18:10:20 -05:00
Gines Hidalgo
24fdce4e1a #jira UE-80569
Solved mini-bug when saving a layout with path too long: It was wrongly checking the relative path length rather than the fulll one.

#rb none
#fyi laura.klinefelter

[CL 10119067 by Gines Hidalgo in Dev-Editor branch]
2019-11-12 18:03:31 -05:00
Gines Hidalgo
d59e73c8f3 Copied CL# 10114589
#JIRA UE-84269

Fixing regression warning created by CL # 10110416

#rb none

[CL 10114671 by Gines Hidalgo in Dev-Editor branch]
2019-11-12 14:11:56 -05:00
gines hidalgo
a2380620e5 #JIRA UE-84269
Fixing regression warning created by CL # 10110416

#rb none

#ROBOMERGE-SOURCE: CL 10114589 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v587-10111126)

[CL 10114597 by gines hidalgo in Main branch]
2019-11-12 14:10:37 -05:00
gines hidalgo
5f1d06306a Copied CL# 10108258
#jira UE-80859

Bug fixed: Loading an Editor Layout used to close all open sub-editors.  Now, a new Dialog warning window is displayed if any sub-editor instance or PIE/SIE are opened when the user tries to load a new layout, asking whether he want to continue loading the layout (that would lead to automatically close+- those without saving them).

Note: Previously, all the load options were disabled while PIE was running. However, this could be confusing for the user, who might not know why they are disabled and not associate it with PIE being running (Although it was shown in the Load Layout tooltip, but people is not likely to read those...). Instead, this warning is merged with the one for the opened asset editors.

This is a quick fix is for 4.24, to avoid deep code changes. However, for later versions, the following tasks should be done as well:
- Investigate whether PIE or the sub-editor can be maintained opened, rather than closing them when a new layout is loaded.

#rb chris.gagnon

#ROBOMERGE-SOURCE: CL 10108290 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v586-10095595)

[CL 10108291 by gines hidalgo in Main branch]
2019-11-11 18:53:05 -05:00
Gines Hidalgo
a288fe1c73 #jira UE-80859
Bug fixed: Loading an Editor Layout used to close all open sub-editors.  Now, a new Dialog warning window is displayed if any sub-editor instance or PIE/SIE are opened when the user tries to load a new layout, asking whether he want to continue loading the layout (that would lead to automatically close+- those without saving them).

Note: Previously, all the load options were disabled while PIE was running. However, this could be confusing for the user, who might not know why they are disabled and not associate it with PIE being running (Although it was shown in the Load Layout tooltip, but people is not likely to read those...). Instead, this warning is merged with the one for the opened asset editors.

This is a quick fix is for 4.24, to avoid deep code changes. However, for later versions, the following tasks should be done as well:
- Investigate whether PIE or the sub-editor can be maintained opened, rather than closing them when a new layout is loaded.

#rb chris.gagnon

[CL 10108258 by Gines Hidalgo in Dev-Editor branch]
2019-11-11 18:50:32 -05:00
gines hidalgo
9a07b5351c Copied CL# 10088684
#jira UE-80569
#jira UE-80575
#jira UE-80577

New features (they are very related to each other, so they have been integrated together):
1) UE-80569: When the user attempts to save a custom layout, we open a Slate SWidget save dialog that no longer allows them to enter the file path where the layout will be saved, but instead the Layout Name and (optionally) Description. The file name will automatically be generated from the displayed layout name.
2) UE-80575: When attempting to save a custom layout, we prevent the OS save dialog. Since the user cannot actually save a layout anywhere other than the default save location, this streamlines the workflow and minimize confusion. Instead, the Slate SWidget detailed in point 1 is used, where the user can introduce only the displayed layout name, and the file name and its directory are automatically generated (fixed directory).
3) UE-80577: After 1 and 2, it is unclear where the layout is saved. Thus, when saving a custom layout, we provide an Editor toast notifying the user of their custom layout's save location. It is analog to the one provided when a user takes a screenshot within the Editor.
In addition, the possible messages displayed to the user when the layout file was not successfully copied have also been improved (higher details and fixed some grammar typos).

Some general and additional considerations about the new Slate layout save dialog:
1) The "Save" button will be disabled when the introduced file name is empty or an error occurs (e.g., name is too long).  If any error occurs, the dialog will display the error message as well, analog to "File" --> "Save current as...".
2) An Override/Cancel dialog will be displayed if the user selects a file name that matches another existing one.
3) An automatic NSLOCTEXT key and namespace fields are generated for each profile created. This is abstracted from the user, who does not need to know about this. Translations come later from a LocRes file that we generate for the engine. Thus, only the profile files that we have included in P4 might be translated.

Some potential issues / observations:
1) The export layout remains with the old OS save dialog (as it can be saved in different directories). This makes the appearance of both of them very different, but it also makes export similar to import.

#rb rex.hill

#ROBOMERGE-SOURCE: CL 10089258 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v574-10069753)

[CL 10089279 by gines hidalgo in Main branch]
2019-11-08 17:44:25 -05:00