Commit Graph

7025 Commits

Author SHA1 Message Date
Zabir Hoque
9e69df719e Add missing flattened material property enum that was missed when anisotropy was added.
#rb: none
#jira: UE-88708

[CL 11534852 by Zabir Hoque in 4.25 branch]
2020-02-18 21:14:47 -05:00
Patrick Laflamme
c05f507c5e #jira UE-88250 - Crash Report Client doesn't emits EditorSummaryEvent with proper AppId/AppVersion/SessionId/UserId
- Added AppId, AppVersion and UserId as FEditorAnalyticSession members and updated FEditorSessionSummaryWriter to write them.
  - Changed FEngineAnalytics::GetProvider() to return IAnalyticsProviderET rather than IAnalyticsProvider.
  - Updated FEditorSessionSummarySender to embed the AppId/AppVersion/UserId as attribute when sending the summary event and also configured the AnalyticsProvider to use the SessionID/AppID/AppVersion/UserID of the event rather than the current one.
  - Added a function to return the current IAnalyticProviderET configuration.

#rb Wes.Hunt

Edigrated 11445334 and 11459406.

[CL 11512055 by Patrick Laflamme in 4.25 branch]
2020-02-18 15:12:36 -05:00
Thomas Sarkanen
f041494714 Fixed previous frame button on Gameplay insights transport controls
Fixes off-by-one error in frames provider
This caused frames to be mis-reported when using FFrameProvider::GetFrameFromTime.

#jira UE-88149 - Previous frame button on Gameplay insights transport control has no impact
#rb Jurre.deBaare

[CL 11498367 by Thomas Sarkanen in 4.25 branch]
2020-02-18 09:33:24 -05:00
Helge Mathee
5feac49bfc RigVM AST: Moved the lookup from AST Node to Expression Index to a map, since now with nested nodes the Node index itself cannot be relied on.
#rb lina.halper
#jira UE-88252

Merging

//UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/...

to //UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/...

[CL 11498311 by Helge Mathee in 4.25 branch]
2020-02-18 09:31:54 -05:00
Helge Mathee
2bd8c7ba58 Instead of accessing sub array elements on a default struct we create a new structonscope for the inner property and use that instead. The array property might be empty - so relying on that isn't stable and can cause crashes as hit in UE-88394
#rb lina.halper
#jira UE-88394

Merging

//UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/Private/RigVMModel/RigVMController.cpp

to //UE4/Release-4.25/Engine/Source/Developer/RigVMDeveloper/Private/RigVMModel/RigVMController.cpp

[CL 11498307 by Helge Mathee in 4.25 branch]
2020-02-18 09:31:44 -05:00
Helge Mathee
14d280ca41 Control Rig: Fix error log for UE-88390
#jira UE-88390
#rb na

Merging

//UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/Private/RigVMModel/RigVMController.cpp

to //UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/Private/RigVMModel/RigVMController.cpp

[CL 11498280 by Helge Mathee in 4.25 branch]
2020-02-18 09:30:28 -05:00
benoit deschenes
2c1af0ecab Integrating CL#11136074 from Dev-Enterprise
Fixing Python asset import task returning wrong path when not combining mesh.

#jira UE-72503
#rb none

[CL 11461632 by benoit deschenes in 4.25 branch]
2020-02-17 13:39:37 -05:00
benoit deschenes
452fc8eba6 Integrating CL#11259478 from Dev-Enterprise
Fixing memory leak when GC is not called in datasmith mesh exporter

#jira UE-87989
#review-11255122 JeanMichel.Dignard
#rb JeanMichel.Dignard

[CL 11461470 by benoit deschenes in 4.25 branch]
2020-02-17 13:28:11 -05:00
emil kirichev
c82ca910c3 Illegal characters in texture name don't survive datasmith export
Integrated from Dev-Enterprise (CL 11279033)

#jira UE-87907
#rb JeanLuc.Corenthin

[CL 11459086 by emil kirichev in 4.25 branch]
2020-02-17 08:01:52 -05:00
Jamie Dale
be36eaf6c2 Fixed localization conflicts
#jira
#rb none
#rnx

[CL 11448060 by Jamie Dale in 4.25 branch]
2020-02-14 15:48:09 -05:00
Rolando Caloca
5b82f15def Copying //UE4/Dev-RenderPlat-Staging@11388153 to //UE4/Main
#rb none
#rnx

[CL 11388545 by Rolando Caloca in Main branch]
2020-02-12 13:27:19 -05:00
bob tellez
c7a60a8d7f #UE4 Fix thread safety issue when generating lods
#rb Alexis.Matte


#ROBOMERGE-SOURCE: CL 11386825 via CL 11386830 via CL 11386831
#ROBOMERGE-BOT: (v654-11333218)

[CL 11386832 by bob tellez in Main branch]
2020-02-12 12:41:49 -05:00
juan canada
090d1f15b8 Fixed more static analysis warnings
#rb none
#jira UE-88610


#ROBOMERGE-SOURCE: CL 11383939 via CL 11383979
#ROBOMERGE-BOT: (v654-11333218)

[CL 11383999 by juan canada in Main branch]
2020-02-12 09:53:28 -05:00
matt kuhlenschmidt
3fa44160fd Improved the details panel root object customization API to support multiple objects in the "root object set". Deprecated old functionality and removed pass through customizations that are no longer needed
#rb none

#ROBOMERGE-OWNER: matt.kuhlenschmidt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
#ROBOMERGE-SOURCE: CL 11382968 via CL 11382988 via CL 11382990
#ROBOMERGE-BOT: (v654-11333218)

[CL 11383722 by matt kuhlenschmidt in Main branch]
2020-02-12 09:41:11 -05:00
rex hill
0987dfb11e Project Launcher now has 'Show Missing' option in the cooked maps section.
#rb none
#jira UE-88438


#ROBOMERGE-SOURCE: CL 11341704 via CL 11350709 via CL 11350959
#ROBOMERGE-BOT: (v654-11333218)

[CL 11351178 by rex hill in Main branch]
2020-02-11 14:40:18 -05:00
juan canada
02c1c2fac8 Fixed static analysis warnings due false positive warnings
#rb none


#ROBOMERGE-SOURCE: CL 11348471 via CL 11348500
#ROBOMERGE-BOT: (v654-11333218)

[CL 11348519 by juan canada in Main branch]
2020-02-11 14:09:37 -05:00
geordiemhall
a2912779ca PR #6671: Enable right-click drag scrolling in Project/Editor Settings sidebar (Contributed by geordiemhall)
#jira UE-88368
#rb chris.gagnon, rex.hill


#ROBOMERGE-SOURCE: CL 11339223 via CL 11345303 via CL 11345519
#ROBOMERGE-BOT: (v654-11333218)

[CL 11345711 by rex hill in Main branch]
2020-02-11 13:41:03 -05:00
mihnea balta
9c7996448f Fixed incorrect dissassembly when WITH_EDITOR is not defined.
The opcode was only added to the argument list when WITH_EDITOR was defined, so all the positional arguments used by the string formatter were offset by -1.

#rb none


#ROBOMERGE-SOURCE: CL 11335700 via CL 11335730
#ROBOMERGE-BOT: (v653-11302973)

[CL 11335734 by mihnea balta in Main branch]
2020-02-11 08:57:26 -05:00
Ben Marsh
62db13b006 Fix for warning after upgrading to PVS-Studio 7.0.4:
V1028: Possible overflow. Consider casting operands of the 'j + IABOffsetIndex' operator to the 'uint64' type, not the result.

#codereview Rolando.Caloca
#rb none
#rnx

[CL 11311722 by Ben Marsh in Main branch]
2020-02-10 16:28:24 -05:00
arciel rekman
e1db3cb334 Don't include commented out defines in the preprocessed code by default.
- Defines will still be there if we're dumping the shader code for debug.
- This makes the code less unique in general case and also avoids unnecessary works that no one sees.

#rb Lukas.Hermanns
[FYI] Lukas.Hermanns, Rolando.Caloca


#ROBOMERGE-SOURCE: CL 11311362 via CL 11311438
#ROBOMERGE-BOT: (v653-11302973)

[CL 11311455 by arciel rekman in Main branch]
2020-02-10 16:07:53 -05:00
matt kuhlenschmidt
54ad259b8b Non-unity fixes
#ROBOMERGE-SOURCE: CL 11311048 via CL 11311051 via CL 11311053
#ROBOMERGE-BOT: (v653-11302973)

[CL 11311421 by matt kuhlenschmidt in Main branch]
2020-02-10 16:06:34 -05:00
matt kuhlenschmidt
2466840461 Added filtering to details panels to filter the set of incoming objects passed to a details panel
Changed the way details panels handle multiple root objects.  The filter can now specify this without setting a specific flag on a details panel at creation time.

[CODEREVIEW] chris.gagnon


#ROBOMERGE-OWNER: matt.kuhlenschmidt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
#ROBOMERGE-SOURCE: CL 11308033 via CL 11308037 via CL 11308040
#ROBOMERGE-BOT: (v653-11302973)
#rb none

[CL 11310703 by matt kuhlenschmidt in Main branch]
2020-02-10 15:43:53 -05:00
Martin Ridgers
bcda0febbe Cancel the timeout tick when accepting a connection to read trace data from a relay. Otherwise the timeout fires causing an extra read, the loss of a page of trace data, and eventually a segfault or assert.
#rb jb
#rnx
#jira ue-88376
#ushell-cherrypick of 11302806 by Martin.Ridgers

[CL 11303311 by Martin Ridgers in Main branch]
2020-02-10 08:55:35 -05:00
Martin Ridgers
cfd65a404f Always attempt to cancel a timer regardless of the owning FAsioTickable's state. Without this it isn't possible to cancel one-shot ticks.
#rb jb
#rnx
#jira ue-88376

#ushell-cherrypick of 11302796 by Martin.Ridgers

[CL 11303303 by Martin Ridgers in Main branch]
2020-02-10 08:53:23 -05:00
robert manuszewski
b938e59c9b Reimplementing FProperty changes from //UE4/Main
+ Reimplemented FProperty related fixed from //UE4/Main:
CL#10791312, 10804850, 10851666, 10855122, 10855198, 10942138, 11030611, 11030639, 11032261, 11061515, 11136964,11138881, 11214238, 11214865

#rb none (previously reviewed in Dev-Core)
[FYI] Chris.Bunnner, Daniel.Lamb


#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 11302985 via CL 11303011 via CL 11303019
#ROBOMERGE-BOT: (v0-11244347)

[CL 11303183 by robert manuszewski in Main branch]
2020-02-10 08:06:56 -05:00