Commit Graph

182 Commits

Author SHA1 Message Date
rob gay
94e46a67f9 Initial MetaSound Editor Page Support (cvar disabled until all transactions are supported and tested)
#jira UE-194160
#rb phil.popp
#rnx
#tests PIE, MetaSound Asset Editor, Engine Automation tests

[CL 34535569 by rob gay in ue5-main branch]
2024-06-20 13:33:47 -04:00
phil popp
8846679f41 Recurse MetaSound Preset Graph Inflation as much as possible.
#rnx
#rb Rob.Gay

[CL 34465653 by phil popp in ue5-main branch]
2024-06-18 12:26:46 -04:00
rob gay
1b3382acee Guid collision fix-up follow-up renaming
#rb helen.yang, phil.popp
#rnx

[CL 34426347 by rob gay in ue5-main branch]
2024-06-17 12:51:18 -04:00
rob gay
114a801414 Pesky, sneaky, snacky exclamat!on
#rb rob.gay
#rnx

[CL 34389549 by rob gay in ue5-main branch]
2024-06-14 19:43:40 -04:00
rob gay
81433d4d49 Versioning guid collision fixes
#jira UE-217835
#rb phil.popp
#rnx
[FYI] sondra.moyls
#tests local edits, audioQA automated tests, project fast cook

[CL 34376054 by rob gay in ue5-main branch]
2024-06-14 13:05:35 -04:00
rob gay
be35f85305 - Move duplication to re-use registered builder at different points of duplication process as multiple builders per class name in the builder registry its now supported
- Give asset builders proper names based off the MetaSound asset being built for easier debugging
- Add log supression during duplication from spamming user as brief existence of multiple builders with shared class name is expected behavior (Leaving disabled until cook can be verified log is not being hit)
#rb helen.yang
#jira UE-216532
[FYI] sondra.moyls
#rnx

[CL 34245724 by rob gay in ue5-main branch]
2024-06-10 13:52:48 -04:00
rob gay
d2f0f9fed1 Fix for registration not being called after conforming an object to document
#rb trivial
#jira UE-216541
[FYI] sondra.moyls
#rnx

[CL 34180691 by rob gay in ue5-main branch]
2024-06-06 19:07:15 -04:00
nicholas howe
9e4adb4d75 Audio Bus Reader-Writer Nodes Don't CreatePatch in Reset
#tests all audio bus engine tests pass
#rb Rob.Gay

[CL 34154610 by nicholas howe in ue5-main branch]
2024-06-06 09:01:57 -04:00
phil popp
56737d13eb MetaSound Graph Render Cost
The main elements of this change are:
- Incorporation of "Relative Render Cost" to the AudioDevice in order to do more nuanced voice limiting
- Added a method for tracking a RenderCost in MetaSounds
- Live information on RenderCost is displayed in the MetaSound editor when a sound is previewed

There was some small cleanup as well
- Moved the GraphHierarhcy MetaSound environment variable
- Renamed the MetaSound Environment Variable  TransmissionID to InstanceID
- Put CPU cost and Render Cost into their own widget in the MS editor.

#jira UE-215467
#rb Rob.Gay, Jimmy.Smith

[CL 34020333 by phil popp in ue5-main branch]
2024-05-30 19:36:18 -04:00
rob gay
064e244218 - Make Version call to generate MetaSound Builder async GC-safe
- Misc clean-up
#rb phil.popp
#rnx
[FYI] helen.yang
#jira UE-216029

[CL 34017798 by rob gay in ue5-main branch]
2024-05-30 18:56:24 -04:00
nicholas howe
5921988c1f Bus Reader-Writer Node Consistent Latency Fix
#tests EngineTest Audio Bus functional tests all pass
#rb Aaron.McLeran, Rob.Gay, phil.popp

[CL 34003097 by nicholas howe in ue5-main branch]
2024-05-30 10:27:00 -04:00
maxwell hayes
1c89213cf7 [Metasounds] setting object arrays from bp not working (Fix fallout from UE-213913)
#jira UE-215523
#rb phil.popp
#rnx
#tests Metasound Blueprint Engine tests, AQ_Metasounds test map

[CL 33874514 by maxwell hayes in ue5-main branch]
2024-05-23 16:53:33 -04:00
maxwell hayes
2a6834cc22 [MetaSounds] Maintain object parameters set in blueprint after un-virtualization.
#jira UE-213913
#rb Rob.Gay
[FYI] Seth.Weedin, Helen.Yang

[CL 33781662 by maxwell hayes in ue5-main branch]
2024-05-20 18:08:51 -04:00
rob gay
711a973c73 - Move MetaSoundAssetSubsystem& BuilderSubsystem implementations to monolithics that are initialized at MetaSoundEngine module load for safety
- Avoids PreDefault vs Default module Init which can interact negatively and obscurely with EngineSubsystems not being loaded prior to certain builds/scenarios where serialized assets are loaded earlier
- Sunset existing Subsystem non-UFUNCTION calls not pertaining to direct Blueprint exposition
- Optimize AssetManager to use own key vs NodeRegistryKey and TopLevelPaths vs SoftObjectPaths
- Misc module clean-up
- Misc callsite refactors to use new monolithics
#rb phil.popp
[FYI] sondra.moyls, helen.yang

#tests EngineTest & AudioQA Automation PIE Packaged Build -game

[CL 33522338 by rob gay in ue5-main branch]
2024-05-08 14:53:53 -04:00
helen yang
e88cefd8c5 Refactor MetaSound Array Random Get Node shared state
- Add input for Shared State Behavior to share state between other array random nodes that are the same node, same node in composition, or same data
- Simplify behavior for reinitializing and updating state
- Add hidden friend GetHashType hash functions to MetaSound types
- Add output for chosen index
- Tooltip updates and debug logging

#jira UE-211778
#jira UE-172282
#rb phil.popp, aaron.mcleran

[CL 33495083 by helen yang in ue5-main branch]
2024-05-07 16:54:01 -04:00
aaron mcleran
25e7e03cdf Adding StartTime interface as an optional MetaSound Source interface.
StartTime used in BP API and Sequencer will now be forwarded to the MetaSound through this interface. The MetaSound can decide what to do with that information -- i.e. sound design what 'Start Time' means.

#rb Phil.Popp, Rob.Gay, Brian.Chrisman
#jira UE-211683

[CL 33272664 by aaron mcleran in ue5-main branch]
2024-04-26 14:51:16 -04:00
rob gay
e8e0c199a2 Remove dependency on MetaSound engine subsystems of any kind being required to register MetaSounds with frontend
#rb rob.gay
#rnx
[FYI] sondra.moyls, phil.popp, helen.yang

[CL 33199328 by rob gay in ue5-main branch]
2024-04-24 10:36:28 -04:00
rob gay
b3ab5744bf - Fix for attempting to access EngineSubsystem during MetaSound versioning (serialization), which can assert when apparently certain commands in certain contexts can attempt to preload assets prior to the init phase.
- Minor Fix for LocText duplication
#tests BuildCookRun, -game, version MetaSounds assets in editor, PIE

[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33102023 by rob gay in ue5-main branch]
2024-04-19 10:09:04 -04:00
bob tellez
416e6c17d8 [Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33096249 by bob tellez in ue5-main branch]
2024-04-18 23:43:05 -04:00
rob gay
50a661b140 Reverting early return speculative fix for warnings and removing warning for now when attempting to cache MetaSound runtime data to fix sequencer warnings.
#rb rob.gay
[FYI] phil.popp, helen.yang
#jira UE-194159
#rnx

[CL 33089038 by rob gay in ue5-main branch]
2024-04-18 18:24:11 -04:00
rob gay
184db3803e Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33085078 by rob gay in ue5-main branch]
2024-04-18 16:50:48 -04:00
phil popp
f0941560d0 Fix ensure on retrieving quality settings from none-asset metasound.
#jira UE-210369, FORT-724365
#rb rob.gay

[CL 32448309 by phil popp in ue5-main branch]
2024-03-22 16:20:00 -04:00
jimmy smith
048f5a5a11 Fix for perf regression in Metasounds
#rb Maxwell.Hayes, phil.popp
#tests Local verification

[CL 32409889 by jimmy smith in ue5-main branch]
2024-03-21 15:21:31 -04:00
jimmy smith
0637da8f9e Fix non-cooked quality settings by adding a cook stage the MetasoundSource to correctly save them out per platform.
Previously the PerPlatformSettings was added to the MetasoundSettings, however as this is not a true asset they weren't being correctly cooked.
The code previously pulled the global settings, then allowed overrides upon this. This decision is now made during cook.
#rb jake.burga, Josh.Adams
#tests Shelve tested back and forth with Sondra Moyles
#jira UE-204075

[CL 32370815 by jimmy smith in ue5-main branch]
2024-03-20 12:42:32 -04:00
jimmy andrews
5e5d976da3 fix unreachable implicit "++iterator" in cases where a for-loop was used to just grab the first element of a set or map
#rb lonnie.li
#lockdown michael.balzer

[CL 31880424 by jimmy andrews in ue5-main branch]
2024-02-28 14:51:06 -05:00