FOutputLogTextLayoutMarshaller::GetText wasn't implemented, so it was always returning an empty string. I've implemented this and verified that it doesn't cause any performance issues for the output log.
I had to change SMultiLineEditableText::LoadText to only do that when it was bound to a delegate, as that was causing a hitch while the output log was updated when you gave it focus.
I also fixed giving the output log focus sometimes jumping to the top of the log (SMultiLineEditableText::OnKeyboardFocusReceived needed the same fix as SMultiLineEditableText::OnKeyboardFocusLost to prevent the cursor jumping into focus).
ReviewedBy Justin.Sargent
[CL 2308259 by Jamie Dale in Main branch]
It wasn't actually needed as we're able to perform the scroll immediately in all cases we need to, rather than wait until the next Tick().
#codereview Max.Preussner
[CL 2306688 by Jamie Dale in Main branch]
1) The selected text colour is now easier on the eyes
2) The output log will always scroll to the end when you enter a command
3) The output log will now correctly scroll to the bottom when it is first opened (it forces the scrollbars to always visible to avoid the horizontal scrollbar being able to move the vertical scrollbar up slightly from the bottom of the log)
ReviewedBy Andrew.Rodham
[CL 2305438 by Jamie Dale in Main branch]
This is using a custom text marshaller to efficiently convert an FLogMessage into something understood by the FTextLayout.
ReviewedBy Justin.Sargent
[CL 2297960 by Jamie Dale in Main branch]
TTP# 345402 - CRITICAL: Regression: EDITOR: CRASH: Closing the editor
There was a static instance of SOutputLog being created, which was persisting beyond the lifespan of both Slate and ICU.
#codereview Justin.Sargent
[CL 2282175 by Jamie Dale in Main branch]
Slate TPanelChildren, TSlotlessChildren are no longer full-fledged arrays; removed any unused Array API.
Fixed up a lot of improper use cases.
This better encapsulates the action of adding/removing Slate Widgets from the runtime tree as a Slate Core concern.
Alows us to add parent pointers in the future with significantly less effort.
#codereview Wes.Hunt
#codereview Nick.Darnell
#codereview Matt.Kuhlendschmidt
#codereview Justin.Sargent
[CL 2234301 by Nick Atamas in Main branch]
