- to try to fix large crack, a second step could be perform with a larger tolerance
- to prevent the meshing failure of thin surface, and consequently the presence of a crack in the mesh, thin surface can be removed and replaced by a topological weld.
3 new CVar are added to drive this new process:
- ds.CADTranslator.Stitching.ForceSew
- ds.CADTranslator.Stitching.ForceFactor
- ds.CADTranslator.Stitching.RemoveThinFaces
Fix crashes, fix HD leak, fix RAM usage
#jira UE-154019, UE-157085
#rb jeanluc.corenthin
#preflight 6356cd17f92c325024f48f6e
#lockdown jeanmichel.dignard
#preflight 635a9bb00b08a07d8a4310d7
[CL 22810471 by david lesage in ue5-main branch]
[FYI] David.Lesage
Original CL Desc
-----------------------------------------------------------------
[CADKernel] Improve topological welding:
- to try to fix large crack, a second step could be perform with a larger tolerance
- to prevent the meshing failure of thin surface, and consequently the presence of a crack in the mesh, thin surface can be removed and replaced by a topological weld.
3 new CVar are added to drive this new process:
- ds.CADTranslator.Stitching.ForceSew
- ds.CADTranslator.Stitching.ForceFactor
- ds.CADTranslator.Stitching.RemoveThinFaces
Fix crashes, fix HD leak, fix RAM usage
#jira UE-154019, UE-157085
#rb jeanluc.corenthin
#preflight 6352c5ef7261e565c47ca046
#lockdown jeanmichel.dignard
[CL 22713056 by aurel cordonnier in ue5-main branch]
- to try to fix large crack, a second step could be perform with a larger tolerance
- to prevent the meshing failure of thin surface, and consequently the presence of a crack in the mesh, thin surface can be removed and replaced by a topological weld.
3 new CVar are added to drive this new process:
- ds.CADTranslator.Stitching.ForceSew
- ds.CADTranslator.Stitching.ForceFactor
- ds.CADTranslator.Stitching.RemoveThinFaces
Fix crashes, fix HD leak, fix RAM usage
#jira UE-154019, UE-157085
#rb jeanluc.corenthin
#preflight 6352c5ef7261e565c47ca046
#lockdown jeanmichel.dignard
[CL 22711547 by marc audy in ue5-main branch]
TS give unclosed external loop for sperical surface in specific case. A process is added to find this case and close the loop.
TS return wrong loop as the external loop. A process is added to find the external loop.
#preflight 633a980f7c11614c2174a446
[CL 22295994 by david lesage in ue5-main branch]
Headers are updated to contain any missing #includes needed to compile and #includes are sorted. Nothing is removed.
#ushell-cherrypick of 21065896 by bryan.sefcik
#preflight 62d4b1a5a6141b6adfb0c892
#jira
#ROBOMERGE-OWNER: Bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21150156 via CL 21151754 via CL 21154719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
#ROBOMERGE-CONFLICT from-shelf
[CL 21181076 by Bryan sefcik in ue5-main branch]
Move Headers from public to private
Use DOUBLE constants
Remove unused files
#fyi jeanluc.corenthin
#preflight 62b4dbd734570ba99470ba0d
[CL 20803237 by David Lesage in ue5-main branch]
#jira UETOOL-5056: Crash with sew option
#jira UE-135895: Editor crash on JT import with stitching Sew
#jira UE-144389: Worker lost when Importing STP file with TechSoft + CADKernel Tessellator
fix crash in TPolylineApproximator::UpdateSubPolylineBBox (PolylineTools.h)
fix nullptr in FCoreTechBridge::AddLoop
improve void FTopologicalFace::UpdateBBox
improve FTopologicalLoop::RemoveDegeneratedEdges() by reducing the joining angle of an degenerated edge and its neighbour to allow the merge of the degenerated edge
improve FTopologicalLoop::EnsureLogicalClosing
- reducing the joining angle of a loop's gap and its neighbouring to allow to extend the neighbour to fill the gap
- make a degenerated edge to fill lage Gap in 2D (in degenerated area)
fix FParametricMesher::Mesh(FTopologicalEdge& InEdge, const FTopologicalFace& Face): Set meshed degenerated edge as meshed
fix FGrid::GetMeshOfLoop when a degenerated loop is deleted
improve FTechSoftBridge::TraverseShell => Avoid edge link between different shells
fix crash in FTechSoftFileParserCADKernelTessellator::AdaptBRepModel()
fix nullptr in FTechSoftFileParserCADKernelTessellator::GenerateBodyMesh
fix crash in BowyerWatsonTriangulation.h
remove "ensure" in:
- FTopologicalLoop::Orient()
- FTopologicalVertex::RemoveConnectedEdge
#fyi jeanluc.corenthin, flavien.picon, andreas.brock, andre.stdenis
#preflight 62976046545b9a93abf320a1
[CL 20451488 by David Lesage in ue5-main branch]
#jira UE-144198
- A scale is apply at the mesh during the transfer to UE
- Alias/CADKernel: BRep body is transferred to CADKernel in cm instead of mm
- Rhino/CADKernel: fix nullptr
#rb jeanluc.corenthin
#swarm https://p4-swarm.epicgames.net/reviews/19409797
#preflight 623379ee84667926da28f3b8
#preflight 62337bdde14776a6ebbf4f36
[CL 19424322 by David Lesage in ue5-main branch]
Fix CADKernel used with TechSoft, 3 mains problems:
- by default, from TechSoft, faces with a periodic basis surface are not always split on parametric seams
- CADKernel expects to have the external loop in first, that is not always the case with TechSoft
- The function to test the relative orienation of two coincident closed edges (StartVertex = EndVertex) has not been yet implemented
#swarm https://p4-swarm.epicgames.net/reviews/19379931
#rb jeanluc.corenthin
#preflight 6230eb079406c2cfd6a9bd63
[CL 19392487 by David Lesage in ue5-main branch]
Step 2: Preparing to plug of CADKernel into TechSoft: Add missing methodes in TechSoftInterface, TechSoftUtils and CADKernel::FSession
#rb jeanluc.corenthin
#preflight 621029245219b1d13ceedd90
#ROBOMERGE-AUTHOR: david.lesage
#ROBOMERGE-SOURCE: CL 19082460 in //UE5/Release-5.0/... via CL 19097105
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)
[CL 19140833 by david lesage in ue5-main branch]
#preflight 61f5e0a3cb5b9daed89646ac
#ROBOMERGE-AUTHOR: david.lesage
#ROBOMERGE-SOURCE: CL 18784834 in //UE5/Release-5.0/... via CL 18784835 via CL 18784855
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)
[CL 18784856 by david lesage in ue5-main branch]
#preflight 61eae081c557ec200181a61a
#ROBOMERGE-AUTHOR: david.lesage
#ROBOMERGE-SOURCE: CL 18690771 in //UE5/Release-5.0/... via CL 18690789 via CL 18690825
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)
[CL 18690865 by david lesage in ue5-main branch]
#preflight 61eaceb1f1438e8a4b30dae0
#ROBOMERGE-AUTHOR: david.lesage
#ROBOMERGE-SOURCE: CL 18689718 in //UE5/Release-5.0/... via CL 18689733 via CL 18689751
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)
[CL 18689869 by david lesage in ue5-main branch]