Commit Graph

4553 Commits

Author SHA1 Message Date
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
Zousar Shaker
9ebb9da0b5 [Backout] - CL22952808
#fyi Zousar.Shaker
Original CL Desc
-----------------------------------------------------------------
Disallow TObjectPtr use on complete non-UObject derived types.

#rb devin.doucette
#preflight 63633a910c2e7c8f91d2e4e9

[CL 22953432 by Zousar Shaker in ue5-main branch]
2022-11-03 10:59:07 -04:00
Zousar Shaker
828ced0b2a Disallow TObjectPtr use on complete non-UObject derived types.
#rb devin.doucette
#preflight 63633a910c2e7c8f91d2e4e9

[CL 22952808 by Zousar Shaker in ue5-main branch]
2022-11-03 10:28:34 -04:00
NEdwards-Sharkmob
f2b8376be6 PR #9698: Adding missing script macros for weak object properties.
#rnx
#rb Robert.Manuszewski
#preflight 6363cbb71052c15f13845c6a

[CL 22952772 by NEdwards-Sharkmob in ue5-main branch]
2022-11-03 10:26:35 -04:00
scott nelson
8a674181f8 Add Ability to provide Default PackageFlags to each mount point during CreatePackage
#rb Francis.Hurteau
#preflight 6361809f1a32af63a89cb229

[CL 22918043 by scott nelson in ue5-main branch]
2022-11-02 11:48:28 -04:00
Helge Mathee
747879c204 Core: Array Text import not working for ()
#rb Steve.Robb
#jira UE-134101
#preflight https://horde.devtools.epicgames.com/job/63613e16ef6d25c674605ec6

[CL 22908318 by Helge Mathee in ue5-main branch]
2022-11-02 06:16:07 -04:00
henrik karlsson
4a36cfe8ff Moved operator== to be hidden friend instead of put directly in global namespace
Moved GetTypeHash function to be hidden friend instead of put directly in global namespace.

Note that the function/operator needs to be fully inlined in the type or placed in the cpp. If the function is added as friend but then implemented outside the type then hidden friend optimization won't work.

This should improve compile time somewhat according to msvc devs.

#rb Steve.Robb
#preflight 6360b7052b5338aceb26471b

[CL 22889837 by henrik karlsson in ue5-main branch]
2022-11-01 15:50:27 -04:00
jamie dale
b7c361c823 Fixed FPropertyLocalizationDataGatherer failing to gather text from external actor packages
It wasn't finding any root objects in the actor package due to the "Object->GetOuter() == Package" test failing for external actors.

#jira
#preflight 63612013e271e75dea8c13e2
[FYI] Daniel.Lamb
#rb Rex.Hill
#rnx

[CL 22888819 by jamie dale in ue5-main branch]
2022-11-01 15:15:27 -04:00
henrik karlsson
8f895fef35 Added includes needed after removing includes in headers
#preflight 6360b63e41625be270a6e464
#rb none

[CL 22888775 by henrik karlsson in ue5-main branch]
2022-11-01 15:14:15 -04:00
robert manuszewski
6dc32674ac Adding FPackageName::GetContentPathForPackageRoot to be able to get the filesystem path (e.g. D:/Project/Engine/Content) of a given package root (e.g. /Engine/)
#rb Steve.Robb
#preflight 6360c64663608aee36d1a954

[CL 22888595 by robert manuszewski in ue5-main branch]
2022-11-01 15:08:10 -04:00
edwin maynard
2f2e641dd0 [Backout] - CL22878456 (Backed out due to CIS issues)
[FYI] Robert.Manuszewski
Original CL Desc
-----------------------------------------------------------------
Adding FPackageName::GetContentPathForPackageRoot to be able to get the filesystem path (e.g. D:/Project/Engine/Content) of a given package root (e.g. /Engine/)

#rb Steve.Robb
#preflight 6360c64663608aee36d1a954

[CL 22888588 by edwin maynard in ue5-main branch]
2022-11-01 15:08:01 -04:00
robert manuszewski
263c23a1dc Adding FPackageName::GetContentPathForPackageRoot to be able to get the filesystem path (e.g. D:/Project/Engine/Content) of a given package root (e.g. /Engine/)
#rb Steve.Robb
#preflight 6360c64663608aee36d1a954

[CL 22888560 by robert manuszewski in ue5-main branch]
2022-11-01 15:07:16 -04:00
henrik karlsson
48faa4b230 [CoreUObject]
* StructOnScope - Removed include of Package
* GeneratedCppInclude - Removed include of Package

Both of these files include Class.h which in turn include Package so no need to add backwards compatibility. Will add backwards compatibility in Class.h when Package.h is removed there (require a bit more work)

#preflight skipped
#rb none

[CL 22888526 by henrik karlsson in ue5-main branch]
2022-11-01 15:06:31 -04:00
Alexis Matte
2a9bfb7eef Fix crash when serializing(saving) FSkeletalMeshImportData cause by code not returning the proper UE version for the bulk data.
#jira UE-167443 , UE-167493
#rb jeanluc.corenthin
#rnx
#preflight 63612bde2b5338aceb3ddd56

[CL 22883134 by Alexis Matte in ue5-main branch]
2022-11-01 11:05:02 -04:00
andrew scheidecker
a8a6f870ca Add a few missing override specifiers and remove a vestigial method that no longer overrides anything.
#preflight 635fadcc3c0af539fdde0caa

[CL 22864389 by andrew scheidecker in ue5-main branch]
2022-10-31 11:43:34 -04:00
CarlMagnus Nordin
b48cb7ed39 AssetLoadingInsights:
Fixed recursive post loads not being tracked properly
Fixed time calculations for recursive scopes
Added support for load time tracing in the editor
Added time selection filtering to the requests tab
#rb ionut.matasaru
#preflight 635fa5cd1803be35c7ff3bc8

[CL 22858164 by CarlMagnus Nordin in ue5-main branch]
2022-10-31 07:09:17 -04:00
josh may
60aa5758b0 Ensure bCooked doesn't get mistakenly unset during reference collection in cooked versions of the editor.
#preflight 635c47003c0af539fd650f34
#rb jamie.dale, rex.hill

[CL 22850789 by josh may in ue5-main branch]
2022-10-29 03:00:34 -04:00
graeme thornton
e7986ac620 [Backout] - CL22808749
[FYI] Steve.Robb
Original CL Desc
-----------------------------------------------------------------
TMap and TSet can now be declared as members with forward-declared key and value parameters.
KeyFuncs::KeyInitType and KeyFuncs::ElementInitType typedefs are no longer used and user-defined KeyFuncs do not need to provide them.  Deprecated placeholders for these typedefs exist though they may not be defined exactly as they were before.  A new KeyType typedef needs to be provided by custom KeyFuncs which don't already inherit from BaseKeyFuncs or TDefaultMapKeyFuncs.
KeyConstPointerType, KeyInitType, ValueInitType and ElementInitType typedefs have been deprecated across TMap, TSet and TSortedMap.  Regular C++ parameter-passing semantics should be used instead (const T& Ref or T Value, depending on T).
Added missing FSetElementId::operator!=().

[FYI] steve.robb
#rb james.hopkin
[FYI] henrik.karlsson
#preflight 635a56c15d49a96f7b31938f

[CL 22850782 by graeme thornton in ue5-main branch]
2022-10-29 02:59:59 -04:00
francis hurteau
2419ef2300 Cap the number of reference gathering when printing invalid references during save since they can be pathologically expensive
#rb Matt.Peters
#preflight 635c3504052cb0bae6b189fd

[CL 22850501 by francis hurteau in ue5-main branch]
2022-10-29 01:53:18 -04:00
justin marcus
7bf1ba442a [Backout] - CL22822857
Change WebRemoteControlInternalUtils.cpp to use WIDECHAR
[FYI] aurel.cordonnier
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL22811007
[FYI] Justin.Marcus
Original CL Desc
-----------------------------------------------------------------
Fix JSON Reader UTF8 parsing.
Add ability to use JSON Reader with a string view.
Add explicit UTF8 smoke tests.
Change uses of TJsonReader<UCS2CHAR> to TJsonReader<WIDECHAR> since TStringBuilder<UCS2CHAR> doesn't compile.
Change uses of TJsonReader<char> to TJsonReader<UTF8CHAR>.  There isn't much use for TJsonReader<char> as ASCII is a subset of UTF8 so TJsonReader<UTF8CHAR> is always preferable.
#rb [at]Steve.Robb
#preflight https://horde.devtools.epicgames.com/job/635980ead86d91ca2cfabc77

[CL 22835909 by justin marcus in ue5-main branch]
2022-10-28 15:39:05 -04:00
henrik karlsson
cd1466475b Fixed up const/constexpr variables in header files to be "inline"
This is required for c++ modules/header units in order to decide if constexpr/const value should be available to outside module

#preflight 635c0b5c1803be35c767e0ea
#rb none

[CL 22835882 by henrik karlsson in ue5-main branch]
2022-10-28 15:38:42 -04:00
john barrett
356f62ec6e Added stack crashdump helpers for async demo crashes.
#rb Brian.Bekich, LouisPhilippe.Seguin, Johan.Torp, Ryan.Gerleve
#preflight 635a6fee9b2e9c76c7038ade

[CL 22827074 by john barrett in ue5-main branch]
2022-10-28 08:02:41 -04:00
aurel cordonnier
c34355bbdf [Backout] - CL22811007
[FYI] Justin.Marcus
Original CL Desc
-----------------------------------------------------------------
Fix JSON Reader UTF8 parsing.
Add ability to use JSON Reader with a string view.
Add explicit UTF8 smoke tests.
Change uses of TJsonReader<UCS2CHAR> to TJsonReader<WIDECHAR> since TStringBuilder<UCS2CHAR> doesn't compile.
Change uses of TJsonReader<char> to TJsonReader<UTF8CHAR>.  There isn't much use for TJsonReader<char> as ASCII is a subset of UTF8 so TJsonReader<UTF8CHAR> is always preferable.
#rb [at]Steve.Robb
#preflight https://horde.devtools.epicgames.com/job/635980ead86d91ca2cfabc77

[CL 22823854 by aurel cordonnier in ue5-main branch]
2022-10-28 01:03:42 -04:00
anton dunchev
90787f42bc Print script warning caller name.
Printing full stack trace could quickly bloat log, but we can print only top level caller actor to narrow down what BP is responsible for the warning.
Main use case is to catch BP which causes Script Msg: Divide by zero: Divide_VectorFloat and other UKismetMathLibrary errors.

#rb andrew.ladenberger, Steve.Robb
#tests replay run

[CL 22823605 by anton dunchev in ue5-main branch]
2022-10-28 00:34:39 -04:00
justin marcus
e432616e7f Fix JSON Reader UTF8 parsing.
Add ability to use JSON Reader with a string view.
Add explicit UTF8 smoke tests.
Change uses of TJsonReader<UCS2CHAR> to TJsonReader<WIDECHAR> since TStringBuilder<UCS2CHAR> doesn't compile.
Change uses of TJsonReader<char> to TJsonReader<UTF8CHAR>.  There isn't much use for TJsonReader<char> as ASCII is a subset of UTF8 so TJsonReader<UTF8CHAR> is always preferable.
#rb [at]Steve.Robb
#preflight https://horde.devtools.epicgames.com/job/635980ead86d91ca2cfabc77

[CL 22823191 by justin marcus in ue5-main branch]
2022-10-27 23:19:57 -04:00