Commit Graph

54 Commits

Author SHA1 Message Date
Devin Doucette
0db4050542 Zen: Changed the Analytics dependency from public to private
#preflight 6362b15954471d10be06613a
#rb none
#rnx

[CL 22924597 by Devin Doucette in ue5-main branch]
2022-11-02 15:43:23 -04:00
mark lintott
c6f8a9e9d9 Removed AnalyticsEventAttribute.h from the ZenServerInterface and VirtualizationManager header
#rb paul.chipchase
#jira none
#preflight 63625ed70c2e7c8f91891d11

[CL 22911432 by mark lintott in ue5-main branch]
2022-11-02 08:18:25 -04:00
mark lintott
490070be3c Decoupled Zen, DerivedDataCache and Virtualization dependency from Studio Analytics. Systems can now register callbacks to append or modify Event payloads to analytics events by name via the FAnalytics interface.
#rb Nick.Darnell
#fyi Paul.Chipchase,Zousar.Shaker
#preflight 636248d054471d10bedc3749

[CL 22909100 by mark lintott in ue5-main branch]
2022-11-02 06:56:10 -04:00
carlmagnus nordin
a140b38ac8 Fixed some potential integer overflows in Zen/COTF communication layers
#preflight 6350f7a98449f85a479e6746
#jira UE-166519,UE-166521,UE-166522,UE-166525
#rb pj.kack
#lockdown mark.lintott

[CL 22655214 by carlmagnus nordin in ue5-main branch]
2022-10-20 10:21:52 -04:00
Zousar Shaker
30a941b659 Set the working directory when launching zenserver to avoid the working directory being inherited from the running process and leading to issues with that path being in use when it needs to be deleted.
#rb matt.peters
#rb FNMain
#preflight 634efe22215dc19825407297

[CL 22610484 by Zousar Shaker in ue5-main branch]
2022-10-18 16:44:32 -04:00
dan engelbrecht
b0b3345d11 Add "Accept" field in Zen RPC request to enable new style RPC responses.
See https://github.com/EpicGames/zen/pull/180 for Zen side change.
#rb stefan.boberg zousar.shaker
#preflight 6347c2568a0a7b2adcbe4d71

[CL 22505182 by dan engelbrecht in ue5-main branch]
2022-10-13 11:17:53 -04:00
dan engelbrecht
0f1143130a Use Http::TryLoadCbPackage as first option to parse packages from Zen.
This will allow UE to talk to both old and new zen servers as we move to use the new package wire format in Zen responses.
#rb devin.doucette
#preflight 6334bf81691c0168b71bc0a9

[CL 22233160 by dan engelbrecht in ue5-main branch]
2022-09-28 18:22:23 -04:00
jessica agee
403f029bd7 Set UnsafeTypeCastWarningLevel to Error for a few widely-used modules
#rb none
#preflight 630d013af92416fb926b3c7a
#preflight 630d0938e54ec9d5815ebb45

[CL 21696478 by jessica agee in ue5-main branch]
2022-08-30 02:22:04 -04:00
devin doucette
eb55a547d0 Fixed unsafe type casts in a few widely-used modules
#preflight 62f72b49185b21882ac5c366
#rb Steve.Robb
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 21404445 via CL 21404453 via CL 21404464
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v975-21357124)

[CL 21407133 by devin doucette in ue5-main branch]
2022-08-16 12:35:53 -04:00
bryan sefcik
de1956f47b Ran IWYU on Public headers under Engine/Source/Developer/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21064294 by bryan.sefcik
#jira
#preflight 62d5c2111062f2e63015e598

#ROBOMERGE-OWNER: bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21155249 via CL 21158121 via CL 21161259
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21182053 by bryan sefcik in ue5-main branch]
2022-07-20 12:03:45 -04:00
Zousar Shaker
5397757d9a Fix bugs with the installation of the symbol file and crashpad_handler when launching ZenServer.
#rb matt.peters
#rnx
#preflight 62b39086767c9aaf34adbd36

[CL 20783321 by Zousar Shaker in ue5-main branch]
2022-06-22 18:18:26 -04:00
Zousar Shaker
eac62026c9 Ensure that when subprocesses are launched (turnkey or launcher) that the ZenDataPath is inherited from the parent process. This avoids errors experienced in the CookOnTheFly flow when the parent process and subprocess differ in their expectation for Zen arguments.
#rb devin.doucette
#jira UE-154809
#robomerge EngineMerge
#rnx
#preflight 62a8d353cf54a658ee26ce9d

[CL 20655173 by Zousar Shaker in ue5-main branch]
2022-06-14 15:37:29 -04:00
Zousar Shaker
d34d74fad2 Avoid compiling in desktop-only Zen functionality for Stadia due to the use of PLATORM_UNIX instead of PLATFORM_LINUX.
#rb devin.doucette
#fyi martin.ridgers
#preflight 62967ef3261e39f6206b0a82

[CL 20444919 by Zousar Shaker in ue5-main branch]
2022-05-31 20:12:27 -04:00
Zousar Shaker
edf8ae1f0b 2nd submit:
Switch Zen cache store to use the HTTP request codepath in the Jupiter cache store while taking some of the improvements that had been made when that code was branched off to make the Zen HTTP codepath.  This is a precursor for getting Zen cache store using non-blocking operations like Jupiter cache store - this has started to be stubbed in with the EnqueueAsyncRpc methods that are stubbed in but not used from the Zen cache store.  Eventually I'd like this HTTP code to move out of the DerivedDataCache module and be usable elsewhere and supplant the HTTP code currently in the Zen module, but this will require some decisions about whether IRequestOwner should move out of the DerivedDataCache module or not.

Tested Zen operation using ShooterGame editor.
Tested Jupiter operation using CitySample editor (empty local cache).

#rb devin.doucette
#fyi stefan.boberg
#preflight 62953e65401169f78c57c298
#preflight 629642a1be0ae0b33a46d012

[CL 20438549 by Zousar Shaker in ue5-main branch]
2022-05-31 12:42:17 -04:00
Zousar Shaker
77f51a02b9 [Backout] - CL20433163
#fyi Zousar.Shaker
Original CL Desc
-----------------------------------------------------------------
Switch Zen cache store to use the HTTP request codepath in the Jupiter cache store while taking some of the improvements that had been made when that code was branched off to make the Zen HTTP codepath.  This is a precursor for getting Zen cache store using non-blocking operations like Jupiter cache store - this has started to be stubbed in with the EnqueueAsyncRpc methods that are stubbed in but not used from the Zen cache store.  Eventually I'd like this HTTP code to move out of the DerivedDataCache module and be usable elsewhere and supplant the HTTP code currently in the Zen module, but this will require some decisions about whether IRequestOwner should move out of the DerivedDataCache module or not.

Tested Zen operation using ShooterGame editor.
Tested Jupiter operation using CitySample editor (empty local cache).

#rb devin.doucette
#fyi stefan.boberg
#preflight 62953e65401169f78c57c298

[CL 20433363 by Zousar Shaker in ue5-main branch]
2022-05-30 19:32:59 -04:00
Zousar Shaker
2f6cbf5012 Switch Zen cache store to use the HTTP request codepath in the Jupiter cache store while taking some of the improvements that had been made when that code was branched off to make the Zen HTTP codepath. This is a precursor for getting Zen cache store using non-blocking operations like Jupiter cache store - this has started to be stubbed in with the EnqueueAsyncRpc methods that are stubbed in but not used from the Zen cache store. Eventually I'd like this HTTP code to move out of the DerivedDataCache module and be usable elsewhere and supplant the HTTP code currently in the Zen module, but this will require some decisions about whether IRequestOwner should move out of the DerivedDataCache module or not.
Tested Zen operation using ShooterGame editor.
Tested Jupiter operation using CitySample editor (empty local cache).

#rb devin.doucette
#fyi stefan.boberg
#preflight 62953e65401169f78c57c298

[CL 20433163 by Zousar Shaker in ue5-main branch]
2022-05-30 18:14:02 -04:00
David Harvey
b5840fed7f removing several PLATFORM_HOLOLENS references, mostly around WindowsHWrapper etc.
#jira UE-149794
#rnx
#preflight 628f7a4df622d972b5db8318
#rb pending

[CL 20391626 by David Harvey in ue5-main branch]
2022-05-27 07:04:22 -04:00
devin doucette
b2a07ea03e DDC: Merge from UE5/Main
#preflight 6288ff678828ea88c8af7034
#preflight 628ab5d93246d5019db76ed2
#rb none
#rnx

#ROBOMERGE-OWNER: devin.doucette
#ROBOMERGE-AUTHOR: Devin.Doucette
#ROBOMERGE-SOURCE: CL 20353148 via CL 20353832 via CL 20353839
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20355348 by devin doucette in ue5-main branch]
2022-05-24 16:40:25 -04:00
Zousar Shaker
d64ab67c15 Increase the time window that ZenServer has to launch within before it becomes an error for unattended executions.
#rb none
#rnx
#preflight 626f65bd332a0b0e0b283c4f

[CL 20006381 by Zousar Shaker in ue5-main branch]
2022-05-02 01:05:46 -04:00
Zousar Shaker
773d501638 Move ZenLogPath and ZenCfgPath commandline arguments to "non-transient" arguments that will influence whether their modification causes a running instance of zenserver should be stopped/started.
#rb none
#rnx
#preflight 626c5e05320b2198448e71c3

[CL 19987200 by Zousar Shaker in ue5-main branch]
2022-04-29 18:10:02 -04:00
Zousar Shaker
c54c86c43f Add command-line option for passing config file path when launching ZenServer.
#rb none,Trivial
#rnx
#preflight 626772dd820fbeb9a4e16c3e

[CL 19915984 by Zousar Shaker in ue5-main branch]
2022-04-26 00:23:58 -04:00
Devin Doucette
748e39e3c0 Replaced uses of _SV with TEXTVIEW
#preflight 6266da740634d0904ce6de29
#rb Steve.Robb
#rnx

[CL 19905760 by Devin Doucette in ue5-main branch]
2022-04-25 13:56:30 -04:00
Devin Doucette
92a888c1f6 Replaced uses of _ASV with ANSITEXTVIEW
#preflight 6266acf50634d0904cdfe91c
#rb Steve.Robb
#rnx

[CL 19903251 by Devin Doucette in ue5-main branch]
2022-04-25 11:31:36 -04:00
Per Larsson
dc0583348b Zen - experimental web socket client
#rb paul.chipchase
#rnx
#preflight 6231d4bcac0173aa412c8706

[CL 19405005 by Per Larsson in ue5-main branch]
2022-03-16 09:17:31 -04:00
zousar shaker
625a874551 Resolve compile issue in UE Zen client caused by including an Internal header from a Public header.
This is being resolved by cherrypicking 19196840 by mark.lintott from UE5/Main (see original changelist details at the end of this cl description).  On top of the cherrypick, there was a change made to re-use a single Http request when fetching stats.  This avoids the overhead of doing name resolution repeatedly if the zen instance has a name instead of IP address.

Tested by:
- Running ShooterGame editor & observing UnrealInsights for ZenHttp_CurlPerform timers and ensuring they are not happening on the game thread when the editor is sitting idle (they are on background threads instead)
-Terminating ZenServer.exe while the editor is running and observing whether the framerate of the editor is negatively affected

#rb matt.peters
[FYI] mark.lintott
#jira UE-132849
#jira UE-143182
#lockdown aurel.cordonnier
#preflight 6220038831454c90cc13a123

Original changelist:
============
Blocking Zen HTTP stats request now runs async using futures
#rb Andriy.Tylychko
#[fyi] Zousar.Shaker
#jira UE-132849
#preflight 621e0c71e15c51d8c5bd5967

#ushell-cherrypick of 19196840 by mark.lintott

#ROBOMERGE-OWNER: zousar.shaker
#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 19234318 in //UE5/Release-5.0/... via CL 19236659
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19237357 by zousar shaker in ue5-main branch]
2022-03-02 22:10:10 -05:00