Commit Graph

5050 Commits

Author SHA1 Message Date
dave jones2
8e63e97e14 This change broke loading of cooked content in the editor, which we technically need to support.
Note: after revert, this will be resubmitted with a deadend, so it stays in the current stream.

[Backout] - CL24029894
[FYI] danny.couture
Original CL Desc
-----------------------------------------------------------------
Reduce ping/pong/latency between threads by removing asyncpackage loader now that iostore is the default for cooked data in editor
   - Saves ~5s on 30s of a warm cookbythebook for a small project

#rnx
#rb CarlMagnus.Nordin
#preflight 63e100d9cf24c08f2c89541e

[CL 25203018 by dave jones2 in ue5-main branch]
2023-04-26 13:58:03 -04:00
paul chipchase
a0e172c2c0 Add an explicit cast to GetObjectOuterHash to supress a truncation warning and show intent.
#rb Johan.Torp
#jira none
#rnx
#preflight 6447a8c72804595a04cae50b

- Also fixed up some comments that had gotten out of date with the code.

[CL 25194700 by paul chipchase in ue5-main branch]
2023-04-26 03:13:14 -04:00
paul chipchase
d35e2d3e1a Fixed some potential truncations errors in UObjectHash
#rb Johan.Torp
#jira none
#rnx
#preflight 644677a427014596f361d249

- Fixed inconsistency in how allocation sizes were being handled by storing everything as SIZE_T, removing the need to cast.
- Fixed some whitespace issues (spaces instead of tabs)

[CL 25194697 by paul chipchase in ue5-main branch]
2023-04-26 03:12:42 -04:00
paul chipchase
9b0daf1a44 Fix potential truncation in FUnversionedPropertySerializer constructor
#rb Johan.Torp
#jira none
#rnx
#preflight 643935f98e01968448188986

- It is expected that the value of GetIntNum will fit in a uint8 so we can just cast.

[CL 25194695 by paul chipchase in ue5-main branch]
2023-04-26 03:12:08 -04:00
danny couture
f039803cb0 Fix some reentrancy problems during flush in zenloader
#rnx
#rb Francis.Hurteau, PJ.Kack
#preflight 6447b6ed671e6df177089f22

[CL 25179889 by danny couture in ue5-main branch]
2023-04-25 10:11:12 -04:00
pj kack
4f65ed1be6 ZenLoader: Minor code modification to fix pvsstudio warning V595
Engine/Source/Runtime/CoreUObject/Private/Serialization/AsyncLoading2.cpp(4723): warning V595: The 'ImportedPackageRef.GetPackage()' pointer was utilized before it was verified against nullptr. Check lines: 4723, 4741.

#rb per.larsson
#rnx
#preflight 64466ef2434155a8f81c05c0

[CL 25176896 by pj kack in ue5-main branch]
2023-04-25 03:49:14 -04:00
pj kack
88dcc1e183 ZenLoader: Now that we only finish loading packages that are part of the current sync load (see 25024411) we need to let IncludePackageInSyncLoadContextRecursive process all packages that has not reached the Complete state yet.
Fix infinite load problem when flushing a package that is already in the LoadedPackagesToProcess array.

#rb francis.hurteau
#rnx
#preflight 64468e8ddc71c13446e00210

[CL 25176836 by pj kack in ue5-main branch]
2023-04-25 03:31:02 -04:00
joe pribele
9f5fbe6b97 reducing the number of items in the array conversion tests as the 100k items was unnecessary
https://p4-swarm.epicgames.net/reviews/25165292

#rb devin.doucette
#preflight 6446f4a827014596f3952e7d

[CL 25172199 by joe pribele in ue5-main branch]
2023-04-24 17:46:08 -04:00
Steve Robb
fd82f5215a Added a CBaseStructureProvider concept for detecting if a type is supported by TBaseStructure.
Deleted the second parameter from TStructOnScope, which doesn't work so well with forward-declared types.

#rb robert.manuszewski
#jira none
#preflight 64466ad927014596f34ea1e6

[CL 25162348 by Steve Robb in ue5-main branch]
2023-04-24 08:05:26 -04:00
robert manuszewski
fa6945160f Fixing option property GC processing code
[CL 25159958 by robert manuszewski in ue5-main branch]
2023-04-23 19:47:43 -04:00
marc audy
323d21af1c [Backout] - CL25150340
[FYI] patrick.enfedaque
Original CL Desc
-----------------------------------------------------------------
Fix newly created flags not being properly stripped from packages on save

#rb Patrick.Enfedaque, Matt.Peters
[FYI] francis.hurteau
#jira UE-183445
#preflight 643effcf73470c177c37354a
#p4v-cherrypick 25108804

[CL 25153381 by marc audy in ue5-main branch]
2023-04-21 16:50:48 -04:00
patrick enfedaque
b8b00a8495 Fix newly created flags not being properly stripped from packages on save
#rb Patrick.Enfedaque, Matt.Peters
[FYI] francis.hurteau
#jira UE-183445
#preflight 643effcf73470c177c37354a
#p4v-cherrypick 25108804

[CL 25153293 by patrick enfedaque in ue5-main branch]
2023-04-21 16:47:54 -04:00
matt peters
74346ba7b0 SavePackage TransientPropertyOverrides: Fix harvesting of FNames for the transient override properties to be included. They are needed during serialization of the properties when the exports are saved into FLinkerSave.
#rb Francis.Hurteau
#rnx
#preflight 64429c894944ef78926c394f

[CL 25149530 by matt peters in ue5-main branch]
2023-04-21 14:05:35 -04:00
Matt Peters
330d05499f UBlueprint::PostLoadAssetRegistryTags: When fixing up short path names, the short path name may no longer exist and have been redirected (e.g. GameplayAbilityBlueprintGeneratedClass). In that case,clear the tag; it will need to be recreated by recompiling the blueprint, which will happen on PostLoad.
Keeping the invalid shortname will trigger an assertion when saving the assetregistry if the asset is not loaded during the cook.
#rb Dan.Engelbrecht
#rnx
#preflight 6441b9eef126d87e45a3bd63

[CL 25146571 by Matt Peters in ue5-main branch]
2023-04-21 11:40:41 -04:00
jeanfrancois dube
b750c21e3e Add linker support to skip loading imports that are remapped to none from the instancing context.
This can be used to partially load an instanced package based on the caller's instancing context.

#rb francis.hurteau
#preflight 644188a3f030f684d52d2782

[CL 25139575 by jeanfrancois dube in ue5-main branch]
2023-04-20 19:04:18 -04:00
josh adams
b618bab642 - Fixed the root cause of GConfig and DefaultConfig.ini getting out of sync
#jira UE-183508
#preflight https://horde.devtools.epicgames.com/job/6441883327014596f3ce7922

[CL 25139543 by josh adams in ue5-main branch]
2023-04-20 19:03:18 -04:00
Matt Peters
ce0616d173 OnlyEditorOnly support: Add scopes around the load of undeclared dependencies so that the cooker knows whether they need to be added to the cook.
* Add more uses of the existing FSoftObjectPathSerializationScope, UE_TRACK_REFERENCING_PACKAGE_SCOPED , and FSerializedPropertyScope.
* Add a new FCookLoadScope which is similar to FSoftObjectPathSerializationScope but applies to undeclared loads rather than to SoftObjectPath references.
* Tunnel the scopes through to the eventual package creation when asynchronous loads are triggered through StreamingManager or AsyncLoading.
#rnx
#rb Zousar.Shaker
#preflight 64418782b14f1faacfbb1908

[CL 25135331 by Matt Peters in ue5-main branch]
2023-04-20 15:50:24 -04:00
kirill zorin
d78d7d61ae Updating callsites of ToRawPtr{*}Unsafe in preparation for upcoming mutable TObjectPtr container restrictions.
#rb zousar.shaker
#preflight 64416b5f4f243417cd7c41d7

[CL 25130429 by kirill zorin in ue5-main branch]
2023-04-20 13:00:27 -04:00
Matt Peters
35cf645860 OnlyEditorOnly: Move ICookInfo.h into CoreUObject so new scopes that will be added into it can be used by LinkerLoad and AsyncLoading.
#rb None, trivial
#rnx
#preflight 6441571a9566b6145062888b

[CL 25128993 by Matt Peters in ue5-main branch]
2023-04-20 11:56:08 -04:00
josh adams
f024fd97c2 - Stop writing out saved ini files after reloading ini after writing a default property (the timing of the write was getting the default and saved out of sync)
#jira UE-183508, UE-166236
#preflight https://horde.devtools.epicgames.com/job/64404d75a35280ed4f925b2d

[CL 25120275 by josh adams in ue5-main branch]
2023-04-19 19:47:50 -04:00
kirill zorin
391337c97d Add deprecation path for mutable TArray/TArrayView<TObjectPtr<...>> implicit conversions
#rb zousar.shaker
#rb devin.doucette
#rb steve.robb
#rb robert.manuszewski
#rb saam.barati

#preflight 64402c6f8d0bcde49c5a4cb1

[CL 25112110 by kirill zorin in ue5-main branch]
2023-04-19 14:31:15 -04:00
Matt Peters
c1045c0b2d FPathViews::Less: Fix inconsistent sort order that was breaking DirectoryTree.
"Foo" < "Foo-Bar "
but
"Foo/" > "Foo-Bar/".
In the new order, '/' and '\\' are less than every character except '\0'.
Note this will change existing sort order ('A' used to be  less than '\\', now it is more than '\\) and might cause some cooked packages with strings sorted by path to change.
#rb Devin.Doucette, Bob.Tellez
#rnx
#preflight 64400892b91c130758a9762d

[CL 25111252 by Matt Peters in ue5-main branch]
2023-04-19 13:53:06 -04:00
francis hurteau
af723360a3 Fix newly created flags not being properly stripped from packages on save
#rb Patrick.Enfedaque, Matt.Peters
#jira UE-183445
#preflight 643effcf73470c177c37354a

[CL 25109998 by francis hurteau in ue5-main branch]
2023-04-19 13:05:48 -04:00
patrick enfedaque
28d0f74d94 LinkerInstancingContext: Support Instancing Prefix
- Add support for Instancing Prefix
- Add Automation Test
- Bring back CL 24926885 now that Prefix are supported

#rb richard.malo
#preflight 643fd42d211b661dc4b9846b
#rnx

[CL 25106963 by patrick enfedaque in ue5-main branch]
2023-04-19 11:01:11 -04:00
paul chipchase
db540cc55d Fix potential truncation warning in ::ResolveName
#rb trivial
#jira none
#rnx
#preflight

- The pointer arithmetic is being done within the contents of an FString, which we know must fit in a int32 for length, so we know the cast is safe.

[CL 25104954 by paul chipchase in ue5-main branch]
2023-04-19 09:11:50 -04:00