Automation - Adding more options for forcing and waiting for loading and streaming to finish and more utilities for waiting for that to happen entirely for tests.
Lauren.Ridge
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 5382989 via CL 5383481 via CL 5383540
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5385045 by nick darnell in Dev-Anim branch]
Automation - Adding more options for forcing and waiting for loading and streaming to finish and more utilities for waiting for that to happen entirely for tests.
Lauren.Ridge
#ROBOMERGE-SOURCE: CL 5382989 via CL 5383481
[CL 5383540 by nick darnell in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 4048227 by Rolando.Caloca
VR - vk - Some Vulkan merge conflicts resolved
Change 4078631 by Mike.Beach
Fixing MR Calibration so it scales the alignment model according the the capture's FOV (so they appear the same size across capture devices - leading to a homogenous experience).
Also moved the FOV override config setting to be a console command/setting (mrc.FovOverride) to help in testing this.
#jira UE-55499
Change 4080389 by Mike.Beach
Speculative fix/guard against live crash - trying to catch malformed model data. Logging helpful information to give us insight in the future.
#jira UE-57680
Change 4080792 by Joe.Graf
Prep work for moving face ar to its own plugin
Change 4080852 by Joe.Graf
Prep work for moving face ar support to its own plugin
Change 4081735 by Keli.Hlodversson
Remove a workaround change from the Lumin branch that should not have been merged over.
Change 4081737 by Keli.Hlodversson
Fix SteamVR forcing full screen regardless of user settings.
#jira UE-51654
Change 4082323 by Joe.Graf
Pulled face ar support into its own plugin so that it can be enabled/disabled independently from room ar
Change 4082334 by Joe.Graf
Changed where face LiveLink was logging to
Change 4095529 by Joe.Graf
Dramatically simplified the face API isolation to a separate plugin
Change 4103356 by Joe.Graf
Fixed a threading bug that appeared when migrating the face ar code into its own plugin
Change 4109752 by Joe.Graf
Added a setting to specify the type of AR world alignment transform type a session should use
Deleted some old ARKit configuration code that wasn't really used
Fixed the setting of light estimation using the wrong value to determine the setting on ARKit
#jira: UE-58544, UE-59371
Change 4110601 by Jason.Bestimt
#DEV-VR - Adding spaces to plugin names
#JIRA: UE-58642, UE-58643
Change 4110721 by Jason.Bestimt
#DEV-VR - Removing question mark from tooltip
#JIRA: UE-58641
Change 4111412 by Joe.Graf
Fixed a bad merge of BaseEngine.ini
Change 4111902 by Nick.Whiting
Adding in support for locking HMD tracking to an external tracking environment (e.g. mo cap). This is not meant to drive the position continually in lieu of an HMD's built in system, but is rather to help keep the HMD from generally getting out of alignment with another tracking system. Two functions, CalibrateExternalTrackingToHMD and UpdateExternalTrackingHMDPosition allow for arbitrary rigid offsets between the HMD and the external tracking source, and updating as desired.
Change 4116059 by Joe.Graf
First pass integration of ARKit 2.0 (very wip, thar be dragons everywhere)
Change 4116109 by Jason.Bestimt
#DEV-VR - Disable editing of Tegra Debugger setting for installed builds
#JIRA: UE-58636
Change 4117821 by Jason.Bestimt
#DEV-VR - Fix for crash in DebugCanvas on application termination
#JIRA: UE-58865
Change 4118560 by Joe.Conley
MagicLeap ImageTrackerComponent: Adding check for PLATFORM_LUMIN to prevent PIE crash running code that was designed to only run on device.
Tested PIE in editor and launching to device.
Change 4118626 by Jason.Bestimt
#DEV-VR - Removing ES2 from bMobileRendering Tooltop
#JIRA: UE-58640
Change 4119786 by Joe.Conley
Merging CL-4118965 from Release-4.20 using DevVRtoRelease420
Change 4119906 by Joe.Conley
Magic Leap settings: Changing comment/tooltip on mobile rendering flag to not mention vulkan and just say "mobile". Still technically possible to use ES2 but it's hidden.
#jira UE-59755 "Magic Leap: Project setting to set vulkan or ES2 needs to be removed"
Change 4122067 by Jason.Bestimt
#DEV-VR - Copying all relevant files for Resonance Audio
Change 4122930 by Keli.Hlodversson
Use XR ThreadUtils when scheduling GameTrackingThread to Render and RHI thread.
#jira UE-58852
Change 4123848 by Nick.Whiting
Enabling RHI threading on Lumin
Change 4124116 by Nick.Whiting
Adding support for DefaultStereoLayers on Lumin
Change 4151051 by Joe.Conley
Magic Leap: Override IniPlatfromName() for LuminTargetPlatform to report "Lumin" rather than reporting the value from it's parent, AndroidTargetPlatform, "Android".
#jira UE-60389 "Lumin - Need to switch the *Phaedra* launch on option "All_Android_On..." to a single "All_Phaedra_On..." with no expandable options"
Unsure if this will affect more than just this display name, as IniPlatformName() is used in a few places in the code, but eventually it will need to be "Lumin" anyway so we'll fix fallout as we find it.
Change 4160099 by Nick.Whiting
Enabling RHI threading on Vulkan by default on Magic Leap
Change 4163986 by Joe.Graf
Merging using Dev-VR_to_Release-4.20
Change 4164500 by Joe.Graf
Merging using Release-4.20_to_Dev-VR
Change 4166311 by Jason.Bestimt
#DEV-VR - Merge from //UE4/Dev-MagicLeap/... @ CL 4136411
Change 4167085 by Ryan.Vance
#integrating 4.20 cl 4132173 to fix mobile vulkan occusion query issues.
#jira UE-61051
Change 4167151 by Jason.Bestimt
#DEV-VR - Manual merge of Dev-MAIN to resolve conflicts for robomerge
Change 4167983 by Joe.Conley
For Lumin, only build shaders for OpenGL or Vulkan, not both. Fix a shader compile error in BogMyrtle material (can't use SpeedTree node on mobile).
#jira UE-61126 Lumin Sample: Warning: LogMaterial : Failed to compile material for GLSL_ES2
Change 4168244 by Nick.Whiting
Fix for stereo layers crashing on exit, where the DebugCanvas was destroyed after the layer manager, causing a nullptr dereference
Change 4170213 by Mike.Beach
CIS build fix - removing duplicate definition & adding a missing #pragma once to a header fille
#mlqdr
Change 4170299 by Mike.Beach
LNK fix - fixing up more fallout from the recent merge from DevMain. Adding in missing function that was dropped in the merge (matching Main's version).
Change 4170962 by Nick.Whiting
Back out changelist 4160099: Removing the enabling by default on lumin
Change 4171227 by Chance.Ivey
Unreal Engine logos for Portal and Model. These need to be set in Project Settings.
Change 4171260 by Chance.Ivey
Removing ML basic assets for project icons.
Change 4171939 by Joe.Conley
#jira UE-61124 Lumin Sample: EDL errors during Launch On
Change Lumin Sample to use vulkan, like we do for everything by default now.
Didn't see this error after this change.
Change 4172321 by Mike.Beach
Sizing the debug layer properly for the magic leap device (inverting the y when rendering with opengl).
#jira UE-60299
#mlqdr
Change 4174175 by Jason.Bestimt
#DEV-VR - Fix for dragging a "skylight" from lighting menu directly into sequencer.
Change 4174237 by Jason.Bestimt
#DEV-VR - fixing initializer order
#JIRA - UE-61337
Change 4175281 by Joe.Graf
Added support to stream a preview image and the accompanying AR world data for shared AR experiences
Change 4175656 by Ryan.Vance
Copying //Tasks/UE4/Dev-VR-VulkanMedia to Dev-VR (//UE4/Dev-VR)
Preliminary vulkan media player support for ML.
There are a number of tasks left to do with this feature before committing to main:
- Clean up leaked color conversion handles
- Texture slot binding is not robust for media textures
- Color conversion extension init should be move to a lumin platform function
- Mobile renderer's base pass may collapse multiple materials together into the same drawing policy, so the immutable samplers referenced in the pso would bleed into other materials
- Fixing above will allow us to remove the immutable samplers from the mobile material rendering proxy to ensure we don't re-introduce the fort bug listed in the related comment
Change 4175684 by Ryan.Vance
Fix for vk media player crash
Change 4175699 by Nick.Whiting
Merging CL 4175640 (fix for Audio Capture pausing and resuming) to Dev-VR
Change 4176804 by Joe.Conley
Rolando originally hacked the RHI for Lumin with the ForceEnableDebugMarkers() function; return false there instead of if PLATFORM_LUMIN.
Change 4178261 by Ethan.Geller
Back out changelist 4175699 #fyi nick.whiting #rb none
Change 4179088 by Mike.Beach
Mirroring CL4178961.
Removing spammy error log, per consult from ML - apparently, at this time, MLSnapshotGetTransform() can return NaNs (which we handle). It is currently expected from the API.
#jira UE-61127
#mlqdr
Change 4179629 by Jeff.Fisher
UEVR-1209 Update to Magic Leap Hand Tracking API
-Switched from the Gestures API to the HandTracking API
-There is nothing like the 0 and 1 tracking point that change meaning per gesture in the new API, so I assigned the former Center/Pointer/Secondary special 1/3/5 2/4/6 to Center/IndexFingerTip/ThumbTip.
#review-4178177
#jira UEVR-1209
#mlqdr
Change 4179705 by Jeff.Fisher
MagicLeapHandTracking CIS fix.
Change 4181301 by Joe.Graf
Moved FaceARSample to Samples/Sandbox/AR/ so we can have all of the AR samples together
Change 4181402 by Joe.Graf
Fixed a missing #ifdef wrapper in the MagicLeap plugin
Change 4181445 by Joe.Graf
Fixed another missing #ifdef wrapper in the MagicLeap plugin
Change 4181558 by Jeff.Fisher
HandTracking LeftGestureButton fix
-The reality is Nihav made the fix, and I reviewed it.
Change 4185551 by Joe.Graf
Added support to query and specify the desired video format for an AR session
Change 4185843 by Joe.Graf
Merged in absolute scale/location/rotation PR #4760 from Wang Hao
Change 4186875 by Joe.Graf
Added stats for face ar
#jira: UE-53883
Change 4187681 by Joe.Graf
Fixed unity build compilation error
Change 4188782 by Joe.Graf
Work around LiveLink interpreting ARKit timestamps incorrectly causing jitter and animation lag
#jira: UE-61540
Change 4189204 by Joe.Graf
Merging using Release-4.20_to_Dev-VR
Change 4189331 by Joe.Graf
Removed all of my merge markers from the lab
Change 4189477 by Joe.Graf
Added performance tuning options for Face AR to ARSessionConfig
Added whether to mirror or be face relative for Face AR to ARSessionConfig
#jira: UE-53881
Change 4189835 by Joe.Graf
Changed how timestamps for ARKit objects are updated to make them more amenable with the engine
#jira: UE-61550
Change 4190085 by Jeff.Fisher
Duplicating from Dev-Partner-MagicLeap-4.20 cl 4189995
HandTracking 'failed to load' errors.
-Needed a package redirector as well as the various class and enum redirectors.
#MLQDR
#review-4189613
Files:
//UE4/Dev-Partner-MagicLeap-4.20/Engine/Config/BaseEngine.ini#8
Change 4190100 by Jason.Bestimt
#DEV-VR - Adding script version string to make sure AutoSDK gets run again
[To Fix CIS Builds for UE4 Lumin]
Change 4190795 by Joe.Conley
#jira UE-61265 Audio Capture Components need to hook Lumin backgrounding notifications to pause capture
Shelve 4175638 got committed but didn't compile. Fixed compile errors and changed some checks from Handle != ML_HANDLE_INVALID to MlIsValidHandle(Handle), fixed functions to return false if they error, responded to the errors by not continuing further, etc...
Don't know if this fixes all the functionality, but doesn't crash for me anymore.
Change 4196211 by Jason.Bestimt
#DEV-VR - Fixes for Android platform with new Lumin Vulkan Color Conversion Functions
Change 4199020 by Jason.Bestimt
Making sure bHaveVulkan is true for Lumin
Change 4199506 by Jason.Bestimt
#DEV-VR - Merging CL 4199443 from Dev-Magicleap to clear cache on looping media
Change 4200139 by Joe.Graf
Initial check in of a project to illustrate AR persistent sessions
Change 4200299 by Joe.Graf
Fixed the plugin setup for ARSaveLoad
Change 4200327 by Joe.Graf
Fixed adding face ar plugin instead of world ar plugin
Change 4200330 by Joe.Graf
Added a sample for using ARKit's environment probe feature
Change 4200352 by Joe.Graf
Changed the ARSessionConfig to use automatic environment probe generation
Change 4201607 by Zak.Parrish
Moving latest version of FaceARSample to DevVR
Change 4203453 by Jason.Bestimt
#DEV-VR - Fixing Audio Capture to not re-open stream if it's already open
#JIRA: UE-61609
Change 4204527 by Joe.Graf
Changed the AR World Save and AR Get Candidate Object latent actions to use the new mechanism to reduce code
Change 4204533 by Joe.Graf
POC of saving and load an AR world
Change 4204806 by Joe.Graf
Added more descriptive display names for AR blueprint operations
Change 4204870 by Jeff.Fisher
HandTracking blueprint access to all keypoints
-Duplicating for Dev-VR from Dev-Partner-MagicLeap-4.20
-Created new GetGestureKeypointTransform blueprint function to get a keypoint's transform by hand and keypoint enum.
-Deprecated the old GetGestureKeypoint methods
-Fixed Special_1 and Special_2 to use hand center instead of wrist center.
-Exposed all the keypoints to blueprint, so they can work right away when underlyign support appears in the OS.
#MLQDR
#review-4200777
Change 4204877 by Jeff.Fisher
Updated gesture test content to replace deprecated hand tracking blueprint functions.
Change 4204915 by Joe.Graf
Hid blueprint internal methods from being callable
Change 4205082 by Joe.Graf
Split ImportFileAsTexture2D into two functions so you can also import from a buffer
Change 4205170 by Joe.Graf
Made the proxy create function blueprint internal only
Change 4206898 by Joe.Graf
Initial ARSharedWorld multiplayer sample check in
Change 4207396 by Joe.Graf
Removed the FARSharedWorld from ARSharedWorldGameState to make things simpler/cleaner
Change 4207406 by Joe.Graf
Hooked up the delivery of the AR shared world data to the clients in the MP sample
Change 4207444 by Joe.Graf
Fixed the shadowing warning
Change 4207794 by zak.parrish
Checking in first stage of usable Save/Load AR work. Some UI, foundational functionality. Not testable yet.
Change 4207832 by Joe.Graf
For Zak
Change 4207952 by Joe.Graf
For Zak part 2
Change 4208268 by zak.parrish
Checking in changes to ARSaveLoad's game mode
Change 4208316 by zak.parrish
Living in shame under JoeG's rough admonishment. And fixing UI bugs.
Change 4208404 by zak.parrish
Actually saving... maybe?
Change 4208407 by Joe.Graf
Fixed wrong platform name being used as the whitelist for the AppleImageUtils plugin
Change 4209764 by Joe.Graf
Added missing module class for AppleImageUtilsBlueprintSupport
Change 4210695 by Joe.Graf
Added compression and versioning to the AR saved world data
Change 4211461 by Joe.Graf
Incremented the face live link packet version since the new blendshapes were added
Change 4211843 by Joe.Graf
Split some of the methods for ARKit conversion into a cpp from being all in the header
Added some logging during conversion
Change 4212020 by Joe.Graf
Added support for telling the AR system whether to reset tracking and tracked objects (useful for generating a play space and then using lower cpu/gpu tracking only)
Change 4212878 by Joe.Graf
Fixed inline problem and exported FAppleARKitConversion class
Change 4214969 by Ryan.Vance
#jira UEVR-1257
Adding initialization to all members in the default FAppleARKitFrame ctor
Change 4217193 by Jason.Bestimt
#DEV-VR - Fix for swapping shader cache formats and using Launch On
We now reload the settings each time they are used rather than caching once at startup
Change 4217487 by Jason.Bestimt
#DEV-VR - Fix for CIS shadowed member variable error
Change 4220007 by Jason.Bestimt
#DEV-VR - Fix for Dev-VR compile issue for Lumin Target Platform dependencies on Engine
Change 4223757 by Jason.Bestimt
#DEV-VR - Moving Lumin Audio Platform above Android because Lumin is Android
Change 4230863 by Keli.Hlodversson
Updating to SteamVR 1.0.15
Change 4235330 by Jason.Bestimt
#DEV-VR - Selective Merge from Dev-Partner-MagicLeap-4.20
CL 4117808
SKIP 4166531, 4172433, 4173415, 4174167, 4175152, 4174192
CL 4175448, 4175781, 4176126, 4176135, 4176138, 4176803, 4178961
SKIP - 4179818, 4179864
CL 4179921, 4179956, 4180229, 4180268, 4180298, 4182733, 4183548, 4184684, 4186883, 4187230, 4189420, 4189995, 4190527, 4190721
SKIP - 4191085
CL 4192219
SKIP 4195948
CL 4197287, 4197951, 4197956, 4201351, 4202541, 4202544, 4202547
SKIP 4202774
CL 4203462, 4203484
SKIP 4204670
CL 4206823, 4209729, 4209810, 4211003, 4215367, 4215662, 4215892, 4215898, 4220239, 4220257
SKIP 4220295
CL 4220307
SKIP 4221842
CL 4221866, 4222959, 4223772, 4225943
SKIP 4226329, 4227773
CL 4228213, 4228270
SKIP 422902, 4229054, 4229365, 4230881, 4233277
Change 4235969 by Joe.Conley
MagicLeap: Add quotes around the path to the tools (clang etc) in the mlsdk directory, so that it won't fail if the MLSDK directory has a space in the path.
Change 4239300 by Nick.Whiting
Adding missing uplugin file to GoogleARCoreServices
Change 4240183 by Keli.Hlodversson
Updating to SteamVR 1.0.16
Change 4241714 by joe.conley
#jira UE-62189 - "Various QAARApp/Content/...uassets have been saved with empty engine version"
Resaved assets.
Change 4242300 by Nick.Whiting
Fix for ARCore Tools being in the wrong folder, emitting RuntimeDependency ref to make sure they're properly included
#jira UE-62277
Change 4244428 by Mike.Beach
Copying //UE4/Partner-Oculus-Staging to Dev-VR (//UE4/Dev-VR)
Change 4244671 by Jeff.Fisher
Fxing 'Lumi" build break.
Change 4247283 by Nick.Whiting
Merging fix from CL 4247094 for ARCore external dependency locations
Change 4255817 by Ryan.Vance
#jira UE-58854
Vulkan Shared Texture Media Framework support cleanup
Don't leak vk color conversion handles and only allocate if needed
Move color conversion device init to a lumin platform call
Add immutable sampler state to mobile base pass policy comparison
Remove WITH_VULKAN_COLOR_CONVERSIONS wrappers around color conversion code
TODO: FVulkanDescriptorSetsLayoutInfo::AddBindingsForStage still uses the first combined image sampler found when handking materials w/ immutable sampelrs which is not robust. The correct binding needs to be selected from reflection data generated by the compiler.
Change 4256021 by Jeff.Fisher
UEVR-1261 MagicLeap HandTracking should be exposed to LiveLink
-Exposed hand tracking transforms through live link.
-Added blueprint function to get the livelink source.
-Exposed LiveLikeSourceHandle through ILiveLinkSource.h so that it can be used by the MagicLeapPlugin.
-The transforms are in tracking space. They form a hierarchical skeleton with HandCenter as the root. See FMagicLeapHandTracking::SetupLiveLinkData() for details on the hierarchy. With the current magicleap runtime functionality many transforms in the skeleton are always identity.
#jira UEVR-1261
#review-4248322
Change 4258366 by Jeff.Fisher
UE-62494 Dev-VR Editor fails to build with errors related to MagicLeapHandTrackingLiveLink.cpp
-Fixed build break
Change 4260114 by Ryan.Vance
#jira UE-62509
Moving color conversion vk entry points to lumin platform to avoid failing to find them in android drivers.
Change 4263040 by Ryan.Vance
Fixing scope issue.
Change 4263556 by Jeff.Fisher
UE-62507 Fatal error crash opening packaged QAGame
UE-62544 //UE4/Dev-VR - Run Automated Tests Cooked Win64 - Unhandled Exception
-Updated #define OPENVR_SDK_VER TEXT("OpenVRv1_0_16")
#jira UE-62507
Change 4265161 by Jason.Bestimt
#DEV-VR - Fix for Lumin BP Projects not using their project specific ini files for compiling/cooking/packaging
#JIRA: UE-62568
Change 4265739 by Ryan.Vance
Marker API override for ML VK.
The current ML driver unofficially supports debug markers, but will report the extension unsupported if queried directly.
Once they add official support, we need to add the extension name back into the list.
Change 4267320 by Ryan.Vance
We need to add the debug marker extension for all platforms but Lumin.
Change 4268149 by Michael.Trepka
Fix for Lumin Toolchain failing to compile on Mac due to changes to the SDK
[CL 4268410 by Jason Bestimt in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3774677 by Arne.Schober
DR - Deprecated SetLocal from the RHICmdlist
Fixed some unnecessary PSO collisions.
Change 3809579 by Chris.Bunner
Back out changelist 3774677.
#jira UE-53483
Change 3810363 by Mark.Satterthwaite
More random fixes to mtlpp: most important is the extension to Buffer that allows creation of sub-buffers that are merely views onto a sub-range of the parent. These sub-buffers are valid to use throughout the mtlpp API with two exceptions: they may not be used for visibilityResultsBuffers and Set*BufferOffset functions cannot take this offset into account (as the encoder does not hold onto the buffers and I don't want it to). In the case of Set*BufferOffset the caller has to know what is going on and in the case of visibilityResultsBuffers it'll just assert as it isn't sensible.
This makes it *much* easier to do things like sub-buffer allocation, though the caller must be aware of the alignment restrictions of their intended usage as they are not possible to enforce. For example, a call to SetVertexBuffer requires an offset alignment must match the alignment of the data-type in the shader for "device" resources, or for "constant" data it must be max(4, sizeof(datatype)) on iOS and 256 on macOS. This should allow for much more tightly packed sub-allocations than earlier approaches, though older drivers (e.g. Mac OS X 10.11) enforce only the coarser "constant" data restriction everywhere.
Change 3810407 by Marcus.Wassmer
PR #4322: ShadowSetup Bug Fix: Only stencil mask drawn meshes (Contributed by DSDambuster)
Change 3810676 by Guillaume.Abadie
Makes r.Test.SecondaryUpscaleOverride work with any arbitrary pixel size.
Change 3810696 by Guillaume.Abadie
Adds support for #include "../MyFile.ush" in the shader compiler.
Change 3810698 by Guillaume.Abadie
Implements enum class based shader permutation dimension.
Change 3810699 by Guillaume.Abadie
Implements Diaphragm DOF ground work.
Change 3811536 by Guillaume.Abadie
Pulls the trigger on CircleDOF's setup pass for DiaphragmDOF.
Change 3811958 by Mark.Satterthwaite
More fixes for mtlpp.
Change 3811964 by Mark.Satterthwaite
Only views onto a mtlpp::Buffer should return a valid parent-buffer.
Change 3812604 by Guillaume.Abadie
Changes Diaphragm DOF's source file layout.
Change 3812827 by Mark.Satterthwaite
More missing/broken functionality in mtlpp fixed and fixed obvious leaks.
Change 3812920 by Guillaume.Abadie
Adds support for per mip level UAV in FSceneRenderTarget.
Change 3812926 by Mark.Satterthwaite
Change the way we handle mtlpp resource construction to avoid leaks.
Change 3812960 by Rolando.Caloca
DR - vk - Disable DFGI
Change 3812968 by Rolando.Caloca
DR - Linker fix
Change 3813318 by Mark.Satterthwaite
Fix linear texture allocation from a buffer sub-view.
Change 3813326 by Mark.Satterthwaite
Fix another Metal mtlpp sub-buffer allocation failure.
Change 3813328 by Guillaume.Abadie
Removes global samplers in TAA for GL4, Vulkan and Switch.
Change 3813937 by Rolando.Caloca
DR - Fix logs not getting dumped when r.DumpSCWQueuedJobs is on
Change 3813947 by Rolando.Caloca
DR - noshaderworker should override r.XGEShaderCompile
Change 3817017 by Uriel.Doyon
Fixed texture editor black screen
#jira UE-53653
Change 3818568 by Rolando.Caloca
DR - Fix log when shader jobs crash
- Move log10 to common
- Added COMPILER_VULKAN define
Change 3818603 by Uriel.Doyon
Fix to static analysis warning
Change 3818623 by Rolando.Caloca
DR - Workaround hlslcc loop unrolling bug
Change 3819070 by Uriel.Doyon
Fix to stat duplication.
Change 3819105 by Uriel.Doyon
Refactored volume sample shader to avoid using texture dimension.
Change 3819136 by Rolando.Caloca
DR - vk - Per platform files (empty)
Change 3819180 by Rolando.Caloca
DR - vk - Move defines out of config into per platform
Change 3819247 by Rolando.Caloca
DR - vk - Remove more defines into platform settings
Change 3819318 by Rolando.Caloca
DR - vk - Fixes for linking
Change 3819868 by Rolando.Caloca
DR - vk - Linux & Android fixes
Change 3819873 by Guillaume.Abadie
Adds support for PermutationId on r.DumpShaderDebugInfo=1
Change 3819940 by Rolando.Caloca
DR - vk - Fix Linux issues
Change 3819956 by Rolando.Caloca
DR - vk - Invalid check
Change 3819961 by Michael.Lentine
Hide attributes when plugin is not present
Change 3819980 by Rolando.Caloca
DR - vk - Standard validation always
Change 3820039 by Rolando.Caloca
DR - vk - Fix invalid ensure
Change 3820326 by Rolando.Caloca
DR - vk - Linux compile fix
Change 3820422 by Michael.Lentine
Add back GBufferAO.
Change 3820433 by Rolando.Caloca
DR - Fix D3D12 crash on 20 thread (10x2 cores) machines
Change 3821677 by Rolando.Caloca
DR - vk - Win32 compile fix
Change 3821961 by Rolando.Caloca
DR - Vulkan uses real UB by default on non-Android
Change 3821968 by Rolando.Caloca
DR - vk - Update glslang 1.0.65.1
Change 3821969 by Uriel.Doyon
Added support for stat groups that must be sorted by name. Defined by DECLARE_STATS_GROUP_SORTBYNAME.
Change 3821983 by Rolando.Caloca
DR - vk - Change to static array (0.1ms on 10k draw calls)
Change 3824141 by Rolando.Caloca
DR - vk - Fix static analysis
- Bumped up some (c) 2017->2018
Change 3824355 by Rolando.Caloca
DR - vk - Accessor to find out if a cmd buffer has been submitted
Change 3824420 by Rolando.Caloca
DR - Sanity check number of queries per batch on D3D11 as to not break other RHIs
Change 3824463 by Rolando.Caloca
DR - Removed dummy ensure for D3D12
Change 3824609 by Rolando.Caloca
DR - vk - Linux compile fix
Change 3826074 by Mark.Satterthwaite
Start IMP-caching the various descriptor types in mtlpp.
Change 3826098 by Rolando.Caloca
DR - vk - Dump layer compile fixes
Change 3826113 by Rolando.Caloca
DR - vk - Missing dump functions
Change 3826302 by Rolando.Caloca
DR - vk - Compile fix
- Change dump handles to %p
Change 3826635 by Mark.Satterthwaite
Forward declarations required for mtlpp compilation without exposing Metal headers - plus fixes to the mtlpp test compiler.
Change 3827072 by Mark.Satterthwaite
Switch some more mtlpp descriptors over to IMPTables from objc_msgSend.
Change 3827909 by Guillaume.Abadie
Replaces diaphragm DOF's prefiltering with LDS bank coherent bilateral reduction, and implements 1/8 res background gathering pass.
Change 3827952 by Guillaume.Abadie
Updates copy right to year 2018 on diaphragm DOF's new files.
Change 3828055 by Rolando.Caloca
DR - vk - Rename in prep for changes
Change 3828229 by Guillaume.Abadie
Avoids to log multiple time global shader type name that have multiple permutations when verifying global shader map.
Change 3828427 by Guillaume.Abadie
Reimplements Max3x3 gathering post filtering for Diaphragm DOF with proper shader permutation.
Change 3829979 by Guillaume.Abadie
Fixes a color NaN source in diaphragm DOF's TAA pass.
Change 3830116 by Rolando.Caloca
DR - vk - Fix GPU queries/frame time on old system
- New system in place, disabled temporarily
Change 3830169 by Rolando.Caloca
DR - vk - Fix async pso creation crash
Change 3830193 by Rolando.Caloca
DR - vk - CPU RHI thread improvement
Change 3830291 by Guillaume.Abadie
Automatically lower the number of gathering rings on background half res gather pass as far CoC is getting smaller.
Change 3830300 by Rolando.Caloca
DR - vk - Static analysis fix: Split VulkanCommon.h out of VulkanConfiguration.h
Change 3830589 by Mark.Satterthwaite
In mtlpp cache the IMPTables for all the Metal @protocol's that are dependent on the MTLDevice, this avoids a mutex & map lookup. Also make all the concrete types store their IMPTable statically as it won't change.
Change 3830793 by Mark.Satterthwaite
Fix a small number of bugs introduced with the mtlpp descriptor and table caching.
Change 3831491 by Jian.Ru
Fix driver version unknown
#jira UE-53688
Change 3832335 by Rolando.Caloca
DR - vk - Change include
Change 3832550 by Rolando.Caloca
DR - vk - Occlusion query rewrite WIP
Change 3832589 by Rolando.Caloca
DR - vk - Minor refactor to pools in prep for timestamps
Change 3832618 by Rolando.Caloca
DR - vk - Do not block timestamp queries
Change 3832636 by Rolando.Caloca
DR - vk - Fix old timestamp queries
Change 3833138 by Rolando.Caloca
DR - vk - Fix timestamp queries
Change 3833249 by Rolando.Caloca
DR - vk - Test lock
Change 3833667 by Rolando.Caloca
DR - vk - Old queries wait on the RHI thread now instead of the driver (disabled)
Change 3833907 by Daniel.Wright
Fixed NextStartOffset UAV index out of bounds
Change 3833918 by Daniel.Wright
D3D12 RHI: only refcount uniform buffers if GRHINeedsExtraDeletionLatency is false, which is no longer the case for PC or Xbox. The refcounting was heavy on performance as reported by a licensee because FRHIResource uses atomics for refcounting, which is only necessary when GRHINeedsExtraDeletionLatency is disabled.
Change 3834852 by Rolando.Caloca
DR - vk - Missing file
Change 3834858 by Guillaume.Abadie
Implements r.DOF.MinimalFullresBlurringRadius
Change 3834979 by Rolando.Caloca
DR - vk - Fix
Change 3836117 by Rolando.Caloca
DR - vk - Update to 1.0.65.1
Change 3836122 by Rolando.Caloca
DR - vk - Added r.Vulkan.SubmitOcclusionBatchCmdBuffer
- Added new error codes/messages
Change 3836421 by Mark.Satterthwaite
For the purposes of debugging and conformance testing mtlpp make it possible to compile *without* the IMP cache so that we call the underlying Objective-C.
Change 3836896 by Uriel.Doyon
Fixed concurrency and exit issues around d3d12 pipeline states on windows.
Change 3837385 by Rolando.Caloca
DR - vk - Dump memory on OOM
Change 3837427 by Rolando.Caloca
DR - vk - Change some arrays to array views
Change 3837800 by Guillaume.Abadie
Implements SHADER_PERMUTATION_RANGE_INT to make contiguous integer permutations that does not start to 0.
Change 3838128 by Rolando.Caloca
DR - vk - Support for non-cached memory types
Change 3838540 by Guillaume.Abadie
Refactors Diaphragm DOF's CoC tile buffer under a single API for better maintainability.
Change 3838731 by Rolando.Caloca
DR - vk - Descriptor pools per command buffer pool (turned off)
Change 3838961 by Rolando.Caloca
DR - vk - Use ring buffer for per frame uniform buffers
- Enable descriptor pools per layout recycled per command buffer
Change 3839087 by Rolando.Caloca
DR - vk - Compile fixes for Android
Change 3839106 by Marcus.Wassmer
PR #4413: Removing unnecessary call to FString::ToLower (Contributed by gsfreema)
Change 3839252 by Mark.Satterthwaite
Fix mtlpp::Resource move operators.
Change 3839426 by Marcus.Wassmer
Duplicate 380972
Make PC GPU Benchmarks more reliable
Change 3840041 by Guillaume.Abadie
Fixes shader compilation failure in TAA with alpha channel through post processing support.
Change 3840257 by Chris.Bunner
Swapping a mul() to * in HLSLTranslator::Dot to allow scalar transformations per a UDN ticket.
Change 3840308 by Rolando.Caloca
DR - vk - Support for UB & non-UB on emulation mode
Change 3840586 by Rolando.Caloca
DR - Copy 3840577
Fix for CPUs with more than 16 cores
Change 3840671 by Rolando.Caloca
DR - vk - Copy from 3840663
Fix for layout ensure on HMD projects on Vulkan
Change 3840980 by Rolando.Caloca
DR - vk - Android compile fixes
Change 3841989 by Guillaume.Abadie
Slices Diaphragm DOF's Gather pass in multi shader files, and CFLAG_StandardOptimization flag for faster iteration time.
Change 3842216 by Guillaume.Abadie
Fixes DDOF's foreground alpha channel.
Change 3842217 by Guillaume.Abadie
Implements r.DOF.MaximalForegroundBlurringRadius
Change 3842353 by Guillaume.Abadie
Allows to disable foreground gathering with r.DOF.MaximalForegroundBlurringRadius=0
Change 3842747 by Rolando.Caloca
DR - vk - Missing use of GPoolSizeVRAMPercentage
- Support for smaller allocations if page size is not available
Change 3842791 by Rolando.Caloca
DR - vk - Use 95% of available GPU memory to handle some fragmentation
Change 3843690 by Guillaume.Abadie
Fixes diaphragm DOF's foreground after all this refactoring.
Change 3844439 by Guillaume.Abadie
Improves Coc dilate pass to make the gather pass as fast as possible, but still without artifacts caused by the fast gathering optimisation.
Change 3844946 by Mark.Satterthwaite
rd_route v1.1.1 with attached TPS approval.
For macOS function interposition which is useful for debugging and the occasional workaround.
Change 3845164 by Mark.Satterthwaite
Add LLM support for macOS, including tracking of memory allocated in Objective-C. This makes use of runtime method swizzling in the Objective-C runtime and the rd_route library I added for Richard Wallis, which allows for arbitrary runtime function interposition and allows me to hook the custom allocators used in Apple's many Objective-C frameworks on which the whole macOS edifice is built. Objective-C objects are charged to the calling scope as they are too common to impose their own without murdering frame rate.
We would need a TPS approval for an iOS function interposition library for this to work fully on iOS, if desired in the short term discarding LowLevelFree events that aren't in the map rather than asserting will workaround the problem.
Change 3845849 by Marcus.Wassmer
Fix clang and some normal refactor errors
Change 3846026 by Rolando.Caloca
DR - vk - Descriptor set allocation scheme rewrite
- Type hash for each pool
- Desc sets Pool on device
Change 3846169 by Rolando.Caloca
DR - vk - Remove old code for non-layout descriptor set pools
Change 3846205 by Mark.Satterthwaite
Disambiguate the PatchControlPointOut struct definitions in Metal tessellation shaders at Apple's suggestion to avoid a metallib gotcha.
Change 3846346 by Arne.Schober
DR - Missing Vector instructions
Change 3847037 by Arne.Schober
DR - Fix issue with GPU skincache where the offset of the clothbuffer is not relative to the offset of the actual vertexbuffer.
Fixed MorphTarget Skincache Offset mixxup
Change 3847275 by Marcus.Wassmer
Copying MGPU to Dev-Rendering (//UE4/Dev-Rendering)
Change 3847464 by Rolando.Caloca
DR - vk - Fix static analysis warning
Change 3847707 by Michael.Lentine
Only use MorphTargetOffset when the shader enables morph targets.
Change 3848533 by Richard.Wallis
Handle Metal adding FirstInstance into [[ instance_id ]] which is different to other APIs. SV_InstanceID and SV_VertexID should now have their respective base instance and base vertex ID's subtracted before use in the shader.
#jira UE-51716
Change 3848625 by Richard.Wallis
Compile Fix
Change 3848725 by Rolando.Caloca
DR - Remove use of Build/SetLocalGraphicsPipelineState
Change 3848797 by Rolando.Caloca
DR - Deprecate Build/SetLocalGraphicsPipelineState
Change 3849237 by Arne.Schober
DR - AddCustom Ver for ModelVertex Serialization
Change 3851247 by Rolando.Caloca
DR - vk - Util functions
Change 3851523 by Arne.Schober
DR - Update Reflection Comparission shot from the BuildFarm.
Change 3851859 by Rolando.Caloca
DR - vk - Skip loader
Change 3851889 by Krzysztof.Narkowicz
Removed lights with lighting channels out of tiled deferred light list. Tiled deferred lights do not support lighting channels and it's wasn't worth to add extra complexity to this shader in order support this special case.
#jira UE-51512
Change 3852181 by Rolando.Caloca
DR - vk - Linux compile fix
Change 3852547 by Uriel.Doyon
Fixed Pre-Exposure shader compilation and Temporal AA issue.
#jira UE-54276
Change 3852637 by Arne.Schober
DR - Fixing Normal Automated Test Result
Change 3853167 by Richard.Wallis
AvfPlayer - support for streaming media. Due to an operator new/delete mismatch in Apples CFNetwork - we've had to change out one of that framework allocators using rd_route to avoid the memory corruption.
#jira UE-35637
Change 3853447 by Chris.Bunner
Fixing typos.
Change 3853645 by Krzysztof.Narkowicz
Fixed light functions on subsurface materials
Removed strange code from blending between static and dynamic shadows
#jira UE-50275
Change 3853660 by Rolando.Caloca
DR - Fix OpenGL overwriting texture samplers on forward renderer
Change 3853945 by Mark.Satterthwaite
Duplicate #3831616
Fix the black ground scattering on Metal - we've had issues with the atmospheric fog calculations for a long time - one or more intermediate operations generates different precision on Metal so we end up passing -ve values into sqrt which then generates NaN/INF. For Metal when compiling this file and this file only #define sqrt() to sqrt(abs()) so that we don't see anymore unexpected black in atmospheric rendering. This is far from ideal but I don't want to make abs all inputs into every sqrt because AFAIK this is the only case where we have an issue, and until we to investigate each intermediate calculation that isn't ridiculously, soul-crushingly tedious, it isn't practical to identify the source of the error.
#jira UE-53720
Change 3853966 by Mark.Satterthwaite
Duplicate #3835852
Fix tessellation shaders in Metal with Manual Vertex Fetch enabled:
- The control points idnex buffer shouldn't collide with anything else.
- We can't use the optimisation of loading texture width & height from the buffer meta-table in tessellation shaders as the combined stages don't guarantee not to clobber unused buffer slots and screw it up when we use linear textures.
#jira UE-53851
Change 3854250 by Uriel.Doyon
Fix fbx automation tests
Change 3854736 by Uriel.Doyon
Added a tooltip to the EV100 slider in the exposure menu.
Using game settings now disables the slider.
#jira UE-53945
Change 3855047 by Jian.Ru
Fix DFAO getting NANs when samples out of ViewRect
#jira UE-54403
Change 3858197 by Krzysztof.Narkowicz
View frustum shadow caster culling for pointlights/spotlights
#jira UE-54381
Change 3860081 by Krzysztof.Narkowicz
Tighter bounding sphere for a spotlight
Replaced IntersectSphere(LightProxy->Origin, LightProxy->Radius) with LightProxy->SphereBounds for tighter culling of spotlights
Directional light GetBoundingSphere() now everywhere returns Sphere((0,0,0),HALF_WORLD_MAX) for consistency and proper SphereBounds
#jira UE-54258
Change 3860324 by Mark.Satterthwaite
Update the macOS deployment target version to 10.12 from 10.11 as we officially ended support for El Capitan a while ago. Should mean that libraries compiled for 10.12 and up won't cause link warnings.
Change 3860945 by Arne.Schober
DR - Fix not releaseing SRV on render thread for FPositionVertexBuffer, FStaticMeshVertexBuffer, FColorVertexBuffer, FStaticMeshInstanceBuffer.
#jira UE-54587
Change 3861129 by Jian.Ru
Prevent distance culled objects from casting distance field direct shadows
#jira UE-54533
Change 3861502 by Jian.Ru
Exclude distance culled objects from DFAO calculation
#jira UE-54533
Change 3862243 by Krzysztof.Narkowicz
Changed radius of a directional light's bounding sphere from HALF_WORLD_MAX to WORLD_MAX in order to encopass entire WORLD_MAX box
Change 3863476 by Krzysztof.Narkowicz
Added BuildReflections option to ResavePackages commandlet
#jira UE-54581
Change 3863717 by Rolando.Caloca
DR - vk - Missed using pipeline cache on compute PSOs
Change 3865332 by Arne.Schober
DR - Fix UE-52356 Bone Weight
Change 3866220 by Rolando.Caloca
DR - vk - Fixed GetNativeResource missing on textures
- Added support for -preferNvidia|AMD|Intel
- Added VulkanRHIBridge.h
- Minor fixes
Change 3866222 by Rolando.Caloca
DR - vk - Missed file
Change 3866951 by Krzysztof.Narkowicz
Fixed FreezeRendering on non editor builds: ComputeAndMarkRelevanceForViewParallel was calling FrozenMatricesGuard on multiple threads, reading and writing view matrices state in parallel.
#jira UE-53640
Change 3867231 by Guillaume.Abadie
Adds alpha mode to allow the tonemapper to passthrough the alpha channel for broadcast industry.
Change 3867233 by Guillaume.Abadie
Fixes a compilation failures in TAAU with r.PostProcessing.PropagateAlpha==2
Change 3867594 by Daniel.Wright
Removed EditorOnlyDefaultMaterials, which added 79s of shader compilation during startup
Added a dialog when opening the Material Editor on a Default Material, warning of advanced workflow
Preventing Material Editor Apply or Save for a Default Material when the preview material has compilation errors
Change 3870048 by Daniel.Wright
Cleaned up formatting in TranslucentRendering from merges
Change 3870106 by Krzysztof.Narkowicz
Fixed some FArchive Tell()/Seek() 64bit->32bit truncations
Change 3870211 by Rolando.Caloca
DR - vk - Added -vulkanvalidation=N/-vulkanstandardvalidation/-novulkanstandardvalidation to set validation layer behaviour from cmd line
Change 3870225 by Rolando.Caloca
DR - vk - Some platforms do not use a standard swapchain
Change 3870267 by Arne.Schober
DR - SafeRelease SRVs that might be hold by the Vertexfactories (maybe due to indirect use in GlobalResources)
Note that the VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should be uneccessary
Change 3870647 by Daniel.Wright
Moved FogRendering.h to Renderer
Change 3872130 by Krzysztof.Narkowicz
Disable USE_GLOBAL_CLIP_PLANE for MATERIAL_DOMAIN_POSTPROCESS and MERIAL_DOMAIN_UI
Merging GitHub Pull request #4459
"When material domain is not needing global clip plane there is no need to generate any code involving it. This does not alter output but removes lot of code at vertex shader and pixel shaders. At least on mobile rendered was actually generating clipping code for ui materials."
#jira UE-54616
Change 3872145 by Rolando.Caloca
DR - vk - Optional SupportsMarkersWithoutExtension
Change 3872404 by Uriel.Doyon
Added some guards when streaming virtual textures.
Fixed optimized UCanvasRenderTarget2D::RepaintCanvas() to prevent resolving the texture twice.
Fixed bad mipmap generation with UCanvasRenderTarget2D.
Change 3872507 by Arne.Schober
Back out changelist 3870267
Change 3874176 by Ben.Marsh
IncludeTool: Add an flag to prevent scanning source files for exported symbols.
Change 3874935 by Krzysztof.Narkowicz
Fixed white thumbnails and other issues with sky lighting on ES3_1 path, by disabling GGX prefiltering, as mobile path doesn't have a single cubemap with all initialized mips. Instead it ping-pongs between 2 partially initialized.
#jira UE-54656
Change 3875710 by Daniel.Wright
Renamed uniform buffer member macros to be much shorter for readability
Change 3876665 by Guillaume.Abadie
Cherry-pick 3870715: Implements DOF's hybrid scatering bare bones.
Change 3876666 by Guillaume.Abadie
Cherry-pick 3871786: DOF hybrid scatering: fixes NaN source, transition to gather on close to screen edge and low intensity.
Change 3876677 by Guillaume.Abadie
Cherry-pick 3872348: Implements neighbor comparison for DOF's scattering compilation pass.
Change 3876680 by Guillaume.Abadie
Cherry-pick 3872357: Oups... fixes build...
Change 3876683 by Guillaume.Abadie
Cherry-pick 3872475: Controls number of mip to generate with DOF's reduce pass.
Change 3876687 by Guillaume.Abadie
Cherry-pick 3874104: Fixes various bugs in diaphragm DOF's hybrid scattering.
Change 3876690 by Guillaume.Abadie
Cherry-pick 3874144: Packs multiple DOF scattering group into same draw instance.
Change 3876694 by Guillaume.Abadie
Cherry-pick 3874275: Switches hybrid scattering with indexed indirect draw call to reduce scatter vertex shader invocation.
Change 3876695 by Guillaume.Abadie
Cherry-pick 3874674: Records min and max coc on DOF's setup's draw event.
Change 3876783 by Rolando.Caloca
DR - Static analysis fix
Change 3876845 by Guillaume.Abadie
Implements USceneCaptureComponent::ProfilingEventName
Change 3877197 by Rolando.Caloca
DR - vk - OQ fixes (disabled)
Change 3877428 by Krzysztof.Narkowicz
Merged with tiny tweaks Ansel photography plugin improvements from Adam Moss (GitHub pull request #4426):
-The free-roaming photography camera has new constraints by default, i.e. it can't pass through walls
-Photography session can be started and stopped programmatically, e.g. making it possible to bind photography to an alternative hotkey or button combo. This was an often-requested feature.
-Tweakables and utilities are now exposed through a Blueprint Function Library (rather than direct manipulation of console variables)
-The Ansel photography session UI now exposes some engine effect tweakables as sliders. For example, if the game is using depth-of-field then sliders are made available to allow the photographer to change the focal depth etc. The developer may suppress this behavior through the Blueprint Function Library.
-Letterboxing is now removed during multi-part capture, d'oh.
-Tiled shots are taken at full resolution even if ScreenPercentage < 100
-SSR is enabled during super-resolution shots since Ansel is now better at hiding any ensuing artifacts
-Postprocess settings are frozen at session start to avoid discontinuities during photography, i.e. wandering between postprocess volumes when the camera auto-moves for stereo and 360 shots.
#jira UE-54244
#4426
Change 3879086 by Krzysztof.Narkowicz
Fixed sky/reflection capture (without owner) update - they are now updated only with a correspoding world
Change 3879090 by Guillaume.Abadie
Fixes tones of regressions on diaphragm DOF's recombine passes.
Change 3879198 by Rolando.Caloca
DR - vk - Support for real uniform buffers on Android platforms
Change 3879993 by Krzysztof.Narkowicz
-Fixed int64->int32 FArchive offset truncation in TShaderMap, VertexFactory and TextureDerivedData
-Fixed FSerializationHistory bug, when trying to serialize 0 bytes
#jira UE-43203
Change 3881462 by Guillaume.Abadie
Implements full res DOF's setup pass for cheaper full res gathering in recombine pass.
Change 3881524 by Krzysztof.Narkowicz
Fixed compilation by removing FTickableEditorObject from FPreviewScene
Change 3881724 by Chris.Bunner
Static analysis fix.
#jira UE-54762
Change 3881861 by Rolando.Caloca
DR - vk - Fix layout warning when generating mip chain
Change 3881864 by Rolando.Caloca
DR - Use render passes on HZB
Change 3882236 by Yuriy.ODonnell
IndirectLightingColorScale is now applied to SubsurfaceLighting and DiffuseLighting. Was previously only applied to DiffuseLighting.
#jira UE-42534
#github 3326
Change 3882325 by Guillaume.Abadie
Implements FocusOnly lower gathering pass for Diaphragm DOF's slight out focus temporal stability.
Change 3882340 by Rolando.Caloca
DR - vk - Fix api dump
Change 3882430 by Rolando.Caloca
DR - vk - KHR_maintenance2
Change 3882563 by Rolando.Caloca
DR - Add depth-stencil access mode to PSO initializer
Change 3882929 by Rolando.Caloca
DR - vk - Proper fix for maintenance extension macros
Change 3883087 by Mark.Satterthwaite
Allow disabling VSync in windowed mode for macOS 10.13.4+ and above.
Change 3883597 by Guillaume.Abadie
Collapses full and half res DOF setup passes together.
Change 3883702 by Guillaume.Abadie
Fixes mac's build.
Change 3884747 by Uriel.Doyon
Fix for static analysis warning
Change 3884975 by Rolando.Caloca
DR - vk - Move some platform defines to platform properties
Change 3884988 by Rolando.Caloca
DR - vk - Make an override per platform
Change 3885832 by Rolando.Caloca
DR - vk - Cosmetic change to group similar members
Change 3885891 by Rolando.Caloca
DR - vk - Some _RenderThread functions to avoid stalls
Change 3886044 by Rolando.Caloca
DR - Added RHI api _RenderThread version of
RHICreateTextureReference
RHICreateShaderLibrary
RHICreateRenderQuery
Change 3886560 by Guillaume.Abadie
Fixes strong aliasing on TAAU's fast shader permutation.
This adds a 6th neighbor sampling, and switch AA_TONE ON as TAA does for its fast shader permutation.
Change 3886749 by Guillaume.Abadie
Cherry-pick 3884748: Implements DOF's BuildBokehLUT for diaphragm blades simulation.
Only used in hybrid scattering for now.
Change 3886750 by Guillaume.Abadie
Cherry-pick 3885457: Simulates diaphragm blades' curvature on bokeh.
Change 3886752 by Rolando.Caloca
DR - Fix metal static analysis
Change 3887460 by Uriel.Doyon
Fixed to more static analysis warning.
Change 3888201 by Rolando.Caloca
DR - vk - Added r.Vulkan.SubmitAfterEveryEndRenderPass
- Fixed bad layout on rendering back buffer
Change 3888209 by Rolando.Caloca
DR - vk - Unity compile fix
Change 3888254 by Rolando.Caloca
DR - vk - Fix async texture layout
Change 3888893 by Guillaume.Abadie
Simulates bokeh in DOF's slight out of focus.
Change 3889085 by Guillaume.Abadie
Fixes DOF's reduce pass sampling outside viewport.
Change 3889924 by Rolando.Caloca
DR - vk - Skip seemingly bad validation error
Change 3890573 by Daniel.Wright
Only initialize FDiaphragmDOFGlobalResource in Feature Level 5
Change 3890590 by Arne.Schober
DR - Fix Paper2d crash. When addMesh is called the Vertex and Indexbuffers are nulled out. re-create Dynamic Mesh builder for every Mesh instead.
#jira UE-55063
Change 3890638 by Arne.Schober
DR - Better fix for Paper2d which honors batching
#jira UE-55063
Change 3891099 by Krzysztof.Narkowicz
1.5 texel shadow offset fix inside Manual2x2PCF based on #4485 GitHub pull request
#jira UE-54985
#4485
Change 3891234 by Krzysztof.Narkowicz
Optimized PCF2x2 and PCF3x3 - merged #4494 GithHub pull request
#jira UE-55121
Change 3891407 by Rolando.Caloca
DR - vk - Set vendor id earlier
Change 3891417 by Rolando.Caloca
DR - vk - Missing layout transitions
Change 3891718 by Arne.Schober
DR - Do not recreate one Frame Resource for dynamic draws
#jira UE-55063
Change 3891925 by Yuriy.ODonnell
Fix/workaround for inconsistent preprocessor definitions for NVAftermath that result in FD3D11DynamicRHI class layout mismatch. NVAftermath support is now enabled by default for Win64.
NVAftermath is declared as a private dependency in D3D11RHI. It does not automatically propagate to modules that explicitly include private RHI headers (OculusHMD, OSVR, OSVRInput). This results in NV_AFTERMATH being defined while compiling RHI module and not defined when compiling other modules, causing memory corruption at runtime.
The long-term solution for this and similar issues requires some mechanism for adding transitive module dependencies, so that anyone that depends on D3D11RHI module would automatically also get the NVAftermath. Additionally, private headers should *never* be included directly by external modules.
The short-term solution is to explicitly add NVAftermath dependency to OculusHMD, OSVR and OSVRInput.
Additionally, NV_AFTERMATH is no longer forced by D3D11RHIPrivate.h when it's not defined. This allows catching this kind of mismatch in the future through a compiler warning (C4668).
#jira UE-53065
Change 3891987 by Rolando.Caloca
DR - vk - Support for dedicated allocations
Change 3892339 by Jian.Ru
Fix a crash when tessellation shaders are used in dx12
#jira UE-55127
Change 3892528 by Rolando.Caloca
DR - vk - Update Linux headers
Change 3892867 by Rolando.Caloca
DR - vk - Don't create swapchain if not needed
Change 3893416 by Guillaume.Abadie
Implements bokeh simmulation on foreground and background gather.
Change 3893732 by Chris.Bunner
GetRelevance_Internal should use the immediate parent resource, not the base, as some features are overridden by permutations e.g. UsesWorldPositionOffset.
#jira UE-53404
Change 3893868 by Guillaume.Abadie
Allocates diaphragm DOF's buffers and structered buffer only on supported platforms.
Change 3893917 by Chris.Bunner
Potential fix for CIS.
Change 3893933 by Chris.Bunner
Duplicating CL 2647737 as this is the same issue from that JIRA where accessing game-thread data was being prevented. We don't have this check in UMaterial::GetMaterialResource already, but presumably the UMaterialInstance case was never removed as we've not been calling it until now.
Change 3894218 by Rolando.Caloca
DR - vk - Remove stat counters per draw call, gains 10% CPU on Infiltrator
Change 3894579 by Arne.Schober
RT - Fix assert not in RenderingThread from Triangle Renderer.
#jira UE-55247
Change 3894724 by Rolando.Caloca
DR - vk - New API for batching barriers
Change 3894909 by Arne.Schober
DR - Fix crash in Speedtree wind where Renderdata is unavailable
#jira UE-54544
Change 3895414 by Rolando.Caloca
DR - Add a configurable threshold for SCWs time outs
Change 3896429 by Marcus.Wassmer
Allow variable frame-latency delay in FrameGrabber frames. For performance you want at least a 1 frame delay so you don't sync the GPU to the CPU.
Change 3896495 by Marcus.Wassmer
Set pointer properly
Fix CIS
Change 3897253 by Guillaume.Abadie
Fixes CIS warning in diaphragm DOF
Change 3899179 by Guillaume.Abadie
Implements background hybrid scatter occlusion for diaphragm DOF.
Change 3903654 by Rolando.Caloca
DR - vk - Rework dump layer to allow other layers
Change 3903766 by Rolando.Caloca
DR - vk - More wrappers
Change 3904025 by Rolando.Caloca
DR - vk - More wrappers
Change 3904342 by Rolando.Caloca
DR - vk - Track image resources & callstacks
Change 3904346 by Rolando.Caloca
DR - vk - Copy fix from 4.19 for flickering grass
Change 3904510 by Rolando.Caloca
DR - vk - Compile fix
Change 3904914 by Daniel.Wright
[Integrate] Fixed PS4 transitions with forward shading
Change 3904916 by Daniel.Wright
[Integrate] Fixed PS4 transitions with occlusion queries
Change 3905975 by Rolando.Caloca
DR - vk - Missing wrappers
Change 3905977 by Rolando.Caloca
DR - vk - Missed file
Change 3907829 by Rolando.Caloca
DR - Move depth bounds to the PSO
Change 3907832 by Rolando.Caloca
DR - vk - Prep for delaying transitions
Change 3907834 by Rolando.Caloca
DR - vk - Fix for depth stencil issues/validation errors
Change 3907967 by Rolando.Caloca
DR - vk - Linux compile
Change 3908093 by Rolando.Caloca
DR - vk - Fix depthstencil layout on descriptors
Change 3908393 by Rolando.Caloca
DR - vk - Disable dedicated allocation as it causes crashes on Nvidia 700 series
Change 3908401 by Rolando.Caloca
DR - Do transitions outside render pass
Change 3908422 by Rolando.Caloca
DR - vk - Fix transition state not getting stored
Change 3908735 by Guillaume.Abadie
Cherry-pick 3896619: Fixes after TAAU post process material that had wrong default buffer UV.
#jira UE-55317
Change 3908736 by Guillaume.Abadie
Cherry-pick 3891352: Fixes ensure when visualizing HDR with TAAU.
#jira UE-55019
Change 3908753 by Guillaume.Abadie
Lets the renderer layout the views in the internal render targets like it prefers.
Change 3909119 by Daniel.Wright
Fix some static analysis warnings
Change 3911943 by Rolando.Caloca
DR - vk - Fix for packaging Vulkan projects
Change 3912145 by Rolando.Caloca
DR - vk - Fix layout on streaming textures
Change 3913029 by Rolando.Caloca
DR - Fix missing transition
Change 3913048 by Rolando.Caloca
DR - Fix for hlslcc
Change 3913054 by Rolando.Caloca
DR - vk - Fix number of layers on barrier
Change 3913171 by Rolando.Caloca
DR - vk - Fix for decal missing transition
Change 3913211 by Rolando.Caloca
DR - vk - Add debug name to image tracking
Change 3913449 by Rolando.Caloca
DR - vk - Restore transition
Change 3913466 by Rolando.Caloca
DR - Fix Vulkan EngineTest
Change 3913537 by Rolando.Caloca
DR - vk - Fixes independent samplers & textures (contributed by AMD)
Change 3913548 by Rolando.Caloca
DR - vk - Warning fix
Change 3913691 by Rolando.Caloca
DR - vk - Fixes for parallel (wip)
Change 3914656 by Rolando.Caloca
DR - vk - Fix bug when using separate samplerstates and textures
Change 3914730 by Rolando.Caloca
DR - vk - Bump version
Change 3914764 by Rolando.Caloca
DR - vk - Don't crash on exit
Change 3915532 by Rolando.Caloca
DR - vk - Parallel context fixes
Change 3915589 by Rolando.Caloca
DR - vk - Hoist and rename transition and layout manager class out of the context
Change 3915592 by Rolando.Caloca
DR - Fix gpu marker name
Change 3917607 by Rolando.Caloca
DR - vk - Fix depth bounds on Vulkan
Change 3917609 by Rolando.Caloca
DR - vk - Fix static analysis
Change 3917616 by Rolando.Caloca
DR - Fix D3D11 initialization
Change 3920569 by Rolando.Caloca
DR - vk - Prep for layout mgr refactor
Change 3921023 by Rolando.Caloca
DR - vk - Dump layer fixes
Change 3921623 by Rolando.Caloca
DR - vk - Prep refactor for layouts
- Dump now shows marker tree
Change 3922007 by Rolando.Caloca
DR - vk - Fix extra allocation per draw call
Change 3922442 by Rolando.Caloca
DR - vk - Detect potential issues
Change 3922470 by Rolando.Caloca
DR - vk - Minor optimization
Change 3922482 by Rolando.Caloca
DR - vk - More minor optimizations
Change 3923158 by Rolando.Caloca
DR - Move r.DisableEngineAndAppRegistration out to common RHI and use it on Vulkan
Change 3923486 by Rolando.Caloca
DR - vk - Minor cpu optimizations
Change 3923505 by Rolando.Caloca
DR - vk - Use bigger allocations for uniform buffers
Change 3923516 by Rolando.Caloca
DR - vk - Android compile fix
Change 3923557 by Rolando.Caloca
DR - vk - Cache descriptorset layouts, refactor duplicated code
Change 3923851 by Rolando.Caloca
DR - vk - Linux compile fix
Change 3924153 by Rolando.Caloca
DR - vk - Support for dynamic UBs
Change 3924193 by Rolando.Caloca
DR - vk - Remove old per pso descriptor pools
Change 3924197 by Rolando.Caloca
DR - vk - Remove unused global uniform buffer pool
Change 3924220 by Rolando.Caloca
DR - vk - Wrap some unused classes in their define
Change 3924234 by Rolando.Caloca
DR - vk - Show ring buffer wrapping messages
Change 3924243 by Rolando.Caloca
DR - vk - Fix bad dynamic buffer
Change 3924902 by Rolando.Caloca
DR - vk - Fix crash running infiltrator
Change 3925209 by Rolando.Caloca
DR - vk - Fix bug with dynamic buffers
- Remove old defines
Change 3925300 by Rolando.Caloca
DR - vk - Allow packed uniforms as dynamic UBs (with r.Vulkan.DynamicGlobalUBs)
Change 3925627 by Rolando.Caloca
DR - vk - Move DynamicOffsets into the pipeline state
Change 3925834 by Rolando.Caloca
DR - vk - Cache per stage information
Change 3925835 by Daniel.Wright
Fixed DisplayName for UParticleModuleCollisionGPU
Change 3925897 by Rolando.Caloca
DR - vk - Split update descriptors loop
Change 3926488 by Rolando.Caloca
DR - vk - 16MB for ring buffer on desktop, 8 MB for mobile
Change 3928168 by Guillaume.Abadie
Cherry-pick 3917219: Implements r.DOF.RecombineQuality
Change 3928173 by Guillaume.Abadie
Cherry-pick 3927888: Enables r.DOF.HybridScatter.BackgroundCompositing and r.DOF.HybridScatter.ForegroundCompositing to work when both enabled.
Change 3928216 by Rolando.Caloca
DR - vk - Fix Android
- Fix static analysis
Change 3929119 by Rolando.Caloca
DR - vk - Rename some classes for clarity
- Fix read-only cvar
Change 3929151 by Rolando.Caloca
DR - vk - Rename class
Change 3930046 by Rolando.Caloca
DR - Temp fix Vulkan flickering grass
Change 3930148 by Rolando.Caloca
DR - vk - Only update dirty descriptors
- Use dynamic descriptors for packed global uniform buffers
Change 3930998 by Guillaume.Abadie
Packs shader permutation in different XGE submissions.
Change 3931079 by Rolando.Caloca
DR - vk - Fixes for Android and non-real ubs platforms
Change 3931942 by Krzysztof.Narkowicz
Depth rendering - When EarlyZPassMode is set to DDM_AllOccluders, dynamic objects need also to test bUseAsOccluder just like static ones
#jira none
Change 3932819 by Daniel.Wright
[Integrate] Scene Textures uniform buffer
* Base Pass Uniform Buffer now contains a Scene Textures uniform buffer. Previously the translucent base pass had to check ~40 loose scene texture parameters every draw.
* FMeshMaterialShader's must now bind PassUniformBuffer and supply a valid pass uniform buffer. For most passes this is just FSceneTextureUniformParameters.
* FRendererModule::DrawTileMesh can now cleanly set dummy scene texture resources, just by configuring how the pass uniform buffer is created.
* Moved scene texture shader functions out of Common, into SceneTexturesCommon which must be manually included by shaders that want to use them
* Separate Mobile Scene Textures uniform buffer to silo the platform complexities
Moved DBuffer inputs out of FDeferredPixelShaderParameters and into FOpaqueBasePassUniformParameters
Removed per-frame material uniform expressions. GameTime material node with period is now implemented with an fmod in the shader, without the use of MaterialFloat, so that it will happen at full precision.
* Per-frame expressions were used when the GameTime material node had a period, to do the fmod on the CPU where 32 bit precision is guaranteed, for mobile GPU's where pixel shader precision is sometimes less than 32fp.
Moved forward shading data into the Base Pass Uniform Buffer
Removed instanced stereo support for the light cull grid - will have to be reimplemented without changing SRV's per draw
Base pass sets View Uniform Buffer from DrawRenderState instead of choosing which one to set per-draw
Fixed padding in nested uniform buffer structs
Skip SRV members on Feature Level SM4 and below
Change 3932964 by Rolando.Caloca
DR - vk - Renderdoc on Android
Change 3933095 by Daniel.Wright
Moved FSceneTextureUniformParameters out of the opaque base pass uniform buffer.
* Base Pass shaders now enable SCENE_TEXTURES_DISABLED when compiling for a material of any domain other than MD_Surface. These are used when rendering thumbnails of a material in a different domain, which could be opaque, but the opaque base pass drawing policy does not bind a scene textures uniform buffer, so the shader must not bind it.
* Opaque materials can no longer use EyeAdaptation.
Change 3933096 by Daniel.Wright
Better d3d11 assert message when a uniform buffer was not set by the renderer
Change 3933176 by Rolando.Caloca
DR - vk - Prefer mailbox if available
Change 3933271 by Ryan.Vance
#jira UE-55936
Fixed missing referenced uniform bindings on AR pass-through camera shaders.
Change 3934000 by Guillaume.Abadie
Fixes Win32 build in ShaderCompilerXGE.cpp
Change 3934299 by Guillaume.Abadie
Fixes a bug in DOF's reduce operator that was casusing color leaking between background and foreground.
Change 3934699 by Daniel.Wright
Added bAffectDistanceFieldLighting to landscape
Change 3935190 by Daniel.Wright
Forward Light Grid SRV's use StructuredBuffer on Metal, instead of 'invariant Buffer', which throws off RemoveUniformBuffersFromSource parsing
Change 3935606 by Daniel.Wright
Removed LightmapPolicy::Set which was needed for vertex lightmaps
Renamed FVertexFactory::Set to SetStreams to make it findable
Change 3936510 by Rolando.Caloca
DR - vk - Update glslangValidator.exe to 1.0.65.1 for dumped debug SPIRV shaders
Change 3936545 by Richard.Wallis
Clone of CL's (3925763, 3925430, 3925424, 3925385, 3925278) Mark Satt's Xcode fixes from task stream //Tasks/UE4/Dev-UERNDR-354-mtlpp/
Plus XCode 9.2 compile fix in ApplicationPlatformCompilerPreSetup.h for -Wunused-lambda-capture.
Change 3938061 by Daniel.Wright
Vulkan: Added support for SRV's in Uniform Buffers
Change 3938123 by Daniel.Wright
Vulkan: Slightly better assert for null resources in uniform buffer
Change 3939197 by Rolando.Caloca
DR - vk - Disable custom memory mgmt
Change 3939677 by Rolando.Caloca
DR - vk - Fix static analysis warning
Change 3939809 by Rolando.Caloca
DR - vk - Fixes for async compute
Change 3939875 by Rolando.Caloca
DR - vk - Support for -vktrace
Change 3939977 by Rolando.Caloca
DR - vk - Skip a condition during gather UBs
- Set up efficient compute async var
- Fix validation cmd line
Change 3939982 by Rolando.Caloca
DR - vk - Revert mipchain
Change 3939984 by Rolando.Caloca
DR - vk - Remove unnecessary asserts
Change 3940082 by Rolando.Caloca
DR - vk - Custom mem mgr
Change 3940475 by Rolando.Caloca
DR - vk - Fix DFAO (indirect draw offset)
Change 3940555 by Rolando.Caloca
DR - vk - Minor fixes
Change 3940675 by Rolando.Caloca
DR - vk - Fix indirect type mismatch
Change 3941111 by Rolando.Caloca
DR - Renderpass bGeneratingMips
Change 3941847 by Daniel.Wright
Fixed Volumetric Lightmaps on Static geometry only working if the geometry had been built with Surface Lightmaps before
Change 3941978 by Rolando.Caloca
DR - vk - Minor fixes for presenting on compute queue
Change 3942074 by Rolando.Caloca
DR - vk - Remove some RHI stalls
- Fixed swap chain stat
Change 3943946 by Daniel.Wright
Fixed Texcoord0 on Volume materials on a particle sprite, including SubUV particles.
Change 3944065 by Daniel.Wright
Fixed SceneDepth collision getting broken on GPU particles when a scene capture is rendering
Change 3944158 by Daniel.Wright
Fixed ViewUniformShaderParameters accessing GEngine->PreIntegratedSkinBRDFTexture too early during slate loading screen
Change 3944865 by Rolando.Caloca
DR - vk - Prep for render passes
Change 3945196 by Rolando.Caloca
DR - Move render pass validate to cpp
Change 3945202 by Rolando.Caloca
DR - vk - Some fixes for using real render passes
Change 3945357 by Rolando.Caloca
DR - Fix bad condition
Change 3946295 by Yuriy.ODonnell
Added a sentinel member to FLightMap, which is initialized in the ctor and reset in the dtor. Sentinel is then checked in FLightCacheInterface::GetLightMapInteraction().
This aims to shed some more light on a hard-to-repro crash, which is suspected to be a use-after-free bug: http://crashreporter/Buggs/Show/1785593
Change 3946407 by Rolando.Caloca
DR - vk - Prep for refactor
Change 3946648 by Rolando.Caloca
DR - vk - Fixes for async compute (wip)
Change 3947299 by Rolando.Caloca
DR - vk - FIx static analysis
Change 3948434 by Rolando.Caloca
DR - vk - Fix exiting with parallel
Change 3948928 by Rolando.Caloca
DR - vk - Fix enabling draw markers for tools
Change 3949021 by Rolando.Caloca
DR - vk - Buffer tracking layer
Change 3949602 by Rolando.Caloca
DR - vk - static analysis fix
Change 3949757 by Rolando.Caloca
DR - vk - Remove bogus parameter
Change 3949810 by Rolando.Caloca
DR - vk - Move waits for cmd buffer
Change 3950270 by Guillaume.Abadie
Implements dedicated gather pass for foreground hole filling to avoid being VGPR bound in foreground gather pass, but still being hable to amend foreground.
Change 3950272 by Rolando.Caloca
DR - vk - Minor refactor for semaphores
Change 3950279 by Guillaume.Abadie
Oups... fixes build
Change 3950298 by Rolando.Caloca
DR - vk - Gather wait semaphores in the cmd buffers
Change 3950371 by Rolando.Caloca
DR - vk - fixes for async compute
Change 3950597 by Rolando.Caloca
DR - vk - Fix for clip distance (fixes planar reflections)
Change 3951075 by Rolando.Caloca
DR - vk - Fix for async compute
Change 3952524 by Guillaume.Abadie
Some DOF enum refactoring.
Change 3955016 by Daniel.Wright
Fixed BuiltData package getting renamed into the map package during a content browser folder move, causing a redirector to be incorrectly placed in the map package
Change 3955668 by Guillaume.Abadie
Fixes a bug where full res coc buffer was computed even if not doing slight out of focus.
Change 3956722 by Guillaume.Abadie
Fixes a bug where r.DOF.MaximalForegroundBlurringRadius was screen percentage dependent.
Change 3959212 by Guillaume.Abadie
Prefixes all DOF's shaders files with DOF keyword.
Change 3959705 by Guillaume.Abadie
Optimises the DOF setup pass outputing half res and full res with LDS downsample.
Change 3959941 by Guillaume.Abadie
Halfs DOF's hybrid scatter compilation by using a unique downsampling for both foreground and background, instead of 2 reduce passes.
Change 3962273 by Rolando.Caloca
DR - Fix typos
#jira UE-56317
PR #4586
Change 3962615 by Rolando.Caloca
DR - vk - Compile fix
Change 3962949 by Rolando.Caloca
DR - Fix DOFDownsample extension
Change 3962993 by Guillaume.Abadie
Back out changelist 3962949
Change 3963016 by Guillaume.Abadie
Adds missing DOFDownsample.usf
Change 3963041 by Rolando.Caloca
DR - vk - Misc changes to help integrate
Change 3964293 by Guillaume.Abadie
Fixes DOF's setup pass reading outside of the viewport.
Change 3964475 by Guillaume.Abadie
Collapses DOF's hybrid scatter compilation passes into reduce passes.
Change 3964883 by Daniel.Wright
Fixed 3d texture in uniform buffer on unsupporting RHI
Change 3964897 by Rolando.Caloca
DR - Compile fixes
Change 3964914 by Guillaume.Abadie
Fixes a bug on r.DOF.RecombineQuality=0
Change 3965153 by Guillaume.Abadie
Fixes compile warning in D3D12Commands.cpp.
Change 3965814 by Rolando.Caloca
DR - Prep for integration conflict resolve
Change 3965899 by Rolando.Caloca
DR - Fix odd linkage issue
Change 3966072 by Rolando.Caloca
DR - More prep for merge
Change 3966163 by Rolando.Caloca
DR - Merge prep
Change 3966844 by Guillaume.Abadie
Packs multiple DOF scattered bokeh per instance and uses PT_RectList in DOF for platforms that can.
Change 3967116 by Rolando.Caloca
DR - Compile fixes for integration
Change 3967273 by Rolando.Caloca
DR - Use same path for mip generation
Change 3967277 by Rolando.Caloca
DR - vk - Fix mips on cubemaps
Change 3967693 by Rolando.Caloca
DR - Copying //UE4/Dev-Main@3912313 to //UE4-DevRendering, missing shaders
Change 3967851 by Rolando.Caloca
DR - Copying //UE4/Dev-Main@3912313 to //UE4-DevRendering, Engine 2/2
Change 3968083 by Rolando.Caloca
DR - Integration compile fixes
Change 3968240 by Rolando.Caloca
DR - Shader compile fixes for integration
Change 3968270 by Rolando.Caloca
DR - Fix for missing hash calculation
Change 3969426 by Rolando.Caloca
DR - vk - Fix warning
Change 3969869 by Krzysztof.Narkowicz
Back out changelist 3946295 - UE-54537 is fixed, so no need for this debug sentinel.
#jira none
Change 3969944 by Rolando.Caloca
DR - Warning fix
Change 3970020 by Rolando.Caloca
DR - Bump after integration
Change 3970052 by Rolando.Caloca
DR - Fix for mobile
Change 3970236 by Daniel.Wright
Causing decal shader to recompile to fix a merge bug
Change 3970270 by Daniel.Wright
Bump shader version from merge
Change 3970339 by Olaf.Piesche
Replace series of locks/unlocks with a single one for curve injection
#tests QAGame
Change 3970390 by Rolando.Caloca
DR - Rename FSceneTextureUniformParameters to FSceneTexturesUniformParameters
- Remove duplicate method for occlusion queries
Change 3970523 by Rolando.Caloca
DR - Fix serialization of shaders
Change 3970533 by Arne.Schober
DR - fix for removing the Speed tree wind when the scene gets deleted. The original enque rendercommand requeues the element onto the renderthread although the call already came from the Renderthread and the scene can get lost in between.
#jira UE-56322
Change 3971160 by Guillaume.Abadie
Fixes CompositeEditorPrimtive pass and SelectionOutline pass for VR editor to work with TAAU.
Change 3971516 by Guillaume.Abadie
Cherry-pick 3912629: Fixes SSR that was computing vigneting according to PrevScreen that could let some outside viewport samples going through when rotating the camera.
#jira UE-55353
Change 3971594 by Krzysztof.Narkowicz
Fixed assert inside BindLightMapVertexBuffer. FSplineMeshSceneProxy was calling BindLightMapVertexBuffer for invalid (still not generated) lightmap UV channel after mesh reimport. Simplified assert, as at the moment almost all of the high callsites already clamp lightmap uv channel.
#jira UE-56321
Change 3971622 by Krzysztof.Narkowicz
Fixed crash inside Indirect Lighting Cache. Data (reflection captures and lightmap) generation calls ULevel::GetOrCreateMapBuildData(), which can destroy lightmap data if level has legacy data. Last Lightmap generation step recreates this data, but if user cancels lightmap generation - it won't do that.
#jira UE-56171
Change 3974788 by Rolando.Caloca
DR - Remove GSupportsGenerateMips
Change 3974789 by Rolando.Caloca
DR - Remove bogus function
Change 3974986 by Rolando.Caloca
DR - vk - Tracking fixes
Change 3974989 by Rolando.Caloca
DR - vk - Don't submit dummy barriers
Change 3975075 by Olaf.Piesche
Update for particle curve injection improvement, fixing ES2 problems
#tests QAGame tm-shadermodels, various color curve tests in-editor
Change 3975957 by Uriel.Doyon
Fixed invalid max texture resolution when using the bake material tools.
Change 3978471 by Daniel.Wright
New cvar r.SkylightUpdateEveryFrame
Change 3978779 by Rolando.Caloca
DR - Accessor for texture sizes
Change 3978797 by Rolando.Caloca
DR - Clean up RHI CopyTexture API
Change 3978832 by Rolando.Caloca
DR - vk - Workaround for RenderDoc crashing due to Descriptor Pool reset
Change 3978836 by Rolando.Caloca
DR - vk - Remove generate mips
Change 3979201 by Rolando.Caloca
DR - vk - RHI CopyTexture. Uses general layout for generating mips
Change 3979204 by Rolando.Caloca
DR - Use render passes and CopyTexture to generate mips
Change 3979592 by Rolando.Caloca
DR - Warning fix
Change 3980855 by Krzysztof.Narkowicz
Optimize bounding sphere radius after non-uniform scale by using bounding box extent.
#jira UE-56227
Change 3981065 by Rolando.Caloca
DR - vk - Fix bad layout
#jira UE-56238
Change 3981346 by Rolando.Caloca
DR - Copy from 3707257
Support for not flushing compute jobs (r.D3D11.UAVFlushNV)
Change 3981347 by Rolando.Caloca
DR - Copy from 3707257
Don't flush between morph dispatched
Change 3981932 by Mark.Satterthwaite
Generate the shader hash and function name when a Metal shader error needs to be reported so that even without shader code we get something to go on.
Change 3982442 by Rolando.Caloca
DR - Fix warning
Change 3982652 by Rolando.Caloca
DR - vk - Signal semaphore cleanup
Change 3983917 by Richard.Wallis
Clone of CL 3974146 converted for mtlpp along with extra mtlpp usage suggestions by Mark Satt:
Fix for black flickering on first paint with weighted material landscape on Mac. When using AsyncCopyFromBufferToTexture in Metal we put the blit operation on the prologue encoder - however after a draw call using that resource the copy operation should happen after on the current encoder, this keeps the correct order of operations.
Added Bool return from various Asnyc renderpass resource requests so caller can decide correct further action. Updated to include the other async functions.
Change 3984409 by Guillaume.Abadie
Attempts to make static analysis happy again.
Change 3984435 by Nick.Bullard
Checking in Performance Test level provided to us by Tor Frick based on UE-44841.
This has been utilized for checking issues against Aftermath performance impact.
The Map includes 2 Level Book marks, most testing has been done against Bookmark 1 view, in fullscreen, in game mode
Change 3985087 by Mark.Satterthwaite
Make sure that the particle scratch buffer is large enough to hold all the data for the curve texture we are rendering to, otherwise a full set of curves will start scribbling memory after 64Kb (the curve texture is 256Kb of data - 512x512x4 as sizeof(RGBAUInt8) == 4). This happens in ElementalDemo.
Change 3985201 by Rolando.Caloca
DR - Fix bad CopyTexture
Change 3985258 by Mark.Satterthwaite
Try and detect orientation changes so that we don't blow-up on iOS due to a huge mismatch between the drawable texture for the display and the scene's depth-stencil target. I can't just fiddle with the depth-stencil texture itself without running the risk of obliterating in-use data and really we shouldn't permit such a mismatch anyway but it is fallout from 3620990.
#jira UE-55756
Change 3986449 by Rolando.Caloca
DR - vk - Update & consolidate Vulkan headers to 1.1.70.1
Consolidate SDK into one
Change 3986571 by Guillaume.Abadie
Makes PVS-Studio happy again in DOF.
Change 3987039 by Yuriy.ODonnell
Initial implementation of tracing profiler to show CPU and multiple GPUs on the same timeline. Currently only supported on DX12 platforms.
Use `TracingProfiler frames=N` console command to trigger a capture of the next N frames. Trace is saved to disk as a JSON file into `Saved/Profiling/Traces` directory.
Trace file uses Google Tracing format and can be visualized in Chrome built-in profiler (chrome://tracing).
`r.GPUStatsChildTimesIncluded=1` CVar makes timing scopes hierarchical.
`TracingProfiler.BufferSize=N` CVar controls the size of the tracing buffer, which may need to be increased for long traces (default is 65k events). Only can be set at startup.
Change 3987074 by Yuriy.ODonnell
Implemented timestamp calibration on DX11. Calibration is only performed when tracing profiler session starts.
Change 3987160 by Yuriy.ODonnell
Added thread naming and ordering to the tracing profiler output
Change 3987331 by Mark.Satterthwaite
Remove the Nvidia hack to retain resource references in command-buffers for UE-46604 as the mtlpp refactor provides stronger resource lifetime guarantees.
#jira UE-46604
Change 3987754 by Mark.Satterthwaite
Fix MetalRHI memory reporting in non-default path.
PR #4568
Change 3988184 by Arciel.Rekman
Linux: Fix editor OpenGL performance (UE-55960).
- GetCurrentThreadId() calls became much more frequent with the OpenGL RHIT refactor.
- We used to only cache that value in monolithic builds, because having per-thread static variables in dynamic libraries is risky due to OS limits.
- This change adds dynamically-managed per-thread cache for non-monolithic builds.
#jira UE-55960
Change 3988394 by Rolando.Caloca
DR - vk - Improve memory mgmt
- Use 256MB pages for Device heap (or 1/8th if less).
- Remove texture allocations not going through resource manager
Change 3988405 by Marcin.Undak
Fix VulkanQuery crash on exit #codereview rolando.caloca #codereview arciel.rekman #rb arciel.rekman
Change 3988567 by Rolando.Caloca
DR - vk - Support for packed global UBs on pci aperture heap
Change 3988668 by Rolando.Caloca
DR - vk - Remove old comments
Change 3988956 by Marcin.Undak
RecordPerformance: added option to skip building/cooking before tests #rb none #codereview arciel.rekman
Change 3989161 by Yuriy.ODonnell
Static analysis error fix
Change 3989196 by Guillaume.Abadie
Fixes a crash in light shaft's TAA pass.
#jira UE-57366
Change 3989207 by Yuriy.ODonnell
Refactored FRealtimeGPUProfilerFrame to avoid splitting profile events when calculating exclusive times of scopes. This allows tracing profiler to retain the hierarchical view of the data, while keeping CSV and GPU Stat system behavior intact.
Change 3989469 by Rolando.Caloca
DR - vk - Fix for bad index; fix for bad transition
Change 3989772 by Yuriy.ODonnell
Implemented timestamp calibration on Vulkan
Change 3990040 by Marcus.Wassmer
Aftermath enabled by default.
Removed unnecessary warning for other vendors
Change 3990064 by Mark.Satterthwaite
Ensure that packed globals are reuploaded when the command-encoder is restarted - don't simply invalidate the existing parameters. This properly handles cases where a single logical render-pass is broken into multiple command-encoders and/or command-buffers - otherwise all shaders must reset all parameters each time. When we move between frames we *do* want to perform a full state reset though as previous frame globals are treated as invalid.
Change 3990080 by Mark.Satterthwaite
Change the way we invalidate the visibility buffer between command-buffers and command-encoders so that on iOS you can reuse the same buffer within the same command-buffer, but not across more than one. The code provides an exception to this rule when running under the MetalRHI validation tools which can break each draw call into its own buffer.
Change 3990084 by Mark.Satterthwaite
Get MetalStatistics compiling again.
Change 3990381 by Arciel.Rekman
Bring back D3D12 in RecordPerformance.
Change 3991113 by Rolando.Caloca
DR - Fix crash on RHI thread on mobile preview
- Check RHI objects are not null in the PSO initializer
Change 3991191 by Ryan.Vance
#jira UE-55952
Reimplemented instanced stereo for forward lighting cull grid after the srv/ub clean up.
Change 3991343 by Rolando.Caloca
DR - Copy from 3911492
UE4 - Disabled parallel mobile bass pass by default. This is experiemental and not known to be useful on any mobile platform.
Change 3991375 by Mark.Satterthwaite
Proper copyright assignment in the mtlpp debugger header.
Change 3993151 by Daniel.Wright
Fix RTDF resource transition found by Rolando
Change 3993818 by Rolando.Caloca
DR - Missed file
Change 3993923 by Krzysztof.Narkowicz
Fixed crashes inside RemoveSpeedTreeWind() and RemoveSpeedTreeWind_RenderThread().
FStaticMeshComponentRecreateRenderStateContext didn't flush deferred render updates causing stale RenderData to be left:
1. Thumbnail manager called SetStaticMesh(nullptr), which added StaticMeshComponent to deferred render updates.
2. UStaticMesh::Build called FStaticMeshComponentRecreateRenderStateContext and destroyed DenderData, but didn't touch Thumbnail's manager StaticMeshComponent as it was nullptr.
3. This resulted in a StaticMeshComponent with stale RenderData pointer.
#jira UE-54544
Change 3994033 by Rolando.Caloca
DR - vk - Reworked layers & extensions, as we were not doing it properly
- Remove -vulkanstandardvalidation and -novulkanstandardvalidation as they are not needed anymore
Change 3994275 by Mark.Satterthwaite
Change to linking against mtlpp via AddEngineThirdPartyPrivateStaticDependencies and marking its header with THIRD_PARTY_* macros in the vain hope that might convince the remote compilation code to distribute the module to the remote machine when building MetalRHI.
#jira UE-57507
Change 3994365 by Mark.Satterthwaite
Pilfer some code from the old MetalHeap file to handle calculating texture memory size on older macOS and iOS builds when running with stats or LLM enabled.
#jira UE-57513
Change 3994382 by Rolando.Caloca
DR - vk - Some missing locks during image tracking
Change 3994422 by Rolando.Caloca
DR - vk - Remove bogus shader format
Change 3995530 by Rolando.Caloca
DR - vk - Fix for crash when validation is enabled
Change 3995531 by Rolando.Caloca
DR - vk - Fix static analysis
Change 3995532 by Rolando.Caloca
DR - vk - Added support for r.Vulkan.SaveValidationCache
Change 3995610 by Uriel.Doyon
Texture Streaming Changes and Fixes:
- Using the small FOV items (like scopes) now only affect visible primitives (through "r.Streaming.MaxHiddenPrimitiveViewBoost").
- Static components added after the level is registered in the streaming manager are now handled correctly (fixes the low quality on the chests)
- Dynamic components do not need to register to the streaming manager anymore.
- Optimized dynamic component management by removing duplicate entries in the update list.
- Added a pregarbage collect pass to the dynamic component management to optimize GC handling.
- Added a budget reset logic whenever the scene requirements change significantly.
- PIE worlds now have correct visibility information.
- Fixed possible invalid memory access when processing the streaming manager slave views.
- Refactored the incremental level texture data build to prevent new components from being unhandled.
- Removed StreamingManager callbacks for NotifyActorSpawned() and NotifyPrimitiveAttached()
- Added a StreamingManager callback NotifyPrimitiveUpdated(), to be used whenever a primitive streaming state must be updated.
#jira none
Change 3995908 by Arciel.Rekman
Fix compile errors when using new Vulkan queries.
Change 3995990 by Arciel.Rekman
More compile fixes to new Vulkan queries.
- MSVC did not catch this, clang did.
Change 3996101 by Rolando.Caloca
DR - vk - Win32 compile fix
Change 3996323 by Mark.Satterthwaite
Use the right include path to export the mtlpp headers.
#jira UE-57507
Change 3996392 by Arciel.Rekman
Vulkan: fix crash on start when using new queries.
- CommandBufferManager was not yet set at that point and the code in queries relied on it.
Change 3996585 by Rolando.Caloca
DR - Slight improvement to GL being black, but just a temporary 'workaround' as it's not correct.
Change 3998806 by Arciel.Rekman
Fix Linux build (UE-57602).
#jira UE-57602
Change 3998866 by Arciel.Rekman
SubwaySequencer: fix old shader platform name.
Change 3998947 by Mark.Satterthwaite
Silence deprecation warnings in CEF on macOS now that we've moved to 10.12 as the minimum.
#jira UE-57577
Change 3998951 by Mark.Satterthwaite
Fix last of the deprecation errors that I am aware of for macOS 10.12.
#jira UE-57581
Change 3998984 by Mark.Satterthwaite
Build mtlpp for iOS 9.0 not 9.3.
#jira UE-57586
Change 3999065 by Rolando.Caloca
DR - vk - Make sure we use version 1.0.0
#jira UE-57521
Change 3999071 by Arne.Schober
DR - [UE-55433, UE-57361] Hack SNORM support in OpenGL by re-interpreting UNORM. Underlying data is always SNORM.
#jira UE-55433, UE-57361
Change 3999494 by Rolando.Caloca
DR - Enable r.UnbindResourcesBetweenDrawsInDX11 in debug
- Clear compute resources when r.UnbindResourcesBetweenDrawsInDX11 is enabled
Change 4000197 by Krzysztof.Narkowicz
Mesh simplifier - normalize TexCoordWeights using min/max TexCoord range. This fixes precision issues for very big TexCoord values and allows to optimize for all TexCoord channels when channels have values of different magnitudes (e.g. non standard TexCoord data).
#jira UE-54935
Change 4000305 by Yuriy.ODonnell
Suppress PVS Studio warning V547 (Expression is always true) related to Aftermath
Reported issue to PVS team and to NVIDIA. Confirmed false positive, fix coming in future PVS version (v6.24).
#jira UE-57579
Change 4000853 by Arciel.Rekman
Linux: fix not calling CrashReportClient (UE-57678).
#jira UE-57678
Change 4001504 by Rolando.Caloca
DR - vk - Fix transition
Change 4002460 by Krzysztof.Narkowicz
Toggle for contant shadow length in word space
Exposed contact shadows to Blueprints
#jira none
Change 4002608 by Rolando.Caloca
DR - vk - Fix static analysis
- Fix potential debug image tracking crash
- Comment out unused methods
Change 4002615 by Rolando.Caloca
DR - vk - Allow r.Vulkan.WaitForIdleOnSubmit to be set at startup (e.g. in ConsoleVariables.ini)
Previously, if your map needed to UpdateSkyCaptureContents on startup, an ensure would fail if GWaitForIdleOnSubmit was set.
PrepareForCPURead needs to wait for the command buffer to finish before trying to read the results back, but the wait has already happened when r.Vulkan.WaitForIdleOnSubmit is set. Trying to wait again correctly complains that the command buffer is not in the correct state. So, skip the WaitForCmdBuffer call when r.Vulkan.WaitForIdleOnSubmit is set.
Change 4002640 by Rolando.Caloca
DR - vk - Missing support for CVarDefaultBackBufferPixelFormat
Change 4002919 by Guillaume.Abadie
Implements DOF's temporal upsampling pass for better dynamic resolution stability.
Change 4002984 by Guillaume.Abadie
Integrates Sebastian Aaltonen's ALU optimisations for TAAU.
Change 4003112 by Olaf.Piesche
Fir for TBB stall (resulting in severe hitches and hangs in the editor with stats active); tested multiple scenarios and encountered no hitches.
#tests QAGame PerformanceTest and RenderTest map with various stats on and off
Change 4003159 by Mark.Satterthwaite
Undo parts of changelist 3970553 - the ref-counted pointer approach to returning textures to the pool is not working as expected so we'll remove that. It'll be faster on the CPU without it and everything works thanks to the changes this CL made to the way textures were released.
#jira UE-57538
Change 4003287 by zachary.wilson
Adding reflection capture content to TM-LightingScenarios
Change 4003395 by Arne.Schober
DR - Fix unitzialised value when clicking Go To in the editor
#jira UE-57048
Change 4003425 by Rolando.Caloca
DR - vk - Fix for new occlusion queries
Change 4003530 by Arne.Schober
DR - Disable GPU Benchmark in headless configurations
#jira UE-57673
Change 4003717 by Rolando.Caloca
DR - vk - Fix for depth not store, stencil store
Change 4003719 by Rolando.Caloca
DR - Minor switch to render pass
Change 4003720 by Mark.Satterthwaite
Don't suballocate private memory buffers on Vega and only Vega as there is something wrong with the blits in those cases but I can't capture a GPU trace to find out what right now (the driver is broken) - could be a bug in my code but this works on Polaris and Nvidia so it will need to be filed as a radar for AMD.
Remove the FMetalBufferChunk from FMetalBuffer and simply store a pointer to the owning Heap/Magazine allocator. The FMetalResourceHeap now calls a new Release function to return the buffer to the allocator which will be faster on the CPU.
#jira UE-57659
Change 4003854 by Mark.Satterthwaite
Undo parts of 3990064 and try a different approach to get the uniforms to upload and remain available in the right places. As the original bug has been lost to time we should keep an eye out for missing buffer bindings by running under the Metal validation layer periodically.
#jira UE-57576
Change 4004709 by Rolando.Caloca
DR - Support for D3D 11, 12 & Vulkan for UAVs off Index Buffers
Change 4005149 by Guillaume.Abadie
Adds shader permutation to avoid clamping input buffer UV in DOF's gather pass.
Change 4005284 by Uriel.Doyon
Resaved volume texture assets with proper engine version.
#jira UE-57534
Change 4005286 by Guillaume.Abadie
Reduces constant setup in DOF's gather pass.
Change 4005359 by Rolando.Caloca
DR - vk - Fix annoying warning
Change 4005363 by Rolando.Caloca
DR - Fix android not finding vulkan shaders
Change 4005457 by Rolando.Caloca
DR - vk - Fix swapchain crash
Change 4005473 by Patrick.Kelly
UE-57135: Editor crash if set Reflection Capture Resolution to be 64 and New a Default level
Codde by Daniel
Tested by Patrick
Change 4005474 by Rolando.Caloca
DR - vk - Remove glsl code from shaders. Packaged QAGame goes from 176MB to 162MB
Change 4005759 by Krzysztof.Narkowicz
Fixed a bug, where reflection capture build is called, even though we are in mobile preview mode.
#jira UE-57743
Change 4005774 by Mark.Satterthwaite
Update the wave intrinsics to avoid implicit bool->uint conversion that Apple don't like.
#jira UE-57750
Change 4005974 by Mark.Satterthwaite
Don't use cubemap array types on iOS Metal as they aren't available on all devices and we need to maintain backward compatibiliy for years to come.
#jira UE-57083
Change 4006056 by Mark.Satterthwaite
Remove the use of the PrimitiveType argument from Metal draw calls.
#jira UE-57822
Change 4006139 by Mark.Satterthwaite
- Move the render-pass functions into the MetalRHI implementation for later alteration.
- Implement Index buffer UAVs for Metal - makes them more like vertex-buffers so this is one more step on the road to a unified buffer base-class implementation.
Change 4006215 by Mark.Satterthwaite
Metal's begin & end render/compute pass API implementation will take some time, but for now make it not depend on the parent stub implementation.
Change 4006394 by Mark.Satterthwaite
In lieu of a real instruction count just use the number of lines in the "Main" function of the shader as the instruction count for Metal.
#jira UE-57551
Change 4006493 by Mark.Satterthwaite
MetalRHI can currently support 4-component formats for Buffer UAVs - this might need some thought in the future as the API evolves but we might as well take advantage while we can.
Change 4006495 by Daniel.Wright
Integrate from Refactor branch
* New FMaterialRenderProxy function GetMaterialWithFallback which provides both the FMaterialRenderProxy and FMaterial. Needed when falling back to default material, so that proxy and material resource match.
* Local vertex factory uniform buffer
Change 4006851 by Brian.Karis
Fix for joined charts forming an L to inflate both axii.
Thanks to Jess Kube of The Coalition.
Change 4006852 by Brian.Karis
Fix for hard coded reflection capture cube map size. Should fix light static light aliasing in captures
Change 4006918 by Brian.Karis
New ByteBuffer functionality. Memcpy and scatter upload. Can implement GPU side TArray reflection.
Not yet used by checked in code. WIP optimization.
Change 4007246 by Guillaume.Abadie
Creates lower quality permutation for DOF's gathering pass, without Coc based weighting of the samples, and lower number of gathering ring for fast accumulator.
Change 4007291 by Guillaume.Abadie
Exposes more DOF scalability settings.
Change 4007328 by Guillaume.Abadie
Optimises DOF's half res only setup pass using gather4
Change 4007627 by Richard.Wallis
Fix for when Magic Mouse cannot zoom in World Composition editor. Missing default SNodePanel::OnMouseMove behaviour. Tested using a classic 2xbutton + wheel mouse and a Mac MagicMouse.
#jira UE-57030
Change 4007682 by Richard.Wallis
No video when playing HLS streaming video on Mac. 2 Issues, FPS was zero making duration for video sample buffer nonsense and Video Track dimensions were going to zero on the AVAsset once fully initialized when playing HSL streams. Now cache relevant details and handle zero frame rate.
Notes:
- Caching the frame rate is not as important as we could look it up each time and fix for zero - ignoring that at the moment.
- Assume we DO NOT want the FrameSize to be the last fetched video frame size from the AvfMediaVideoSampler as I think that is the video quality for streaming video and not the media frame size.
- Renamed a variable in the AvfMediaVideoSample - was called FrameRate but it was the FrameDuration by that point.
#jira UE-56734
Change 4007731 by Rolando.Caloca
DR - Disable byte buffers on non-hlsl based platforms
#jira UE-57851
Change 4007741 by Rolando.Caloca
DR - Disable byte buffers on hlslcc platforms
Change 4007782 by Mark.Satterthwaite
Force Metal shaders, including the stdlib, to recompile.
Change 4007918 by Rolando.Caloca
DR - vk - Some static asserts
Change 4008404 by Arciel.Rekman
Do not crash on incompatible Vulkan drivers (UE-57521).
#jira UE-57521
Change 4008442 by Daniel.Wright
Better comments on ERHIFeatureLevel expectations
Change 4008494 by Arne.Schober
DR - moved bDeletedThroughDeferredCleanup before begincleanup to catch cases where the reference is added twice to the array. also removed finishcleanup as all they ever did was deleting the pointer anyway, and it sould be adfded if such functionallity is ever required fom outside of the regular destructor.
#jira UE-57754
Change 4008730 by Mark.Satterthwaite
After the most recent changes to handling uniform buffer dirty bits in MetalRHI we should guard against attempts to set an unbound uniform buffer.
#jira UE-57870
Change 4008949 by Brian.Karis
Fix compile warning
Change 4008951 by Brian.Karis
Added LTC LUT textures
Change 4009326 by Guillaume.Abadie
Compiles out DOF's gathering bokeh simulation on platform other than desktop.
Change 4009380 by Krzysztof.Narkowicz
Moved area light code before the contact shadows, so contact shadows use representative light's direction.
Merged all contact shadows shader code.
Contact shadows keep constant screen space length independent of FoV settings.
Contact shadows for translucents.
Contact shadows for eye.
Change 4009555 by Guillaume.Abadie
Splits DOFCocTile.usf in two.
Change 4009999 by Yuriy.ODonnell
MallocStomp can now be enabled on certain platforms using '-stompmalloc' command line argument.
Previously it was necessary to modify MallocaStomp.h and re-compile the engine.
Currently supported platforms: Win64, Mac, Linux.
Replaced hard-coded page size with FPlatformMemory::GetConstants().PageSize.
Change 4010288 by Rolando.Caloca
DR - vk - Fix for vertex streams
Change 4010289 by Krzysztof.Narkowicz
D3D12 - fixed depth bounds bug, where depth bounds wasn't properly set to [0;1] after disabling.
#jira UE-57510
Change 4010297 by Rolando.Caloca
DR - vk - Remove some functions for android
Change 4010315 by Rolando.Caloca
DR - vk - Remove create info macro
Change 4010451 by Rolando.Caloca
DR - vk - Reuse samplers
- Infiltrator goes from 5759 to 24 samplers!
Change 4010627 by Rolando.Caloca
DR - vk - Fix missing values for tracking swapchain validation
Change 4011924 by Guillaume.Abadie
Implements tile based early return optimisation on DOF's postfiltering method.
Change 4011941 by Guillaume.Abadie
Shaves some ALU in DOF's accumulator for LowQuality permutation.
Change 4012093 by Yuriy.ODonnell
Disable MallocStompOverrunTest() in static analysis config, as it intentionally performs an out-of-bounds access.
Change 4012195 by Rolando.Caloca
DR - vk - Fix for mobile backbuffer layout
Change 4012202 by Rolando.Caloca
DR - vk - Don't use staging buffers on UMA
Change 4012467 by Rolando.Caloca
DR - Remove redundant check
Change 4012486 by Rolando.Caloca
DR - Fix missing transition
Change 4012518 by Guillaume.Abadie
Implements fast shader permutation for DOF's TAA pass.
Change 4013084 by Arciel.Rekman
Fix for Linux clock discrepancy.
- Causing at least one precision issue, possibly more.
(Edigrating 4003273, 4012462 from //UE4/Dev-Editor/... to //UE4/Dev-Rendering/...)
Change 4013266 by Uriel.Doyon
Fixed crash when setting SceneDepthTextureNonMS and not having valid depth buffers in the SceneContext.
Change 4013626 by Uriel.Doyon
Fixed crash in the lighting build when creating a blueprint of the ALight and placing a light component in it.
#jira UE-51672
Change 4013805 by Rolando.Caloca
DR - Fix more missing transitions
Change 4014128 by Arne.Schober
DR - Do not create LocalVFUniformBuffer when running without MVF
#jira UE-57929
Change 4014193 by Uriel.Doyon
Editing component transforms now invalidate the component's lighting cache.
#jira UE-48134
Change 4014282 by Rolando.Caloca
DR - vk - Remove extra validation during dump
Change 4014584 by Uriel.Doyon
Duplicated static meshes now generate a new GUID to prevent possible issues with lightmass.
#jira UE-49064
Change 4014604 by Uriel.Doyon
UStaticMesh postduplicate now only generates a new GUID if !bDuplicateForPIE.
Change 4015460 by Guillaume.Abadie
Composes separate translucency within DOF's recombine pass.
Change 4015571 by Guillaume.Abadie
Refactors tonemapper to use global shader permutation API, that adds permutation for HDR output device rather than dynamic branching that some shader compiler are not very well optimizing.
Change 4015984 by Krzysztof.Narkowicz
Fixed crash inside DFAO resource allocation, when DFAO viewport has zero area.
#jira UE-58000
Change 4016056 by Mark.Satterthwaite
Fix Mac Metal shader compilation of texture cube arrays.
Change 4016062 by Richard.Wallis
Convert things like Space, Delete, F6 etc to unicode so they display correctly on the Mac menu rather than first letter of word. Added the default Mac commands to the GenericCommands so we get a Chord overwrite message and stop things like cmd+ q / w / h from getting bound.
#jira UE-46999
Change 4016109 by Mark.Satterthwaite
One unified Metal buffer implementation - will make further changes a heck of a lot easier.
Change 4016221 by Patrick.Kelly
UE-57617: Ensure changing viewmode to ShaderComplexity while in -game
Change 4016238 by Guillaume.Abadie
Makes clang happy again in Tonemapper.
Change 4016309 by Mark.Satterthwaite
More *_RenderThread implementations for MetalRHI.
Change 4016414 by Mark.Satterthwaite
And MetalRHI version of CreateStructuredBuffer_RenderThread...
Change 4016498 by Mark.Satterthwaite
Don't hold on to the uniform buffers bound to the hull shader when switching to a tessellated draw call as they'll have the wrong buffer layout.
#jira UE-57930
Change 4017394 by Juan.Canada
OpenGL: Fixed shading artifacts due incorrect UNORM/SNORM conversions in skin/skincache/computetangent shaderss.
#jira UE-57691
Change 4017522 by Rolando.Caloca
DR - vk - Remove unused code path (old mip generation detection)
Change 4017539 by Rolando.Caloca
DR - vk - Fix for sky lighting mips showing green on AMD
Change 4017542 by Arciel.Rekman
Moved appCountTrailingZeros to a non-SSE header (fixes ARM64 build).
- Arguably WITH_SLI shouldn't apply to Linux on ARM but the fact that the function wasn't available is bad on its own.
Change 4017827 by Guillaume.Abadie
Optimises DOF's scattering cost by a third.
Change 4017835 by Rolando.Caloca
DR - Only allow a render pass to generate mips for one color render target
Change 4017889 by Mark.Satterthwaite
Cache all the Metal state objects to avoid hitting the API unnecessarily.
Change 4018251 by Mark.Satterthwaite
Fix broken rendering on Metal that tracked back to the innocuous looking changes in CL #4006495 (no blame attached - these changes are entirely reasonable) and cause various bugs in QAGame's TM-DistanceFields, ElementalDemo and probably more. Doesn't fix broken SpeedTree rendering :(.
MetalRHI was allowing uniform buffers to blow away linear texture buffers when the constant buffer has been elided due to dead-code elimination. This problem can manifest without linear textures if the uniform buffer contains both constant data and a resource-table but the shader doesn't use any of the constant data. That's because Metal doesn't separate constant buffers from any other kind of buffer unlike D3D which separates all the slots out - and Metal doesn't provide enough buffers to emulate the D3D arrangement. So far this has only manifested in the MVF + Linear Texture case but a more robust solution will be necessary long term.
Change 4018514 by Guillaume.Abadie
Implements r.DOF.Scatter.MinCocRadius.
Change 4018553 by Guillaume.Abadie
Implements r.DOF.Scatter.MaxSpriteRatio to control the budget upperbound of DOF's scattering
Change 4020369 by Yuriy.ODonnell
Disable MallocStompOverrunTest in all static analysis configs (using USING_CODE_ANALYSIS macro)
Previously was only disabled for PVS-Studio.
Change 4020620 by Arciel.Rekman
Fix XboxOne CIS (fallout of appCountTrailingZeros move).
Change 4020949 by Guillaume.Abadie
Configures DOF in scalability settings.
Change 4021593 by Rolando.Caloca
DR - vk - Support for Aftermath style api on AMD
Change 4021740 by Rolando.Caloca
DR - vk - Change log output
Change 4022008 by Uriel.Doyon
Fixed renderthread stalls when streaming texture mips on low end systems.
Change 4022135 by Rolando.Caloca
DR - vk - Fix last mip's layout during mip chain creation
Change 4022607 by Jian.Ru
Speculative fix for a bug where an invalid vertex buffer is deferenced
#jira UE-56229
Change 4022890 by Rolando.Caloca
DR - Fix reference count not getting released
Change 4023540 by Mark.Satterthwaite
Avoid some pointless retain/release calls on Metal Encoders.
Change 4023796 by Marcus.Wassmer
Tell users they are over the maximum size when allocating very large rendertargets.
Change 4025337 by Yuriy.ODonnell
Improved use-after-free detection mechanism and physical memory usage of MallocStomp on Windows.
MallocStomp on Windows will now reserve virtual address space for every allocation and then commit physical pages only to the valid usable part.
Physical pages will be unmapped on Free, but virtual address space will not be released and therefore will never be re-used.
Virtual address space is allocated from the OS in blocks of 1GB and then linearly sub-allocated.
This reduces VA space usage, as VirtualAlloc returns blocks on 64KB granularity even if we just need 4KB. As a small bonus, this also reduces number of syscalls per allocation.
This dramatically increases accuracy of use-after-free detection, but consumes significant amount of memory for the OS page table.
Virtual memory limit for a process on Win10 is 128 TB, which means we can afford to keep virtual memory reserved for a long time.
Running Infiltrator demo consumes ~700MB of virtual address space per second.
Additionally, committing physical pages only for the usable part of the entire virtual block reduces physical memory usage by ~30% compared to old behavior,
which allocated and committed entire block of pages via BinnedAllocFromOS and then marks border page as non-accessible.
Change 4026047 by Rolando.Caloca
DR - Fix test/shipping
#jira UE-58148
Change 4026150 by Krzysztof.Narkowicz
Force proper ordering of buffer visualization materials - after tonemapping (so exposure doesn't influence it) and before editor stuff like icons.
#jira UE-57992
Change 4026226 by Rolando.Caloca
DR - Fix static analysis
#jira UE-58150
Change 4026354 by Jian.Ru
Debug check trying to catch a crash. Only enabled in editor build
#jira UE-50111
Change 4026655 by Rolando.Caloca
DR - Fix for static analysis
#jira UE-58149
Change 4026763 by Rolando.Caloca
DR - Remove references to defunct CCT to avoid confusing licensees
Change 4027167 by Uriel.Doyon
Fixed possible out of bound buffer access when serializing with FDuplicateDataWriter.
#jira UE-56509
Change 4027850 by Jian.Ru
Prevent log spam
#jira UE-50111
Change 4029546 by Rolando.Caloca
DR - Compile fixes
Change 4029624 by Yuriy.ODonnell
Addressed static analysis errors in MallocStomp
- VirtualAlloc return value is now explicitly checked.
- C6250 is suppressed, as VirtualFree does not release address space by design.
Change 4030225 by Yuriy.ODonnell
Static analysis warning fix: make sure declaration of Sleep() is consistent between Windows headers and TBB
The complexity with this particular case is that the warning is generated in synchapi.h, which is included by some Windows headers.
If a module includes TBB and then Windows platform headers, static analyzer will report this warning.
Suppressing it would require wrapping all instances of Windows header includes in third-party macros.
Current pragmatic solution is to modify the Sleep() declaration in TBB header to be consistent with Windows and to report the issue to Intel for a permanent fix.
Change 4030440 by Rolando.Caloca
DR - Fix crash on mobile
#jira UE-58222
Change 4030570 by Daniel.Wright
Allow null SRV's in uniform buffers for feature levels that don't support SRV's in shaders
Change 4030618 by Arne.Schober
DR - missing tangent/normal sign conversion after integration from main
#jira UE-58224
Change 4031588 by Rolando.Caloca
DR - vk - Fix compile error when missing vkCmdWriteBufferMarkerAMD
Change 4032145 by Mark.Satterthwaite
Fix UE-58268 by only emitting the base_instance/base_vertex variables required to fix-up the instance/vertex ID values to match D3D when the Metal version is 1.1 or higher, earlier versions don't support these features.
#jira UE-58268
Change 4032209 by Rolando.Caloca
DR - Fix crash on EngineTest: Mesh Batch's UserIndex is not a union anymore
Change 4033178 by Guillaume.Abadie
Fixes FXAA sampling outside viewports, that was causing black outline on bottom and right edge of the screen when ViewSize != BufferSize, problematic for some screenshot automated test.
#jira UE-58151
Change 4034489 by Daniel.Wright
Fixed UStaticMeshComponent modifying its UStaticMesh when undoing a change. This caused a crash when other static mesh components using the same mesh asset were rendered, since their rendering state was not recreated. A component should not modify its asset during PostEditUndo.
* This behavior has been present for a long time but was previously hidden because only the vertex factory of the mesh asset is cached in static draw lists, not any of its rendering resources (eg vertex declaration).
Change 4035157 by Uriel.Doyon
Fixed deadlock in the streaming code when running with -onethread.
#jira UE-58299
Change 4035198 by Rolando.Caloca
DR - vk - Fix issue when an older SDK was installed, UBT would pick it (should pick the newer of ThirdParty\Vulkan or installed SDK).
#jira UE-58267
Change 4035730 by Arne.Schober
DR - Fix missing Fog parameters during LightScattering Injection
#jira UE-57608
Change 4035843 by Daniel.Wright
Reimplemented support for EyeAdaptation node in opaque materials
Change 4036837 by Marcus.Wassmer
Replace some of the screenshots to match new un-tonemapped buffer visualization
Change 4036980 by Rolando.Caloca
DR - vk - Fix deadlock contention during mem allocation on Linux
Change 4037225 by Guillaume.Abadie
Fixes jittering selection outline.
#jira UE-58350
Change 4038056 by Marcus.Wassmer
roll back changelist 4026150. breaks a bunch of automated tests by cutting off half the image.
Change can go back in later with that part fixed also
Change 4038296 by Jian.Ru
Static analysis fix
#jira UE-58377
Change 4038402 by Ben.Marsh
Suppress IncludeTool warnings caused by CL 3998947.
Change 4038514 by Arne.Schober
DR - Fix case with MVF where instance offset is not supported by the API (in this case only foliage OpenGL and TvOS), usually the buffers are offsetted instead but with MVF we do not use offsetted buffers, therfore the offset needs to be passed into the shader although we are drawing with offset of 0.
#jira UE-57652
Change 4038747 by Marcus.Wassmer
Back out changelist 3853645, causing us to lose shadows in the shaderhair test
Change 4040138 by Rolando.Caloca
DR - Fix compile warning
Change 4041614 by Rolando.Caloca
DR - vk - Fix for Oculus module
#jira UE-58267
Change 3810277 by Daniel.Wright
Ray Traced Distance Field shadows use a two pass tile culling algorithm with no tile max - fixes flickering from tile overflow in dense areas or with a low sun angle. Costs .2ms on PS4.
The distance field scene buffers now use float4 on PS4 and Xbox, saves .1ms on PS4.
Change 3817029 by Uriel.Doyon
Added UVolumeTexture, which use 3D textures. Compressed formats are supported on DX11, DX12, PS4 and XB1.
Projects targetting OpengGL don't have access to compressed formats (as the implementation has texture tiling issues).
Add "r.AllowVolumeTextureAssetCreation" set as 0 by default, which controls whether volume texture can be sampled in materials and whether they can be created from 2D texture assets.
Platform not supporting BC7, will now fallback on RGBA8 instead of DXT to preserve quality, in an attemps to increase usage of BC7.
#jira UE-32263
Change 3819960 by Michael.Lentine
Expose UEPhysics Clothing Parameters through UI.
Change 3823401 by Rolando.Caloca
DR - Add NumQueriesInBatch to RHIBeginOcclusionQueryBatch
Change 3844805 by Arne.Schober
DR - Increased Intermediate normal of Umodel and Skelmesh from 8bit Unorm Compressed to float. A resave/rebuid/reimport of the meshes is recommended to recover some lost precision.
Fixed an issue with compressed (packed) normals on the GPU which were off by one integer representation. Also switched from UNORM to SNORM to get a discrete zero representation and removed some mads from all the VertexShaders.
Change 3847283 by Marcus.Wassmer
Extra fixes from Uriel
Change 3876607 by Rolando.Caloca
DR - Use render passes when running occlusion queries
- Removes the RHI(Begin|End)OcclusionQueryBatch API
Change 3903799 by Daniel.Wright
[Integrate] Pass Uniform Buffers
* All pass-constant shader inputs should go into the appropriate pass uniform buffer, instead of being set per-draw
* Moved many per-draw base pass parameters over to the Base Pass Uniform Buffer
* Opaque and Translucent base pass shaders have different uniform buffers, which allows compile errors when accessing an invalid resource (eg GBuffer in Opaque), instead of silently falling back to GBlackTexture
Uniform buffers can now contain nested structs with UNIFORM_MEMBER_STRUCT()
* This allows composing a uniform buffer at a particular update frequency out of many features, with encapsulation of each feature's parameters in a struct.
* Eg deferred fog uses FFogUniformParameters, but so does translucency in the base pass, where FFogUniformParameters is reused nested inside the base pass uniform buffer.
* Resources can now be located anywhere in the uniform buffer. Padding is inserted to the cbuffer representation to keep memory layouts matching. In the future the cbuffer could be compacted.
* RemoveUniformBuffersFromSource() which works around HLSLCC lack of struct initializers now handles nested structs
Change 3917500 by Rolando.Caloca
DR - Change depth bounds so only the enable bit is in the PSO, allow min/max to be dynamically modified
Change 3964907 by Guillaume.Abadie
Implements RectList topology support in RHI.
Change 3979171 by Mark.Satterthwaite
Copying //Tasks/UE4/Dev-UERNDR-354-mtlpp to Dev-Rendering (//UE4/Dev-Rendering):
Rewrites MetalRHI in terms of mtlpp, which is a C++ wrapper library built around Metal's Objective-C API that attempts to reduce overheads and eliminate resource lifetime errors.
Regarding mtlpp:
- The mtlpp library uses C++ constructor/destructor and smart-pointer style management of Objective-C retain/release calls to prevent over- and under-release problems.
- To reduce Objective-C overheads the mtlpp library caches the internal C-function that implements the Objective-C selectors for the most commonly used Metal protocol types and calls the function directly - this avoids objc_msgSend which does this look-up dynamically and thus improves CPU performance slightly.
- Another advantage is that mtlpp provides infrastructure to extend the Metal API slightly to help improve MetalRHI - the two important aspects are mtlpp::CommandBufferFence which provides a consistent CPU<->GPU synchronisation primitive and sub-buffer allocations from mtlpp::Buffer which allow for far superior memory management.
- Validation functionality is also provided by mtlpp to detect CPU vs. GPU data races and resource lifetime validation - this is expensive and is thus optional and compiled out from Shipping binaries that should be used when performance is most critical. The validation only works between resource modification and *submitted* command-buffers - anything that is being actively encoded on the CPU is ignored and it remains the responsibility of the application to validate the order of operations when encoding.
Apple Platform:
- LLM support which tracks Objective-C objects is enabled only on macOS - we don't have the necessary libraries to intercept and override the internal system calls on iOS.
MetalRHI:
- All the types are switched over, (mostly) insuling the external API from the horror of Metal and Objective-C.
- Buffers are now managed quite differently, small buffers are allocated from a magazine allocator that allocates in fixed blocks from a larger parent buffer, intermediate sized buffers are allocated from a simple heap allocator that wraps a larger buffer and anything of reasonable size (>2Mb) will use the pooled allocator. This *radically* reduces the number of buffer resources, by as much as a factor of 10, because they are now sub-allocated without the need to use MTLHeap or MTLFence so they are performance equivalent to the existing implementation on the GPU and much faster on the CPU. Total memory use is approximately the same.
- Vertex & index buffer management has been updated to reflect changes in the management and to avoid reallocating buffers which provide a Linear Texture (for SRVs) unless strictly necessary. This ensures that even in cases where a dynamic buffer is updated multiple times in a frame it will still work acceptably well.
- The Metal ring-buffer implementation is completely different again, this time it can use Managed memory on macOS which allows for much better performance on eGPUs which will be more and more important for Mac.
- Everyone that needs to wait on a command-buffer fence (rather than a command-buffer itself) now use mtlpp::CommandBufferFence, which prevents race conditions between the different command-buffer handlers (which sometimes execute out of order).
- LLM tracking should now report the same data as the MetalRHI stats group for buffer & texture allocations - there is no segmentation for Vertex/index/Structured/Uniform allocations in Metal so these numbers are going to be wrong and will need to be rethought.
- What will be unseen are the number of small but important resource usage fixes that avoid stale resources from being bound to the device after the point at which they become invalid. This should eliminate a class of errors where the GPU uses a resource pointer that is modified by the CPU and was necessary to satisfy the new mtlpp validation code.
Other:
- Remove the Metal focused workarounds from the ClothBuffer resource binding and related vertex-buffer SRV - these were put in when MetalRHI/MetalShaderFormat couldn't handle float->uint conversions correctly and they should now.
- Fix a validation error caused by trying to render a 0-sized scissor rect which is invalid in Metal and simply pointless elsewhere.
- Consistency of disabling the Manual Vertex Fetch behaviour in shaders.
#jira UERNDR-354
Change 3979312 by Rolando.Caloca
DR - Remove bogus bKeepOriginalSurface parameter in CopyToResolveTarget
Change 4005122 by Rolando.Caloca
DR - Support for PS4 Index Buffer UAVs
Change 4016298 by Guillaume.Abadie
Fixes DOF hybrid scattering on platforms that supports RectList topology.
Change 4018575 by Guillaume.Abadie
Optimises DOF's reduce pass when doing scattering compilation.
Change 4020317 by Guillaume.Abadie
Implements WaveBroadcastIntrinsics.ush.
[CL 4042226 by Marcus Wassmer in Main branch]
#rb None
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3629223 by Rolando.Caloca
DR - Rollback //UE4/Dev-Rendering/Engine/Source/Runtime/VulkanRHI to changelist 3627847
Change 3629708 by Rolando.Caloca
DR - vk - Redo some changes from DevMobile
3601439
3604186
3606672
3617383
3617474
3617483
Change 3761370 by Arne.Schober
DR - Added CityHash to use with conatiners and stuff. It provides good performance and high quallity across multiple platforms.
Change 3761437 by Guillaume.Abadie
Optimises motion blur compute shader for consoles.
Change 3761483 by Guillaume.Abadie
Fixes D3D11 RHI lying to dynamic resolution heuristic with t.MaxFPS.
Change 3761995 by Mark.Satterthwaite
Add the Metal compiler path to the local .pch filename to avoid problems when Xcode moves.
Change 3761996 by Mark.Satterthwaite
Emit more details when a pixel shader is found to have no outputs at all which Metal doesn't permit. More likely this is a bug in the shader compiler not configuring the in-out mask correctly...
#jira UE-52292
Change 3761999 by Mark.Satterthwaite
No need to avoid tessellation for FMetalRHICommandContext::RHIEndDrawIndexedPrimitiveUP anymore - that was from back when the tessellation logic was replicated in each RHI*Draw* implementation.
#jira UE-51937
Change 3762181 by Joe.Graf
Changed MaxShaderJobBatchSize to 25 on Mac as it reduced shader compile time by 21%
Change 3762607 by Mark.Satterthwaite
Remove accidentally included changes from 3761995.
Change 3762612 by Mark.Satterthwaite
Enable the explicit sincos intrinsic for Metal to avoid instances of UE-52477 that can cause shaders to compile incorrectly through hlslcc.
#jira UE-52477
Change 3762772 by Michael.Lentine
Move RHI calls to render thread.
Change 3763021 by Richard.Wallis
Remove shader cache tool project and implementation.
#jira UE-51613
Change 3763082 by Guillaume.Abadie
More SceneTexture, SceneColor and SceneDepth automated tests
Change 3763111 by Richard.Wallis
Clone of CL 3763033 (Release-4.18):
Fix for crash upon launching packaged game on Mac with Share Material Shader Code enabled.
#jira UE-52121
Change 3763657 by Michael.Lentine
Invalidate ddc for skeletal mesh render data so that the duplicated vertex render structures are properly serialized.
Change 3763727 by Jian.Ru
Fix Player Collision view mode. It is caused by checking an uninitialized vertex buffer so the check always fail.
#jira UE-52052
Change 3763738 by Guillaume.Abadie
Implements SSR input post process material location.
Change 3764271 by Mark.Satterthwaite
Allow ControlPointPatch lists to flow through MetalRHI as it was setup to handle this transparently - the VSHS compute shader will convert them to triangles to draw. Report the same warning as in the pipeline creation stage as this hasn't been formally validated.
#jira UE-52454
Change 3764316 by Daniel.Wright
Added AVolumetricLightmapDensityVolume - gives local control over Volumetric Lightmap density. Dropping the top mip outside of the play area in Monolith saves 20Mb (35Mb original).
Volumetric Lightmap no longer refines around static translucent geometry - saves 5Mb in Monolith
Reworked brick culling by error mechanism. Now compares error to interpolated parent lighting instead of the brick average - prevents dropping constant value bricks which are near a wall and cause leaking due to parent interpolation after being culled.
Change 3764318 by Daniel.Wright
Missing file
Change 3764321 by Daniel.Wright
Shader compiling memory optimizations
* Editor memory: Sharing uniform buffer includes and GeneratedInstancedStereo.ush per FShaderType (was previously duplicated per FShader job)
* SCW input size: Sharing uniform buffer includes and SharedEnvironment per batch
* 7.6Gb of shader job inputs in memory -> .5Gb (13x less) when doing a full shader compile of Paragon Editor
* 13.8Gb written into worker input files -> 2.9Gb (4.7x less). Global shaders are never batched when sent to SCW so unoptimized by these changes.
Change 3764595 by Daniel.Wright
Added VolumetricLightmapDensityVolume asset icons
Change 3764701 by Michael.Lentine
Add duplicated vertices merging for meshmerge.
Change 3766002 by Guillaume.Abadie
Fixes a crash in translucency.
Change 3766007 by Guillaume.Abadie
Oups.... Fixes compilation failure.
Change 3766697 by Guillaume.Abadie
Giant refactor of global shader interface for upcoming native support of permutation.
CL generated by python script.
Change 3767205 by Chris.Bunner
Deferring FMaterial::RenderingThreadShaderMap update to render-thread rather than assumption commands have been flushed.
#jira UE-50652
Change 3767207 by Chris.Bunner
Clamp fetched texture coordinates to those available on the mesh.
Change 3767209 by Chris.Bunner
PR #4203: Early-outs in UMaterialInstance parameter setters (Contributed by stefanzimecki)
#jira UE-52193
Change 3767772 by Mark.Satterthwaite
MetalShaderFormat will no longer fallback to text shaders when you ask it to compile to bytecode but the bytecode compiler is not available (either locally or remotely) - this ensures that the DDC can't be poisoned by incorrectly configured clients. The Editor is already setup such that if the remote shader compiler is not configured & Xcode is not available locally the shader-compiler will be invoked to generate text shaders.
#jira UE-52554
Change 3768604 by Guillaume.Abadie
Polish up with new global shader function signature.
Change 3768993 by Guillaume.Abadie
Fixes r.Upscale.Panini cvars
Change 3769478 by Mark.Satterthwaite
Move the ue4_stdlib.metal & PCH into a temporary directory that exists for the lifetime of the SCW on the remote side as well as the local one and add this path as an include directory.
#jira UE-52587
Change 3769703 by Mark.Satterthwaite
For all Metal platforms >= Metal v1.2 transform mul(a,b) into fma(a,b,0) to prevent the Apple compiler reordering operations differently between the base & depth passes which results in variance in the position output.
For iOS disable fast-math when the vertex-shader uses World-Position-Offset because there are additional problems on the iOS shader compiler that result in position variance even with the above fix - WPO performance will suffer but I don't have any alternatives.
Remove the depth-offset hack from the depth-only vertex shader again.
#jira UES-5651
Change 3769763 by Mark.Satterthwaite
Handle swizzle's in the hlslcc fma identification pass so that we reduce the number of instructions and the platform compiler can't break the instructions up.
Change 3769849 by Mark.Satterthwaite
Fix CIS error.
Change 3770517 by Richard.Wallis
Fix for crash when creating a new media texture (AppleIntelHD5000GraphicsMTLDriver!SamplerStage::bindSamplerToTexture()). Missing texture resource for binding. Old InitDynamicRHI() code has been refactored out into seperate functions which leaves us on Mac with a NULL resource initially after creation which Metal doesn't like. This fix puts InitDynamicRHI down the default setup/clear path which inits default resources - I don't think we should use a global dummy in this instance as this is a render target.
#jira UE-51940
Change 3770688 by Uriel.Doyon
Fixed texture resolution returning 0 when running blueprint construction scripts at cook time.
Change 3771115 by Mark.Satterthwaite
Report errors from failed attempts to compile global shaders or we can't see why things fail on non-Windows platforms.
Change 3771263 by Mark.Satterthwaite
Change the way ManualVertexFetch is enabled on Metal platforms so that it is enabled when targeting Metal v1.2 and higher (macOS 10.12+/iOS 10+). This brings iOS in the Desktop Forward renderer back into line with the Mac.
#jira UERNDR-300
Change 3773472 by Guillaume.Abadie
Fixes a crash on PIE of SimpleComposure project.
Change 3773475 by Guillaume.Abadie
Fixes bug in editor viewport caused by SSR input changes.
Change 3774677 by Arne.Schober
DR - Deprecated SetLocal from the RHICmdlist
Fixed some unnecessary PSO collisions.
Change 3777037 by Mark.Satterthwaite
Remove incorrect change that caused a reference to "accurate::sincos" to appear in some Metal shaders rather than "precise::sincos".
Change 3777122 by Mark.Satterthwaite
Back out changelist 3777037 - I'm blind and wasn't seeing the real problem was a stale shader cache...
Change 3777196 by Mark.Satterthwaite
Fix text-shader compilation on iOS 10 - maybe iOS 9 too (untested!).
We need our own make_scalar type-trait template for ue4_stdlib.metal so that we still compile with older iOS runtime compilers and we can't use as_type to directly implement the packHalf2x16/unpackHalf2x16 intrinsics for these older runtime compilers either.
Change 3779098 by Rolando.Caloca
DR - vk - Fix query index
Change 3779275 by Mark.Satterthwaite
Silence the Metal runtime compiler warning caused by use of a deprecated enum value when running text shaders compiled for Metal v1.0/1.1 on a Metal v1.2+ OS.
#jira UE-52554
Change 3779427 by Rolando.Caloca
DR - vk - Fix for allocator contention
Change 3779608 by Uriel.Doyon
Fixed invalid access in the resave package commantlet when building texture streaming material data for materials enabling tesselation.
Change 3784496 by Mark.Satterthwaite
Temporarily disable USE_OBJECT_COMPOSITING_TILE_CULLING for Metal shader compilation only - other platforms are unaffected - as it isn't working properly for some reason. need to work out what's up but don't want Distance Fields to be completely snookered in the interim.
#jira UE-52952
Change 3784608 by Rolando.Caloca
DR - Copy 3784588
- Fix for drivers returning out of date swapchains during resizes
Change 3784734 by Mark.Satterthwaite
Real fix for UE-52952 - MetalShaderFormat wasn't propagating the full thread-group value.
#jira UE-52952
Change 3784741 by Mark.Satterthwaite
More Metal debugging commandline options "-metalfastmath" & "-metalnofastmath" to force fast-math on or off for all shaders, must be using runtime-compiled shaders (i.e. -metalshaderdebug or r.Shaders.Optimise=0) to take effect.
Change 3787103 by Guillaume.Abadie
Kills BuiltinSamplers UB
Change 3787207 by Guillaume.Abadie
Sorry, compile fix that were fine with local changes...
Change 3787396 by Marcus.Wassmer
PR #4271: UE-52901: Set VIS_Max meta to hidden (Contributed by projectgheist)
Change 3788028 by Peter.Sumanaseni
Working linear HDR exr output from sequencer
Change 3788536 by Mark.Satterthwaite
Track whether the Metal shader uses the discard_fragment function as when this is used but without any other outputs we know we need to bind at least one render-target or a depth-stencil surface but we don't know which. This lets us correctly error when we encounter a shader with no outputs at all which Metal doesn't permit.
#jira UE-52292
Change 3788538 by Mark.Satterthwaite
Let's try mitigating UE-46604 on Nvidia by retaining resource references in the command-buffer. This shouldn't be necessary and isn't typically on other vendors but we haven't been able to reproduce this reliably enough to get to the bottom of it.
#jira UE-46604
Change 3789083 by Guillaume.Abadie
Implements global shader permutations. Example in ScreenSpaceReflections.cpp.
Change 3789090 by Guillaume.Abadie
Fixes linux build.
Change 3789106 by Guillaume.Abadie
Fixes compilation failure in niagara plugin.
Change 3789274 by Guillaume.Abadie
Avoid hit proxies to clobber TAA's hitsory.
#jira UE-52968
Change 3789380 by Guillaume.Abadie
Back out changelist 3789083: global shader permutation because compilation failure in clang.
Change 3789648 by Guillaume.Abadie
Relands global shader permutation, with clang support.
Change 3789712 by Guillaume.Abadie
Fixes TestImage show flag with TAAU on.
#jira UE-53061
Change 3791593 by Guillaume.Abadie
Reinvalidates shaders with shader permutations.
Change 3791884 by Daniel.Wright
Added BP setter for LowerHemisphereColor
Change 3791886 by Daniel.Wright
Added LightmapType to PrimitiveComponent
* ForceVolumetric allows forcing static geometry to use Volumetric Lightmaps, which can be useful on instanced foliage where seams are prevalent. Lightmass internal caching still requires lightmap UVs and reasonable lightmap resolution.
* ForceSurface replaces bLightAsIfStatic
Improvements to Volumetric Lightmap quality needed for static geometry
* Stationary light shadowing is now dilated inside geometry
* Now doing two dilation passes since samples near geometry see inside due to ray start bias
* Refinement around geometry uses an expanded cell bounds when the geometry is going to use Volumetric Lightmaps, since cross-resolution stitching causes leaking
Lightmass debug primitives are now tied to a swarm task instead of global - allows debugging of Volumetric Lightmap tasks
Change 3792256 by Guillaume.Abadie
Fixes a bug where permutation was not actually serialised in FShader, so was ending up recompiling shader at every load.
Change 3792884 by Marcus.Wassmer
Copying //UE4/Partner-AMD to Dev-Rendering (//UE4/Dev-Rendering)
Change 3793200 by Marcus.Wassmer
Copying //UE4/Partner-IDV-SpeedTree to Dev-Rendering (//UE4/Dev-Rendering)
Speedtree 8 support
Change 3793206 by Brian.Karis
Added color grading control BlueCorrection to correct for artifacts with "electric" blues due to the ACEScg color space. Bright blue desaturates instead of going to violet.
Added color grading control ExpandGamut which expands bright saturated colors outside the sRGB gamut to fake wide gamut rendering.
ACES changes.
Change 3793344 by Marcus.Wassmer
Fix editortest compile
Change 3794285 by Guillaume.Abadie
Serializes PermutationId according to archive rendering version to avoid issues with old material that were serializing a shader map into UObject.
Change 3794307 by Guillaume.Abadie
Resaves uassets that were modified between 3789648 and 3794285
Change 3794627 by Mark.Satterthwaite
Implement two components for MTLPP, an IMP cache for Objective-C selector implementations & an interposition framework for those same selectors:
- imp_SelectorCache & friends provide the IMP caching for each of the Metal protocols which constitute most of the API, so far I've not covered the Metal classes used for the various descriptor/initializer types. Each type has its own IMPTable which caches the selector's implementation pointer and provides the mechanism to hook that implementation. As Objective-C is runtime dynamic this look up must be performed on the actual Class value returned by an object at runtime - you can't do this at compile time. Even things like NSString which appear compile-time static are really not as NSString is an alias for a class-cluster (NSString, NSMutableString, __NSInlineString and more).
- The interpose directory contains MTI* files which are the framework for interposing all the functions in Metal's runtime API - I deliberately omit the descriptor classes & read-only functions as there's no benefit to interposing them - which I can build off to create a trace tool or a superior validation layer. Right now this is Mac only as there'll be some problems to solve for iOS/tvOS due to difference in linking requirements - not insurmountable.
- Rebuild MTLPP's implementation of the C++ wrapper classes around the IMPTable's - this means we avoid all the objc_msgSend overhead for all the classes and functions whose implementations are cached. Right now the IMPTable is going to incur a look-up for all non-copy/move constructors which is suboptimal - ideally the Metal IMPTables would be cached in the Device object as they will be consistent within a single Device.
- Sort out the MTLPP availability logic - it now exports the availability warnings to the caller and internally just blithely assumes it may call the functions, the caller is responsible for ensuring that calls are made only on appropriate devices & OSes. This reduces MTLPP complexity and better fits how MetalRHI works.
- Fix a number of retain/release bugs that were lying dormant in MTLPP but exposed by the switch to IMPTables.
- Add tvOS support.
Next up, put this into MetalRHI and start fixing all the fallout.
Change 3794631 by Mark.Satterthwaite
Missed updating mtlpp's build.cs for TVOS.
Change 3794651 by Uriel.Doyon
UPointLightComponent::GetUnitsConversionFactor() now takes the cone angle as parameter. This allows to fix spotlight unit conversion when using lumens.
Change 3794720 by Guillaume.Abadie
Fixes a bug in Global{Bilinear,Trilinear}ClampedSampler that was actually doing a Point sampling.
Change 3794749 by Mark.Satterthwaite
Fix mtlpp.build.cs paths.
Change 3794856 by Mark.Satterthwaite
Fix some shadowing warnings.
Change 3795484 by Daniel.Wright
Implemented the Spherical Harmonic windowing algorithm from 'Stupid Spherical Harmonics (SH) Tricks'
New WorldSettings Lightmass property VolumetricLightmapSphericalHarmonicSmoothing controls the global amount of smoothing applied
Change 3795590 by Brian.Karis
Area light fixes
Fixed order of operations. This helps mixing of SourceRadius, SourceLength, and SoftSourceRadius.
Change 3796832 by Marcus.Wassmer
Correct shouldcache condition for new resolve shader
Change 3796884 by Marcus.Wassmer
Doing it right this time.
Change 3797196 by Mark.Satterthwaite
More updates to MTLPP to make things simpler and reduce the number of spurious Objective-C warnings that are emitted because of the way we are using the runtime.
Change 3797200 by Daniel.Wright
Lightmass now uses the highest density VolumetricLightmapDensityVolume settings that affect any part of a cell
Change 3797221 by Daniel.Wright
Reduced default SphericalHarmonicSmoothing based on RoboRecall tests. Now only active with strong direct lighting from static lights by default.
Change 3797411 by Brian.Karis
Disable ExpandGamut for old tone mapper.
Change 3797462 by Mark.Satterthwaite
More build warnings silenced after changing to the lowest possible deployment target OS for each library.
Change 3797585 by Mark.Satterthwaite
Range-based-For support in the NSArray wrapper.
Change 3797836 by Mark.Satterthwaite
Even more forward-declarations to avoid system headers poking through to the including code from mtlpp.
Change 3798027 by Mark.Satterthwaite
Fix handling of nil objects, on which no functions may be called, command-buffer retention and IMP declaration.
Change 3798154 by Mark.Satterthwaite
Fix some egregious memory leaks that rewriting to use mtlpp exposed before we carry on - don't want these slipping into 4.19.
Change 3800990 by Mark.Satterthwaite
Typedef all the completion-handler callback types in mtlpp to make future me's life easier.
Change 3801400 by Chris.Bunner
Improving automated test errors on failure to generate report data.
Change 3801726 by Mark.Satterthwaite
Correct some function availability and the command-buffer error status in mtlpp.
Change 3801808 by Chris.Bunner
Added DefaultScalability.ini to EngineTest that forces all quality levels to Engine default Epic for now to improve consistency.
Change 3801862 by Marcus.Wassmer
Update automated tests with color gamut change
Change 3802214 by Chris.Bunner
When running automated tests in and editor-locked PIE viewport, skip resizing as the editor can't handle this.
Added bindable delegate called when ScreenshotRequest is processed - Useful to allow screenshots to override and restore settings per capture.
#jira UE-53188
Change 3802243 by Chris.Bunner
Added button to automated test screenshot browser to add or replace all outstanding test reports if appropriate.
DeleteAllReports button is now only enabled whilst there are reports in the list.
Change 3802372 by Chris.Bunner
Updating more test screenshots.
Change 3803683 by Chris.Bunner
Adding more logging and multiple attempts to automated test report network save.
Added small wait on repeated operations that are known to fail.
Change 3803826 by Rolando.Caloca
DR - vk - Fix merge issue
Change 3804181 by Chris.Bunner
Tentative fix for CIS test failure.
Change 3804236 by Chris.Bunner
Additional logging for case where file write silently fails, report platform-specific error.
Change 3804303 by zachary.wilson
Cleaning up assets in QAGame saved with empty engine versions to resolve warnings seen when launching on
Change 3804410 by Chris.Bunner
Added additional logging when automated screenshot test fails due to size mismatch.
Mismatched bounds are colored red in the delta.
Change 3804455 by Mark.Satterthwaite
Fix a small number of persistent memory leaks on the Mac build that slowly consume more and more memory as you use the Editor - interacting with menu's was particularly egregious as each NSMenu would leak after you move away.
#jira NA
Change 3804667 by Chris.Bunner
Speculative CIS fixes.
Change 3806008 by Chris.Bunner
Partially reimplementing backed-out CL 3804181 to improve consistency of how automated screenshot test settings are applied/restored.
#tests CIS preflight job 8174412
Change 3806909 by Mark.Satterthwaite
Use the vertex-shader's in-out mask to ensure that we only validate legitmate vertex-streams in Metal's DrawIndexedPrimitive implementation.
#jira UE-53046
Change 3807059 by laz.matech
Checking in QAGame Rendering Map, QA-PhysicalLightingUnits, for testing Physical Light Units.
Wanted to get this in before copy up.
#Jira none
Change 3807726 by Chris.Bunner
Removed a check that we can't fix up. The check hits unbound buffers which it assumes means a failure but is actually due to m.v.fetch. We don't have the information available to know which are which removed from the input without reading from the shader.
#jira UE-53046
Change 3807800 by Guillaume.Abadie
Fixes some warning in shader headers.
Change 3807804 by Guillaume.Abadie
Back out changelist 3807800
Change 3807807 by Guillaume.Abadie
Relands shader header warnings.
Change 3808046 by Chris.Bunner
Dropping a new automated test error back to a warning as this may lead to genuine issues being ignored in the short term.
Change 3809579 by Chris.Bunner
Back out changelist 3774677.
#jira UE-53483
Change 3809620 by Chris.Bunner
Updating animated cloth test screenshot.
Change 3803629 by Chris.Bunner
Rebuilt CornellBox and DistanceField test maps, updated screenshots.
Change 3787045 by Guillaume.Abadie
Moves some global samplers to Common.ush
Change 3809756 by Chris.Bunner
Updating animated cloth test screenshot.
[CL 3809764 by Chris Bunner in Main branch]
#rb
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3776794 by Chris.Bunner
Fixed inverted check.
Change 3778396 by Chris.Bunner
By default functional screenshot tests now enable camera cut and a fixed tonemap/exposure.
Existing tests in PostProcessing have had the FixedTonemapping flag disabled.
Updated all existing screenshots against the new fixed gamma ground truth.
Change 3778592 by Chris.Bunner
Updating PostProcess screenshots that managed to collide mid P4 add.
Change 3778793 by Chris.Bunner
Override the secondary screen percentage (used for high DPI) when taking screenshots. This is necessary for consistent results between machines.
Change 3781715 by Chris.Bunner
Updating Windows screenshots.
Change 3781717 by Chris.Bunner
Fixes for eye adaptation and tonemapping override consistency between test types and run modes.
Change 3783199 by Chris.Bunner
Added separate add/replace screenshot buttons to know if we're working with a matching platform tier or a fallback.
Change 3783228 by Chris.Bunner
When incoming screenshots are different sizes create a delta of the minimum shared dimensions but still force a failure. The UI is more consistent showing any delta, even if it's almost pure white.
Change 3783712 by Chris.Bunner
Rebuilt translucency lighting test map and updated screenshot results.
Change 3784010 by Chris.Bunner
Adding Mac-specific PostProcessing screenshots.
Change 3787456 by Chris.Bunner
Improving name matching consistency of test blacklist entries.
Change 3787522 by Chris.Bunner
Updating Mac-specific screenshots.
Change 3787583 by Chris.Bunner
Updating Mac-Specific screenshots.
Change 3787832 by Chris.Bunner
Fixing-up NaNs in two saved level's HLOD world settings.
Change 3789147 by Chris.Bunner
Updating Sequencer sub-levels which still had NaNs in World Settings.
Change 3791454 by Chris.Bunner
Deleted ancient screenshot re-introduced by Fortnite merge.
Change 3781713 by Chris.Bunner
Updating platform unique screenshots - Tessellation, fixed vs variable screenshot size, Niagara simulation.
Change 3776756 by Chris.Bunner
Initial pass at hierarchical screenshot testing.
Deleted existing platforms automated test screenshots.
Change 3784051 by Chris.Bunner
Updated CableActor screenshots for new capture defaults.
Change 3787092 by Chris.Bunner
Added blacklist as "AutomationTestBlacklist" in Engine.ini.
Formatting fix-up in existing automation test config.
Removed workaround cvar for physicalized animation tests failing on platforms.
[CL 3792526 by Chris Bunner in Main branch]
#lockdown Nick.Penwarden
#rb
============================
MAJOR FEATURES & CHANGES
============================
Change 3716887 by Chris.Bunner
[Duplicate] Added "show delta" checkbox to automated screenshot comparison viewer.
Change 3720970 by Chris.Bunner
Added more time for UDP serialization test.
Change 3722873 by Chris.Bunner
Updated screenshot comparison to handle new folder layout, can no longer assume the root folder. Was deleting pending AddNew/Replace comparison results when any were updated.
Change 3720019 by Chris.Bunner
Swapping automation screenshot test data from "Map_Test/Platform_RHI" to "Map/Test/Platform/RHI" as this allows platform folders and platform-specific tests to obey privacy rules.
Change 3720989 by Chris.Bunner
[Duplicate] Allow platforms to override the default ICU timezone calculation
[CL 3723196 by Chris Bunner in Main branch]
Added cvar for adjusting tolerance on less precise autopamted tests, AutomationTestUseRelaxedPhysicsStabilityThresholds.
Added GetConsoleVariableFloat/Int global blueprint functions.
#rb Marcus.Wassmer
#fyi James.Golding
#jira UE-48317
#lockdown Nick.Penwarden
[CL 3699491 by Chris Bunner in Main branch]
- Disable texture streaming
- AScreenshotFunctionalTest now reads back from game viewport directly when taking screenshot
- AFunctionalUIScreenshotTest now render into a custom render target using FWidgetRenderer so that UI screenshot can be captured at fixed size
- Add a new class, AScreenshotFunctionalTestBase, that handles screenshot common functions. AScreenshotFunctionalTest and AFunctionalUIScreenshotTest now derive from it
#rb Chris.Bunner
#codereview Chris.Bunner
#lockdown nick.penwarden
[CL 3647910 by Jian Ru in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3503468 by Marcus.Wassmer
Fix merge conflicts
Change 3537059 by Ben.Marsh
Fixing case of iOS directories, pt1
Change 3537060 by Ben.Marsh
Fixing case of iOS directories, pt2
Change 3608300 by Chris.Bunner
Added post process material to preview compile cache set to allow post process volume preview scene improvements.
Change 3608302 by Chris.Bunner
Fixed decal lifetime fading.
#jira UE-48400
Change 3608303 by Chris.Bunner
Updated default WritesAllPixels input to ignore dithering (as intended, was disabled due to isues at the time).
Fixed material instances returning their local data when not overridden.
#jira UE-48254
Change 3608455 by Mark.Satterthwaite
Enabling WorldPositionOffset requires disabling fast-math on Metal because the manually specified FMA's are not respected if one or more arguments is a literal which then leads to very different compiler optimisation between the depth-only shader and the base-pass shader. This change will only affect the way Metal compiles shaders.
#jira UE-47372
Change 3608462 by Rolando.Caloca
DR - Cloth vertex buffers no longer generate dummy vertices
Copy from 3608349 and 3608407
Change 3608491 by Rolando.Caloca
DR - hlsl - Fix crash when type was not found
Change 3608513 by Rolando.Caloca
DR - Default to real uniform buffers for Vulkan SM4 & SM5
Change 3608794 by Mark.Satterthwaite
Implement SV_DepthLessEqual (maybe right?) for Metal - seems to work in the ParallaxOcclusionMapping test map.
#jira UE-47614
Change 3608929 by Mark.Satterthwaite
Fix ambiguous expression compile error.
Change 3608991 by Mark.Satterthwaite
Fix a dumb bug when parsing the Metal compiler version that breaks Metal shader PCH generation on HFS+ volumes.
Change 3609090 by Uriel.Doyon
StaticMeshComponent and LandscapeComponent now register AO material mask and sky occlusion texture in the texture streamer.
Changing the current lighting scenario now triggers an update of the texture streamer, and a refresh of lighting data for instanced static meshes.
Added an option to the "liststreamingtextures" named UNKOWNREF allowing to inspect texture without references in the texture streamer.
BUILDMATERIALTEXTURESTREAMINGDATA now rebuild every shader in memory and mark for save those with different data.
MipBias now behaves the same way in shipping than in other builds.
Fixed texture resolution logic for editor tooltips and in game stats.
Change 3609659 by Richard.Wallis
Remove Eye Adaption Pixel Shader Workaround for macOS 10.11 (El Cap) Nividia.
#jira UE-48642
Change 3610552 by Mark.Satterthwaite
Optimise the constant-propagation pass in hlslcc by using a hash-table to reduce the cost of looking up the existing constant assignment instructions. The get_assignment_entry drops from 25% of runtime to 2.2% of runtime on a 4.2Ghz Quad i7 2017 iMac.
Change 3610662 by Rolando.Caloca
DR - hlsl - Fix for rwstructured buffer
Fix for floats printed as ints
Change 3610830 by Michael.Lentine
ByteAddressBuffer does not have a subtype.
Change 3610869 by Rolando.Caloca
DR - hlsl - Fix disambiguation between 1.r and 1.0.r
Change 3610982 by Mark.Satterthwaite
Use the correct code to dump Metal shader text for debugging at runtime.
Change 3610996 by Rolando.Caloca
DR - hlsl - Actual fix for 0.r
Change 3611312 by Rolando.Caloca
DR - Integrate: Improve performance of bokeh depth of field.
* Fewer instances with more work (higher quad count) per instance.
* Improves performance on RX 480 in the Infiltrator demo by 0.37 ms at 1080p and 0.50 ms at 1440p (average frame time over the beginning of the demo, including the hallway confrontation between the guard and the infiltrator, where heavy DOF is used).
* Similar optimizations may be possible for other systems that perform similar "instanced draws of quads" (e.g. virtual texture page table updates, lens blur, and velocity scatter).
Change 3611345 by Mark.Satterthwaite
Missed the hash-table destructor in previous change.
Change 3611372 by Rolando.Caloca
DR - vk - New barrier/layout api
Change 3611445 by Mark.Satterthwaite
Fix stupid bugs in MetalBackend's LoadRWBuffer helper function where the wrong type was being used - won't fix problems in the LinearTexture case though.
Change 3611686 by Mark.Satterthwaite
Remove the sampler from the Metal Linear Texture SRV path as for reasons so far unknown it doesn?â•Ÿâ•“t work with the light grid culling.
#jira UE-48881
Change 3611743 by Mark.Satterthwaite
Implement early depth test for Metal - it is implemented such that manual specification of the SV_Depth* outputs will elide the early_fragment_test qualifier as Metal does not permit both at present.
Change 3611746 by Mark.Satterthwaite
Use early fragment tests implicitly unless we perform a direct resource write or use discard - explicit depth writes always disable early fragment tests as Metal doesn?â•Ÿâ•“t allow both. This should better match D3D driver behaviour.
Change 3611756 by Mark.Satterthwaite
Missed a header file in last commit.
Change 3611836 by Mark.Satterthwaite
Fixed the use of Metal?â•Ÿâ•“s capture manager so that it doesn?â•Ÿâ•“t capture more frames than intended.
Change 3611843 by Mark.Satterthwaite
Tidy up the handling of when to increment the frame count for the Metal capture manager.
Change 3612279 by Michael.Lentine
Move FP16 Math to Public so that it can be included as part of platform which is where the other float/half defines happen.
Change 3612595 by Rolando.Caloca
DR - hlslcc - Rebuilt with CL 3611345
Change 3612665 by Rolando.Caloca
DR - Make cubemap mip barrier consistent with HZB mip barriers
Change 3612758 by Daniel.Wright
FColor usage comment
Change 3612980 by Rolando.Caloca
DR - hlsl - Do not overflow ints
Change 3613068 by Rolando.Caloca
DR - vk - Initial fix for transition validation warnings
Change 3613115 by Daniel.Wright
Volumetric lightmap voxels are now always cubes
Bricks outside of any Lightmass Importance Volume will never be refined
Change 3613124 by zachary.wilson
Enabling Eye-Adaptation in TM-ShaderModels.
Change 3613205 by Mark.Satterthwaite
Fully disable linear textures in Metal - they simply aren't performant. Instead we'll have to use helper functions to dynamically type-cast appropriately within the shader. This is currently only configured for a handful of UAV types and will need to be extended.
Change 3613208 by Mark.Satterthwaite
Add code to MetalBackend to promote half types to float for math operations to avoid compiler errors.
Change 3613354 by zachary.wilson
Fixing up the Bloom_FFT map. Renaming to fit qa conventions, updating content and improving workflow.
Change 3613409 by Rolando.Caloca
DR - vk - Layout as part of descriptor writes
Some access flag warning fixes
Change 3613518 by Daniel.Wright
Added 'Render Unbuilt Preview Shadows in game' rendering project setting and r.Shadow.UnbuiltPreviewInGame cvar
Change 3613610 by Daniel.Wright
Volumetric lightmap visualization sphere size is now a fraction of the corresponding brick world size
Change 3613651 by Daniel.Wright
[Copy] Fixed landscape in the Global Distance field on PS4. Multiple updates to a vertex buffer using BUF_Dynamic cause a race condition on PS4 with no assert.
Also added shrinking for GDistanceFieldUploadData which saved 15Mb.
Change 3613696 by Mark.Satterthwaite
Add the Metal SRV format for Index buffers so that they can be properly type-cast inside the shader. Fixes recompute tangents with latest changes.
Change 3613697 by Rolando.Caloca
DR - vk - Fix missing layout
Change 3613922 by Rolando.Caloca
DR - vk - Some fixes for layout/transitions
- Disable GSupportsDepthFetchDuringDepthTest on desktop as the deferred renderer is not copying the aux depth in the right spot and will be removed
Change 3614009 by Mark.Satterthwaite
TPS Approved: Integrating the MIT-licensed mtlpp C++ Metal wrapper from Nikolay Aleksiev which will slowly replace previous Metal API wrappers in MetalRHI.
Change 3614015 by Mark.Satterthwaite
Initial extensions to mtlpp:
- Fixed over retention of alloc-init'd objects.
- Added 10_13 & 11_0 availablity macros.
- Started, but have not yet finished adding new Metal API function wrappers.
Change 3614909 by Rolando.Caloca
DR - Fix static analysis
Change 3614916 by Michael.Lentine
Add function to convert FP32 to FP16
Change 3614957 by Mark.Satterthwaite
mtlpp declarations for macOS 10.13 & iOS 11 Metal features - no matching definitions yet.
Change 3614995 by Mark.Satterthwaite
Revert all changes to project config's from Rhino that should not have come back to Dev-Rendering, keeping only the solitary change to Metal shader standard necessary for ShowdownDemo.
Change 3615035 by Rolando.Caloca
DR - Generate mips using shader for HZB
Change 3615561 by Rolando.Caloca
DR - Fix deprecation warning
Change 3615787 by Mark.Satterthwaite
Only emit min. OS version specification into the Metal shader bytecode for macOS as we share shaders between iOS & tvOS and this option inhibts that.
#jira UE-48919
Change 3616317 by Mark.Satterthwaite
Make TonemapperConfBitmaskPC the proper size so we dn't attempt to access uninitialized memory.
Change 3616357 by Mark.Satterthwaite
And fix some compile errors...
Change 3616473 by Rolando.Caloca
DR - Render pass api minor changes
Change 3616518 by Mark.Satterthwaite
Fix a merge snafu where dead code was retained where it shouldn't be.
#jira UE-48472
Change 3616706 by Rolando.Caloca
DR - Vulkan fixes (integration from Vulkan working branch)
- Fix for editor outline
- Fix for profilegpu
Change 3616770 by Rolando.Caloca
DR - vk - Mark GIsGPUCrashed on device lost
Change 3616993 by Daniel.Wright
IndirectLightingCacheQuality respects VolumetricLightingMethod
Change 3616996 by Daniel.Wright
Volumetric Lightmap show flag is respected by Volumetric Fog
Change 3616999 by Daniel.Wright
Fixed ObjectRadius in Volume domain materials
Change 3617777 by Rolando.Caloca
DR - Fix static analysis warning
Change 3617863 by Guillaume.Abadie
PR #3875: Removed Duplicated "RHI" Module Dependency (Contributed by DavidNSilva)
#jira UE-48159
Change 3618133 by Rolando.Caloca
DR - vk - Set general layout for compute shader resources
- Assume transitions to writable imply end render pass
Change 3618292 by Michael.Lentine
Add support for Expressions, Jump Statments, and Structs.
Change 3618326 by Rolando.Caloca
DR - vk - Fix transition flags
Change 3618408 by Daniel.Wright
Lightmass skylight solver improvements
* Lightmass uses a filtered cubemap to represent the skylight instead of a 3rd order Spherical Harmonic. Directionality in shadowed areas is improved. Mip level is chosen based on the ray differential for anti-aliasing.
* Multiple skylight and emissive bounces are now supported with a radiosity solver, controlled by NumSkyLightingBounces in Lightmass WorldSettings. More bounces results in longer build times, and the radiosity time is not distributable.
* The mapping surface cache is now rasterized with supersampling, reduces incorrect darkness in corners
* Combined direct lighting, photon irradiance, skylight radiosity and diffuse in the mapping surface cache so final gather rays only have to do one memory fetch, speeds up lighting builds by 7%.
* Added support for Embree packet tracing although no solver algorithms use it yet
Change 3618413 by Daniel.Wright
Swarm hands out the most expensive tasks in roughly a round robin ordering among distribution agents. Lightmass processing of a single task is multithreaded, so ideally the most expensive tasks are evenly distributed among active agents. This has the biggest impact in small scenes with 10's of high resolution lightmaps, and with a distribution farm. Build time in one scene went from to 113s -> 47s.
Change 3618439 by Mark.Satterthwaite
Fix the assert in hlslcc when we have saturate(int) and the shader language spec. supports a native saturate intrinsic.
Change 3618468 by Rolando.Caloca
DR - vk - Fix copy to non render target surface
Change 3618696 by Daniel.Wright
Worked around Lightmass crash callstacks not getting reported back to the editor
Change 3618779 by Mark.Satterthwaite
mtlpp definitions for a few of the new calls & fixing the max. number of samplers it assumes.
Change 3618789 by Daniel.Wright
Added missing file
Change 3618816 by Daniel.Wright
Another missing file
Change 3618855 by Rolando.Caloca
DR - vk - Show user debug markers when using dump layers
- Remove old defines
Change 3618887 by Rolando.Caloca
DR - Fix for missing transition to readable for blur widget. Was causing corruption on Vulkan.
Change 3618999 by Mark.Satterthwaite
Definitions for Metal's new CaptureManager & CaptureScope classes.
Change 3619790 by Jian.Ru
Add some debug info
#jira UE-48710
Change 3619834 by Rolando.Caloca
DR - vk - static analysis fix
Change 3619952 by Rolando.Caloca
DR - vk - Static analysis not smart enough...
Change 3620191 by Jian.Ru
Revert 3584245 to prevent focus stealing
#jira UE-49044
Change 3620402 by Mark.Satterthwaite
Remaining Metal definitions for mtlpp.
Change 3620803 by Brian.Karis
Removed faceting bug I introduced to Dither Opacity Mask. Removes the attempt to make opacity stack properly.
Change 3620904 by Michael.Lentine
Change the order of static and const
Change 3620975 by Rolando.Caloca
DR - Updated Vulkan headers to SDK 1.0.57.0
Change 3621026 by Rolando.Caloca
DR - Remove unused type
- Force recompile with new Vulkan headers
Change 3621070 by Rolando.Caloca
DR - glslang - Fix pdb option
Change 3621157 by Arciel.Rekman
Added files to cross-build glslang on Windows.
(Edigrating //UE4/Main/...@3621127 to //UE4/Dev-Rendering/...)
Change 3621194 by Rolando.Caloca
DR - glslang - Update to 1.0.57.0
- Fix some tab/whitespace mismatch
Change 3621225 by Rolando.Caloca
DR - Revert glslang (Back out changelist 3621194)
Change 3621254 by Mark.Satterthwaite
Duplicate 3610656 and revert the incorrect merge from the Rhino task stream. Fixes EyeAdaptation on all clang platforms properly thanks to RCL.
Change 3621261 by Mark.Satterthwaite
Trivial FMetalStateCache optimisations - won't help much but equally they shouldn't hurt.
Change 3621262 by Mark.Satterthwaite
Correct the handling of MSAA target in Desktop Forward for iOS - now the problem is that iOS always creates an internal resolve target so which texture to bind depends on the shader parameter type. Not sure (yet) how best to solve that.
Change 3621263 by Mark.Satterthwaite
Don't mandate Mobile Metal for projects that have Metal MRT enabled.
Change 3621301 by Rolando.Caloca
DR - Unity build fix
Change 3621349 by Mark.Satterthwaite
Fix a bug in MetalBackend that was omitting the depth-output variable from the hlslcc signature if the semantic was SV_DepthLessEqual rather than SV_Depth.
Change 3621546 by Uriel.Doyon
Refactor of the texture 2D mip update logic to offload more work on the async thread.
#jira UE-45332
#jira UE-45789
Change 3622210 by Rolando.Caloca
DR - Do not store DDC data if static mesh failed to build
#jira UE-48358
Change 3622349 by Arciel.Rekman
Better build script for Linux glslang and a bugfix.
(Edigrating CL 3622235 from //UE4/Main/... to //UE4/Dev-Rendering/...)
Change 3622401 by Rolando.Caloca
DR - vk - Integration
- Support for r.Vulkan.ProfileCmdBuffers
Change 3622506 by Rolando.Caloca
DR - vk - Back out changelist 3622401
Change 3622521 by Mark.Satterthwaite
Support disabling V-Sync in MetalRHI on macOS 10.13+.
Change 3622910 by Rolando.Caloca
DR - static analysis fix
Change 3622964 by Mark.Satterthwaite
Fix generation of .metallib on local Macs and exclude .metallib files from the pak - they must always be loaded from disk.
#jira UE-48193
Change 3622986 by Mark.Satterthwaite
A couple more trivial optimisations to MetalRHI for iOS:
- Metal page size is 4k but only buffers under 512 bytes should go through set*Bytes on iOS to balance CPU cost.
- On iOS the minimum buffer size should therefore be 1k and on Mac 4k as nothing else makes much sense.
- No need to rebind uniform buffers if to the same slot - it just wastes cycles.
Change 3623266 by Rolando.Caloca
DR - Fix GL4 rendering
#jira UE-49187
Change 3623377 by Daniel.Wright
Volume materials applied to static meshes operate on the object's bounding sphere
Change 3623427 by Mark.Satterthwaite
Fix MetalViewport compile errors on Xode 8.3.
#jira UE-49231
Change 3623443 by Daniel.Wright
Fixed out of bounds crash in lightmass
Change 3623751 by Daniel.Wright
Volume materials on static meshes now voxelize the mesh's Object space bounding box
Change 3625142 by Guillaume.Abadie
PR #2992: Fixing aspect ratio issue of SceneCapture2D rendering in "Ortho" camera mode (Contributed by monsieurgustav)
Change 3625983 by Jian.Ru
Fix a LPV race condtion due to parallel RSM draw-call submission
#jira UE-48247
Change 3626015 by Jian.Ru
Small fix to 3625983
Change 3626294 by Michael.Trepka
Copy of CL 3535792 and 3576637
Added support for changing monitor's display mode on Mac in fullscreen mode. This greatly improves performance on Retina screens when playing in resolutions lower than native.
Fixed a problem with incorrect viewport size being set in windowed fullscreen in some cases. Also, slightly improved screen fades for fullscreen mode transitions on Mac.
#jira UE-48018
Change 3626532 by Marcus.Wassmer
Fix divide by 0 crash when GPU timing frequency not available for whatever reason.
Change 3626548 by Ryan.Brucks
KismetRenderingLibrary: Added EditorOnly function for creating static textures from Render Targets. Has options for Mip and Compression Settings
Change 3626874 by Mark.Satterthwaite
Fix Metal 2.0 compilation.
Change 3626997 by Rolando.Caloca
DR - vk - cis fix
- Initial RGBA16 readback
Change 3627016 by Mark.Satterthwaite
Workaround more of Metal's unfortunate tendency to re-associate float mul/add/sub operations - this time from Metal's own standard-library.
Change 3627040 by Brian.Karis
Removed old rasterized deferred reflection env path.
Removed reflection compute shader. Replaced with PS. Small perf gain.
Change 3627055 by Mark.Satterthwaite
No MSAA support on Intel Metal or iOS Desktop Forward for the moment as neitehr work and I don't want to have lots of crashes out in the wild until we have a solution.
Change 3627057 by Mark.Satterthwaite
Make SCW's directcompile not fall over with Metal when there are compilation errors.
Change 3627083 by Mark.Satterthwaite
Invalidate Metal shaders so QA testing picks up the most recent changes.
Change 3627788 by Chris.Bunner
[Duplicate, CL 3627751] - VisibleExpressions static switch value evaluation needs to handle reroute nodes rather than only verify first expression.
Change 3627834 by Rolando.Caloca
DR - cis fix
Change 3627847 by Rolando.Caloca
DR - 4th try to fix static analysis
Change 3627877 by Guillaume.Abadie
Works arround a HLSLCC bug in a SimpleComposure project's material where x != x does not work for an unknown reason yet.
#jira UE-48063
Change 3628035 by Marcus.Wassmer
Duplicate 3620990
Smarter scenecapture allocation behavior.
Change 3628204 by Daniel.Wright
Fixed denormalization scale on one of the 2nd SH band of volumetric lightmaps
Change 3628217 by Mark.Satterthwaite
Fix InfiltratorForward project defaults so that iOS will package.
Change 3628515 by Arne.Schober
DR - [UE-49213] - Fix case where HZB was not generated for SSR and SSAO when Occlusion culling was disabled.
#RB Marcus.Wassmer
Change 3628550 by Chris.Bunner
Merge fixes.
Change 3628597 by Chris.Bunner
Merge fixes.
Change 3628656 by Michael.Trepka
One more workaround for a bug in StandardPlatformString.cpp. It doesn't handle %lf format correctly, parsing it as long double instead of ignoring the 'l' format sub-specifier.
Change 3628685 by Daniel.Wright
CPU interpolation of Volumetric Lightmaps for the mobile renderer. They use a scene cache based on interpolation position, since the precomputed lighting buffer for movable objects is recreated every frame.
Change 3629094 by Ryan.Brucks
Fixes to RenderTargetCreateStaticTexture2DEditorOnly with additional error checks
#RB none
Change 3629223 by Rolando.Caloca
DR - Rollback //UE4/Dev-Rendering/Engine/Source/Runtime/VulkanRHI to changelist 3627847
Change 3629491 by Rolando.Caloca
DR - Revert back to emulated uniform buffers on SM4/SM5
Change 3629663 by Daniel.Wright
Fixed NaN when capsule shadow direction is derived from volumetric lightmap with completely black lighting
Change 3629664 by Daniel.Wright
Don't render dynamic indirect occlusion from mesh distance fields when operating on a movable skylight, since DFAO fills that role
Change 3629708 by Rolando.Caloca
DR - vk - Redo some changes from DevMobile
3601439
3604186
3606672
3617383
3617474
3617483
Change 3629770 by Mark.Satterthwaite
Fix a mobile Metal shader compilation error when using the FMA workaround for "cross" which should only be applied if the min. Metal version is 1.2 (as FMA is not known to work prior to this).
Change 3629793 by Daniel.Wright
Fixed VolumetricLightmapDetailCellSize not being respected in small levels, causing too much volumetric lightmap density and memory
Change 3629859 by Mark.Satterthwaite
macOS 10.12 also had problems with MSAA in forward rendering - so only permit it to work on macOS 10.13 and above.
Change 3630790 by Mark.Satterthwaite
Move RHISupportsMSAA so that the Metal related complications for when it is viable can be hidden within.
Change 3630990 by Rolando.Caloca
DR - vk - Redid CL 3617437 (optimize number of Buffer Views, eg 165 to 58)
Change 3631071 by Mark.Satterthwaite
Fix a small gotcha in a change from Dev-Mobile: for MetalRHI we need to explicitly configure the ShaderCacheContext for the immediate/device context after initialising the shader-cache.
#jira UE-49431
Change 3631076 by Rolando.Caloca
DR - vk - Redo 3617574, reduce number of render pass objects created
Change 3631250 by Mark.Satterthwaite
Make another Metal warning a Verbose log instead as it isn't interesting unless you are me.
Change 3631911 by Chris.Bunner
Back out changelist 3628035.
#jira UE-49364, UE-49365
Change 3632041 by Mark.Satterthwaite
Fix cloth rendering on Metal - some of the data in FClothVertex is uint but we load it from a float buffer. This could be due to a bug in Metal's as_type<uint4>() or it could be that Xcode 9's compiler is now finally enforcing Metal's official flush-to-zero-on-load semantics for denorms - it isn't immediately obvious.
#jira UE-49439
Change 3632261 by Brian.Karis
SM4 fallback for reflection captures.
Change 3632281 by Mark.Satterthwaite
Fix an intermittent assert on startup when the AVFoundation movie player gets the QAGame TM-ShaderModels video ready to play prior to the rendering thread being back online when resizing the window. This is done by deferring the processing of AVFoundation events to the game-thread where it won't cause a threading violation.
Change 3632382 by Rolando.Caloca
DR - vk - Fix clang warning
Change 3633338 by Chris.Bunner
Static analysis/Linux compile fix.
#jira UE-49502
Change 3633616 by Jian.Ru
Force alpha to 0xff for functional UI screenshot tests
#jira UE-48266
Change 3633818 by Daniel.Wright
Better indirection texture clamping and asserts
Change 3634319 by Mark.Satterthwaite
Stop FVolumetricLightmapDataLayer ::Discard which is invoked by the Editor RHI during texture-upload from chucking the backing data when in the Editor - because if we do that then cooking will serialise an empty array. This was only apparent on Mac because Metal always invokes Discard on BulkDataInterfaces and D3D11 never does.
#jira UE-49381
Change 3634613 by Rolando.Caloca
DR - Call discard on bulk data for textures
#jira UE-49533
Change 3634654 by Mark.Satterthwaite
Fixes for broken iOS builds:
- Fix RHIGetShaderLanguageVersion returning the wrong version for iOS Metal if the Mac version had already been queried - this has been wrong for a long while.
- Remove the precise:: qualifier for Metal's fma intrinsic - it isn't necessary and breaks on older OSes.
#jira UE-49381
Change 3634820 by Mark.Satterthwaite
Change the hash-function for the preprocessed HLSL source in FMetalShaderOutputCooker to reduce risk of hash-collisions. Fixes one cause of UE-49381 and reveals an underlying driver bug on iOS 9 with runtime-compiled text shaders *only*.
#jira UE-49381
Change 3634821 by Mark.Satterthwaite
Force Metal shaders only to recompile by incrementing the format version.
[CL 3635058 by Chris Bunner in Main branch]
#lockdown nick.penwarden
#rb none
Change 3235667 on 2016/12/14 by Max.Preussner
Media: Moved enums into separate header file, so they can be shared
Change 3259266 on 2017/01/16 by Max.Preussner
Core: Added timespan ratio
Change 3267229 on 2017/01/21 by Max.Preussner
Editor: Fixed texture samplers in materials not getting notified when sRGB mode changed
Change 3274773 on 2017/01/27 by Max.Preussner
Core: Added TLruCache template
Change 3281579 on 2017/02/01 by Max.Preussner
Core: Added scalar division to FTimespan
Change 3289522 on 2017/02/07 by Max.Preussner
MediaAssets: Added looping for play lists
Change 3290664 on 2017/02/07 by Max.Preussner
Engine: Moved UTexture material notification code into separate function, so it can be used by derived classes.
Change 3290688 on 2017/02/07 by Max.Preussner
MediaAssets: Notifying materials when media texture properties changed.
Change 3291171 on 2017/02/07 by Max.Preussner
MediaAssets: Filtering unused UTexture properties
Change 3291229 on 2017/02/07 by Max.Preussner
ImgMedia: Use displayWindow instead of dataWindow due to bug in OpenEXR with data window min < 0
Change 3298520 on 2017/02/11 by Max.Preussner
Sequencer: Fixed skylight and reflection components off by one frame in PIE
Change 3298778 on 2017/02/12 by Max.Preussner
MediaUtils: Experimenting with dynamic pitch adjustment
Change 3298987 on 2017/02/13 by Max.Chen
Editor: Add matrix and transform properties to property editor test object
Change 3298997 on 2017/02/13 by Max.Chen
Editor: It's now possible to specify Units and ForceUnits meta-data on struct properties
- Doing so will cause any child numeric and struct properties to use these units by default (unless another unit was specified)
- Added percentage unit type
- Multiplier unit types can now be converted between
Change 3298998 on 2017/02/13 by Max.Chen
Editor: Conversion between multiplier (1.5x) and percentage (150%) units is now possible
Change 3348678 on 2017/03/15 by Max.Preussner
Media: Added Buffering media event
Change 3355268 on 2017/03/20 by Max.Preussner
Core: TQueue documentation updates
Change 3359055 on 2017/03/22 by Max.Preussner
Portal: Removed dependency to Messaging.h
Change 3359060 on 2017/03/22 by Max.Preussner
Messaging: Modernization pass
- added missing includes & forward declarations
- include what you use
- deprecated shared pointer typedefs
- replaced some delegates with callback interfaces
- documentation fixes
Change 3359189 on 2017/03/22 by Max.Preussner
Automation: Modernization pass
- include what you use
- removed molothic header
- documentation fixes
#upgradenotes: IAutomationWorkerModule.h is now in the module's public root directory
Change 3359718 on 2017/03/22 by Max.Preussner
Messaging: Moved common helper classes into MessagingCommon module
#upgradenotes: If you use the common helper classes, replace "Messaging" with "MessagingCommon" in your Build.cs files and remove the "Helpers/" subdirectory from your include statements (unless you actually
include header files from "Messaging", in which case you need to keep "Messaging" and add "MessagingCommon").
Change 3359793 on 2017/03/23 by Max.Preussner
TargetDeviceServices: Modernization pass
- include what you use
- removed boilerplate header
- deprecated selected shared pointer typedefs
- reorganized files
- documentation fixes
Change 3361028 on 2017/03/23 by Max.Preussner
DeviceManager: Modernization pass
- include what you use
- reduced shared pointer typedef usage
- documentation fixes
Change 3361197 on 2017/03/23 by Max.Preussner
Messaging: Waking up message router thread on shutdown
Change 3361246 on 2017/03/23 by Max.Preussner
AutomationWindow: Removed boilerplate header
#upgradenotes: Replace includes of AutomationWindow.h with IAutomationWindowModule.h
Change 3361428 on 2017/03/23 by Max.Preussner
AutomationController: Removed boilerplate header
#upgradenotes: Instead of AutomationController.h, include the individual interface headers that you actually use. Remove the "Interfaces/" subdirectory from existing interface inclusions.
Change 3363206 on 2017/03/24 by Max.Preussner
ProfileLauncher: Modernization pass
- include what you use (selected files)
- reduced shared pointer typedef usages
- removed dead code
- cleaned up file organization
- documentation fixes
Change 3363290 on 2017/03/24 by Max.Preussner
LauncherServices: Removed boilerplate header
#upgradenotes: Instead of including LauncherServices.h, include the ILauncherXXX.h files that you actually use. Remove the "Interfaces/" subdirectory from existing ILauncherXXX.h includes
Change 3363305 on 2017/03/24 by Max.Preussner
LauncherCheck: Removed boilerplate header
#upgradenotes: Include ILauncherCheckModule.h instead of LauncherCheck.h. Remove "Interfaces/" subdirectory from existing ILauncherCheckModule.h inclusions
Change 3363708 on 2017/03/24 by Max.Preussner
ImageWrapper: Removed boilerplate header
#upgradenotes: Instead of including ImageWrapper.h, include the actual IImageWrapperXXX.h files that you use. Remove the "Interfaces/" subdirectory from existing IImageWrapperXXX.h includes
Change 3363966 on 2017/03/24 by Max.Preussner
ImageWrapper: Modernization pass
- include what you use
- reorganized internal files
- documentation fixes
Change 3364579 on 2017/03/24 by Max.Preussner
ImageWrapper: Deprecated shared pointer typedef and removed usages
#upgradenotes: Please use TSharedPtr<IImageWrapper> instead of IImageWrapperPtr
Change 3364582 on 2017/03/24 by Max.Preussner
NetworkFileSystem: Removed monolithic boilerplate header
#upgradenotes: Instead of including NetworkFileServer.h, include the INetworkFileXXX.h headers that you actually use. Remove the "Interfaces/" subdirectory from existing INetworkFileXXX.h includes
Change 3381440 on 2017/04/05 by Max.Preussner
Oculus: Removed illegal pragmas
Change 3391731 on 2017/04/12 by Max.Preussner
ImgMedia: Added support for BMP, JPG and PNG image sequences
Change 3401146 on 2017/04/19 by Max.Preussner
Core: Cleanup pass for FTimespan usages; updated documentation
When initializing time span values from single components, consider using the FromHours, FromMinutes, FromSeconds, Zero, MinValue and related methods instead of calling the overloaded constructors as they will make
your code easier to read and understand.
Change 3401504 on 2017/04/20 by Max.Preussner
MCP: Fixed incorrect FTimespan usage of GetMilliseconds instead of GetTotalMilliseconds
Change 3401833 on 2017/04/20 by Max.Preussner
Core: Various improvements to FTimespan
- added proper serialization
- updated documentation
- access fractions as milli-, micro- or nanoseconds
- removed the following string formatters as they were not useful: %D %H %M %S %F
- updated documentation
#upgradenotes: The %D string formatter (previously total number of days) is now the zero-padded days component of the time span. Time spans are now always exported and stringified with a leading plus or minus sign.
#jira UE-43990
#jira UE-44163
Change 3437543 on 2017/05/12 by Max.Preussner
PS4Media: Added audio error codes conversion
Change 3446564 on 2017/05/18 by Max.Preussner
Networking: Fixed nullpointer crash if socket initialization fails
Change 3459978 on 2017/05/25 by Max.Preussner
ImgMedia: Renamed frame cache to frame loader
Change 3463311 on 2017/05/26 by Max.Preussner
Core: Added iterators & predicate based methods to LRU Cache
Change 3464452 on 2017/05/29 by Max.Preussner
ImgMedia: Added video sample output
Change 3464468 on 2017/05/29 by Max.Preussner
Media: Added separate cache visualization for loaded and cached samples
Change 3464592 on 2017/05/29 by Max.Preussner
Core: Added TLruCache::FindAndTouch
Change 3464607 on 2017/05/29 by Max.Preussner
Core: Added TRange::Inclusive / ::Exclusive
Change 3464608 on 2017/05/29 by Max.Preussner
Media: Fixed incorrect upper bound in support play rates of various players
Change 3466732 on 2017/05/30 by Max.Preussner
ImgMedia: Added image compression type to info string
Change 3466871 on 2017/05/31 by Max.Preussner
WmfMedia: Fixed session capabilities not showing up; added initialization logging
Change 3467785 on 2017/05/31 by Max.Preussner
MfMedia: Fixed sample stride calculated from media input instead of output
Change 3467963 on 2017/05/31 by Max.Preussner
WmfMedia: Reordered media sub-type string conversion to fix some tracks being reported incorrectly
Change 3468110 on 2017/05/31 by Max.Preussner
WmfMedia: Added MPEG-2 media sub types to utils
Change 3468516 on 2017/05/31 by Max.Preussner
AndroidMedia: Allow mediaplayer audio to be disable on Android (UE-45570)
Change 3468554 on 2017/05/31 by Max.Preussner
MediaAssets: Added AutoClear option to automatically clear media texture when media is unloaded
Change 3468627 on 2017/05/31 by Max.Preussner
ImgMedia: Allowing for auto-selection of EXR decoder thread count
Change 3468648 on 2017/05/31 by Max.Preussner
ImgMedia: Reorganized OpenExrWrapper files
Change 3471789 on 2017/06/02 by Max.Preussner
WmfMedia: Fixed potential concurrency issue in session state management
Change 3472918 on 2017/06/03 by Max.Preussner
Core: Allowing zero sized LRU cache; added default constructor
Change 3472919 on 2017/06/03 by Max.Preussner
Media: Added pre-Slate tick stage; renamed some functions; continued to implement sample caching
Change 3473704 on 2017/06/05 by Max.Preussner
AndroidMedia: Added settings class
Change 3474407 on 2017/06/05 by Max.Preussner
AndroidMedia: Implemented video sample processing
Change 3474934 on 2017/06/05 by Max.Preussner
ImgMedia: Fixed crash due to deleting loader work items twice (UE-45705)
#jira UE-45705
Change 3476925 on 2017/06/06 by Max.Preussner
Media: Added return values to media view interface; documentation fixes
Change 3477158 on 2017/06/06 by Max.Preussner
SwitchMedia: Implemented sample pooling
Change 3477201 on 2017/06/07 by Max.Preussner
PS4Media: Implemented video sample pooling
Change 3481470 on 2017/06/08 by Max.Preussner
Media: Fixed time stamps not set in recycled texture samples
Change 3481472 on 2017/06/08 by Max.Preussner
MediaAssets: Fixed no video samples fetched while player is in buffering state
Change 3481473 on 2017/06/08 by Max.Preussner
MediaUtils: Added default constructor to MediaSampleQueue
Change 3481584 on 2017/06/08 by Max.Preussner
MediaUtils: Paused state is considered forward for sample lookup as this is the common case.
Change 3481588 on 2017/06/08 by Max.Preussner
PS4Media: Redesigned the PS4 media player to support async file loading & track switching
Change 3481627 on 2017/06/08 by Max.Preussner
PS4Media: Opening media sources in thread pool if not precaching
Change 3481666 on 2017/06/08 by Max.Preussner
ImgMedia: Fixed SequencePath property file picker always opening default path
Change 3481669 on 2017/06/08 by Max.Preussner
ImgMedia: Fixed crash when quering cache state of empty image sequence
Change 3481685 on 2017/06/08 by Max.Preussner
ImgMedia: Fixed EXR reader failing to play slow loading sequences (UE-45719)
#jira UE-45719
Change 3483623 on 2017/06/10 by Max.Preussner
Media: Added getters for 360 view settings; added support for relative view updates
Change 3483624 on 2017/06/10 by Max.Preussner
Media: Added Blueprint support for 360 videos
Change 3483626 on 2017/06/10 by Max.Preussner
MediaPlayerEditor: Added 360 video mouse controls; broke out viewport widget into separate class.
Change 3483627 on 2017/06/10 by Max.Preussner
Core: Using system start time instead of current time for renamed log file names
Change 3483630 on 2017/06/10 by Max.Preussner
Core: Grouping log files by log name and processing each group separately when deleting old log files
Change 3483816 on 2017/06/10 by Max.Preussner
WmfMedia: Detecting audio device availability to prevent lockup of audio tracks
Change 3483939 on 2017/06/11 by Max.Preussner
AvfMedia: Finished Media Framework 3.0 upgrade
- overhauled track switching
- removed render thread flushes
- reduced nesting
- code cleanup pass
Change 3483940 on 2017/06/11 by Max.Preussner
Media: Consistent track switching behavior across platforms
Change 3484172 on 2017/06/11 by Max.Preussner
MediaPlayerEditor: Removed obsolete asset type actions
Change 3484180 on 2017/06/11 by Max.Preussner
MediaPlayerEditor: Fixed media player info overlays not visible during mouse capture
Change 3484248 on 2017/06/11 by Max.Preussner
MediaAssets: Media players now always have a playlist
Change 3484249 on 2017/06/11 by Max.Preussner
MediaPlayerEditor: Added UI controls to Playlist tab
Change 3484250 on 2017/06/11 by Max.Preussner
Media: Implemented overlay sample caching
Change 3484252 on 2017/06/11 by Max.Preussner
WmfMedia: Enabled support for .smi and .sami subtitle files
Change 3485433 on 2017/06/12 by Max.Preussner
ImgMedia: Enabled plug-in on all platforms; enabled EXR only on platforms that support it
Change 3485720 on 2017/06/12 by Max.Preussner
MediaPlayerEditor: Added ability to save playlists
Change 3485828 on 2017/06/12 by Max.Preussner
AvfMedia: Thread-safe ticking of video sampler; ticking audio processing on high frequency thread
Change 3485926 on 2017/06/12 by Max.Preussner
MediaUtils: Draining all unconsumed samples at the end of a frame
Change 3486043 on 2017/06/12 by Max.Preussner
Media: Consistent behavior for playlist navigation (UE-45964)
#jira UE-45964
Change 3486104 on 2017/06/12 by Max.Preussner
MediaPlayerEditor: Implemented simple overlay text positioning
Change 3486145 on 2017/06/12 by Max.Preussner
AndroidMediaPlayer: Moved video sample handling into render thread
Change 3486147 on 2017/06/12 by Max.Preussner
MediaPlayerEditor: Moved overlay texts into separate layer
Change 3486188 on 2017/06/12 by Max.Preussner
Media: Enabling media factory modules in Editor for all players
Change 3486223 on 2017/06/12 by Max.Preussner
Media: Defaulting players to select first audio and video tracks by default
Change 3486473 on 2017/06/13 by Max.Preussner
Media: Buffering is no longer a media player state, but handled separately (for players that can buffer while playing)
Change 3486475 on 2017/06/13 by Max.Preussner
MediaPlayerEditor: Showing busy bar when buffering or preparing
Change 3487237 on 2017/06/13 by Max.Preussner
AndroidMedia: Fixed video sample not getting processed on render thread
Change 3487507 on 2017/06/13 by Michael.Trepka
AvfMedia - small cleanup of the code for passing video frame rate to the video sampler
Change 3487719 on 2017/06/13 by Michael.Trepka
Disable shared PCH in OpenExrWrapper to solve a problem with bUseRTTI mismatch between the module and the PCH
Change 3487842 on 2017/06/13 by Max.Preussner
AndroidMedia: Fixed texture swizzle disabled on non-Engine builds
Change 3488006 on 2017/06/13 by Michael.Trepka
AvfMedia - Moved some logic from FAvfMediaPlayer::TickTickable() to FAvfMediaTracks::ProcessAudio() to make it thread safe, plus fixed a bug with the player not setting the current status to Stopped after opening a
file
Change 3488308 on 2017/06/13 by Chris.Babcock
AndroidMedia: Fixed flicker issue
#jira UE-45736
Change 3488335 on 2017/06/13 by Max.Preussner
MediaAssets: Made UFileMediaSource::GetFullPath public
Change 3488338 on 2017/06/13 by Max.Preussner
MediaPlayerEditor: Fixed "Show file in Explorer" not working for file media sources
Change 3488339 on 2017/06/13 by Max.Preussner
MediaPlayerEditor: Showing a throbber when buffering player
Change 3488768 on 2017/06/14 by Max.Preussner
Core: Inlined FTimespan static functions
hange 3490203 on 2017/06/14 by Max.Preussner
Core: Force inlined TComPtr operators
Change 3494083 on 2017/06/15 by Chris.Babcock
AndroidMedia: Fix playlist looping (send PlaybackEndReached event)
#jira UE-46086
Change 3497017 on 2017/06/16 by Max.Preussner
MediaAssets: Playlists now auto advance with PlayOnOpen off
Change 3497075 on 2017/06/17 by Chris.Babcock
MediaPlayer Sampler node and external texture support for Android MediaPlayer
- enable with USE_EXTERNALTEXTURE in AndroidMediaPlayer.cpp (disabled in this CL)
- supports MediaSample node in material editor with scale/bias handled if above flag enabled
- fixed looping problems, including eventual crashes
- track switching fixed (lockups and missing video)
- corrected resource leaks and crash switching maps
#jira UE-46055
#jira UE-45744
#jira UE-46086
Change 3497163 on 2017/06/17 by Max.Preussner
MediaUtils: Processing media events immediately if on game thread
Change 3497170 on 2017/06/17 by Max.Preussner
Media: All Media Framework interfaces are pure virtual
Change 3498603 on 2017/06/19 by Ben.Marsh
UBT: Prevent plugins which list modules multiple times from adding them twice.
Change 3500870 on 2017/06/20 by Max.Preussner
WmfMedia: Rewrote WMF state machine; now with track switching
#jira UE-20209
#jira UE-35385
#jira UE-38337
#jira UE-45676
Change 3502181 on 2017/06/20 by Chris.Babcock
MediaSampler node updates
- fixed issue with ExternalTexture singleton for DLL compatiblity
- now works for all players (registers texture samples with ExternalTexture by player GUID)
- enabled OES in AndroidMediaPlayer now that materials can universally use the MediaSampler
Change 3503182 on 2017/06/21 by Max.Preussner
Media: Refactored status flags into an enum; exposed connecting status
Change 3503724 on 2017/06/21 by Chris.Babcock
Improvement in MediaPlayer Sampler node
- RGB, R, G, B, A output pins like normal texture sampler
- allow preview in material editor
- fix OES detection for Android
Change 3509088 on 2017/06/26 by Max.Preussner
MediaAssets: Added AddFile and AddUrl to UMediaPlaylist
Change 3510256 on 2017/06/26 by Max.Preussner
WmfMedia: Fixed play rate not set to zero when end reached
Change 3510273 on 2017/06/26 by Max.Preussner
MediaPlayerEditor: Removed obsolete Slate culling rectangle code
Change 3510413 on 2017/06/26 by Max.Preussner
MediaPlayerEditor: Showing frame rate if available
Change 3510533 on 2017/06/26 by Max.Preussner
MediaUtils: Preventing media cache filling up when scrubbing
Change 3510859 on 2017/06/26 by Max.Preussner
PS4Media: Fixed track switching crashes (UE-45960)
#jira UE-45960
Change 3514173 on 2017/06/28 by Max.Preussner
WmfMedia: Optimized player capabilities check
Change 3514174 on 2017/06/28 by Max.Preussner
WmfMedia: Moved media source resolver code into utility class
Change 3514714 on 2017/06/28 by Max.Preussner
Core: Added TComPointer.IsValid; code cleanup pass
Change 3517912 on 2017/06/30 by Max.Preussner
MediaUtils: Added GetVideoAspectRatio to player facade
Change 3524957 on 2017/07/06 by Max.Preussner
ImgMedia: Decoding image frames only when video track is selected
Change 3525252 on 2017/07/06 by Max.Preussner
ImgMedia: Async image sequence initialization
Change 3525266 on 2017/07/06 by Max.Preussner
ImgMedia: Enabled reverse playback
Change 3525722 on 2017/07/06 by Max.Preussner
WmfMedia: Workaround for occasional WMF internal deadlock in IMFRateSupport
Change 3525800 on 2017/07/07 by Max.Preussner
WmfMedia: Fixed another WMF deadlock issue & some rate change glitches; improved logging.
Change 3525801 on 2017/07/07 by Max.Preussner
MediaPlayerEditor: Made scrubbing more responsive
Change 3526500 on 2017/07/07 by Max.Preussner
WmfMedia: Using NULL for Windows pointers
Change 3527323 on 2017/07/07 by Max.Preussner
WmfMedia: Added support for audio and video capture media sources
Change 3530197 on 2017/07/10 by Max.Preussner
WmfMedia: Added utility functions for enumerating audio and video capture devices
Change 3533465 on 2017/07/12 by Max.Preussner
Media: Added media capture device support API & implementation for WMF
Change 3533469 on 2017/07/12 by Max.Preussner
MediaPlayerEditor: Added source selection menu w/ capture device menu to navigation bar
Change 3533540 on 2017/07/12 by Max.Preussner
MediaAssets: Blueprint support for media capture device discovery
Change 3533574 on 2017/07/12 by Max.Preussner
WmfMedia: Using cached supported play rates; more strict pausing support check
Change 3533924 on 2017/07/12 by Max.Preussner
WmfMedia: Added global LowLatency setting (UEVR-859)
Note that this setting is only supported when compiling for Windows 8 or newer.
Change 3534027 on 2017/07/12 by Max.Preussner
WmfMedia: Compile time support for low latency session attribute on < Windows8
#jira UEVR-859
Change 3538744 on 2017/07/14 by Max.Preussner
MediaUtils: Renamed FDefaultMediaTimeSource to FAppMediaTimeSource
Change 3542818 on 2017/07/18 by Max.Preussner
WmfMedia: Fixed race condition on session shutdown
Change 3543082 on 2017/07/18 by Max.Preussner
WmfMedia: Fixed track selection in media that doesn't support seeking
Change 3543092 on 2017/07/18 by Max.Preussner
Media: Implemented media track format API
Enables multiple formats per media track. By default, the first usable format is selected.
This feature is currently only implemented for WmfMedia. All other players assume a single format per track.
Change 3543794 on 2017/07/19 by Max.Preussner
WmfMedia: Added string conversion for null GUIDs
Change 3543796 on 2017/07/19 by Max.Preussner
MfMedia: Copied GUID string conversion updates from WmfMedia
Change 3543797 on 2017/07/19 by Max.Preussner
WmfMedia: Preventing duplicate track formats in capture devices with legacy DirectX support
Change 3544390 on 2017/07/19 by Max.Preussner
Media: Allowing INDEX_NONE as 'current selection' index in track format related functions
Change 3545368 on 2017/07/19 by Max.Preussner
WmfMedia: Fixed session error with some media sources when attempting to seek to current position without ever starting
Change 3545388 on 2017/07/19 by Max.Preussner
MediaAssets: Fixed RGB input sources rendered upside down
Change 3545430 on 2017/07/19 by Max.Preussner
MediaAssets: Fixed incorrect sRGB conversion on BMP inputs
Change 3547362 on 2017/07/20 by Max.Preussner
Core: Added IsGraph and IsPrint to TCHAR utilities
Change 3547376 on 2017/07/20 by Max.Preussner
WmfMedia: Better log messages for non-standard video types (UE-47533)
#jira UE-47533
Change 3547404 on 2017/07/20 by Max.Preussner
QAGame: Enabled PlayOnOpen and Looping on MediaPlayerSwitch BP (UE-47542)
#jira UE-47542
Change 3547466 on 2017/07/20 by Max.Preussner
WmfMedia: Fixed edge case for detecting whether pause is available
Change 3548742 on 2017/07/21 by Max.Preussner
Media: Added API for changing the input frame rate
Change 3548743 on 2017/07/21 by Max.Preussner
WmfMedia: Implemented ability to change input frame rate
Change 3554411 on 2017/07/25 by Max.Preussner
AudioMixer: Broke out SynthComponent initialization code; added bIsUISound property
Change 3554818 on 2017/07/25 by Max.Preussner
Media: Added per track-type cache queries
Change 3557284 on 2017/07/26 by Max.Preussner
WmfMedia: Added buffer size check in texture sample as well
Change 3560530 on 2017/07/27 by Max.Preussner
WmfMedia: Made COM object destructors private and added assertions
Change 3560580 on 2017/07/27 by Max.Preussner
MediaUtils: Added method for querying number of objects in pool
Change 3562572 on 2017/07/28 by Max.Preussner
WmfMedia: Properly handling topology status errors when opening media
Change 3576710 on 2017/08/08 by Chris.Babcock
bug fixes for mediaplayer
- rare cases in Android media tracks
- make FMediaCaptureDevice members available in blueprints
Change 3577736 on 2017/08/08 by Chris.Babcock
Extend ExternalTexture to support 2x3 transform (scale/rotation + offset)
Change 3578831 on 2017/08/09 by Max.Preussner
MediaAssets: Made media sound component BP spawnable
Change 3579210 on 2017/08/09 by Max.Preussner
UdpMessaging: Not showing warning message if tunnel settings left empty to use defaults
Change 3579547 on 2017/08/09 by Chris.Babcock
Better support for Android external texture detection
Change 3579567 on 2017/08/09 by Chris.Babcock
Android camera plugin
#jira UEMOB-215
Change 3580035 on 2017/08/10 by Andrew.Rodham
Media Texture: External textures are now fully supported and enforced when attempting to sample external texture types in materials.
- Textures can now dynamically provide an external texture GUID at runtime, which is queried by the uniform expression. Statically defined GUIDs remain supported.
- Added necessary ExternalTexture(Parameter) methods to the material compiler and HLSL translator
- Made UTexture::GetMaterialType const-correct
#tests Test map that contains TextureObject, TextureObjectParameter, TextureSample and TextureSampleParameter nodes with media textures works on both a Nexus 10 (non-image-external), and a Pixel (image-external),
and on desktop PC.
Change 3581552 on 2017/08/10 by Chris.Babcock
Use bilinear sampling instead of point for external texture (Android media and camera)
Change 3581628 on 2017/08/10 by Max.Preussner
Core: Fixed FTimespan import/export/copypaste (UE-43990)
#jira UE-43990
#jira UE-44163
Change 3581909 on 2017/08/11 by Andrew.Rodham
Media: Only cache material proxy pointers if they have been initialized (and thus, will be removed from the cache on release)
- This prevents destroyed proxies from remaining in the texture registry
#jira UE-48307
Change 3582451 on 2017/08/11 by Max.Preussner
AudioMixer: Fixed initialization order of synth components
This ensures that the Synth is initialized before OnRegister in the super class initializes and activates the AudioComponents. Previously, the AudioComponent would fail to activate, because Synth was nullptr.
#jira UE-48055
Change 3582453 on 2017/08/11 by Max.Preussner
MediaAssets: Enabling ticking in media sound component (UE-48055)
#jira UE-48055
Change 3583101 on 2017/08/11 by Chris.Babcock
Android camera improvements
- return correct capture device type (webcamfront/rear)
- remove seek (not supported)
- support track formats
- better framerate selection
Change 3590109 on 2017/08/16 by Chris.Babcock
Move external texture coordinate update to improve accuracy and save a uniform in final shader
Change 3590530 on 2017/08/16 by Max.Preussner
MediaAssets: Changed capture device enumeration BP function signatures to allow filter bit masks
#jira UE-48166
Change 3590547 on 2017/08/16 by Max.Preussner
MediaPlayerEditor: Ticking sound component directly
Change 3590628 on 2017/08/16 by Max.Preussner
Switch: Fixed media decoder asserting when attempting to pause without having started
Change 3591816 on 2017/08/16 by Aaron.McLeran
#jira UE-48470 Disabling async processing for procedural sound waves on mac.
Change 3592266 on 2017/08/16 by Max.Preussner
Media: Replaced media cache with the new sample processing pipeline; continued to implement MfMedia
This change fixes stuttering issues with audio and video. However, proper pipeline flushing is not fully implemented yet, so the playback will break after the first playthrough, which might result in freeze frames
or out of memory assertions depending on the platform. This will be addressed in an upcoming change.
#jira UE-48474
#jira UE-45677
Change 3592355 on 2017/08/17 by Max.Preussner
MediaUtils: Added sample sink collection to remove code duplication
Change 3592739 on 2017/08/17 by Max.Preussner
ImgMedia: Fetching only one video sample per frame
Change 3592741 on 2017/08/17 by Max.Preussner
MediaUtils: Better sample fetching when paused
Change 3592761 on 2017/08/17 by Max.Preussner
MediaUtils: Fixed overflow detection in sample sinks
Change 3592762 on 2017/08/17 by Max.Preussner
ImgMedia: Sending end reached event when looping
Change 3592885 on 2017/08/17 by Max.Preussner
ImgMedia: Fixed reverse play
Change 3592887 on 2017/08/17 by Max.Preussner
MediaUtils: Better sample range calculation for audio samples
Change 3593010 on 2017/08/17 by Max.Preussner
ImgMedia: Fixed async loading of non-EXR image sequences
Change 3593193 on 2017/08/17 by Max.Preussner
AndroidMedia: Fixed typo
Change 3593230 on 2017/08/17 by Max.Preussner
Media: Implemented flushing for player sample queues
Change 3593346 on 2017/08/17 by Max.Preussner
Media: Proper sample processing for reverse playback
Change 3593482 on 2017/08/17 by Max.Preussner
Switch: Fixed sample range check for reverse playback
Change 3594428 on 2017/08/17 by Max.Preussner
PS4Media: Fixed video not playing/crashing
#jira UE-48547
#jira UE-48549
Change 3595404 on 2017/08/17 by Max.Preussner
MediaAssets: Not requesting audio samples if not playing
#jira UE-48557
Change 3595624 on 2017/08/17 by Max.Preussner
PS4Media: Fixed no looping after track switching
#jira UE-46524
#jira UE-48557
Change 3595704 on 2017/08/17 by Max.Preussner
MediaUtils: Improved sample queue flushing
Eventually this needs to be event-driven.
#jira UE-48557
Change 3595706 on 2017/08/17 by Max.Preussner
PS4Media: Flushing queues when track switching
#jira UE-48557
Change 3595909 on 2017/08/17 by Max.Preussner
Matinee: Fix Matinee redirect missing as UClass has been GC'ed (GitHub PR #3382)
https://github.com/EpicGames/UnrealEngine/pull/3382
#jira UE-42906
#rn Fix Matinee redirect missing as UClass has been GC'ed (GitHub PR #3382)
Change 3597480 on 2017/08/18 by Max.Preussner
ImgMediaPlayer: Fixed presentation time calculation for very large delta times
Change 3597669 on 2017/08/18 by Max.Preussner
ImgMedia: Setting player stopped instead of paused when end reached
Change 3597709 on 2017/08/18 by Max.Preussner
SwitchMedia: Fixed audio sample duration calculation
Change 3598479 on 2017/08/18 by Max.Preussner
ImgMedia: Ensuring that first/last frame is played when starting playback forward/reverse; improved state checking; user logging
Change 3598629 on 2017/08/18 by Max.Preussner
MediaUtils: Properly handling pending flushes when peeking sample queues
Change 3598633 on 2017/08/18 by Max.Preussner
WmfMedia: Fixed occasional WMF deadlock when scrubbing
Change 3598653 on 2017/08/18 by Max.Preussner
MediaUtils: Fixed audio resampling in reverse playback
Change 3598659 on 2017/08/18 by Max.Preussner
MediaPlayerEditor: Creating sound output only if audio device available
Change 3598688 on 2017/08/18 by Max.Preussner
MediaUtils: Flushing sample queues on direction change regardless of paused state
Change 3599444 on 2017/08/20 by Max.Preussner
WmfMedia: Added missing check for rate control when quering supported rates
Change 3603661 on 2017/08/22 by Max.Preussner
WmfMedia: Fixed NV12 output
Change 3604345 on 2017/08/23 by Max.Preussner
MediaUtils: Added subtitle samples to media sample collection; fixed documentation
Change 3604987 on 2017/08/23 by Max.Preussner
PS4Media: Setting correct track format types
Change 3605117 on 2017/08/23 by Joe.Barnes
Fix issue where presentation time was being treated as milliseconds instead of microseconds.
Change 3605128 on 2017/08/23 by Joe.Barnes
Fix potential issue calculating total (looped) play time after seek or reset.
Track last video presentation time
Change 3605139 on 2017/08/23 by Joe.Barnes
Support audio type DType_Setup.
Fix issue with procedural sounds popping. Consume more samples if necessary.
#jira ue-48544
Change 3605197 on 2017/08/23 by Max.Preussner
Media: Fixed track display name formatting (UE-48767)
#jira UE-48767
Change 3605817 on 2017/08/23 by Max.Chen
Auto set sampler type on drop on actor.
#jira UE-48769
Change 3605999 on 2017/08/23 by Max.Preussner
MfMedia: Restarting source reader when switching tracks
#jira UE-48766
Change 3606416 on 2017/08/23 by Max.Preussner
PS4Media: Various player improvements
#jira UE-48586
Change 3607656 on 2017/08/24 by Max.Preussner
WmfMedia: Improved logging for Seek and SetRate
Change 3607855 on 2017/08/24 by Max.Preussner
MfMedia: Better verbose logging; validating seeks; reduced nesting; fixed track switching\
#jira UE-48766
Change 3608029 on 2017/08/24 by Max.Preussner
PS4Media: Fixed streaming media not playing; improved result checks & logging
#jira UE-48610
Change 3608473 on 2017/08/24 by Max.Preussner
MfMedia: Fixed audio sample duration calculation
#jira UE-48756
Change 3609316 on 2017/08/24 by Chris.Babcock
Provide external texture RotationScale and Offset from sample
Change 3610067 on 2017/08/25 by Richard.Wallis
Mac: Editor locks up when Track switching and Mac: Media Audio continues to play after closing player.
- Fix for creating extra OS AV media playback objects so audio playback not stopping due to over retained objects.
- Trying to access OS AV Media Playback object (esp. the currentTime value) across mutliple threads at once seems to cause deadlock in the Apple libraries - moved location of currentTime acess point to Media Ticker
- this sets the current time and is then just returned in the getter when on game main.
- Trying to playback audio via OS media playback and through the engine at the same time when enabling the selected audio track. Engine version via sample buffers via AVAssetReaderTrackOutput doesn't seem to be
working as intended with the new audio frame work audio sinks - so reverting to OS AV media playback for Mac at the moment until better fix for this can be put in.
#jira UE-48590, UE-48604
Change 3610267 on 2017/08/25 by Max.Preussner
PS4Media: Added missing track selection validation
#jira UE-48765
Change 3610399 on 2017/08/25 by Max.Preussner
PS4Media: Fixed infinite player re-initialization loop if track selection failed
Change 3610809 on 2017/08/25 by Chris.Babcock
Fixes for Android media player and camera player
- buffer samples copy proper bytecount
- realloc sets new buffer ptr
- refcount of Java buffers fixed
Change 3610953 on 2017/08/25 by Chris.Babcock
Fix audio disable before play on Android media player
Change 3611405 on 2017/08/25 by Max.Preussner
WmfMedia: Resetting supported rates if RateSupport unavailable
Change 3611406 on 2017/08/25 by Max.Preussner
MfMedia: Resetting supported rates if RateSupport unavailable
Change 3611453 on 2017/08/25 by Chris.Babcock
Android external texture extension updates for compatibility
Change 3611719 on 2017/08/26 by Max.Preussner
Media: Added media event for completed seek operations; flushing sinks on seek
Change 3611764 on 2017/08/26 by Max.Preussner
AvfMedia: Setting player to preparing state prior to initializing tracks asynchronously
Change 3611802 on 2017/08/26 by Max.Preussner
Media: Exposed error state in media player
Change 3611803 on 2017/08/26 by Max.Preussner
MediaPlayerEditor: Showing error state in UI
Change 3611887 on 2017/08/26 by Max.Preussner
MediaUtils: Corrected media sample sink overflow check
Change 3611892 on 2017/08/27 by Max.Preussner
WmfMedia: Leaving session in error state after error
Change 3611929 on 2017/08/27 by Max.Preussner
MediaPlayerEditor: Fixed sound stopping on looping
Change 3611930 on 2017/08/27 by Max.Preussner
MfMedia: Rewrote async sample processing to fix various playback issues
Change 3611942 on 2017/08/27 by Max.Preussner
Media: Sending suspension event when playback ended
Change 3611957 on 2017/08/27 by Max.Preussner
UnrealEd: Allowed transient assets to be resaved to disk
Change 3611981 on 2017/08/27 by Max.Preussner
PS4Media: Rewrote sample processing to fix various playback issues
#jira UE-48596
#jira UE-48793
Change 3612035 on 2017/08/27 by Max.Preussner
UnrealEd: Picking standard default names when resaving transient packages
Change 3612045 on 2017/08/27 by Max.Preussner
Media: Fixed playlists not getting saved correctly from Editor (UE-35382)
#jira UE-35382
Change 3612212 on 2017/08/28 by Richard.Wallis
Fix for Multitrack Video samples continue to Play on Open after Play on Open is toggled off. Current Rate was not getting reset back to 0.0 on media close.
#jira UE-47602
Change 3613531 on 2017/08/28 by Max.Preussner
MediaAssets: Fixed external texture related crash on shutdown (UE-48918)
Also no longer creating clock sink for media player CDO
#jira UE-48918
Change 3613677 on 2017/08/28 by Andrew.Porter
Fixed crash at exit in Mac editor caused by double release of AVPlayerItem object
#jira UE-48937
Change 3615917 on 2017/08/29 by Max.Preussner
MfMedia: Added compile options for DXVA and falling back to synchronous sample reading
[CL 3617655 by Max Chen in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3441680 by Uriel.Doyon
Added units to point light intensity, to allow the user to specify the value in candelas or lumens.
New point light actors now configure the intensity in candelas by default.
Replaced viewport exposure settings by an EV100 slider.
Hidding the tone mapper in the show flag now still applies the exposure.
Added a new AutoExposure method called EV100 which allows to specify :
- MinEV100, MaxEV100
- Calibration Constnat
- Exposure Compensation
#jira UE-42783
Change 3454934 by Chris.Bunner
Backing out changelists 3441680, 3454636 and 3454844 for the sake of integration stability.
Change 3512118 by Marc.Olano
Fix rare Sobol shader data problem. Mismatch with CPU code after a large number of points
Resubmit of portion of //UE4/Dev-Rendering@3509854 that was rolled back to avoid massive shader recompiles during integration testing
Change 3512129 by Benjamin.Hyder
Fixing up content in TM-SobolNoise
Change 3512151 by Rolando.Caloca
DR - Fixed some layouts that were general
- Added some extra dump information
Change 3512160 by Benjamin.Hyder
Still Fixing TM-Sobol
Change 3512180 by Marc.Olano
PCSS for spotlights. Like directional PCSS this is experimental, activated by r.Shadow.FilterMethod.
Change 3512261 by Michael.Lentine
Move Subsurface to shared properties.
Previously the same code could be executed multiple times without being optimized out if multiple inputs used the same subsurface output.
#jira UE-44405
Change 3512288 by Rolando.Caloca
DR - Fix issue when recycling image handles
Change 3512338 by Michael.Lentine
Fix precision if user enters a multiple of 90 degree rotation for transforms.
This will only work for exact values. Generally comparing float point numbers using == is unsafe but it should be ok in this case as they are exact values entered from the UI. We may want to later expand this to include thresholding using a value ~1e-7.
#jira UE-46137
Change 3512424 by Michael.Lentine
Regenerate BaseColor.uasset and Specular.uasset to not have the notforclient flags set.
#jira UE-44315
Change 3512686 by Brian.Karis
Fix for quadric assert in infiltrator. Due to bad tangents in source mesh.
Change 3512696 by Brian.Karis
Unrevert TAA. Fixed DOF NaN artifacts
Change 3512717 by Marcus.Wassmer
PR #3714: Fix typo in EOcclusionCombineMode (Contributed by Mumbles4)
Change 3513112 by Richard.Wallis
Crash when packaging for iOS with Shared Material Native Libraries and Share Material Shader Code from windows platform. Offline shader compile for archiving not done - shader header has missing offline compile flag for native Metal library archiving.
Fix includes:
- Handle offline compile failure when not running on Mac and no remote is configured (or remote fails). (I think it's this point at which the crash in the bug report is at).
- Make sure remote can build for native Metal libraries and archive correctly - this should now support Linux platforms or Mac to Mac (if enabled in MetalShaderCompiler.cpp) for testing if required.
- Updated to include remote calling into the xcode 9 Metal pch fix already submitted by Mark Satt.
#jira UE-45657
Change 3513357 by Richard.Wallis
Windows compile fix.
Change 3513375 by Guillaume.Abadie
Exposes the possibility to manually destroy the GPU ressource of UTextureRenderTarget2D.
Change 3513685 by Richard.Hinckley
#jira UEDOC-3822
Fixing a comment that refers to a non-existent function, for documentation purposes.
Change 3513705 by Marc.Olano
Updates to Sobol test levels in RenderTest project
Change 3513730 by Rolando.Caloca
DR - Fix mip size copying resolve targets
- Fix compute fence
- Fix descriptor set texture layout
- More dump info
Change 3513742 by Marc.Olano
Texture-free numeric print for shader debugging
Change 3513777 by Daniel.Wright
Handled edge case where no furthest samples are found in precomputed visibility
Change 3514852 by Rolando.Caloca
DR - Fix -directcompile on SCW
Change 3515049 by Rolando.Caloca
DR - hlslcc dump crash fix
Change 3515167 by Rolando.Caloca
DR - hlslcc - Fix bogus string pointer
- Allow reading from non-scalar UAVs
Change 3515745 by Rolando.Caloca
DR - Linux compile fix
Change 3515862 by Rolando.Caloca
DR - Remove old reference to CCT
- Link with hlslcc debug libs on SCW debug config for easier debugging
Change 3516292 by Rolando.Caloca
DR - glslang exe fixes
Change 3516568 by Rolando.Caloca
DR - hlslcc - Copy fix for *Buffer as functionparameters
Change 3516659 by Marcus.Wassmer
Fix some d3derrors with distance fields
Change 3516801 by Daniel.Wright
Fixed crash when doing editor 'Force Delete' on a static mesh whose distance field is still being built. Any UObject reference that is to an asset can be NULL'ed by the editor.
Change 3516825 by Rolando.Caloca
DR - Some initial fixes for structured buffers
Change 3516843 by Rolando.Caloca
DR - Fix for Vulkan dist fields
Change 3516869 by Marcus.Wassmer
Add format to the createrendertarget blueprint node
Change 3516957 by Daniel.Wright
Fixed bUsesDistortion being editable
Change 3516965 by Daniel.Wright
Still mark the distance field task completed, even if the static mesh has been deleted
Change 3517039 by Yujiang.Wang
GitHub #2655: Optimization for shadow map resolution selection for spot lights
* Use the radius of the inscribed sphere at the cone end as the spot light's screen radius
Note: slight drop of shadow quality of spot lights may occur when they are far away from the camera. This is intended, since before this optimization they tend to be always rendered with the maximum shadow map resolution (2048), which is very costly
#jira UE-33982
Change 3517069 by Yujiang.Wang
Fix for ScissorRect settings in d3d11 being lost under certain scenarios
* Scissor rectangle is always enabled in the low-level d3d11 pipeline, and it is expected that at least one ScissorRect is present no matter whether RHISetScissorRect is called with bEnable=false (when it is false we just use a big rect to make it effectively disabled)
* However FD3D11StateCacheBase::ClearState() clears all the states, which removes scissor rectangles and causes problems for certain routines (FScene::UpdateSkyCaptureContents)
* Now SetScissorRectIfRequiredWhenSettingViewport will always set a effectively disabled ScissorRect on each FD3D11DynamicRHI::RHISetViewport call, just like d3d12 does
#jira UE-45465 UE-44760
Change 3517134 by Yujiang.Wang
CIS fix
Change 3517662 by Rolando.Caloca
DR - Execute upload Vulkan cmds on the RHI thread
- Fix crash with structured buffer
Change 3517677 by Rolando.Caloca
DR - Update/copy textures on RHI thread
Change 3517680 by Rolando.Caloca
DR - Copy texture bulk data on rhi thread
Change 3517748 by Marcus.Wassmer
temporary workaround for one class of GPU crashes
Change 3518832 by Rolando.Caloca
DR - Copy & extend 3518077
- Fix for movable skylight shader missing on simple forward (low lighting quality mode)
Change 3519973 by Richard.Wallis
Jittering in Engine Menu Dropdown Options. Jitter fix: Fix some areas that hadn't been changed from RoundToInt (from previous CL's) to CeilToInt.
#jira UE-46505
Change 3520849 by Uriel.Doyon
Fixed issue with investigate texture command and dynamic component entries.
Change 3521064 by Guillaume.Abadie
Returns absolute path of shader files on error to avoid work loss in visual studio that can't figure out that a sln relative and absolute path might leading to same file on disk.
Change 3521834 by Rolando.Caloca
DR - Fix decals on Vulkan
Change 3521892 by Rolando.Caloca
DR - Fix Vulkan texture streaming
Change 3523181 by Rolando.Caloca
DR - Copy from 3523176
UE4.17 - Fix Vulkan scissor causing text to not clip
Change 3523534 by Yujiang.Wang
UE-46631: Implement a scalable LongGPUTask to fix ProfileGPU
* A new, scalable, platform-independent IssueLongGPUTask is now implemented in UtilityShaders
* Removed IssueLongGPUTask and G*Vector4VertexDeclaration from RHI implementations
* The measurement of the execution time of a basic LongGPUTask unit is kicked off on the very first frame
#jira UE-46631
Change 3524552 by Yujiang.Wang
Fix iteration number calculation of LongGPUTask
Change 3524975 by Joe.Graf
Moved the Hamming-weight function from StaticMeshDrawList.inl to FGenericPlatformMath
Added SSE versions using _mm_popcnt_u64 for platforms that support it
Added a SSE check to gracefully exit when missing the instruction and it was expected to be there
#CodeReview: arciel.rekman, brian.karis
Change 3525306 by Daniel.Wright
Fixed ensure from LPV
Change 3525346 by Rolando.Caloca
DR - Fix linking issue
Change 3525459 by Daniel.Wright
Volumetric Lightmaps - higher quality precomputed GI on dynamic objects and GI on Volumetric Fog
* Enabled by default on all maps, effective after a lighting build. This replaces the existing Precomputed Light Volume and Indirect Lighting Cache features.
* New Lightmass World Settings: VolumeLightingMethod, VolumetricLightmapDetailCellSize and VolumetricLightmapMaximumBrickMemoryMb.
* Lightmass computes lighting samples in an adaptive grid, with higher density around geometry inside the importance volume. Positions outside the importance volume get lit with the border texels.
* Improved Lightmass volume solver to use importance photons and full adaptive final gather, so volume samples have similar quality to 2d lightmaps.
* A static indirection texture is built covering the importance volume and flattening the brick tree by storing the offset to the highest density brick at each indirection cell.
* Seamless and efficient GPU interpolation across density levels is achieved by adding a single row of padding to bricks, copied from neighbors, and stitching up bricks with lower density neighbors
* The Volumetric lightmap stores Irradiance as a 3 band SH, which is 27 floats, quantized into 28 bytes, 7 texture lookups.
* A full screen barebones material using Volumetric Lightmaps costs .42ms on 970 GTX, while Indirect Lighting Cache Point costs .32ms
* Sky bent normal is also stored for stationary skylights and Directional Light Shadowing for Single Sample Shadow receiving.
* Volumetric fog, Movable components, unbuilt Static Components, SingleSampleShadow receiving and Capsule Shadows use Volumetric Lightmaps if available
* New Visualization show flag for Volumetric Lightmap sample points
* Level streaming of volume light data is not currently supported with this method
Change 3525461 by Daniel.Wright
Lowered default r.Shadow.RadiusThreshold for Epic shadow settings as it was causing a lot of visible artifacts from small objects popping out. This will increase shadowmap cost slightly (13.5ms RT -> 14.3ms RT in Fortnite on PS4, no measurable GPU difference).
Change 3526459 by Rolando.Caloca
DR - Fix validation error
Change 3526474 by Rolando.Caloca
DR - Integrate from GV
Change 3526487 by Daniel.Wright
Disabled Volumetric Lightmap filtering with neighbors due to artifacts
Fix linux compile errors
Change 3526833 by Rolando.Caloca
DR - Workaround for hlslcc
Change 3526991 by Uriel.Doyon
Integrated 3526859 : Texture mip bias is now reset whenever the streaming budget increases. This fixes an issue where textures persistently become low res after a memory spike.
Change 3527574 by Rolando.Caloca
DR - Added some missing resource entries for SCW direct mode
Change 3527625 by Rolando.Caloca
DR - Copy from 3527113
UE4.17 - Fix Vulkan not calling Present
Change 3528461 by Brian.Karis
Support larger hash sizes. Added uint list hashing function.
Change 3528780 by Rolando.Caloca
DR - Default Vulkan resources
Change 3528818 by Rolando.Caloca
DR - glslang - Added missing accessor
Change 3528839 by Rolando.Caloca
DR - Fix virtual path issue when using non-engine relative absolute paths
Change 3528900 by Daniel.Wright
Fixed variable shadowing
Change 3529039 by Rolando.Caloca
DR - Read Spirv reflection data (not used yet)
Change 3529040 by Joe.Graf
Fixed the 32bit compile failures for the popcnt optimization
#CodeReview: arciel.rekman
Change 3529060 by Rolando.Caloca
DR - hlslcc - New flag for keeping resource names
Change 3529344 by Rolando.Caloca
DR - Delete unused file
Change 3529723 by Brian.Karis
Fixed static analysis cleaner.
Change 3531357 by Michael.Trepka
Updated Mac glslang libraries with latest changes. Also, updated the Xcode project (generated with CMake) and moved it to a different location so that it no longer uses hardcoded absolute paths. It should be easy to rebuild these libraries in the future.
Change 3531517 by Joe.Graf
Added support for ddx_fine, ddy_fine, ddx_coarse, ddy_coarse to hlslcc
#CodeReview: arciel.rekman, mark.satterthwaite, rolando.caloca
Change 3531626 by Joe.Graf
Mac version of the popcount optimization
Changed Linux version to use the same builtin
#CodeReview: mark.satterthwaite, arciel.rekman
Change 3531837 by Chris.Bunner
SetScissorRectIfRequiredWhenSettingViewport sets the viewport size by default rather than disabling the scissor rect.
#jra UE-46753
Change 3533415 by Joe.Graf
Renamed the SSSE3 checks per feedback
#CodeReview: arciel.rekman
Change 3533480 by Michael.Lentine
Use more accurate descriptions for shader recompile options
Change 3533511 by Joe.Graf
Updated the GenericPlatformMisc to match the SSSE3 name change
#CodeReview: arciel.rekman
Change 3533521 by Marcus.Wassmer
Fix scenerenderer leak when updating out of view planar reflections
Change 3533528 by Joe.Graf
Updated comments
#CodeReview: n/a
Change 3533608 by Mark.Satterthwaite
New manual Xcode project for glslang so that we include all the necessary code and can link again.
Change 3534260 by Mark.Satterthwaite
Fix the Xcode 9 Beta 3 compile errors in MetalRHI without breaking Xcode 8.3.3.
Change 3535789 by Yujiang.Wang
Fix for wrong hair shading in forward shading
* IBL reflections should be turned off for hairs
Change 3537059 by Ben.Marsh
Fixing case of iOS directories, pt1
Change 3537060 by Ben.Marsh
Fixing case of iOS directories, pt2
Change 3538297 by Michael.Lentine
Add shader comparison test.
Adding the basic test case.
Adding logic to Common.ush to enable FP16 conditionally on a define (which is not set by default)
Adding more exported functionality to automation for use in the shader test.
Change 3538309 by Michael.Lentine
Add missing file from Shader Test CL.
Change 3538751 by Michael.Lentine
Add missing pragma once.
Change 3539236 by Michael.Lentine
Do not ignore return values.
Change 3539237 by Michael.Lentine
Check in the correct file
Change 3540343 by Rolando.Caloca
DR - Added t.DumpHitches.AllThreads
Change 3540661 by Yujiang.Wang
Fix spot tube light direction
* The tube direction for a spot light was pointing along the light direction, now it is along the local Z axis which is perpendicular to the light direction. Lightmass is also touched
* A new LightTangent is added to FDeferredLightData
* Packed all the values from LightSceneProxy->GetParameters into a single FLightParameters struct to avoid copy-pasting them everywhere
Change 3541129 by Rolando.Caloca
DR - vk - Copy all Vulkan fixes from 4.17
Change 3541347 by Yujiang.Wang
Fix wrong ViewFlags being set between objects when rendering shadow depth maps
* Bug caused by trying to share DrawRenderState between objects, but SetViewFlagsForShadowPass was designed to start from a fresh render state
* Now SetViewFlagsForShadowPass recalculates and sets the flags on each call
Change 3542603 by Rolando.Caloca
DR - vk - Allow sharing samplers on Vulkan
Change 3542639 by Jian.Ru
Changed warning text to better indicate that global clip plane needs to be enabled for planar reflection
#RB Marcus.Wassmer
Change 3543167 by Michael.Lentine
Fix naming for the shader comparison tests.
Change 3543210 by Uriel.Doyon
Fixed an issue when computing material scales where the default material ends up being used instead of the required material.
In that case, we used the default settings for texture streaming (assuming a scale of 1).
Change 3543221 by Brian.Karis
Simplifier optimizations
Change 3543239 by Arciel.Rekman
hlslcc: remove FCustomStd* workarounds.
- This was previous attempt to work around problems arising from different STL used for building libhlslcc (in the cross-toolchain) and possibly different STL used for building engine (on the system).
- The same problem has been resolved by bundling libc++.
Change 3543946 by Michael.Lentine
Add comparison output.
Change 3544277 by Brian.Karis
Fixed uninitialized var error
Change 3544404 by Rolando.Caloca
DR - Fix broken textures
Change 3544503 by Jian.Ru
Ensure lighting failure delegates are always called
#RB Marcus.Wassmer,Daniel.Wright
#3689
Change 3545241 by Daniel.Wright
Fixed spotlight whole scene shadows using a radius 2x too long
Change 3545347 by Daniel.Wright
Fixed shadow occlusion culling broken by shadowmap caching change. FProjectedShadowKey is now computed correctly for whole scene shadows and SDCM_StaticPrimitivesOnly shadowmaps will fall back to the query for a SDCM_MovablePrimitivesOnly, since the static primitives shadowmap's query is not issued every frame.
Change 3546196 by Marcus.Wassmer
Fix minor typo
Change 3546459 by Daniel.Wright
ULevel::PostEditChangeProperty recreates rendering resources if MapBuildData is modified - fixes a crash when Force Deleting the MapBuildData package.
Change 3546469 by Jian.Ru
Take into account CVarStaticMeshLODDistanceScale during static mesh LOD calculation
Change 3546804 by Daniel.Wright
[Copy] Added SendAllEndOfFrameUpdates draw event to wrap skin cache events
Change 3546814 by Daniel.Wright
[Copy] Only use skylight OcclusionMaxDistance for the global distance field if it casts shadows
Change 3546815 by Daniel.Wright
[Copy] Snap volumetric fog light function target resolution to a factor of 32 to avoid constant texture reallocation
Change 3546817 by Daniel.Wright
[Copy] Warmup time warning
Change 3546828 by Daniel.Wright
[Copy] Fixed UWorld::DestroyActor in PIE calling InvalidateLightingCacheDetailed which can do a FlushRenderingCommands and cause a large hitch
Change 3546836 by Daniel.Wright
[Copy] ULightComponent::InvalidateLightingCacheInner uses MarkRenderStateDirty instead of slow reregister + FlushRendingCommands, and only for lights which might have static lighting data
Change 3546849 by Rolando.Caloca
DR - vk - Fix missing samplerstates
- Fixes for structured buffers
- Add missing Draw and Dispatch Indirect
Change 3547516 by Brian.Karis
Linear time 5-coloring for planar graphs.
Brought in the Planarity library written by John Boyer, heavily edited and trimmed down to only include code necesary for graph coloring. Put behind a simple wrapper.
Change 3547542 by Brian.Karis
Linear time 5-coloring for planar graphs.
Brought in the Planarity library written by John Boyer, heavily edited and trimmed down to only include code necesary for graph coloring. Put behind a simple wrapper.
Change 3547563 by Brian.Karis
Fixed some compiler warnings and hopefully some errors.
Change 3547610 by Brian.Karis
Replaced macros with inlined functions
Change 3547620 by Brian.Karis
Clean up includes
Change 3547770 by Marcus.Wassmer
GPU Crash for MTBF analytics
Change 3547773 by Marcus.Wassmer
Updated doxygen comment for new analytic
Change 3548244 by Rolando.Caloca
DR - Fix for translucency
Change 3548352 by Yujiang.Wang
Added soft source radius for point and spot lights
* Soft source radius controls how 'blurry' the shape of specular lighting looks
* Implemented by LobeRoughness modification
* Better approximation for spherical lights so that they don't look sharp when the radius is large using 'smoothed representative point' method
* Suppoted LightTangent in forward shading
Change 3548530 by Brian.Karis
Fix for mac build
Change 3548770 by Rolando.Caloca
DR - vk - Prereq work for Vulkan parallel RHI contexts
Change 3548772 by Jian.Ru
Fixed an issue that caused an ensure when switching levels in D3D10. #rb Marcus.Wassmer
Change 3548865 by Daniel.Wright
With shadowmap caching of whole scene shadows, only one of the cache modes issues an occlusion query. Fixes a crash where the static primitive shadowmap is culled but the movable primitive shadowmap is visible, which is normally not possible.
Change 3548952 by Rolando.Caloca
DR - Allow separate samplers in the shaders on Vulkan
Change 3549197 by Marcus.Wassmer
Fix DX12 PIx not working in cooked builds
Change 3549209 by Daniel.Wright
Occlusion culling for CSM, from the main camera, controlled by 'r.Shadow.OcclusionCullCascadedShadowMaps'. Disabled by default as rapid view changes don't work well with latent occlusion queries.
Change 3549943 by Ben.Marsh
Include better diagnostic information when a modified build product is detected after running a build step.
Change 3550546 by Rolando.Caloca
DR - Fix merge issue
Change 3550962 by Marcus.Wassmer
EarlyZ Masking requires full depth prepass, so just force it to.
Change 3551062 by Daniel.Wright
Handle NULL skylight
Change 3551104 by Rolando.Caloca
DR - vk - Remove assert to match other platforms
Change 3551221 by Rolando.Caloca
DR - vk - Add mirror clamp to edge extension
- Fix framebuffer deletion
Change 3551224 by Daniel.Wright
Volumetric lightmap increase density around static lights affecting a voxel brighter than LightBrightnessSubdivideThreshold.
Change 3551495 by Rolando.Caloca
DR - vk - Intiial support for async queue
Change 3552101 by Rolando.Caloca
DR - vk - Fix for async
Change 3552102 by Rolando.Caloca
DR - SkinCache - Fix potential leak on staging buffers for recompute tangents
- Integrate changes from 4.17 for memory optimizations
Change 3552104 by Rolando.Caloca
DR - vk - Support for SRVs for index buffers
Change 3552838 by Rolando.Caloca
DR - vk - Enable debug markers if found
Change 3553106 by Rolando.Caloca
DR - vk - Fixes for index buffer SRVs
Change 3553107 by Rolando.Caloca
DR - vk - Enable recompute tangents on Vulkan
Change 3553154 by Rolando.Caloca
DR - vk - Fix crash with null uav
Change 3553342 by Yujiang.Wang
Fix redundant skylights in AdvancedPreviewScene
* PreviewScene was changed to using a skylight instead of ambient cubemap to support forward shading
* AdvancedPreviewScene originally had a skylight, now it is changed to using the one inherited from PreviewScene
Change 3553481 by Rolando.Caloca
DR - Integrate fix for D3D12 support of index buffers SRVs
#jira UE-47674
Change 3553715 by Rolando.Caloca
DR - Fix crash when launching PC with -featureleveles31
Change 3553725 by Rolando.Caloca
DR - Redo fix
Change 3553803 by Rolando.Caloca
DR - Shader compile fixes for ES3.1
Change 3553963 by Rolando.Caloca
DR - vk - Remove extra IRDump
Change 3554741 by Ben.Marsh
CIS fix.
Change 3555222 by Rolando.Caloca
DR - vk - static analysis fix
Change 3555362 by Rolando.Caloca
DR - vk - Prep work for separate present queue
Change 3556800 by Daniel.Wright
Fixed screenshot for simple volume material doc
Change 3556942 by Brian.Karis
Fixed Bokeh DOF regression.
Change 3556959 by Rolando.Caloca
DR - vk - Rework staging buffer peak usage
Change 3557497 by Daniel.Wright
Better display name for Unbound property on post process volume
Change 3557499 by Daniel.Wright
Disable r.GenerateLandscapeGIData by default, opt-in for kite demo. Projects that want to use heightfield GI need to opt-in to r.GenerateLandscapeGIData.
Change 3557068 by Olaf.Piesche
Configurable spawn rate scaling reference value; sets the zero-scale reference value (default: 2), so additional quality levels can be added and scaling customized further.
IMPORTANT: This sets the reference to 3 in PS4Scalability.ini; effects on PS4 are again going to have reduced spawn rates versus PC and Neo, as intended by the FX artists starting with this change.
#tests QAGame test maps
Change 3558123 by Rolando.Caloca
DR - vk - static analysis fix
Change 3558685 by Yujiang.Wang
Github #3323: Two sided foliage lightmap directionality fix
* Subsurface is not intended to work with lightmaps that don't have directionality, however we still want it to look similar to a directional one
* Now it uses a constant directionality value
#jira UE-42523
Change 3559052 by Brian.Karis
Hopefully fix static analysis
Change 3559113 by Rolando.Caloca
DR - Fix crash witrh planar reflections
Change 3559275 by Yujiang.Wang
Fix race condition on several scalability CVars between rendering thread and game thread
Change 3559612 by Rolando.Caloca
DR - vk - SM5 with uniform buffers backend support
Change 3559716 by Rolando.Caloca
DR - hlslcc - Fix linker warning on SCW debug
Change 3559768 by Rolando.Caloca
DR - vk - Keep ub names for bindings
Change 3560195 by Rolando.Caloca
DR - accessor
Change 3560275 by Rolando.Caloca
DR - vk - Support for uniform buffers
Change 3560913 by Rolando.Caloca
DR - vk - Fix static analysis
Change 3561145 by Rolando.Caloca
DR - Don't crash if out of resource table bits
Change 3561194 by Rolando.Caloca
DR - vk - Integrate timestamp fixes
Change 3562009 by Rolando.Caloca
DR - vk - Workaround for bad UTexture data
Change 3563884 by Chris.Bunner
VK_NULL_HANDLE fix.
Change 3563885 by Jian.Ru
Ignore a warning caused by enabling distance field generation so that test Cube_Blue and Cube_Section don't fail. #rb Chris.Bunner
Change 3565943 by Jian.Ru
Add extra warning log triggered when attempt to create FRWBuffer greater than 256MB in ComputeLightGrid() #rb Chris.Bunner
Change 3569479 by Michael.Lentine
Integrate rhino shader changes to dev-rendering
Change 3569511 by Michael.Lentine
Fix formating and string out on windows.
Change 3569572 by Yujiang.Wang
Fix MeasureLongGPUTaskExecutionTime crashing on AMD on Macs
Change 3569614 by Yujiang.Wang
Flush rendering commands before measuring the long GPU task's excution time to get accurate results
Change 3570524 by Jian.Ru
Add extra parentheses to avoid compilation warning #rb Chris.Bunner
Change 3570722 by Chris.Bunner
Static analysis workaround - same code, just validating compile-time assumptions a little further.
Change 3570880 by Jian.Ru
Add small depth offset to avoid depth test failing during velocity pass
#jira UE-37556
Change 3572532 by Jian.Ru
Disable a warning to let tests pass
#jira UE-48021
Change 3573109 by Michael.Lentine
Checkin Michael.Trepka's fix for external dynamic libraries on mac.
This is needed to make the build go green on mac.
Change 3573995 by Jian.Ru
Move an include out of define to let nightly build pass
Change 3574777 by Chris.Bunner
Continued merge fixes.
Change 3574792 by Rolando.Caloca
DR - Rename todo
Change 3574794 by Chris.Bunner
Re-adding includes lost in a pre-merge merge.
Change 3574879 by Michael.Trepka
Disabled a couple of Mac deprecation warnings
Change 3574932 by Chris.Bunner
Merge fix.
Change 3575048 by Michael.Trepka
Fixed iOS compile warnings
Change 3575530 by Chris.Bunner
Duplicating static analysis fix CL 3539836.
Change 3575582 by Chris.Bunner
Fixed GetDimensions return type in depth resolve shaders.
Compile error fix.
Change 3576326 by Chris.Bunner
Static analysis fixes.
Change 3576513 by Michael.Trepka
Updated Mac MCPP lib to be compatible with OS X 10.9
Change 3576555 by Richard.Wallis
Metal Validation Errors. Dummy black volume texture is in the wrong format in the Metal shader for the VolumetricLightmapIndirectionTexture. Create a new dummy texture with pixel format PF_R8G8B8A8_UINT.
#jira UE-47549
Change 3576562 by Chris.Bunner
OpenGL SetStreamSource stride updates.
Change 3576589 by Michael.Trepka
Fixed Mac CIS warnings and errors in Dev-Rendering
Change 3576708 by Jian.Ru
Fix cascade preview viewport background color not changing
#jira UE-39687
Change 3576827 by Rolando.Caloca
DR - Minor fix for licensee
Change 3576973 by Chris.Bunner
Fixing up HLSLCC language spec mismatch (potential shader compile crashes in GL and Vulkan).
Change 3577729 by Rolando.Caloca
DR - Fix for info on SCW crashes
Change 3578723 by Chris.Bunner
Fixed issue where custom material attribute was using display name as hlsl function name.
Change 3578797 by Chris.Bunner
Fixed pixel inspector crashing on high-precision normals gbuffer format.
#jira UE-48094
Change 3578815 by Yujiang.Wang
Fix for UE-48207 Orion cooked windows server crash on startup
* Crash caused by rendering features not available in a dedicated server build
* Skip over MeasureLongGPUTaskExecutionTime when !FApp::CanEvenRender()
#jira UE-48207
Change 3578828 by Daniel.Wright
Disable volumetric lightmap 3d texture creation on mobile
Change 3579473 by Daniel.Wright
Added View.SharedBilinearClampSampler and View.SharedBilinearWrapSampler. Used these to reduce base pass sampler counts with volumetric lightmaps.
Change 3580088 by Jian.Ru
Fix QAGame TM-CharacterMovement crashing on PIE
#jira UE-48031
Change 3580388 by Daniel.Wright
Fixed shadowed light injection into volumetric fog fallout from Rhino merge
Change 3580407 by Michael.Trepka
Updated Mac UnrealPak binaries
Change 3581094 by Michael.Trepka
Fix for ScreenSpaceReflections not working properly on iOS 11
Change 3581242 by Michael.Trepka
Fixed a crash on startup on Mac when launching TM-ShaderModels in QAGame
#jira UE-48255
Change 3581489 by Olaf.Piesche
Replicating CL 3578030 from Fortnite-Main to fix #jira UE-46475
#jira FORT-47068, FORT-49705
Don't inappropriaely touch game thread data on the render thread. Push SubUV cutout data into a RT side object owned by the sprite dynamic data.
#tests FN LastPerfTest
Change 3581544 by Simon.Tovey
Fix for ensure accessing cvar from task thread.
#tests no more ensure
Change 3581934 by Chris.Bunner
Fixed ConsoleVariables.ini break from merge.
Change 3581968 by Jian.Ru
Fix QAGame TM-ShaderModels PIE crash when resizing game viewport
#jira UE-48251
Change 3581989 by Richard.Wallis
Fix for NULL PrecomputedLightingBuffer. It is null for first frame request in forward rendering so should have the GEmptyPrecomputedLightingUniformBuffer set in these cases after it's been initially tried to be set not before.
#jira UE-46955
Change 3582632 by Chris.Bunner
Resolved merge error.
Change 3582722 by Rolando.Caloca
DR - Workaround for PF_R8G8B8A8_UINT on GL
#jira UE-48208
Change 3584096 by Rolando.Caloca
DR - Fix for renderdoc crashing in shipping
#jira UE-46867
Change 3584245 by Jian.Ru
Fix System.Promotion.Editor.Particle Editor test crash
#jira UE-48235
Change 3584359 by Yujiang.Wang
Fix for UE-48315 Wall behind base in Monolith is flickering white in -game Orion
* Caused by dot(N, V) being negative
* Clamp to (0, 1)
#jira UE-48315
Change 3587864 by Mark.Satterthwaite
Fix the GPU hang on iOS caused by changes to the Depth-Stencil MSAA handling: you can't store the MSAA stencil results on iOS < 10 unless you use the slower MTLStoreActionStoreAndMultisampleResolve which we don't need for the mobile renderer.
#jira UE-48342
Change 3587866 by Mark.Satterthwaite
Correctly fix iOS compilation errors against Xcode 9 Beta 5 and Xcode 8.3.3 - duplicating function definitions is guaranteed to be wrong.
Change 3588168 by Mark.Satterthwaite
Move the Xcode version into the Metal shader format header, not the DDC key, so that we can handle bad compiler/driver combinations in the runtime and don't force all users to recompile every time the Xcode version changes.
Change 3588192 by Rolando.Caloca
DR - Fix d3d12 linker error when EXECUTE_DEBUG_COMMAND_LISTS is enabled
Change 3588291 by Rolando.Caloca
DR - Fix for d3d12 command list crash: Commited resources can not have aliasing barriers
#jira UE-48299
Change 3590134 by Michael.Trepka
Copy of CL 3578963
Reset automation tests timer after shader compilation when preparing for screenshots taking to make sure tests don't time out.
Change 3590405 by Rolando.Caloca
DR - hlslcc - support for sqrt(uint)
Change 3590436 by Mark.Satterthwaite
Rebuild Mac hlslcc for CL #3590405 - without the various compiler workarounds left over from before the recent code changes.
Change 3590674 by Rolando.Caloca
DR - vk - Integration from working branch
- Fixes distance field maps
- Compute pipelines stored in saved file
- Adds GRHIRequiresRenderTargetForPixelShaderUAVs for platforms that need dummy render targets
Change 3590699 by Rolando.Caloca
DR - Fix distance fields mem leak
Change 3590815 by Rolando.Caloca
DR - vk - Fixes for uniform buffers and empty resource tables
Change 3590818 by Mark.Satterthwaite
Temporarily switch back to OpenVR v1.0.6 for Mac only until I can clarify what to do about a required but missing API hook for Metal. Re-enabled and fixed compile errors with Mac SteamVR plugin code.
Change 3590905 by Mark.Satterthwaite
For Metal shader compilation where the bytecode compiler is unavailable force the debug compiler flag and disable the archiving flag because storing text requires this.
#jira UE-48163
Change 3590961 by Mark.Satterthwaite
Submitted on Richard Wallis's behalf as he's on holiday:
Mac fixes for Compute Skin Cache rendering issues (resulting in incorrect positions and tangents) and for recomputing tangents. Problem sampling from buffers/textures as floats with packed data. Some of the data appears as denorms so get flushed to zero then reinterpreted as uints via asuint or in Metal as_type<uint>(). Fix here for Metal seems to be to use uint types for the skin cache SRV's and as_type<> to floats instead.
There could be some other areas where we're unpacking via floats that could affect Metal and I'm not sure how this will impact on other platforms.
#jira UE-46688, UE-39256, UE-47215
Change 3590965 by Mark.Satterthwaite
Remove the Z-bias workaround from Metal MRT as it isn't required and actually causes more problems.
Change 3590969 by Mark.Satterthwaite
Make all Metal shader platforms compile such that half may be used, unless the material specifies full precision.
Change 3591871 by Rolando.Caloca
DR - Enable PCSS on Vulkan & Metal
- Enable capsule shadows on Vulkan
Change 3592014 by Mark.Satterthwaite
Remove support for Mac OS X El Capitan (10.11) including the stencil view workaround.
Bump the minimum Metal shader standard for Metal SM4, SM5 & Metal MRT to v1.2 (macOS 10.12 Sierra & iOS 10) so we can use FMAs and other newer shader language features globally.
Enable the new GRHIRequiresRenderTargetForPixelShaderUAVs flag as Metal is like Vulkan and needs a target for fragment rendering.
Also fix the filename for direct-compile & remove the old batch file generation in the Metal shader compiler.
Change 3592171 by Rolando.Caloca
DR - CIS fix
Change 3592753 by Jian.Ru
repeat Daniel's fix on xb1 profilegpu crash (draw events cannot live beyond present)
Change 3594595 by Rolando.Caloca
DR - Fix D3D shader compiling run time stack corruption failure on debug triggering falsely
Change 3594794 by Michael.Trepka
Call FPlatformMisc::PumpMessages() before attempting to toggle fullscreen on Mac to fix an issue on some Macs running 10.13 beta that would ignore the toggle fullscreen call freezing the app
Change 3594999 by Mark.Satterthwaite
Disable MallocBinned2 for iOS as on Rhino it worked but on iOS 10.0.2 there are bugs (munmap uses 64kb granularity, not the 4096 the code expects given the reported page-size).
While we are here remove the spurious FORCE_MALLOC_ANSI from the iOS platform header.
#jira UE-48342
Change 3595004 by Mark.Satterthwaite
Disable Metal's Deferred Store Actions and combined Depth/Stencil formats on iOS < 10.3 as there are bugs on earlier versions of iOS 10.
#jira UE-48342
Change 3595386 by Mark.Satterthwaite
Silence the deprecation warning for kIOSurfaceIsGlobal until SteamVR switches to one of the newer IOSurface sharing mechanisms.
Change 3595394 by Rolando.Caloca
DR - Added function for tracking down errors in the hlsl parser
- Added support for simple #if 0...#endif
Change 3599352 by Rolando.Caloca
DR - Fixes for HlslParser
- Added missing attributes for functions
- Fixed nested assignment
Change 3602440 by Michael.Trepka
Fixed Metal shader compilation from Windows with remote compilation disabled
#jira UE-48163
Change 3602898 by Chris.Bunner
Resaving assets.
Change 3603731 by Jian.Ru
fix a crash caused by a material destroyed before the decal component
#jira UE-48587
Change 3604629 by Rolando.Caloca
DR - Workaround for PF_R8G8B8A8_UINT on Android
#jira UE-48208
Change 3604984 by Peter.Sauerbrei
fix for orientation not being limited to that specified in the plist
#jira UE-48360
Change 3605738 by Chris.Bunner
Allow functional screenshot tests to request a camera cut (e.g. tests relying on temporal aa history).
#jira UE-48748
Change 3606009 by Mark.Satterthwaite
Correctly implement ClipDistance for Metal as an array of floats as required by the spec. and fix a few irritating issues from the merge that should not have.
- When compiling a tessellation vertex shader in the SCW direct mode we can't evaluate non-existant defines and we don't actually need to.
- The define names, values & shader file name are irrelevant to the Metal output key, but the shader format name & Metal standard really do matter - should speed up Metal shader compilation a bit.
- Move the shader vertex layer clip-distance to index 2 to avoid conflicts.
- Don't default initialise the debug code string for Metal shaders or it won't print out the actual code....
#jira UE-47663
Change 3606108 by Mark.Satterthwaite
Temporary hack to avoid a crash in AVPlayer.
#jira UE-48758
Change 3606121 by Mark.Satterthwaite
Fix Windows compilation.
Change 3606992 by Chris.Bunner
Static analysis fix.
[CL 3608256 by Marcus Wassmer in Main branch]
#lockdown Nick.Penwarden
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3459524 by Marc.Audy
Get/Set of properties that were previously BPRW/BPRO should error when used
#jira UE-20993
Change 3460004 by Phillip.Kavan
#jira UE-45171 - Fix C++ compilation failures during packaging caused by nativizing a Blueprint that overrides a native function with a 'TSubclassOf' parameter or return value.
Change summary:
- Modified FKismetCompilerContext::CreateParametersForFunction() to pass the 'CPF_UObjectWrapper' flag through to new function parameter properties during Blueprint compilation.
Change 3461210 by Phillip.Kavan
#jira UE-44505 - Fix occasional Blueprint editor crashes that could occur while rebuilding the context menu from the action registry.
Change summary:
- Modified FBlueprintActionDatabase::FActionRegistry to use an FObjectKey as the key type. This allows us to test entries for UObject validity before rebuilding context menu items based on the action database.
- Changed FBlueprintActionInfo::CachedOwnerClass to be a TWeakObjectPtr rather than a raw UClass* since it's based on the ActionOwner, which could potentially become invalid after the OwnerClass has been cached.
- Modified FBlueprintActionDatabase::RefreshAssetActions() to exclude World assets if the WorldType is not EWorldType::Editor. This eliminates an issue with unreferenced "inactive" GC'd world objects being left in the BP action registry after cooking, at which point the keys could become invalid.
- Added FBlueprintActionDatabase::DeferredRemoveEntry() to allow for scheduling removal of entries from outside of the database if they are known to be invalid.
- Modified FBlueprintActionDatabase::Tick() to handle deferred entry removals.
- Modified FBlueprintActionMenuBuilder::RebuildActionList() to both test actions for validity before building menu items and schedule removal of invalid actions on the next tick.
Notes:
- Alternatively we could just include UObject keys in the database's AddReferencedObject impl, but that would then prevent objects from ever being GC'd if they are not explicitly removed. For most entries the action database takes the approach of explicitly removing entries via delegate when the UObject is destroyed, so I chose to use a TWeakObjectPtr instead so that any entries that may not be getting explicitly removed via delegate will now simply become invalidated if the UObject key is GC'd due to not being referenced. I also set it up to clean and remove any entries (along with any associated node spawners) that are found to be invalid the next time we open the BP editor.
Change 3461373 by Lukasz.Furman
fixed async navmesh rebuilds not kicking in for requests from navdata.bForceRebuildOnLoad
#jira UE-44231
Change 3461409 by Lukasz.Furman
fixed reenabling automatic navmesh generation in Editor Preferences
#ue4
Change 3461550 by Ben.Zeigler
#jira UE-45328 Fix local variable support for Redirectors and other save-time validation. We need to run the local variables to UProperty and back at save time
Add new flag PPF_SerializedAsImportText which is used for BP pins/default values and indicates that something has been serialized as import text and so needs to handle string asset redirectors
Change 3462625 by Zak.Middleton
#ue4 - Fix InterpToMovementComponent not setting velocity on the object it moves. Fix movement rate when substepping enabled (other related fixes to come).
github PR #3620
Change 3462796 by Dan.Oconnor
Fix for spamming BroadcastBlueprintReinstanced and for creating CDO at wrong time when compiling FrontEnd.uasset in OrionGame
#jira UE-45434
Change 3462995 by Ben.Zeigler
#jira UE-16941 Fix it so Load Asset node works with a literal value as well as a connected pin
Change 3463099 by Ben.Zeigler
#jira UE-45471 Allow abstract base classes for primary assets
Change 3464809 by Marc.Audy
Expose FVector2D / FVector2D to blueprints
#jira UE-45427
Change 3467254 by Mieszko.Zielinski
Added an AI helper BP function that supplies caller with a copy of navigation path given controller is currently following #UE4
Change 3467644 by Dan.Oconnor
Fix for cook issues in ocean when using compilation manager, one issue caused by bad dependencies list, one issue caused by lack of subobject mapping in archetype reinstancing.
#jira UE-45443, UE-45444
Change 3468176 by Dan.Oconnor
Fix dependent blueprints being marked dirty when a blueprint is compiled
Change 3468353 by Michael.Noland
UnrealHeaderTool: Improved the warning generated when missing Category= on a function or property declared in an engine module, and centralized the logic that determines if the module is engine or game
Change 3470532 by Dan.Oconnor
Re-enable compilation manager
Change 3470572 by Dan.Oconnor
Fix for pin paramters resetting when an archetype was reinstanced
#jira UE-45619
#rnx
Change 3471949 by Mason.Seay
Adding Primary Assets for testing
Change 3472074 by Ben.Zeigler
#jira UE-45140 Convert iterative cooking to use the Asset Registry as it's only mode, remove old hash and timestamp versions. This allows deleting the entire PackageDependencyInfo module
Change the asset registry iteration to not compute a hash at all, and instead store the script package guids in it's cache.
Expose bIgnoreIniSettingsOutOfDateForIteration and bIgnoreScriptPackagesOutOfDateForIteration in cooker settings, affects rather to listen to ini/script changes when doing iterative cooking
Change 3472079 by Ben.Zeigler
With new incremental cook options, change Fortnite to never care about ini settings, but do care about code changes. This can be changed but from previous discussions we wanted to be more safe than fast here
Change 3473429 by Lukasz.Furman
changed path following update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473476 by Lukasz.Furman
changed crowd simulation path update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473663 by Ben.Zeigler
Fix it so base k2node registers framework version, this is needed for the assetptr fixup I previously added
Change 3473679 by Mason.Seay
Slight cleanup of test map and added ability to teleport across level for easy navigation
Change 3473712 by Marc.Audy
Do default value validation against the actual value of the default entry of an enum rather than the serialized empty autogenerated default value
Change 3474055 by Marc.Audy
When nodes are reconstructed any pins that were previously linked or set to non-default values that have been removed will no longer simply vanish, but instead will remain in an Orphaned state until dealt with.
#jira UE-41828
Change 3474119 by mason.seay
Tweaked Force Feedback test
Change 3474156 by Marc.Audy
Actually enable orphan pin retention
Change 3474382 by Ben.Zeigler
Class.h Header and comment cleanup. Started this because IsChildOf did not have a comment and it's usage is a bit confusing
Change 3474386 by Ben.Zeigler
Close popup window when adding asset class to audit window
Change 3474491 by Ben.Zeigler
Remove ability for Worlds to not be saved as assets, this has been the default since 2014.
Change 3475363 by Marc.Audy
Alt-click now works with orphaned pins
#jira UE-45699
Change 3475523 by Marc.Audy
Fixup Fortnite and Paragon content for orphaned pin errors and warnings
Change 3475623 by Phillip.Kavan
#jira UE-45477 - Fix an EDL assertion on load in a nativized build with one or more Actor subobjects instanced via the EditInlineNew UI in the BP class defaults property editor.
Change summary:
- Modified FEmitDefaultValueHelper::OuterGenerate() to emit code to construct/initialize instanced subobject values that do not have the RF_DefaultSubObject flag set, and also to recursively handle nested subobjects for those values.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to alternatively emit a 'NewObject' assignment statement rather than a 'CreateDefaultSubobject' statement if only RF_ArchetypeObject is set on the source object value.
Change 3476008 by Dan.Oconnor
Fix for failing to preload our super class's subobjects. Effectively moving UBlueprint::ForceLoad calls earlier in loading process. This only results in data resetting to your parent's parent's default value from your parent's default value.
#jira UE-18765
Change 3476115 by Dan.Oconnor
Fix missing category information for inherited functions when using compilation manager
#jira UE-45660
#rnx
Change 3476577 by Lukasz.Furman
added early outs from navmesh layer generation when there's no walkable cells or contours to avoid allocating 0 bytes by next generation steps (behavior differs between platforms)
#ue4
Change 3476587 by Phillip.Kavan
#jira UE-45517 - Fix a regression in which dragging UMG widgets around in the designer view results in redundantly-compounded BP class properties and context menu actions.
Change summary:
- Modified SDesignerView::ClearDropPreviews() to move the widget that was removed from the tree into the transient package. This ensures that FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() won't pick them up.
- Modified SDesignerView::ProcessDropAndAddWidget() to also consider any widgets not added to the 'DropPreviews' array as being transient (i.e. also move them into the transient package since they were not added to the tree).
Notes:
- The regression was introduced by the changes in CL# 3410168, and was merged to Main at CL# 3431398.
#rnx
Change 3476723 by Dan.Oconnor
Match old behavior wrt updating implemented interfaces in blueprints - this logic from FKismetEditorUtilities::CompileBlueprint was missing in compilation manager
#jira UE-45468
#rnx
Change 3476948 by Michael.Noland
Framework: Changed AActor::FindComponentByClass (and AActor::GetComponentByClass by extension) to return nullptr when passed a nullptr class, rather than crashing
Change 3476970 by Ben.Zeigler
Fix bug I introduced in 4.16 where assigning assets to multiple chunks did not work properly
Change 3477536 by Marc.Audy
Don't display default value box on linked orphaned input pins
Change 3477835 by Marc.Audy
Fix pins orphaned by deletion of an entry in a user-defined enum disappearing instead of remaining connected
#jira UE-45754
Change 3478027 by Marc.Audy
Minor performance optimization
#rnx
Change 3478198 by Phillip.Kavan
#jira UE-42431 - Remove an unnecessary ensure() when pasting an event node.
Change summary:
- Modified UEdGraphSchema_K2::CreateSubstituteNode() to no longer ensure() that we have a valid PreExistingNode; it's only used for logging when a substitute node is created in response to a conflict with an existing node.
Change 3478485 by Marc.Audy
Eliminate extraneous error messages about orphaned pins on get/set nodes
#jira UE-45749
#rnx
Change 3478756 by Marc.Audy
Fix fallout from changes to DoesDefaultValueMatchAutogenerated for user defined enums
#jira UE-45721
#rnx
Change 3478926 by Marc.Audy
Non-blueprint type structs can no longer be made/broken
Non-blueprint visible properties in structs will no longer have pins created for them
#jira UE-43122
Change 3478988 by Marc.Audy
DeltaTime for a tick function with a tick interval is now correct after disabling and then reenabling the tick function.
#jira UE-45524
Change 3479818 by Marc.Audy
Allow ctrl-drag off of orphan pins
#jira UE-45803
Change 3480214 by Marc.Audy
Modifications to user defined enumerations are now transacted
#jira UE-43866
Change 3480579 by Marc.Audy
Maintain all pin properties through transactions.
#rn Reference pins that are removed and then restored via undo now correctly have the diamond icon instead of the standard circle.
Change 3481043 by Marc.Audy
Make/Break of structs does not depend on having blueprint exposed properties.
Splitting of a struct pin still requires blueprint exposed properties.
#jira UE-45840
#jira UE-45831
Change 3481271 by Ben.Zeigler
Fix the AssetManager chunking code to use ChunkDependencyInfo instead of a hardcoded check for chunk 0
Clean up ChunkDependencyInfo and make it properly public
Move ShouldSetManager to be WITH_EDITOR
Ported from WEX branch
#RB peter.sauerbrei
Change 3481373 by Dan.Oconnor
Reduce reliance on expensive FindDelegateSignature. 3275922 made warnings about a ambiguous search more likely as it preserved names of members on the REINST_ classes
#jira UE-45704
Change 3481380 by Ben.Zeigler
Change it so Struct and Object AssetRegistrySearchable properties do not show up in content browser, they are not helpful
Change 3482362 by Marc.Audy
Fix properties not exposed to blueprint warnings for input properties on function graphs.
#jira UE-45824
Change 3482406 by Ben.Zeigler
#jira UE-45883 Fix Switch On Gameplay Tag Container node, and add switch nodes to TagCheck map
Change 3482498 by Ben.Zeigler
Attempt to fix hot reload issues with Asset Manager. We need to reset and re-acquire the asset classes when rescanning, as they may be pointing to the replaced class
Change 3482517 by Lukasz.Furman
fixed smart navlink update functions removing important flag
#jira UE-45875
Change 3482538 by Marc.Audy
When comparing float, vector, and rotator values for whether the the default matches the autogenerated do not use the string compare because differences in use of decimal or number of 0s after decimal are then considered not the same float
#jira UE-45846
Change 3482773 by Marc.Audy
Don't show default value or pass by reference for exec pins
#jira UE-45868
Change 3482791 by Ben.Zeigler
#jira UE-45800 Correctly dirty game mode blueprint when changing player controller/etc classes from game mode customization
Fix it so MarkBlueprintAsStructurallyModified calls MarkBlueprintAsModified as several fixes were only in the second function
Change 3483131 by Zak.Middleton
#ue4 - InterpToMovementComponent:
- Fix velocity not zeroed when interpolation stops.
- Various fixes when calculating velocity and time when substepping is enabled.
- Improve accuracy of interpolation when looping and there is time remaining after the loop event is hit. Consume the remainder of the time after the event back in the loop (similar to handling a blocking impact).
#jira UE-45690
Change 3483146 by Phillip.Kavan
#jira UE-38358 - Propagate 'const' function flag from interface Blueprint to implementing Blueprints.
Change summary:
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified() to call SkeletalRecompileChildren() on dependent BPs when the target is an interface BP.
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified::FRefreshHelper::SkeletalRecompileChildren() to set child BP status to BS_Dirty after compiling.
- Modified ConformInterfaceByName() (FBlueprintEditorUtils) to use the interface's skeleton class for function iteration as well as to match the Function Entry node's 'const' setting to the interface UFunction's signature.
Change 3483340 by Ben.Zeigler
Fix issue querying asset registry after a hot reload, make sure pending kill objects are never considered to be Assets
Change 3483548 by Michael.Noland
Epic Friday: Playing around with some prototype traps
Change 3483700 by Phillip.Kavan
Fix CIS cook crash introduced by last submit.
#rnx
Change 3485217 by Ben.Zeigler
#jira UE-45519 Fix regression introduced in 4.16 where it would no longer cook all maps when no explicit maps were specified in ini or game callback. Moved the code that detects changes before culture/default map code and hardened it to deal with the case where some engine packages were already in the list before it entered the function
Change 3485367 by Dan.Oconnor
Avoid adding mappings to anim node when creating variables on the skeleton class and using the compilation manager
#jira UE-45756
Change 3485565 by Ben.Zeigler
#jira UE-45948 Fix compilation manager to properly reset variable default values after promoting a pin to local variable
Change 3485566 by Marc.Audy
Fix crashes caused by undo/redo of user defined struct changes
#jira UE-45775
#jira UE-45781
Change 3485805 by Michael.Noland
PR #3459: Fix for world origin shifting and SpringArmComponent location lag (Contributed by michail-nikolaev)
#jira UE-43747
Change 3485807 by Michael.Noland
PR #3485: Added additional textures field to paper 2d tileset class (Contributed by gryphonmyers)
#jira UE-44041
Change 3485811 by Michael.Noland
Framework: Fixed a bug in FStreamLevelAction::MakeSafeLevelName to avoid appending the PIE prefix multiple times (fixes functions like Unload Streaming Level when passed a full package name from an instanced streaming level)
Change 3485829 by Michael.Noland
Framework: Made GetWorldAssetPackageFName BlueprintCallable so instanced levels can be unloaded
Change 3485830 by Michael.Noland
PR #3568: add API declarations to ALevelStreamingVolume methods (Contributed by kayama-shift)
#jira UE-45002
Change 3486039 by Michael.Noland
PR #3495: UE-44014: Refreshing node error fixes (Contributed by projectgheist)
- Empty out the ErrorMsg when a node gets refreshed to prevent the same error messages from compounding
- Added support for split pins in UK2Node_Event::IsFunctionEntryCompatible
- Added a missing check for the delegate pin name on the entry node part of UK2Node_Event::IsFunctionEntryCompatible
#jira UE-44014
Change 3486093 by Michael.Noland
PR #3379: Added GAMEPLAYABILITIES_API to all Ability Tasks. (Contributed by ryanjon2040)
#jira UE-42903
Change 3486139 by Michael.Noland
Blueprints: Added new config options for execution wire thickness when not debugging (DefaultExecutionWireThickness) and data wire thicknesses (DefaultDataWireThickness) to the Graph Editor Settings page
#rn
Change 3486154 by Michael.Noland
Framework: Speculative fix for CIS error about FStructOnScope
#rnx
Change 3486180 by Dan.Oconnor
Better match old logic for determining when to skip data only compile
#jira UE-45830
Change 3487276 by Marc.Audy
Fix crash when using Setter with a locally scoped variable
#rnx
Change 3487278 by Marc.Audy
Ensure that pin change notifications occur on all pin breaks unless it is part of a node being garbage collected
Change 3487658 by Marc.Audy
Ensure that child actor template is created for subclasses
#jira UE-45985
Change 3487699 by Marc.Audy
Move non-templated elements out of FArchiveReplaceObjectRef and put them in FArchiveReplaceObjectRefBase
Change 3487813 by Dan.Oconnor
Asset demonstrating a crash
Change 3488101 by Marc.Audy
Fix crash with spawn/construct actor/object from class nodes when they no longer had any pins.
Correctly orphan pins when a node goes to 0 pins.
Change 3488337 by Marc.Audy
Editable pin base should not manually remove pin and let reconstruct node and rewire pins do their job
#jira UE-46020
Change 3488512 by Dan.Oconnor
ConstructObject nodes and SubInstances nodes use skeleton class when compilation manager can provide it
#jira UE-45830, UE-45965
#rnx
Change 3488631 by Michael.Noland
Framework: Fixed a crash when loading a blueprint with a parent class of ALevelBounds caused by trying to register the class default object with a non-existent level
#jira UE-45630
Change 3488665 by Michael.Noland
Blueprints: Improve the details panel customization for optional pin nodes like Struct Member Get/Set
- The category, raw name, and tooltip of the property are now included as part of the filter text as well
- The property tooltip is now displayed when hovering over the property name
- Code updated to use GET_MEMBER_NAME_CHECKED() where appropriate
Change 3489324 by Marc.Audy
Fix recursion causing stack crash
#jira UE-46038
#rnx
Change 3489326 by Marc.Audy
Fix cooking crash
#jira UE-46031
#rnx
Change 3489687 by mason.seay
Assets for testing orphan pins
Change 3489701 by Marc.Audy
Back out changelist 3487278 and 3489443 and make targetted changes for fixing up orphan pin cases where changing connections doesn't remove the pin.
#jira UE-46051
#jira UE-46052
#rnx
Change 3490352 by Dan.Oconnor
Fix for missing WidgetTree on Skeleton class - just look directly at the WidgetBlueprint
#jira UE-46062
Change 3490814 by Marc.Audy
Make callfunction/macro instances save all pins in orphan state more similar to previous behavior
#rnx
Change 3491022 by Dan.Oconnor
Properly clean up 'Key' property when we fail to create a value property
#jira UE-45279
Change 3491071 by Ben.Zeigler
#jira UE-45981 Fix rotation issues, vector/rotator pins with empty strings were not matching due to uninitialized memory.
Change 3491244 by Michael.Noland
Blueprints: Add compile time message back to the output log (will not auto-open the output log if there were no warnings/errors)
#jira UE-32948
Change 3491276 by Michael.Noland
Blueprints: Fixed some bugs where a newly added item would fail show up in the "My Blueprints" tree if there was a filter active (e.g., when promoting a variable)
- Centralized the logic for clearing the filter so it happens when we try and fail to select the item, rather than ad hoc in various other places
- Made it only clear the filter if necessary, rather than (almost) always clearing it when adding an item
#jira UE-43372
Change 3491562 by Marc.Audy
Put back pin removal in to editable pin base and instead modify the pin destroy implementation to take down child split pins with it
#jira UE-46020
#rnx
Change 3491658 by Marc.Audy
Unify RemoveUserDefinedPin implementations. Use version that has break to avoid size change assert
#rnx
Change 3491946 by Marc.Audy
ReconstructSinglePin no longer destroys OldPin (avoids oprhaned sub pins being destroyed before reparented)
RewireOldPinsToNewPins now destroys OldPins at the end (calling code no longer reponsible)
DestroyImpl now prunes out SubPins that had already been trashed
#rnx
Change 3492040 by Marc.Audy
Discard exec/then pins from a callfunction that has been converted to a pure node
#rnx
Change 3492200 by Zak.Middleton
#ue4 - Always reset the input array in AActor::GetComponents(), but do so without affecting allocated size.
Fixes possible regression from CL 3359561 that removed the Reset(...) entirely.
#jira UE-46012
Change 3492290 by Ben.Zeigler
#jira UE-46108 Fix StringLibrary Mid to never crash, Substring had already been fixed
Change 3492311 by Marc.Audy
Don't clear the pin type if what you're connecting to's pin type is wildcard
#rnx
Change 3492680 by Dan.Oconnor
Handle missing generated class when using compilation manager - tested by forcing compile of BP_ParentClassIsMissingType.uasset
Change 3492826 by Marc.Audy
Don't do pin connection list change notifications from DestroyPins while regenerating on load
#jira UE-46112
#rnx
Change 3492851 by Michael.Noland
Core: Fixed various crashes when using UObject::CallFunctionByNameWithArguments with non-trivial argument types by properly initializing the allocated parameters
Change 3492852 by Michael.Noland
Framework: Fixed a crash if ACharacter::FindComponentByClass was passed a nullptr class
Change 3492934 by Marc.Audy
Fix ensure and crash delete macro containing orphaned pin
#rnx
Change 3493079 by Dan.Oconnor
Fix for crash when opening ThirdPersonAnimBlueprint and ThirdPersonAnimBlueprint_Perf then clicking 'Compile' button in ThirdPersonAnimBlueprint editor. Make sure the convenience members in the derived compilers get set when we relink child classes (which requires making cdos, which requires PropagateValuesToCDO..)
#rnx
Change 3493346 by Phillip.Kavan
#jira UE-40560 - Fix a reported crash when pasting nodes between unrelated Blueprint graphs.
Change summary:
- Modified FEdGraphUtilities::PostProcessPastedNodes() to ensure() on a NULL pin entry; this will allow execution to continue while still alerting us since it is an unexpected result. Also added an 'else' case to then remove the NULL entry so that PostPasteNode() implementations don't all have to guard against NULL pin entries. When the node is reconstructed, the NULL entry will be replaced with the correct pin initialized to its default values.
- Modified UEdGraphPin::ImportTextItem() to add some additional logging to parse error cases when importing pin properties from source T3D text. Hopefully this gives us more information when this is encountered in the future.
Change 3493938 by Michael.Noland
Blueprints: Prevent issues with renaming event dispatchers to contain periods (this may be disallowed in the future, but they no longer become uneditable)
#jira UE-45780
Change 3493945 by Michael.Noland
Blueprints: Fixed GetDelegatePoperty typos
#rnx
Change 3493997 by Michael.Noland
Blueprints: Partially reverting changes from CL# 3319966 to reroute nodes, restoring their alignment but losing the symmetrical grab handle changes
#jira UE-45760
Change 3493998 by Dan.Oconnor
Fix rare crash in RefreshStandAloneDefaultsEditor when the blueprint editor is opened and a blueprint had errors in it
Note: I stumbled across this by running a unit test and then opening a blueprint in the BPE. CrashReporter indicates 3 crashes in the last 3 days
Change 3494025 by Michael.Noland
Engine: Deleted some dead code (DEBUGGING_VIEWPORT_SIZES)
#rnx
Change 3494026 by Michael.Noland
Blueprints: V0 of a BlueprintCallable/BlueprintPure function fuzzer
- Calls exposed methods with default parameters on classes it is able to spawn for now, which catches crashes due to null and /0 but not out of bounds issues or ones on classes it can't spawn due to classwithin, abstract, etc...
- Can be called using Test.ScriptFuzzing, won't be integrated into automated tests until it is more fully fleshed out and all known issues are addressed
#rnx
Change 3496382 by Ben.Zeigler
Fix ensure when launching editor with cook on the side and incremental cooking enabled. It now flushes the background asset gather when calling the sync load all assets if one is in progress
Change 3496688 by Marc.Audy
Avoid crashing in component instance data if (for some reason) the Actor's root component isn't properly set up
#jira UE-46073
Change 3496830 by Michael.Noland
Editor: Change FEditorCategoryUtils methods to take UStruct* instead of UClass*, as they are just reading metadata
#rnx
Change 3496840 by Michael.Noland
Framework: Remove the requirement for a local player in UCheatManager::CheatScript, so it can be be started from the server side (doesn't change the availability of the cheat manager, just allows things like the redundant "cheat cheatscript scriptname" to work)
Change 3497038 by Michael.Noland
Fortnite: Added UFortDeveloperSettings to allow developers to auto-run cheats in PIE (does not occur in -game or outside of WITH_EDITOR builds)
- You can specify a list of cheat commands to run when a pawn is possessed (also needs CL# 3496840 for cheatscripts)
- You can also specify a set of items to grant to your local inventory when it is created
Change 3497204 by Marc.Audy
Fix AbilitySystemComponent not being blueprint readable.
#rnx
Change 3497668 by Mieszko.Zielinski
Fixed a crash in BT editor when dealing with enum-typed Blackboard-keys pointing to enum values that have been deleted #UE4
#jira UE-43659
Change 3497677 by Mieszko.Zielinski
Added a community-suggested working solution to patching up dynamic navmesh after world offset #UE4
Also, fixed a crash related to navmesh rebuilding if generation was configured to lazily gather navigatble geometry
#jira UE-41293
Change 3497678 by Mieszko.Zielinski
Marked AbstractNavData class as transient #UE4
We never want to save it to levels
Change 3497679 by Mieszko.Zielinski
Made NavModifierVolume responsive to editor-time property changes #UE4
#jira UE-32831
Change 3497900 by Dan.Oconnor
Fix bad skel reference when using construct object from class, just limiting scope of 3491946. To reproduce the bug just nativize QA Game, including the TM-Gameplay level
#rnx
Change 3497904 by Dan.Oconnor
Use K2Node_Event::FindEventSignatureFunction in order when directly generating the skeleton generated class to get event params correct
#jira UE-46153
#rnx
Change 3497907 by Dan.Oconnor
Correctly set blueprint visibility flags on params for inherited functions when generating the skeleton class
#rnx
#jira UE-46186
Change 3498218 by mason.seay
Updates to pin testing BP's
Change 3498323 by Mieszko.Zielinski
Made UNavCollision instance assigned to StaticMesh not get re-created from scratch every single time any StaticMesh property changes #UE4
Recreation was resulting in some of the UNavCollision's properties not getting saved and the way we were recreating the nav collision could also interfere with undo buffers
#jira UE-44891
Change 3499007 by Marc.Audy
Allow systems to hook Pre and PostCompile to do custom behaviors
Change 3499013 by Mieszko.Zielinski
Made AbstractNavData class non-transient again #UE4
Implemented AbstractNavData instances' transientness in a different manner.
#jira UE-46194
Change 3499204 by Mieszko.Zielinski
Introduced CrowdManagerBase, an engine-level class that can be extended to implement custom crowd management #Orion
Extracted FRecastQueryFilter into a separate file, which will break some peoples' compilation.
#jira UE-43799
Change 3499321 by mason.seay
Updated bp for struct testing
Change 3499388 by Marc.Audy
Allow the compiler log to store off potential messages from earlier in the compile cycle (early validation), that can be committed later (for example once pruning is completed).
Change 3499390 by Marc.Audy
Generate the orphan pin error messages during EarlyValidation, but cache until the regular validation phase. This ensures all are generated, but only those that aren't pruned will be emitted.
#rnx
Change 3499420 by Michael.Noland
Engine: Introduced a new version of UEngine::GetWorldFromContextObject which takes an enum specifying the behavior on failures and updated all existing uses
The new version intentionally does not have a default value for ErrorMode, callers need to think about which variant of behavior they want:
- ReturnNull: Silently returns nullptr, the calling code is expected to handle this gracefully
- LogAndReturnNull: Raises a runtime error but still returns nullptr, the calling code is expected to handle this gracefully
- Assert: Asserts, the calling code is not expecting to handle a failure gracefully
- Deprecated UEngine::GetWorldFromContextObject(object, boolean) and changed the default behavior for the deprecated instances to do LogAndReturnNull rather than Assert, based on the real-world call pattern
- Introduced GetWorldFromContextObjectChecked(object) as a shorthand for passing in EGetWorldErrorMode::Assert
- Made UObject::GetWorldChecked() actually assert if it would return nullptr (under some cases the old function could silently return nullptr while reporting bSupported = true, so it neither ensured nor checked)
- Fixed a race condition in the 'is implemented' bookkeeping logic in GetWorld()/GetWorldChecked() by confining it to the game thread and added a check() to ImplementsGetWorld() to make it clear that it only works on the game thread
The typical recommended call pattern is to use something like:
if (UWorld* World = GEngine->GetWorldFromContextObject(WorldContextObject, EGetWorldErrorMode::LogAndReturnNull))
{
... Do something with World
}
Handling the failure case but requesting a log message (with BP call stack printed out) if it failed. This is now also the default behavior for old calls to UEngine::GetWorldFromContextObject(Object) (using the default value of bChecked=true), which is a behavior change but it matches how the function was being used in practice; the vast majority of call sites actually expected it to potentially fail and handled the nullptr case gracefully; very few places used the return value unguarded and wanted it to assert when passed a nullptr.
#jira UE-42458
Change 3499429 by Michael.Noland
Engine: Removed a bogus TODO (the problematic code had already been reworked)
#rnx
Change 3499470 by Michael.Noland
Core: Improved and corrected the comment for ensure()
- It doesn't crash when checking is disabled (and hasn't since UE3, maybe ever?)
- It now only fires once per ensure() by default, added a note about ensureAlways()
#rnx
Change 3499643 by Marc.Audy
Use TGuardValue instead of manually managing it
#rnx
Change 3499874 by Marc.Audy
Display <Unnamed> instead of nothing for Pins with blank display name in the compiler log
Change 3499875 by Marc.Audy
When changing function parameter types, don't orphan a pin on the function entry/exit nodes (but do at the call sites)
#jira UE-46224
Change 3499927 by Dan.Oconnor
UField::Serialize no longer serialize's its next ptr, UStruct::Serialize serializes all Children properties instead. This resolves a hard circular dependency between function libraries that EDL detected. It was resolved in an ad hoc way by the old linker
#jira UE-43458
Change 3499953 by Michael.Noland
Core: Created a variant of ensure that does runtime error logging without stopping in the debugger and some related functions that print a warning or error and may trigger a BP callstack (under the same rules as FFrame::KismetExecutionMessage)
- These are WIP and the API may change in the future, but are being used to fix various crashes found by fuzzing BP exposed functions
Change 3499957 by Michael.Noland
Animation: Added runtime errors for nullptr ControlRigs passed into BP methods
#rnx
Change 3499958 by Michael.Noland
Blueprints: Changed an ensure in UKismetNodeHelperLibrary::GetValidValue to a runtime error
#rnx
Change 3499959 by Michael.Noland
Engine: Downgrade various checks() to ensures() in the runtime asset cache functions exposed to Blueprints
Change 3499960 by Michael.Noland
AI: Changed UBTFunctionLibrary to not check/ensure if passed a null world context object
Change 3499968 by Michael.Noland
Editor: Fixed a couple of crashes in UEditorLevelUtils when passed nullptr arguments, and reformatted the entire file to fix widespread indentation issues
#rnx
Change 3499969 by Michael.Noland
Engine: Changed the verbosity of the failure log message of UEngine::GetWorldFromContextObject(..., LogAndReturnNull) from Warning to Error, so it always prints out a BP callstack
#rnx
Change 3499973 by Michael.Noland
Rendering: Fixed asserts in various UKismetRenderingLibrary methods if passed a nullptr for the WorldContextObject
- Also fixed flipped warnings in the failure cases for EndDrawCanvasToRenderTarget
Change 3499979 by Michael.Noland
Editor: Prevented a crash in UMaterialEditingLibrary::RecompileMaterial when passed a nullptr material
Change 3499984 by Michael.Noland
Physics: Prevented a crash in UTraceQueryTestResults::AssertEqual when passed in nullptr for Expected
Change 3499993 by Michael.Noland
Blueprints: Added validation when renaming variables, functions, components, multicast delegates, etc... to prevent names from containing some unacceptable characters
- This validation only kicks in when trying to rename an item, so bad names in existing content are 'grandfathered in'
- These bad names can cause bugs when working with content that contains these characters (e.g., names that contain a period cannot be found via FindObject<T>)
- Currently only . is banned, but eventually we may expand it to include all of INVALID_OBJECTNAME_CHARACTERS
Change 3500009 by Michael.Noland
Blueprints: Made the fuzzer skip classes declared in UnrealEd for now (some of the exposed methods change global state that can cause other tests to fail as the fuzzer isn't particularly sandboxed ATM)
#rnx
Change 3500011 by Michael.Noland
Android: Fixed a crash in UAndroidPermissionFunctionLibrary::AcquirePermissions when called with an empty array on non-Android platforms
Change 3500012 by Michael.Noland
Editor: Prevent a crash in UEditorTutorial::OpenAsset when passed a nullptr Asset
Change 3500014 by Michael.Noland
Engine: Changed FRuntimeAssetCacheFilesystemBackend::ClearCache(NAME_None) to not try to clear all cache directories (there is a separate no-args method for that)
Change 3500019 by Michael.Noland
Core: Fixed some more issues with CallFunctionByNameWithArguments and initializing / destroying parameters
- It was skipping the return value and incorrectly relying on the FirstPropertyToInit list which isn't set for by ref arguments
Change 3500020 by Michael.Noland
Automation: Prevent UFunctionalTestingManager::RunAllFunctionalTests and UFunctionalTestingManager* UFunctionalTestingManager::GetManager from crashing when a manager cannot be created (because we can't route to a world)
Change 3501062 by Marc.Audy
MakeArray AddInputPin is often used as part of node expansion, so need to move the transaction out of the function
Fix inability to undo/redo pin additions to sequence node
Add a K2Node_AddPinInterface to generalize the interface that K2Nodes implement to interact with SGraphNodeK2Sequence so it can be more generally used
#jira UE-46164
#jira UE-46270
Change 3501330 by Michael.Noland
AI: Fix an error on shutdown when the CDO of UAIPerceptionComponent tries to clean up (as it was never registered in the first place)
#jira UE-46271
Change 3501356 by Marc.Audy
Fix crash when multi-editing actor blueprints
#jira UE-46248
Change 3501408 by Michael.Noland
Core: Improve the print-out of FFrame::GetStackTrace() / FFrame::GetScriptCallstack() when there is no script stack (e.g., when FFrame::KismetExecutionMessage is called by native code with no BP above in the call stack)
Change 3501457 by Phillip.Kavan
#jira UE-46054 - Fix crash when launching a packaged build that includes a nativized Blueprint instance with a ChildActorComponent instanced via an AddComponent node.
Change summary:
- Removed UK2Node_AddComponent::PostDuplicate(). This eliminates the creation of redundant component templates that were being unnecessarily created during the Blueprint duplication that precedes the nativization pass.
- Modified SMyBlueprint::OnDuplicateAction() to call MakeNewComponentTemplate() in response to a graph duplication action within the same Blueprint context (replaces previous UK2Node_AddComponent::PostDuplicate() impl).
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to force AddComponent-based CAC-owned template objects in the emitted codegen to use the UDynamicClass as the Outer when instancing. This matches what we already do for SCS-based CAC-owned template objects - that logic was added in CL# 3270456, and this matches up with FBlueprintNativeCodeGenModule::FindReplacedNameAndOuter(), where we specifically handle CAC-owned template objects.
Change 3502741 by Phillip.Kavan
#jira UE-45782 - Fix undo for index pin type changes.
Change summary:
- Modified SGraphPinIndex::OnTypeChanged() to call Modify() on the pin that was changed.
Change 3502939 by Michael.Noland
Back out changelist 3499927
Change 3503087 by Marc.Audy
Re-fixed ocean content as editor had also changed so had to take theirs and redo
#rnx
Change 3503266 by Ben.Zeigler
#jira UE-46335 Fix regression added in 4.16 where AssetRegistry GetAncesorClassNames/GetDerivedClassNames were not working properly in cooked builds for classes not in memory
Change 3503325 by mason.seay
updated Anim BP to prep for pin testing
Change 3503445 by Marc.Audy
Fix crash caused by OldPins being destroyed before rewiring
#rnx
Change 3505024 by Marc.Audy
Fix NodeEffectsPanel blueprint as it was using pins that no longer existed
#rnx
Change 3505254 by Marc.Audy
Don't include orphan pins when gather source property names
If a property doesn't exist for a source property name just skip the property rather than crashing
#jira UE-46345
#rnx
Change 3506125 by Ben.Zeigler
#jira UE-46311 Fix issues when blueprints are reloaded in place, it needs to remove them from root properly and sanitize the old class. It's still not clear why they are being reloaded in place
Change 3506334 by Dan.Oconnor
Move UAnimGraphNode_Base::PreloadRequiredAssets up to K2Node, make sure nodes get a chance to preload data before compilation manager compiles newly loaded blueprints
#jira UE-46411
Change 3506439 by Dan.Oconnor
Return to pre 3488512 behavior for construct object nodes. This means that we can still get warnings on load when users compile after saving a blueprint, but the current behavior loses default values because it's lookng at the skeleton cdo
#jira UE-46308
Change 3506468 by Dan.Oconnor
Return to pre 3488512 behavior, as it causes bad default values
#jira UE-46414
#rnx
Change 3506733 by Marc.Audy
Use the most up to date class to determine whether a property still exists when adding pins during reconstruction
#jira UE-45965
#author Dan.OConnor
#rnx
Change 3507531 by Ben.Zeigler
#jira UE-46449 Better fix to flush the asset registry queue when the editor requests a synchronous scan at startup. Sometimes it can take a few frames because of file handle delays
Change 3507924 by mason.seay
Sanity save of TM-Gameplay and sublevels to maybe resolve level streaming issues
Change 3507962 by Marc.Audy
Remake changes from CL# 3150796 wiped out by WEX-Staging merge to Main in CL# 3479958
#rnx
Change 3509131 by Dan.Oconnor
Compilation manager compile on load flow never called FindExportsInMemoryFirst, which is critical to prevent reloading of UBlueprintGeneratedClasses when Rename clears the export table
#jira UE-46311
Change 3509345 by Marc.Audy
CVar to disable orphan pins if necessary
#rnx
Change 3509959 by Marc.Audy
Protect against crashing due to large values in Timespan From functions
#jira UE-43840
Change 3510040 by Marc.Audy
Remove all the old unneeded ShooterGame test maps
#rnx
[CL 3510073 by Marc Audy in Main branch]
#lockdown Nick.Penwarden
#rb none
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3433074 by Matt.Kuhlenschmidt
Fix crash when clicking on certian tutorial blueprints.
#jira UE-44593
Change 3433075 by Matt.Kuhlenschmidt
Remove hittest grid log spam. The underlying problem causing this has been fixed
Change 3433077 by Matt.Kuhlenschmidt
Fix lighting becoming unbuilt when mesh painting
#jira UE-44837
Change 3433081 by Matt.Kuhlenschmidt
PR #3553: Crashfix for static array properties (Contributed by Pierdek)
Change 3433104 by Alexis.Matte
Make sure re-import skeletal mesh follow the import morph option
#jira UE-42846
Change 3434825 by Matt.Kuhlenschmidt
Fix crash when GC happens while the vr editor radial menu is open.
Change 3434831 by Matt.Kuhlenschmidt
Added missing file
Change 3434868 by Shaun.Kime
If you have a reroute node between a Material Function texture input and its usage, the parent material will fail to resolve the reroute node.
#jira ue-44670
Change 3434998 by Alexis.Matte
Meshes editors material/section panel are now fully transactional
- Staticmesh editor: section material slot, section cast shadow, section collision, material slot instance, material slot name
- Skeletal mesh editor: material slot instance, material slot name
Also fix some transaction description
#jira UE-44462
Change 3435195 by Jamie.Dale
Fixed incorrect handling of some LTR scripts that require shaping
These scripts need to go through HarfBuzz, and this also fixes a case where HarfBuzz wasn't applying font scale correctly.
#jira UE-44767
Change 3435199 by Jamie.Dale
Fixed some crashes/artifacts with bidirectional text
It was possible for a line to compute an incorrect range, which could cause crashes or other highlighting issues. The highlighting logic has also been updated as the old code didn't handle all bidirectional cases correctly.
Change 3435200 by Jamie.Dale
Fixed a grapheme cluster metrics issue in the font editor viewport
The viewport also now respects the default shaping method CVar.
Change 3435771 by Alexis.Matte
Fix degenerated bounds calculation for skeletalmesh when the skeleton is remove from a re-import
(PhysicAsset API change, adding 1 function)
#jira UE-44609
Change 3436856 by Jamie.Dale
Added some missing Unicode block ranges
Change 3436914 by Jamie.Dale
Adding some missing combining character ranges to the text shaper
Change 3436923 by Alexis.Matte
PR #3463: Get bounds for all triangles, not just the first one. WedgeIndex was . (Contributed by DaveC79)
#jira UE-43764
Change 3436948 by Jamie.Dale
Updated the Portal to use the predefined Unicode block ranges
Change 3436961 by Max.Chen
Sequencer: Show camera shake/anim track menus even if there aren't any assets.
Change 3437244 by Max.Chen
Sequencer: Clear locked cameras when releasing Sequencer.
#jira UE-44967
Change 3437515 by Arciel.Rekman
UBT: improvements for LocalExecutor.
- Larger number of parallel jobs on 16GB+ machines.
- Use WaitForExit() instead of polling.
- Tested on Linux and Mac.
Change 3437629 by Matt.Kuhlenschmidt
Improve asset import data display in static and skeletal meshes
Change 3438047 by Arciel.Rekman
Fix overlapping ranges being passed to memcpy().
Change 3438822 by Yannick.Lange
ViewportInteraction: Move gizmo handle files to make them private.
Change 3438906 by Matt.Kuhlenschmidt
PR #3556: Git Plugin: fix new option "init Git LFS" that make assets read-only (master/UE4.17) (Contributed by SRombauts)
Change 3438907 by Matt.Kuhlenschmidt
PR #3565: add -quality option to buildlighing commandlet (Contributed by kayama-shift)
Change 3438908 by Matt.Kuhlenschmidt
PR #3558: UE-44862: Always update SColorPicker color on OK button (Contributed by projectgheist)
Change 3439393 by Matt.Kuhlenschmidt
Force highest LOD for highres screenshots
Change 3439819 by Matt.Kuhlenschmidt
Turned FAssetData into a struct for some upcoming script exposure of FAssetData
Change 3439949 by Arciel.Rekman
Fixed selection logic for the UE4_LINUX_USE_LIBCXX environment variable.
- Allows disabling libc++ by setting the variable to 0.
- Pull request #3576 contributed by jared-improbable.
Change 3441078 by Jamie.Dale
The culture/language/locale console commands are now available in all build configs
Change 3441109 by Jamie.Dale
Text containing surrogate pairs now runs through HarfBuzz when shaping in Auto mode
This is needed as the kerning-only shaping code assumes that everything is within the BMP
Change 3441275 by Matt.Kuhlenschmidt
Disable spinning on location and scale. These dont work because we have no notion of infinite spinning
Change 3442748 by Yannick.Lange
ViewportInteraction: Remove unused console variables.
Change 3442775 by James.Golding
Add support for editing MaterialFunctions to MaterialEditingLibrary
Pull Material recompile/update code into UMaterialEditingLibrary::RecompileMaterial
Pull MaterialFunction update code into UMaterialEditingLibrary::UpdateMaterialFunction util
Move RebuildMaterialInstanceEditors to UMaterialEditingLibrary
Added test content for Material/MaterialFunction editing
Add needed BlueprintReadWrite to expressions (constants, function input/output)
Expose UMaterialExpressionMaterialFunctionCall::SetMaterialFunction to BP, rename old func (which takes old function) to SetMaterialFunctionEx, also expose GetInputNameWithType
Change 3442779 by James.Golding
Fix header order
Change 3442817 by Yannick.Lange
ViewportInteraction: Add can execute checks for level editor commands.
Change 3443038 by Michael.Dupuis
#jira UE-43377: When you select a foliage actor we will move all instance contained in it to the new level as we can't move a foliage actor
Only permit moving foliage instance if there is some selected
Change 3443855 by Michael.Dupuis
#jira UE-44885: Unregister from PerModuleDataObjects when the object is destroyed
Change 3446096 by Max.Chen
Sequencer: Add OnFinished() event when a level sequence completes playback
#jira UE-45173
Change 3446097 by Max.Chen
Sequencer: Evaluate one last time before the sequence is torn down and reset
#jira UE-45174
Change 3446242 by Jamie.Dale
Fixed caret not appearing in empty text layouts
Caret selections have no range, and therefore have no width
Change 3446361 by Matt.Kuhlenschmidt
Fix WITH_EDITOR only functions causing generated code compile errors when the all functions on the class are WITH_EDITOR
Change 3446457 by Alexis.Matte
Polish the speed tree import dialog
#jira UE-44963
Change 3446946 by Michael.Trepka
Modified FWindowsWindow::GetRestoredDimensions to return correct window position for normal windows for which GetWindowPlacement returns position in workspace coordinates
#jira UE-37934
Change 3447543 by Arciel.Rekman
Reduce VMAs on Linux.
- Trades off increased address space (VIRT in terms of ps/htop) for smaller number of distinct mappings (VMAs, virtual memory areas).
This decreases possibility to run into vm.max_map_count limit on Linux.
- Tested on Linux and Mac.
Change 3448468 by Arciel.Rekman
Fix race condition during creation of GMalloc.
- On Mac GMalloc can be created on two different thread that are racing with each other - app's main thread and a system thread.
Change 3449012 by Max.Chen
Sequencer: Add time to transform, color and vector key structs so that key times are editable from the key editors.
#jira UE-45089
Change 3449018 by Max.Chen
Sequencer: Add OnCameraCut event that fires when there is a camera cut.
#jira UE-45137
Change 3449195 by Max.Chen
Sequencer: Add setting for limit scrubbing to playback range.
#jira UE-43502
Change 3449198 by Max.Chen
Sequencer: Reorder hierarchical bias so that group priority takes precedence.
Change 3449217 by Max.Chen
Sequencer: Add setting to activate realtime viewports when in sequencer.
Change 3449219 by Max.Chen
Sequencer: Focus on search boxes when opened.
Change 3449238 by Max.Chen
Sequencer: Assign actor should replace the actor itself after it has updated all the components. Also, replace components be fullname rather than by class.
Change 3449239 by Max.Chen
Sequencer: Fix offsets when moving multiple sections. Dragging should be clamped to the bounds that any of the selected sections hits against the unselected sections.
Change 3449241 by Max.Chen
Sequencer: Restore section selection after full tree rebuild.
Change 3449279 by Max.Chen
Sequencer: Set movie scene capture frames only when not using custom frames. This allows the user entered frame numbers to persist in config, rather than overwriting them when doing a "Render Shot"
Change 3449280 by Max.Chen
Sequencer: Spawn in the persistent level. Otherwise, they get spawned into whatever sublevel is current.
#jira UE-44552
Change 3449294 by Max.Chen
Sequencer: Null check for sequencer ed mode crash.
Change 3449297 by Max.Chen
Sequencer: Fix delay in sliding values. Mark changed when sliding values. Mark refresh immediately when committing values since OnValueChanged will be called and needs to have the correct value that was refreshed immediately.
#jira UE-42866
Change 3449542 by Max.Chen
Sequencer: Fix scrubber hit testing so that the time scrubber is really favored over the playback ranges.
#jira UE-44569
Change 3451507 by Matt.Kuhlenschmidt
Fix extra slate uv coords not functioning on ES2
Change 3451510 by Matt.Kuhlenschmidt
PR #3595: Fixed wrong colour for level status (Contributed by ronve)
Change 3451529 by Alexis.Matte
fbx scene importer: Make sure we set INVALID_UNIQUE_ID to node that has no attribute.
#jira UE-34410
Change 3451611 by Yannick.Lange
ViewportInteraction: Dragging gizmo without second pass for snapped calculations.
Change 3452134 by Jamie.Dale
Fixed constant font cache flushing if a widget had no font set
Change 3452239 by Jamie.Dale
Fixed constant font measure flushing if a widget had no font set
Change 3452243 by Jamie.Dale
Removed deprecated code for creating fonts from bulk data
Change 3452277 by Jamie.Dale
The concept of "stale" composite fonts is now editor-only
Change 3452358 by Alexis.Matte
Fbx scene importer: Do not remove existing attribute reference from the blueprint if the reimport of the associate mesh attribute is not tick.
#jira UE-45232
Change 3452678 by Max.Chen
Sequencer: Fix crash on export if there's no shot data.
Change 3453057 by Matt.Kuhlenschmidt
Exposed asset exporting to script
Change 3453782 by Andrew.Rodham
Sequencer: Fixed deterministic cooking issues with movie scene data
- Movie scene signatures are now initialized in PostInitProperties
- A warning is now presented when attempting to cook old data that was never serialized with a signature.
- Removed redundant legacy data upgrade logic that could dirty level sequences on load.
#jira UE-44912
Change 3453788 by Yannick.Lange
ViewportInteraction: Custom scene proxy for gizmo handles.
Change 3453938 by Max.Chen
Sequencer: Hotkeys (shift , and shift .) to step to next/previous shot
#jira UE-45119
Change 3454058 by Michael.Dupuis
Fixed StaticAnalysis
Change 3454077 by Max.Chen
Sequencer: Fix not saving the pre-animated track value when creating a track/key.
On pre object change, broadcast property change so that a track or key can be created. That track/key needs to be evaluated immediately so that the pre-animated state can be saved properly. This is done now with RefreshAllImmediately and is only called when a track has been created. Also, added a return value for OnKeyProperty, so that it's known what changed in particular (ie. track created, track modified, etc)
Also, fixed transform keying so that if a transform track already exists for the object or the scene component, the existing track is used.
#jira UE-45130
Change 3454108 by Nick.Darnell
UMG - Fixing the WIC to properly record cursor delta so that scrollbars work.
Change 3454109 by Jamie.Dale
Cache the text layout source info in non-shipping builds so you can inspect it in the debugger
Change 3454202 by Matt.Kuhlenschmidt
Fix bogus error message about the number of usable texture coordinates on ES2 when compiling a UI domain material
Change 3454390 by Yannick.Lange
Fix creating a plugin in a C++ project opens a second instance of Visual Studio. Use SourceCodeAccessor to open solution when necessary.
#jira UE-45035
Change 3454564 by Matt.Kuhlenschmidt
#rnx Fix deprecation warnings
Change 3455471 by Yannick.Lange
ViewportInteraction: Fix entering and exiting VR Mode disables gizmo in desktop editor viewport.
#jira UE-44965
Change 3456183 by Max.Chen
Sequencer: Auto key, auto track refactor.
Auto key - create a key when the property changes and there's an existing track.
Auto track - create a track when the property changes. This is only exposed in the level sequence editor.
All - create a key and a track when the property changes. This is only exposed in VR Editor.
None - do nothing.
#jira UE-43469
Change 3456349 by Andrew.Rodham
Sequencer: Only perform legacy signature checks on instances, and only where signatures match the CDO
Change 3456678 by Alexis.Matte
Allow to add null level instance override material via the advance material array. But still limit the override material number to the mesh material number.
#jira UE-45306
Change 3456945 by Max.Chen
UMG: Add restore state to 2d transform section.
#jira UE-45372
Change 3457196 by Arciel.Rekman
Linux: serialize allocations from the memory pool.
Change 3458434 by Max.Chen
Sequencer: Remove obsolete set tick prerequites functions.
Change 3458671 by James.Golding
Added MIC editing support to MaterialEditingLibrary
Fix static analysis warning
Change 3458888 by Matt.Kuhlenschmidt
PR #3615: More detailed log messages for debugging warnings/errors (Contributed by projectgheist)
Change 3458893 by Matt.Kuhlenschmidt
PR #3583: UE-44960: Delta value wasn't being used (Contributed by projectgheist)
Change 3458895 by Matt.Kuhlenschmidt
Fix typo
Change 3458902 by Matt.Kuhlenschmidt
PR #3607: Improved InputKeySelector functionality (Contributed by projectgheist)
Change 3458917 by Matt.Kuhlenschmidt
Fix crash with invalid object properties in the class picker
#jira UE-39000
Change 3458939 by Matt.Kuhlenschmidt
Fix compile error
Change 3458984 by andrew.porter
QAGame: Initial check in of sequencer smoke test map
Change 3459510 by Matt.Kuhlenschmidt
Fixed ensure when deleting a map that contains build data which also happens to be the currently loaded map.
#jira UE-45052
Change 3460985 by Max.Chen
Sequencer: Snap play time to keys now allows scrubbing between keys and snaps to key times within a certain screenspace tolerance.
#jira UE-45090
Change 3461698 by Arciel.Rekman
Avoid using ARRAY_COUNT in Vulkan.
- Sometimes those arrays can have no extensions whatsoever, and it is illegal to declare a 0 element C array.
Change 3462053 by Max.Chen
Sequencer: Show sequencer spawnables in the world outliner and add the icon overlay for spawnables.
#jira UE-43470
Change 3462139 by Max.Chen
Property Editor: Add objects to FPropertyAndParent
Change 3462202 by Arciel.Rekman
Fix FSocket::Recv() blocking with Peek when there's no data.
Change 3462253 by Nick.Darnell
Slate - New Clipping System
Clipping is now a stateful choice made during composition of the slate hierarchy. Previously every widget got to respect or modify the clipping rect on an as needed basis. The problem was that clipping was only allowed in the layout space of the widget, and it wasn't possible to properly clip elements with render transforms. The new system permits all kinds of transforms on any widget, and they will all be clipped correctly. It tries to use Scissor Rects as they are much cheaper, but will switch over to stenciling if need be to represent a complicated masking structure with several rotated clipping rects all needed to be combined together.
Here are the new clipping states a widget can have, almost all widgets are set to No. Only change it from No if your widget actually needs to clip, generally speaking most widgets don't need to clip.
/**
* This widget does not clip children, it and all children inherit the clipping area of the last widget that clipped.
*/
Inherit,
/**
* This widget clips content the bounds of this widget. It intersects those bounds with any previous clipping area.
*/
ClipToBounds,
/**
* This widget clips to its bounds. It does NOT intersect with any existing clipping geometry, it pushes a new clipping
* state. Effectively allowing it to render outside the bounds of hierarchy that does clip.
*
* NOTE: This will NOT allow you ignore the clipping zone that is set to [Yes - Always].
*/
ClipToBoundsWithoutIntersecting UMETA(DisplayName = "Yes - Without Intersecting (Advanced)"),
/**
* This widget clips to its bounds. It intersects those bounds with any previous clipping area.
*
* NOTE: This clipping area can NOT be ignored, it will always clip children. Useful for hard barriers
* in the UI where you never want animations or other effects to break this region.
*/
ClipToBoundsAlways UMETA(DisplayName = "Yes - Always (Advanced)"),
/**
* This widget clips to its bounds when it's Desired Size is larger than the allocated geometry
* the widget is given. If that occurs, it behaves like [Yes].
*
* NOTE: This mode was primarily added for Text, which is often placed into containers that eventually
* are resized to not be able to support the length of the text. So rather than needing to tag every
* container that could contain text with [Yes], which would result in almost no batching, this mode
* was added to dynamically adjust the clipping if needed. The reason not every panel is set to OnDemand,
* is because not every panel returns a Desired Size that matches what it plans to render at.
*/
OnDemand UMETA(DisplayName = "On Demand (Advanced)")
- Large API Change -
All FSlateDrawElement::Make_____ calls have been deprecated that involved passing in a clipping rect. You no longer should are passed a Clipping rect via OnPaint. You are still passed a rect, but this rect represents a Culling Rect, which is valuable if you need to just out right not paint things the user can't possibly see.
If you were previously trying to determine if you should cull widgets, by doing something like this,
if ( FSlateRect::DoRectanglesIntersect(MyClippingRect, CurWidget.Geometry.GetRenderBoundingRect()) )
That's no longer a good option since there are ways for widgets to ignore the culling bounds. You should convert anything like above to the one below,
if (!SWidget::IsWidgetCulled(MyCullingRect, CurWidget))
To assist in debugging efforts, there are several new debugging console flags in Slate,
Slate.ShowClipping 1 - Controls whether we should render a clipping zone outline. Yellow = Axis Scissor Rect Clipping (cheap). Red = Stencil Clipping (expensive).
Slate.DebugCulling 1 - Disables pushing clipping or stencil rects to the GPU, but continues to intersect culling rects, so that you can tell if a widget is properly culling children it can't possibly draw.
Slate.ShowTextDebugging 1 - Show debugging painting for text rendering.
I've added a new Experimental Feathering Option, it adds AA geometry around the outside of Box and Image brushes.
Slate.Feathering 1
If you're using RenderDoc or something similar, you can now enable render events for slate, so that you can better grok how we're batching and changing states for each UI render pass.
Slate.EnableDrawEvents 1
#jira UE-4659
#rn
Change 3462714 by Nick.Darnell
Fixing a few more compiler issues with the clipping changes.
Change 3462726 by Max.Chen
Switch OnEditStructChildContentsChanged to use FObjectWriter instead of FMemoryWriter which supports serializeing UObjects. This fixes a crash when adding actor array elements to a user defined event struct.
#jira UE-45431
Change 3462801 by Nick.Darnell
Adding a UMG dependency to EngineTestBuild.
Change 3462914 by Max.Chen
Sequencer: Fix regression where spawnables aren't getting saved. Caused by 3407138
#jira UE-30007
#jira UE-39003
Change 3462946 by Nick.Darnell
Automation - Tweaking the UI automation tests converting them over to use the new UI Screenshot automation test.
Automation - Adding a blur widget test.
Change 3462987 by Matt.Kuhlenschmidt
Back out changelist 3458893
Change 3464774 by Matt.Kuhlenschmidt
PR #3629: Bugfix: Missing small icon in Project Launcher profile editor (Contributed by aarmbruster)
Change 3464785 by Nick.Darnell
Fixing some clipping stuff in the editor.
Change 3464830 by andrew.porter
QAGame: Second pass on sequencer smoke test map
Change 3464902 by Nick.Darnell
Loading - Adding some additional checks to the the loading code to ensure we're on the main thread. Additionally adding a fix from UDN that prevents deadlocks in the rare case a user hits Alt+Tab in a fullscreen game while in a hard loading screen.
Change 3464988 by Max.Chen
Sequencer: Add attenuation settings for attached audio components.
#jira UE-33080
Change 3465024 by Nick.Darnell
MoviePlayer - Impoving the playback mode displaynames.
Change 3465074 by Arciel.Rekman
Fix shadowing issues of GraphicsPSOInit.
Change 3465097 by Matt.Kuhlenschmidt
Some refactoring of the details panel
Exposed new methods of adding a struct on scope to a details panel and have it work properly with customizations. The scruct on scope has a "fake" ustructproperty that allows the details panel to show the whole struct not just an individual property.
Refactored the API for adding rows to details panels to make it more consistent\
AddChildCustomBuilder->AddCustomBuilder
AddChildGroup->AddGroup
AddChildContent->AddCustomRow
AddChildPropert->AddProperty
AddChildStructure->AddExternalStructureProperty
AddStructure->AddAllExternalStructureProperties
AddExternalProperty->AddExternalObjectProperty or AddExternalStructureProperty
Change 3465186 by Max.Chen
Sequencer: Save the BindingID in the pre animated token producer so that it can be destroyed properly. This fixes a bug where the default state of a spawnable isn't saved.
#jira UE-43780
Change 3465315 by Matt.Kuhlenschmidt
Fix Fortnite and Orion details panel customization warnings
Change 3465424 by Nick.Darnell
Automation - Moving the step for setting the link to the automation reports to be set before we start the engine.
Change 3465488 by Nick.Darnell
Automation - Forcing textures to load before taking screenshot, so that the scene gets another opportunity to render before we render with Slate. This should fix the Blur UI Test.
Change 3466277 by Arciel.Rekman
Linux: fix window drift when dragging (UE-40380).
- Change by Cengiz Terzibas.
Change 3466370 by Nick.Darnell
UMG - Fixing the colors for the resize handle in the designer.
Change 3466372 by Nick.Darnell
UMG - Fixing the ruler ticks sometimes not being drawn.
Change 3466374 by Nick.Darnell
UMG - Fixing the designer showing multiple options for sequencer.
Change 3466377 by Nick.Darnell
UMG - Cleaning up some clipping bits.
Change 3467025 by Andrew.Rodham
Re-saving assets that contain legacy (<4.15) movie scene data to remove deterministic cook warning.
If conflicts arise during merging of these assets, please ignore the changes made in dev-editor, and accept game-side changes.
(CIS step 62283298, jobId 7773146)
(CIS step 62283297, jobId 7773146)
Change 3467099 by Max.Chen
Fix GetObjectPropertyClass ensure logic. This was returning UObject::StaticClass when valid.
Change 3467172 by Max.Chen
Sequencer: Evaluation optimizations. Also, fixes subsequences not getting expired, leaving dangling spawnables.
#jira UE-43690
Change 3467192 by Matt.Kuhlenschmidt
Fix transactions getting stuck in the color grading controls. This prevents PIE from working properly and causes shutdown crashes
#jira UE-45527
Change 3467251 by Yannick.Lange
ViewportInteraction: Fix scale and rotation snap while dragging with two lasers.
#jira UE-43489
Change 3467331 by Matt.Kuhlenschmidt
Fix D3D shader compiler hard coding shader path and not giving proper warnings when it cannot find the shaders
Change 3467335 by Matt.Kuhlenschmidt
Remove DarkStyle attribute from SNumericEntryBox and allow a spin box style to be passed to it.
Change 3467558 by Max.Chen
Scene Outliner: Generic support to add default columns to a scene outliner.
Change 3467565 by Jamie.Dale
Removing old screenshot data for test
Change 3467589 by Nick.Darnell
Editor - Random cleanup.
Change 3467596 by Nick.Darnell
Progress Bar - Exposing Border Padding to UMG.
Change 3467600 by Nick.Darnell
Slate - Adjusting the rendering of the splitter, previously it could be off by a pixel or two, which becomes more apparent now with the clipping changes.
Change 3467601 by Max.Chen
Property Editor: Fix static analysis warning
Change 3467662 by Nick.Darnell
Automation - Fixing a bug with the screenshot comparison tool not replacing (removing) the old screenshot data.
Change 3467674 by Max.Chen
Property Editor: Fix static analysis warning
Change 3467737 by Max.Chen
Sequencer: Added OnMovieSceneBindingsChanged delegate
Change 3468053 by tim.gautier
QAGame: Updating Editor Smoke Map
- Updated landscapes into Stations for testing
- Added Foliage Sublevel
Change 3468194 by Arciel.Rekman
Linux: fix problems communicating with various STL-using libs.
- Stop hiding global new/delete signatures.
- Disable CEF3 since this change uncovers the problem with libcef.so not built to use bundled libpng.
Change 3468678 by Max.Chen
Sequencer: Set "Sequencer Actor" tag before setting the actor label so that the outliner refreshes after the actor has the tag.
Change 3469314 by tim.gautier
QAGame: Added Painted Foliage / Spline section to EditorSmoke map
Change 3469377 by Nick.Darnell
Slate - Fixing some warnings in a couple of sample games due to the clipping changes.
#rnx
Change 3469767 by Max.Chen
Sequencer: Outliner column and sequencer binding data
#jira UE-43470
Change 3469974 by Arciel.Rekman
Fix code projects not working in Linux installed build.
Change 3470082 by Nick.Darnell
Slate - The GetRenderer() call on SlateApplication no longer returns a SharedPtr, rather than convert it to a thread safe ptr, going to just make accessing it a raw ptr return, so it can be safely referenced on the game thread while being used on the slate loading thread.
Change 3470174 by Nick.Darnell
Slate - Get the last widget in a widget path utility.
Change 3470176 by Nick.Darnell
UMG - User Widgets now have an easy way to know if they're part of or have been removed from the focused widget path, which is handy for doing effects.
Change 3470261 by Nick.Darnell
Slate - The GetRenderer() call on SlateApplication no longer returns a SharedPtr, rather than convert it to a thread safe ptr, going to just make accessing it a raw ptr return, so it can be safely referenced on the game thread while being used on the slate loading thread.
Change 3470286 by Max.Chen
Sequencer: Scene Component's HiddenInGame now goes through the VisibilityTrack and the visibility template.
Change 3470366 by Nick.Darnell
Slate - We now version focus per user, that way during focus events, we can safely abort focus events and state transitions if someone interrrupts the active focus event with something new.
Change 3470649 by Matt.Kuhlenschmidt
Fix deprecation warnings
Change 3470695 by Matt.Kuhlenschmidt
Fixed typo
#jira UE-45580
Change 3470721 by Matt.Kuhlenschmidt
Fix static analysis
Change 3471254 by Michael.Dupuis
#jira UE-42952: Keep occlusion result per view
Change 3471287 by Nick.Darnell
UMG - Render Focus Rule now defaults to never.
Change 3471291 by Nick.Darnell
Slate - Fixing FSlateRenderer* change fallout.
Change 3471299 by Nick.Darnell
Slate - Fixing FSlateRenderer* change.
Change 3471323 by Nick.Darnell
Automation - Fixing automation and Static Analysis warning.
Change 3471413 by andrew.porter
QAGame: Added test content for anim blending and material parameteres to sequencer smoke level
Change 3471649 by Max.Chen
Sequencer: Modify the track when adding animation
#jira UE-45618
Change 3471659 by Matt.Kuhlenschmidt
Added a way to check if a movie is playing from the engine.
Prevented viewport redraws for canvas loading screens if a slate based loading movie is playing
Change 3471734 by Matt.Kuhlenschmidt
Added basic material hookup to USD. Similar to FBX it will find materials based on rules specified by the user in the import settings
Change 3472176 by Nick.Darnell
UMG - Improving the display of the +Track menu in sequencer for UMG. Renamed it from +Add, which is repetitve to +Track. Additionally, the dropdown now shows the currently selected widgets, as well as a submenu containing all the 'important' widgets, so we no longer populate that list with a ton of irrelevant widgets that are just Buton_1 - N, which is pointless in showing people, they'll never guess which is the right button.
Change 3472740 by Max.Chen
Sequencer: Add GetThisFrameMetaData accessor
Change 3472748 by Max.Chen
Sequencer: Added OnBeginScrubbing and OnEndScrubbing event delegates
Change 3472753 by Max.Chen
Sequencer: Add EMovieSceneDataChangeType parameter to OnMovieSceneDataChanged delegate
Change 3472870 by Nick.Darnell
Clipping - Fixing the deprecated tip for scissor rect boxes to be correct. Removing it's usage from UT.
Change 3473340 by Max.Chen
Scene Outliner: Add ability to register additional filters
Change 3473348 by Max.Chen
Details View: Make ForceRefresh virtual. Added accessors to delegates (ie. GetIsPropertyReadOnlyDelegate)
Change 3473441 by Max.Chen
Sequencer: Autokey Refactor Part 2.
Autokey is now a single toggleable state.
Allow Edits Mode has 3 states:
Allow All Edits - Allow any edits to occur, some of which may produce tracks/keys or modify default properties.
Allow Sequencer Edits Only - All edits will produce either a track or a key.
Allow Level Edits Only - Properties in the details panel will be disabled if they have a track.
#jira UE-45229
Change 3473670 by Nick.Darnell
Modules - The module manager no longer returns sharedptrs to IModuleInterfaces, this was the source of rare hard to track down crashes due to a shared ptr reference leak when GetModule was called on non-main threads. We now store a TUniquePtr internally, and only lease out raw pointers.
#rn
Change 3473711 by Nick.Darnell
Disabling the ensure in the module manager.
Change 3473747 by Max.Chen
Sequencer: Fix tooltip
Change 3474091 by Jamie.Dale
Added a warning when cooking a UFontFace that is outered to a UFont asset
These cause issues with iterative COTF, and should be split off into their own assets (as the UI has been asking people to do for several versions)
Change 3475052 by Yannick.Lange
VR Editor: Fix Crash when quitting the editor with VR Mode enabled. VR Editor was being enabled when saving the map on closing the editor.
#jira UE-45415
Change 3475054 by Yannick.Lange
Fix crash when adding a camera to the world in VR Mode the second time. The slate application did not reset when stop dragging in VR Mode, so the second time when starting to drag a camera out of the UI it would already by in a dragging state.
#jira UE-45574
Change 3475263 by Nick.Darnell
Fixing some additional cases of IModuleInteface SharedPtr usage.
Change 3475268 by Max.Chen
Sequencer: Set jumped state when looping playback. This fixes an issue where audio doesn't stop and restart when looped.
#jira UE-45654
Change 3475269 by Max.Chen
Scene Outliner: Additional filters should only apply to actor browsing mode
Change 3475407 by Nick.Darnell
Fixing some clipping / module shared ptr changes in the launcher code.
Change 3475542 by Max.Chen
Sequencer: Update thumbnail and section highlighting to use new clipping behavior.
#jira UE-45692
#jira UE-45689
Change 3475743 by Michael.Dupuis
#jira UE-45183: When updating phyx region take into account simple collision mip
Change 3475949 by Arciel.Rekman
Remove PhysX deoptimization (no longer needed).
- OR-24947 has been closed three months ago.
Change 3476022 by Michael.Dupuis
#jira UE-45560: Make sure we're not going out of range
Change 3476063 by Michael.Dupuis
#jira UE-45562: Do not try to unregister from static mesh if no static mesh is specified for the component
Change 3476168 by Michael.Trepka
Added handling of directory symlinks to FApplePlatformFile::IterateDirectory
#jira UE-43704
Change 3476172 by Nick.Darnell
Fixing a Imoduleinterface change.
Change 3476183 by Jamie.Dale
Exposing GoTo/ScrollTo to single-line editable text for API parity with multi-line editable text
Change 3476385 by Arciel.Rekman
Linux: handle symlinks when iterating directories.
Change 3476522 by Michael.Trepka
Solved a problem with Mac FMallocTBB::Malloc() returning nullptr for 0 bytes allocations, which is inconsistent with other platforms. On Mac we always scalable_aligned_malloc, which behaves differently than scalable_malloc, so for 0 bytes requests we allocate sizeof(size_t), which is exactly what scalable_malloc does internally in such case.
Change 3476806 by Nick.Darnell
UMG - Focus the designer after dropping a widget onto the surface.
Change 3476809 by Nick.Darnell
Curve Editor - Enable Clipping on the curve editor.
Change 3477475 by Nick.Darnell
Fixing a module interface shared ptr usage in UT.
Change 3477553 by Yannick.Lange
VR Editor: Removed AssetEditorPanelID and replaced it with TabManagerPanelID. A panel for AssetEditorPanelID was never created making it impossible to open an asset editor.
Change 3477734 by Yannick.Lange
VR Editor: Fix Warning: SetRelativeScale3D : Invalid Scale entered (X=inf Y=inf Z=inf). Resetting to 1.f. warning when adding CineCameraActor to World from Modes Panel. Make sure to not divide by zero when there is no boundary scale.
#jira UE-44933
Change 3477761 by Jamie.Dale
Some improvements to avoid loading the native .locres files twice when we don't need to
Change 3477780 by Nick.Darnell
PR #3250: Return correct VirtualUserIndex (Contributed by projectgheist)
Change 3477786 by Nick.Darnell
PR #3650: Changed TestNull to accept const pointers. (Contributed by e-agaubatz)
Change 3477795 by Nick.Darnell
PR #2844: UE-36936: Don't stretch container for Plugin Image (Contributed by projectgheist)
Change 3478092 by Nick.Darnell
PR #2341: Optional Middle Mouse Button panning in Graph Editor (Contributed by flipswitchingmonkey)
Engine Edit - Made some small changes to the enum type, and some naming.
Change 3478450 by Nick.Darnell
Fixing some uninitialized variable errors.
Change 3479827 by Andrew.Rodham
Sequencer: Addressed serialization issues with some struct types
Change 3479874 by Jamie.Dale
Fixed "NativeGameLanguage" not being used correctly during localization initialization
Change 3480012 by Andrew.Rodham
Sequencer: Fixed loading tagged properties as native for track identifiers
#jira UE-45823
Change 3480337 by Alexis.Matte
Fix morph target crash missing some valid index check
Change 3480804 by Alexis.Matte
Fix crash with ColorGradingMode custom detail
#jira UE-45638
Change 3480892 by Andrew.Rodham
Sequencer: Ensure that movie scene sequences know about the editor object version
#jira UE-45842
Change 3481073 by Nick.Darnell
Fix the shader compiler error from main in Slate.
Change 3481303 by Nick.Darnell
UMG - Fixing a bug with the drag handle not working correctly in HDPI mode.
Change 3481308 by Nick.Darnell
Slate - Tweaking the IsWidgetCulled logic to consider both the layout and rendering bounds. If we do this, we get a much more desireable outcome for people that want to animate widgets and such and plan to have temporary animations to move the widget offscreen, but want the layout bounds to anchor that widget in the visible frame so that it animates even when normally it would be culled b/c the render transform and therefore the renderbounds moved it completely outside the culling rect.
Change 3481629 by Max.Chen
Sequencer: Add Level Sequence Actor as an output for CreateLevelSequencePlayer()
#jira UE-45785
Change 3481899 by Yannick.Lange
VR Editor: Added debug modetoggle command with an event that is broadcasted whenever this happens. Currently this is used to show all the floating UIs of the UI system to debug without HMD using VREd.ForceVRMode.
Change 3481984 by Michael.Dupuis
#jira UE-45845: always validate if we have a static mesh before trying to access it as user can decide to not assign one and use the tools
Change 3482047 by Nick.Darnell
Slate - Adding some comments to IsWidgetCulled.
Change 3482110 by Nick.Darnell
Slate - IsWidgetCulled is no longer static and is now called IsChildWidgetCulled.
Change 3482136 by Jamie.Dale
The CamelCase break iterator now treats digits around character tokens as part of the identifier
Change 3482138 by Michael.Dupuis
#jira UE-45854: Properly unregister during undo operation
Change 3482150 by Michael.Dupuis
#jira UE-45845 : Add missing nullcheck for GetStaticMesh
Change 3482153 by Nick.Darnell
Slate - IsWidgetCulled is no longer static and is now called IsChildWidgetCulled.
Change 3482180 by Nick.Darnell
UMG - Widget Components do not need to define a widget class to be rendererd, they can have native slate widgets only. This was a regression from main.
Change 3482273 by Nick.Darnell
UMG - Tweaking some more things about the widget component box outline.
Change 3482308 by Alexis.Matte
Fixing morph target smooth group support. Do not call FillSkeletalMeshImportData more then once on FbxNode since this fonction is doing some conversion and change the FbxNode, applying those conversion twice do not return the same faces smooth group.
#jira UE-45696
Change 3482327 by Nick.Darnell
UMG - More tweaks to the WidgetComponent so both shows the box outline, but works in game and VR editor.
Change 3482705 by Andrew.Rodham
Resaving assets that contain legacy data to suppress CIS warnings.
- If conflicts arise in these assets, please take game-side changes and ignore these.
Change 3484245 by Max.Chen
Sequencer: Evaluate on end scrub. This fixes a bug where audio doesn't evaluate in a stopped position at the end of scrubbing, causing it to not stop all sounds. This fixes a bug introduced from 3365018 where evaluate on end scrub was removed.
#jira UE-45905
Change 3484263 by Max.Chen
Sequencer: Fix crash on forcing refresh of details panel on release.
#jira UE-45911
Change 3484431 by Andrew.Rodham
Resaving assets that contain legacy data to suppress CIS warnings.
- If conflicts arise in these assets, please take game-side changes and ignore these.
Change 3484474 by Alexis.Matte
Fix the morph target animation curve name matching.
#jira UE-20294
Change 3484475 by Alexis.Matte
When removing a LOD, make sure we remove all morph target data associate to the LOD.
Change 3484489 by Nick.Darnell
PR #3668: UE-45908: Cache debug line locations when performing a LineTraceMulti (Contributed by projectgheist)
#jira UE-45908
Change 3484692 by Nick.Darnell
Slate - Reverting a change from a game stream. All Arranged Children don't need to allocated 42 to begin with. Do need to initialize WidgetPaths better.
Change 3484703 by Nick.Darnell
Player Input - Making the input event loop for players obey EKeys::NUM_TOUCH_KEYS, rather than being set to Touch10, as the maximum touch input amount, to make supporting greater than 10 touches easier. Also making the seeding of keys use EKeys::NUM_TOUCH_KEYS.
#jira UE-43213
Change 3484918 by Jamie.Dale
Fixed font measuring regression with RTL text
RTL applies the character count to the next glyph, so it shouldn't process the end of the loop (this was how the older code used to work).
Change 3485718 by Nick.Darnell
Editor - Removing Super Search & User Feedback button.
Change 3485719 by Nick.Darnell
Portal - Removing SuperSearch.
Change 3485751 by Matt.Kuhlenschmidt
Fix crash accessing platformer game menu if the menu is open during a console based load
#jira UE-45950
Change 3486047 by Arciel.Rekman
Linux: add OpenEXR implementation (UE-40270).
#jira UE-40270
Change 3486467 by Max.Chen
Sequencer: Reset max tick rate when destroyed.
#jira UE-45956
Change 3486477 by Max.Chen
Sequencer: Refresh outliner when column is removed.
#jira UE-45891
Change 3486667 by Andrew.Rodham
Added missing include
Change 3486724 by Andrew.Rodham
Sequencer: Fixed curves with no default value, and no keys being evaluated and applied to properties
- Also fixed an edge case where a zero (but non-animated) channel could be applied to a final transform
Change 3486730 by Alexis.Matte
In the Auto-Reimport options, hide the mout point only for the default /Game/ folder
#UE-45684
Change 3486749 by Alexis.Matte
Make sure the parent window of the monitor directory browse folder is set properly
#jira UE-45682
Change 3486805 by Matt.Kuhlenschmidt
Additional safety against invalid objects being accessed by slate
Change 3486848 by Alexis.Matte
Make sure Monitor folder feature support root mount point map folder
During auto import, give priority to asset import factory over the scene import factory
#jira UE-45691
Change 3486879 by Andrew.Rodham
Removing obsolete QA assets
Change 3486950 by Nick.Darnell
PR #2281: Scrollbar missing features and SScrollbar fixes (Contributed by SNikon)
Review - made some adjustments from the original.
Change 3486954 by Nick.Darnell
Slate - Moving the STableViewBase over to the FOverscroll class, rather than it's own clone.
Change 3486967 by Nick.Darnell
Slate - Fixing some HDPI calculations for fitting new windows on screen, it was using the unscaled size of the widgets for fitting, when it needed to scale them up.
Change 3486970 by Andrew.Rodham
Sequencer: Delay mouse capture until drag for sequencer time slider
- Fixes context menus not opening as a result of mouse capture being taken on mouse down
#jira UE-45937
Change 3486984 by Andrew.Rodham
Sequencer: Improved blending type iconography
Change 3486996 by Nick.Darnell
UMG - Adding a way for games to opt-out of the slow widget path, to completely prevent them from being cooked.
UMG - The movie data is no longer cloned for each new instance that inhabits. It now keeps a reference to the now publically accessible movie scene data on the class instead.
Change 3487070 by Andrew.Rodham
Sequencer: Added graphics for key areas that represent empty space
Change 3487195 by Andrew.Rodham
Sequencer: Changed evaluation groups to always flush implicitly
- Due to the latent nature of blended token types, it's no longer safe to rely solely on execution token order between tracks
- This fixes an issue where events set in the PostEvaluation stage were executed before blended token actuation
Change 3487322 by Nick.Darnell
PR #2457: Add .gitdeps.xml-files for plugins support (Contributed by bozaro)
Change 3487363 by Nick.Darnell
PR #2481: Fix for packing of a project with users plugins (Contributed by yatagarasu25)
Change 3487439 by Nick.Darnell
PR #2642: Changed private to protected in SVirtualJoystick.h (Contributed by Skylonxe)
Change 3487500 by Arciel.Rekman
Removed LinuxNativeDialogs.
- No longer used; has been superceded by SlateDialogs since UE 4.8 (2 years ago).
Change 3487630 by Lauren.Ridge
Don't create Landscape Info Maps for Editor Preview Worlds or thumbnail worlds
#jira UE-44885
Change 3487864 by Matt.Kuhlenschmidt
Exposed the asset registry to blueprints and script. Works in editor scripts and runtime scripts
AssetRegistry is now a UInterface object.
Blueprint users can access various asset registry methods using the asset registry interface (via GetAssetRegistry) and various static helpers in the AssetRegistryHelpers object
C++ users should still continue to use IAssetRegistry.
Change 3487879 by Matt.Kuhlenschmidt
Renamed asset tools uobject helper to UAssetToolsHelpers
Change 3487926 by Lauren.Ridge
Fixing reset to default not showing up for custom widgets
#jira UE-44164
Change 3488184 by Matt.Kuhlenschmidt
PR #3656: Make References/Referencers List copyable (Contributed by user37337)
#jira UE-45763
Change 3488240 by Matt.Kuhlenschmidt
Fix compiler issue
Change 3488350 by Lauren.Ridge
Landscape info map transactional state is based on its world's transactional state
#jira UE-44885
#jira UE-46019
Change 3488412 by Matt.Kuhlenschmidt
Fix reset to default showing up in two different places for some customizations
Change 3488413 by Matt.Kuhlenschmidt
Fix slate font customization
Change 3488414 by Matt.Kuhlenschmidt
Fix slate font customization
Change 3488415 by Matt.Kuhlenschmidt
Missed file
Change 3488565 by Arciel.Rekman
Add pretty printers for gdb (UETOOL-1171).
- Committing shelf by Cengiz.Terzibas, with some modifications.
#jira UETOOL-1171
Change 3489094 by Nick.Darnell
Slate - The Slate RHI Renderer now caches the TextureLODGroups so that it can properly lookup the filtering of different texture groups that are set to Default, instead of a particular filter override on a texture.
Engine/Rendering - Simplifying some of the setup logic in TextureLODSettings so that code is shared for setting them up properly after loading from a config file.
Change 3489095 by Nick.Darnell
PR #2699: GameViewportClient - Added a method to allow setting the viewport cur. (Contributed by rfenner)
Review - Fixed spacing.
Change 3489108 by Matt.Kuhlenschmidt
Fix deprecation warning
Change 3489120 by Nick.Darnell
PR #3478: Fix possible UComboBoxString crash (Contributed by nakosung)
Change 3489147 by Andrew.Rodham
Sequencer: Adding return value to function to appease static analysis
- This function is never compiled, and if it is, it won't compile, but static analysis doesn't know that
Change 3489264 by Nick.Darnell
Testing - Finishing the thought behind an enum comment.
Change 3489265 by Nick.Darnell
PR #2750: UE-35164: Button padding (Contributed by projectgheist)
Change 3489267 by Nick.Darnell
PR #3645: UE-45464: Handle SSlider mouse interaction more accurately (Contributed by projectgheist)
Change 3489632 by Arciel.Rekman
Correctness changes to MallocPoisonProxy.
- Missing forwarding functions added. Incorrect comment removed.
- Change by Steve.Robb, doing here so it is in 4.17.
Change 3489689 by Arciel.Rekman
More MallocPoisonProxy changes I missed in previous CL.
Change 3489751 by Matt.Kuhlenschmidt
Moved editor performance settings out of per-project settings so they can be shared across projects
Change 3489837 by Lauren.Ridge
Keyboard shortcut for entering/leaving VR Mode is now Alt+V
Change 3491082 by Arciel.Rekman
Linux: better fix for the crash due to name collision (UE-46040).
- Put classes in Sequencer module into Sequencer namespace instead of SceneOutliner namespace.
- Undid change in the SceneOutliner module.
#jira UE-46040
Change 3491096 by Arciel.Rekman
Fix UAT compilation on the newest mono.
Change 3491240 by Max.Chen
Sequencer: Disable key button when allow level edits only is on.
#jira UE-46060
Change 3491406 by Yannick.Lange
Fix editor crashes when opening a project that includes a plugin with more than two custom Volume classes. This issue was caused because registering show volume commands is based on finding volume classes. Finding these classes at multiple times resulted in a mismatch of the returned array of volume classes because modules/plugins were still being loaded.
#jira UE-45806
Change 3491559 by Alexis.Matte
Make sure we use the good preview mesh when doing a preview
#jira UE-45963
Change 3491563 by Alexis.Matte
Fix crash with staticmesh editor LodLevel selection
Change 3491564 by Nick.Darnell
UMG - Fixing an offset with the grab handles in HDPI mode.
Change 3491595 by Nick.Darnell
Editor - Fixing a clipping artifact in the pin type dropdown in the blueprint editor.
Change 3491604 by Nick.Darnell
Back out changelist 3489265
Change 3491615 by Arciel.Rekman
Added malloc replay proxy (Linux only for now).
- Allows to dump malloc callstream (without regard to threads) and replay later to study the behavior of different mallocs and/or repro problems.
Change 3491684 by Arciel.Rekman
Added FMalloc functions I missed.
- Also moved function bodies into the .cpp file, this does not make a difference in performance in this case.
Change 3491692 by Matt.Kuhlenschmidt
Some minor fixes to the static mesh editor
- Fix UV combo button looking non-standard on the toolbar
- Fix a few combo buttons in the details panel looking too big.
Change 3491702 by Arciel.Rekman
Do not compile replay proxy-specific code when not used.
Change 3491717 by Michael.Dupuis
#jira UE-35083:
The component is now the owner of the PerInstanceRenderData instead of the proxy
Add an Update path to only update specified instances range
Always call BuildTreeIfOutdated so we have a standard code path to make sure static mesh are fully loaded before trying to build the tree
Moved the Instance Buffer aysnc to the base class, as it's not related to UHierarchicalInstancedStaticMeshComponent
Expose a new property to decide if we require dynamic instance buffer
Change 3491758 by Matt.Kuhlenschmidt
Fix crash on static mesh editor shutdown
Change 3491873 by Cody.Albert
Fixed clipping issue in Sequencer curve editor
#rnx
Change 3491956 by Matt.Kuhlenschmidt
Fix crash opening the Previewing sub-menu in the level editor settings menu
#jira UE-46095
Change 3492046 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492076 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492165 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492222 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492274 by Michael.Dupuis
#jira UE-46105: Fixed Clang warning
Change 3492338 by andrew.porter
QAGame: Testing ensure when submitting
Change 3492371 by Nick.Darnell
UMG - Reverting the animation sharing, cossed GLEO regressions in cooking. Will look for a better solution.
Change 3492462 by Matt.Kuhlenschmidt
Fix ensure checking in files through perforce
Change 3492491 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492505 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492517 by Jamie.Dale
The package localization ID is no longer used at all at runtime, and is now truly editor-only
This should have always been the case, but it was leaked into manifest/archives/PO files in 4.14, and while 4.15 removed it from PO files it was still present in the manifest/archives. This change removes it entirely (unless gathering editor-only data, and even then the PO file will still collapse the entries together for translation), and the deprecated 4.14 export behavior will now produce an error if you attempt to use it.
After taking this change you'll need to run a gather, import, and compile of your LocRes files to update your game localization to use the new localization IDs.
Change 3492630 by Nick.Darnell
UMG - Removing some extra cleanup code that's probably overkill and is causing a crash for uses of "Within" in class meta.
#jira UE-46124
Change 3492692 by Matt.Kuhlenschmidt
Fix drop shadows inheriting the outline color of the font. The outline should still appear but not have a different outline color from fill color
Change 3492714 by Matt.Kuhlenschmidt
Added outline with drop shadow to font automation test
Change 3492737 by Matt.Kuhlenschmidt
Fix linux
Change 3492992 by tim.gautier
Resaving Ocean Widget Blueprints / Sequences to resolve Legacy Sequence Data warnings
#jira UE-46132
Change 3493089 by Jamie.Dale
Ensure that the composite font of a font asset is flushed when the font object is GC'd
Change 3493322 by Jamie.Dale
Fixing null crash
#jira UE-45758
Change 3494467 by Andrew.Rodham
Fix Xbox warning
Change 3494852 by tim.gautier
QAGame: Changed streaming method of QA-EditorSmoke-Landscape to Always Loaded
Change 3494853 by Nick.Darnell
Another attempt at fixing the automation blueprint SA warning.
Change 3494896 by Arciel.Rekman
Fix possible null pointer access during Vulkan init.
- May fix static analysis warnings in UE-46142, although warnings seem to be referring to something else.
#jira UE-46142
Change 3494987 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3495010 by Matt.Kuhlenschmidt
Adding additional logging to track down html5 issue
Change 3495212 by Michael.Dupuis
#jira UE-46143: Properly init the InstanceRenderData during the cooking phase (required by fortnite)
Change 3495536 by Jamie.Dale
Updating UGameEngine to call its Super::PreExit after performing its own teardown
This prevents UEngine cleaning up resources that UGameEngine still needs.
#jira UE-46159
Change 3495551 by Arciel.Rekman
Another attempt to fix analyzer problem (UE-46142).
Change 3495794 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3495905 by Matt.Kuhlenschmidt
Fix USD crash when importing a meshwith no material
[CL 3499771 by Matt Kuhlenschmidt in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3383163 on 2017/04/06 by james.fox
Enabling Overlap automation tests.
Change 3387240 on 2017/04/10 by James.Fox
Enabling ProcMesh automation tests. Made minor changes to in-level object names.
Change 3397994 on 2017/04/18 by Nick.Darnell
Automation - Adding some areas for future extension to allow transmission of data, and performance information between controller and client. The next step is to expose a way in blueprints, or via C++ to hook these events and send these messages.
Change 3401903 on 2017/04/20 by samuel.proctor
Test map for blueprint bitwise operators
Change 3405592 on 2017/04/24 by Benjamin.Hyder
Updated Roughness only example to be more visible in Decals test map
Change 3405625 on 2017/04/24 by Benjamin.Hyder
Re-Saving material in decals map to remove log spam
Change 3406256 on 2017/04/24 by Mason.Seay
Show Collision tests, with Ground Truth Screenshots
Change 3410179 on 2017/04/26 by mason.seay
Beginning of Math test map
Change 3412646 on 2017/04/27 by mason.seay
More math tests
Change 3413556 on 2017/04/28 by Adric.Worley
Add support for expected errors in automation tests
Automation tests can now define expected errors/warnings that will not prevent
the test from succeeding. If expected messages are not encountered, the test
will fail. The intent is to allow unit tests to verify negative or error cases
while keeping the test pass report green. It is not intended as an error
suppression system.
#tests new automation tests
Change 3414217 on 2017/04/28 by mason.seay
Wake Event functional test map
Disabled Collision tests that still need review.
Change 3414605 on 2017/04/28 by mason.seay
Added more tests to Math map
Change 3415806 on 2017/05/01 by Adric.Worley
Suspend log parsing during tests with expected errors
Electric Commander was failing successful test passes that have expected errors
because of its log parsing. BenM added markers to temporarily disable error
parsing in CL 3414237, which this implements usage of.
#tests preflight
Change 3416022 on 2017/05/01 by Mason.Seay
Physics/ChildTransform tests
Change 3420820 on 2017/05/03 by Nick.Darnell
Automation - Allowing users to control the delay from the quick getter functions for Default Game/Rendering settings for screenshots. Avoids needing to add more delay nodes to your graph.
Improving the Box Drop example to use the new delay options.
The FunctionalTest actor now ticks even when the game is paused.
Change 3422013 on 2017/05/03 by Nick.Darnell
Automation - Adding an initial version of a ground truth storge mechanism that will only run in the editor. Users can use special runs of their tests to store the ground truth, then rewire things to then in the future read that ground truth. Added an example map showing the usage.
Change 3422802 on 2017/05/04 by Nick.Darnell
Automation - Fixing a crash in the curve asset actions that assumes there will always be import data.
Change 3422803 on 2017/05/04 by Nick.Darnell
Automation - Adding some comments to the ground truth function.
Change 3423739 on 2017/05/04 by Nick.Darnell
Automation - Introducing a way for people to provide Ground Truth for their tests.
Change 3423768 on 2017/05/04 by Nick.Darnell
Automation - GTD can no longer be modified on the build machine. Unchecking modifiable on the example GTD.
Change 3425226 on 2017/05/05 by Nick.Darnell
Automation - Fixing the FinishLoading code to only force shader compilation on platforms that don't require cooking.
#jira UE-44669
Change 3428140 on 2017/05/08 by Ori.Cohen
Added ground truth for scene query testing.
Change 3441024 on 2017/05/16 by Nick.Darnell
Automation - Ground truth pass, improving system based on feedback. Ditching the bCanModify, there's now a way to reset the data, and if it's been filled, you've got to reset it to save over it.
Change 3443894 on 2017/05/17 by Nick.Darnell
Automation - Automation tweaking some logging.
Change 3446426 on 2017/05/18 by Nick.Darnell
Automation - Adding additional logging and attempting to fix the warning on the build machine.
Change 3447617 on 2017/05/18 by Nick.Darnell
Automation - Found an issue with the automation system keeping an old map around if the names were similar enough, and one contained the entirety of the other map's name. This should fix the overlap warnings on the build machine. Also cleaned up several places in the functional test manager that looked like they could cause confusion and problems with cleaning them up.
[CL 3449079 by Nick Darnell in Main branch]
#lockdown Nick.Penwarden
#rb none
Change 3436405 on 2017/05/11 by Andrew.Grant
Fix for client/server compile issue
#!tests compiled
#!rb none
Change 3436160 on 2017/05/11 by Dan.Hertzka
Merging CL 3418191 to Dev-General for game capture team
- Fixes MasterPoseComponent not updating slave components when being animated by Sequencer
#!rb none
#!tests none
Change 3436098 on 2017/05/11 by Andrew.Grant
Skip LoadClass in FAnimBlueprintCompiler::PostCompileDiagnostics if no class is specified (fixes Failed to load Object warnings)
Laurent - I'm assuming it's valid not to have a class here, if not let me know and I'll add an else() to issue a warning
#!tests ran cooker and verified warnings are gone
#!review-3436099 @Laurent.Delayen
#!rb none
Change 3435892 on 2017/05/11 by Ben.Salem
Make timed out Gauntlet tests ignore Retry codes. Turn retry back on in HeroFunctionalTest as a result.
#!rb clayton.langford
#!tests Ran some functional character tests post change.
Change 3435864 on 2017/05/11 by David.Ratti
Fix for linux servers not adding all native tags properly due to static order of init differences.
#!rb none
#!tests compile
Change 3435521 on 2017/05/11 by Daniel.Lamb
Fixed the compile editor check box in launch build dialog.
#!rb Ben.Marsh
#!test Launch build paragon.
Change 3435331 on 2017/05/11 by Frank.Fella
Niagara - Stack - Add support for assigning locally defined handles to module inputs e.g. Physics.Force, also fix up some graph layout and wiring bugs.
#!tests Can now override inputs to locally defined parameter handles like Physics.Force and can properly move up/down and delete those modules.
#!rb none
#!codereview Olaf.Piesche,Simon.Tovey,Shaun.Kime
Change 3435020 on 2017/05/11 by Laurent.Delayen
Refactored AnimBP Post Compile Validation to be in its own class, in the AnimGraph module. So we can access UAnimGraphNodes for auditing.
#!rb michael.noland
#!codereview james.golding, thomas.sarkanen
#!tests Hero AnimBP compile.
Change 3434979 on 2017/05/11 by Daniel.Lamb
Removed engine version cl from the inisettings check as it's unstable.
#!rb Trivial
#!test none
Change 3434880 on 2017/05/11 by Alexis.Matte
Add a base source folder to store more robust source file relative path in the asset to ease the re-import process
#!jira UE-44858
#!rb matt.kuhlenschmidt
#!tests run fbx automation tests
Change 3434869 on 2017/05/11 by Mieszko.Zielinski
A fix to BTDecorator_TimeLimit to make it work in tight loops #!UE4
#!codereview Lukasz.Furman
#!test golden path
#!rb none
Change 3434224 on 2017/05/10 by Andrew.Grant
Orion tests -
Fix for case where a semi-responsive kit could continually be picked leading to a timeout.
Better path structure for saving logs, and some error handling
#!tests #!rb none
Change 3434194 on 2017/05/10 by Andrew.Grant
Merging 3434064 from //Orion/Release-40.1 to Release-40 (//Orion/Release-40)
Make EDL match old linker wrt setting of RF_NeedPostLoadSubobjects on CDOs (only blueprint CDOs are loaded by the linker - so BP CDOs only). The Old Linker would try to set RF_NeedPostLoadSubobjects, but StaticAllocateObject would discard it and RF_NeedPostLoad, but then the older linker would later set RF_NeedPostLoad, but not RF_NeedPostLoadSubobjects. PostLoadSubobjects actually creates subobjects on the CDO so running that function would stomp overriden subobjects.
#!jira OR-38085
#!rb Michael.Noland
#!tests played solo vs ai as murdock, completed game and buttoned through summary screen
Change 3434064 on 2017/05/10 by Dan.Oconnor
Make EDL match old linker wrt setting of RF_NeedPostLoadSubobjects on CDOs (only blueprint CDOs are loaded by the linker - so BP CDOs only). The Old Linker would try to set RF_NeedPostLoadSubobjects, but StaticAllocateObject would discard it and RF_NeedPostLoad, but then the older linker would later set RF_NeedPostLoad, but not RF_NeedPostLoadSubobjects. PostLoadSubobjects actually creates subobjects on the CDO so running that function would stomp overriden subobjects.
#!jira OR-38085
#!rb Michael.Noland
#!fyi Gil.Gribb
#!tests played solo vs ai as murdock, completed game and buttoned through summary screen
Change 3433811 on 2017/05/10 by Ben.Salem
Add 5 minute timeout into Queue For Lobby function in auto tests so we don't wind up with weird timeouts overnight.
#!rb clayton.langford
#!tests Ran a set of comparison tests and killed client multiple times
Change 3433503 on 2017/05/10 by David.Ratti
Add -noepicportal to gauntlet args
#!rb Andrew.Grant
#!tests gauntlet
Change 3433291 on 2017/05/10 by Laurent.Delayen
Added Alpha parameter to AimOffset anim nodes.
#!rb none
#!tests wukong
#!codereview lina.halper
Change 3433185 on 2017/05/10 by Shaun.Kime
Added Get/SetValue functions for NiagaraBool types as well as an IsValid function. All access to the data should go through this path.
#!rb none
#!tests n/a
Change 3433071 on 2017/05/10 by Shaun.Kime
Trying to capture crash that occurs when working with modules due to timing of parameter view model rebuilds and draw calls for slate. Leaving some debug code in place should this change not completely protect against it.
Modified the change handler for parameter map collections to correctly set the value variable.
#!rb none
#!codereview frank.fella
#!tests n/a
Change 3432919 on 2017/05/10 by David.Ratti
temp logging for linux server tag mismatch problem
#!rb none #!tests compile
Change 3432758 on 2017/05/10 by Andrew.Grant
Script fix from DanielL
#!tests #!rb na
Change 3432710 on 2017/05/10 by Shaun.Kime
Now defaulting to Module. for new custom variables.
#!rb none
#!tests n/a
Change 3432609 on 2017/05/10 by Andrew.Grant
Fix from JohnN for many ability cancellation bugs
#!rb Johh.Nielson
#!review-3432610 @John.Nielson, @David.Ratti, @Laurant.Delayen
#!tests na
Change 3432541 on 2017/05/10 by Simon.Tovey
Moved Niagara settings to plugins section.
#!rb none
#!tests none
Change 3432151 on 2017/05/09 by Jeff.Williams
Merging //Orion/Main to Release-40.1 (//Orion/Release-40.1) @3432138
#!rb none
#!tests none
Change 3432121 on 2017/05/09 by Jeff.Williams
Initial branch of files from Release-40 (//Orion/Release-40) to Release-40.1 (//Orion/Release-40.1)
Change 3431141 on 2017/05/09 by Alexis.Matte
Make sure content browser import override use the re-import factory to override the asset instead of the import factory.
#!rb none
#!tests run fbx automation tests
Change 3431127 on 2017/05/09 by Shaun.Kime
Can now handle any arbitrary nesting of variable namespaces
#!rb none
#!codereview simon.tovey
#!tests created an internal test that nests out multiple structs
Change 3431124 on 2017/05/09 by Shaun.Kime
Adding ability for graph to add in non-UNiagaraNodeEmitter & UNiagaraNodeInput values for System graph.
#!rb none
#!codereview simon.tovey
#!tests n/a
Change 3431043 on 2017/05/09 by David.Ratti
Push the GE context down to the GC parameters for minimal replication cues. Fixes issues where EffectCauser ends up being the target of the cue instead of the source of the GE.
#!rb none
#!tests editor
Change 3430861 on 2017/05/09 by Frank.Fella
Niagara - Stack - Cleanup and fixes.
+ Fix undo to all stack edits.
+ When promoting module inputs to emitter inputs, copy the module input value.
#!Tests Undo works correctly for moving up/down the stack, deleting/adding modules, and for all input edits. Promoting a module input to an emitter input preserves the value.
#!rb none
#!codereview Olaf.Piesche,Simon.Tovey,Shaun.Kime
Change 3430603 on 2017/05/09 by Shaun.Kime
Commenting If node
#!rb none
#!tests n/a
Change 3430538 on 2017/05/09 by Shaun.Kime
Fixing prior checkin. We need for Niagara true and false to be explicitly -1 and 0 for the current implementation of the VM. More comments were added to this effect.
#!rb none
#!codereview frank.fella, simon.tovey
#!tests labelled the SphereLocationBoolTrueAsParameter asset more exactly so that we can know what we are testing here
Change 3430442 on 2017/05/09 by Shaun.Kime
Sphere location asset
#!rb none
#!tests this is a test case for spawning on a sphere
Change 3430438 on 2017/05/09 by Shaun.Kime
Fixing bool conversion
#!rb frank.fella
#!tests SphereLocation asset
Change 3429736 on 2017/05/08 by Olaf.Piesche
More GPU sim work; dispatch now works properly, more work on read/write of data sets needed; parmeter binding, setting, unsetting, should all be good; also made shader debug output work for niagara shaders; CPU simulation should work as before, and while GPU doesn't do anything useful yet, we're at the point of running Niagara shaders on GPU over buffers defined by data sets now
Recommend not setting an emitter to GPU sim for now :)
#!rb none
#!tests ran CPU sim on test assets; ran shader compile and GPU sim without crashes (but of course also without visible results)
Change 3429390 on 2017/05/08 by Shaun.Kime
Added a force compile on load global variable that assists if a file crashes on load due to a bad script compilation.
#!rb none
#!tests fixes Howitzer
Change 3429368 on 2017/05/08 by Andrew.Grant
Added more debugging info on module load failure
#!tests compiled
#!rb none
Change 3429269 on 2017/05/08 by Andrew.Grant
Made DLL error just a log. apparently there are a few of these...
#!tests #!rb na
Change 3428950 on 2017/05/08 by David.Ratti
GameplayTags.PrintNetIndices command for tracking down gameplay tag error
#!rb #!tests none
Change 3428865 on 2017/05/08 by Shaun.Kime
Fixing incorrect interpolation of primer tutorial content in interpolated spawning. We were not properly handling required, but not exposed input nodes.
#!rb simon.tovey
#!tests run primer tutorial in interpolated mode
Change 3428647 on 2017/05/08 by Andrew.Grant
Reverted argument to -test form
#!rb #!tests none
Change 3428633 on 2017/05/08 by Andrew.Grant
Extra debugging info for DanB
#!tests #!rb none
Change 3428473 on 2017/05/08 by Andrew.Grant
Tidied up structure of automation logs
#!tests boot test locally
#!rb none
Change 3428226 on 2017/05/08 by Paul.Moore
#!libWs
- Explicitly track if the connection is open or not (so that IsConnected() returns true when the connection is closed but not yet destroyed).
#!codereview rob.cannaday
#!rb none
#!tests matchmaking
Change 3428011 on 2017/05/08 by Alexis.Matte
fix fbx importer to allow animation sample rate greater then 30Hz
#!jira UE-44685
#!rb matt.kuhlenschmidt
#!tests none
Change 3427502 on 2017/05/07 by Andrew.Grant
Fixed bug with order of states in Gauntlet
Made MallocLeakDetection compact periodically to reduce footprint for testkits
OrionMemoryReport now limits tracking to memory >= 16kb to reduce footprint for testkits
Fixed report error with missing file when running mempory report on a test build
#!tests LoadTest, MemoryReport tests
#!rb none
Change 3427352 on 2017/05/06 by Andrew.Grant
Bigly refactor of Orion native test framework into new "Gauntlet" plugin
- All logic for creating test controllers, ticking them, and propgating events is now in GauntletModule
- Orion initializes Gauntlet module at startup and passes necessary information to generate Frontend, Draft, Game states
- States are now FName's so games can provide their own sets of state
- OrionTestControllerBase now inherits from GauntletTestController
- Test controllers are now passed as a -gauntlet argument to game (was -test)
#!tests ran locally lots, preflighted with a full test pass
#!rb none
Change 3426807 on 2017/05/05 by Frank.Fella
Niagara - Stack - Make the up, down, and delete buttons less obnoxious.
#!tests the buttons are less obnoxious
#!rb none
Change 3426454 on 2017/05/05 by Andrew.Grant
Fixed issue in Gauntlet when using a PS4 that has no name set
#!rb none
#!tests ran against PS4 with no name set
Change 3426317 on 2017/05/05 by Frank.Gigliotti
Added utility function to draw a 2D box to the debug canvas.
#!Tests Drawing in ShowDebug screens
#!RB None
Change 3426047 on 2017/05/05 by Dan.Hertzka
[OR-38289] - The DataAsset creation dialog now filters out classes with the HideDropDown class flag, so skins and variants can only be created via the right-click menu on the hero/skin they belong to, respectively
#!rb Matt.Kuhlenschmidt
#!tests Skin & SkinVariation item defs do not appear in the DataAsset creation dialog
Change 3426025 on 2017/05/05 by Frank.Fella
Niagara - Stack - Can now move and delete stack items.
#!tests none
#!rb none
#!codereview Olaf.Piesche,Simon.Tovey,Shaun.Kime
Change 3425913 on 2017/05/05 by Matt.Schembari
Apparently I never actually compiled this?
#!rb none
#!tests compile
Change 3425819 on 2017/05/05 by Matt.Schembari
OR-36760: PS4 client can load with no visible cursor
- Added logging per Darnell to help catch this issue.
#!rb Nick.Darnell
#!tests PIE with breakpoints
#!CodeReview Andrew.Grant
#!QAReview I've added more logging. The issue won't be fixed, but when you see it again, please attach the logs. I'm looking for lines like "Failed to load cursor" or "Attempting to add an invalid cursor class."
Change 3425760 on 2017/05/05 by Shaun.Kime
Follow up to previous fix. We weren't releasing delegates properly.
#!rb none
#!codereview frank.fella
#!tests ran under normal usage for a while
Change 3425623 on 2017/05/05 by Frank.Fella
Niagara - Stack - Can now add modules
#!tests Added modules, it worked.
#!rb none
#!codereview Olaf.Piesche,Simon.Tovey,Shaun.Kime
Change 3425250 on 2017/05/05 by Andrew.Grant
Merging using ROBO://Orion/Main->//Orion/Dev-General
#!tests #!rb none
Change 3425196 on 2017/05/05 by Shaun.Kime
Being more diligent about cleaning up delegate bindings in destructors as I have been getting a periodic crash when objects are gc'ed.
#!rb none
#!tests ran with changes for a bit
#!codereview frank.fella
Change 3425184 on 2017/05/05 by Shaun.Kime
Fixing missing GC reference to the stack view model (which is a UObject)
#!rb frank.fella
#!tests ran over time with GC.CollectGarbageEveryFrame 1
Change 3425036 on 2017/05/05 by Simon.Tovey
Fix for bad constant table generation.
Cause by confliting names between bool and int constants.
#!tests works
#!rb none
#!codereview Shaun.Kime
Change 3424539 on 2017/05/04 by Andrew.Grant
Another two quick patchups...
#!tests compiled Win64 editor
#!rb none
Change 3424535 on 2017/05/04 by Frank.Fella
Niagara - Stack UI updates
+ Input remapping drop-down menu now works.
+ Graph is auto-arranged after being mangled by the stack.
#!tests graph appears to update correction when remapping through the stack.
#!rb none
#!codereview Olaf.Piesche,Simon.Tovey,Shaun.Kime
Change 3424514 on 2017/05/04 by Andrew.Grant
Compilation fixes for some files that were accidentally checked in!
#!tests compiled PS4
#!rb none
Change 3424455 on 2017/05/04 by Andrew.Grant
Moved a lot of Orion test controller code to "Gauntlet" plugin
#!tests compiled Win64 Editor & PS4
#!rb none
Change 3424433 on 2017/05/04 by Shaun.Kime
Added simple sub uv example based on https://wiki.unrealengine.com/SubUV_Particle_(Tutorial)
#!rb none
#!tests n/a
Change 3424215 on 2017/05/04 by Shaun.Kime
Adding map when no particles or system parameters are used.
#!rb none
#!tests Sparks.uasset
Change 3423924 on 2017/05/04 by Shaun.Kime
Preventing crash when no parameter map is wired into graph
#!rb none
#!tests broke graph wiring mid-graph. crashed before this change.
Change 3423803 on 2017/05/04 by Shaun.Kime
Adding tooltips on stack items so that you can get more insight into what they do.
#!rb none
#!tests n/a
#!codereview frank.fella
Change 3423795 on 2017/05/04 by David.Ratti
Fix GE mod data not being passed through properly
#!rb none #!tests editor pie
#!codereview Aaron.Eady
Change 3423688 on 2017/05/04 by Shaun.Kime
Fixing crash on exit bug
#!rb none
#!codereview frank.fella
#!tests n/a
Change 3423341 on 2017/05/04 by Shaun.Kime
Adding ability to not have to type in the known variables for the graph in Get/Set nodes.
#!rb none
#!tests n/a
Change 3423340 on 2017/05/04 by Frank.Fella
Niagara - Initial stack UI implementation. Lots of stuff still doesn't work, but I wanted to get up latest and get what I have in to avoid a single monolithic check-in.
#!tests none
#!rb none
#!codereview Olaf.Piesche,Simon.Tovey,Shaun.Kime
Change 3423040 on 2017/05/04 by Jeff.Williams
Clearing up Robomerge
Merging //Orion/Main to Dev-UI (//Orion/Dev-UI) @3422721, @3422721
#!rb none
#!tests none
Change 3422746 on 2017/05/04 by jon.lietz
- adding back in the depricated warning forAssignSetByCallerMagnitude() need, to use AssignTagSetByCallerMagnitude() now
- marked SetFilterSetByCallerMagnitude() as deprecated, need to use SetFilterTagSetByCallerMagnitude() now
- set SplitGameplayEffectSpecBetweenActors and SplitGameplayEffectSpecBetweenTargetData to deprecated, need to use TagSplitGameplayEffectSpecBetweenActors and TagSplitGameplayEffectSpecBetweenTargetData now
- cleaned up all code to use the tag verison of set by caller, and fixed up what data I could some was checked out and will need to be fixed by design.
#!rb none
#!test compiles and played a bit in monolith
#!lockdown Billy.Rivers
#!ROBOMERGE-SOURCE: CL 3422721 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
#!ROBOMERGE-SAYS: Unresolved conflicts. jon.lietz, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/OrionGame/Content/Blueprints/OrionAbilityMacros.uasset
#!CodeReview: jon.lietz, jason.bestimt, andrew.grant, jeff.williams
Change 3422721 on 2017/05/04 by Jon.Lietz
- adding back in the depricated warning forAssignSetByCallerMagnitude() need, to use AssignTagSetByCallerMagnitude() now
- marked SetFilterSetByCallerMagnitude() as deprecated, need to use SetFilterTagSetByCallerMagnitude() now
- set SplitGameplayEffectSpecBetweenActors and SplitGameplayEffectSpecBetweenTargetData to deprecated, need to use TagSplitGameplayEffectSpecBetweenActors and TagSplitGameplayEffectSpecBetweenTargetData now
- cleaned up all code to use the tag verison of set by caller, and fixed up what data I could some was checked out and will need to be fixed by design.
#!rb none
#!test compiles and played a bit in monolith
#!lockdown Billy.Rivers
Change 3422412 on 2017/05/03 by Andrew.Grant
Merging //Orion/Main to Dev-Cinematics (//Orion/Dev-Cinematics)
#!tests #!rb na
Change 3422407 on 2017/05/03 by Andrew.Grant
Merging using ROBO://Orion/Main->//Orion/Dev-General
#!tests #!rb none
Change 3422281 on 2017/05/03 by Shaun.Kime
Moving default assets into NiagaraTestbed
#!lockdown Andrew.Bains
#!rb none
#!tests n/a
Change 3422241 on 2017/05/03 by Shaun.Kime
Now synchronizing data interfaces using the same rules as parameters
#!rb none
#!codereview frank.fella
#!tests TestDataInterfaceEffect overrides curves from TestDataInterfaceParameterMap
Change 3422095 on 2017/05/03 by Shaun.Kime
Rewrote logic for non-parameter mapped emitters to put their data into parameter map format. This has the advantage of cleaning up the code substantially for interpoloated spawning.
Added interpolated spawning to parameter maps.
#!rb none
#!codereview simon.tovey, frank.fella, olaf.piesche
#!tests opened an recompiled all known effects and emitters in both interpolated spawn and regular spawn
Change 3421829 on 2017/05/03 by Simon.Tovey
Removed stats tracking for operations and placed it behind a CVar should someone want to disable it entirely.
Should probably cook them out too.
#!tests none
#!rb none
Change 3421597 on 2017/05/03 by Andrew.Grant
Fix for shipping build compilation issue
#!tests #!rb none
Change 3421481 on 2017/05/03 by Andrew.Grant
Leak reporter tweaks - now pass desired reports in as arguments
#!tests ran LeakCheck
#!rb none
Change 3421451 on 2017/05/03 by Andrew.Grant
Merging //Orion/Main to Dev-Balance (//Orion/Dev-Balance)
#!tests #!rb na
Change 3421299 on 2017/05/03 by Andrew.Grant
Merging using ROBO://Orion/Main->//Orion/Dev-General
#!tests #!rb na
Change 3421295 on 2017/05/03 by Andrew.Grant
Merging 39.5 changes through //Orion/Main to Release-40 (//Orion/Release-40)
#!tests #!rb na
Change 3421273 on 2017/05/03 by Andrew.Grant
Improvements to leak detection and Orion memory tests
- Moved most leak reporting out of MallocLeakDetection allocator and into MallocLeakReporter
- MallocLeakReporter supports mallocleak.start / mallocleak.stop with optional reporting times
- Simplified orion-side memory reporting
- Now always add DebugOutputDevice when logging is enabled
#!tests loats and lots of soaking
#!rb send CR to Core-Team
Change 3421248 on 2017/05/03 by Andrew.Grant
Merging fixes from //Orion/Release-39.5 to Main (//Orion/Main)
#!tests #!rb na
Change 3420862 on 2017/05/03 by Simon.Tovey
Missing files
#!rb none
#!tests none
Change 3420851 on 2017/05/03 by Simon.Tovey
Reworked compilation of internal constants to avoid dependancy between ShaderFormatVectorVM and Niagara.
#!rb none
#!tests stuff works
#!codereview Shaun.Kime, Frank.Fella, Olaf.Pieche
Change 3420817 on 2017/05/03 by Laurent.Delayen
Integrated CL#! 3418811 from UE4/Dev-Framework
Fix existing animation blueprint nodes with dead asset references duplicated by pins. This code can be applied independent of the other change to fix specific games
#!codereview ben.zeigler
#!rb ben.zeigler
#!tests wukong PIE
Change 3420393 on 2017/05/03 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb na
Change 3420383 on 2017/05/03 by Andrew.Grant
Merging down from Release-40 to unblock Robomerge
#!tests #!rb na
Change 3420369 on 2017/05/03 by Andrew.Grant
Workaround for issue seen when working on BP_DamageNumberManager
#!tests compiled
#!rb Dan.Oconner
#!ROBOMERGE: Main, DG, DUI
Change 3420357 on 2017/05/03 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb na
Change 3419928 on 2017/05/02 by Olaf.Piesche
More GPU sim updates; some additional shader map tweaks, added a dispatch queue to the render module, binding and dispatching if sim target is GPU (GPU sim is not working yet though!); also shoulld fix some existing compile issues; CPU sim and other current functionality should be unaffected by this commit.
#!rb none
#!tests compiled, ran editor, opened test effect
Change 3419751 on 2017/05/02 by Zak.Middleton
#!ue4-orion - Remove unused function FPhysicsFilterBuilder::SetExtraFiltering(). It was also incorrect.
#!codereview Ori.Cohen
#!rb none
#!tests compiled, launched editor
Change 3419683 on 2017/05/02 by Andrew.Grant
Temporarily removing depreciation flag
#!codereview @David.Ratti
#!tests #!rb none
Change 3419594 on 2017/05/02 by Shaun.Kime
Fixing interpolated spawning's base algorithm wrt timing. Parameter maps to come.
When you spawn, the delta time is zero (shouldn't be used anyway) and the values are interpolated based on the in-between of the last frame and current frame when the particle spawns.
When you update that first frame, the delta time is the time from the tween to the current frame and the parameter values are the current frame's values.
Tried to convert UNiagaraScript::Usage to be an accessor to better trap when we were setting the type away from interpolating scripts. Converted most cases over, but kept it public due to the accessors for asset browsing.
Removed GetCompanionUpdate/Spawn script as they are no longer used.
Also making sure that the script and other parameters are properly duplicated for event graphs.
#!rb none
#!test InterpolatedSpawnTestCircle and InterpolatedSpawnTestLine
#!codereview simon.tovey
Change 3419568 on 2017/05/02 by Laurent.Delayen
OR-37965 Fixed first frame AnimNotifies in a Montage getting skipped for SimulatedProxies, due to NotifyWeight being uninitialized and Montage's weight not being updated to meet notify weight threshold.
#!rb none
#!tests Kallari double jump networked.
Change 3419513 on 2017/05/02 by Shaun.Kime
Encountered div by zero.
#!rb none
#!tests none
#!codereview olaf.piesche
Change 3419184 on 2017/05/02 by Jeff.Williams
Converting <utf8> to <text>. Stripping BOM
#!rb none
#!tests none
Change 3418731 on 2017/05/02 by Zak.Middleton
#!orion - Add 2 more bits to collision MaskFilter. Added TeamBlueBarrier and TeamRedBarrier. Add SetTeamBarrierCollision() function to OrionBlueprintLibrary for setting collision on pieces spawned by abilities. Not yet hooked up to Dekker's ult, though in testing it does work (waiting to hear feedback on some details there).
#!rb Frank.Gigliotti
#!tests PIE multiplayer.
Change 3418581 on 2017/05/02 by Mieszko.Zielinski
A set of small AI API extensions, in preparation for the Bot Playbook submission #!Orion
#!test compilation
#!rb none
Change 3417896 on 2017/05/02 by David.Ratti
Unshelved from pending changelist '3417884':
Integrate keyword system. This is Events, Qualifiers, and GameplayStats. (Item and ItemProperty keywords remain in Dev-UI).
Note this has a few content warnings on startup. Will submit spot fixes after the integrate.
#!rb none
#!tests compile, editor, pie, cook
#!ROBOMERGE-SOURCE: CL 3417883 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-UI)
#!ROBOMERGE-SAYS: Unresolved conflicts. david.ratti, please merge this change by hand.
//ROBOMERGE_ORION_Dev_UI/OrionGame/Source/OrionEditor/OrionUnrealEdEngine.cpp
#!CodeReview: david.ratti, jason.bestimt, andrew.grant, jeff.williams
Change 3417883 on 2017/05/02 by David.Ratti
Integrate keyword system. This is Events, Qualifiers, and GameplayStats. (Item and ItemProperty keywords remain in Dev-UI).
Note this has a few content warnings on startup. Will submit spot fixes after the integrate.
#!rb none
#!tests compile, editor, pie, cook
Change 3416622 on 2017/05/01 by Andrew.Grant
Merging //Orion/Main to Dev-UI (//Orion/Dev-UI)
#!tests #!rb na
Change 3416463 on 2017/05/01 by Ben.Salem
Merging //Orion/Dev-General to Release-40 (//Orion/Release-40)
#!rb #!tests na
Change 3416291 on 2017/05/01 by Ben.Salem
Don't send out report mail for skills/smokes if there's nothing to send out. This prevents us from getting spammed to oblivion as tests roll into new branches.
#!rb none
#!tests compiled
Change 3416214 on 2017/05/01 by Andrew.Grant
Merging //Orion/Main to Dev-Balance (//Orion/Dev-Balance)
#!tests #!rb na
Change 3416131 on 2017/05/01 by Mieszko.Zielinski
Made EQSDebugger store query tick data only if there has been any work done for that specific query #!UE4
#!test golden path
#!rb Lukasz.Furman
Change 3416044 on 2017/05/01 by Andrew.Grant
Missed file needed by previous change
#!tests #!rb na
Change 3416043 on 2017/05/01 by Jon.Lietz
seperating out the FName and FGameplayTag for the SetByCallerMagnitude() into two functions so the FName version can be marked as depricated and gives us a clean path at removing the Data and Functions with engine version 4.17
#!rb none
#!tests compiles and played in the box map
#!codereview David.Ratti Billy.Bramer Fred.Kimberley
Change 3416042 on 2017/05/01 by Andrew.Grant
Merging //Orion/Main to Dev-Cinematics (//Orion/Dev-Cinematics)
#!tests #!rb na
Change 3416020 on 2017/05/01 by David.Ratti
non unity fix
remove unused function I added to TOptional
#!rb #!tests none
Change 3415996 on 2017/05/01 by Andrew.Grant
Adds a new delegate 'OnMemoryTrim' that is called as a request for systems to free up any temporary or high-watermark memory they may be holding. UEngine::TrimMemory calls this delegate after flushing rendering. By default this is called during LoadMap, but can be called at other times if necessary (and the cost can be afforded).
Added OnMemoryTrim handlers to the following -
GarbageCollector reference pools: The count and size of these pools can grow significantly based on content and user patterns. Soaking games of Paragon they rarely exceed 4MB, but in the frontend been seen at ~10MB. Additionally the size of pool elements can trend upwards overtime based the section of objects they are assigned to.
ParticleGpuSimulation: The classes here grow based on content usage
PhysLevel: PhysX resources are normally cleaned up one frame after their owning UObject's are destroyed. Calling this via "Trim" collects that memory immediately which benefits reports that are generated immediately afterwards.
#!tests soaked Paragon on PS4, lots
#!rb set to Core-Team alias as CR
Change 3415952 on 2017/05/01 by Andrew.Grant
Utility class and COUNT_INSTANCES macro that allows manual tracking of non-UObject instances to diagnose behaviors
#!tests lots of soaking
#!rb DanL
Change 3415778 on 2017/05/01 by Gil.Gribb
Test change, nothing actually changed.
#!rb none
#!tests none
Change 3415448 on 2017/04/30 by Andrew.Grant
Merging //Orion/Main to Dev-UI (//Orion/Dev-UI)
#!tests ShortSOloGame
#!rb none
Change 3415430 on 2017/04/30 by Andrew.Grant
Merging //Orion/Main to Dev-UI (//Orion/Dev-UI)
#!tests #!rb na
Change 3415298 on 2017/04/29 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb none
Change 3415269 on 2017/04/29 by Andrew.Grant
Merging //Orion/Main to Release-40 (//Orion/Release-40)
#!tests #!rb none
Change 3415264 on 2017/04/29 by Andrew.Grant
Copying //Orion/Dev-REGS to Main (//Orion/Main)
#!tests #!rb none
Change 3415263 on 2017/04/29 by Andrew.Grant
Merging //Orion/Main to Dev-REGS (//Orion/Dev-REGS)
#!tests #!rb none
Change 3415226 on 2017/04/29 by Andrew.Grant
Copying //Orion/Dev-General to Main (//Orion/Main)
#!tests #!rb none
Change 3414890 on 2017/04/28 by Olaf.Piesche
-Bit more cleanup
-Added a UniqueID to UNiagaraScript to distinguish spawn and update scripts coming from the same source; this is regenerated everytime ChangeID is updated
-Changed synchronizing IDs to a set instead of passing guid reference to be overwritten to the source guid owner in order to make the above work
-Encapsulating the most frequently used members of UNiagaraScript for better debugability
#!rb none
#!tests compiled and ran
Change 3414784 on 2017/04/28 by Mieszko.Zielinski
Fixed EQS manager needlessly using up all its time budget if it manages to finish all active queries and there are some queries that are marked as finished due to being aborted before the EnvQueryManager::Tick call #!UE4
Added stats to EQSDebugger for debugging purposes, but since that's what helped me nail down the bug I've left them in.
#!test golden path
#!rb none
#!codereview Lukasz.Furman, John.Abercrombie
Change 3414740 on 2017/04/28 by Andrew.Grant
Merging //Orion/Main to Dev-REGS (//Orion/Dev-REGS)
#!tests #!rb na
Change 3414691 on 2017/04/28 by Andrew.Grant
Copying //Orion/Dev-General to Main (//Orion/Main)
#!tests #!rb none
Change 3414665 on 2017/04/28 by Zak.Middleton
#!ue4-orion - Clean up collision FMaskFilter usage to be able to cleanly change the number of bits it uses. Current value unchanged, this is a baseline for bumping it up next.
#!rb Ori.Cohen
#!tests AITest multiplayer
Change 3414499 on 2017/04/28 by Shaun.Kime
Now forcing spawn scripts to write default values to their attributes in main rather than call an input function whose results were bogus.
#!rb none
#!codereview simon.tovey
#!tests ran on multiple existing scripts to ensure proper output
Change 3414332 on 2017/04/28 by Shaun.Kime
Now function calls have their own internal name that we use when doing aliasing. This is important as it allows us to deterministically address a node irrespective of traversal ordering.
#!rb none
#!codereview frank.fella
#!tests n/a
Change 3414231 on 2017/04/28 by Jeff.Williams
Initial branch of files from Main (//Orion/Main) to Release-40 (//Orion/Release-40)
Change 3414055 on 2017/04/28 by Shaun.Kime
Now that emitter scripts compile event scripts, we no longer need to compile standalone when Applying.
#!rb none
#!tests found crash when updating a collision event script due to incorrect usage of standalone compile.
Change 3414049 on 2017/04/28 by Shaun.Kime
Added simple IsEventScript accessor.
#!rb none
#!tests n/a
Change 3414046 on 2017/04/28 by Shaun.Kime
Added function to convert a SYS_* macro value into its parameter map form.
#!rb none
#!tests integrated into later changelist and ran over several scripts
Change 3413618 on 2017/04/28 by Ben.Salem
Add skins to smoke test, and fix big camp locations.
#!rb adric.worley
#!tests Ran a smoke test with Muriel, generated a report.
Change 3413106 on 2017/04/27 by Andrew.Grant
Merging //Orion/Main to Dev-REGS (//Orion/Dev-REGS)
(contains latest code from Dev-Gen)
#!tests preflighted
#!rb none
Change 3412911 on 2017/04/27 by Andrew.Grant
Copying //Orion/Dev-General to Main (//Orion/Main) ahead of v40
#!tests #!rb none
Change 3412528 on 2017/04/27 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb na
Change 3411879 on 2017/04/27 by Chris.Bunner
Shader typo fix.
#!rb None
#!tests Loaded multiple heroes and assets
Change 3411689 on 2017/04/27 by David.Ratti
Refresh data table view and select new row when adding new gameplay tags to the keyword data tables
#!rb Jamie.Dale
#!tests editor
Change 3411680 on 2017/04/27 by Simon.Tovey
Restoring the set of NumUserPtrs that was lost somewhere along the way.
#!rb none
#!tests none
#!codereivew Olaf.Piesche
Change 3411177 on 2017/04/27 by Chris.Bunner
Fixed missing shader variable initialization.
#!rb None
Change 3410880 on 2017/04/27 by Simon.Tovey
Fixed a few bugs in yesterday's checkins.
- HLSL ordering of int/float register indices was incorrect.
- Mistakenly left a start index on the new accessor classes ctors and an implicit convert to bool caused some iterators to access the current frame data when trying to access the previous.
#!rb none
#!tests no crash, collision works(mostly)
#!codereview Shaun.Kime
Change 3410088 on 2017/04/26 by Shaun.Kime
Getting basic interpolated spawn back to compiling in scripts.
#!rb none
#!tests n/a
Change 3409935 on 2017/04/26 by Ben.Salem
Add nightly Skill Changes report to the Deep Tests list to generate a list of all changes made per day in a branch. Also, separate solo smoke report node from dependencies on all other tests running so we can get smoke reports more rapidly.
#!rb brad.angelcyk
#!tests Ran preflight of new node successfully.
Change 3409724 on 2017/04/26 by Shaun.Kime
Current state of collision detection:
Collision is spotty, but seems to work. Will often get a crash in\Engine\Plugins\FX\Niagara\Source\Niagara\Private\NiagaraEmitterInstance.cpp(905) with an invalid Index value, leading the counts to be off.
Get a crash in MovePush_Pusher in writing an integer.
#!rb none
#!tests n/a
Change 3409340 on 2017/04/26 by Shaun.Kime
Working on getting events back up and running. This represents a stable loading path as well s sample assets that don't yet work.
#!rb none
#!tests n/a
Change 3409271 on 2017/04/26 by Simon.Tovey
Changed data set iterators to be more explicitly accessors that can read at any index.
Implemented replacement template iterator on top of these to so we can avoid modifying all existing uses of the iterator classes.
#!rb none
#!tests simulation and rendering work.
#!codereview Olaf.Piesche, Shaun.Kime, Frank.Fella
Change 3409205 on 2017/04/26 by Andrew.Grant
Removed accidentally added NetLog messages
#!tests #!rb none
Change 3409191 on 2017/04/26 by Simon.Tovey
Modified dataset layout and updated hlsl generation.
Now keeping float and int data separate as it's simpler and will be better for feeding GPU.
#!rb none
#!tests sims still work
#!codereview Olaf.Piesche, Shaun.Kime, Frank.Fella
Change 3408858 on 2017/04/25 by Jeff.Williams
Initial branch of files from Release-39.4 (//Orion/Release-39.4) to Release-39.5 (//Orion/Release-39.5)
Change 3408617 on 2017/04/25 by Olaf.Piesche
Bit of cleanup and a few small fixes
#!rb none
#!tests none
Change 3408425 on 2017/04/25 by Olaf.Piesche
Niagara plugin side implementation of shader compiling manager; various bug fixes to the translator and shader code
This should make the process of generating HLSL from a Niagara script, compiling it to a compute shader, sticking it in a shader map, as well as serializing to and from DDC, work.
Probably has various small residual problems that we'll shake out over the next few days.
#!codereview simon.tovey
#!codereview frank.fella
#!codereview shaun.kime
#!rb none
#!tests compiled Shaun's test Niagara rebuild of Hyperbreach's grenade explosion
Change 3408154 on 2017/04/25 by Ben.Salem
Extend timeout on skill test as more characters come online.
#!rb none
#!tests compiled
Change 3408077 on 2017/04/25 by Ben.Salem
Adding a nightly Skill Change report node to pick up all ability changes that may have intentionally and unintentionally cropped up the night before for use in maintaining automated tests and maybe eventually for helping out QA.
#!rb Brad.Angelcyk, Clayton.Langford
#!tests Generated a few reports.
Change 3407912 on 2017/04/25 by Shaun.Kime
Fixing crash bug when using multiple renderers for an emitter.
Adding in example.
#!rb none
#!tests created example
Change 3407873 on 2017/04/25 by Shaun.Kime
NormalizedAge is now what we previously referred to as Age.
Age is also output, but it is in seconds.
Modifed the Renderers to go through their Properties objects for GetRequiredAttributes. This allows us to make it a compile error if the script doesn't have the attributes required by the renderer.
#!rb none
#!tests updated all checked in assets
#!lockdown Andrew.Bains
Change 3407661 on 2017/04/25 by Rob.Cannaday
Libwebsocket logging from Fortnite CLs 3377318, 3380860
#!rb james.hopkin
#!tests mms matchmaking beginning
Change 3407657 on 2017/04/25 by Rob.Cannaday
libwebsocket updates from Fortnite CL 3380852
Includes client crash fix, increased log verbosity, and removes x64 libwebsockets directory.
#!rb james.hopkin
#!tests mms matchmaking beginning
Change 3407596 on 2017/04/25 by Laurent.Delayen
Added hooks in AnimBlueprintCompiler to perform Post Compile Validation in an AnimInstance subclass.
Also added virtual function to opt in for warnings when nodes are not using Fast Path.
#!codereview michael.noland, james.golding, thomas.sarkanen
#!rb thomas.sarkanen
#!tests Orion HeroAnimInstance
Change 3407480 on 2017/04/25 by Jon.Lietz
fixing logic error that would still use the FName even once a tag was defined, check to see if we have a tag first and if not THEN use the FName
#!rb none
#!tests apply a GE that has a FName and Tag SetByCaller defined
Change 3407385 on 2017/04/25 by Laurent.Delayen
If an AnimBP has warnings or errors, force opening Compiler Results Window, and recompile to display results.
#!codereview michael.noland, thomas.sarkanen
#!rb thomas.sarkanen
#!tests revernant's AnimBP in editor
Change 3407328 on 2017/04/25 by Andrew.Grant
Added comment to FTicker about DeltaTime arg
#!tests #!rb na
Change 3407325 on 2017/04/25 by Shaun.Kime
We now have moved the Material parameter onto the NiagaraRenderer objects.
There can now be multiple NiagaraRenderer objects per emitter. This has not been well tested.
There can now be multiple Event scripts per emitter. This has not been well tested.
#!rb none
#!tests converted default assets as well as the howitzer test asset
#!lockdown Andrew.Bains
Change 3407152 on 2017/04/25 by Andrew.Grant
Locked v39.3 builds to network version 3404004
#!tests #!rb na
#!ROBOMERGE: !39.4
Change 3406265 on 2017/04/24 by Gates.Aldridge
Updated Gem Trees and New Content.
For list of all Gem trees visit this link: https://docs.google.com/a/epicgames.com/spreadsheets/d/1UA0Tin_eQ-SQKR-4hFicN51S08MXbWCBYRW_dQ6VevU/edit?usp=sharing
#!tests PIE
#!codereview billy.rivers, colin.fogle
Change 3405946 on 2017/04/24 by Shaun.Kime
Rename/move file(s)
#!rb none
#!tests n/a
Change 3405914 on 2017/04/24 by Shaun.Kime
Refactoring due to renamings. Most functionality is back up, but additional renames have been requested that will occur in a later changelist.
#!rb none
#!tests opened exisiting emitters and made sure that they worked after recompile.
Change 3405760 on 2017/04/24 by Shaun.Kime
Moving shader file
#!rb none
#!tests n/a
Change 3405547 on 2017/04/24 by Shaun.Kime
Rename/move file(s)
#!rb none
#!tests n/a
Change 3405537 on 2017/04/24 by Shaun.Kime
Rename/move file(s)
#!rb none
#!tests n/a
Change 3405530 on 2017/04/24 by Shaun.Kime
Rename/move file(s)
#!rb none
#!tests n/a
Change 3405500 on 2017/04/24 by Shaun.Kime
DO NOT SYNC Further renamings
#!rb none
#!tests n/a
Change 3405473 on 2017/04/24 by Shaun.Kime
DO NOT SYNC Rename/move file(s) stage 1, physical file movement
#!rb none
#!tests n/a
Change 3404829 on 2017/04/22 by David.Ratti
#!rb #!tests missed file
Change 3404805 on 2017/04/22 by David.Ratti
Added FGameplayTagCreationWidgetHelper. This will add a 'create new gameplay tag' widget in whatever struct it is put in.
Added these to all of the keyword types. This makes it easier to add new keywords from within the keyword data table.
Minor changes to GameplayTagWidget to support auto expanded and default strings when creating new tags.
#!rb none
#!tests editor
#!codereview Jon.Lietz
Change 3404235 on 2017/04/21 by Shaun.Kime
Now updating the graph properly to match Module or Function depending on the state of the details panel.
#!rb none
#!tests n/a
Change 3404205 on 2017/04/21 by Wes.Hunt
Added PlaylistName to PlayerContextLocationPerMinute (empty if not in Match).
Other changes:
* FAnalyticsEventAttribute now uses Lex::ToString() to convert the key name.
* removed !PLATFORM_COMPILER_HAS_DEFAULTED_FUNCTIONS code.
* Added AppendAnalyticsEventAttributeArray to efficiently append to an existing array.
* Added a Lex::ToString conversion for EGenericAnalyticParam::Type
#!rb josh.markiewicz
#!tests build PC/PS4/Editor run solo match and check heartbeat values.
Change 3404059 on 2017/04/21 by Shaun.Kime
Adding back in the default pin for optional, exposed function inputs.
#!rb none
#!tests n/a
#!codereview simon.tovey
Change 3403939 on 2017/04/21 by Frank.Fella
Niagara - Loop fixes
+ Reset bursts on loop.
+ Fix off by 1 error when looping.
#!rb none
#!tests bursts now fire correctly every loop, and emitters now loop the number of times specified.
Change 3403935 on 2017/04/21 by Frank.Fella
Niagara - Make in editor sequencer time update code more correct and easier to follow
#!rb none
#!tests auto-loop only happens when playing now.
Change 3403899 on 2017/04/21 by Jon.Lietz
cook fix
#!rb none
#!tests compiles
#!codereview dave.ratti
Change 3403787 on 2017/04/21 by Ben.Salem
Increase timeout for FXTest node
#!rb none
#!tests none
Change 3403760 on 2017/04/21 by David.Ratti
Downgrade fatal to error temporarily (?)
#!rb #!tests cook
Change 3403452 on 2017/04/21 by Shaun.Kime
Tweaking some checks and getting rid of stale files.
#!rb none
#!tests n/a
Change 3403400 on 2017/04/21 by Shaun.Kime
Moving Niagara assets to the FX asset category
#!rb none
#!tests ran app and created asset types
#!codereview simon.tovey, frank.fella, olaf.piesche
Change 3403392 on 2017/04/21 by David.Ratti
Deprecated FOnGameplayAttributeChange delegate in favor of FOnGameplayAttributeValueChange which returns a structure for payload data. The structure is for better future proofing. The data that actually changed is that now the previous value of the attribute is included in the callback.
RegisterGameplayAttributeEvent is replaced with GetGameplayAttributeValueChangeDelegate. The former is now deprecated (4.17) but will still work.
(unrelated, also broke out function that gathers attribute uproperties to static func FGameplayAttribute::GetAllAttributeProperties [was previously embedded in details cust code])
#!rb Jon.Lietz
#!tests Pie, editor
#!codereview Billy.Bramer, Fred.Kimberley
Change 3403093 on 2017/04/20 by Shaun.Kime
You can now set default values for parameter map entries. These default values will be applied for the module if nothing overrides them from the outside.
#!rb none
#!tests ran all existing assets
Change 3403079 on 2017/04/20 by Andrew.Grant
Renamed OrionTestFramework to Gauntlet and moved under Engine automation (currenty NotForLicensees).
Updated namespaces and filenames to match new project name
Added RunFortTests with simple BootTest example (tested and verified this works).
#!tests ran locally, preflighted
#!rb none
#!gulp
Change 3402958 on 2017/04/20 by Shaun.Kime
Making standalone modules compile with data interfaces.
Fixing comments.
Updating test assets now that they compile in-place.
#!rb none
#!tests n/a
#!lockdown Andrew.Bains
Change 3402867 on 2017/04/20 by Paul.Moore
[MatchMaking]
- Fixed Lws wrapper detection of when a connection close is initiated by the client + other misc cleanup.
#!review-3402868
@tyler.cole
@rob.cannaday
#!rb none
#!tests matchmaking
Change 3402846 on 2017/04/20 by Shaun.Kime
Echoing the error message log so that it can be properly shown in the UI for HLSL translation.
#!rb none
#!tests n/a
Change 3402788 on 2017/04/20 by Laurent.Delayen
Click a Hyperlinked Asset in a log window will now attempt to open the editor for it.
#!rb michael.noland
#!tests new AnimBP validation warnings
Change from Dev-General. This is slightly different than the original change due to differences between release and dev-general. Dev-General version should be accepted in any merges.
Fixed clothing LODs seeming to get a bunch of energy on transitions. This was due to the current/target motion values used for inertia simulation not updating correctly leading the simulation to think it was moved a large amount in a single frame.
#!rb Martin.Wilson
#!jira OR-37697
#!tests PIE OrionEntry with 2 clients to check LOD transitions
[REVIEW] Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3401784 in //Orion/Release-39.3/... via CL 3401787 via CL 3402125
#!ROBOMERGE-BOT: ORION (Main -> Dev-Balance)
Change from Dev-General. This is slightly different than the original change due to differences between release and dev-general. Dev-General version should be accepted in any merges.
Fixed clothing LODs seeming to get a bunch of energy on transitions. This was due to the current/target motion values used for inertia simulation not updating correctly leading the simulation to think it was moved a large amount in a single frame.
#!rb Martin.Wilson
#!jira OR-37697
#!tests PIE OrionEntry with 2 clients to check LOD transitions
[REVIEW] Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3401784 in //Orion/Release-39.3/... via CL 3401787 via CL 3402125
#!ROBOMERGE-BOT: ORION (Main -> Dev-REGS)
Change from Dev-General. This is slightly different than the original change due to differences between release and dev-general. Dev-General version should be accepted in any merges.
Fixed clothing LODs seeming to get a bunch of energy on transitions. This was due to the current/target motion values used for inertia simulation not updating correctly leading the simulation to think it was moved a large amount in a single frame.
#!rb Martin.Wilson
#!jira OR-37697
#!tests PIE OrionEntry with 2 clients to check LOD transitions
[REVIEW] Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3401784 in //Orion/Release-39.3/... via CL 3401787 via CL 3402125
#!ROBOMERGE-BOT: ORION (Main -> Dev-UI)
Changed check to ensure for v39.3 release
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3400956 in //Orion/Release-39.3/... via CL 3400957 via CL 3401972
#!ROBOMERGE-BOT: ORION (Main -> Dev-Balance)
Changed check to ensure for v39.3 release
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3400956 in //Orion/Release-39.3/... via CL 3400957 via CL 3401972
#!ROBOMERGE-BOT: ORION (Main -> Dev-REGS)
Changed check to ensure for v39.3 release
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3400956 in //Orion/Release-39.3/... via CL 3400957 via CL 3401972
#!ROBOMERGE-BOT: ORION (Main -> Dev-UI)
Change 3402354 on 2017/04/20 by Shaun.Kime
Adding support for DataInterfaces to parameter maps.
#!rb none
#!tests opened all test files and recompiled
Change 3402350 on 2017/04/20 by Simon.Tovey
Removing some validation that vm compiler is failing currently to bypass issues for others.
#!test works
#!rb none
#!codereview Shaun.Kime
Change 3402233 on 2017/04/20 by Simon.Tovey
Bringing 3402222 from dev-render to dev-general
#!rb Marcus.Wassmer
#!tests Fixes issue on PS4
Change 3402213 on 2017/04/20 by Daniel.Lamb
Added support for using precompiled exe when running shared cooked builds.
Updated UI to support this feature.
#!rb Andrew.Grant, Ben.Marsh
#!test Shared cooked builds paragon
Change 3402153 on 2017/04/20 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb na
Change from Dev-General. This is slightly different than the original change due to differences between release and dev-general. Dev-General version should be accepted in any merges.
Fixed clothing LODs seeming to get a bunch of energy on transitions. This was due to the current/target motion values used for inertia simulation not updating correctly leading the simulation to think it was moved a large amount in a single frame.
#!rb Martin.Wilson
#!jira OR-37697
#!tests PIE OrionEntry with 2 clients to check LOD transitions
[REVIEW] Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3401784 in //Orion/Release-39.3/... via CL 3401787
#!ROBOMERGE-BOT: ORION (Release-39.4 -> Main)
Change 3402081 on 2017/04/20 by Andrew.Grant
Workaround for crash where FRepLayout items were being GC'd during (but before) the NetDriver shutdown. We now explicitly clear out the references in our Shutdown() call that occurs prior to being GC'd.
#!tests no longer crashing when returning to main menu after tutorial
#!rb na
#!review-3402082 @Ryan.Gerleve
Change 3402006 on 2017/04/20 by Olaf.Piesche
Fixing serialization problem; need to use FArchive custom version in Serialize, not the Linker's
#!codereview shaun.kime
#!codereview simon.tovey
#!rb daniel.lamb
#!tests loaded and saved problematic assets
Changed check to ensure for v39.3 release
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3400956 in //Orion/Release-39.3/... via CL 3400957
#!ROBOMERGE-BOT: ORION (Release-39.4 -> Main)
Change from Dev-General. This is slightly different than the original change due to differences between release and dev-general. Dev-General version should be accepted in any merges.
Fixed clothing LODs seeming to get a bunch of energy on transitions. This was due to the current/target motion values used for inertia simulation not updating correctly leading the simulation to think it was moved a large amount in a single frame.
#!rb Martin.Wilson
#!jira OR-37697
#!tests PIE OrionEntry with 2 clients to check LOD transitions
[REVIEW] Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3401784 in //Orion/Release-39.3/...
#!ROBOMERGE-BOT: ORION (Release-39.3 -> Release-39.4)
Change 3401784 on 2017/04/20 by Benn.Gallagher
Duplicating change from Dev-General. This is slightly different than the original change due to differences between release and dev-general. Dev-General version should be accepted in any merges.
Fixed clothing LODs seeming to get a bunch of energy on transitions. This was due to the current/target motion values used for inertia simulation not updating correctly leading the simulation to think it was moved a large amount in a single frame.
#!rb Martin.Wilson
#!jira OR-37697
#!tests PIE OrionEntry with 2 clients to check LOD transitions
#!review Andrew.Grant
Changed check to ensure for v39.3 release
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3400956 in //Orion/Release-39.3/...
#!ROBOMERGE-BOT: ORION (Release-39.3 -> Release-39.4)
Change 3400956 on 2017/04/19 by Andrew.Grant
Changed check to ensure for v39.3 release
#!ROBOMERGE: !39.4
#!tests #!rb none
Change 3400938 on 2017/04/19 by Andrew.Grant
FDelegateBase destructor now implicitly results in Unbinding.
Removed now-unnecessary Unbind calls from MulticastDelegate and commented the one valid case
#!tests soaked Orion during memory leak tests
#!rb none
#!review-3400939 steve.robb
Change 3400853 on 2017/04/19 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb none
Change 3400613 on 2017/04/19 by Olaf.Piesche
Code chunks know whether they're terminated (with ;) so we can have unterminated lines in the generated hlsl (opening and closing scopes in if/else, for example)
#!rb shaun.kime
#!tests compiled script with if node
Change 3400296 on 2017/04/19 by Rob.Cannaday
Specify tlog endpoint by using the backend name (e.g,. tencentdev)
Supported: tencentdev, tencentqa, tencentlive, tencentff
#!tencent
#!orion
#!tlog
#!rb none
#!tests tlog initialization
Change 3400197 on 2017/04/19 by Shaun.Kime
Fixing uninitialized variable preventing data interfaces from properly adding to data table.
#!rb none
#!tests n/a
#!codereview Olaf.Piesche, Simon.Tovey
Changes from Dev-Rendering
#!tests preflighted
#!rb Marcus.Wasmer
#!ROBOMERGE-SOURCE: CL 3397593 in //Orion/Release-39.3/... via CL 3397598
#!ROBOMERGE-BOT: ORION (Main -> Dev-Balance)
Changes from Dev-Rendering
#!tests preflighted
#!rb Marcus.Wasmer
#!ROBOMERGE-SOURCE: CL 3397593 in //Orion/Release-39.3/... via CL 3397598
#!ROBOMERGE-BOT: ORION (Main -> Dev-REGS)
Changes from Dev-Rendering
#!tests preflighted
#!rb Marcus.Wasmer
#!ROBOMERGE-SOURCE: CL 3397593 in //Orion/Release-39.3/... via CL 3397598
#!ROBOMERGE-BOT: ORION (Main -> Dev-UI)
Change 3399720 on 2017/04/19 by Andrew.Grant
Merging applocal deployment of Xuadio/ Xinput from //UE4/Dev-Core/... @ 3386262
#!tests #!rb na
Change 3399667 on 2017/04/19 by Andrew.Grant
Duplicating 3398085 from Dev-Rendering:
Removed Aftermath hearbeat check as it internally uses the deviceConext which is not threadsafe
#!jira UE-42280
#!RB Marcus.Wassmer
#!tests none
Change 3399658 on 2017/04/19 by Simon.Tovey
Changes that remove some erroneous usage of hlslcc ir list nodes.
Required for upcoming removal of some code which masked these errors in hlslcc.
#!rb none
#!tests Everything worked in cleanup brach. Pulled over from there.
#!codereview Olaf.Piesche
Change 3399633 on 2017/04/19 by Shaun.Kime
Fixing issue where we were trying to HLSL convert an effect script.
#!rb none
#!tests n/a
#!codereview olaf.piesche
Change 3399577 on 2017/04/19 by Shaun.Kime
Updating default content
Change 3399393 on 2017/04/19 by Shaun.Kime
Merging spawn/update/event graphs into one.
#!rb none
#!tests n/a
#!codereview frank.fella, simon.tovey, olaf.piesche
Change 3399101 on 2017/04/19 by Jeff.Williams
Merging //Orion/Main to Release-39.4 (//Orion/Release-39.4) @3398765
#!rb none
#!tests none
Change 3399084 on 2017/04/19 by Jeff.Williams
Initial branch of files from Release-39.3 (//Orion/Release-39.3) to Release-39.4 (//Orion/Release-39.4)
Change 3398550 on 2017/04/18 by Olaf.Piesche
Fixes for post-compile data interface tables on scripts; removing unnecessary stuff from the compilaiton output that was move to the translator
#!tests ran and compiled hyperbreach grenade explosion
#!rb shaun.kime
Change 3398413 on 2017/04/18 by Shaun.Kime
Removing duplicate compiler definition
#!rb none
#!tests n/a
Change 3398395 on 2017/04/18 by Olaf.Piesche
Missing NiagaraShader module build file.
#!rb shaun.kime
#!tests none
Change 3398350 on 2017/04/18 by Alexis.Matte
Avoid matching the material slot name when resetting the material on reimport
#!rb none
#!jira UE-42755
#!test run the fbx automation test
Change 3398337 on 2017/04/18 by Olaf.Piesche
Niagara compute shader compilation and storage infrastructure; shader maps, serialization, DDC save and load, split of compilation and HLSL translation, kicking off of shader compiler jobs to the workers, and a whole bunch of supporting code;
still missing and up next: applying successful shader compile job results to the corresponding niagara script (up next).
Nothing *should* change from a user perspective, CPU compilation and simulation *should* still work as previously.
#!rb shaun.kime
#!tests built a simple emitter with function calls, made sure it compiled and ran
Change 3398248 on 2017/04/18 by Andrew.Grant
Merging RepLayout fix from Fortnite
#!tests short solo game
#!rb Ryan.Gerleve
Change 3398152 on 2017/04/18 by Andrew.Grant
Actually enabling Aftermath... :(
#!tests compiled and verified NV_AFTERMATH is set
#!rb none
Change 3398133 on 2017/04/18 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb none
Change 3397942 on 2017/04/18 by Benn.Gallagher
Fixed clothing LODs seeming to get a bunch of energy on transitions. This was due to the current/target motion values used for inertia simulation not updating correctly leading the simulation to think it was moved a large amount in a single frame.
#!rb Martin.Wilson
#!jira OR-37697
#!tests PIE OrionEntry with 2 clients to check LOD transitions
Change 3397885 on 2017/04/18 by Daniel.Lamb
Remove duplicate addition of package name. Fixes crash when iterative cooking.
#!rb Trivial
#!test iterative cook paragon.
Change 3397778 on 2017/04/18 by Daniel.Lamb
Added mountpoint to the information which is dumped for pak files.
#!rb trivial
#!test Unrealpak -list
Change 3397777 on 2017/04/18 by Daniel.Lamb
Added stats to network platform file and network server.
#!rb Andrew.Grant
#!test Paragon cook on the fly.
Change 3397776 on 2017/04/18 by Daniel.Lamb
Added suppport for multiple shared cooked build paths.
Added additional paths to the paragon shared cooked build search paths.
Shared cooked builds use editor server instead of cooked server (tiny bit slower but improves iteration time and reduces build machine load).
#!rb Andrew.Grant
#!test Shared cooked build paragon
Change 3397775 on 2017/04/18 by Daniel.Lamb
Split up TickCookOnTheSide into 3 functions (still more work to be done).
Added function to save cooked packages during low cpu usage time in the editor when using cook on the side, not enabled by default.
Added profiling for network cooking requests.
Added dump of stats for cooker to exec commandline.
Fixed issue with cook on the fly sending back unsolicited files which might not be done.
Fixed issue with cook by the book not recooking packages found as dirty.
Fixed issue with cook on the fly not resending ubulk and uexp packages to ps4.
Make sure ubulk and uexp packages are cleaned up with the original uasset / umap package.
#!rb Andrew.Grant
#!test Cook by the book paragon, cook on the side paragon.
Change 3397759 on 2017/04/18 by Andrew.Grant
Removed ensures that were hampering QA
#!tests compiled
#!rb none
#!review-3397760 Benn.Gallagher
Changes from Dev-Rendering
#!tests preflighted
#!rb Marcus.Wasmer
#!ROBOMERGE-SOURCE: CL 3397593 in //Orion/Release-39.3/...
#!ROBOMERGE-BOT: ORION (Release-39.3 -> Main)
Change 3397593 on 2017/04/18 by Andrew.Grant
Merging Aftermath changes from Dev-Rendering
#!tests preflighted
#!rb Marcus.Wasmer
Change 3397167 on 2017/04/17 by Andrew.Grant
Fix for multicast delegate where delegate handles to shared-ref objects that been collected were not being deleted
#!tests verified Orion leak is gone
#!rb sent to Core-Team
Change 3397165 on 2017/04/17 by Andrew.Grant
Back out revision 4 from //Orion/Release-39.3/Engine/Source/Runtime/Core/Public/Delegates/MulticastDelegateBase.h
#!tests #!rb none
Change 3397163 on 2017/04/17 by Andrew.Grant
Fixed issue where shared-ref objects in multicast delegate that had been nulled were never being deleted
#!tests verified orion lean is gone
#!rb sent to Core-Team
Change 3397152 on 2017/04/17 by Andrew.Grant
Alternate fix for leaky PhysX data
#!tests compiled
#!rb none
Change 3397135 on 2017/04/17 by Andrew.Grant
Compile fix for editor build
#!tests compiled WIn64 editor
#!rb none
Change 3397090 on 2017/04/17 by Andrew.Grant
Fix for DerivedPhysXData not being freed in UBody Setup
#!tests soaked
#!rb none
Change 3396548 on 2017/04/17 by Laurent.Delayen
OR-37726 Fix for array changing during Ranged-Loop iteration.
#!rb none
#!tests none
Change 3396271 on 2017/04/17 by Rob.Cannaday
Use [HTTP]HttpMaxConnectionsPerServer in CurlHttp
Move call to FPlatformHttp::Init() to after config values are read
Related to CL 3368228
#!UE4 #!http #!curl
#!rb ian.fox
#!tests Dedicated Server startup
Change 3396247 on 2017/04/17 by Max.Chen
Copy from Release-4.16
Fixed crash saving sequencer sublevels due to relying in initialization of UWorld::Scene that is not guaranteed
#!rb Martin.Wilson, Benn.Gallagher
#!jira UE-43903
#!tests none
Change 3396132 on 2017/04/17 by Frank.Fella
Niagara - Fix copy/paste error in comment.
#!rb none
#!tests none
Change 3396089 on 2017/04/17 by Jon.Lietz
- adding in support for SetByCaller Gameplay Effects to be trag driven, Making DataName VisibleDefaultsOnly, adding in DataTag EditDefaultsOnly limited to SetByCaller tag category
- getting Triggered event abilities working, added in a new OrionAbility for cards that will allow us to auto change activation group from replacable to default when it is going to be triggered from an event
#!rb none
#!tests box map
#!codereview Dave.Ratti Billy.Bramer Fred.Kimberley
*There is a bit of code clean up to happen but this is a good stopping point and the CL is getting bigger and any other work will cause the CL harder and harder to track
Change 3395801 on 2017/04/17 by Frank.Fella
Sequencer - Guard against the ed mode being null for non-level sequencers.
#!rb none
#!tests no longer crashes when changing actor selection with the niagara editor open.
Change 3395769 on 2017/04/17 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb na
Change 3395735 on 2017/04/17 by Rob.Cannaday
Fix curl attempting to use invalid address for requests
Only specify the address to use if MULTIHOME is specified on the command line
#!rb rob.cannaday
#!tests dedicated server startup
#!jria TEN-130
Change 3394964 on 2017/04/14 by Andrew.Grant
- Fixed RemoveAll not removing entries from MulticastDelegate
- Ensures compact is eventually called for infrequently/never Broadcast() delegages during an Add() (fixes leak in SafeZone delegates)
#!tests soaked orion
#!rb email-list
Change 3394945 on 2017/04/14 by Andrew.Grant
Fix for memory leak in FRepLayout from Ryan.Gerleve
#!tests soaked orion
#!rb Ryan.Gerleve
Change 3394929 on 2017/04/14 by Andrew.Grant
Added destructor to SafeZone to ensure delegates are freed immediately
#!tests soaked
#!rb none
Change 3394195 on 2017/04/14 by Andrew.Grant
Fix for mem reporting crash
#!tests none
#!rb Marcus.Wassmer
Change 3393355 on 2017/04/13 by Shaun.Kime
Modified traversals to be recorded depth first, making it a clear input to output linear sequence.
Also commented the Parameter Map History class header.
#!rb none
#!tests n/a
Change 3393350 on 2017/04/13 by Andrew.Grant
Merging 3371638 from Release-39 for improved cloth perf
#!tests #!rb na
Change 3393349 on 2017/04/13 by Shaun.Kime
Fix issue where 'listtextures' from the console causes a crash due to not properly checking against a valid EffectInstance.
#!rb none
#!tests n/a
Change 3393342 on 2017/04/13 by Andrew.Grant
Merging 3367375 from Release-39 for cloth perf
#!tests #!rb na
Change 3393335 on 2017/04/13 by Andrew.Grant
Merging cloth improvements pt1 from 3363203
#!tests #!rb na
Change 3393185 on 2017/04/13 by Mieszko.Zielinski
Fixed in order to prevent GameplayTask crashes when exiting the engine #!UE4
#!rb Lukasz.Furman
#!test golden path
#!jira OR-37658
#!ROBOMERGE: 39.3, MAIN, DG
#!lockdown Andrew.Grant
Change 3393134 on 2017/04/13 by Laurent.Delayen
Added 'ShouldRemainVertical' to encapsulate when DesiredRotation should be restricted to Yaw only in PhysicsRotation.
#!rb none
#!codereview zak.middleton
#!tests wukong's air walking ability.
Change 3393059 on 2017/04/13 by Frank.Fella
Sequencer - Prevent a crash when trying to draw tick marks for impossible view ranges.
#!codereview Max.Chen,Andrew.Rodham
#!rb none
#!tests no longer furiously consumes memory with ludicrous view ranges
Change 3392910 on 2017/04/13 by Rob.Cannaday
Remove reference to DerivedDataCache in Sockets module - no longer needed to be there
#!rb josh.markiewicz
#!tests compile DebugGame Editor Win64
Change 3392890 on 2017/04/13 by Ben.Marsh
UGS: Merging config settings to exclude changes matching certain patterns.
#!rb none
Change 3392875 on 2017/04/13 by Shaun.Kime
Moving NiagaraGraph into its own cpp
#!rb none
#!tests n/a
Change 3392867 on 2017/04/13 by Shaun.Kime
Moving the parameter map history out into its own header/cpp
#!rb none
#!tests n/a
Change 3392702 on 2017/04/13 by Shaun.Kime
Making sure that alias fixups are an exact match and do not impact the final varible name
#!rb none
#!tests n/a
Change 3392701 on 2017/04/13 by Shaun.Kime
Removing stale comment
#!rb none
#!tests n/a
Change 3392650 on 2017/04/13 by Simon.Tovey
? Moved the vertex color filtering to a shared storage referenced by the instance data
#!rb Shaun.Kime
#!tests Editor Win64
Change 3392305 on 2017/04/13 by Shaun.Kime
Making it possible to set aliases to op nodes. This allows parity for things like multiply as * or divide as / that exists in Materials.
#!rb simon.tovey
#!tests n/a
Change 3391887 on 2017/04/13 by Andrew.Grant
Integration from Main
#!tests #!rb none
Change 3391876 on 2017/04/13 by Andrew.Grant
Memory leak fix in Slate - Multicast delegates are not clearing invocation list on Add....
#!tests cycled game
#!rb none
Change 3391864 on 2017/04/13 by Andrew.Grant
Added ini setting that can be used to increase networking timeout values in unoptimized builds to avoid resorting to -notimeouts or editing ini files.
#!tests verified timeouts are increased with UE4Editor game/server
#!rb none
--
@review Josh.Markiewicz
Change 3391841 on 2017/04/13 by Andrew.Grant
Fix for linux compile error
#!tests #!rb none
Change 3391811 on 2017/04/12 by Andrew.Grant
Memory Leak Fixes
#!tests soaked PS4 client
#!rb various
Change 3391388 on 2017/04/12 by Rob.Cannaday
#!UE4 - made libcurl respect the MULTIHOME param that already exists in the engine
- allows libcurl to switch NICs
#!rb rob.cannaday
#!codereview rob.cannaday
#!tests Win64 DebugGame Editor dedicated server startup, successful http request
Written by Josh.Markiewicz
Change 3390998 on 2017/04/12 by Shaun.Kime
Parameter maps now compile, but you cannot set their default values yet, nor wire the defaults with anything other than a ParameterMapSet node.
#!codereview simon.tovey
#!rb none
#!TESTS n/a
Change 3389691 on 2017/04/11 by Jeff.Williams
Copying //Orion/Main to Release-39.3 (//Orion/Release-39.3) @3389406
#!rb none
#!tests none
Change 3389226 on 2017/04/11 by Rob.Cannaday
Handle missing PluginSettings.ini
#!rb trivial
#!tests dlc pak for RegionCN
Change 3388873 on 2017/04/11 by Laurent.Delayen
Integrated CL #!3388506 from Main
Delay clearing of MontageInstances and triggering 'OnAllMontageInstancesEnded' until all Montage Events have been dispatched.
Also fix SkelMeshComponent ticking on dedicated servers when rejoining in progress.
Fixes https://jira.it.epicgames.net/browse/OR-37565
#!rb martin.wilson, lina.halper, jon.lietz
#!tests Grux E, gadget rejoin
Change 3388761 on 2017/04/11 by Rob.Cannaday
Build changes to specify additional content files for dedicated servers only
#!rb daniel.lamb
#!tests RunUAT BuildCookRun for OrionGame, and separately for RegionCN plugin as DLC
Change 3388749 on 2017/04/11 by Frank.Fella
Niagara - In-editor timeline changes, various timing fixes, and burst key fixes.
+ Set the playback range and working area in the sequencer timeline to 1000s so that infinite effects behave better. This still needs some work, but I think the new experience is better than what it was doing before.
+ Loop non-infinite effects when the last particle dies or when the last emitter ends, whichever comes last.
+ Reset desired age when resetting the effect so that looping works correctly in the editor without visual popping.
+ Make the tick state inclusive at 0 so that the system is running on the first frame.
+ Rebuild the burst instances in the simulation when it's reset, rather than in reinit so that each time the simulation is reset the bursts are random.
+ Reset the spawn remainder to 0 when resetting. This helps to avoid visual popping on reset.
+ Fix a bug in tick where the simulation was never being set to dead because the current number of particles wasn't being updated.
+ When checking burst keys, include the current age when comparing so that bursts at time 0 evaluate properly.
#!codereview Olaf.Piesche,Simon.Tovey,Shaun.Kime
#!rb none
#!tests Effects loop when the last particle dies, and bursts on the first keyframe work and are random each play
Change 3388506 on 2017/04/11 by Laurent.Delayen
Delay clearing of MontageInstances and triggering 'OnAllMontageInstancesEnded' until all Montage Events have been dispatched.
Also fix SkelMeshComponent ticking on dedicated servers when rejoining in progress.
Fixes https://jira.it.epicgames.net/browse/OR-37565
#!rb martin.wilson, lina.halper, jon.lietz
#!tests Grux E, gadget rejoin
Change 3387648 on 2017/04/10 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb na
Change 3387628 on 2017/04/10 by Jeff.Williams
Initial branch of files from Release-39.2 (//Orion/Release-39.2) to Release-39.3 (//Orion/Release-39.3)
Change 3386546 on 2017/04/10 by Alexis.Matte
Fix the material reset workflow, prevent a bad reordering of the material array when using the skinxx workflow
#!rb none
#!test none
Change 3386311 on 2017/04/10 by Jason.Bestimt
#!ORION_MAIN - Manual Merge of CL 3386053 from 39.2
#!RB:none
#!Tests:none
#!CodeReview: andrew.grant, jeff.williams
Change 3386036 on 2017/04/10 by Daniel.Lamb
Fixed issue with network paltform file looking in incorrect location when using cook in editor.
#!rb None
#!test Paragon cook on the fly in editor.
Change 3386035 on 2017/04/10 by Daniel.Lamb
Stopped inifinite recursion in the case where base path is set incorrectly.
#!rb None
#!test Cook on the fly paragon no base path.
Change 3386021 on 2017/04/10 by Daniel.Lamb
Merging CL 3372508
from //UE4/Main/Engine/Source/Runtime/CoreUObject/Private/Serialization/AsyncLoading.cpp
to //Orion/Dev-General/Engine/Source/Runtime/CoreUObject/Private/Serialization/AsyncLoading.cpp
AsyncLoading - Adding USoundBase to the set of CDOs that have a particular fixed boot order, otherwise strange load orders can be triggered where the USoundWave CDO can be initialized while the USoundBase CDO is mid inititialization. Originally discovered in Dev-Editor, fixed in 3370466.
#!rb Trivial
#!test Paragon cook
Change 3386018 on 2017/04/10 by Daniel.Lamb
Made copy of shared cooked build async.
#!rb Trivial
#!test Shared cooked build paragon
Change 3385949 on 2017/04/10 by Alexis.Matte
Add "Reset Material Slot" fbx option active only when doing a re-import
#!rb Matt.kuhlenschmidt
#!test none
Change 3385945 on 2017/04/10 by Simon.Tovey
? Moving per instance data for data interfaces out to their own struct so we don't have to duplicate the interface itself all the time.
? For the moment, disabling the vertex color filtering until I can tweak the implementation a bit.
? Added a reinit context helper for re initialising niagara components when you modify emitters or data interface properties etc.
Still some testing and tidying up to do but should be 99% complete.
#!rb Shaun.Kime
#!test Tested the functionality of static mesh interface in the editor
Change 3385507 on 2017/04/07 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb na
Changed, duplicated UMG editor fix from //UE4/Main
#!tests compiled
#!rb NickD
#!ROBOMERGE-SOURCE: CL 3383414 in //Orion/Release-39/... via CL 3383880
#!ROBOMERGE-BOT: ORION (Release-39.1 -> Release-39.2)
Change 3385407 on 2017/04/07 by Andrew.Grant
Fix memory leak in landscape collision due to outstanding reference count
#!tests Ran Orion, memory leak seems gone
#!rb none
#!review-3385408 Thomas.Sarkanen
Change 3385399 on 2017/04/07 by Andrew.Grant
Fix for memory leak in EDL
#!tests memory leaks vanished!
#!rb none
Change 3385137 on 2017/04/07 by Andrew.Grant
Fix for decal issue
#!jira OR-37359
#!tests none
#!rb Arne.Schober
Change 3384414 on 2017/04/07 by Benn.Gallagher
Fixed crash switching Grux skins in frontend. Issue arises when switching to a new skin that has more clothing elements than the first mesh. Undid the workaround previously applied to stop the crash.
#!rb Martin.Wilson
#!tests PIE frontend and -game frontend. Also animation tools that reproduced the crash
#!jira OR-36671
Changed, duplicated UMG editor fix from //UE4/Main
#!tests compiled
#!rb NickD
#!ROBOMERGE-SOURCE: CL 3383414 in //Orion/Release-39/...
#!ROBOMERGE-BOT: ORION (Release-39 -> Release-39.1)
Change 3383414 on 2017/04/06 by Andrew.Grant
non-shipping changed, duplicated UMG editor fix from //UE4/Main
#!tests compiled
#!rb NickD
Change 3383318 on 2017/04/06 by Laurent.Delayen
Delay dispatching of AnimEvents (Notifies and Montage Events) until after we receive an updated animation pose (if applicable).
This fixes AnimNotifies playing particle effects using a socket location using last frame's pose. Now they use the current frame's pose.
#!rb martin.wilson
#!codereview lina.halper
#!tests Revenant primary fire spawning muzzle flash at correct location
Change 3383123 on 2017/04/06 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb na
Change 3382781 on 2017/04/06 by Andrew.Grant
Made pak signing issues non-fatal
#!tests #!rb na
Change 3382670 on 2017/04/06 by David.Ratti
Continued event/qualifier/stat work
-Added concept of supported and required qualifier contexts so that system can know which qualifiers/stat gathers can work with what events/stats.
-Added details customization support for gameplay tags so that this type of filtering can be done by owned structs dynamically
-Some general refactoring of keywords
#!rb #!tests none
#!codereview Jon.Lietz
Change 3381646 on 2017/04/05 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb na
Change 3381483 on 2017/04/05 by Lina.Halper
#!DUPEFIX: Merging using AnimPhys-Orion-DevGeneral
Fix crash on creating montage and setting slot node
#!jira: UE-43698
#!rb: Ori.Cohen
Change 3381435 on 2017/04/05 by Frank.Fella
SDetailsView - Prevent a crash when a customization tries to use a layout builder which has been destroyed.
Change 3381019 on 2017/04/05 by Frank.Fella
Niagara - Fix the default assets which broke when moving the content.
Change 3380701 on 2017/04/05 by Daniel.Lamb
Stopped splash screen showing over the top of message boxes if you get a message before the game loads.
#!rb Luke.Thatcher
#!test Run paragon ps4 crash on startup
#!jira UE-43209
Change 3380293 on 2017/04/05 by Jeff.Williams
Copying //Orion/Main to Release-39.2 (//Orion/Release-39.2) @3380245
Change 3380165 on 2017/04/04 by Frank.Fella
Niagara - Move niagara engine content into the niagara plugin.
Change 3380151 on 2017/04/04 by Frank.Fella
Niagara - Fixes for code moved into the plugin.
Change 3380117 on 2017/04/04 by Andrew.Grant
Locking network version to 3375394 for v39 patch
#!ROBOMERGE: !39.1
Change 3380092 on 2017/04/04 by Andrew.Grant
Streaming requests are now honored even when a null-item is specified in the list
#!tests Verified Grux master skin loads correctly.
#!rb Ben.Ziegler
#!jira OR-37406, OR-37404
#!ROBOMERGE: 39
Change 3380052 on 2017/04/04 by Frank.Fella
Niagara - Move vertex factories to the correct plugin folders.
Change 3380029 on 2017/04/04 by Frank.Fella
Niagara - Move vertex factory code to the plugins directory.
Change 3380025 on 2017/04/04 by Frank.Fella
Niagara - Move runtime code to the plugins directory.
Change 3380024 on 2017/04/04 by Frank.Fella
Niagara - Move editor code to the plugins directory.
Change 3379115 on 2017/04/04 by David.Ratti
redo minor fix for engine ability system that was lose in a rollback
#!rb #!tests none
Change 3378590 on 2017/04/04 by Jurre.deBaare
Mesh painting tools not working
#!fix required a direct loadmodule call
#!rb trivial
Change 3378406 on 2017/04/04 by Shaun.Kime
Making the name of the node shorter
Change 3378357 on 2017/04/04 by Shaun.Kime
Adding basic UI support for Parameter Maps. Currently does not compile if you place these nodes.
Change 3377549 on 2017/04/03 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb none
Change 3377457 on 2017/04/03 by Jeff.Williams
Initial branch of files from Release-39.1 (//Orion/Release-39.1) to Release-39.2 (//Orion/Release-39.2)
Change 3377394 on 2017/04/03 by Olaf.Piesche
Removing mesh renderer material relevance determination for now; unsafe and needs to be re-worked anyway
#!codereview shaun.kime
Change 3376222 on 2017/04/03 by Jack.Porter
Prevent landscape crash due to thumbnail hitproxy renderer
#!jira OR-37325
#!rb None
#!codereview: andrew.grant
Change 3375394 on 2017/03/31 by Marcus.Wassmer
Bump script version to force new pub tools
Change 3375342 on 2017/03/31 by Daniel.Lamb
Added some more blacklist files to the cook ini settings configs
#!rb Trivial
#!test fastcook iterative paragon.
Change 3375213 on 2017/03/31 by Shaun.Kime
Adding Promote to Parameter pin action
Change 3375038 on 2017/03/31 by Olaf.Piesche
First basics for Niagara GPU simulation.
- Compiling for PC_D3D11 everytime we do a script compile, so we can start catching problems with hlsl gen;
- adding GPU side reps for data buffers;
- stub class for a simulation batcher;
- added a compute execution context to separate the two script execution modes
- GPU execution is queued in ScriptExecutionContext's execute function; may want to queue CPU executiuon here too
- additional bits and pieces.
- turning Niagara on by default for our stream
Some of this will change once shader management infrastructure is in place (our own shader map with proper storage and FShader derived shader classes, next up)
Change 3374733 on 2017/03/31 by Jason.Bestimt
#!ORION_TENCENT - Merge Beetle Grux crash fix from CL 3367820
#!RB:none
#!Tests:none
#!CodeReview: andrew.grant, benjamin.crocker
#!QAReview
Change 3374293 on 2017/03/31 by Alexis.Matte
Fix copy paste of material array
#!rb none
#!test none
Change 3374226 on 2017/03/31 by Shaun.Kime
Making it so that scripts work properly when version numbers change.
Turns out that doing the refresh in PostLoad is a Bad Idea (TM) and we need to be careful in how we do the deep copy.
Change 3373809 on 2017/03/30 by Rob.Cannaday
Fix inability to send chat using PS4 OSK
#!codereview James.Longstreet, ian.fox
#!jira OR-37160
#!lockdown andrew.grant
Change 3373676 on 2017/03/30 by Andrew.Grant
Merge of cloth changes from Release-39
#!review-3373677 @Benn.Gallagher
#!tests compiled
#!rb none
Change 3373262 on 2017/03/30 by Josh.Markiewicz
#!UE4 - more logging for perf counters to check for watchdog sync issues
#!codereview sam.zamani, david.nikdel
#!rb rob.cannaday
Change 3373002 on 2017/03/30 by Josh.Markiewicz
#!UE4 - more logging for perf counters to check for watchdog sync issues
#!codereview sam.zamani, david.nikdel
#!rb rob.cannaday
Change 3372731 on 2017/03/30 by Marcus.Wassmer
Fix Niagara shader compile issue.
#!rb none
#!tests none
Change 3372113 on 2017/03/30 by Andrew.Grant
Merging //Orion/Dev-General to Dev-Niagara (//Orion/Dev-Niagara)
#!rb #!tests na
Change 3372109 on 2017/03/30 by Daniel.Lamb
Fix issue where the editor doesn't update all windows after rendertarget texture is converted to Texture2D
#!rb Trivial
#!test Paragon editor
Change 3371797 on 2017/03/30 by Jeff.Williams
Merging //Orion/Main to Dev-Balance (//Orion/Dev-Balance) @3368008
Change 3371638 on 2017/03/30 by Benn.Gallagher
Fixes to stability due to component space being the simulation space, games like Paragon treat the mesh and component transforms differently and cause issues with added energy in the system.
#!jira OR-36927
#!rb Martin.Wilson
#!tests PIE Entry+Monolith. Cooked Monolith PS4 nomcp
#!review @andrew.grant
Change 3371635 on 2017/03/30 by Andrew.Grant
Merging //UE4/Main @ 3365166
#!tests QA pass, preflighted
#!rb na
Change 3371566 on 2017/03/30 by Jurre.deBaare
All PC clients crash when Ice uses RMB - Assertion failed: bCachedMaterialParameterIndicesAreDirty == false
#!fix also removed other check, total brainfart moment
#!codereview Lina.Halper
#!jira OR-37269
#!lockdown Andrew.Grant
Change 3371404 on 2017/03/30 by Martin.Wilson
Speculative fix for unreproducable crash on loading animations
#!jira OR-37157
#!rb Benn.Gallagher
Change 3370987 on 2017/03/29 by Andrew.Grant
Merging //Orion/Main to Dev-UI (//Orion/Dev-UI)
#!rb na
Change 3370949 on 2017/03/29 by Andrew.Grant
Painless merge of files from //Orion/Main to Dev-UI (//Orion/Dev-UI)
#!tests compiled Win64 Editor & PS4 Test Client, Ran solo game, half-cooked a build
#!rb none
Change 3369730 on 2017/03/29 by Daniel.Lamb
Fixed crash in staging when the deepfiles directory doesn't exist by the time we need to create the meta for the deep files.
#!rb None
#!test stage paragon
Change 3369724 on 2017/03/29 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb none
Change 3369329 on 2017/03/29 by Jurre.deBaare
The Fey doll looks offset on Mambos hip and has motion blur FX for wings flying
#!fix with the Orion setup override materials can already contain a nullptr entry, this used to cause the material indices not to be dirtied when a new material is set, needed to remove the check() as well due to the new situation
#!jira OR-36855
#!rb Lina.Halper
Change 3368540 on 2017/03/28 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests compiled
#!rb none
Change 3368526 on 2017/03/28 by Rob.Cannaday
MaxHostConnections improvements after code review
Change 3368285 on 2017/03/28 by Lukasz.Furman
fixed TimeLimitedExecution task being removed by GC, gameplay tasks component will now keep track of all managed tasks, not only AI priority queue
#!ue4
#!rb none
#!codereview Mieszko.Zielinski
#!tests PIE
Change 3368228 on 2017/03/28 by Rob.Cannaday
Add config field to drive how many connections CURL will make to any host
[HTTP.Curl].MaxHostConnections
When 0, unlimited (default behavior)
#!jira TEN-78
#!codereview ian.fox
Change 3368076 on 2017/03/28 by Jeff.Williams
Copying //Orion/Main to Release-39.1 (//Orion/Release-39.1) @3368008
Change 3368008 on 2017/03/28 by Jeff.Williams
Merging //Orion/Dev-REGS to Main (//Orion/Main) @3367948
Change 3367820 on 2017/03/28 by Andrew.Grant
Temp workaround for crash when changing skins on Grux in the frontend
#!jira OR-36671
#!review-3367821 @Benn.Gallagher
#!tests flipped between all Grux skins and crash when selecting Scarab no lonber occurs
#!rb none
Change 3367576 on 2017/03/28 by Daniel.Lamb
Stopped the cooking of packages which are already cooked.
#!rb Trivial
#!test Shared cooked build paragon
Change 3367518 on 2017/03/28 by David.Ratti
Gameplay Tag customizations: added way for systems to turn GameplayTag widgets to hyperlinks to arbitrary callbacks (e.g, opening an asset that a project wants to associate with a tag).
#!rb none
#!tests editor
Change 3367455 on 2017/03/28 by Andrew.Grant
Merging //Orion/Main to Dev-General (//Orion/Dev-General)
#!rb na
Change 3367375 on 2017/03/28 by Benn.Gallagher
Fix for clothing perf regressions due to LOD switching leaving simulation enties in the clothing solver
#!jira OR-36926
#!rb Martin.Wilson
#!tests Editor + PIE, Cooked PS4 BaselinePerformance testing
Change 3366525 on 2017/03/27 by Jeff.Williams
Initial branch of files from Release-39 (//Orion/Release-39) to Release-39.1 (//Orion/Release-39.1)
Change 3365941 on 2017/03/27 by Andrew.Grant
Integrated fix from Dev-Gen
Speculative fix for clothing crashes using Mambo. It was possible that the skeletal mesh component could have triggered deletion or creation of simulation state objects while the simulation was in flight on another thread, added tracking and waiting for outstanding tasks.
#!jira OR-36843, UE-42975
#!rb Martin.Wilson
#!tests Editor PIE, -game hero gallery
Change 3365861 on 2017/03/27 by Jeff.Williams
Initial branch of files from Dev-General (//Orion/Dev-General) to Dev-Niagara (//Orion/Dev-Niagara)
[CL 3441199 by Andrew Grant in Main branch]
Marc Audy
nick darnell
Thomas Sarkanen
Francis Hurteau
Ben Marsh
Jason Bestimt
Marcus Wassmer
Chris Bunner
Jian Ru
Max Chen
Matt Kuhlenschmidt
Andrew Grant
Ori Cohen