Commit Graph

5462 Commits

Author SHA1 Message Date
danny couture
14026f9448 [ALT] Fix all FMessageLog indirect calls to slate widget via a delegate that can be encountered when errors are reported during async loading
#rnx
#rb JeanFrancois.Dube

[CL 28751409 by danny couture in ue5-main branch]
2023-10-13 10:07:40 -04:00
yiliang siew
40bb1ccd21 - Introduces a new FHashableUniqueStringSetKey type that is used for lookup to allow for avoiding conversion between TWeakBarrier for the key type, and also to allow for returning a sentinel "null" value when there is no key as opposed to returning an empty set (which could be a valid set). This fixes an intermittent failure where if the heap is already terminated and a object in a weak barrier is not marked, we return the object instead of a nullptr. This can happen when we are in-between heap termination and conducting a census, as the memory is still live but hasn't yet been swept.
- Adds a test to make sure that vending empty unique strings and vending unique string sets works.
- Fixes a race condition that could occur when multiple threads are running collection cycles and we read the weak barrier state first before one thread adds items to the mark stack, causing the other thread to cancel termination and thus set the weak barrier state back to inactive.

#rnx
#rb Phil.Pizlo
#rb Saam.Barati

[CL 28740421 by yiliang siew in ue5-main branch]
2023-10-12 23:10:12 -04:00
eric knapik
10ddb9b08f Fix multicast export code to export the path to the actor rather than the name so it can be parsed on import.
Fixes an issue where Alt+Click drag would ensure failing to find an actor class.

Marking the erroring primitive component BP assignable delegate TextExportTransient as we shouldn't copy and bind to the original class.

[REVIEW] [at]Robert.Millar [at]Sergio.Gardeazabal [at]Steven.Barnett

[CL 28734281 by eric knapik in ue5-main branch]
2023-10-12 18:31:25 -04:00
patrick boutot
072c79b755 MVVM: Make sure the different object ptr type matches before copying them. Evaluated path use the correct container address when evaluating a function.
#jira UE-194034
#rb editor-ui-systems, zousar.shaker

[CL 28716227 by patrick boutot in ue5-main branch]
2023-10-12 13:12:00 -04:00
brandon schaefer
8ed4c66e9c Add OPEN in AllocateSerialNumber and avoid undo'ing anything letting the Primary Serial Number keep increasing even if we abort during a transaction
#rb Michael.Nicolella, Robert.Manuszewski

[CL 28707536 by brandon schaefer in ue5-main branch]
2023-10-12 08:59:10 -04:00
tim smith
3111b9d52c Fixed Malloc/delete mismatch
#rb yiliang.siew
#jira UE-197531

[CL 28667100 by tim smith in ue5-main branch]
2023-10-11 11:56:40 -04:00
robert manuszewski
18380ec217 Making sure incremental reachability is complete before the engine performs the final UObject purge
#rb Johan.Torp

[CL 28655311 by robert manuszewski in ue5-main branch]
2023-10-11 03:23:23 -04:00
tim smith
82c32809ec Fix race condition with FrankenGC that could prevent VCell->UObject references from being marked.
#rb robert.manuszewski

[CL 28622316 by tim smith in ue5-main branch]
2023-10-10 11:52:59 -04:00
brandon schaefer
630338cc4d Add an Open for AddObject and an OpenAbort to remove it if we fail during a transaction
#rb Michel.Nicolella, Neil.Henning, Robert.Manuszewski

[CL 28617841 by brandon schaefer in ue5-main branch]
2023-10-10 10:02:41 -04:00
markus breyer
c99a307a7c Support for built-in/intrinsic functions
- new singleton cell VIntrinsics that owns VNativeFunctions belonging to the intrinsic functions
- added Floor and Ceil functions to VRational

#rb saam.barati, niklas.rojemo
#rnx

[CL 28605210 by markus breyer in ue5-main branch]
2023-10-09 19:51:11 -04:00
aditya ravichandran
d1874db290 PropertyBaseObject: When exporting a property to text, if the property is a default subobject make sure it is actually inside the parent's package instead of assuming so
#jira UE-194575
#rb maxime.mercier

[CL 28593445 by aditya ravichandran in ue5-main branch]
2023-10-09 15:06:51 -04:00
yiliang siew
f740b08a81 Fix Linux linking issues.
#rnx
#rb none
[FYI] Anna.Fukutome

[CL 28560379 by yiliang siew in ue5-main branch]
2023-10-06 18:00:32 -04:00
robert millar
7fa67ab702 Improve script VM assertion message on failure to use property setter
#rb none

[CL 28558636 by robert millar in ue5-main branch]
2023-10-06 17:26:41 -04:00
yiliang siew
664fd7f23c Introduces VClass. Emergent types are vended by VClass when a new object is requested to be constructed given a class and the fields that are being overrriden.
- Opcodes now support having immediate operands.
- Fixes the indices not being generated correctly for object shapes.
- New opcodes `NewClass`, `NewObject`, `LoadField` and `UnifyField` for working with classes and objects.
- Some `const` cleanup of arguments.
- Also update UBT to disable the "first include must match in terms of filename" check on `VerseVM`, since it brings us no benefits and actively interferes with the way we do inline versions of our headers.

#rnx
#rb Saam.Barati
#rb Phil.Pizlo

[CL 28541942 by yiliang siew in ue5-main branch]
2023-10-06 11:32:14 -04:00
dave belanger
9c9c30297b Remove AssetVersePath asset tag (motivation is that having a full path written within an asset makes it less portable and changing the root of the verse path involves resaving and revisioning lots of assets)
Bonus: Improve "Create Blueprint/C++ Class" menus to only show if they can be performed (instead of being grayed out)
#rb Steve.Robb,YiLiang.Siew,Justin.Marcus
#rnx

[CL 28539147 by dave belanger in ue5-main branch]
2023-10-06 10:23:06 -04:00
richard malo
239ac90407 Refactor in preparation of supporting Data Layer Instances saved in their own external package.
- Adapted existing code to propertly support external package on object not directly outered to the level.
- Generalized handling of external objects when renaming a world, resetting package loaders in ULevelStreamingLevelInstance, handling dirty external packages
- Implemented FExternalPackageHelper::CopyObjectsExternalPackageFilePathToClipboard
- Added optional PrimaryAssetDisplayName asset registry tag to allow for systems to use a display name (generalized version of ActorLabel tag)
#rb jeanfrancois.dube, patrick.enfedaque
#jira UE-197314

[CL 28537555 by richard malo in ue5-main branch]
2023-10-06 09:14:09 -04:00
danny couture
7396ff3001 [LinkerLoad] Fix missing attempt to reresolve a redirector when it is encountered multiple times recursively, potentially causing missing objects for complex case
#rnx
#rb Francis.Hurteau, Dave.Jones

[CL 28532851 by danny couture in ue5-main branch]
2023-10-06 03:52:12 -04:00
matt peters
c2f521c18e AssetRegistry: Respect value of LinkerLoad's s.EnforcePackageCompatibleVersionCheck and allow packages to be listed in the AssetRegistry even if they have invalid versions, if the check is disabled.
#rnx
#rb Zousar.Shaker

[CL 28515527 by matt peters in ue5-main branch]
2023-10-05 16:37:16 -04:00
kirill zorin
a69268f054 TMaybeObjectPtr: fixing sometimes-incorrect handling of pointers returned from Cast<...>
#rb sebastian.barrios

[CL 28507521 by kirill zorin in ue5-main branch]
2023-10-05 13:54:43 -04:00
matt peters
aa16a83128 Cooker: Add HardEditorOnlyReference to the list of Instigator causes. This is useful for validating that packages omitted by SkipOnlyEditorOnly were indeed OnlyEditorOnly in the non-SOEO cook.
#rb Zousar.Shaker
#rnx

[CL 28505710 by matt peters in ue5-main branch]
2023-10-05 13:10:39 -04:00
justin marcus
d4f26c234d Add comment about using package versions during saving.
#jira

[CL 28504123 by justin marcus in ue5-main branch]
2023-10-05 12:36:10 -04:00
KristofMorva
a75f380b2a Fix warning "Failed to find object 'Object None.None'" when deserializing FObjectAndNameAsStringProxyArchive.
Should also speed up loading a buffer with a lot of NULL objects considerably (see PR #6875).

#jira UE-92396
#PR 6875
#rb robert.millar

#ushell-cherrypick of 28497640 by kristof.morva1

[CL 28502883 by KristofMorva in ue5-main branch]
2023-10-05 12:09:52 -04:00
neil henning
38245c59ea Make MakeUniqueObjectNameReusingNumber transactionally safe.
[CL 28499782 by neil henning in ue5-main branch]
2023-10-05 11:04:36 -04:00
andrew rodham
f5896b67bb Core: Make UScriptStruct::ImportText const-correct
#rb Steve.Robb

[CL 28497785 by andrew rodham in ue5-main branch]
2023-10-05 09:57:09 -04:00
markus breyer
23bfca8aaa Various additions and fixes in VerseVM 2/2
- removed incorrect array append functionality from Add operator
- added support for multiplication between int and float values
- added string length support
- minor improvements

#rb yiliang.siew
#rnx

[CL 28485353 by markus breyer in ue5-main branch]
2023-10-04 20:46:48 -04:00