+ Improve messaging when movie pipeline test is failing for reason other than image comparison.
+ Store ScreenshotName inside comparison request and result.
#jira UE-194701
#rnx
#rb Matt.Hoffman, Sean.Sweeney
[CL 28750594 by jerome delattre in ue5-main branch]
- Removed unused function
- Added 'FX' asset type category for Niagara purposes that maps to the FX asset category path for default expansion purposes
- Restored functionality for default filter category expansion. This code seemed abandoned. The category expansion could be specified in the asset picker config, but in the end was ignored and the Basic asset path was used instead. This uses a Convert function to go from AssetTypeCategory -> AssetCategoryPath. There is no 1:1 mapping, so it falls back to Basic if necessary. Changing the type in the asset picker config would be cleaner, but isn't straight forward due to FAssetCategoryPath needing to be exposed to all modules that include the content browser module
- Tweaked OnExtendAddFilterMenu delegate. It's now a global delegate, making it unnecessary to handle template shenanigans to access it.
AssetPickerConfig has a new option to provide this OnExtendAddFilterMenu externally. As the 'Common' category still shows up if we expand the FX category (since Niagara System is part of Basic & FX), we can use this to remove unwanted filters
The delegate is called on the dynamic menu section before the widget generation
- Added PinAllFrontendFilters argument. This is useful if you have a small amount of filters available so that you want to display them all by default
Big code cleanup:
- MakeAddFilterMenu is now marked as final to help with API consistency.
- Added new 'CreateAssetFilterBarContext` virtual function. This is now the unified way of configuring your menu.
- The context now contains the FOnFilterAssetType delegate, and the OnExtendAddFilterMenu delegate. This allows subclasses to keep their original functionality, while having a central place to tweak it
- Removed the old content browser context as it's no longer used
- Exposed the menu name. Kept old names consistent. This allows to reuse menus, or create new ones.
- Moved the right click context filter UI of the content browser into the SAssetFilterBar. Now all SAssetFilterBars can do this. Removed the OnGetContextMenu delegate that was only used in one place
- Removed various functions that are no longer needed
#rb rex.hill, aditya.ravichandran
#ushell-cherrypick of 28538117 by Mateo.Egey
[CL 28705843 by mateo egey in ue5-main branch]
* Generate line directive map during parsing
* Use xxhash instead of cityhash
* Avoid FStringView operator [] in ExtractIdentifiers
* Use TArray Reset instead of Empty where appropriate
* Vectorize SkipUntilNonIdentifierCharacter
* Vectorize ExtractBlock
* Vectorize line ending search
* Use FString directly instead of FStringBuilderBase for the final output to avoid a copy
#rb christopher.waters
#rb jason.hoerner
[CL 28699609 by yuriy odonnell in ue5-main branch]
Changed UTS version visualisation in log to avoid "heap-use-after-free" error in IsUnrealTraceServerReady()
#jira UE-196814
#rb Ionut.Matasaru Monica.South
#tests mac, linux, win64
[CL 28654678 by mikita hauruk in ue5-main branch]
- Patch HLSL to support SV_DepthGreaterEqual and SV_DepthLessEqual.
- Maintain order of shader input/output variables in cross-compiled HLSL.
#rb Jason.Nadro
#jira UE-186066, UE-192125
#rnx
[CL 28633421 by laura hermanns in ue5-main branch]
* Set the no-encryption setting in the template Mac plist to make uploading to TestFlight/AppStore easier
* Fixed editor to not compile as universal when using -distribution, only the client should be universal
* Further improvements to stripping out nested .app's in a final .app (remove them from the staged directory helps)
* Changed how the Mac app name is displayed, since the .app name itself is shown in the Finder, unlike IOS where the CFBundleName is shown (the archived .app name in the .xcarchive is named by a project setting, falling back to the .uproject name if not set)
* Disabled the SignExecutables function on Modern because they attempt to sign the wrong .apps, and one is no longer (previously it was uselessly signing .apps, but now it throws an error due to changes for the third item in this list)
[CONSIDER5.3]
#rb calvin.zheng
#jira UE-197465
[CL 28619839 by josh adams in ue5-main branch]