Commit Graph

169 Commits

Author SHA1 Message Date
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
geoff evans
1981b2f5f3 StallDetector support for Linux
### Features

This change enables the StallDetector watchdog in Editor to submit reports to crashreporter about threads violating instrumented deadlines in the source code. This feature was available prior on Windows, and this change adds Linux support.

### Notes

New APIs:
ReportStall()
CaptureThreadPortableCallStack()

Many APIs are updated from purely "Ensure" naming to more general naming. Stalls are more like Ensures than crashes, and so the appropriate renames to make the code readable and clear have been made. In some places Ensure is replaced with the clearer: Continuable Event nomenclature.

### Testing

I synthesized an ensure on Linux, and did the same for a stall. I then compared crash report XML file to make sure they contain accurate data in the callstack, portable callstack, and other fields in the report. I also noted that the stall information was showing as expected in the crash reporter.

#rb brandon.schaefer, francis.hurteau
#jira UETOOL-3336
#preflight 625e20d2804460ab0fea3277

[CL 19911608 by geoff evans in ue5-main branch]
2022-04-25 19:19:04 -04:00
Devin Doucette
292008ea35 Logging: Replaced GLog->PanicFlush() with GLog->Panic()
Panic allows only one thread to become the panic thread. In panic mode, logs are only sent to panic-safe output devices. Each call to Panic flushes buffered logs to panic-safe output devices, and flushes panic-safe output devices.

#jira UE-147152
#preflight 62424814292f228e09d8a612
#rb Zousar.Shaker
#fyi Brandon.Schaefer

[CL 19545093 by Devin Doucette in ue5-main branch]
2022-03-29 13:31:48 -04:00
wes hunt
b14fc01621 Fix FGenericCrashContext::Initialize() to initialize the GameName to UE-ProjectName instead of UE5-GameName
#ROBOMERGE-AUTHOR: wes.hunt
#ROBOMERGE-SOURCE: CL 19472252 via CL 19472515 via CL 19472553 via CL 19488666 via CL 19488781
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v936-19480137)

[CL 19489780 by wes hunt in ue5-main branch]
2022-03-23 20:34:22 -04:00
Andriy Tylychko
ab590753d3 Mac compilation: added "-faligned-new" if an old macOS is targetted to avoid "aligned new is not supported" error. Broken build: https://horde.devtools.epicgames.com/job/618160c0fc786a000148b7f4?step=ea45
preflight https://horde.devtools.epicgames.com/job/6182954f300d520001e9e1fb?step=1df5

#jira UE-131480
#rb will.damon

[CL 18049627 by Andriy Tylychko in ue5-main branch]
2021-11-04 05:04:27 -04:00
Chris Varnsverry
d591db88dc - Fix aligned allocation reliated compile fails in targets building against old OSX versions.
#review-18021464 @Michael.Kirzinger @Sam.Zamani
#jira UE-133052

[CL 18022672 by Chris Varnsverry in ue5-main branch]
2021-11-02 14:18:30 -04:00
Andriy Tylychko
2a295eb685 deprecated FTicker and family and replaced by thread-safe FTSTicker
#jira UE-120090
#rb francis.hurteau

[CL 17176325 by Andriy Tylychko in ue5-main branch]
2021-08-16 11:05:18 -04:00
Patrick Laflamme
ac8bb6f139 Fixed hang in crash reporter client when reporting bug in unattended mode.
- Ensured the new FTSTicker get ticked when running CRC in unattended mode.

#rb Jerome.Delattre
#fyi Dmytro.vovk

[CL 17157164 by Patrick Laflamme in ue5-main branch]
2021-08-12 15:33:43 -04:00
Patrick Laflamme
24bc1477ae Removed CrashReportClient analytic field 'MonitorQueryingPipe' that was temporary added to verify if CRC crashed while reading the pipe.
- The data show no evidence that CRC is crashing there. Capturing this state is I/O expensive and not required moving forward.

#jira UETOOL-4042 Inspect UE5/Main analytics for CRC crashes
#rb Jamie.Dale

[CL 17116844 by Patrick Laflamme in ue5-main branch]
2021-08-10 10:57:38 -04:00
aurel cordonnier
d17d20ca36 Merge from Release-Engine-Test @ 16758890 to UE5/Main
This represents UE4/Main @ 16738161 and Dev-PerfTest @ 16737719 (and Release-17.00 @ 16658211)

[CL 16763350 by aurel cordonnier in ue5-main branch]
2021-06-23 17:51:32 -04:00
Brandon Schaefer
da6e2eb1e2 Rename LinuxAArch64 to LinuxArm64
#jira UE-118127
#rb Michael.Sartain
#fyi Marc.Audy, Aurel.Cordonnier

[CL 16660821 by Brandon Schaefer in ue5-main branch]
2021-06-14 13:39:47 -04:00
Patrick Laflamme
8064fa38b0 Added temporary diagnostic code to CrashReportClient in hopt to narrow down why it suspiciouly die often.
#rb Jamie.Dale

[CL 16640468 by Patrick Laflamme in ue5-main branch]
2021-06-11 08:51:14 -04:00
aurel cordonnier
e0ad4e25df Merge from Release-Engine-Test @ 16624776 to UE5/Main
This represents UE4/Main @ 16579691 and Dev-PerfTest @ 16579576

[CL 16625248 by aurel cordonnier in ue5-main branch]
2021-06-10 13:13:24 -04:00
David Harvey
f0ba6ecb4f adding the option to hide the 'submit and restart' crash reporter option for platforms that do not support it.
#jira UE-93432
#rnx
#rb Patrick.Laflamme

[CL 16622682 by David Harvey in ue5-main branch]
2021-06-10 09:59:32 -04:00
Patrick Laflamme
eba22612ed Updated the crash report analytic session summary version number from 4 to 5.
#rb trivial

[CL 16592549 by Patrick Laflamme in ue5-main branch]
2021-06-08 16:11:15 -04:00
Patrick Laflamme
571c8ffe14 Added analytics to report more granular metrics about CRC performance when handling crash/ensure/stall.
#rb Jamie.Dale

[CL 16570467 by Patrick Laflamme in ue5-main branch]
2021-06-07 10:37:55 -04:00
Patrick Laflamme
aa76047110 Stripped the callstack from the ensure error message when logging the ensure message in the analytics diagnostic log.
- This information is not required for analytic purpose.

#rb Jamie.Dale

[CL 16533474 by Patrick Laflamme in ue5-main branch]
2021-06-02 09:16:50 -04:00
Patrick Laflamme
ef94e39d6c UETOOL-3650 - Delete expired UECrashContext-pid.xml that could be left over by crashed/killed CRC
- Added code to run a clean up on UECrashContext-{pid}.xml files that 30 days old where the process ID (pid in the name) is not running anymore.

#rb Jamie.Dale

[CL 16522984 by Patrick Laflamme in ue5-main branch]
2021-06-01 16:55:30 -04:00
aurel cordonnier
43fa62fcd8 Merge from Release-Engine-Test @ 16487383 to UE5/Main
This represents UE4/Main @ 16445039 and Dev-PerfTest @ 16444526

[CL 16488106 by aurel cordonnier in ue5-main branch]
2021-05-27 13:40:37 -04:00
Patrick Laflamme
9925c861ae Prevent the engine from providing all threads to CRC on stall and ensure. Only transmit the responsible thread, so that CRC doesn't need to walk all threads before resuming the engine.
- Analytics shows that CRC may takes up to 400 seconds to walk all the threads and create a minidump before responding back to the engine on the pipe to resume the crashing thread.

#rb Johan.Berg
#fyi Geoff.Evans

[CL 16483781 by Patrick Laflamme in ue5-main branch]
2021-05-27 10:10:12 -04:00
danny couture
c5710a3eba Fix non-unity build
#rb trivial
#rnx

[CL 16469067 by danny couture in ue5-main branch]
2021-05-26 10:18:35 -04:00
Patrick Laflamme
9f3f8f25e8 Removed duplicated module dependency on Analytics from CrashReportCLientEditor build script.
Added missing include in AnalyticsPropertyStore.cpp
Added ENGINE_API to expose EngineAnlytixSessionSummary publicly.
Added the longuest unattended crash report processing measured during a session to CRC summary to track how fast or how slow CRC is to manage ensures/stalls.

#rb Jamie.Dale

[CL 16404437 by Patrick Laflamme in ue5-main branch]
2021-05-20 11:39:14 -04:00
Patrick Laflamme
cb3aaf9000 Fixed analytics summary system losing type information.
- Instead of converting summary properties to string duing session aggregation, put properties in FAnalyticsEventAttribute instances to preserve the type information.
Added MonitorEngineVersion, MonitorReportCount, MonitorEnsureCount, MonitorAssertCount to CRC analytics summary.
Added MissingDataFrom to the analytics summary when the property file from a collaboration process failed to load.
Fixed the analytics summary manager to aggreage and produce a report even if the helper process data couldn't be loaded.

#rb Jamie.Dale

[CL 16382795 by Patrick Laflamme in ue5-main branch]
2021-05-19 06:22:37 -04:00
Patrick Laflamme
d62b1c4fea Fixed Editor analytics session summary key 'MonitorLogs' as 'MonitorLog' to be consistent with previous versions.
#rb Trivial.

[CL 16328917 by Patrick Laflamme in ue5-main branch]
2021-05-14 09:18:54 -04:00
Jeff Farris
c2c4f4ac98 Fixed CrashReportClientEditor compile error in unity builds.
#fyi Patrick.Laflamme

[CL 16326683 by Jeff Farris in ue5-main branch]
2021-05-14 00:48:14 -04:00