Commit Graph

10942 Commits

Author SHA1 Message Date
rob krajcarski
755d3d7dd9 Fix for metal shader backend mismatch between resources and samplers
#jira UE-151850
#rb christopher.waters
#preflight none

[CL 20246663 by rob krajcarski in ue5-main branch]
2022-05-17 13:36:05 -04:00
ionut matasaru
f319b6cd6e Fixed CIS error (-NoPCH -DisableUnity).
#rb trivial
#jira UE-152669
#preflight skip

[CL 20246426 by ionut matasaru in ue5-main branch]
2022-05-17 13:24:57 -04:00
alexander suvorov
ba7c292aba #jira FORT-432261
Allow color adjustment for cubemaps created from longlat sources.
#rb charles.bloom
#preflight 627e972d6d7654cc68b225bd

[CL 20241303 by alexander suvorov in ue5-main branch]
2022-05-17 08:41:54 -04:00
paul chipchase
f85fad88ff It is now possible to disable virtualization for all payloads owned by a specific asset type by adding the name of the asset to [Core.ContentVirtualization]DisabledAsset string array in the engine ini file.
#rb Per.Larsson
#rnx
#jira UE-151377
#preflight 628364050039ea57a52d6989

### Virtualization
- [Core.ContentVirtualization] in the engine ini file now supports an array called 'DisabledAsset' which can be used to name asset types that should not virtualize their payloads.
-- By default (in BaseEngine.ini) we have disabled the StaticMesh asset as we know it will crash if a payload is missing and the SoundWave asset as it still is pending testing.
- This new way to disable virtualization is data driven. The older hard coded method has not been removed but will likely be reworked in a future submit.
- Now when an editor bulkdata is adding it's payload to the package trailer builder during package save it will poll the virtualization system with a call to the new method ::IsDisabledForObject by passing in it's owner.
-- If the owner is valid and was present in the 'DisabledAsset' array then the method will return true and the EPayloadFlags::DisableVirtualization flag will be applied.

### Package Trailer
- The pre-existing functionality of enum EPayloadFilter has been moved to a new enum EPayloadStorageType as will only filter payloads based on their storage type.
- EPayloadFilter has been modified to filter payloads based on functionality although at the moment the only thing it can filter for is to return payloads that can be virtualized, it is left for future expansion.
- EPayloadFlags has been reduced to a uint16 with the remaining 2bytes being turned into a new member EPayloadFilterReason.
- This new member allows us to record the exact reason why a payload is excluded from virtualization. If it is zero then the payload can virtualize, otherwise it will contain one or more reasons as to why it is being excluded. For this reason the enum is a bitfield.
- Added overloads of ::GetPayloads and ::GetNumPayloads that take EPayloadFilter rather than a EPayloadStorageType
- Added wrappers around all AccessMode types for FLookupTableEntry.
- FPackageTrailerBuilder has been extended to take a EPayloadFilterReason so that the caller can already provide a reason why the payload cannot be virtualized.
-- As a future peace of work this will probably be changed and we will ask the caller to pass in the owner UObject pointer instead and then we will process the filtering when building the package trailer to a) keep all of the filtering code in one place b) keep the filtering consistent

### PackageSubmissionChecks
- The virtualization process in  will now request the payloads that can be virtualized from the package trailer, which respects the new payload flag, rather than requesting all locally stored payloads.

### UObjects
- There is no need for the SoundWave or MeshDescription classes to opt out of virtualization on construction. This will be done when the package is saved and is now data driven rather than being hardcoded.

### DumpPackagePayloadInfo
- The command has been updated to also display the filter reasons applied to each payload

[CL 20240971 by paul chipchase in ue5-main branch]
2022-05-17 07:54:28 -04:00
sara schvartzman
642f1d141d Control Rig: Fix crash when connecting different type to template node
#jira UE-152650
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/62837e9aed2c0847b026948c

[CL 20240830 by sara schvartzman in ue5-main branch]
2022-05-17 07:43:53 -04:00
ionut matasaru
6ba99a3742 [Insights]
- Table Tree view: Added "SameValue" aggregation for the table/tree columns of CString type. Aggregated value is equal with children value if all children have exactly same value, otherwise aggregated value is empty.
  - Memory Insights: Enabled "SameValue" aggregation for the Mem Tag column of the Mem Allocs table/tree view.

#jira UE-152586
#rb Catalin.Dragoiu
#preflight 6282a1907d471e73a568ea4c

[CL 20239889 by ionut matasaru in ue5-main branch]
2022-05-17 05:41:12 -04:00
Johan Torp
cd2427aff7 Deprecated nonsensical FDateTime + FDateTime operator that modified left-hand side
Updated the deprecated operator+ to not modify LHS
Didn't make it const since that causes ambiguity, e.g. FDateTime() + 0.0f

PR #8690: Fix for the FDateTime "+operator" (Contributed by yashasg)
#jira UE-136752
#rb pj.kack
#preflight 6283680e44349a6581e709eb

[CL 20239857 by Johan Torp in ue5-main branch]
2022-05-17 05:35:22 -04:00
Arciel Rekman
da789a035f Fix FHlslParser to support global scope.
#rb Yuriy.ODonnel
#jira none
#preflight none

[CL 20233493 by Arciel Rekman in ue5-main branch]
2022-05-16 18:10:37 -04:00
jon olick
9408eb8659 Fixed GetAllDefaultTextureFormats as well for MacEditor
#preflight

[CL 20231289 by jon olick in ue5-main branch]
2022-05-16 16:36:39 -04:00
Jon Olick
8c5745998d Fix for GenericMaxTargetPlatform.h and texture building
#preflight 6282af0dcf7e4667a9acda17

[CL 20231086 by Jon Olick in ue5-main branch]
2022-05-16 16:29:42 -04:00
jack cai
65e04a2821 ControlRig: rigvmpythonuitl.cpp non-unity compilation issue, missing class.h header include
#jira UE-152512
#rb trivial
#preflight skip

[CL 20227668 by jack cai in ue5-main branch]
2022-05-16 13:47:05 -04:00
robomerge
6a58d6b815 Material Baking - FExportMaterialProxy - Do not rely on BaseMaterialId as it is invalid on cooked materials
* Instead, use StateId & override GetShaderMapUsage() to differentiate the export proxy from the source material.
#rb jason.nadro

#ROBOMERGE-AUTHOR: sebastien.lussier
#ROBOMERGE-SOURCE: CL 20222932 via CL 20224332 via CL 20224346 via CL 20224360
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20227117 by robomerge in ue5-main branch]
2022-05-16 13:10:08 -04:00
Jon Olick
0a7be0f773 Removed bSupportDX11TextureFormats, functionality is no longer necessary. Pushed functionality of bSupportDX11TextureFormats down to target platform code.
#preflight 6282816acf7e4667a999a6ea

[CL 20227025 by Jon Olick in ue5-main branch]
2022-05-16 13:05:50 -04:00
ionut matasaru
7abf3bac49 [Insights]
- Memory Insights: Added "Open Source in Visual Studio" for any callstack frame of any allocation item, in the Allocs Table/Tree view (even if the tree is not grouped by callstack).

#jira UE-152557
#rb Catalin.Dragoiu
#preflight 6282660f046b81bf93be7420

[CL 20226574 by ionut matasaru in ue5-main branch]
2022-05-16 12:40:00 -04:00
danny couture
623896568d Improve frame rate stability in editor by reducing the priority of the DDC IO threads which are now doing CPU intensive compression to avoid them preempting more important threads (GT/RT/RHI)
#rnx
#rb Devin.Doucette
#preflight 62825177cf7e4667a991a6cc

[CL 20223281 by danny couture in ue5-main branch]
2022-05-16 09:52:19 -04:00
David Harvey
564e50fa3c move HoloLens default packaging resource images to platform extension folder.
#jira UE-149794
#rnx
#rb Jeff.Fisher, Josh.Adams
#preflight 6274da588a31599132a0cf72

[CL 20222676 by David Harvey in ue5-main branch]
2022-05-16 09:18:03 -04:00
julien lheureux
c97187b8c3 Fixed crash on interacting with garbage collected packages after their deletion through a sync in source control.
#rnx
#rb jamie.dale, takashi.suzuki
#preflight 627eb8569650a27733a21686
#jira UE-104597

[CL 20222478 by julien lheureux in ue5-main branch]
2022-05-16 09:03:46 -04:00
ionut matasaru
1c905ca529 [Insights] Added "TraceAnalysis" and "Trace/CpuProfile" LLM_SCOPEs (in an effort to reduce the Untagged allocations):
- "TraceAnalysis" -- captures all mem allocated by the FAnalysisProcessor.
  - "Trace/CpuProfile" -- captures allocation of per-thread buffers used by the cpu profiler trace.

#jira UE-147172 (partially)
#rb Johan.Berg
#preflight 6281fc9fd819c085e0ad0fe5

[CL 20222034 by ionut matasaru in ue5-main branch]
2022-05-16 07:37:42 -04:00
paul chipchase
2f9d959940 Fix a bug where the virtualization process was failing to virtualize loaded packages when submitted from the editor
#rb trivial
#rnx
#preflight 62820fb0046b81bf93921c6b

- When adding the check to see if a package file could be written to, I tried to do this as early as possible to avoid virtualizing payloads for packages that can't be modified.
- This didn't take into account submits via the editor, when the package is loaded which means the editor will have the package file locked for edit.
- For now I have gone with the simple fix, we check if we can write to the package once we have called ResetLoader on the package. This means that we will virtualize the payloads then potentially skip removing them from the package file if another process has a file lock.
- This approach will minimize impact to the users for now but we should revisit this in the future to try and reduce the error scope further.

[CL 20221653 by paul chipchase in ue5-main branch]
2022-05-16 06:10:12 -04:00
josh adams
c9a46d2479 - Fixed typo on printf, I swear I had compiled the editor, I guess not sigh
#rb trivial
#preflight skip

#ROBOMERGE-AUTHOR: josh.adams
#ROBOMERGE-SOURCE: CL 20187446 via CL 20189065 via CL 20189140 via CL 20189159
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20191624 by josh adams in ue5-main branch]
2022-05-13 18:57:37 -04:00
josh adams
e7204af78c - Added some more debugging for dealing with missing EditorOptional files going from Client -> Editor
#rb trivial
#preflight skip

#ROBOMERGE-AUTHOR: josh.adams
#ROBOMERGE-SOURCE: CL 20185216 via CL 20189057 via CL 20189126 via CL 20189153
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20191620 by josh adams in ue5-main branch]
2022-05-13 18:57:30 -04:00
Jeremy Moore
0186b7d7bc Added virtual texture warmup for material baking.
Number of warmup frames is controlled by MaterialBaking.VTWarmupFrames CVar and defaults to 5
Warmup should only happen if material samples virtual textures.
#preflight 627ec42a5a0a06a57ea838e6

[CL 20189296 by Jeremy Moore in ue5-main branch]
2022-05-13 17:01:46 -04:00
lucas dower
3ab4f1d404 Organise anim assets into subcategories and add or fix tooltips
#jira UE-139412
#rb thomas.sarkanen
#preflight 627d322462656a7b7e31a679

[CL 20179330 by lucas dower in ue5-main branch]
2022-05-13 07:12:03 -04:00
sara schvartzman
1bce442c08 Control Rig: Fix hanging of editor when adding/breaking links
#jira UE-151849
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/627e3843830b40b66830915e

[CL 20179303 by sara schvartzman in ue5-main branch]
2022-05-13 07:10:24 -04:00
Helge Mathee
79506075b5 RigVMDeveloper: Centralize pythonize for enum values
#rb sara.schvartzman
#jira UE-151724
#preflight https://horde.devtools.epicgames.com/job/627e298434434190054ad8c8

[CL 20178877 by Helge Mathee in ue5-main branch]
2022-05-13 05:53:36 -04:00