#Summary
Remove useless network capability validated code
The crash was caused by failing to check for null in responses from calls to some system methods.
In general this code doesn't help much since this specific check was added prior to adding the more thorough HEAD request to example.com.
By removing it, it should fix the null issue, and in-fact make the naive internet check more in-line with what's expected which is a very simple network check.
This naive check always followed by attempting to connect to example.com which provides a far more guaranteed check into whether the internet is in-fact connected.
#Test Plan
Connected bluetooth headset
Launched app
launched game
Disconnected bluetooth
Verified no crash
#ROBOMERGE-SOURCE: CL 10155147 via CL 10155334 via CL 10155443
#ROBOMERGE-BOT: (v587-10111126)
[CL 10155612 by ben temple in Main branch]
# Summary
See title, variable needed to be declared as final.
#ROBOMERGE-SOURCE: CL 10084496 via CL 10084499 via CL 10084505 via CL 10084508
#ROBOMERGE-BOT: (v574-10069753)
[CL 10087046 by ben temple in Main branch]
# Summary
Since the HTTP url open connection is a blocking call. It needs to be run on a seperate thread. The call .get on a future is blocking though, meaning we were still running a blocking call on the main looper. This updates that code to instead add a timeout runnable to the local handler, to cancel the executor if it hasn't completed in the allotted time.
Added some tweaks to match comments made by [at]Pete.Procopio
- Refactor INSTANCE to be lower case
- Tweak construction of Logger to match current pattern
- Copied over correct NetworkChangedManager to remove System static call that was accidently included in the NativeWrapper
[CODEREVIEW] [at]Zhao.Zhong [at]Chris.Babcock [at]Pete.Procopio [at]trevor.stone
# Test Plan
1. Built and ran app with UeDevelopmentDebug
2. app launched
3. signed in
4. verified that could start download
5. Turned off wifi
6. Verified that saw network error
7. Turned wifi back on
8. Verified that network error went away automatically
#ROBOMERGE-SOURCE: CL 10073998 via CL 10074011 via CL 10074013 via CL 10074017
#ROBOMERGE-BOT: (v574-10069753)
[CL 10075107 by ben temple in Main branch]
# Summary
This matches code that we recently added to iOS. Along with attempting to determine network connectivity with system methods, this also checks the ability to resolve a HEAD request with an external host `http://google.com/` in-order to verify that the network connection actually has a connection. This check is asynchronous with a 2 second timeout and has an exponential back-off retry with a maximum of up to 13 seconds when the check fails.
[CODEREVIEW] [at]zhaolong.zhong [at]chris.babcock
# Test Plan
1. Built and ran app with UeDevelopmentDebug
2. app launched
3. signed in
4. verified that could start download
5. Turned off wifi
6. Verified that saw network error
7. Turned wifi back on
8. Verified that network error went away automatically
Repeated above steps but instead of turning off wifi, had Scout test it by unplugging the network cable to a wifi router.
#ROBOMERGE-SOURCE: CL 10068945 via CL 10068946 via CL 10068947 via CL 10068950
#ROBOMERGE-BOT: (v574-10069753)
[CL 10073116 by ben temple in Main branch]
#android
[at]Pete.Procopio
#rb Pete.Procopio
#ROBOMERGE-SOURCE: CL 9619974 via CL 9620751 via CL 9620787
#ROBOMERGE-BOT: (v528-9595928)
[CL 9620822 by chris babcock in Main branch]
#jira UE-81254
#PR #6249
#ue4
#android
#rb trivial
#ROBOMERGE-SOURCE: CL 9479487 via CL 9479558
#ROBOMERGE-BOT: (v508-9471939)
[CL 9479560 by chris babcock in Main branch]
#jira:FORT-212155
#android
#rb:Chris.Babcock
#ROBOMERGE-SOURCE: CL 8983651 via CL 8985055 via CL 8985213
#ROBOMERGE-BOT: (v441-8974111)
[CL 8989970 by pete procopio in Main branch]
#android
#rb Pete.Procopio
#ROBOMERGE-SOURCE: CL 8376640 via CL 8376641 via CL 8376642 via CL 8377377 via CL 8380717
#ROBOMERGE-BOT: (v402-8361577)
[CL 8380781 by chris babcock in Main branch]
#rb jack.porter
#ROBOMERGE-SOURCE: CL 8210582 via CL 8210585 via CL 8211298
#ROBOMERGE-BOT: (v401-8057353)
[CL 8211403 by dmitriy dyomin in Main branch]
#ue4
#android
[at]Pete.Procopio
#ROBOMERGE-SOURCE: CL 8044017 via CL 8044020 via CL 8044753 via CL 8047292
#ROBOMERGE-BOT: (v400-8057353)
[CL 8066732 by chris babcock in Main branch]
#rb chris.babcock
[FYI] chris.babcock, jack.porter
#rnx
#ROBOMERGE-SOURCE: CL 7920939 via CL 7920941 via CL 7920947 via CL 7922543
#ROBOMERGE-BOT: (v391-7919777)
[CL 7922754 by allan bentham in Main branch]
#android
[REVIEW] [at]Pete.Procopio
#ROBOMERGE-SOURCE: CL 7890200 via CL 7890204 via CL 7893018 via CL 7893354 via CL 7917067
#ROBOMERGE-BOT: (v389-7813075)
[CL 7917162 by chris babcock in Main branch]
[REVIEW] [at]Chris.Babcock
#rnx
#ROBOMERGE-SOURCE: CL 7709501 via CL 7709502 via CL 7709503 via CL 7710969
#ROBOMERGE-BOT: (v385-7708028)
[CL 7711100 by francois guimond in Main branch]
#jira none
#android
#rb trivial
#ROBOMERGE-SOURCE: CL 7633002 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v372-7473910)
[CL 7633003 by chris babcock in Main branch]
#jira:None
#android
#kairos
#ROBOMERGE-SOURCE: CL 7617055 via CL 7617484 via CL 7617525 via CL 7625655
#ROBOMERGE-BOT: (v372-7473910)
[CL 7625737 by pete procopio in Main branch]
#jira:FORT-192662
#android
#kairos
#ROBOMERGE-SOURCE: CL 7615728 via CL 7616480 via CL 7616516 via CL 7624236
#ROBOMERGE-BOT: (v372-7473910)
[CL 7624414 by pete procopio in Main branch]
Commiting changes from post-commit review.
#rnx
#rb Chris.Babcock, Pete.Procopio
#ROBOMERGE-SOURCE: CL 7265680 via CL 7271181
#ROBOMERGE-BOT: (v369-7254125)
[CL 7271330 by francois guimond in Main branch]
