Commit Graph

17572 Commits

Author SHA1 Message Date
krzysztof narkowicz
f04ce1caad Fixed rendering corruption and crashes when r.DoInitViewsLightingAfterPrepass 1. This was caused by using FGlobalDynamic(Vertex/Index/Read)Buffer before it was committed (also commit was overlapping the parallel draw cmd list):
* IntiViews
* Dispatch prepass parallel cmd list (flickering, as global buffers weren't committed).
* InitShadows.
* Commit global buffers (race condition and potential crash).

This was fixed by:
* Renamed FNiagaraGlobalReadBuffer to FGlobalDynamicReadBuffer and moved it out from Niagara.
* Removed all global buffer singletons and placed them inside appropriate renderers as static members.
* They are also separated into two - one for InitViews and one for InitShadows, so we can dispatch prepass while writing to the shadow global buffers.
* All global buffers are now passed as a parameter and/or through mesh collector.

#jira UE-69167
#rb Rolando.Caloca
#rnx

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: krzysztof.narkowicz
#ROBOMERGE-SOURCE: CL 4871865 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4884269 by krzysztof narkowicz in Dev-Networking branch]
2019-02-04 12:25:41 -05:00
jules blok
2d8d9b1890 Move the InstanceFactor to draw command submission rather than building
#jira UE-69272
#rb Daniel.Wright

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: jules.blok
#ROBOMERGE-SOURCE: CL 4871742 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4884268 by jules blok in Dev-Networking branch]
2019-02-04 12:25:37 -05:00
jon nabozny
9ae67030c1 Disable NetGuidCache History tracking by default.
[CODEREVIEW] Ryan.Gerleve, Bart.Hawthorne, Brian.Bekich

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: jon.nabozny
#ROBOMERGE-SOURCE: CL 4860847 via CL 4860851 via CL 4865329 via CL 4870465
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4884220 by jon nabozny in Dev-Networking branch]
2019-02-04 12:24:11 -05:00
uriel doyon
d8c9ecbb81 Fixed missing include "FXSystemPrivate.h".
#rb none

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: uriel.doyon
#ROBOMERGE-SOURCE: CL 4869284 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4884174 by uriel doyon in Dev-Networking branch]
2019-02-04 12:23:16 -05:00
jules blok
3cd77bcc2e Add ISR support for instanced particles.
Improve the fix for UE-39249, instead of changing CheckAndUpdateLastFrame() rendering code is moved outside of its conditional scope.
This reduces redundant buffer allocations/uploads within the same frame.

#rb Ryan.Vance

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: jules.blok
#ROBOMERGE-SOURCE: CL 4869197 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4884173 by jules blok in Dev-Networking branch]
2019-02-04 12:23:14 -05:00
jules blok
ca8d3a89a6 Downsampled translucent rendering now also sets the instanced view uniform buffer
#rb Ryan.Vance

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: jules.blok
#ROBOMERGE-SOURCE: CL 4869192 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4884172 by jules blok in Dev-Networking branch]
2019-02-04 12:23:13 -05:00
uriel doyon
f80c1c6324 Extended FFXSystemInterface framework to allow custom FX implementations.
NiagaraEmitterInstanceBatcher now derives from FFXSystemInterface and is hooked to the new implementation.
Removed the FComputeDispatcher framework (which was only used for Niagara hooks)
#jira UE-67618
#rb Matt.Collins

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: uriel.doyon
#ROBOMERGE-SOURCE: CL 4869109 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4884171 by uriel doyon in Dev-Networking branch]
2019-02-04 12:23:11 -05:00
arciel rekman
53f2d3bff9 Linux: removed an obsolete cmline arg and added logs for build settings.
#rb Brandon.Schaefer
#rnx

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: arciel.rekman
#ROBOMERGE-SOURCE: CL 4860272 via CL 4865225 via CL 4867323
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4884033 by arciel rekman in Dev-Networking branch]
2019-02-04 12:15:47 -05:00
chris bunner
8e7c248036 Resolving Robomerge conflict from shelf 4866583.
#rb Robomerge

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: chris.bunner
#ROBOMERGE-SOURCE: CL 4867298 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4883999 by chris bunner in Dev-Networking branch]
2019-02-04 12:15:22 -05:00
James Hopkin
03fa8c7775 Manual merge changelist that broke RoboMerge, due to weird integration records for test files
Merging //UE4/Dev-Main to Dev-Networking (//UE4/Dev-Networking)

Copying //UE4/Dev-Documentation to Samples-Main (//UE4/Samples-Main) CL - 4860397
#rb none

[CL 4883189 by James Hopkin in Dev-Networking branch]
2019-02-04 09:35:31 -05:00
John Barrett
febbc76efb Disable stateless challenge ack retries, once the client sends a non-handshake packet.
Fixes an issue where connections would be initialized into a bad state, if connecting to the same IP:Port, as a prior connection.

#rb Mattias.Hornlund
#JIRA none

[CL 4883073 by John Barrett in Dev-Networking branch]
2019-02-04 08:42:19 -05:00
Jake Leonard
c532d4e15b Updating NetConnection, NetDriver and PacketHandlers to use FInternetAddrs. Moves address information to the base class instead of relying on it being created by derived classes.
#Jira: UENET-911, UENET-888, UENET-887
#rb: john.barrett, ryan.gerleve

[CL 4875396 by Jake Leonard in Dev-Networking branch]
2019-02-01 20:55:06 -05:00
Jake Leonard
411f29f794 Fix iOS build break due to missing cast qualifier
#JIRA: None
#rb: none
#rnx

[CL 4872483 by Jake Leonard in Dev-Networking branch]
2019-02-01 18:35:42 -05:00
rolando caloca
3dc3a37cc6 Unshelved from pending changelist '4864895':
[CODEREVIEW] rolando.caloca,jeff.williams

Merge conflict.
rolando.caloca, please merge this change by hand.
More info at https://robomerge.epicgames.net#FORTNITE

/src/robomerge_ue4_main_01/Engine/Source/Runtime/RHI/Public/RHICommandList.h - merging //Fortnite/Dev-EngineMerge/Engine/Source/Runtime/RHI/Public/RHICommandList.h#6


--------------------------------------
FN - Some RHIs don't have support for FRHICopyTextureInfo::NumMips yet
#rb none
[CODEREVIEW] Michael.Dupuis
#rnx

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: rolando.caloca
#ROBOMERGE-SOURCE: CL 4859824 via CL 4864762 via CL 4865689
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4865700 by rolando caloca in Dev-Networking branch]
2019-02-01 09:53:57 -05:00
martin ridgers
6bd4ca2086 Keep the page executable when patching SetConsoleCtrlCHandler to prevent access vioations on other threads whose instruction pointers are in kernel32.dll's text segment.
#rb Yuriy.ODonnell

(peafour-eddy of //UE4/Dev-Core/[at]4864689 by Martin.Ridgers)

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: martin.ridgers
#ROBOMERGE-SOURCE: CL 4865510 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4865522 by martin ridgers in Dev-Networking branch]
2019-02-01 09:40:18 -05:00
david harvey
e1b0ccc83a Trimming out unused FramePro function
#rb anthony.bills

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: david.harvey
#ROBOMERGE-SOURCE: CL 4859776 via CL 4864756 via CL 4864865
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4865161 by david harvey in Dev-Networking branch]
2019-02-01 09:29:42 -05:00
anthony bills
38fd676ac1 Pass down the shader format FName to IShaderFormat::NotifyShaderCooked
- Some platforms have multiple sub formats per IShaderFormat

#rb david.harvey
[FYI] luke.thatcher

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: anthony.bills
#ROBOMERGE-SOURCE: CL 4859289 via CL 4863633 via CL 4864171
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4864211 by anthony bills in Dev-Networking branch]
2019-02-01 07:50:22 -05:00
ben marsh
bae1e02719 Update version in Main to 4.23.
#rb none

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 4862715 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4863329 by ben marsh in Dev-Networking branch]
2019-02-01 05:55:29 -05:00
krzysztof narkowicz
705958d6f6 Removed unnecessary flush inside cascade shadow map rendering.
#rb none
#jira none
#rnx

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: krzysztof.narkowicz
#ROBOMERGE-SOURCE: CL 4860862 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4863245 by krzysztof narkowicz in Dev-Networking branch]
2019-02-01 05:51:58 -05:00
ryan gerleve
f3be613426 Fix merge conflicts.
--------------------------------------
Copying //UE4/Dev-Online to Dev-Main (//UE4/Dev-Main)
Source: //UE4/Dev-Online 4860295

#rb none

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: michael.kirzinger
#ROBOMERGE-SOURCE: CL 4860323 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4860452 by ryan gerleve in Dev-Networking branch]
2019-01-31 15:36:12 -05:00
josh adams
da6a4b9ce1 - Fixed copyright date
#okforgitub public
#jira UE-69384
#rb trivial

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: josh.adams
#ROBOMERGE-SOURCE: CL 4859777 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4859785 by josh adams in Dev-Networking branch]
2019-01-31 13:07:12 -05:00
andrew grant
2a870c2110 Changed cook check about landscape verts into a warning.
#rb michael.dupries

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 4858087 via CL 4858088 via CL 4858869 via CL 4859003
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4859625 by andrew grant in Dev-Networking branch]
2019-01-31 12:49:30 -05:00
james hopkin
14f0a02126 #json Added Num accessors for dom builder
#rb none

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: james.hopkin
#ROBOMERGE-SOURCE: CL 4857951 via CL 4858351 via CL 4858991
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4859612 by james hopkin in Dev-Networking branch]
2019-01-31 12:48:40 -05:00
krzysztof narkowicz
31dcc0591c Fixed FMeshDrawSingleShaderBindings static analysis warning.
#rb none
#jira UE-69378

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: krzysztof.narkowicz
#ROBOMERGE-SOURCE: CL 4858284 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4859608 by krzysztof narkowicz in Dev-Networking branch]
2019-01-31 12:47:38 -05:00
krzysztof narkowicz
6fd04e9b31 Fixed ComputeDynamicMeshRelevance conditions.
#jira UE-69380
#rb none

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: krzysztof.narkowicz
#ROBOMERGE-SOURCE: CL 4858162 in //UE4/Main/...
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 4859607 by krzysztof narkowicz in Dev-Networking branch]
2019-01-31 12:47:37 -05:00