Commit Graph

19038 Commits

Author SHA1 Message Date
nick darnell
899e70569f Stopping the slate debugger should stop the slate debugger.
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 5296313 via CL 5296316 via CL 5306895 via CL 5306994
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5322942 by nick darnell in Dev-Anim branch]
2019-03-06 18:05:11 -05:00
dan hertzka
e962269616 Defaulting URichTextBlock's visibility to SelfHitTestInvisible
#rb Nick.Darnell

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: dan.hertzka
#ROBOMERGE-SOURCE: CL 5295921 via CL 5295922 via CL 5306587 via CL 5306686
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5322333 by dan hertzka in Dev-Anim branch]
2019-03-06 18:02:52 -05:00
marc audy
d5232114b6 Dynamic Multicast delegates can now specify that their storage be stored in a sparse allocation for delegates that are expected to be bound rarely. The memory usage of an unbound sparse delegate is 1 byte instead of 16 bytes (for the empty array), however, a bound sparse delegate will have access overhead to retrieve the invocation list from the sparse object annotation.
The definition of the delegate type must specify the class and property name of the delegate that will use it and the type cannot be used outside of that context or just on the stack.
UMulticastDelegateProperty is now abstract and has 2 subclasses (UMulticastDelegateInlineProperty and UMulticastDelegateSparseProperty). The SparseProperty SignatureFunction will be a USparseDelegateFunction.
The sparse delegates do not work correctly with the python bindings at this point, but this will be visited soon.
#rb Michael.Noland
#jira

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5295832 via CL 5306530 via CL 5306657
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5322213 by marc audy in Dev-Anim branch]
2019-03-06 18:02:30 -05:00
jian ru
6a9a45a668 Mark FTexture2DMipMap::FCompactByteBulkData::GetFilename as deleted to better convey intention
#rb none

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: jian.ru
#ROBOMERGE-SOURCE: CL 5295514 via CL 5306295 via CL 5306390
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5321750 by jian ru in Dev-Anim branch]
2019-03-06 18:00:49 -05:00
jian ru
3d14913c42 Trim FTexture2DMipMap in cooked builds
#jira
[FYI] Pete.Sauerbrei, Uriel.Doyon, Chris.Bunner

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: jian.ru
#ROBOMERGE-SOURCE: CL 5294379 via CL 5305959 via CL 5306033
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5321187 by jian ru in Dev-Anim branch]
2019-03-06 17:58:22 -05:00
dmitriy dyomin
8791444f23 Fixed the case where StaticMesh LightMapCoordinateIndex could go negative if mesh has stripped LOD data. Removed workoraund for negative LightMapCoordinateIndex.
[CODEREVIEW] jack.porter

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: dmitriy.dyomin
#ROBOMERGE-SOURCE: CL 5291350 via CL 5291351 via CL 5305690 via CL 5305733
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5320677 by dmitriy dyomin in Dev-Anim branch]
2019-03-06 17:54:16 -05:00
Helge Mathee
157f5167e4 Documentating "DocumentationPolicy" meta tag for inside ObjectMacros.h
#rb lina.halper

[CL 5312098 by Helge Mathee in Dev-Anim branch]
2019-03-06 08:29:36 -05:00
Helge Mathee
b710e6deec Updated KismetAnimationLibraryHeaders to conform with the latest UHT changes
#rb lina.halper

[CL 5312085 by Helge Mathee in Dev-Anim branch]
2019-03-06 08:20:59 -05:00
ben zeigler
0bda3c19a4 #jira UE-70578 Add new constructor for FScopedConditionalWorldSwitcher that allows explicitly setting a world to set GWorld to when ticking/handling events in PIE
Fix it so switching worlds via the scope correctly sets GPlayInEditorID, related to UE-59417
Add a scope switcher to ShooterGameInstance Tick as it's executed from FCoreTicker, outside the normal world tick. It needs to be outside worldtick because it handles map transfer and other things that are not safe to do during world tick.
#rb marc.audy

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.zeigler
#ROBOMERGE-SOURCE: CL 5289149 in //UE4/Release-4.22/... via CL 5296692
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5308738 by ben zeigler in Dev-Anim branch]
2019-03-05 18:35:40 -05:00
mark satterthwaite
9187a3f0e9 RHIs need frames in order to handle all their book-keeping - even when debugging a blueprint - without this they will live-leak memory into their internal pools.
#rb none
#jira UE-69956

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: mark.satterthwaite
#ROBOMERGE-SOURCE: CL 5288951 in //UE4/Release-4.22/... via CL 5296687
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5308694 by mark satterthwaite in Dev-Anim branch]
2019-03-05 18:35:18 -05:00
mark satterthwaite
3a3b006a18 Setting a compute shader in MetalRHI should not affect the graphics tessellation state or we'll fail to go down the proper DrawPatches rendering path and ultimately assert on a missing PrologueEncoder.
#jira UE-69738
#rb none

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: mark.satterthwaite
#ROBOMERGE-SOURCE: CL 5288511 in //UE4/Release-4.22/... via CL 5296684
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5308686 by mark satterthwaite in Dev-Anim branch]
2019-03-05 18:35:16 -05:00
krzysztof narkowicz
115b9a18b2 Fixed crashes when overriding material parameters. Every texture or parameter override was needlessly recreating uniform expression uniform buffer, which may be referenced by cached mesh draw commands. Now it is done only when required, so only when uniform buffer layout will change. This also allowed to back-out CL 4751942 "Fix for UE-68218. Crash altering material's scalar values" and similar fixes.
#jira UE-70868, UE-70833
#rb Daniel.Wright

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: krzysztof.narkowicz
#ROBOMERGE-SOURCE: CL 5288494 in //UE4/Release-4.22/... via CL 5296498
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5308670 by krzysztof narkowicz in Dev-Anim branch]
2019-03-05 18:35:12 -05:00
nick darnell
373b892698 Fixing main compile issue.
#jira UE-71002
#rb none

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 5295869 in //UE4/Main/...
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5303783 by nick darnell in Dev-Anim branch]
2019-03-05 15:40:21 -05:00
aaron mcleran
098deb27e5 Removing check which was invalid.
#rb Ethan.Geller

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 5290877 via CL 5290879 via CL 5295136 via CL 5295199
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5303288 by aaron mcleran in Dev-Anim branch]
2019-03-05 15:37:16 -05:00
zak middleton
8f2444a87c #ue4 - Improve jump consistency over varied framerates on the frame when the jump force ends and we transition to applying gravity.
We have a portion of the time at constant speed then a portion with constant acceleration due to gravity, and those need to be separated.

[CODEREVIEW] Frank.Gigliotti

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: zak.middleton
#ROBOMERGE-SOURCE: CL 5290785 via CL 5290800 via CL 5294926 via CL 5295079
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5303170 by zak middleton in Dev-Anim branch]
2019-03-05 15:36:44 -05:00
aaron mcleran
e97db7567b Fix for reverb on console/surround sound systems.
- Fix is to allow quad reverb channel flipping to be enabled via cvar.

#rb Ethan.Geller

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 5290606 via CL 5290607 via CL 5294883 via CL 5294965
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5302903 by aaron mcleran in Dev-Anim branch]
2019-03-05 15:35:06 -05:00
rob gay
45e593b5f0 Fix for hotfix dynamic volume not working with new audio mixer
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 5290398 via CL 5294662 via CL 5294775
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5302468 by rob gay in Dev-Anim branch]
2019-03-05 15:32:43 -05:00
allan bentham
af9a0e89ac Fix comments somehow lost during merge
#jira UE-70963
#rb none

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: allan.bentham
#ROBOMERGE-SOURCE: CL 5294300 in //UE4/Main/...
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5302006 by allan bentham in Dev-Anim branch]
2019-03-05 15:30:46 -05:00
nick darnell
7060960a31 Speculative fix to this crash, but taking 2 main approaches,
1) Attempt to remove the widget sooner than end play, it's possible something is happening when we unload assets that leaves live widgets that haven't been torn down yet in a bad state.
2) The remove code looks like it could suffer from re-entrant code problems where a widget component might remove and then might attempt to remove again, adding a temporary copy step to keep the memory alive, then immediately remove it, then actually remove it from the screen, so that any downstream code attempting to remove again would be thwarted.

#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 5288912 via CL 5288916 via CL 5293701 via CL 5293802
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5300939 by nick darnell in Dev-Anim branch]
2019-03-05 15:25:59 -05:00
peter knepley
22335b1a60 Fix tag hash being vulnerable to FName casing issues between client and server
[FYI] Bob.Tellez

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: peter.knepley
#ROBOMERGE-SOURCE: CL 5288863 via CL 5288864 via CL 5293666 via CL 5293788
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5300884 by peter knepley in Dev-Anim branch]
2019-03-05 15:25:43 -05:00
david nikdel
e916116989 Adding helpful GetField and SetField methods to FJsonDataBag
#JIRA: none

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: david.nikdel
#ROBOMERGE-SOURCE: CL 5287286 via CL 5287288 via CL 5293035 via CL 5293142
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5299923 by david nikdel in Dev-Anim branch]
2019-03-05 15:21:40 -05:00
jason petersohn
8de4e6d14b Fixed warning on deprecated Pauser variable being Replicated but not in GetLifetimeReplicatedProps
#rnx
[CODEREVIEW] david.hamm, dan.kaufman, bob.tellez

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: jason.petersohn
#ROBOMERGE-SOURCE: CL 5286325 via CL 5292715 via CL 5292822
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5299205 by jason petersohn in Dev-Anim branch]
2019-03-05 15:18:30 -05:00
stephen holmes
ff390659ed Work to provide ConditionalPopulateNavOctreeActor Delgate for the Nav System.
[at]Mieszko.Zielinski

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: stephen.holmes
#ROBOMERGE-SOURCE: CL 5284289 via CL 5284389 via CL 5292468 via CL 5292570
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5298881 by stephen holmes in Dev-Anim branch]
2019-03-05 15:16:32 -05:00
andriy tylychko
62b01950d2 fixed TMediaObjectPool::Num(): it's a const method that lock a mutex inside. To make it compilable the mutex should be mutable
#rb:rex.hill
#jira:none

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: andriy.tylychko
#ROBOMERGE-SOURCE: CL 5282425 via CL 5282428 via CL 5292187 via CL 5292306
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5298455 by andriy tylychko in Dev-Anim branch]
2019-03-05 15:14:29 -05:00
aaron mcleran
ecb867108c Fixing initialization order warning.
#rb none

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 5275962 via CL 5275963 via CL 5292022 via CL 5292052
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5297830 by aaron mcleran in Dev-Anim branch]
2019-03-05 15:10:21 -05:00