Commit Graph

37 Commits

Author SHA1 Message Date
Helge Mathee
57e8a49d69 Control Rig: Refactor CopyOp to contain all required information for a copy
Also fixes UE-115756

#rb sara.schvartzman
#jira na

[CL 16354335 by Helge Mathee in ue5-main branch]
2021-05-17 12:35:41 -04:00
Helge Mathee
e4b9b30fb4 Control Rig: Improving debug watches
* watches now no longer crash with Mannequin Control Rig
* watches no longer disappear after recompile
* watches work on formerly optimized out nodes
* watches work within collapse nodes and functions

#rb sara.schvartzman
#jira na

[CL 16327158 by Helge Mathee in ue5-main branch]
2021-05-14 02:36:03 -04:00
sara schvartzman
624ea19f1e ControlRig: Adding local variables to CR graphs
#jira UE-110373
#rb helge.mathee

[CL 16281162 by sara schvartzman in ue5-main branch]
2021-05-11 17:13:58 -04:00
Helge Mathee
ba4f6f545d Control Rig VM Compiler - Don't create registers for Variables
#rb sara.schvartzman
#jira na

[CL 16156791 by Helge Mathee in ue5-main branch]
2021-04-29 09:47:07 -04:00
Helge Mathee
3afc8b83ea Control Rig: Moving debug memory to its own container
#rb sara.schvartzman
#jira na, Control Rig Debugging Work

[CL 16155492 by Helge Mathee in ue5-main branch]
2021-04-29 05:02:50 -04:00
Helge Mathee
4cf6dc7f35 Control Rig: Variable Remapping
#rb sara.schvartzman, jack.cai
#jira UEA-564

[CL 16122169 by Helge Mathee in ue5-main branch]
2021-04-27 03:19:42 -04:00
Helge Mathee
02c478ba4b Control Rig: Avoid undo / redo during compilation. Improve RemoveExpressions performance within AST Parser
#rb sara.schvartzman
#jira UE-113260

[CL 15990888 by Helge Mathee in ue5-main branch]
2021-04-13 12:03:23 -04:00
Helge Mathee
d3cb2516f6 Control Rig: Follow up on orphan pins: Ensure to only setup orphan pins during postload and avoid compilation of invalid graphs
#jira FROST-1844
#rb na

[CL 15946315 by Helge Mathee in ue5-main branch]
2021-04-07 17:24:36 -04:00
Helge Mathee
534665507f Control Rig: Orphan pin functionality for RigVM
#jira UEA-564
#rb jack.cai

[CL 15942963 by Helge Mathee in ue5-main branch]
2021-04-07 13:09:20 -04:00
sara schvartzman
d511013a98 Control Rig: Watch variables overriding expresion to operand map
#jira UE-102323
#rb helge.mathee

[CL 15888724 by sara schvartzman in ue5-main branch]
2021-04-01 09:40:45 -04:00
sara schvartzman
662a226b3c ControlRig: Fix watches not working for functions and collapsed nodes.
#jira UE-110041
#rb helge.mathee

[CL 15877909 by sara schvartzman in ue5-main branch]
2021-03-31 13:16:23 -04:00
sara schvartzman
cee997e004 ControlRig: Revert changes breaking unit tests.
#jira UE-110041
#rb na

[CL 15865012 by sara schvartzman in ue5-main branch]
2021-03-30 13:37:49 -04:00
Helge Mathee
5ae0239dfa Control Rig: Fix automation test around RigVM Compiler Array Array Link
#rb na
#jira UE-111976
#fyi sara.schvartzman

[CL 15862009 by Helge Mathee in ue5-main branch]
2021-03-30 10:21:09 -04:00
sara schvartzman
bb333535d4 ControlRig: Fix watches not working for functions and collapsed nodes.
#jira UE-110041
#rb helge.mathee

[CL 15748441 by sara schvartzman in ue5-main branch]
2021-03-19 12:43:05 -04:00
Helge Mathee
a0a8e3b5aa Control Rig: Services around introspection of run counts
#rb sara.schvartzman
#jira UEA-564

[CL 15746088 by Helge Mathee in ue5-main branch]
2021-03-19 06:35:50 -04:00
Helge Mathee
305fe5e166 Control Rig: Move instruction index lookup from a per-node field to a 1-n map. 1 instruction can represent 1 node, but 1 node can represent multiple instructions.
This fixes the labels on the execution stack for nested nodes.
Also fixes the cross selection issues between the stack and the graph views.
Finally also implements the "focus on selection" feature, which will now open the right tab and focus on the selected nodes.

#rb jack.cai
#jira na

[CL 15201429 by Helge Mathee in ue5-main branch]
2021-01-26 04:06:19 -04:00
Helge Mathee
2cf10865a6 Control Rig: Support for error reporting from AST parser all the way up to the Blueprint / Editor
#jira UEA-564
#rb audit
#fyi jack.cai

[CL 15134925 by Helge Mathee in ue5-main branch]
2021-01-19 07:26:41 -04:00
Helge Mathee
e04ec93397 Control Rig: Move default override infrastructure to also support Bound variable paths (and more stuff in the future)
Adapting the AST parser and compiler to deal with variable bindings on encapsulated nodes

#rb jack.cai
#jira UEA-564

[CL 15134612 by Helge Mathee in ue5-main branch]
2021-01-19 04:57:43 -04:00
Helge Mathee
61a6c148ee Control Rig: Encapsulation support for the rigvm compiler
#rb jack.cai
#jira UEA-564

[CL 15048039 by Helge Mathee in ue5-main branch]
2021-01-12 06:47:41 -04:00
jack cai
698f3b295f Control Rig: Added value string validation for setting pin default values + unit tests
#jira UE-97718

#rb helge.mathee

[CL 14939670 by jack cai in ue5-main branch]
2020-12-16 12:11:20 -04:00
Helge Mathee
d59fb33465 Control Rig variables aren't showing the correct values
The issue here is that we copy the source operand to target - where the source operand might actually be on a sub pin. We need to make sure to remove the registeroffset from the operand used for the debug register - since we only allow debug copies on the root of each register.

#rb jack.cai
#jira UE-102323

Merging

//UE4/Release-4.26/Engine/Source/Developer/RigVMDeveloper/Private/RigVMCompiler/RigVMCompiler.cpp

to //UE5/Main/Engine/Source/Developer/RigVMDeveloper/Private/RigVMCompiler/RigVMCompiler.cpp

[CL 14931406 by Helge Mathee in ue5-main branch]
2020-12-15 11:39:01 -04:00
Helge Mathee
057007d906 Control Rig variables aren't showing the correct values
The issue here is that we copy the source operand to target - where the source operand might actually be on a sub pin. We need to make sure to remove the registeroffset from the operand used for the debug register - since we only allow debug copies on the root of each register.

#rb jack.cai
#jira UE-102323

Merging

//UE4/Release-4.26/Engine/Source/Developer/RigVMDeveloper/Private/RigVMCompiler/RigVMCompiler.cpp

to //UE5/Main/Engine/Source/Developer/RigVMDeveloper/Private/RigVMCompiler/RigVMCompiler.cpp

[CL 14931362 by Helge Mathee in ue5-main branch]
2020-12-15 11:37:17 -04:00
Helge Mathee
e8e75d44ba Control Rig: Use the node path on the RigVMNode for the uniqueness of register paths
#jira UEA-564
#rb na

[CL 14869924 by Helge Mathee in ue5-main branch]
2020-12-07 11:12:11 -04:00
jack cai
5dfa6fc8d2 RigVM: Minor fixes for bugs found during nativization research
1. Select node's "IntEquals" operand should not be a literal since it stores the result of a runtime comparison
2. Register.CppType now renamed to Register.BaseCppType since it does not include TArray prefix for array type.
3. Added a few missed accessor/convertor functions for rig vm data types

#rb helge.mathee
#jira none

[CL 14855110 by jack cai in ue5-main branch]
2020-12-04 11:37:54 -04:00
Helge Mathee
7cca9cc7d7 Control Rig: Compiler to support node instruction markup for Collapse nodes
#jira UEA-564
#rb na

[CL 14853394 by Helge Mathee in ue5-main branch]
2020-12-04 05:57:00 -04:00