Commit Graph

37 Commits

Author SHA1 Message Date
mike zyracki
7d43c5e7c2 Sequencer: Constraints Fix redo constraint deletion due to the ordering of the modifies for the transform section and it's constraint object, and make sure constraint manager also undo's correctly and is reflected in the widget.
#jira UE-163621
#rb benoit.gadreau
#preflight 6328ac33f87253e021d14168

[CL 22087317 by mike zyracki in ue5-main branch]
2022-09-19 22:25:48 -04:00
benoit gadreau
5c8ff9a00f ensure that both constraint and target tick functions belong to the same world when setting up dependencies
#jira UE-163837
#rb mike.zyracki
#preflight 632889a01c7511917a92aea9

[CL 22087011 by benoit gadreau in ue5-main branch]
2022-09-19 21:56:58 -04:00
benoit gadreau
f374b6c2cd fixed dynamic behavior for scale constraints
+ manage look at properties visibility

#jira UE-163614
#rb none
#preflight 6324957ef258fccf98c45648

[FYI] mike.zyracki

[CL 22054541 by benoit gadreau in ue5-main branch]
2022-09-16 13:54:39 -04:00
benoit gadreau
b6be52d474 ensure that actors and constraints are safe to use
#jira UE-161958
#rb trivial
#preflight 63234cc4c225e8be38042ec2

[CL 22038462 by benoit gadreau in ue5-main branch]
2022-09-15 17:10:46 -04:00
benoit gadreau
65a4ef8bd2 Constraints improvements:
- register component handle delegates on post load
    - evaluate all constraints when compensating to make sure things are up to date

#jira none
#rb mike.zyracki
#preflight 63234b515a44869a7dfaeeec

[CL 22038451 by benoit gadreau in ue5-main branch]
2022-09-15 17:10:08 -04:00
mike zyracki
e01aea1667 Constraints: Componensate All works with components, unify evaluation code all into compensation evaluation code to also be used by baker, make sure everyhing ticks while baking.
#jira UE-163358
#jira UE-162149
#rb benoit.gadreau
#preflight 632144479677b738f4c0d8ba

[CL 21999938 by mike zyracki in ue5-main branch]
2022-09-14 00:25:25 -04:00
bryan sefcik
07894f4a07 Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631a717cec45fbf3d74d4ba7

[CL 21916033 by bryan sefcik in ue5-main branch]
2022-09-09 00:53:22 -04:00
bryan sefcik
cb0456c6d4 Cleaned up build.cs files by removing any include paths that were already being added by UBT. This was done to help identify how include paths are being added and to help with future refactoring.
#jira
#preflight 631a5c04967ffc68fbf0dd8f

[CL 21911226 by bryan sefcik in ue5-main branch]
2022-09-08 21:44:02 -04:00
benoit gadreau
6963920ecf fixed unacceptable words
#jira none
#preflight skip
#rb trivial

[CL 21845334 by benoit gadreau in ue5-main branch]
2022-09-07 05:10:36 -04:00
benoit gadreau
a5bf2bc1cd Constraints:
- Look for possible prerequisite if any when the constraint's parent can't tick (static meshes for instance). In a context of adding several constraints, we want to make sure that the evaluation order is the right one
- use the ControlRig dependency map to check for dependencies between controls
- display all constraints in sorted order when the constraints actoor is selected


#jira UE-162813, UE-153568
#rb mike.zyracki
#preflight 631756b7ab25bb91f5f5045d

[CL 21845001 by benoit gadreau in ue5-main branch]
2022-09-07 04:45:39 -04:00
Mike Zyracki
be0cb2cfcb Cosntraints: Fix Baking so that A) All constraint keys are turned off B) -1 keys are removed C) it's undoable. Also added some Modifies to the manager when adding/removing to help with undo/redo issues.
#jira UE-162590
#rb Benoit.Gadreau
#preflight 6312782eab25bb91f5a12e24

[CL 21770173 by Mike Zyracki in ue5-main branch]
2022-09-02 19:22:30 -04:00
benoit gadreau
ac22ac4fa4 fixed log message when trying to create a cycle
#jira UE-153568
#rb none
#preflight 6310d10b4d54e9a683461ab3

[CL 21756614 by benoit gadreau in ue5-main branch]
2022-09-02 03:56:13 -04:00
benoit gadreau
42c1944d1f use the controller when removing constraints to ensure it's propagated
#jira UE-162142
#rb mike.zyracki
#preflight 6310bba97e5b5908116f3d20

[CL 21756472 by benoit gadreau in ue5-main branch]
2022-09-02 03:27:02 -04:00
benoit gadreau
2d685d4c80 Constraints:
- notification from control rig bound to a new object to ensure that handles and constraints are up to date
- enable keyframe in constraint space
- ensure we exit sequencer silent mode


#jira UE-161762
#rb mike.zyracki
#preflight 630c8e9ba416f6df25aa3cfe

[CL 21681383 by benoit gadreau in ue5-main branch]
2022-08-29 12:52:16 -04:00
Mike Zyracki
7affeb9b1c Constraints: Fix Undo Issue with Component constraints and fix regression with compensation happening twice do to the wrong componensation guard being used.
#jira na
#preflight 6305505fa45b007ea28a4e89
#rb Benoit.Gadreau

[CL 21524397 by Mike Zyracki in ue5-main branch]
2022-08-23 19:08:52 -04:00
benoit gadreau
90e2075511 Constraints:
- socket based component handle to be able to constrain to bones/sockets
- disabled scale for parent constraints by default
- auto expand constraint view when creating a new constraint
- check for direct dependencies (hierarchy) between handles before creating constraints

#jira na
#rb mike.zyracki
#preflight 6304a67eae13a5a098d8e372

[CL 21504158 by benoit gadreau in ue5-main branch]
2022-08-23 06:24:41 -04:00
benoit gadreau
f65e4f1dd3 Add undoable support for constraints
#jira UE-159833
#rb mike.zyracki
#preflight 62fe499d3752f9dd44246922

[CL 21455552 by benoit gadreau in ue5-main branch]
2022-08-19 07:23:25 -04:00
Mike Zyracki
bda9e41e3f Sequencer: Consraints: Add/Move/Delete constraint keys for transform tracks
Main change was to move code out of ConstraintChannelHelper to a new MovieSceneConstraintChannelHelper so that we can use the same functions for add/delete/move for both TransformableHandle types. It would have been better perhaps to keep this in control rig plugin, it would have made things much easier, but the Sequencer architecture limits us to only one track editor per track type so we had to move code into the transform track editor, which meant moving functionality to MovieSceneTools module. but do to this I had to add some modularity which means less code duplication. In particularly
Added an Interface IMovieSceneConstrainedSection, to handle accessing contraint channels. Also moved getting channels and setting transforms to the TransfomableHandles. Both of these changes will make moving more things like compensentation to runtime if needed later. Also added a snapper fix for sub sections
#jira UE-143510
#robomerge FNMain
#preflight 62f81e49b66d5d93134784f8
#rb Benoit.Gadreau

[CL 21407789 by Mike Zyracki in ue5-main branch]
2022-08-16 13:02:21 -04:00
benoit gadreau
c4996e6327 delegates implementation for active keys move/deletion and channel deletion so that child's transform keys are compensated
#jira none
#rb mike.zyracki
#preflight 62d90b98110da0f9449bb359

#robomerge FNMain

[CL 21199938 by benoit gadreau in ue5-main branch]
2022-07-21 09:22:18 -04:00
Bryan sefcik
b4a6e947d8 Ran IWYU on Public headers under Engine/Source/Runtime/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21065896 by bryan.sefcik
#preflight 62d4b1a5a6141b6adfb0c892
#jira

#ROBOMERGE-OWNER: Bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21150156 via CL 21151754 via CL 21154719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
#ROBOMERGE-CONFLICT from-shelf

[CL 21181076 by Bryan sefcik in ue5-main branch]
2022-07-20 11:31:36 -04:00
benoit gadreau
99ab461493 make sure that the constraint ticks before the child if the both parent and child tick functions are the same (e.i. two controls controling the same skeletal mesh)
#jira UE-159534, UE-153573
#rb mike.zyracki
#preflight 62d16522af68cd745b702b55


#robomerge FNMain

[CL 21143907 by benoit gadreau in ue5-main branch]
2022-07-18 04:52:10 -04:00
benoit gadreau
dd6b6cd563 removed useless dynamic offsets and added editable conditions for offset properties
#jira none
#rb mike.zyracki
#preflight 62ced9b7d00f3c208e4839b3

#robomerge FNMain

[CL 21107366 by benoit gadreau in ue5-main branch]
2022-07-15 04:58:43 -04:00
benoit gadreau
3600d14c67 - Label improvements to display constraint's type and parent in editor
- avoid creating handles for certain controls

#jira UE-157458
#rb mike.zyracki
#preflight 62c86155230ad2aa3095ccd0

[CL 21009972 by benoit gadreau in ue5-main branch]
2022-07-08 13:16:16 -04:00
Mike Zyracki
9771008042 Constraints: Refactor constraint channels out of MovieScene and ControlRig and into Constraint. Note still need to create a ConstraintEditor plugin to move the ConstraintChannelEditor code out of MovieSceneTools but wanted to get this in asap.
#jira na
#rb Benoit.Gadreau
#preflight 62c5150d2f2d046918d6794f

[CL 20969379 by Mike Zyracki in ue5-main branch]
2022-07-06 13:49:40 -04:00
benoit gadreau
b4d9995de7 Constraints in Sequencer:
- dynamic behavior or parent constraints so that child transform in constraint space can be dynamically changed over time.
- transform compensation when changing child transforms
- Aim constraint: dynamic look-at axis and input roll

to be discussed: this has to be done for scene components as well once the constraint channel available thru sequencer

#jira na
#rb mike.zyracki
#preflight 62c459ceb47aed4cf1a2a889

[CL 20944281 by benoit gadreau in ue5-main branch]
2022-07-05 12:44:47 -04:00