Commit Graph

89 Commits

Author SHA1 Message Date
marc audy
3feb7411d2 Workaround linux compiler failing to expand out nested UE_LOG_REF/CLINKAGE when NO_LOGGING is true and there are no parameters to the log message
#horde 214762
#rnx

[CL 22089158 by marc audy in ue5-main branch]
2022-09-20 02:31:34 -04:00
Bryan sefcik
b4a6e947d8 Ran IWYU on Public headers under Engine/Source/Runtime/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21065896 by bryan.sefcik
#preflight 62d4b1a5a6141b6adfb0c892
#jira

#ROBOMERGE-OWNER: Bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21150156 via CL 21151754 via CL 21154719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
#ROBOMERGE-CONFLICT from-shelf

[CL 21181076 by Bryan sefcik in ue5-main branch]
2022-07-20 11:31:36 -04:00
ronald koppers
12979e53c2 FMessageLog::CriticalError has been deprecated.
FMessageLog::CriticalError has a delay before throwing an assert to allow compositing of the message. As a result the assert isn't thrown at the location of the problem, but somewhere in the surrounding area, which makes the problem harder to debug and generates misleading log entries. Due to these problems FMessageLog::CriticalError and EMessageSeverity::CriticalError have been deprecated. It's recommended to use checkf instead.

When FMessageLog goes out of scope or is destroyed explicitly it will flush its messages to the log, which in turn means the log may immediately use the messages. In a few places a reference to the message was kept that outlived the lifetime of the owning FMessageLog in order to add arguments later on. The found cases have been updated to make sure FMessageLog doesn't outlive the addition of the arguments so the arguments are correctly passed to the log.

#jira: UE-155605
#rb brooke.hubert francis.hurteau jerome.delattre
#preflight 62cc4fca9922f7e5129e4e0a

[CL 21042765 by ronald koppers in ue5-main branch]
2022-07-11 12:58:26 -04:00
bryan sefcik
7b41b28df3 Moved forward decl to get around IncludeTool issue.
#preflight 62c754a6b3789302b1b873a0

[CL 20994535 by bryan sefcik in ue5-main branch]
2022-07-07 18:24:36 -04:00
bryan sefcik
a9cc65bca4 Updated Core code to not use CoreMinimal.h when possible.
Core public headers still will contain CoreMinimal.h if any included it before my IWYU changes.
#preflight 62c73594756222ced4e48707

[CL 20991367 by bryan sefcik in ue5-main branch]
2022-07-07 16:02:19 -04:00
bryan sefcik
13f4c9daac Ran IWYU again after fixing some IWYU mapping issues.
#preflight 62c71b3ab3789302b1a0818b

[CL 20987904 by bryan sefcik in ue5-main branch]
2022-07-07 14:01:46 -04:00
bryan sefcik
9905eb52bb Pass 2 on running IWYU on Core.
Things to note regarding this pass:
* No includes are currently being removed from public headers.
* Any private file that has a #if is currently not being updated.
#preflight 62c703bbd13fac04f11da948

[CL 20985655 by bryan sefcik in ue5-main branch]
2022-07-07 12:30:11 -04:00
bryan sefcik
62489fe2b3 Ran a pass of IWYU on Core.
Things to note regarding this pass:
* No includes are currently being removed from public headers.
* Any private file that has a #if is currently not being updated.

#rb Devin Doucette and Marc Audy
#preflight 62c62086756222ced497ff95
#preflight 62c626d12f2d04691814d331
#preflight 62c630107e606620fdd64e31
#preflight 62c635c6756222ced49a13cf

[CL 20979027 by bryan sefcik in ue5-main branch]
2022-07-06 21:44:18 -04:00
steve robb
dbe6f4a18d Allow formatting strings to be binary-compatible char types, not only exact types.
#jira UE-132142
#rb devin.doucette
#preflight 62bd5018a3568e30662ad3b4

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20890364 via CL 20890433 via CL 20890478
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20892157 by steve robb in ue5-main branch]
2022-06-30 07:58:27 -04:00
steve robb
5943a5cdae UE_SECURITY_LOG deprecated and fixed to work in UTF-8 mode.
CLOSE_CONNECTION_DUE_TO_SECURITY_VIOLATION deprecated.

#rb ryan.gerleve
#preflight 62b5a20cb822fb9c11a7a983

#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20828653 via CL 20828657 via CL 20828660
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20828972 by steve robb in ue5-main branch]
2022-06-27 07:17:14 -04:00
Devin Doucette
cd9a0ac867 Logging: Fixed the use of FORCENOINLINE and UE_DEBUG_SECTION for logging and assertions
Since DispatchCheckVerify is already FORCENOINLINE, the use of it on the lambdas causes DispatchCheckVerify to be act as an additional and unnecessary wrapper.

#preflight 62ab81cfe9031caf98b27e6c
#rb Zousar.Shaker

[CL 20694514 by Devin Doucette in ue5-main branch]
2022-06-16 16:32:07 -04:00
ionut matasaru
29e7e89d3b LogTrace: Workaround for crash in TRACE_LOG_MESSAGE when encounters string arguments not null-terminated (Added and enabled LOGTRACE_RUNTIME_FORMATTING_ENABLED which traces the log messages already preformatted).
#rb Johan.Berg
#preflight 62a34bb7b0150a87f9f04641

[CL 20598673 by ionut matasaru in ue5-main branch]
2022-06-10 13:04:33 -04:00
jorgenpt
af8a301d4a PR #8891: TokenizedMessage: Move exported symbols to .cpp (Contributed by jorgenpt)
Also used the opportunity to convert from MakeShareable to MakeShared.

#jira UE-142104
#preflight 627ec6b70f72dc21c7e13a93
#rb Steve.Robb

[CL 20223845 by jorgenpt in ue5-main branch]
2022-05-16 10:21:43 -04:00
johan berg
b44c0346eb Define log categories even in NO_LOGGING configurations.
#rb devin.doucette
#preflight 61e7e49d3f00a0a23e02ec63

#ROBOMERGE-AUTHOR: johan.berg
#ROBOMERGE-SOURCE: CL 18656252 in //UE5/Release-5.0/... via CL 18656269 via CL 18656271
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18656275 by johan berg in ue5-main branch]
2022-01-19 05:34:02 -05:00
halfdan ingvarsson
c103d87c31 Fix non-unity builds due to missing <Misc/Guid.h> include.
#jira none
#preflight trivial

#ROBOMERGE-AUTHOR: halfdan.ingvarsson
#ROBOMERGE-SOURCE: CL 18653238 in //UE5/Release-5.0/... via CL 18653252 via CL 18653270
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18653284 by halfdan ingvarsson in ue5-main branch]
2022-01-18 20:00:57 -05:00
patrick enfedaque
819bde9b19 New FActorToken for message logs that contains information to select loaded or unloaded actors
original code contributed by: The Coalition

#rb richard.malo, jeanfrancois.dube
#preflight 61e6f268b56c33b8ecef210e

#ROBOMERGE-AUTHOR: patrick.enfedaque
#ROBOMERGE-SOURCE: CL 18642284 in //UE5/Release-5.0/... via CL 18642299 via CL 18642303
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18642316 by patrick enfedaque in ue5-main branch]
2022-01-18 12:54:01 -05:00
geoff evans
2d8e221bf1 Check GIgnoreDebugger for assert system debug break
Add command line arg to set GIgnoreDebugger
Remove GIgnoreDebugger from UE_BUILD_SHIPPING
Fix up naming convention and deprecate _DebugBreakAndPromptForRemote

=== Notes ===

Sometimes it's useful to run a process with a debugger attached, but knowing you get the same behavior as if it weren't, including how the assert system behaves

Such situations include:
* Tight timing of assert and exceptions in different threads
* When rarely reproducable ensure()s fire before or between breakpoints set in the debugger

=== Hashtags ===

#jira none
#rb steve.robb
#preflight 6182e64d924922000186366e

[CL 18045343 by geoff evans in ue5-main branch]
2021-11-03 22:09:24 -04:00
aurel cordonnier
34f55d3a4a Merge from Release-Engine-Test @ 17946149 to UE5/Main
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17949667 by aurel cordonnier in ue5-main branch]
2021-10-27 15:14:40 -04:00
Stefan Boberg
e0fb0cfce3 Added opt-in printf format string validation for logging macros (currently implemented for MSVC only)
To opt in, please define the UE_VALIDATE_FORMAT_STRINGS macro to 1

#rb steve.robb

[CL 17689137 by Stefan Boberg in ue5-main branch]
2021-10-01 04:09:22 -04:00
sara schvartzman
8f8de89f24 Fix clear page not clearing the currently viewed page in MessageLog
#jira UE-129593
#rb halfdan.ingvarsson
#preflight 615458864751730001f8eb86
#robomerge 5.0

[CL 17674725 by sara schvartzman in ue5-main branch]
2021-09-30 05:08:32 -04:00
aurel cordonnier
1ee4eed9aa Merge from Release-Engine-Test @ 17666640 to UE5/Main
This represents UE4/Main @17638339 and Dev-PerfTest @17636504

[CL 17668579 by aurel cordonnier in ue5-main branch]
2021-09-29 17:45:16 -04:00
aurel cordonnier
e3f7878676 Merge from Release-Engine-Test @ 17462327 to UE5/Main
This represents UE4/Main @17430120 and Dev-PerfTest @17437669

[CL 17463546 by aurel cordonnier in ue5-main branch]
2021-09-08 16:42:26 -04:00
sara schvartzman
2901e7ccbd Control Rig: Python commands output to different message log pages depending on the blueprint
#jira UE-119792
#rb helge.mathee

[CL 16968244 by sara schvartzman in ue5-main branch]
2021-07-27 09:58:53 -04:00
Michael Noland
6284d812b4 Fixing non-unity issue with missing include/forward decl for FString in LogVerbosity
(horde# 85342)
#rnx

[CL 16834580 by Michael Noland in ue5-main branch]
2021-07-12 22:43:15 -04:00
Michael Noland
12c4b10e37 Core: Made the verbosity of the unintialized reflected property check configurable via ini
- Issues with UObject* properties are upgraded from Warning to Error
- Other types remain the same for both engine and project modules (Display), but engine will soon change to Error as well

Settings can be overridden for either project or engine modules in DefaultEngine.ini (engine defaults are in BaseEngine.ini), e.g.,

[CoreUObject.UninitializedScriptStructMembersCheck]
EngineModuleReflectedUninitializedPropertyVerbosity=Error
ProjectModuleReflectedUninitializedPropertyVerbosity=Warning

#rb marc.audy

[CL 16826159 by Michael Noland in ue5-main branch]
2021-07-12 11:49:03 -04:00