Johan Berg
570f495f32
[Insights] Change cbor return type to UTF8StringView
...
Unreal Trace Server now writes full UTF8 strings to the CBOR objects, change the corresponding string views to `FUtf8StringView` to support correct conversion to TCHAR based strings.
#rb ionut.matasaru
#jira UE-155288
#robomerge EngineMerge
#preflight 62bedf2eb024a2608c81d044
[CL 20913058 by Johan Berg in ue5-main branch]
2022-07-01 07:53:53 -04:00
Johan Berg
7a928530a2
Fix CIS errors on Mac
...
#rb none
#preflight 624c4d54683a7dd323b02e7d
[CL 19625055 by Johan Berg in ue5-main branch]
2022-04-05 10:37:43 -04:00
Catalin Dragoiu
04455f4b88
Fix Mac compile error.
...
#rb trivial
#preflight 6218b02b8849a7424f7f7740
[CL 19143970 by Catalin Dragoiu in ue5-main branch]
2022-02-25 05:35:44 -05:00
Catalin Dragoiu
828042a563
[Insights] Fix trace list not refreshing MAC
...
#jira UE-137793
#preflight 62178f9f1a114ad504399e8d
#rb Ionut.Matasaru Johan Berg
[CL 19143744 by Catalin Dragoiu in ue5-main branch]
2022-02-25 04:53:37 -05:00
Catalin Dragoiu
2e1ff374d1
[Insights] Fix trace list not refresing when adding or deleting trace files on Linux.
...
#jira UE-137793
#rb Ionut.Matasaru Johan.Berg
#preflight 6214ba2f9e2201e21403e22c
[CL 19070550 by Catalin Dragoiu in ue5-main branch]
2022-02-22 05:54:56 -05:00
Martin Ridgers
54d117c581
Restrict trace store client to only resolve IPv4 addresses. Previously the resolve would look up IPv6 addresses for the given host leading to stalls.
...
#rb jb
#rnx
[CL 17443422 by Martin Ridgers in ue5-main branch]
2021-09-07 08:32:03 -04:00
Martin Ridgers
822c99f7f6
Shifted the store frontend to another port so as to avoid collision with old-school Unreal Insightses.
...
#rnx
[CL 16603796 by Martin Ridgers in ue5-main branch]
2021-06-09 08:50:18 -04:00
Martin Ridgers
7c160ebaa3
Tweaked the trace store client/server protocol to be more HTTP-like.
...
#rb honk
#rnx
[CL 16602541 by Martin Ridgers in ue5-main branch]
2021-06-09 07:01:48 -04:00
Martin Ridgers
e75bd655f6
Add accessor for the "store_dir" field of the trace store's /v1/status response.
...
[CL 16544497 by Martin Ridgers in ue5-main branch]
2021-06-03 03:34:33 -04:00
Martin Ridgers
49726ba2ae
Include the trace store's local filesystem location in the /v1/status response.
...
[CL 16544451 by Martin Ridgers in ue5-main branch]
2021-06-03 03:22:21 -04:00
Martin Ridgers
18f8df19ed
Bumped a port number one step too early.
...
[CL 16509004 by Martin Ridgers in ue5-main branch]
2021-05-31 09:51:47 -04:00
Martin Ridgers
5be4185e2a
Versioned the end points that the trace store server and client communicate over. This will be useful as I shift to running the trace store in a separate process who's lifetime I've less control over.
...
[CL 16508945 by Martin Ridgers in ue5-main branch]
2021-05-31 09:38:07 -04:00
Steve Robb
1f3fe8c9ac
Some ANSICHAR/UTF8CHAR cast fixes for upcoming changes to StringConv.h.
...
#rb none
#jira none
[CL 16469364 by Steve Robb in ue5-main branch]
2021-05-26 10:45:12 -04:00
Martin Ridgers
5cfc74ed00
Specifying the port that the Trace Store client should connect is now optional.
...
#rb jb
#rnx
[CL 16467361 by Martin Ridgers in ue5-main branch]
2021-05-26 08:25:39 -04:00
Martin Ridgers
4bf9cfa79a
Call select() on a socket before making a blocking call to recv(). Calls to recv() that are waiting for data may not return even if the socket is closed. This can result in a technical hang where Insights waits on Trace waiting on a socket that was closed. This way we only call recv() when we know there is data to read, and the select()+timeout combo correctly detects to the close().
...
#rb Catalin.Dragoiu
#rnx
[CL 16364807 by Martin Ridgers in ue5-main branch]
2021-05-18 04:24:57 -04:00
Martin Ridgers
be972be826
Moved the Trace namespace into the UE namespace.
...
#rb jb
#rnx
[CL 14762673 by Martin Ridgers in ue5-main branch]
2020-11-17 06:54:28 -04:00
Martin Ridgers
1d420c9d7b
Expose active trace sessions' control port via the Trace Store.
...
#rb jb
#rnx
[CL 14750314 by Martin Ridgers in ue5-main branch]
2020-11-16 04:31:03 -04:00
Martin Ridgers
71cc29d19a
Fixed MSVC static analysis warnings from a Windows SDK header.
...
#rb trivial
#rnx
[CL 14744174 by Martin Ridgers in ue5-main branch]
2020-11-13 10:09:34 -04:00
Martin Ridgers
8a6a773e17
Trace data is a stream and communication is one way. It is implemented this way to share code between sending trace data over the wire and writing it to a file. Because there's no ping/pong we can end up with a half-open TCP connection if the other end doesn't close its socket. So we'll enable keep-alive on the socket and set a short timeout (default is 2hrs).
...
[CL 14733648 by Martin Ridgers in ue5-main branch]
2020-11-12 10:07:23 -04:00
Marc Audy
11f5b21210
Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
...
#rnx
[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
martin ridgers
3b724a0c2f
Made the sockets that the trace store client creates uninheritable
...
#rb none
#jira ue-91015
#ushell-cherrypick of 12106008 by Martin.Ridgers
#ROBOMERGE-SOURCE: CL 12386981 in //UE4/Release-4.25/... via CL 12386982
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v671-12333473)
[CL 12386984 by martin ridgers in Main branch]
2020-03-24 06:20:59 -04:00
Martin Ridgers
bcda0febbe
Cancel the timeout tick when accepting a connection to read trace data from a relay. Otherwise the timeout fires causing an extra read, the loss of a page of trace data, and eventually a segfault or assert.
...
#rb jb
#rnx
#jira ue-88376
#ushell-cherrypick of 11302806 by Martin.Ridgers
[CL 11303311 by Martin Ridgers in Main branch]
2020-02-10 08:55:35 -05:00
Martin Ridgers
cfd65a404f
Always attempt to cancel a timer regardless of the owning FAsioTickable's state. Without this it isn't possible to cancel one-shot ticks.
...
#rb jb
#rnx
#jira ue-88376
#ushell-cherrypick of 11302796 by Martin.Ridgers
[CL 11303303 by Martin Ridgers in Main branch]
2020-02-10 08:53:23 -05:00
Stefan Boberg
55a8b15f1f
Copying //UE4/Dev-Core to Main (//UE4/Main)
...
#rb none
[CL 11258477 by Stefan Boberg in Main branch]
2020-02-05 14:26:36 -05:00
Martin Ridgers
75ebb9e56a
Prevent listening sockets from being inherited by child processes. See 11152126 for details.
...
#rb none
#rnx
[CL 11153119 by Martin Ridgers in Dev-Core branch]
2020-01-29 04:13:59 -05:00