Commit Graph

84 Commits

Author SHA1 Message Date
elliot colp
33c85ce6b0 [RemoteControl] Fix crash when client disconnects mid-transaction
#jira UE-164256
#rb Alejandro.Arango
#preflight 6328971eea1c94f4c5e694cb

[CL 22087065 by elliot colp in ue5-main branch]
2022-09-19 21:58:05 -04:00
robert millar
e6857190f2 Updating collection manager interface to use FSoftObjectPath for the paths of assets and objects rather than FName.
#jira UE-161932
#rb julien.stjean
#preflight https://horde.devtools.epicgames.com/job/6324e773f258fccf98de78cf

[CL 22064625 by robert millar in ue5-main branch]
2022-09-16 20:57:34 -04:00
elliot colp
5e6549713e [EpicStageApp] Disable Stage App beacon unless the WebSocket server is running
#jira UE-163343
#rb Alejandro.Arango
#preflight 632229798838676d1057c6b3

[CL 22018644 by elliot colp in ue5-main branch]
2022-09-14 18:22:36 -04:00
Elliot Colp
c6e87912b4 [EpicStageApp] Fix stage app failing to control nDisplay nodes when connected directly
#jira UE-161370
#rb Alejandro.Arango, Jeremie.Roy
#preflight 6308f989987e7155b1add7b1
#preflight 630911ffed56f9e6dbe3c7f4

[CL 21596518 by Elliot Colp in ue5-main branch]
2022-08-26 15:25:15 -04:00
Zousar Shaker
3f4252aa56 ObjectPtr upgrade for engine plugins used from UnrealEditor -allmodules. Automated upgrade process.
#rb none
#preflight 62fe7f270601ad0504910c30

[CL 21447894 by Zousar Shaker in ue5-main branch]
2022-08-18 15:08:49 -04:00
Elliot Colp
f4dbabd0b8 [EpicStageApp][WebRemoteControl] Fix cases where a transaction could be cancelled but fail to report to subscribers
#jira UE-156394
#rb Alejandro.Arango
#preflight 62fd28b087319bacfb16607e

[CL 21427682 by Elliot Colp in ue5-main branch]
2022-08-17 13:48:28 -04:00
jamie dale
a84ca6fb32 Moved some object-centric transaction APIs out of Core and into CoreUObject
The following types have moved to ITransactionObjectAnnotation.h:
- ITransactionObjectAnnotation

The following types have moved to TransactionObjectEvent.h:
- FTransactionObjectDeltaChange
- ETransactionObjectEventType
- FTransactionObjectEvent
- FTransactionDiff

#preflight 62f141b7086f90bbc473f631, 62f1351a904c243122f5eacd
#rb Francis.Hurteau, Rex.Hill

#ROBOMERGE-OWNER: jamie.dale
#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 21272390 via CL 21285937 via CL 21285973 via CL 21286088
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21290425 by jamie dale in ue5-main branch]
2022-08-09 12:16:06 -04:00
steve robb
4cafa69f6a Misc direct FTCHARToUTF8_Convert usage replaced with StringCast or FPlatformString.
#rb devin.doucette
#jira UE-132142
#preflight 62bf8c181c0b75879792c9b5

#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20925918 via CL 20925919 via CL 20925920
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20926016 by steve robb in ue5-main branch]
2022-07-02 09:05:41 -04:00
steve robb
1b2a6972d9 Undo //Fortnite/Main/... changelist 20912148
#rb none

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20912525 via CL 20912560 via CL 20912561
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20913042 by steve robb in ue5-main branch]
2022-07-01 07:49:36 -04:00
steve robb
39ffa82638 Direct FTCHARToUTF8_Convert usage deprecated and replaced with StringCast or FPlatformString.
#rb devin.doucette
#jira UE-132142
#preflight 62bd92d71c0b758797185071

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20912148 via CL 20912242 via CL 20912250
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20913038 by steve robb in ue5-main branch]
2022-07-01 07:49:22 -04:00
jeremie roy
1f790162e2 Change check to ensure until we can reproduce
#rb simon.therriault
#preflight 62b0b7aede510ae06e5decec
#jira UE-156554

[CL 20756619 by jeremie roy in ue5-main branch]
2022-06-21 09:27:48 -04:00
Matt Chapman
d617dced5e Missing include added.
#jira UE-156993
#rb trivial
#preflight 62ac96205d5264997e1d6a03
#preflight 62ac96205d5264997e1d6a03

[CL 20703742 by Matt Chapman in ue5-main branch]
2022-06-17 11:11:12 -04:00
evan kinney
b125fd52fe optionally fail to get a valid HttpRouter if we fail to bind/start listening on the given port, modify callers to request this behavior if it's clear they expected it to behave this way, and allow listener sockets to reuse addresses/ports when binding
#rnx
#rb brian.bekich, jake.champlin

#ROBOMERGE-AUTHOR: evan.kinney
#ROBOMERGE-SOURCE: CL 20695650 via CL 20695677 via CL 20695883 via CL 20695924
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v968-20684695)

[CL 20697322 by evan kinney in ue5-main branch]
2022-06-16 19:07:59 -04:00
Matt Chapman
cd4cfcd8d0 Static analysis issue with Engine/Plugins/VirtualProduction/RemoteControl/Source/WebRemoteControl/Private/WebSocketMessageHandler.cpp
#jira UE-156841
#rb Simon.Therriault
#preflight 62ab41eb5c69124c40841018
#preflight 62ab41eb5c69124c40841018

[CL 20687951 by Matt Chapman in ue5-main branch]
2022-06-16 11:32:10 -04:00
Matt Chapman
f891d6366e Update to allow remote control presets to exist within other assets and toolkit hosts (not level editor.)
#jira none
#rb jeremie.roy
#preflight 62aa4871da0af39a475a0b65

[CL 20677397 by Matt Chapman in ue5-main branch]
2022-06-15 17:50:19 -04:00
Denys Dubinin
9f5ce23bde [UE-156705] Quality of Life upgrades for Logic UI
Featuring:

* Rename Controller [UE-156717] - Provides ability to rename Controllers via API support and Rename UI command.

* Controllers Table - header & resizing support

~~~

[Rename Controller]

Functional notes:
* Provides rename via F2 key (UI command). Rename via RMB Context Menu wiill be part of a subsequent CL.
* Web API has been updated in this CL to support using the user-friendly Controller name (renamed by users as desired) rather than the internal proprety name (which is currently immutable, see impl notes below)

Impl notes:
* Added a new property DisplayName to VirtualProperty class to support specifiying user frienedly Controller Names.
* I deemed this preferrable to modifying the underlying PropertyBag description because that approach will reallocate memory for all the Controllers each time the user tries to rename even just one. This is due to the way PropertyBag is designed (each collection of properties is conidered as a unique type with a specific hash value.The entire set is reallocated if any modification is made to the property bag).

[Controllers Table]
* Used Header Rows for automatic resizing
* Preferred over using manual splitter (as in EP list), no issues noted thusfar
#preflight 62a9e27962552c58ff1a3401

[CL 20669482 by Denys Dubinin in ue5-main branch]
2022-06-15 10:11:39 -04:00
Elliot Colp
1d4f299a33 [WebRemoteControl] WebSocket API for generating DisplayCluster previews
#jira: UE-141883
#rb: Alejandro.Arango
#preflight 62a0e5f7593ebacf17dd4053

[CL 20562205 by Elliot Colp in ue5-main branch]
2022-06-08 15:11:48 -04:00
Denys Dubinin
44f104bcb7 ~ Remote Control Logic Web API ~
UE-155855

For manipulating Controllers through HTTP requests

The following routes have been added:

1. SetPresetController - Set the value of a Controller (on a Remote Control Preset asset).
  HTTP Parameters: Preset Name, Controller Name, Body: JSON;
   Example:
  (PUT) http://127.0.0.1:30010/remote/preset/PresetNameParam/controller/SomeBoolController
  Body (raw JSON):  { "PropertyValue": false}

2. GetPresetController - Fetch the value of a Controller (on a Remote Control Preset asset).
  HTTP Parameters: Preset Name, Controller Name, Body: None
   Example:
  (GET) http://127.0.0.1:30010/remote/preset/PresetNameParam/controller/SomeBoolController
  HTTP Response:  { "PropertyValue": false}

Interception support has been provided as well by adding an nDispaly cluster implementation.

Pending work:
Unit tests for new route handlers to be added to RemoteControlIntereceptionTest.cpp. Review will be updated with this.
#preflight 62a0cca0232daff7b3f55c21

[CL 20559126 by Denys Dubinin in ue5-main branch]
2022-06-08 12:57:13 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Marc Audy
f9445fed38 Initialize TransactionIds
#jira UE-153291
#codreview Elliot.Colp
#rnx
#preflight

[CL 20376151 by Marc Audy in ue5-main branch]
2022-05-26 00:50:44 -04:00
Elliot Colp
5dd755610e [WebRemoteControl] Move manual transaction timeout to a CVar
#jira: UE-151340
#rb: Alejandro.Arango
#preflight 6288165a7e018d20dc195123

[CL 20304652 by Elliot Colp in ue5-main branch]
2022-05-20 18:44:31 -04:00
Elliot Colp
e0a67fef06 [WebRemoteControl] Don't mix together struct fields when sending property updates
#jira: UE-151340
#rb: Alejandro.Arango, Jeremie.Roy
#preflight 6287ca731e478b95c729b852

[CL 20299104 by Elliot Colp in ue5-main branch]
2022-05-20 14:04:44 -04:00
Elliot Colp
39825987c5 [WebRemoteControl] Add WebSocket routes to control when transactions are created
#jira: UE-151340
#rb: Alejandro.Arango
#preflight 6286d359cf5ac7317c494b5a

[CL 20289121 by Elliot Colp in ue5-main branch]
2022-05-19 19:41:12 -04:00
Elliot Colp
9d7db4bdb1 [WebRemoteControl] Send property update messages for the same type as a single batch
Remove tracked actors when world is destroyed and ignore tracking for actors outside the current editor world
#jira: UE-151340
#rb: Alejandro.Arango, Jeremie.Roy
#preflight 62853fac882a1e5cd78f6ee3

[CL 20266375 by Elliot Colp in ue5-main branch]
2022-05-18 15:18:41 -04:00
Elliot Colp
eef6986449 [EpicStageApp] Control lightcard color from app
#jira: UE-141884
#rb: Alejandro.Arango
#preflight 62697595d575958d55350727

[CL 19943049 by Elliot Colp in ue5-main branch]
2022-04-27 13:46:15 -04:00