Commit Graph

69 Commits

Author SHA1 Message Date
geoffrey douglas
92eabd07a2 [CameraCalibration] Fix lens component to properly detect livelink roles that derive from the camera role
#jira UE-164481
#rb simon.therriault
#preflight 632a2a34fc7f1efbdf5e0420

[CL 22105330 by geoffrey douglas in ue5-main branch]
2022-09-20 19:34:53 -04:00
Robert Millar
c9a159a7dd FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for VirtualProduction.

#jira UE-161932
#rb Simon.Therriault,Alejandro.Arango
#preflight 631a6229a60c539c98ab815e

[CL 21905662 by Robert Millar in ue5-main branch]
2022-09-08 18:15:24 -04:00
bryan sefcik
02ff8ad64b Added more LLM tags to VP code.
Renamed some of the tags to use the correct plugin name for the parent.

#jira UE-155581, UE-155579, UE-155438, and UE-155469
#preflight 63127922a20b67673b883746

[CL 21769125 by bryan sefcik in ue5-main branch]
2022-09-02 18:34:25 -04:00
Geoffrey Douglas
7d534b0e98 [CameraCalibration] Add "display unit" setting and use it in the "add point" dialog to let users enter focal length and image center in mm, pixels, or normalized.
#jira UE-159566
#rb simon.therriault, jeremie.roy
#preflight 6312137ce05f2c40c575b745

[CL 21759507 by Geoffrey Douglas in ue5-main branch]
2022-09-02 10:55:46 -04:00
Zousar Shaker
3f4252aa56 ObjectPtr upgrade for engine plugins used from UnrealEditor -allmodules. Automated upgrade process.
#rb none
#preflight 62fe7f270601ad0504910c30

[CL 21447894 by Zousar Shaker in ue5-main branch]
2022-08-18 15:08:49 -04:00
George Rolfe
b7d662f24e CameraCalibrationCore automation test category changed to "Plugin"
#jira none
#rb geoffrey.douglas
#preflight 62de09f0185da2495fd733d5

[CL 21235280 by George Rolfe in ue5-main branch]
2022-07-24 23:47:18 -04:00
Geoffrey Douglas
aba73b1380 [CameraCalibration] Fix focal length evaluation in LensComponent. Fixes bug where distortion could not be disabled properly on playback, and bug where override LensFile's focal length was not evaluated on playback.
Also, fix a bug where changing the distortion source to "Lens File" did not automatically update the lens model, leading to distortion not being properly applied.
#rb simon.therriault
#preflight 62d9b6cb185da2495f54b9bf

[CL 21209592 by Geoffrey Douglas in ue5-main branch]
2022-07-21 16:50:55 -04:00
Geoffrey Douglas
6306b45993 Fix CIS issue with duplicate macro definition
#rb none
#preflight none

[CL 21094077 by Geoffrey Douglas in ue5-main branch]
2022-07-14 13:58:51 -04:00
Geoffrey Douglas
340cb9c676 [CameraCalibration] Fix uninitialized distortion displacement maps caused by materials not being compiled in time for the first draw
#rb simon.therriault
#preflight 62cf2020d45d5be7f1b05bed

[CL 21079080 by Geoffrey Douglas in ue5-main branch]
2022-07-13 16:09:44 -04:00
Geoffrey Douglas
39e6961760 [CameraCalibration] Add custom track recorder for LensComponent to support caching the LensFile, the LensFile evaluation inputs, and the distortion state (parameters and intrinsics), in order to properly support evaluation and application of distortion on playback of a level sequence.
#jira UE-155866
#jira UE-155867
#rb simon.therriault
#preflight 62cf0a4c471a2c288623f9e1

[CL 21077668 by Geoffrey Douglas in ue5-main branch]
2022-07-13 15:04:36 -04:00
Geoffrey Douglas
a049ee681b [CameraCalibration] Centralize lens distortion evaluation to the Lens Component
Deprecate LensDistortionHandlerPicker structure
Remove LensDistortionHandlers from the CameraCalibrationSubsystem
Update Composure to use a component picker to choose a LensComponent that has distortion data
Remove lens distortion evaluation from LiveLink camera and lens controllers
#rb simon.therriault, jeremie.roy
#jira UE-153109
#preflight 62cf04a7d00f3c208e4c4d55

[CL 21075928 by Geoffrey Douglas in ue5-main branch]
2022-07-13 14:07:38 -04:00
zach bethel
34623f0321 Replaced thread-local MemStack with ConcurrentLinearAllocator across the renderer.
- Removed scene render mem-mark among others. MemStack usage is now restricted to local scopes with known marks.
 - Render resources with destructors are allocated using the FSceneRenderingBulkObjectAllocator on FSceneRenderer, which is deleted when the scene render is.

#preflight 62b266e20d4d6228de97babe
#rb mihnea.balta, yuriy.odonnell

[CL 20907647 by zach bethel in ue5-main branch]
2022-06-30 19:55:24 -04:00
eric mcdaniel
f788616fed Some shader compilation warning cleanup
- addressing misc warnings but primarily type ambiguity on bit operations and vector truncation

- testing
  - cooked and ran EngineTest on Win64 and select console platforms

#rb David.Harvey
#jira none
#preflight skip, NA
#rnx

[CL 20830609 by eric mcdaniel in ue5-main branch]
2022-06-27 10:34:25 -04:00
geoffrey douglas
fe0e0c634e Fix improper order of lerp arguments in LensFile evaluation
#jira UE-157485
#preflight 62b49daece64aeefefb99fbe
#rb jeremie.roy
#lockdown simon.tourangeau

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 20797482 in //UE5/Release-5.0/... via CL 20799555
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20801165 by geoffrey douglas in ue5-main branch]
2022-06-23 16:29:33 -04:00
Geoffrey Douglas
d8a155aeb4 Update nodal offset algos to check the lens component to determine whether nodal offset was being applied during a calibration
#jira UE-147582
#preflight 62a371dbb0150a87f9f59549
#rb simon.therriault

[CL 20598787 by Geoffrey Douglas in ue5-main branch]
2022-06-10 13:11:34 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Geoffrey Douglas
7d3985da84 Centralize application of nodal offset to LensComponent, removing all references to nodal offset from the LiveLink camera controller
#jira UE-153107
#jira UE-146118
#rb simon.therriault
#preflight 628fe02174630984fd4eb26a

[CL 20385271 by Geoffrey Douglas in ue5-main branch]
2022-05-26 16:49:09 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
Geoffrey Douglas
9f1a9bf6d5 Rename LensDistortionComponent to LensComponent and move from CameraCalibration plugin to CameraCalibrationCore plugin
Remove CameraCalibration module from CameraCalibration plugin
#rb simon.therriault
#preflight 62840673114e08fa2f3d59a8

[CL 20250823 by Geoffrey Douglas in ue5-main branch]
2022-05-17 17:04:38 -04:00
Jurre deBaare
631bec320b Moved RichCurve evaluation code from RichCurve.cpp to separate file and consolidated all instances of copy-pasta behaviour
#jira none
#rb Mike.Zyracki
#preflight 627cd946e97f57bf6cc98b8a

[CL 20162602 by Jurre deBaare in ue5-main branch]
2022-05-12 06:08:53 -04:00
geoffrey douglas
6b56d8c32f Fix camera calibration producing NANs on Vulkan
#jira UE-142731
#rb simon.therriault
#preflight 620e6a2f242ff267d4734926
#lockdown alejandro.arango

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 19060582 in //UE5/Release-5.0/... via CL 19078444
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19121449 by geoffrey douglas in ue5-main branch]
2022-02-24 14:36:33 -05:00
geoffrey douglas
5b25666102 Properly initialize ImageDimensions script struct member
#jira UE-140884
#preflight 61faa58d1a71e1f04e92ff5e
#lockdown cristina.riveron
#rb simon.therriault

#ROBOMERGE-OWNER: geoffrey.douglas
#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18827623 in //UE5/Release-5.0/... via CL 18827793 via CL 18827887
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18827918 by geoffrey douglas in ue5-main branch]
2022-02-02 11:18:36 -05:00
andrew davidson
60a1fa84a7 Fix FVector2D variant casts - Plugins
Submitted on behalf of fred.kimberley
#rb andy.davidson
#preflight 61f86c4ca6632a34f35dfbca

#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18800855 in //UE5/Release-5.0/... via CL 18802061 via CL 18802724
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18810177 by andrew davidson in ue5-main branch]
2022-02-01 12:08:54 -05:00
Marc Audy
c43360f47c Eliminate whitespace only differences between Release-Engine-Staging and Release-Engine-Test
#[fyi] Aurel.Cordonnier

#ushell-cherrypick of 18448630 by Marc.Audy
#preflight none

[CL 18483677 by Marc Audy in ue5-main branch]
2021-12-17 03:41:59 -05:00
geoffrey douglas
c9dd4b72e0 Nodal offset calibration algorithm for finding the optical axis of the lens and the entrance pupil position that lies along that axis
#preflight 61ba60dd23741afd577080f5
#rb alejandro.arango

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18475255 in //UE5/Release-5.0/... via CL 18480663 via CL 18480758
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18480888 by geoffrey douglas in ue5-main branch]
2021-12-16 18:31:30 -05:00