Commit Graph

292 Commits

Author SHA1 Message Date
rob gay
57d0be3dd2 Missing recursive call to reset sync state in prior CL
#rb trivial
#jira none
#preflight 6323a1805f55ba280ed12b0f

[CL 22042427 by rob gay in ue5-main branch]
2022-09-15 20:11:13 -04:00
rob gay
31435d69a5 Fix bug with synchronization not being completed prior to validation for referenced MetaSound graphs
TLBSRA (Too long but still read anyway)
This was due to validation moving to recursive behavior but sync not to support bubbling up referenced errors/warnings in 5.1.  This resulted in missing members after interface transforms are applied and potentially hitting ensures in validation.
...
But wait there's more!!! Synchronization on tick is now more efficient as it doesn't attempt to resynchronize/validate references already synchronized/validated in prior pass in same frame due to referencing graph needing to sync

#rb helen.yang
#rnx
#jira UE-162586
#preflight 63223e6c29254beccbf06119

[CL 22019580 by rob gay in ue5-main branch]
2022-09-14 18:49:46 -04:00
rob gay
e6a69d94c8 Set invalid controller's default access type to unset
#rb trivial
#jira none
#rnx
#preflight skip

[CL 21997854 by rob gay in ue5-main branch]
2022-09-13 21:51:42 -04:00
rob gay
7c89cca430 Fix missing rerouted implicit accessor behavior causing various bugs with constructor pins
#rb helen.yang
#rnx
#jira UE-163090
#preflight 6320d96829254beccb80dc36

[CL 21997851 by rob gay in ue5-main branch]
2022-09-13 21:51:22 -04:00
rob gay
2c38378951 - Fix doubleclick to add connected reroute not capturing full transaction
- Fix pasted reroute ed nodes not generating reroute template frontend node
- Fix for "promote to" transactions not capturing graph changes
#rb helen.yang
#jira UE-162560
#jira UE-161233
#jira UE-147944
#rnx
#preflight 631fac6a575e11cd2a6ffe70

[CL 21985212 by rob gay in ue5-main branch]
2022-09-13 12:30:44 -04:00
robert millar
aa6e458004 FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for Metasound.

#jira UE-161932
#rb none
#preflight https://horde.devtools.epicgames.com/job/631f7da6a9331c69c3aa4ac5

[CL 21976387 by robert millar in ue5-main branch]
2022-09-12 19:52:49 -04:00
rob gay
3698d480b1 Fix crash when no output is supplied on a reroute and user attempts undo
#jira UE-161229
#rnx
#rb trivial
#preflight skip

[CL 21927053 by rob gay in ue5-main branch]
2022-09-09 16:14:43 -04:00
rob gay
367eeb114e Fix for assetpath not being generated properly from displayed filepath indirectly in SGraphPinObject locations that attempt to extract short display name from the pin's DefaultValue
#rb phil.popp
#jira none
#rnx
#preflight skip

[CL 21910546 by rob gay in ue5-main branch]
2022-09-08 21:30:35 -04:00
helen yang
d14412ac5b Rename MetaSound cvars for consistency, fix typos
#jira none
#rb trivial
#preflight 630d758d556fc14dce5ad10c

[CL 21707153 by helen yang in ue5-main branch]
2022-08-30 15:11:11 -04:00
Aaron McLeran
5f08d51e97 Fix for static analysis include cycle
#fyi Rob.Gay
#jira none
#rb none
#preflight none

[CL 21463121 by Aaron McLeran in ue5-main branch]
2022-08-19 15:42:08 -04:00
Rob Gay
25826b9069 Summer Cleaning
- Rename MetasoundArchetype Source file to MetasoundFrontendInterface
- Move MetaSound interface files to subdirectory.
- Break out document versioning transforms to own impl/header
#rb todo
#rnx
#jira none
#preflight 62fed263200ff87e07d77340

[CL 21458865 by Rob Gay in ue5-main branch]
2022-08-19 12:14:31 -04:00
phil popp
5fc6f172c9 [MetaSound] Allow Constructor pin to be set from BP
#rb Rob.Gay
#jira UE-153913
#preflight 62fe6e68f7404b55a3fd49f9

[CL 21445924 by phil popp in ue5-main branch]
2022-08-18 13:55:13 -04:00
Rob Gay
92e6f6d708 Register data type as it is required to generate transmission channel to avoid ensure in editor
#rb trivial
#jira UE-149394
#rnx
#preflight skip

[CL 21434407 by Rob Gay in ue5-main branch]
2022-08-17 19:04:08 -04:00
Rob Gay
4427e326e4 Make AnalyzerAddress & GraphAnalyzerAddress real TransmissionAddress citizens
#rb phil.popp
#jira UE-149394
#rnx
#preflight 62fd6ff6086f90bbc482f1e7

[CL 21434257 by Rob Gay in ue5-main branch]
2022-08-17 19:01:34 -04:00
Rob Gay
9064ec60e0 Virtual call in ctor & rogue #pragma in impl fixes
#rb trivial
#jira none
#rnx
#preflight skip

[CL 21427438 by Rob Gay in ue5-main branch]
2022-08-17 13:34:02 -04:00
Rob Gay
2b17ace435 Node Template Preprocessor Updates
- Conform template build step nominclature to "Document Preprocessing" (as it may be used either directly before building or at time post serialization)
- Use new preprocessor to cache edge data for more performant reroute template processing
#rb phil.popp
#rnx
#jira UE-160476
#preflight 62fbe79fad3bd8ad645963ec

[CL 21413130 by Rob Gay in ue5-main branch]
2022-08-16 16:19:43 -04:00
phil popp
20d9fe84b6 MetaSound Source Surround Channel Format Support.
#rb Rob.Gay
#jira UE-150587
#preflight 62fa5557153b17e746323904

[CL 21386849 by phil popp in ue5-main branch]
2022-08-15 10:49:30 -04:00
Rob Gay
43065604d6 Rename UMetaSound to UMetaSoundPatch
#jira UE-150599
#rb helen.yang
#preflight 62f69d471e61d1ba0e8e37e5

[CL 21360370 by Rob Gay in ue5-main branch]
2022-08-12 14:54:54 -04:00
Rob Gay
d759aee3d7 MetaSound Reroute Nodes
- Minor play button/transport bar updates using new icons from RobbieK
- Validation Clean-up to better report final message severity state & accomidate template node validation (i.e. reroute validation & visual reporting/user feedback)
#rb helen.yang
#jira UE-150599
#rnx
#preflight 62f6949acf7afa018ba94144

[CL 21359529 by Rob Gay in ue5-main branch]
2022-08-12 14:22:05 -04:00
Rob Gay
b11e9b2c7c Minor error text fix-up (missed in prior CL)
#fyi helen.yang
#rb helen.yang
#jira none
#rnx
#preflight skip

[CL 21323383 by Rob Gay in ue5-main branch]
2022-08-10 14:52:01 -04:00
Rob Gay
87f810eadf MetaSound Template nodes
#rb phil.popp
#jira UE-160476
#preflight 62f3f49df75a2a539c8b4973

[CL 21322540 by Rob Gay in ue5-main branch]
2022-08-10 14:18:10 -04:00
UnrealBot
73409369c0 Branch snapshot for CL 21319338
[CL 21319338 in ue5-main branch]
2022-08-10 16:03:37 +00:00
Rob Gay
d9d184894a Minor FrontendRegistry Clean-up
#rb trivial
#jira none
#rnx
#preflight 62f14e55185da2495f7e3ee8

[CL 21272010 by Rob Gay in ue5-main branch]
2022-08-08 14:04:23 -04:00
helen yang
85f1f46cee Fix conditional for reconnecting connections when updating a MetaSound node version
#jira UE-159938
#jira UE-159940
#rb phil.popp
#preflight 62d75247185da2495fce054c
#rnx

[CL 21181052 by helen yang in ue5-main branch]
2022-07-20 11:30:34 -04:00
helen yang
abcf114f57 MetaSound Constructor pin editor-frontend integration checkpoint
- Both inputs and outputs can be constructor vertices, not just inputs
- Enforce connection and data type constraints for access types
- Prevent default value constructor value from being changed while playing
- Added cvar (default disabled) for enabling constructor pin option in editor

#jira UE-151661
#rb phil.popp
#preflight 62d59f4bf156340c79cfcbf5

[CL 21152841 by helen yang in ue5-main branch]
2022-07-18 17:14:25 -04:00