Commit Graph

286 Commits

Author SHA1 Message Date
sebastian nordgren
c4b81d8b75 Multi-line editable text boxes no longer call IPropertyUtilities::RequestRefresh() when adding or removing lines, which caused textboxes created in property row generators to fail to accept input past a single line.
This was a bug exposed because FPropertyRowGenerator previously ignored RequestRefresh() calls entirely, but now does a deferred refresh.

Since this was the only use of it, IEditableTextProperty and all its implementations have also had their RequestRefresh() methods removed.

[REVIEW] [at]jamie.dale, [at]vincent.gauthier
#preflight 632432a2cb23fcbbd8ef5dd2

[CL 22050354 by sebastian nordgren in ue5-main branch]
2022-09-16 11:35:06 -04:00
rob gay
9ff0d9869e Fix for alt-left clicking reroute nodes not being deleted
#rb helen.yang
#jira UE-161253
#rnx
#preflight 63225c5c506f1a33e0ea68b6

[CL 22023175 by rob gay in ue5-main branch]
2022-09-14 23:20:28 -04:00
rob gay
31435d69a5 Fix bug with synchronization not being completed prior to validation for referenced MetaSound graphs
TLBSRA (Too long but still read anyway)
This was due to validation moving to recursive behavior but sync not to support bubbling up referenced errors/warnings in 5.1.  This resulted in missing members after interface transforms are applied and potentially hitting ensures in validation.
...
But wait there's more!!! Synchronization on tick is now more efficient as it doesn't attempt to resynchronize/validate references already synchronized/validated in prior pass in same frame due to referencing graph needing to sync

#rb helen.yang
#rnx
#jira UE-162586
#preflight 63223e6c29254beccbf06119

[CL 22019580 by rob gay in ue5-main branch]
2022-09-14 18:49:46 -04:00
rob gay
7c89cca430 Fix missing rerouted implicit accessor behavior causing various bugs with constructor pins
#rb helen.yang
#rnx
#jira UE-163090
#preflight 6320d96829254beccb80dc36

[CL 21997851 by rob gay in ue5-main branch]
2022-09-13 21:51:22 -04:00
helen yang
3c0bfae228 Remove MetaSound delete node input pin context action, port emphasize graph connection color on hover functionality, clamp output/variable float literals
#jira UE-163144
#jira UE-163568
#jira UE-157781

#rb rob.gay
#preflight 6320a79929254beccb7124d5

[CL 21990872 by helen yang in ue5-main branch]
2022-09-13 15:56:26 -04:00
rob gay
2c38378951 - Fix doubleclick to add connected reroute not capturing full transaction
- Fix pasted reroute ed nodes not generating reroute template frontend node
- Fix for "promote to" transactions not capturing graph changes
#rb helen.yang
#jira UE-162560
#jira UE-161233
#jira UE-147944
#rnx
#preflight 631fac6a575e11cd2a6ffe70

[CL 21985212 by rob gay in ue5-main branch]
2022-09-13 12:30:44 -04:00
robert millar
aa6e458004 FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for Metasound.

#jira UE-161932
#rb none
#preflight https://horde.devtools.epicgames.com/job/631f7da6a9331c69c3aa4ac5

[CL 21976387 by robert millar in ue5-main branch]
2022-09-12 19:52:49 -04:00
rob gay
39b4c62e67 Fix for time pins not showing default value editor
#rb trivial
#rnx
#jira UE-161759
#preflight 631a7ab2f448dc6e58c9da73

[CL 21916030 by rob gay in ue5-main branch]
2022-09-09 00:52:58 -04:00
rob gay
7a7c3aa235 Fix adding/removing interfaces in editor transaction construction not being cached for duration of scope
- Add interface name to scoped transaction display text
#rb helen.yang
#jira UE-151448
#preflight 631a6112354826f8b381f6ab

[CL 21910559 by rob gay in ue5-main branch]
2022-09-08 21:30:48 -04:00
alfaroh corneyiii
228c580a44 Allow Attenuation Visualization for MetaSounds
#jira UE-124030
#rb rob.gay
#preflight 631a228d354826f8b36fd583

[CL 21897461 by alfaroh corneyiii in ue5-main branch]
2022-09-08 13:29:35 -04:00
Rob Gay
6a755ab901 Add editor setting to resample and apply window size ratio for MetaSound connection envelopes to be able to shorten or expand envelope history visually
#rb helen.yang
#jira UE-153987
#preflight 6318d435ab25bb91f533f676

[CL 21856251 by Rob Gay in ue5-main branch]
2022-09-07 13:45:43 -04:00
helen yang
d14412ac5b Rename MetaSound cvars for consistency, fix typos
#jira none
#rb trivial
#preflight 630d758d556fc14dce5ad10c

[CL 21707153 by helen yang in ue5-main branch]
2022-08-30 15:11:11 -04:00
helen yang
2a5ee75170 Retain Metasound literal default values when toggling constructor pin state, fix Metasound -> Metasound Patch editor setting name
#jira UE-162138
#jira UE-162148

#rb rob.gay
#preflight 630cda18a416f6df25b5d02d
#rnx

[CL 21687663 by helen yang in ue5-main branch]
2022-08-29 16:33:55 -04:00
sara schvartzman
eb18cf44f6 Prevent the MetaSound and Dataflow plugins from hijacking comment widget creation for other graph types
#jira UE-159764
#rb helen.yang
#preflight 630614815366f61a42b862f9

[CL 21561518 by sara schvartzman in ue5-main branch]
2022-08-25 06:28:40 -04:00
helen yang
474b9a98b6 MetaSound constructor pin tooltip clarification
#rb trivial
#preflight skip
#rnx

[CL 21522872 by helen yang in ue5-main branch]
2022-08-23 18:22:57 -04:00
alfaroh corneyiii
a30156092c Audio Telemetry Clean-Up
#rb rob.gay
#jira UE-159979
#preflight 63040b47c00af5e2940a0055

[CL 21497581 by alfaroh corneyiii in ue5-main branch]
2022-08-22 19:19:05 -04:00
Rob Gay
25826b9069 Summer Cleaning
- Rename MetasoundArchetype Source file to MetasoundFrontendInterface
- Move MetaSound interface files to subdirectory.
- Break out document versioning transforms to own impl/header
#rb todo
#rnx
#jira none
#preflight 62fed263200ff87e07d77340

[CL 21458865 by Rob Gay in ue5-main branch]
2022-08-19 12:14:31 -04:00
helen yang
e7764f0feb Remove cvar and unhide constructor pins from MetaSound editor
#rb trivial
#jira UE-151661
#preflight 62febf963c4417dcec218371

#rnx

[CL 21458268 by helen yang in ue5-main branch]
2022-08-19 11:39:24 -04:00
Rob Gay
bd01f5f864 More MetaSound pin category clean-up & object pin category for WT fix-up
#rb helen.yang
#jira UE-160802
#rnx
#preflight 62fd3145200ff87e0786ce69

[CL 21430207 by Rob Gay in ue5-main branch]
2022-08-17 15:35:39 -04:00
Rob Gay
6c335bca87 - Top align MS node inputs/outputs in editor unless titles hidden & only one member (ex. math nodes)
- Clean-up of more direct calls to MetaSoundStyle to use safe brush call
- Clean-up a few nodehandle spots that should be const
#rb trivial
#jira none
#rnx
#preflight 62fc0509f015056ce49c9b2d

[CL 21414797 by Rob Gay in ue5-main branch]
2022-08-16 17:21:16 -04:00
Rob Gay
b0e2e421c9 Add missing WaveTable dependencies to MS editor module
#rb trivial
#rnx
#jira none
#preflight skip

[CL 21396354 by Rob Gay in ue5-main branch]
2022-08-15 18:47:23 -04:00
Rob Gay
62ab7479cf Fix issue with MetaSound array constructable types that are not array types to use object pin color in editor
#rb helen.yang
#jira UE-160802
#rnx
#preflight 62faa91eae3edb54c9a4159c

[CL 21393953 by Rob Gay in ue5-main branch]
2022-08-15 16:58:56 -04:00
Rob Gay
2c8fc1464e Fix missing "patch" descriptor in loc text
#rb trivial
#jira UE-160922
#rnx
#preflight skip

[CL 21390487 by Rob Gay in ue5-main branch]
2022-08-15 14:19:33 -04:00
Rob Gay
36925da5fe Fix for duplicate LOC text strings
#rb trivial
#jira UE-160967
#rnx
#preflight skip

[CL 21387920 by Rob Gay in ue5-main branch]
2022-08-15 12:15:34 -04:00
Andrew Davidson
185d22b92c Fix include order issue
#preflight 62fa1622153b17e746270894

[CL 21384858 by Andrew Davidson in ue5-main branch]
2022-08-15 05:51:48 -04:00