Commit Graph

223 Commits

Author SHA1 Message Date
sara schvartzman
63ff8ec15a Control Rig: Fix crash in unit test ControlRig.Debug.PublicFunction
#jira na
#rb trivial
#preflight 6329f947f45b523a630ec0e8

[CL 22100359 by sara schvartzman in ue5-main branch]
2022-09-20 15:43:53 -04:00
sara schvartzman
27c4e76652 Control Rig: Fix GetDependentAssets returning AssetData referencing function references instead of the asset itself
#jira UE-164184
#rb benoit.gadreau
#preflight 63298ccb9840225da2544339

[CL 22094222 by sara schvartzman in ue5-main branch]
2022-09-20 11:35:43 -04:00
robert millar
1274ef50d3 FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for ControlRig.

#jira UE-161932
#rb Sara.Schvartzman
#preflight https://horde.devtools.epicgames.com/job/631f7ec5cd55825044fd1607

[CL 21984791 by robert millar in ue5-main branch]
2022-09-13 12:15:04 -04:00
bryan sefcik
7b9e5abbcc Pass 1 on plugins:
Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631b93c6967ffc68fb2c32df

[CL 21935609 by bryan sefcik in ue5-main branch]
2022-09-10 00:03:16 -04:00
bryan sefcik
cb0456c6d4 Cleaned up build.cs files by removing any include paths that were already being added by UBT. This was done to help identify how include paths are being added and to help with future refactoring.
#jira
#preflight 631a5c04967ffc68fbf0dd8f

[CL 21911226 by bryan sefcik in ue5-main branch]
2022-09-08 21:44:02 -04:00
sara schvartzman
7111ffcc47 Control Rig: Fix duplicating graph with aggregate graph breaking links
#jira UE-162447
#rb benoit.gadreau
#preflight 6318bc9b2b7fe03eb667debf

[CL 21885427 by sara schvartzman in ue5-main branch]
2022-09-08 04:35:36 -04:00
sara schvartzman
1aad416b7f Control Rig: Avoid dirtying assets on load when variables change from float/double
#rb jack.cai
#preflight 63176a44980179553e3d94f5

[CL 21862729 by sara schvartzman in ue5-main branch]
2022-09-07 17:12:35 -04:00
sara schvartzman
42b2218f15 Control Rig: Fix control rig nodes in some AnimBPs having multiple alpha pins
#rb jack.cai
#preflight 6310da2a4d54e9a68348b2a9

[CL 21759790 by sara schvartzman in ue5-main branch]
2022-09-02 11:16:33 -04:00
jack cai
70bc5b69f4 RigVMRegistry: Added support for user defined type addition and removal
Important notes:
1. We should now use TypeUtils::GetUniqueStructName  instead of struct->getstructcppname for type names used by the registry since user defined struct need to have unique names generated for them

2. We should be aware that we can have invalid permutations in templates when types are deleted, so make sure you check for typeindex != INDEX_NONE when looping over permutations

#jira UE-152930
#rb Sara.schvartzman, Benoit.gadreau, Halfdan.Ingvarsson
#preflight https://horde.devtools.epicgames.com/job/6310c6992a5406d810d5a0e8

[CL 21754534 by jack cai in ue5-main branch]
2022-09-01 23:33:24 -04:00
sara schvartzman
91f953bba3 Control Rig: Patch nodes referencing deprecated templates
#rb jack.cai, benoit.gadreau
#preflight 6305f47ba45b007ea29f9ec0

[CL 21543445 by sara schvartzman in ue5-main branch]
2022-08-24 12:42:35 -04:00
sara schvartzman
ab56a6f52c Control Rig: Fix unresolved deprecated nodes are not reporting an error if not involved in compilation
#rb jack.cai
#preflight 6304fce8ae13a5a098e86fbc

[CL 21524982 by sara schvartzman in ue5-main branch]
2022-08-23 19:22:27 -04:00
sara schvartzman
c433308948 Control Rig: Fix cannot connect execute pin in entry node
#jira UE-161023
#rb jack.cai
#preflight 62ff80ca3f75602b2f57967e

[CL 21499907 by sara schvartzman in ue5-main branch]
2022-08-22 21:21:00 -04:00
halfdan ingvarsson
19ae9b947b Control Rig: Sync UpdateTemplateNodePinTypes from UE5Main
#jira UE-161067
#rb benoit.gadreau
#preflight 62fd05fa200ff87e0781a086

#ROBOMERGE-OWNER: halfdan.ingvarsson
#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 21426542 via CL 21430788 via CL 21432247 via CL 21432263
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v980-21429816)

[CL 21434647 by halfdan ingvarsson in ue5-main branch]
2022-08-17 19:07:31 -04:00
benoit gadreau
5202250140 localizable text
#rb sara.schvartzman
#jira UE-160519
#preflight 62fba6f4ad3bd8ad64530bc8

#robomerge FNMain

[CL 21422223 by benoit gadreau in ue5-main branch]
2022-08-17 04:19:12 -04:00
rex hill
421ff22fb1 Fix several check() that should be verify() must still run in shipping
#preflight 62f8f9d7b66d5d9313536c06

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 21382837 via CL 21387149 via CL 21390143 via CL 21390737
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v975-21357124)

[CL 21392618 by rex hill in ue5-main branch]
2022-08-15 15:52:39 -04:00
Matt Peters
89927c6e00 AssetRegistry updates for Niagara/ControlRig: Call AssetTagsFinalized after asynchronous operations that modify the data that contributes to tags.
#rb Zousar.Shaker
#rnx
#preflight 62f6a38f153b17e74679345f

[CL 21361229 by Matt Peters in ue5-main branch]
2022-08-12 15:17:18 -04:00
jamie dale
cd2c04fbed Adding additional includes in preparation for removing a global include
#preflight skip
#rb none
#rnx

#ROBOMERGE-OWNER: jamie.dale
#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 21283042 via CL 21286016 via CL 21286060 via CL 21286134
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21291490 by jamie dale in ue5-main branch]
2022-08-09 12:54:53 -04:00
jack cai
bb42153dc6 Control Rig: Remove an unnecessary check during reattach link. Previously it was checking if template is initialized on library node, which by design should happen after rettach link. So there is no need to check for it during reattach link. Invalid links will be broken by a call to RecomputeAllTemplateFilteredPermutations() later in RefreshAllModels()
#jira UE-159787
#rb Sara.schvartzman, Helge.mathee
#preflight skip

[CL 21201877 by jack cai in ue5-main branch]
2022-07-21 11:53:21 -04:00
jamie dale
31a66a1325 Removed suspect use of GenerateDiff
#jira
#rb Thomas.Sarkanen
#rnx

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 21180075 via CL 21181732 via CL 21182426
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21192626 by jamie dale in ue5-main branch]
2022-07-20 18:33:03 -04:00
sara schvartzman
7e0bf1b762 Control Rig: Fix crash when running Run CitySampleWin64EditorPerf Incr1
#jira UE-159763
#rb helge.mathee
#preflight 62d69d6fd76ea4b5032271be

[CL 21162171 by sara schvartzman in ue5-main branch]
2022-07-19 10:28:07 -04:00
sara schvartzman
075fe3c245 Control Rig: Fix crash when opening CR_Quinn_Example in ControlRigExample
#jira na
#rb helge.mathee
#preflight 62d016296f385a5639a7654c

[CL 21089919 by sara schvartzman in ue5-main branch]
2022-07-14 09:16:13 -04:00
sara schvartzman
eec59437e9 Control Rig: Collapse nodes with templates
#jira UE-146929
#rb helge.mathee
#preflight 62ced5dbd00f3c208e47c183

[CL 21089290 by sara schvartzman in ue5-main branch]
2022-07-14 06:53:37 -04:00
helge mathee
b3573a03b0 Control Rig: Remove strong dependencies from User interface on data model - use TWeakObejctPtr
#rb rob.millar
#preflight https://horde.devtools.epicgames.com/job/62c6e9bb2823f28cf21e5f45

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 20988142 via CL 20988169 via CL 20988205
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 20992713 by helge mathee in ue5-main branch]
2022-07-07 17:00:35 -04:00
Helge Mathee
ac50c45e04 Control Rig: Maintain control names in UI as valid until re-chosen
#rb na
#jira UE-157955
#preflight https://horde.devtools.epicgames.com/job/62c6eb598558075f424d256b

[CL 20983875 by Helge Mathee in ue5-main branch]
2022-07-07 10:33:32 -04:00
Helge Mathee
5ed1ec94c8 Control Rig: Increase default node run count
#rb na
#jira na
#preflight skip

[CL 20964523 by Helge Mathee in ue5-main branch]
2022-07-06 06:34:53 -04:00