Commit Graph

1533 Commits

Author SHA1 Message Date
karen jirak
47d51bc622 Crash on paste of subcategory in the details panel.
Currently pasting a subcategory will result in a crash due to not checking the OnPasteFromTextDelegate for validity. We should check it for validity in SDetailCategoryTableRow prior to broadcasting.

#jira UE-202618
#rb brooke.hubert

[CL 31165390 by karen jirak in ue5-main branch]
2024-02-04 20:36:49 -05:00
karen jirak
f745b1709d Details Panel - Add API to mutate just the property name customization for a specific property path for non-nested properties
- created FDetailsNameWidgetOverrideCustomization and function to get it on FDetailsViewPrivate, SDetailsView and FDetailsViewArgs to provide a customization that can override any Name widget
- FDetailsNameWidgetOverrideCustomization can override any non-nested property, using the CustomizeName function which takes a TSharedRef<SWidget> that is the name widget that would show without the new customization, and the FPropertyPath in order to be able to tell what properties to override.
- In SDetalsSingleItemRow added GetNameWidget to use the FDetailsNameWidgetOverrideCustomization to provide the name widget, if it has been provided

#jira UE-201379
#rb jordan.hoffmann, logan.buchy

[CL 31134537 by karen jirak in ue5-main branch]
2024-02-02 14:14:49 -05:00
helen yang
95bae02570 Check widget row edit condition in addition to details view enablement for paste action enablement on SDetailSingleItemRow
#rb brooke.hubert
#jira UE-200546

[CL 31112945 by helen yang in ue5-main branch]
2024-02-01 19:42:40 -05:00
helen yang
8489a581f9 [Backout] - CL31074105
[FYI] helen.yang
Original CL Desc
-----------------------------------------------------------------
Check widget row in addition to details view enablement for paste action enablement on SDetailSingleItemRow

#rb logan.buchy
#jira UE-200546

[CL 31106243 by helen yang in ue5-main branch]
2024-02-01 17:36:38 -05:00
aditya ravichandran
b5b88730c0 Details Panel Overrides UX updates:
Move icons into an editor folder so they don't get cooked
Change the override combo button to match the desired behavior

#jira UE-192063, UE-204831, UE-205036
#rb logan.buchy

[CL 31099835 by aditya ravichandran in ue5-main branch]
2024-02-01 15:41:22 -05:00
aaron eady
865fca0a93 #JIRA UE-205463
Engine (map and set add item);

Implementing a way to have the map and set fill in with the next available enum value instead of always doing the default value.

Slack discussion with video: https://epicgames.slack.com/archives/C0447BVGFFZ/p1705510234620249

-- Code --
PropertyHandleImpl:
FPropertyHandleMap::AddItem() - Added a HasKey() lambda. We're then checking if the map property's key is an enum property, if so, we'll loop the enum values to see if the map doesn't already have that enum value as a key. When we find one that isn't in the map, we're adding a child node and then setting the child's key node to be the enum value that is not in the map yet. If the map property's key is not enum then we do the old check for if the default key isn't there.
FPropertyHandleSet::AddItem() - Added a HasElement() lambda. We're then checking if the set property's element is an enum property, if so, we'll loop the enum values to see if the set doesn't already have the enum value as an element. When we find one that isn't in the set, we're adding a child node and then setting the child node to be the enum value that is not in the set yet. If the set property's element is not enum then we do the old check for if the default key isn't there.

UnrealTypes:
FSetProperty::GetElementProperty() - Added this getter to return the ElementProp property.

[REVIEW] [at]guillaume.morreel, [at]matt.stone, [at]karen.jirak, [at]ronald.koppers
#tests PIE, opened a uasset that has a TMap property with enum as the key, added each enum key as I clicked the add item button, changed an entry to something out of order to make sure the add item button would add the next available entry, all the way until it wouldn't add anymore entries because all enum keys were taken. Also tried a TMap property with a gameplaytag as the key to make sure it still worked as expected. Repeated with TSet.
#rb ronald.koppers

[CL 31089421 by aaron eady in ue5-main branch]
2024-02-01 11:22:51 -05:00
jeanfrancois dube
5a313bdbf0 Property Coloration Revival:
- This functionality was lost at some point during UE4 and wasn't bound to anything in the engine since then.
- Removed all property coloration specific code and made it go through the new Actor Coloration Framework, and kept the original white color for non-matching objects and red for matching objects.
- In UE3, property coloration was bound to shift-click on a property, but this was replaced by copy/paste in UE4, so this is now bound to control-click instead.

#rb Sebastien.Lussier
[FYI] Brooke.Hubert, Aditya.RaviChandran

[CL 31084023 by jeanfrancois dube in ue5-main branch]
2024-02-01 08:04:34 -05:00
helen yang
b370f12c8c Check widget row in addition to details view enablement for paste action enablement on SDetailSingleItemRow
#rb logan.buchy
#jira UE-200546

[CL 31074130 by helen yang in ue5-main branch]
2024-01-31 19:22:10 -05:00
rex hill
d957f99c5c Property editor - Optimized performance when using a PropertyPermissionList to save several minutes of editor startup time
#rb dave.belanger

[CL 31017632 by rex hill in ue5-main branch]
2024-01-30 15:09:46 -05:00
jordan hoffmann
09a8b4b77c [Feature] PropertyTypeLayout deatails customization of types will be used in the details for their InstanceDataObject counterparts
#rb Francis.Hurteau, logan.buchy
#jira UE-202457

[CL 30979900 by jordan hoffmann in ue5-main branch]
2024-01-29 18:05:37 -05:00
maxime mercier
bb82f0f610 Hooked up overrides menu items which was added by [at]KJ.Jirak
#jira UE-204831
#rb aditya.ravichandran, logan.buchy

[CL 30975228 by maxime mercier in ue5-main branch]
2024-01-29 14:24:41 -05:00
charles lefebvre
fffa38146d Fix array paste when the input string contains commas
#jira UE-202295
#rb Brooke.Hubert
#tests Copy paste arrays with commas
#rnx

[CL 30968690 by charles lefebvre in ue5-main branch]
2024-01-29 10:00:34 -05:00
mike zyracki
9c8acb1685 Property Editor: Add getting the expansion state for a detail property row, which is needed in the following jira so we can show/hide widgets based upon expansion state. Also need to get the property row from the root nodes so added function to detail layout to do that.
#jira UE-200125
#rb Max.Chen

[CL 30958370 by mike zyracki in ue5-main branch]
2024-01-27 23:01:11 -05:00
maxime mercier
386a5e2352 Prevent property propagation for object using overridable serialization
#rb Phillip.Kavan

[CL 30928517 by maxime mercier in ue5-main branch]
2024-01-26 12:18:05 -05:00
maxime mercier
cdabdb790b Fix build break
#rb kurtis.schmidt

[CL 30889454 by maxime mercier in ue5-main branch]
2024-01-25 11:43:59 -05:00
thomas sarkanen
a0daf6d314 Fixed per-track compression to not allow selection of invalid scale formats
Also fixes various property metadata helpers when dealing with enums held in containers

#jira UE-151969
#rb jaime.cifuentes

[CL 30775416 by thomas sarkanen in ue5-main branch]
2024-01-22 11:21:18 -05:00
steve robb
6d5b974842 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30735396 by steve robb in ue5-main branch]
2024-01-19 19:41:56 -05:00
karen jirak
2fec708326 Overrides widget support phase 2
- enabled code in details single item row to show the overrides widget
- added code to the overrides style keys to provide the visibility based on overrides state of the edit property chain (for properties) and object inputs
- Updates to the details display managers to get the property update widgets by providing the edit property chain, needed for override state for properties
- updated the overrides combo button code to iterate through the style keys and show any the have been initialized to show for the current override state
- currently conntains API changes to provide the override state for properties

#jira UE-192054
#rb aditya.ravichandran

[CL 30678106 by karen jirak in ue5-main branch]
2024-01-17 23:35:33 -05:00
daren cheng
e07d373c2c Speculative fix Object name crash when no objects selected.
#jira UE-196979
#rb JeanMichel.Dignard

[CL 30673589 by daren cheng in ue5-main branch]
2024-01-17 18:15:37 -05:00
robert rouhani
8e69aa74c1 Remove property buttons on the header row of statically sized arrays of class properties
#jira UE-204021
#rb aditya.ravichandran

[CL 30662663 by robert rouhani in ue5-main branch]
2024-01-17 12:48:21 -05:00
vincent gauthier
18cd69b474 PropertyEditor Truncation warning fixes
#jira UE-166271
#rb zahra.nikbakht

[CL 30624677 by vincent gauthier in ue5-main branch]
2024-01-15 17:05:29 -05:00
vincent gauthier
7093f1e0c8 PropertyEditor Truncation fixes
#rb karen.jirak
#jira UE-166271

[CL 30622888 by vincent gauthier in ue5-main branch]
2024-01-15 14:25:54 -05:00
evgenii babinets
261e765995 More unreachable code fixes.
#rb simon.orr

[CL 30619462 by evgenii babinets in ue5-main branch]
2024-01-15 10:46:36 -05:00
loris rossi
efb2156d72 PropertyRowGenerator : exposing filter function for generated rows
#rb Jamie.Dale, Karen.Jirak

[CL 30616010 by loris rossi in ue5-main branch]
2024-01-15 05:45:06 -05:00
jordan hoffmann
38254fee20 [Refactor] Renaming scenegraph 'archetypes' to 'ObjectInstanceData'
[CL 30605552 by jordan hoffmann in ue5-main branch]
2024-01-12 17:22:37 -05:00