Commit Graph

14449 Commits

Author SHA1 Message Date
angela robinson
c787a837e1 Changing automated Test name to fit new naming convention
#rnx
#rb phil.wallace


#changelist validated
#virtualized

[CL 31217158 by angela robinson in ue5-main branch]
2024-02-06 11:39:01 -05:00
catalin dragoiu
2d5a67ce6d [Insights] The arrow down/up and autocomplete functionality is described in controls that support it using a hint text and tooltip.
#jira UE-164504
#rb ionut.matasaru

#changelist validated
#virtualized

[CL 31216226 by catalin dragoiu in ue5-main branch]
2024-02-06 11:13:43 -05:00
yiliang siew
34c5b236cf Introduce short names for both AndroidTargetPlatformControls and AndroidTargetPlatformSettings, which are causing certain built targets to run afoul of the MAX_PATH limit we impose on UBT file path lengths.
#rb Chris.Babcock, Florin.Pascu, Jack.Porter, Josh.Adams

[CL 31215454 by yiliang siew in ue5-main branch]
2024-02-06 10:58:52 -05:00
ionut matasaru
53933c01e1 [Insights] Fixed incorrect timestamps for cpu timing events with metadata that are adjacent to other regular cpu timing events.
#jira UE-205404
#rb Catalin.Dragoiu

[CL 31208333 by ionut matasaru in ue5-main branch]
2024-02-06 04:59:13 -05:00
sebastian schoner
65637919f5 Report Metis memory errors as global OOMs
When memory is limited, the GraphPartitioner in Nanite's building code can run out memory from within the METIS library. This is currently not properly raised as an OutOfMemory error in our memory subsystem, which means that we are missing those in our error reporting for memory issues. We are already aborting when this happens, so there is no behavior change besides that the error is now properly picked up by our reporting systems.


#rb Brian.Karis

[CL 31207388 by sebastian schoner in ue5-main branch]
2024-02-06 03:38:40 -05:00
zousar shaker
969392d5fe Fix for zenserver shutdown and start logic bug. The "return" within the while NativeIsProcessRunning || IsZenProcessUsingEffectivePort loop creates a situation where we can exit the loop before the process is completely gone, meaning the lockfile could still be present.
#jira UE-205971
[FYI] dan.engelbrecht

[CL 31200515 by zousar shaker in ue5-main branch]
2024-02-05 19:47:23 -05:00
jeanluc corenthin
1a38568642 Added logic to only disable FBX level import
#jira UE-205931
#rb Alexis.Matte

[FYI] flavien.picon

[CL 31187134 by jeanluc corenthin in ue5-main branch]
2024-02-05 15:28:45 -05:00
sebastien lussier
db863ee448 AssetViewUtils::MoveAssets - Fix issue whe external packages weren't moved
* Previous fix was skipped for non local assets that needed a redirector
#jira UE-198460
#rb JeanFrancois.Dube

[CL 31184245 by sebastien lussier in ue5-main branch]
2024-02-05 14:27:54 -05:00
martin ridgers
edf615ef53 Lifted IAS' TOC downloading out from UnrealPak
#rb paul.chipchase
#rnx

[CL 31167977 by martin ridgers in ue5-main branch]
2024-02-05 04:51:45 -05:00
pj kack
9e9bb35f97 ZenFileSystemManifest fixes for missing plugins on target platforms (relax optimizations in 25794520).
When adding plugin directories also add any valid plugin extension directories (inspired by cl 24072232).
Don't filter out plugins disabled in the editor/cooker, they may still be enabled on the target platform.

todo: Reintroduce more accurate plugin filtering logic.
#rb dan.engelbrecht, Zousar.Shaker

[CL 31167561 by pj kack in ue5-main branch]
2024-02-05 04:07:35 -05:00
daren cheng
9471c651ef Fix undo history crash when temporary property not yet in object reflection data.
#jira UE-204301
#rb aditya.ravichandran

[CL 31165045 by daren cheng in ue5-main branch]
2024-02-04 19:52:19 -05:00
graham wihlidal
28229f90c0 Fixed some additional ISA issues by adding v_fmaak_f32, v_fmamk_f32, v_fmamk_f16, and v_fmaak_f16 to the trailing literal check
[FYI] rune.stubbe, brian.karis, jian.ru, jamie.hayes, luke.thatcher

[CL 31164583 by graham wihlidal in ue5-main branch]
2024-02-04 18:31:55 -05:00
zousar shaker
081894b3f3 Fix log format convention for HttpCacheStore to match ZenCacheStore - log lines should be prefixed by node name, not domain or URL.
[CL 31158214 by zousar shaker in ue5-main branch]
2024-02-03 02:36:18 -05:00
graham wihlidal
592a890924 Fixed RDNA2 disassembler to correctly handle v_madak_f32 and v_madmk_f32 advancing with a trailing literal
[FYI] rune.stubbe, brian.karis, john.huelin, jian.ru, jamie.hayes

[CL 31148557 by graham wihlidal in ue5-main branch]
2024-02-02 18:37:10 -05:00
calvin zheng
26de99eff3 UBT handling Privacy Manifest files for iOS and Mac
#jira UE-191438
#rb adam.kinge, zack.neyland

[CL 31138198 by calvin zheng in ue5-main branch]
2024-02-02 15:34:12 -05:00
dan engelbrecht
5f7a896d20 Validate running processes for zenserver by using native functions directly.
We need to control how the process handle is opened.
#jira UE-205151
#rb stefan.boberg, Zousar.Shaker

[CL 31127942 by dan engelbrecht in ue5-main branch]
2024-02-02 11:42:14 -05:00
ionut matasaru
e550b3ffde [Insights] Fixed crash when "TimingInsights.ExportTimerStatistics" execute command is specified with an invalid filename. An error message is logged instead.
#jira UE-177417
#rb Catalin.Dragoiu

[CL 31127407 by ionut matasaru in ue5-main branch]
2024-02-02 11:26:08 -05:00
ben hoffman
0a6de35a5b Editor | Add functionality for automatic fixes in tokenized messages
This allows you to attach an automatic fix to any error or warning that may arise from eg. validation.

#jira none
#rb Julien.StJean

#ushell-cherrypick of 31124509 by gabriel.wreczycki

[CL 31126352 by ben hoffman in ue5-main branch]
2024-02-02 10:58:45 -05:00
johan berg
49a0aa09d6 Fix dialog text
Fix dialog text when comfirming removal of watch directory.

#rb ionut.matasaru
#jira UE-202922

[CL 31124557 by johan berg in ue5-main branch]
2024-02-02 10:10:36 -05:00
ionut matasaru
6a9895bc46 [Insights] Fixed "Open Source File" functionality (in Log View, Timers panel, Tasks panel and in the "Mem Allocs" table/tree view) to handle correctly the case when there is no source code accessor.
#jira UE-185299
#jira UE-195493
#rb Catalin.Dragoiu

[CL 31121119 by ionut matasaru in ue5-main branch]
2024-02-02 07:28:11 -05:00
sebastian schoner
36a6d2605d Change method of detecting overlapping vertices in SkeletalMeshTools to use FOverlappingCorners
BuildSkeletalMeshChunks is used during cooking when saving skeletal meshes (calls originate from USkeletalMesh::BuildLODModel, see linked jira ticket for full callstacks) and deduplicates overlapping vertices. In contrast to many other places in the engine, it is using a multimap instead of the FOverlappingCorners type. Using a multimap is technically more correct since "points overlap each other" is not an equivalence relation (it is not transitive, i.e. "A overlaps B" and "B overlaps C" but "A does not overlap C" is possible). FOverlappingCorners pretends that transitivity is given, because that is pretty much always true. Note also that there is another check later on for whether two vertices within the same cluster actually overlap.

In especially degenerate cases this can save a lot of memory because we only store each group of overlapping vertices once (instead of having a copy for every vertex in that group). With user content in UEFN, it is unfortunately very much possible to hit these degenerate cases, allocate gigabytes of memory, and have the cooking process terminate with an OOM error.

This CL changes this codepath to use FOverlappingCorners instead. The memory savings and time savings are significant, find a comparison here https://docs.google.com/document/d/1qHnY_6WXpcEmJL_61myQDczxG6XDZRuVUCE8yQ-FkDs/edit?usp=sharing

#rb alexis.matte, laura.hermanns

[CL 31119331 by sebastian schoner in ue5-main branch]
2024-02-02 04:00:56 -05:00
marco anastasi
4f2e25abee * Added Restore as Latest functionality
* Created 'Restore as latest' dialog

#rb wouter.burgers

[CL 31095574 by marco anastasi in ue5-main branch]
2024-02-01 13:58:40 -05:00
catalin dragoiu
19ca1ff397 [Insights] Make task relations more descriptive when they point to hidden tracks. Also add a warning in this case.
#rb ionut.matasaru
#jira UE-203012

[CL 31091277 by catalin dragoiu in ue5-main branch]
2024-02-01 12:18:10 -05:00
jack cai
ad1f902744 [Skeletal Mesh Utilities] fixed a bug causing the same vert attribute map getting copied into multiple attributes on the LOD model
#rb halfdan.ingvarsson

[CL 31088801 by jack cai in ue5-main branch]
2024-02-01 11:03:47 -05:00
paul chipchase
957d42a79e Add analytics for asset virtualization reliability events.
#rb mark.lintott
#jira UE-165045
#rnx

- Add a new event (GetAnalyticsRecordEvent) to the UE::Virtualization namespace. Different telemetry systems can hook into this and respond when the virtualization system tries to send a new analytics event.
-- This even accepts an enum class of flags to provide better context for the event. At the moment the only valid flag is to request that the telemetry system flushes the event to make sure that it is sent before returning control to the event. In this way we can know that events are safely recorded before terminating the current process.
- To begin with we are only adding failure events and not recording any successes
-- Send an analytics even when the initial connection to perforce fails, the event should note if the user opted to retry their connection (after entering new details) or if they wanted to skip the check and load the editor anyway.
-- Send an analytics event when a payload fails to pull, the event should note if the user opted to retry to pull the payload or quit the process.

[CL 31087065 by paul chipchase in ue5-main branch]
2024-02-01 10:00:35 -05:00