Commit Graph

634 Commits

Author SHA1 Message Date
Ben Marsh
7f9774d740 Make it clearer that TargetReceipt.Read can fail if the file doesn't exist or is formatted incorrectly.
[CL 2649965 by Ben Marsh in Main branch]
2015-08-10 16:07:05 -04:00
Marcus Wassmer
9f9a6ba80a Set up stagedir even in skipstage so the run command can find the proper executable
#codereview james.moran

[CL 2646930 by Marcus Wassmer in Main branch]
2015-08-06 16:19:18 -04:00
Wes Hunt
585af51d15 TempStorage Refactor
GUBP High Level
* Temp Storage is zipped into a single archive per node now. This results in ~75% reduction in temp storage usage and network traffic, not to mention the per-file overhead.
* Temp Storage is in P:\\Builds\\{Game}\\TmpStore instead of P:\\Builds\\{Game}\\GUBP (to facilitate easier cleaning of this new structure).
* Temp Storage nodes are in subdirectories of {Branch}\\{CL}\\{NodeName} now instead of a flat directory structure that was hard to manually sift through.

GUBP Mid Level
* Removed -Store= and -StoreSuffix= test parameters.
* Added -NoZipTempStorage parameter to turn off temp storage zipping if necessary.
* Created GUBP.JobInfo class that collects info about the job as a whole to be passed around by GUBP. Mostly used by any code that need to interact with TempStorage.
* Created TempStorageNodeInfo that describes the necessary parameters to find the temp storage location for a node.
* Fully XML commented TempStorage.cs, and commented internals all major functions.
* Added a bunch of telemetry data for storing, retrieving, and cleaning shared temp storage.

UAT Mid Level
* Fixed a bug in Ionic.Zip that make ExtractAll() not work on Mono, checked in new DLLs.
* Added UAT parameter -UseLocalBuildStorage that allows you to test build storage stuff completely locally. Writes to Engine\\Saved\\LocalBuilds\\...

GUBP Low Level
* Refactored some GUBP startup code so temp vars would be limited in scope. Makes it easier to track the impact of refactoring these things.
* CullNodesForPreflight is only called for preflight builds.
* Refactored TempStorage.FindTempStorageManifests to use new TmpStore structure and harden the brittle string/path parsing it was doing. See the new TempStorage FindMatchingSharedTempStorageNodeCLs().
* Refactored TempStorage Saving and Loading to use XDocument instead of older XmlDocument. Removed a bunch of redundant checks.
* Use StripBaseDirectory and MakeRerootedFilePath to remove the brittle directory manipulation code. Directories no longer require a '/' at the end.
* Removed a few redundant caching layers in cleaning temp storage that try to ensure we don't clean a folder twice. None of them were necessary.
* Removed unused single-threaded copy code from temp storage.
* Updated Temp Storage unit test, and fully commented the logic behind it.

UAT Low Level
* UAT top level exception handler is now a single log line now to help parsers find the error.
* Removed several uses of FormatException as it doesn't display the entire exception chain, and is not as good as the default exception formatter.
* Removed ExceptionToString as it used FormatException, which was not a good precedent.
* Fixed several cases of exception propagation that was not properly chaining the inner exception.
* Refactored ThreadedCopyFiles to use Parallel.For because it was just as fast (if not faster) and much simpler to maintain.
* Removed the suffix from Robust_FileExists_NoExceptions because it's sole purpose in life WAS to throw exceptions!
* Added a bunch of XML doc comments to CommandUtils.
* Modernized some container manipulation and iteration to use IEnumerable and extension methods more appropriately.
* Added several @todos for other minor cleanup stuff that should happen eventually.
* Fixed some uses of String.Compare to use invariant culture.
#codereview:ben.marsh

[CL 2644846 by Wes Hunt in Main branch]
2015-08-05 10:22:11 -04:00
Timothy Reynolds
fae6a68b46 Added missing Source folder to zipping filter list.
UE-19560

[CL 2643666 by Timothy Reynolds in Main branch]
2015-08-04 13:36:36 -04:00
Ben Marsh
79351a008c Remove build.properties. Applications can now use Build.version for structured version information; timestamp was only used by the launcher, so it now uses its own.
[CL 2638907 by Ben Marsh in Main branch]
2015-07-30 12:24:22 -04:00
Peter Sauerbrei
36d0ab7a67 UE-17454 - fix for cook hang on mac
we now don't write the same message twice to the output window
#mac

[CL 2638743 by Peter Sauerbrei in Main branch]
2015-07-30 11:01:02 -04:00
Daniel Lamb
8ce5ac8b7f Fixed issue with paking DLC when there is no engine directory.
[CL 2637638 by Daniel Lamb in Main branch]
2015-07-29 16:48:09 -04:00
buildmachine
ce42430211 Code documentation from CL#2636592
[CL 2636758 by buildmachine in Main branch]
2015-07-29 07:47:34 -04:00
Ben Marsh
9e31e87ce0 Explicitly pass the engine root into ReadAvailablePlugins().
[CL 2632416 by Ben Marsh in Main branch]
2015-07-24 13:23:11 -04:00
Marcus Wassmer
8be948a313 Fix cookonthefly steaming condition.
#Daniel.Lamb

[CL 2632390 by Marcus Wassmer in Main branch]
2015-07-24 13:09:50 -04:00
Marcus Wassmer
9a8ce2e905 Do iterative cooking for COTF when requested
#codereview Daniel.Lamb

[CL 2632196 by Marcus Wassmer in Main branch]
2015-07-24 10:21:47 -04:00
Marcus Wassmer
da1cebf73f Just do logs for plugin spam
[CL 2632160 by Marcus Wassmer in Main branch]
2015-07-24 10:03:43 -04:00
Robert Manuszewski
989bed2201 Replacing Console.WriteLine logs with UBT/UAT specific ones.
#codereview Marcus.Wassmer, Ben.Marsh

[CL 2631972 by Robert Manuszewski in Main branch]
2015-07-24 04:38:03 -04:00
Marcus Wassmer
cb2aa76bbb Ensure EngineRelativeDir is correct for plugin staging
#codereview Bob.Tellez

[CL 2631803 by Marcus Wassmer in Main branch]
2015-07-23 22:20:23 -04:00
Bob Tellez
af54d3b60e Plugin files are now read from the correct working directory while creating the staging manifest.
[CL 2631763 by Bob Tellez in Main branch]
2015-07-23 21:25:53 -04:00
Marcus Wassmer
816105af91 More logiging for plugin discovery
[CL 2631608 by Marcus Wassmer in Main branch]
2015-07-23 18:52:28 -04:00
Peter Sauerbrei
dc1d815f84 refactored the logging system for UAT/UBT to be more like UE4
we now use an enum similar to UE4 with Fatal, Error, Warning, Display, Log, Verbose, and VeryVerbose
Log will only go to the log file unless -verbose is passed on the command line
reduced some of the output from UAT to be Log only

[CL 2631062 by Peter Sauerbrei in Main branch]
2015-07-23 14:51:46 -04:00
Timothy Reynolds
5eaf91c514 Fixed zipping project path issue on mac. Cleaned up log messages. Display the correct OS for the process.
UE-19001, UE-19003

[CL 2629653 by Timothy Reynolds in Main branch]
2015-07-22 17:27:55 -04:00
Wes Hunt
7ff08138f9 Move Robust_XXX methods into InternalUtils, since it is called outside of TempStorage.
#UEB-307

[CL 2629371 by Wes Hunt in Main branch]
2015-07-22 15:21:40 -04:00
Ben Marsh
dd08437233 Rename BuildReceipt to TargetReceipt, to clarify its purpose.
[CL 2629145 by Ben Marsh in Main branch]
2015-07-22 13:10:12 -04:00
Marcus Wassmer
a363f3e639 Make sure directory exists for release paks
#codereview Daniel.Lamb

[CL 2628896 by Marcus Wassmer in Main branch]
2015-07-22 10:13:35 -04:00
Daniel Lamb
299c980489 Stopped create release version from failing to copy.
[CL 2627516 by Daniel Lamb in Main branch]
2015-07-21 11:32:06 -04:00
Ben Marsh
f27b374dcc Missing file.
[CL 2625346 by Ben Marsh in Main branch]
2015-07-18 17:04:00 -04:00
Ben Marsh
a5f534451b Remove the ENGINE_VERSION define from Version.h and ObjectVersion.cpp; it's superceded by GEngineVersion. EngineVersion.cpp now defines the constants GEngineVersionChangelist and GCompatibleWithEngineVersionChangelist, which are used to construct GEngineVersion and GCompatibleWithEngineVersion. Modifying those constants allows updating the engine version separately to the defines used for resource files (allowing UGS to update the version number without triggering all files to be relinked).
[CL 2625344 by Ben Marsh in Main branch]
2015-07-18 16:57:53 -04:00
Ben Marsh
36d0c480b6 Fix unused variable warning causing build failure on Mono.
#codereview Peter.Sauerbrei

[CL 2624756 by Ben Marsh in Main branch]
2015-07-17 15:46:40 -04:00