Commit Graph

19 Commits

Author SHA1 Message Date
Matt Kuhlenschmidt
b7723933a6 Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 3279756)
#lockdown Nick.Penwarden
#rb none

==========================
MAJOR FEATURES + CHANGES
==========================

Change 3229490 on 2016/12/09 by Cody.Albert

	Integrated fix to support named changelists in SVN

Change 3229574 on 2016/12/09 by Simon.Tourangeau

	Fix actor mobility getting changed on scene reimport

	#jira UE-39102

Change 3229692 on 2016/12/09 by Cody.Albert

	Fixing an XML Parser assert when parsing a root tag that completes on the same line.

	#jira UE-30393

Change 3230582 on 2016/12/12 by Matt.Kuhlenschmidt

	PR #3024: Correct the outdated error message instructions for how to fix being unable to launch on an iOS device. (Contributed by CleanCut)

Change 3231470 on 2016/12/12 by Matt.Kuhlenschmidt

	Eliminate editor sounds that play when  you PIE, simulate or possess the player.  They get in the way of game sounds, are annoying to hear when you are constantly starting and stopping pie, and flush async loading that the game might be doing when they load.

Change 3231475 on 2016/12/12 by Alex.Delesky

	#jira UE-39023 - Using the High Resolution screenshot tool with the "custom depth as mask" option checked should no longer crash the editor or a PIE viewport when the screen percentage is not set to 100.

Change 3231476 on 2016/12/12 by Alex.Delesky

	#jira UE-39380 - Thumbnails for static meshes in the foliage paint mode window should now update to show the correct mesh if the thumbnail pool has been exhausted. This also increases the number of foliage thumbnals that can exist onscreen at once.

Change 3231477 on 2016/12/12 by Alex.Delesky

	#jira none - Extending the IPluginWizardDefinition interface to allow it to return the descriptor type of the plugin. This fixes a merge conflict from Odin where the new plugin wizard was modified to allow for multiple template selection.

Change 3231479 on 2016/12/12 by Alex.Delesky

	#jira UE-39376 - Changing the number of players or changing the dedicated server options in PIE settings should now always persist on editor shutdown.

Change 3231480 on 2016/12/12 by Alex.Delesky

	#jira UE-39417 - A texture will now match to update a dropped in file if the source path differs from that of the dropped in file

Change 3231508 on 2016/12/12 by Alex.Delesky

	Removing todo comment

	#jira none

Change 3231603 on 2016/12/12 by Matt.Kuhlenschmidt

	Exposed a 0-1 UV set and the scaled pixel size for Box and Border brushes
	Also added a material function that exposes all of the current UV sets with nice names instead of indexed coordinates

Change 3231618 on 2016/12/12 by Alex.Delesky

	#jira UE-38732 - When editing a spin box with a delta value, committing the value with the Enter key and then clearing the focus from the spin box will no longer change the internal value to match the snapped value.

Change 3231638 on 2016/12/12 by Matt.Kuhlenschmidt

	Add RF_Transactional to the list of default flags for creating or importing new assets.  All should be transactional by default

Change 3231642 on 2016/12/12 by Matt.Kuhlenschmidt

	Brighten up the output log by default

Change 3231648 on 2016/12/12 by Alex.Delesky

	#jira UE-38033 - Selecting a Named Slot that's part of a widget in a Widget Switcher will now show that widget instead of the widget at index 0. This also applies to any content set inside the named slot.

Change 3231666 on 2016/12/12 by Alex.Delesky

	#jira UE-38952 - Widgets that have been copied and pasted into the same hierarchy will now retain the same name in the hierarchy. This does not fix widgets that have been previously copied and pasted from other widgets, nor copies of those widgets.

Change 3231674 on 2016/12/12 by Alex.Delesky

	#jira UE-37106 - When using or simulating touch for Widget Components, the hover/clicked state will now be accurately determined rather than showing hover on initial touch.

Change 3231745 on 2016/12/12 by Alex.Delesky

	Back out changelist 3231477 to fix build error C2259

Change 3232417 on 2016/12/13 by Simon.Tourangeau

	Add the following attributes to the Editor.Usage.FBX.Import EngineAnalytics event
	- FBX Version
	- Filename Hash
	- Import Type

	#jira UE-37453

Change 3232477 on 2016/12/13 by Michael.Dupuis

	#jira UE-39675 : There was an issue when the Neutral Value == the Min or Max value, so we simply prevent using the concept of neutral value if min or max == neutral as it mean you only want a log on one side.

Change 3232571 on 2016/12/13 by Alex.Delesky

	Back out changelist 3231745

	#jira none - Extending the IPluginWizardDefinition interface to allow it to return the descriptor type of the plugin. This fixes a merge conflict from Odin where the new plugin wizard was modified to allow for multiple template selection.

Change 3232675 on 2016/12/13 by Alexis.Matte

	Fix a crash when reordering material with a fbx containing unused materials, add a fbx automation test to prevent similar issue.
	#jira UE-39692

Change 3232975 on 2016/12/13 by Alex.Delesky

	Fix to build error C2259 for the IPluginWizardDefinition API change.

Change 3233146 on 2016/12/13 by Michael.Dupuis

	#jira UE-38766 : Added eye dropper to select flatten height
	Fixed a rounding errors resulting in not flattening to the specified height
	Fixed a rounding error resulting in LandscapeDataAccess::GetTexHeight not always returning the appropriate value

Change 3233153 on 2016/12/13 by Alexis.Matte

	We cannot anymore change the instance override materials array topology, the topology is limited by the mesh materials array
	#jira UE-38827

Change 3234406 on 2016/12/14 by Matt.Kuhlenschmidt

	Fix window handle and device context being accessed by scene viewports after the underlying window has been destroyed by the OS.  This is an invalid state on linux and using some vr devices.

	#jira UE-7388

Change 3234485 on 2016/12/14 by Michael.Dupuis

	tentative build fix for Mac

Change 3234495 on 2016/12/14 by Matt.Kuhlenschmidt

	Made a setting to control if PIE enter and exit sounds are played.  Off by default

Change 3236709 on 2016/12/15 by Simon.Tourangeau

	Fix camera export rotation offset

	#jira UE-34692
	#jira UE-39740

Change 3236782 on 2016/12/15 by Jamie.Dale

	Fixed EmitTermExpr failing to use the correct package ID

	FBPTerminal::Source used to be set to the pin, however when pins were moved away from being UObjects, FBPTerminal::SourcePin was added and FBPTerminal::Source is typically null.

Change 3236853 on 2016/12/15 by Alexis.Matte

	Fix the serialization of the staticmesh property FMeshSectionInfoMap

Change 3236890 on 2016/12/15 by Matt.Kuhlenschmidt

	Remove old define

Change 3239328 on 2016/12/18 by Richard.TalbotWatkin

	Fixed Focus Viewport action in Static Mesh Viewport. Problem was that the conversion to Orbit Camera for storing the camera position was trashing the desired position during cvamera transitions.  Orbit camera position is now only stored at the end of a transition.
	#jira UE-39825 - Key "F" for Focus acts Sporadically in the Static Mesh Editor Viewport

Change 3239660 on 2016/12/19 by Alex.Delesky

	#jira UE-38968, UE-36826 - Components attached to actors can now be directly scaled to negative values using the transform gizmo for that component.

Change 3239662 on 2016/12/19 by Alex.Delesky

	#jira UE-39007 - The data table row editor now contains a Reset to Default control.

Change 3239663 on 2016/12/19 by Alex.Delesky

	#jira UE-39698 - Importing CSV files will now show the name of the file in the import dialog.

Change 3240696 on 2016/12/20 by Michael.Dupuis

	#jira UETOOL-1009:
	Added paddiing to columns view
	Added auto resize of column when double clicking on splitter handle in the header
	Remove right number alignment after discussion with Matt K.

Change 3240758 on 2016/12/20 by Michael.Dupuis

	added missing non abstract implementation

Change 3240782 on 2016/12/20 by Michael.Dupuis

	Added missing documentation for content browser column auto resizing

Change 3240817 on 2016/12/20 by Alex.Delesky

	#jira UE-38940 - Copying a Material-Custom node with a tab character should now correctly render the tab.

Change 3240834 on 2016/12/20 by Michael.Dupuis

	tentative fix for build error

Change 3240984 on 2016/12/20 by Michael.Dupuis

	Removed unnecessary functions

Change 3241174 on 2016/12/20 by Matt.Kuhlenschmidt

	Fix compile errors

Change 3241966 on 2016/12/21 by Chris.Wood

	Fixed Typo and changed execution order in "ComboBoxString" Component
	[UE-38994] - GitHub 2971 : Fixed Typo and changed execution order in "ComboBoxString" Component

	PR #2971: Fixed Typo and changed execution order in "ComboBoxString" Component (Contributed by eXifreXi)
	#github https://github.com/EpicGames/UnrealEngine/pull/2971

Change 3242126 on 2016/12/21 by Alexis.Matte

	Back out changelist 3236853
	We have to back out this change list because the change was implement in the 4.15 release branch and the EditorObjectVersion.h change is now implement in the ReleaseObjectVersion.h.

Change 3244492 on 2017/01/02 by Jamie.Dale

	Improved error message

Change 3244545 on 2017/01/02 by Nick.Darnell

	Navigation - Making it so we don't attempt to load HotReload during shutdown, we only access it if it's still loaded.

Change 3244549 on 2017/01/02 by Nick.Darnell

	Slate - Implementing custom hardware cursor loading across Windows, Mac and Linux and supports loading cursors from PAK files.  All platforms support loading PNGs through the FHardwareCursor interface.  Some platforms support additional formats, for multiresolution support, but there's a naming convention that can be used on PNGs for the same capability.  All of it is documented in the FHardwareCursor header.  The platform layer for ICursor, now has support for replacing cursor shapes as an override, and can be reset safely.

	The FHardwareCursor supports loading cursors from raw pixel buffers as well, the plan is to allow for the option to UTextures to also be used for hardware cursors.

	Now users through C++ can load and replace the hardware cursors with custom ones of their own,

	e.g. FSlateApplication::Get().RegisterCursor(EMouseCursor::Default, MakeShareable(new FHardwareCursor(FPaths::GameContentDir() / "Slate/FancyPointer", FIntPoint(0,0))));

	The next step is to expose a game friendly layer that supports caching cursors, and letting users change them out by name, without a bunch of destruction of OS resources.

Change 3244845 on 2017/01/03 by Jamie.Dale

	Fixing typo

	#jira UE-39920

Change 3244903 on 2017/01/03 by Jamie.Dale

	PR #3044: fix link error when FAssetData::PrintAssetData() is used in project (Contributed by kayama-shift)

Change 3245125 on 2017/01/03 by Alexis.Matte

	Put back the dev-editor version because there was some data create before we back it out

Change 3246106 on 2017/01/04 by Chris.Wood

	Removed broken CrashReportReciever pre-upload phase from CrashReportClient.
	[UE-40153] - CrashReportClient fails when used in legacy mode with a CrashReportReciever

Change 3246251 on 2017/01/04 by Alex.Delesky

	#jira UE-39869 - Moving an asset before saving it and then hitting Save All from the file menu will no longer save the asset in its original location.

Change 3246252 on 2017/01/04 by Alex.Delesky

	#jira UE-39793 - Fixes an issue with the AutoReimporter where specifying a non-existent mount point (a directory in the content browser) would cause a crash when attempting to auto-import an asset from a monitored directory, as well as ensuring that valid mount points will be able to create new assets from auto-import.

	The "Map Directory To" field when setting directories to monitor for auto-reimport has also been changed to use the content browser path picker instead of relying on the user to manually enter a mount point.

Change 3247620 on 2017/01/05 by Nick.Darnell

	Automation - Removing an adjustment to the number of shots we take for high res shots.

Change 3247621 on 2017/01/05 by Nick.Darnell

	Automation - Adding a few more rendering tests to the cornell box.

Change 3247629 on 2017/01/05 by Nick.Darnell

	Automation - Improving the comparison row display for screenshots so it's obvious what each image represents.

Change 3248811 on 2017/01/05 by Matt.Kuhlenschmidt

	PR #3091: Removed unnecessary UPackage casts (Contributed by projectgheist)

Change 3248860 on 2017/01/06 by Matt.Kuhlenschmidt

	Made the plugin browser select the "built in" category by default instead of the 2D category.  There is no reason for a sub-category to be selected first as it makes searching for plugins globally an extra click because you have to click on the base category first

Change 3249264 on 2017/01/06 by Matt.Kuhlenschmidt

	Fixed automation test warnings

	#jira UE-40198

Change 3249481 on 2017/01/06 by Michael.Dupuis

	#jira UE-37875 : Fill empty layers of components on assignation or creation
	Also fill new component added with the tool from neighbours predominance

Change 3249505 on 2017/01/06 by Matt.Kuhlenschmidt

	PR #3093: Include guard cleanup (Contributed by projectgheist)

Change 3249544 on 2017/01/06 by Michael.Dupuis

	#jira UE-40299: validate if UISettings is valid

Change 3250738 on 2017/01/09 by Nick.Darnell

	UMG - The WIC now checks if the Widget is enabled before it claims that it's over an interactable or keyboard focusable widget.

	#jira UE-39845

Change 3250865 on 2017/01/09 by Nick.Darnell

	Slate - Updating EAutoCenter and ESizingRule to use the newer enum class style enums.

Change 3250867 on 2017/01/09 by Nick.Darnell

	Slate - Adding more logging to the hardware cursor code so that it reports more information when it doesn't find an exact match when it comes to cursor size.

Change 3250936 on 2017/01/09 by Nick.Darnell

	Automation - Refactoring the screenshot comparison tool to no longer require one one generated report.  Doing screenshot comparions now generates individual reports for each failed comparison so that they can be evaluated in bits, and as changes occur as the user reviews aspects, we can remove the reports.  There is now async image loading for the comparison view so that it doesn't hitch.

Change 3250937 on 2017/01/09 by Nick.Darnell

	Automation - Adding another example to the CornellBox test.

Change 3250958 on 2017/01/09 by Nick.Darnell

	Slate - Fixing some other cases where people were referring to ESizingRule::Type.

Change 3251162 on 2017/01/09 by Nick.Darnell

	Slate - Fixing some other cases where people were referring to ESizingRule::Type.

Change 3251254 on 2017/01/09 by Matt.Kuhlenschmidt

	Attempt to fix static analysis warnings

Change 3251373 on 2017/01/09 by Nick.Darnell

	Core - Now writing a log warning instead of ensuring if calling LoadModule wouldn't have been safe to do here, depending on load order.

Change 3251525 on 2017/01/09 by Nick.Darnell

	Automation - Fixing a build issue in ImageComparer.

Change 3252321 on 2017/01/10 by Alex.Delesky

	#jira UE-40164 - Importing multiple files to overwrite existing assets such as sounds will now correctly persist the "Yes to All" / "No to All" dialog selections.

Change 3252354 on 2017/01/10 by Nick.Darnell

	Image Compare - Fixing a potential threading hazard in the image comparer.

Change 3252356 on 2017/01/10 by Nick.Darnell

	Automation - The screenshot metadata now captures the commit/CL that the screenshot was taken at and records it in the metadata.

Change 3252601 on 2017/01/10 by Alexis.Matte

	Fbx automation test, reload feature implementation

Change 3252761 on 2017/01/10 by Jamie.Dale

	Fixing some IWYU errors with PCH disabled

Change 3252765 on 2017/01/10 by Jamie.Dale

	Fixing some static analysis warnings

Change 3252793 on 2017/01/10 by Jamie.Dale

	Fixing FText natvis

	The text data visualizers have to be defined before the text visualizer

Change 3253987 on 2017/01/11 by Matt.Kuhlenschmidt

	PR #3108: Git Plugin: use asynchronous "MarkForAdd" and "CheckIn" operations for the initial commit (Contributed by SRombauts)

Change 3254378 on 2017/01/11 by Matt.Kuhlenschmidt

	Refactor scene importing to allow for plugins to make scene importers

Change 3254679 on 2017/01/11 by Matt.Kuhlenschmidt

	Fix calling LoadModule in perforce source control off the main thread

Change 3256472 on 2017/01/12 by Jamie.Dale

	Improved error reporting from IncludeTool

	- The error reporting was using zero-based line indices which was misleading.
	- The error reporting now includes the offending line to remove ambiguity.

Change 3256725 on 2017/01/13 by Jamie.Dale

	IncludeTool can now parse typedef in Fwd headers

Change 3256758 on 2017/01/13 by Jamie.Dale

	Added support for String Tables

	String Tables provide a way to centralize your localized text into one (or several) known locations, and then reference the entries within a string table from other assets or code in a robust way that allows for easy re-use of localized text.

	String Tables can be defined in C++ (using the LOCTABLE family of macros), loaded via CSV file, or created as an asset. They can be referenced in C++ using either the LOCTABLE macro, or the static FText::FromStringTable function. INI files can reference them using the LOCTABLE macro syntax, and FText properties in assets can reference them via the advanced settings combo.

Change 3257018 on 2017/01/13 by Alexis.Matte

	FbxAutomationTest fix the import reload operation, it was calling garbagecollect with no keep flag

Change 3257168 on 2017/01/13 by Jamie.Dale

	Removed code that was writing null into bytecode during save

Change 3257344 on 2017/01/13 by Jamie.Dale

	Backing out changelist 3256725, and excluding my header from the scan instead

Change 3257426 on 2017/01/13 by Nick.Darnell

	Slate - Adding the ability to invert alpha when drawing slate textures.  Going to be used in the future for rendering render targets for the scene which have inverted alpha.

Change 3257572 on 2017/01/13 by Nick.Darnell

	Slate - Fixing a build error.

Change 3257970 on 2017/01/14 by Jamie.Dale

	Fixing exclude path

Change 3258458 on 2017/01/16 by Matt.Kuhlenschmidt

	PR #3135: GameViewportClient: FOnCloseRequested is now a multicast delegate (Contributed by Nadrin)

Change 3258472 on 2017/01/16 by Matt.Kuhlenschmidt

	PR #3126: Fix to load editor style assets (Contributed by projectgheist)

Change 3258473 on 2017/01/16 by Matt.Kuhlenschmidt

	PR #3124: Fix wrong result with Image-DrawAsBox with PaperSprite. (Contributed by valval88)

Change 3258539 on 2017/01/16 by Nick.Darnell

	Slate - Pixel Snapping has been moved to the GPU for the RHI rendering policy.  Additionally, widgets with a render transform of Scale, Rotation or Sheer, and their children are no longer pixel snapped, this should reduce some of jittering seen by users when animations are applied to widgets.  NOTE: This only affects render transforms, any transform in layout space is still subject to pixel snapping.

Change 3258607 on 2017/01/16 by Nick.Darnell

	Fixing the mac build.

Change 3258661 on 2017/01/16 by Matt.Kuhlenschmidt

	Actors with experimental components no longer say
	"Uses experimental class: Actor" when selecting the actor root in the details panel

	#jira UE-40535

Change 3258678 on 2017/01/16 by Nick.Darnell

	Platform - Introducing a way to get the mimetype for a file on Windows.  Other platforms don't yet have an implementation outside of returning application/unknown.

Change 3258924 on 2017/01/16 by Nick.Darnell

	Platform - Implementing a fallback for the generic platform http, that can do some basic mimetype lookups.

Change 3258929 on 2017/01/16 by Nick.Darnell

	UMG - Fixing the animation to finish the evaluation before it notifies that the animation completed.

Change 3259109 on 2017/01/16 by Nick.Darnell

	Platform - The GetMimeType function now only takes in FilePath, since some platforms will require that actually resolve to a file on disk in order to determine the true mimetype.

Change 3259111 on 2017/01/16 by Alexis.Matte

	Avoid to move the camera when we re-import in the static mesh editor
	#jira UE-40613

Change 3259275 on 2017/01/16 by Matt.Kuhlenschmidt

	Fix crash when a slate window is resized and calls into a scene viewport during loading code when the scene viewport is not in a slate hierarchy and thus has no widget

Change 3259300 on 2017/01/16 by Nick.Darnell

	UMG - Introducing PreConstruct and NativePreConstruct to the base UUserWidget.  Users can now visualize non-binding based changes in the designer by evaluating a very limited amount of the blueprint code.  In the event your user widget crashes on load, due to calling something unsafe, you can disable evaluation in the editor preferences under Widget Designer.

Change 3259306 on 2017/01/16 by Nick.Darnell

	Games - Removing the Game Specific implementations of PreConstruct.

Change 3260182 on 2017/01/17 by Matt.Kuhlenschmidt

	Fix static analysis

Change 3261049 on 2017/01/17 by Nick.Darnell

	Slate - Putting in some fixes for the non-gpu pixel snapping mode, and disabling gpu snapping while we dig into why it looks weird.

Change 3261434 on 2017/01/17 by Nick.Darnell

	Fixing the mac build.

Change 3261435 on 2017/01/17 by Nick.Darnell

	Slate - Tweaking some aspects of the slate rounding code on the GPU.  There's still some precision loss somewhere causing subtle differences in where the snap occurs, that's different from previously.

Change 3261460 on 2017/01/17 by Nick.Darnell

	UMG - Tweaking the defintiions of NativePreConstruct, dropping passing in design time since that is readily available in native code.

Change 3261833 on 2017/01/18 by Alexis.Matte

	Fix all warning for fbx automation tests
	#jira UE-40208

Change 3261874 on 2017/01/18 by Matt.Kuhlenschmidt

	PR #3136: Fix Submit to Source Control Window for Git plugin : use CanCheckIn() to filter out unmodified assets files (Contributed by SRombauts)

Change 3262000 on 2017/01/18 by Jamie.Dale

	Updated Slate to allocate widgets using MakeShared

	This saves one allocation per-widget

Change 3262003 on 2017/01/18 by Nick.Darnell

	UMG - Widget Interaction Components now ignore Visible(false) Widget Components when tracing.

	#jira UE-40523

Change 3262052 on 2017/01/18 by Alexis.Matte

	Put back the staticmesh skinxx workflow
	#jira UE-40782

Change 3262775 on 2017/01/18 by Nick.Darnell

	Slate - Ditching moving vertex rounding to the GPU, some precision issues could not be overcome.  Ended up writing a clean way to implement it on the CPU.

Change 3262818 on 2017/01/18 by Alex.Delesky

	#jira UE-40668 - Editor preferences will now save for data pin styles

Change 3263679 on 2017/01/19 by Nick.Darnell

	Slate - Adding some comments to the Slate Vertex Rounder.

Change 3265154 on 2017/01/19 by Nick.Darnell

	Slate/UMG - Putting in some more time into pixel snapping.  I've re-introduced the old constructors, and decided to go with the templated approach, as to not break old code that relied on the FSlateVertex working a certain way.

Change 3265478 on 2017/01/20 by Chris.Wood

	Added config support for hang detection time and switching hang detection on/off in UnrealWatchdog
	[UE-40838] - Make hang time configurable and increase default in UnrealWatchdog

Change 3265600 on 2017/01/20 by Nick.Darnell

	Slate - Making some const local variables const.

Change 3265714 on 2017/01/20 by Alex.Delesky

	#jira UE-40791 - The ForceFeedback thumbnail's Play and Stop icons will now render correctly, and will only be visible while an effect is playing or when the cursor hovers over the icon.

Change 3265865 on 2017/01/20 by Alex.Delesky

	#jira UE-40511 - The Content Browser file path will now update when inside a folder that is deleted from the Sources Panel.

Change 3267989 on 2017/01/23 by Jamie.Dale

	Exposed String Tables to Blueprints

Change 3268018 on 2017/01/23 by Jamie.Dale

	Small API clean-up for string tables

Change 3268455 on 2017/01/23 by Matt.Kuhlenschmidt

	Fix SaveAs (Which says SaveCurrentAs) not saving the current level and only saving the persistent level and then reloading everything thus causing work to be lost if editing a sub-level

	#jira UE-40930

Change 3269388 on 2017/01/24 by Chris.Wood

	Refactored tick timing in UnrealWatchdog to stop bug where it doesn't close.
	[UE-40839] - UnrealWatchdog running and blocking use of Unreal Game Sync for internal users

	Standalone tool code only - doesn't touch engine

Change 3270205 on 2017/01/24 by Cody.Albert

	Updated FUnrealEdMisc::OnMessageTokenActivated to properly traverse up the outer hierarchy of an object.

Change 3270231 on 2017/01/24 by Cody.Albert

	Renamed and exposed GetFullScreenAlignment and GetViewportAnchors for consistency with the setters

Change 3271734 on 2017/01/25 by Michael.Dupuis

	#jira UE-38631
	Add sorting for landscape target layer, user can now sort alphabetical, material based or custom
	Added a new vertical box SDragNDropVerticalBox to handle drag & drop of FSlot
	Fixed SDropTarget to only consider the drop action if it was started by it
	Added visibility toggle to only show used layers in the currently loaded data

Change 3271797 on 2017/01/25 by Jamie.Dale

	Renamed HasBeenAlreadyMadeSharable to DoesSharedInstanceExist as the old name was nonsense

Change 3271813 on 2017/01/25 by Jamie.Dale

	Fixed bad access of a shared this during widget destruction when a context menu was open

Change 3271988 on 2017/01/25 by Nick.Darnell

	Slate - Removing some old checkbox deprecated code from the 4.3 and 4.6 days.

Change 3271992 on 2017/01/25 by Nick.Darnell

	Blueprints - Making the checked call better to log out more information when dragging and dropping a missing property.

Change 3272134 on 2017/01/25 by Jamie.Dale

	Updated the GatherText commandlet to no longer hold a ConfigFile pointer while it runs

	This pointer is internal to GConfig, and may be updated (or invalidated) when other config files are loaded (as can happen via game code while gathering text).

Change 3272301 on 2017/01/25 by Nick.Darnell

	Slate - More cleanup from the removal of a old legacy enum that people were still using.

Change 3273070 on 2017/01/26 by Chris.Wood

	Fix CIS errors in landscape code from CL 3271734

Change 3273123 on 2017/01/26 by Chris.Wood

	Fix crash during init of CRC when running packaged without access to main engine config hierarchy.

Change 3273194 on 2017/01/26 by Nick.Darnell

	Fixing some build warnings.

Change 3273242 on 2017/01/26 by Michael.Dupuis

	#jira UE-39948 : if we detect there is multiple levels in the current persistent when we add a new foliage asset we ask to save the foliage as an asset to permit paiting over multiple levels

Change 3273279 on 2017/01/26 by Jamie.Dale

	String Table INI redirects are now in the "Core.StringTable" section (rather than "/Script/Engine.Engine")

Change 3273483 on 2017/01/26 by Alex.Delesky

	#jira UE-32047 - Made changes to the FixupRedirects commandlet to ensure that files that are marked for delete are moved from the default changelist to the pending changelist and submitted when using Perforce.

	Also makes a slight change to the ResavePackages commandlet to submit files marked for delete.

Change 3273568 on 2017/01/26 by Alex.Delesky

	Modifying changes made to SPluginWizard to have the plugin loading phase determined by the wizard's definition rather than from the first selected template.

	#jira none

Change 3273855 on 2017/01/26 by Alex.Delesky

	#jira UE-41117 - Updating the tooltip on the "Allow Paint of all LODs" option for mesh paint mode.

Change 3274200 on 2017/01/26 by Alex.Delesky

	For IPluginWizardDefinition, temporarily adding function bodies to two methods instead of having them be pure virtual methods.

Change 3274317 on 2017/01/26 by Jamie.Dale

	Deleting a seemingly corrupted asset that was accidentially submitted

Change 3275072 on 2017/01/27 by Michael.Dupuis

	#jira UE-38631 tweaks
	Fix typo error
	Iterate all components, not only active one
	Force expand the Target Layers widget

Change 3275249 on 2017/01/27 by Alexis.Matte

	Color grading controls: Keep the vector ratio when changing the master slider
	#jira UETOOL-1098

Change 3275282 on 2017/01/27 by Alexis.Matte

	Color grading controls: Cosmetic changes
	#jira UETOOL-1099

Change 3275292 on 2017/01/27 by Alexis.Matte

	Make sure the build is called once when we import a staticmesh.
	#jira UE-40947

Change 3275430 on 2017/01/27 by Alexis.Matte

	Add some fbx automation tests
	- Import a mesh with no material
	- Import corrupted asset with no section in a LOD
	- Import morph targets
	- Materials name clash
	- Max Multimap material ordering

Change 3275683 on 2017/01/27 by Michael.Dupuis

	#jira UE-41215 : when saving an asset do not register the transaction, and make sure that the duplicate wont keep a copy in the transaction buffer as an asset can't be undo

Change 3276237 on 2017/01/27 by Jamie.Dale

	Deleting a seemingly corrupted asset that was accidentially submitted

Change 3276266 on 2017/01/27 by Jamie.Dale

	Fix for accessing a potentially null pointer

Change 3277065 on 2017/01/30 by Chris.Wood

	Move crash report temp files to saved config and cleanup on schedule.
	[UE-39506] - CrashReportClient ini folders are not cleaned when opening the editor

Change 3277236 on 2017/01/30 by Matt.Kuhlenschmidt

	Fix crash when cancelling SaveCurrentLevelAs

	#jira UE-41182

Change 3277409 on 2017/01/30 by Jamie.Dale

	Improved text rendering when the last resort font is missing

	The last resort font is no longer included in shipping builds, so this change makes some improvements to text rendering when it's missing.

	- The legacy font cache no longer tries to use the last resort font if it's not available (preventing warnings).
	- The Slate font renderer no longer tries to use the last resort font if it's not available.
	- Text shaping will use the last resort character if none of the available fonts can render a given character (likely because the last resort font is missing).
	- HarfBuzz shaped text now uses the fallback character correctly.

Change 3277749 on 2017/01/30 by Nick.Darnell

	Slate - Moving ESlateDrawEffect & ESlateBatchDrawFlag over to be enum class, found cases where users were improperly assuming the enum order, and so now it won't be possible to just treat an int32 or a bool as the draw effect value.

	Core - Adding EnumHasAllFlags and EnumHasAnyFlags, templated functions to make it easier to check for the existance of a flag on enum classes.

Change 3277805 on 2017/01/30 by Nick.Darnell

	Rendering - Changing some LoadModuleChecked calls to GetModuleChecked, as these calls are not happening on the main thread and are not safe to make.

Change 3277914 on 2017/01/30 by Matt.Kuhlenschmidt

	Fix Niagara slate style warning on startup

Change 3278058 on 2017/01/30 by Matt.Kuhlenschmidt

	Fixed compile error

Change 3278132 on 2017/01/30 by Nick.Darnell

	Fixed compile error

Change 3278133 on 2017/01/30 by Matt.Kuhlenschmidt

	Fixed compile errors

Change 3278186 on 2017/01/30 by Nick.Darnell

	Fixed compile error

Change 3278525 on 2017/01/30 by Nick.Darnell

	Fixed compile error

Change 3278534 on 2017/01/30 by Nick.Darnell

	Automation - Clearing up several warnings/errors with automation results, trying to get Automation Tests to at least yellow before integration.

Change 3278941 on 2017/01/31 by Nick.Darnell

	Fixing a build warning due to build team refactor.

Change 3278949 on 2017/01/31 by Nick.Darnell

	Fixing incrmenetal build issues.

Change 3278953 on 2017/01/31 by Nick.Darnell

	Fixing some incrmental linux build issues.

Change 3278964 on 2017/01/31 by Nick.Darnell

	FIxing more incremental build issues.

Change 3279256 on 2017/01/31 by Michael.Dupuis

	#jira UE-41319
	#jira UE-41315
	#jira UE-41316
	Instead of getting the Landscape Actor, call GetLandscapeProxy so all case are handled, either proxy or landscape actor

Change 3279270 on 2017/01/31 by Chad.Garyet

	re-updating the automation test pool

[CL 3279775 by Matt Kuhlenschmidt in Main branch]
2017-01-31 15:22:49 -05:00
Ben Marsh
5275490168 Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3277940)
#lockdown Nick.Penwarden
#rb none

==========================
MAJOR FEATURES + CHANGES
==========================

Change 3233612 on 2016/12/13 by Ben.Marsh

	UGS: Fix cases where precompiled binaries are submitted for a content change.

Change 3235584 on 2016/12/14 by Ben.Marsh

	UBT: Deprecate the overridable TargetRules.ShouldUseSharedBuildEnvironment() function; targets should specify which build environment to use by setting the BuildEnvironment field in their constructor instead.

Change 3235741 on 2016/12/14 by Ben.Marsh

	UBT: Deprecate the SetupBinaries() callback on the TargetRules class. Instead of overriding this, targets may override their launch module through the "LaunchModuleName" property in their constructor, and add extra modules to the "ExtraModuleNames" field on the TargetRules object itself.

Change 3238176 on 2016/12/16 by Ben.Marsh

	UBT: New XML config file parser. Now reads once at startup and can be applied to instanced objects rather than global fields, and caches parsed output in a binary form for quicker initialization on subsequent runs.

Change 3238249 on 2016/12/16 by Ben.Marsh

	UBT: Add attribute-driven command line parser.

Change 3238462 on 2016/12/16 by Ben.Marsh

	UBT: Include the Platform, Configuration and Architecture on the TargetRules. Add a constructor which takes the TargetInfo object and deprecate the parameterless one; these fields are currently initialized before invoking the constructor in RulesAssembly.

Change 3238564 on 2016/12/16 by Ben.Marsh

	UBT: Deprecate the ModuleRules constructor which takes a TargetInfo argument. Replace it with a read-only wrapper around the target rules instead, so target-specific configuration options can be read without needing to access global static variables. Also require that it's passed to the base class constructor.

Change 3239919 on 2016/12/19 by Ben.Marsh

	UBT: Remove the "PreferredSubPlatform" property. This is only used for Windows XP support, which is being retired anyway. Having the target define its own architecture is an awkward contractiction to maintain support for, since the target rules are constructed after the architecture already has been determined.

Change 3240061 on 2016/12/19 by Ben.Marsh

	UBT: Remove ThirdPartyHeaderFinder. I don't think anything is using this any more.

Change 3240175 on 2016/12/19 by Ben.Marsh

	UBT: Add the target name and project file location to the target rules.

Change 3240490 on 2016/12/19 by Ben.Marsh

	UAT: Remove Mac staging code that requires UAT to compile and construct .target.cs files when packaging, to check bUseSteam and bUseCEF3 flags. libsteam_api.dylib is now staged at build time by adding it as a bundle resource, CEF3 is already marked as a runtime dependency by CEF3.build.cs, and UnrealCEFSubProcess.app is already marked as a runtime dependency from WebBrowser.build.cs.

Change 3240717 on 2016/12/20 by Ben.Marsh

	UAT: Allow configuring UAT to run as if on a build machine by passing the -buildmachine argument on the command line.

Change 3240718 on 2016/12/20 by Ben.Marsh

	UAT: Remove target-specific properties that are no longer used by staging (bUsesSlate, bUsesCEF3, etc...). This stuff should all be handled inside UBT.

Change 3241002 on 2016/12/20 by Ben.Marsh

	UBT: Move most target configuration settings from UEBuildConfiguration to TargetRules. This encapsulates target specific settings that will allow instancing multiple targets in the future. To facilitate migration of settings to their new location, "UEBuildConfiguration" is now a property that returns the current target rules instance.

Change 3241027 on 2016/12/20 by Ben.Marsh

	Only copy the Steamworks dylib into the app bundle for monolithic builds. For all other times, just add it as a runtime dependency.

Change 3241055 on 2016/12/20 by Ben.Marsh

	UBT: Only store a ReadOnlyTargetRules object on the instanced build target; finalize the configuration before it's instantiated.

Change 3241156 on 2016/12/20 by Ben.Marsh

	Update SwarmInterface.csproj to .NET framework 4.5, to match what all other C# tools are using.

Change 3241205 on 2016/12/20 by Ben.Marsh

	Replace all uses of TargetRules.TargetType with TargetType.

Change 3241881 on 2016/12/21 by Ben.Marsh

	UBT: Remove project file information from UEBuildContext base class. As configurable properties are moved on to the TargetRules object, it will no longer be a dependency to instantiate the platform with this path.

Change 3241895 on 2016/12/21 by Ben.Marsh

	UBT: Remove toolchain support for Windows XP.

Change 3241908 on 2016/12/21 by Ben.Marsh

	UBT: Move settings for windows targets into a WindowsTargetRules class, which is exposed for targets to modify via the TargetRules.WindowsPlatform field.

Change 3242835 on 2016/12/22 by Ben.Marsh

	UBT: Fix multiple binaries being created if plugins specify module names more than once. MfMedia.uplugin has MfMediaFactory listed twice.

Change 3242837 on 2016/12/22 by Ben.Marsh

	Change UE4EditorServices to include MacSystemIncludes rather than Cocoa.h directly; causes FVector to be defined incorrectly in non-unity builds.

Change 3242923 on 2016/12/22 by Ben.Marsh

	Build: Fixes for conforming incremental workspaces:

	* P4 have table is now reset before deleting all the files. This prevents Perforce being out of sync if the delete fails for some reason.
	* Incremental workspaces are skipped when running a clean operation, because they do not have a workspace capture file (causing a full re-sync, always). The "P4 Clean" option is still effective for cleaning these workspaces.

Change 3242961 on 2016/12/22 by Ben.Marsh

	UBT: Move entry points from PreBuildSync() and PostBuildSync() from UEToolChain to UEBuildPlatform, and make the original toolchain versions static. These functions are already at odds with the rest of the data flow within UBT because they rely on global state cached outside the toolchain instance, making assumptions that UBT is only ever going to be invoked with one target that's constructed in the same run and that nothing is being cached (eg. UBT makefiles). Moving them onto UEBuildPlatform simplifies the toolchain lifecycle for other platforms without leaving Mac and IOS any more limited than they were before.

Change 3242981 on 2016/12/22 by Ben.Marsh

	UBT: Remove symbol server handling code into UAT's platform library, since it's never needed from inside UBT.

Change 3242999 on 2016/12/22 by Ben.Marsh

	UBT: Remove the StripSymbols() function from the UEToolChain base class. This functionality is only required by UAT, so it's better suited to being exposed through UAT's modular platform classes.

Change 3243022 on 2016/12/22 by Ben.Marsh

	UBT: Require an instance of the target rules to be able to construct a toolchain in UBT. This will allow configuring toolchain-specific options from the target, using reflection from config files, and the command line.

Change 3243083 on 2016/12/22 by Ben.Marsh

	UBT: Move settings for the Windows compiler version to use onto the Windows-specific target rules.

Change 3243090 on 2016/12/22 by Ben.Marsh

	UBT: Change the third party paths in UEBuildConfiguration to constants. Changing these would not work.

Change 3243423 on 2016/12/23 by Ben.Marsh

	UBT: Move a lot of settings from BuildConfiguration to TargetRules. This allows different targets to have different settings, naturally, and moves converts argument parsing and config to be driven by attributes.

Change 3243516 on 2016/12/23 by Ben.Marsh

	UBT: Remove the ValidateUEBuildConfiguration callback, which is no longer used. (XGE settings validation occurs in XGE.cs)

Change 3244020 on 2016/12/28 by Ben.Marsh

	UBT: Remove the BaseIntermediatePath static property. Precursor to removing RelativeEnginePath and IntermediateFolder properties.

Change 3244074 on 2016/12/28 by Ben.Marsh

	UBT: Remove the RelativeEnginePath variable from BuildConfiguration. UnrealBuildTool.EngineDirectory gives the absolute path, and can be used to construct a relative path when necessary.

Change 3244076 on 2016/12/28 by Ben.Marsh

	UBT: Remove BuildConfiguration.BaseIntermediateFolder; just use a fixed directory everywhere instead.

Change 3244083 on 2016/12/28 by Ben.Marsh

	UBT: Replace FileReference and DirectoryReference instance methods for manipulating files and directories with static methods, to mirror the System.IO.File and System.IO.Directory classes.

Change 3244441 on 2016/12/31 by Ben.Marsh

	UBT: Remove code to force PDBs when building with no debug info under XGE. Verified described symptoms (that it causes PCH generation to be serialized) no longer occur.

Change 3244687 on 2017/01/03 by Matthew.Griffin

	Changed Exception to use FirstInclude.IncludeName as PrecompiledHeaderIncludeFilename can be null when this occurs

Change 3246112 on 2017/01/04 by Ben.Marsh

	UBT: Fix UHT failures building some targets with the -useprecompiled option, due to differences in the order that circularly dependent modules are parsed. Precompiled binaries are now kept in the regular AppBinaries list, but are excluded from the build at the last minute. Also change some checks from IsEngineInstalled() to bUsePrecompiled, to prevent headers being overwritten when running in a non-installed precompiled build.

Change 3246223 on 2017/01/04 by Ben.Marsh

	UBT: Prevent version manifests being overridden if a file is not being built as part of the target.

Change 3246387 on 2017/01/04 by Ben.Marsh

	UBT: Remove BuildConfiguration settings for UnrealCodeAnalyzer. This tool isn't used at the moment, but it's configured using global variables accessed from all over the UBT codebase, making it difficult to refactor the build options into an instanced object. If we bring this tool back from the dead in the future, it should be possible to implement it using the exported JSON target definition or the XGE manifest, similarly to how IncludeTool uses it.

Change 3247004 on 2017/01/04 by Ben.Marsh

	UBT: Simplify the logic for cleaning targets in UBT. Now uses FileReference/DirectoryReference objects everywhere, doesn't require the compile/link environment, and does all the checking to avoid deleting precompiled binaries in one place.

Change 3247250 on 2017/01/04 by Ben.Marsh

	UBT: Prevent precompiled binaries being added to the list of app binaries twice.

Change 3247594 on 2017/01/05 by Ben.Marsh

	Build: Run sample and template editors on the same agents as the other incremental builds. Remove ProtoStar, which does not have any non-precompiled editor target to build.

Change 3247763 on 2017/01/05 by Ben.Marsh

	UBT: Allow the toolchain to update the list of build products for each module linked into a binary. Allows Mac to add dylibs and bundle resources specified per-module without having to construct a link environment and try to link them.

Change 3247775 on 2017/01/05 by Ben.Marsh

	UBT: Instance the target compile and link environments when they are required during building, and don't persist them on the UEBuildTarget instance.

Change 3247811 on 2017/01/05 by Ben.Marsh

	EC: Add a batch file for testing postp filters.

Change 3247839 on 2017/01/05 by Ben.Marsh

	EC: Include the name of the file being compiled when parsing MSVC errors and warnings.

Change 3248101 on 2017/01/05 by Ben.Marsh

	UBT: Fix Android support for force included headers.

Change 3248533 on 2017/01/05 by Ben.Marsh

	PR #3097: UBT project supports optional platforms (Contributed by PrimalJohnScott)

Change 3249205 on 2017/01/06 by Ben.Marsh

	UAT: Fix ParseTaggedP4Output throwing an exception if the same key name is specified more than once. This can happen when parsing the output from "P4 INFO", where multiple brokers are present.

Change 3249249 on 2017/01/06 by Ben.Marsh

	UBT: Check for the existance of AndroidManifest.xml within extracted AAR directories, rather than just checking for the existance of the directory itself. Perforce does not remove empty directories when cleaning a workspace unless the rmdir option is on the workspace, so this can cause incremental build failures to fail on build machines.

Change 3249486 on 2017/01/06 by Ben.Marsh

	UBT: Use relative paths in unity files when compiling for Mac/IOS, rather than generating a separate local/remote version of the file for gathering include dependencies. Absolute paths are only used to work around the way that MSVC concatenates paths internally; we don't hit the same problems when checking dependencies.

Change 3249736 on 2017/01/06 by Ben.Marsh

	UBT: Rename CPPEnvironment to CppCompileEnvironment, and remove the separate CPPEnvironmentConfiguration object. All settings are now stored directly on the CppCompileEnvironment object.

Change 3250179 on 2017/01/07 by Ben.Marsh

	Fix creating installed build when root directory contains a space in the name.

Change 3250181 on 2017/01/07 by Ben.Marsh

	UBT: Remove some esoteric (and unused, AFAIK) options for orthogonally building different platforms.

Change 3250223 on 2017/01/07 by Ben.Marsh

	UBT: Merge the LinkEnvironment and LinkEnvironmentConfiguration classes together.

Change 3250233 on 2017/01/07 by Ben.Marsh

	UGS: Allow specifying a workspace-specific sync filter, which is applied on top of the standard filter. Also fix filter being cleared if the cancel button is pressed, and help text being stripped out.

Change 3250241 on 2017/01/07 by Ben.Marsh

	UBT: Move the options for specifying additional Android architectures to target onto an Android-specific object on the TargetRules.

Change 3250400 on 2017/01/08 by Ben.Marsh

	UBT: Move executor config settings onto the executor instances.

Change 3257708 on 2017/01/13 by Ben.Marsh

	UBT: Remove the ThirdPartySourceDirectory constant; there are many places which hard-code or assume this location anyway, and it's not going to change.

Change 3260535 on 2017/01/17 by Ben.Marsh

	Add an optional "RequiredSubmittedChange" setting to EC settings files. Allows a scheduled job to run even if there have been no code changes submitted. Test with the utilization capture job.

Change 3260875 on 2017/01/17 by Ben.Marsh

	EC: Fix workspaces getting out of sync wrt. newly added files when jobs are aborted during a sync. In such cases, the P4 have table indicates the new files have been synced locally, but the workspace is forced back to a state before it had them due to the capture file. When a following sync tries to add them again, P4 believes the workspace already has them synced.

	To work around this, we now write an additional file to the root folder of a workspace containing the last CL that was captured, and sync back to it before doing the reconcile.

Change 3261724 on 2017/01/18 by Ben.Marsh

	Allow filtering job types from the list view in EC. Hide the utilization capture job by default. Also set up notifications for the utilization capture job.

Change 3261756 on 2017/01/18 by Ben.Marsh

	IncludeTool: Prevent matching a full enum declaration as a forward declaration.

Change 3261932 on 2017/01/18 by Ben.Marsh

	EC: Add support for specifying days of the week in schedules. The following syntaxes are supported:

	"Monday, Tuesday and Wednesday at 10:30"
	"Daily except Sunday and Wednesday at 14:30"

	 Also tweak display of dates relative to now to handle dates/times in the future, and include the date when specifying a day name.

	#jira UEB-729

Change 3262676 on 2017/01/18 by Ben.Marsh

	UBT: Split UBTMakefile into its own file. (From PR #3106)

Change 3263893 on 2017/01/19 by Ben.Marsh

	UBT: Stop exporting platform classes from UBT, as well as all the referenced classes that have to be made public as a result. Any platform-specific functionality that needs to be shared with UAT is now exposed through wrappers in separate public classes, eg. WindowsExports.cs, IOSExports.cs, etc...

Change 3264291 on 2017/01/19 by Ben.Marsh

	UBT: Fix errors generating documentation in UBT, and enable it by default. Will catch more errors with new code being added. Originally in PR #3106, but redone due to conflicts.

Change 3264534 on 2017/01/19 by Ben.Marsh

	UBT: Include plugin config files in generated projects.

Change 3264571 on 2017/01/19 by Ben.Marsh

	UBT: Prevent overwriting .modules files if nothing has changed. On builders, it's common to build multiple editors in the same workspace, and changing the last modified timestamp causes BuildGraph to fail due to tampered files.

Change 3265745 on 2017/01/20 by Ben.Marsh

	UGS: Automatically open UGS when running the launcher for a second time, rather than prompting to close the original instance.

Change 3265777 on 2017/01/20 by Ben.Marsh

	UGS: Automatically close and reopen when UGS is re-ran with the shift key held down to switch into unstable mode.

Change 3268314 on 2017/01/23 by Ben.Marsh

	UBT: Make sure version manifests are stable by sorting the list of build products, so they are only touched if the contents have really changed.

Change 3269601 on 2017/01/24 by Ben.Marsh

	UBT: Fix symbol files being added to manifest for some platforms even though debug info is disabled.

Change 3269607 on 2017/01/24 by Ben.Marsh

	UBT: Fix bug where UBT would need to be invoked when switching between two editors sharing the same engine binaries on Mac. The location of the .modules file cannot be guessed on Mac by looking in the same directory as the primary output executable because it's an .app bundle, and the actual modules are nested several directories below that.

Change 3269608 on 2017/01/24 by Ben.Marsh

	UBT: Fix additional files copied into the app bundle always being updated on Mac. Now uses rsync --checksum to make sure only modified files are updated.

Change 3271062 on 2017/01/24 by Ben.Marsh

	UBT: Fixes for bugs detected by PVS Studio (PR #3161)

Change 3272421 on 2017/01/25 by Ben.Marsh

	Fix commends regarding DDC in BaseEngine.ini

	#jira UE-41076

Change 3272810 on 2017/01/25 by Ben.Marsh

	Fix VS2017 being displayed as 'Visual Studio 15' in the Windows target settings panel.

Change 3272935 on 2017/01/25 by Ben.Marsh

	Fix Metal errors launching on Mac due to use of OSX environment settings before they are initialized. Toolchain settings are now constructed on demand in a separate class, for Mac, iOS and TVOS.

Change 3274167 on 2017/01/26 by Ben.Marsh

	Fix resource files not being compiled in installed builds on Windows. Was causing metadata not to be embedded into executables.

	#jira UE-36457

Change 3275557 on 2017/01/27 by Ben.Marsh

	Expand checks for propagation of restricted folder names to include source files, and to ensure that each restricted folder is represented in the output. Also improve messaging to show the dependency chain leading to a restricted folder being referenced, and which folder it is.

Change 3275628 on 2017/01/27 by Ben.Marsh

	UBT: Splitting configuration files into one class per-file.

Change 3276784 on 2017/01/29 by Ben.Marsh

	Add an authoritative list of confidential folder names, and expose it through global BuildGraph properties ($(RestrictedFolderNames) and $(RestrictedFolderFilter)). Also switch existing scripts to use it.

Change 3276792 on 2017/01/29 by Ben.Marsh

	UBT: Use UE4CSharp.prog files to indicate which projects should be included in the solution without having to hard-code a list of them in UBT.

Change 3277263 on 2017/01/30 by Ben.Marsh

	IncludeTool: Merging various fixes.

	* Fix warnings about #include directives after first code block from parsing monolithic headers.
	* Fix exception on startup if the intermediate directory does not already exist.
	* Add a special case for ignoring missing header guards from MonolithicHeaderBoilerplate.h, rather than marking it as an inline header. Marking it as inline prevents parsing include directives, which results in including CoreTypes.h from the wrong location.
	* Create job objects for spawned compiler instances to prevent them trying allocating more memory than the system can spare.
	* Remove (unused) code which makes assumptions about files ending with "Classes.h".
	* Add a verbose per-file output log to aid with debugging.
	* Negate the MakeStandalone command line option, which was added to allow tweaking forward declarations in already optimized files, so the optimized output does not have missing headers by default.
	* Fix missing headers when creating standalone files, due to incorrect list of previous files being passed in to the OutputFile constructor. Now passes the original list of included files, not the output list.
	* Fix initial header for a cpp file sometimes being removed. Forcibly including a header at the start of the file does not use the normal pathway for spidering through includes, so a second include of the same file was being generated. Any includes of that header were being forced into output, and the earlier include was then removed due to being redundant.
	* Prevent forward declaring enums which have to be parsed by UHT. UHT relies on includes to determine a parse order, and will fail if the enum definition has not been parsed first.
	* Use a relative path for private includes in the same module if there are any. Fixes some incorrect paths, and makes it clearer that we're doing something we shouldn't.

Change 3277307 on 2017/01/30 by Ben.Marsh

	UBT: Fix private PCHs not using correct header. Causes custom definitions to be excluded from the command line.

[CL 3278101 by Ben Marsh in Main branch]
2017-01-30 16:52:08 -05:00
Ben Marsh
20bf0eb6a1 Updating copyright notices to 2017 (copying from //Tasks/UE4/Dev-Copyright-2017).
#rb none
#lockdown Nick.Penwarden

[CL 3226823 by Ben Marsh in Main branch]
2016-12-08 08:52:44 -05:00
Ben Marsh
4ba423868f Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none

==========================
MAJOR FEATURES + CHANGES
==========================

Change 3209340 on 2016/11/23 by Ben.Marsh

	Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.

	Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.

	  * Every header now includes everything it needs to compile.
	        * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
	        * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
	  * Every .cpp file includes its matching .h file first.
	        * This helps validate that each header is including everything it needs to compile.
	  * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
	        * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
	        * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
	  * No engine code explicitly includes a precompiled header any more.
	        * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
	        * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.

	Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.

[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
Leslie Nivison
29007ff202 Stripping out inaccurate/easily misconstrued .tps info in preparation for exposing this to licensees
#rb none
#lockdown Nick.Penwarden

[CL 3154391 by Leslie Nivison in Main branch]
2016-10-07 00:40:14 -04:00
Robert Manuszewski
af30c884a5 Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3049602)
==========================
MAJOR FEATURES + CHANGES
==========================

Change 2946506 on 2016/04/18 by Steven.Hutton

	Update to Crash Reporter buggs table to add new search fields and inclusion of packages needed for e-mail reports.

Change 3017807 on 2016/06/17 by Chris.Wood

	Improved Crash Report Process folder delete code as it could sometimes fail.
	[UE-30349] - Crash Report Process is leaving crashes in the landing zone that build up and block the queue

	Also added logging to Slack when stop request received instead of just when stop is complete.

Change 3019367 on 2016/06/20 by Chris.Wood

	Improve Crash Report Process logging to track bad reads from S3.
	Also, better logging when CleanReport fails to delete folders.

Change 3019376 on 2016/06/20 by Steve.Robb

	Clarification of assert message and comments which talk about 'null' TFunctions.
	Tidy-up of dead code.

Change 3019409 on 2016/06/20 by Steve.Robb

	New Find and FindByPredicate algorithms for finding stuff in arbitrary containers.

Change 3022658 on 2016/06/22 by Chris.Wood

	Discarding duplicated crash reports earlier in read from Data Router process to avoid clashes in the landing zone (CRP v1.1.11)
	[UE-30349] - Crash Report Process is leaving crashes in the landing zone that build up and block the queue

	Also improved logging to Slack with better layout, fixed event ordering and counting duplicates.

Change 3022840 on 2016/06/22 by Steve.Robb

	Skipped UHT attributes removed.

Change 3022907 on 2016/06/22 by Robert.Manuszewski

	Fixing crash when adding a new C++ class to project

	#jira UE-32333

Change 3023169 on 2016/06/22 by Steve.Robb

	Checks for UTHINGs in skipped preprocessor blocks.
	Fixes for skipped UTHINGs and some other parsing accidents.

	#jira UE-31627

Change 3023239 on 2016/06/22 by Steve.Robb

	Fix for JSON date parsing reported here: https://udn.unrealengine.com/questions/299342/fdatetime-json-serialization-bug.html

Change 3026812 on 2016/06/24 by Mieszko.Zielinski

	Marked FEnvQueryInstance::AddItemData UEnvQueryItemType_Point specialization as AIMODULE_API #UE4

Change 3028235 on 2016/06/27 by Robert.Manuszewski

	PR #2535: BUGFIX: FPS pop-up updates when loading new stat file (Contributed by projectgheist)

Change 3028282 on 2016/06/27 by Steve.Robb

	Fix for missing UFUNCTION check in skipped preprocessor blocks.

	#jira UE-31627

Change 3028284 on 2016/06/27 by Steve.Robb

	Debuggability improvements and coding standards changes.

Change 3028343 on 2016/06/27 by Steve.Robb

	Fix for UHT error in WEX.

	#jira UE-32464

Change 3028393 on 2016/06/27 by Steve.Robb

	Fix for hot reload of enums finding the old enum.
	Fix to stop SPropertyEditorNumeric caching the enum flags.

	#jira UE-31658

Change 3030362 on 2016/06/28 by Robert.Manuszewski

	Fixing hang when cooking.

Change 3030462 on 2016/06/28 by Steve.Robb

	Assert added to PackageTools::GetFilteredPackageList() to help with catching a bug reported in the wild.

	#jira UE-32001

Change 3034341 on 2016/06/30 by Robert.Manuszewski

	Modified crash handling code (on Windows) to handle two threads crashing at the same time properly.  Previously the second crash would force the process to exit before generating the crash report.

	Added 'debug twothreadsgpf' command to test the functionality.

Change 3034342 on 2016/06/30 by John.Mahoney

	Fix for crash when loading an empty cached asset registry.

	#jira UE-32232

Change 3035599 on 2016/07/01 by Chris.Wood

	Added support for CrashType string to Crash Report Process. CRP v1.1.12
	[UE-30592] - Crash Reporter should determine crash type on client and pass string to server

	Also fixes problem with reports falling back on the legacy WER metadata when a crash context exists. They now only read the error message from metadata if available and keep crash context data when possible.

	Added in missing crash context parameters that have been added to clients but not known by the server.

Change 3035787 on 2016/07/01 by John.Mahoney

	Fix for crash when DuplicateRedirects does not contain the DependentObject when saving dependencies. It will still fall through to the assertion below, but it will now fail with a useful error message instead of a generic 'Pair != nullptr' from Map.h.

	#jira UE-30189

Change 3036933 on 2016/07/04 by Steve.Robb

	Proper forwarding constructor for FAsyncTask.

Change 3036938 on 2016/07/04 by Steve.Robb

	Fix for CDO hot reload corrupting memory when replacing references inside structs.

	#jira UE-29335

Change 3036960 on 2016/07/04 by Steve.Robb

	Fix for FAnsiAllocator::ResizeAllocation when resizing to zero.

Change 3037423 on 2016/07/05 by Steve.Robb

	FModuleManager::UnloadOrAbandonModuleWithCallback split into two instead of switching behavior with a bool.

Change 3037464 on 2016/07/05 by Steve.Robb

	HotReload.cpp cleanup:

	Deep nesting flattened.
	Linear array searches replaced with maps.
	FHotReloadModule::GetGameModules made into a non-member function and split into two.
	Comment and coding standard fixes.

Change 3037741 on 2016/07/05 by John.Mahoney

	Fix for COTF not checking the correct timestamps on startup.

	#jira UE-31023

Change 3037846 on 2016/07/05 by Steve.Robb

	Fix for compile button disappearing on a bad compile.

	#jira UE-31575

Change 3037994 on 2016/07/05 by Steve.Robb

	Static analysis fixes:

	warning C6308: 'realloc' might return null pointer: assigning null pointer to 'Data', which is passed as an argument to 'realloc', will cause the original memory block to be leaked.

Change 3039186 on 2016/07/06 by Robert.Manuszewski

	Enabling crash callstack logging by default.

Change 3039220 on 2016/07/06 by Steve.Robb

	Static analysis fixes:

	warning C28159: Consider using 'InitiateSystemShutdownEx' instead of 'ExitWindowsEx'. Reason: Legacy API. Rearchitect to avoid Reboot
	warning C6001: Using uninitialized memory 'UserNameLength'
	warning C6001: Using uninitialized memory 'DomainNameLength'

Change 3039230 on 2016/07/06 by Steve.Robb

	Fix for VC internal compiler errors.

Change 3039237 on 2016/07/06 by Steve.Robb

	Static analysis fix: warning C6385: Reading invalid data from 'Path':  the readable size is '400' bytes, but 'PathCurrentDepth' bytes may be read.

Change 3039287 on 2016/07/06 by Steve.Robb

	Static analysis fixes:

	warning C6509: Invalid annotation: 'return' cannot be referenced in some contexts
	warning C6101: Returning uninitialized memory '*lpdwExitCode'.  A successful path through the function does not set the named _Out_ parameter.
	warning C6387: '_Param_(1)' could be '0':  this does not adhere to the specification for the function 'IMoniker::BindToStorage'.
	warning C6387: '_Param_(1)' could be '0':  this does not adhere to the specification for the function 'IMoniker::BindToObject'.
	warning C6031: Return value ignored: 'CoCreateInstance'.

Change 3039359 on 2016/07/06 by Graeme.Thornton

	Compile error fix for FAsyncTask, courtesy of SteveR

Change 3039534 on 2016/07/06 by Steve.Robb

	Static analysis fix: warning C6319: Use of the comma-operator in a tested expression causes the left argument to be ignored when it has no side-effects.

Change 3039545 on 2016/07/06 by Steve.Robb

	Static analysis fix: warning C6297: Arithmetic overflow:  32-bit value is shifted, then cast to 64-bit value.  Results might not be an expected value.

Change 3039578 on 2016/07/06 by Steve.Robb

	Static analysis fix: warning C6263: Using _alloca in a loop:  this can quickly overflow stack.

Change 3039623 on 2016/07/06 by Steve.Robb

	Static analysis fixes:

	warning C6011: Dereferencing NULL pointer 'X'
	warning C6308:'realloc' might return null pointer: assigning null pointer to 'X', which is passed as an argument to 'realloc', will cause the original memory block to be leaked.
	warning C6385: Reading invalid data from 'X':  the readable size is 'Y' bytes, but 'Z' bytes may be read.
	warning C6386: Buffer overrun while writing to 'X':  the writable size is 'Y' bytes, but 'Z' bytes might be written.
	warning C28182: Dereferencing NULL pointer. 'X' contains the same NULL value as 'Y' did.

Change 3039630 on 2016/07/06 by John.Mahoney

	Fix for crash when spawning an actor using a template object that has instance components. UActorComponent::PostInitProperties was adding itself to the owner's InstanceComponents array, resulting in a realloc of that array and invalidating the reference that the owner's ObjectInitializer was trying to replace while instantiating that property. The new instance component will be added to the array as part of the owner's initialization anyway, so it is not necessary to do it here.

	#jira UE-29123

Change 3039664 on 2016/07/06 by Steve.Robb

	Static analysis fixes:

	warning C6386: Buffer overrun while writing to 'NewKeys':  the writable size is 'NewIndexSize*4' bytes, but '8' bytes might be written.
	warning C6386: Buffer overrun while writing to 'NewHeapIndexes':  the writable size is 'NewIndexSize*4' bytes, but '8' bytes might be written.

Change 3039673 on 2016/07/06 by Steve.Robb

	Static analysis fix: warning C6011: Dereferencing NULL pointer 'v'.

Change 3039690 on 2016/07/06 by Steve.Robb

	Static analysis fixes:

	warning C6011: Dereferencing NULL pointer 'X'.
	warning C6246: Local declaration of 'X' hides declaration of the same name in outer scope.
	warning C6262: Function uses '121180' bytes of stack:  exceeds /analyze:stacksize '81940'.  Consider moving some data to heap.
	warning C6263: Using _alloca in a loop:  this can quickly overflow stack.

Change 3040868 on 2016/07/07 by Graeme.Thornton

	Config based class stripping for server builds

Change 3040872 on 2016/07/07 by Graeme.Thornton

	Remove "return false" NeedsLoadForServer functions from engine code

Change 3040997 on 2016/07/07 by Steve.Robb

	Static analysis fixes:

	warning C6011: Dereferencing NULL pointer 'Landscape'.
	warning C6011: Dereferencing NULL pointer 'rhs.Allocation.LayerInfo'.
	warning C6011: Dereferencing NULL pointer 'lhs.Allocation.LayerInfo'.

Change 3041004 on 2016/07/07 by Steve.Robb

	Static analysis fix: warning C6336: Arithmetic operator has precedence over question operator, use parentheses to clarify intent.

Change 3041014 on 2016/07/07 by Steve.Robb

	Static analysis fix: warning C6287: Redundant code:  the left and right sub-expressions are identical.

Change 3041111 on 2016/07/07 by Steve.Robb

	Removal of an obsolete error message about INI file case sensitivity.

Change 3041150 on 2016/07/07 by Steve.Robb

	Static analysis fix: warning C6289: Incorrect operator:  mutual exclusion over || is always a non-zero constant.  Did you intend to use && instead?

Change 3041274 on 2016/07/07 by Steve.Robb

	Static analysis fixes: warning C6001: Using uninitialized memory 'X'.

Change 3041294 on 2016/07/07 by Chris.Wood

	Fixed protocol buffer and decompression errors in Crash Report Process (v.1.1.14)
	[UE-32151] - High number of crashes read from S3 by Crash Report Process are failing to unpack

	Size of buffer received from S3 is incorrect for some records. Fixed read problems by using size header value instead of stream length.

	Increased buffer size for decompression as this was sometimes too small.

	Modified S3 reading code to look for multiple records in each downloaded file.

Change 3041472 on 2016/07/07 by Steve.Robb

	Static analysis fixes:

	warning C6294: Ill-defined for-loop:  initial condition does not satisfy test.  Loop body not executed.
	warning C6201: Index '1' is out of valid index range '0' to '0' for possibly stack allocated buffer 'NewHistory.Nodes'.

Change 3043074 on 2016/07/08 by John.Mahoney

	Fix for COTF incorrectly reconstructing the original asset path based on the sandbox path when the game name differs from the game folder name.
	Fix for COTF GetFiles not handling absolute GameDir paths properly.

	#jira UE-31023

Change 3044461 on 2016/07/11 by Steve.Robb

	Static analysis fix: warning C6386: Buffer overrun while writing to 'Attributes':  the writable size is '16384' bytes, but '-8' bytes might be written.

Change 3044470 on 2016/07/11 by Steve.Robb

	Static analysis fix: warning C6011: Dereferencing NULL pointer 'Node.Sequence'.

Change 3044476 on 2016/07/11 by Steve.Robb

	Static analysis fix: warning C6011: Dereferencing NULL pointer 'Property'.

Change 3044551 on 2016/07/11 by Steve.Robb

	Static analysis fix: warning C28182: Dereferencing NULL pointer. 'Node' contains the same NULL value as 'KeyAreaNode' did.

Change 3044664 on 2016/07/11 by Steve.Robb

	Static analysis fixes:

	warning C6011: Dereferencing NULL pointer 'ToLandscape->SplineComponent'.
	warning C28182: Dereferencing NULL pointer. 'SplinesComponent' contains the same NULL value as 'Landscape->SplineComponent' did.
	warning C6011: Dereferencing NULL pointer 'Landscape->SplineComponent'.
	warning C6385: Reading invalid data from 'out':  the readable size is 'sizeof(kiss_fft_cpx)*Dims[0]*Dims[1]' bytes, but '16' bytes may be read.

Change 3044716 on 2016/07/11 by Steve.Robb

	Static analysis fix: warning C6385: Reading invalid data from 'this->ScreenSize':  the readable size is '32' bytes, but '-4' bytes may be read.

Change 3044717 on 2016/07/11 by Steve.Robb

	Static analysis fix: warning C28182: Dereferencing NULL pointer. 'Window' contains the same NULL value as 'ElementType * Window=AllWindows.FindByPredicate((*FStaticMeshEditorTest::RunTest::<lambda_46fd0093f3912289e870263afe1fcb2e>(ExpectedTitle)))' did.

	This appears to be a false positive.

Change 3044787 on 2016/07/11 by Steve.Robb

	Static analysis fixes:

	warning C6011: Dereferencing NULL pointer 'FbxObject'.
	warning C28182: Dereferencing NULL pointer. 'Node' contains the same NULL value as 'RigidMeshNode' did.
	warning C28182: Dereferencing NULL pointer. 'Node' contains the same NULL value as 'Result' did.

Change 3045933 on 2016/07/12 by Steve.Robb

	Overloading support for TSharedPtr, TSharedRef and TWeakPtr.

Change 3045960 on 2016/07/12 by Robert.Manuszewski

	Fixing a crash in Portal (and any other program that uses UObjects and GCs, with the exception of UHT) caused by classes not having their token stream assembled.

Change 3045963 on 2016/07/12 by Steve.Robb

	PLATFORM_COMPILER_HAS_EXPLICIT_OPERATORS, FORCEINLINE_EXPLICIT_OPERATOR_BOOL and SAFE_BOOL_OPERATORS macros removed.
	THasOperatorEquals and THasOperatorNotEquals traits moved to their own header.

Change 3045967 on 2016/07/12 by Steve.Robb

	Initializer list support for TArray and TSet.

Change 3045968 on 2016/07/12 by Robert.Manuszewski

	Fixing an ensure after typing 'stat dumphitches' in console.

Change 3045992 on 2016/07/12 by Robert.Manuszewski

	Making sure CoreUObject headers are included for programs that don't include the engine (fixing MinidumpDiagnostics CIS failure)

Change 3047870 on 2016/07/13 by Steven.Hutton

	Updated CRW to entity framework with repository models. #rb none

Change 3047871 on 2016/07/13 by Steven.Hutton

	Add repository models #rb none

Change 3049468 on 2016/07/14 by Steven.Hutton

	Fix broken project files. #rb none

#lockdown Nick.Penwarden

[CL 3050320 by Robert Manuszewski in Main branch]
2016-07-14 14:54:00 -04:00
Unrealbot
e05d94470b Branch snapshot for CL 3018379
[CL 3018379 in Main branch]
2016-06-17 17:28:41 -04:00
Matthew Griffin
bb70b349ce Merging CL 2804086 from //UE4/Release-4.11 to Dev-Main (//UE4/Dev-Main) to isolate copyright update
#lockdown Nick.Penwarden

[CL 2819020 by Matthew Griffin in Main branch]
2016-01-07 08:17:16 -05:00
Matthew Griffin
0ce98f34ca Merging //UE4/Release-4.11 to Dev-Main (//UE4/Dev-Main) (pre copyright update in revision 2804086)
#lockdown nick.penwarden

[CL 2818924 by Matthew Griffin in Main branch]
2016-01-07 04:39:47 -05:00
Leslie Nivison
ff3eaf36d2 Updating TPS files
[CL 2681371 by Leslie Nivison in Main branch]
2015-09-04 20:53:02 -04:00
Ben Marsh
55d1385e2e Add attribute serialization to XmlFile writer.
[CL 2548769 by Ben Marsh in Main branch]
2015-05-13 08:16:52 -04:00
Mike Fricker
2afcef78aa Fixed CIS error on mac with FastXml
[CL 2535895 by Mike Fricker in Main branch]
2015-05-04 12:14:44 -04:00
Mike Fricker
29e46a1bad Fast Xml parser for UE4
This is a simple XML parser that can load XML files very quickly.  The new FFastXml class has a single static method ParseXmlFile() for loading XML files.  The parser is designed to load files efficiently, but may not support all XML features or be resilient to malformed data.  Unlike the FXmlFile class, FFastXml does not generate an XML node tree.  Instead, you must supply a callback class using IFastXmlCallback and respond to elements and attributes as they are parsed.  Call the ParseXmlFile() function and pass in either the full path to the XML file to parse (XmlFilePath parameter), or load the file yourself and pass the contents using the XmlFileContents parameter.  One of either XmlFilePath or XmlFileContents must be valid for ParseXmlFile() to work.

To process the XML data, create your own class that implements the IFastXmlCallback interface.  This class will be responsible for processing the XML elements as they are loaded by FFastXml::ParseXmlFile().  You'll receive a ProcessElement() call for every XML element that is encountered, along with a corresponding ProcessClose() when that element's scope has ended.  ProcessAttribute() will be called for any attributes found within the scope of the current element.

Remember to add a module dependency on "XmlParser" in order to be able to call FFastXml::ParserXmlFile().

This XML parser based on John W. Ratcliff's "FastXml". (FastXml.tps included, with more info.)

[CL 2535797 by Mike Fricker in Main branch]
2015-05-04 11:00:39 -04:00
Ben Marsh
b21b7e3fa8 Fix parsing of XML attributes whose values contain '=' characters, and translate named entities correctly.
[CL 2516789 by Ben Marsh in Main branch]
2015-04-18 12:58:02 -04:00
Saul Abreu
79a26091bf Fixed behavior on FString::ParseIntoArray (muliple delimiters overload) functionality to support optionally culling empty strings. Greatly simplified implementation logic. Output parameter now properly named and taken by reference.
#codereview Steve.Robb, Robert.Manuszewski

[CL 2466824 by Saul Abreu in Main branch]
2015-03-02 15:51:37 -05:00
Jaroslaw Surowiec
2bcb1c27f1 XmlParser - Added method SetContent to the FXmlNode
[CL 2423994 by Jaroslaw Surowiec in Main branch]
2015-01-29 12:33:00 -05:00
Ben Marsh
149375b14b Update copyright notices to 2015.
[CL 2379638 by Ben Marsh in Main branch]
2014-12-07 19:09:38 -05:00
Mike Fricker
a717a7e08d XML Parser: Allow anonymous discovery of node attributes
- Added new GetAttributes() method to FXmlNode that returns all of the attributes in the node

[CL 2346695 by Mike Fricker in Main branch]
2014-11-03 07:34:29 -05:00
Mike Fricker
07948b6ba6 Moved XmlParser from 'Developer' to 'Runtime' so it can be used in shipping games
[CL 2110490 by Mike Fricker in Main branch]
2014-06-19 11:22:41 -04:00