#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3118934 on 2016/09/08 by Jeff.Campeau
Shader compression setting based on target platform instead of cooking host platform.
#jira UE-35753
Change 3150366 on 2016/10/04 by Nick.Shin
emscripten SDK 1.36.11
windows and mac binaries will be checked in separately
#jira UE-36562 - //UE4/Main: Compile UE4Game HTML5 completed with errors: 2 errors
Change 3150367 on 2016/10/04 by Daniel.Lamb
Removed caching of cooked platform data from postload.
#test cook paragon
Change 3150368 on 2016/10/04 by Daniel.Lamb
Added new setting to reserve the maximum amount of memory to leave free for the cooker..
Change 3151091 on 2016/10/04 by Nick.Shin
upgrade emsdk toolchain to "tag-1.36.11"
(along with updates to make scripts)
#jira UEPLAT-890 - HTML5 Multithreading
#jira UE-36562 - //UE4/Main: Compile UE4Game HTML5 completed with errors: 2 errors
Change 3151205 on 2016/10/04 by Daniel.Lamb
HasShaderJobs now includes the PendingFinalizedShadermaps in it's check
#test cook paragon.
Change 3151501 on 2016/10/05 by Luke.Thatcher
[PLATFORM] [PS4] [!] Fix memory usage in PS4 crash handler server.
- The ORTMAPI com object implements a Dispose method which we we're calling, so the object was leaked until it eventually gets GC'd.
- Whilst that object is alive, the orbis-debugserver-x64.exe process stays alive, using up to 2GB memory per instance.
- Also limited the server to processing a single crash dump at once, via a task queue.
Change 3151608 on 2016/10/05 by Nick.Shin
fix CIS build warnings and errors
this is for HTML5 platform
Change 3151851 on 2016/10/05 by Michael.Trepka
Added DesktopRect and WorkArea to FMonitorInfo for desktop platforms and used that to fix an issue in SceneViewport where windowed fullscreen mode would be forced to primary monitor and incorrectly positioned on desktops where a taskbar/dock/etc. was on the left
#jira FORT-30638
Change 3152085 on 2016/10/05 by Josh.Adams
- Fixing some Wolf Launcher things (icon, string)
Change 3152451 on 2016/10/05 by Daniel.Lamb
Enabled logging to help debug shader compiler issue.
#test Cook Paragon.
Change 3152880 on 2016/10/05 by Dmitry.Rekman
Linux: add support for new multiarch toolchain.
- Redoing the change as submitted to Dev-Mobile.
Change 3152957 on 2016/10/05 by Dmitry.Rekman
Linux: fix crosstoolchain for non-AutoSDKs case.
- Redoing the fix for UE-36899 from Dev-Mobile.
Change 3153109 on 2016/10/06 by Keith.Judge
Remove D3D11_RESOURCE_MISC_SHARED from XB1 D3D11.x RHI as it is invalid.
Change 3153176 on 2016/10/06 by Keith.Judge
Xbox One - Disable engine analytics on XB1 shipping games, as per XRs. Verified http requests from devkit with Fiddler.
Change 3153213 on 2016/10/06 by Keith.Judge
Xbox One - Plug small memory leak in the movie player.
Change 3153258 on 2016/10/06 by Josh.Adams
- Moved Wolf OSS to proper location for Online plugins
Change 3153450 on 2016/10/06 by Josh.Adams
wolf net driver class stub
Change 3153451 on 2016/10/06 by Josh.Adams
- Fixed more Wolf OSS errors without special sdk
Change 3153471 on 2016/10/06 by Dmitry.Rekman
Linux: fix always rebuilding FixDeps.
Change 3153472 on 2016/10/06 by Josh.Adams
- Deleting some old test files
Change 3153535 on 2016/10/06 by Josh.Adams
- And... fixed some build errors again with the special sdk
Change 3153819 on 2016/10/06 by Daniel.Lamb
Remove some dead code in the cook on the fly server.
#test Cook QAGame
Change 3154050 on 2016/10/06 by Dmitry.Rekman
Linux: remove some of the clang 3.9.0 warnings.
- Add missing destructors.
- Deal with defined() being undefined in a #define.
- Prevent casting nullptr to reference (or suppress that warning for third party code).
- Case sensitivity fixes.
- Make deoptimization work properly.
- Code still crashes when compiling some of the editor targets.
Change 3154071 on 2016/10/06 by Josh.Adams
- Fixed an issue with Wolf shader compiler optimizing out global array
- Fixed Windows display internal thing
Change 3154567 on 2016/10/07 by Luke.Thatcher
[PLATFORM] [PS4] [!] Hack fix for PS4 crash handler site leaking sony debug server processes.
- Find and kill the process after each task
Change 3154570 on 2016/10/07 by Keith.Judge
Fix crash when run with -nolive. Unititialized member fix.
Change 3154572 on 2016/10/07 by Keith.Judge
Xbox One - Small optimization I did a while ago for Paragon and forgot to submit. Removed the SRV dynamic/static distinction in the state cache and calling code, as it makes no difference since fast semantics.
Change 3154656 on 2016/10/07 by Dmitry.Rekman
Linux: make Test configuration drop core by default.
Change 3154789 on 2016/10/07 by Dmitry.Rekman
Linux: remove multiple instances of target platform device.
Change 3154957 on 2016/10/07 by Joe.Graf
Changed additional plugin directories for project descriptors to be absolute in memory and path relative on disk
Change 3155298 on 2016/10/07 by Dmitry.Rekman
Fix CIS (LinuxTargetDevice not linking).
Change 3155684 on 2016/10/07 by Josh.Adams
- Added -PulseC option for Quickmatch
Change 3155691 on 2016/10/07 by Josh.Adams
- New Wolf NetDriver for P2P sockets. Not working yet
- OSS is _not_ currently usable, for reference
Change 3155750 on 2016/10/07 by Dmitry.Rekman
Linux: fix UT server build (UE-37042).
Change 3156816 on 2016/10/10 by Josh.Adams
- Fixed compile errors wihtout extra SDK bits
Change 3156872 on 2016/10/10 by Keith.Judge
Xbox One - Fix corrupted screenshots. Needed a GPU/CPU sync point, which legacy D3D11.x used to do for us, but now we have to do manually.
#jira UE-37038
Change 3156936 on 2016/10/10 by Josh.Adams
- Backed out changes from files that got pulled into a changelist by mistake
Change 3157602 on 2016/10/10 by Josh.Adams
- FIxed Wolf crash on level quit (at least in ShooterGame)
Change 3157676 on 2016/10/10 by Josh.Adams
- Fixed Wolf audio playback in latest SDK
Change 3158544 on 2016/10/11 by Josh.Adams
- Disabled one of the Wolf file mount points in Debug builds due to SDK bug
Change 3158603 on 2016/10/11 by Josh.Adams
- FIxed type in non-Debug
Change 3159257 on 2016/10/11 by Dmitry.Rekman
Linux: case-sensitive fixes.
Change 3159537 on 2016/10/12 by Luke.Thatcher
[PLATFORM] [PS4] [!] Fix leaking orbis-dbgserver-x64 processes in PS4 crash handler.
- We needed to call Marshal.ReleaseComObject on the CoreFileAPI object to shut down the child processes.
- Disabled the kill process hack.
[!] Also fixed "Unknown" usernames in PS4 crash dumps.
- Sony had changed the format of the PS4 settings file in system software 4.008.071.
[!] Fixed exception getting modules from crash dump when symbols have not been loaded.
- Just skipping this step now, as it was only used for logging.
Change 3159581 on 2016/10/12 by Joe.Conley
Wolf support for TPri_Lowest was missing, so I added that and the corresponding WolfThreadPriority_Lowest
Change 3159749 on 2016/10/12 by Luke.Thatcher
[PLATFORM] [PS4] [~] Re-enable kill process hack in PS4 crash server. The ReleaseComObject fix hasn't solved the leaking processes on the server.
Change 3160336 on 2016/10/12 by Daniel.Lamb
Fix for skip editor content flag being passed throught o UAT.
#jira UE-37223
Change 3160341 on 2016/10/12 by Dmitry.Rekman
Linux: fixes for Fortnite and Orion editors.
- Also, again disable XGE because clang 3.9.0-based toolchain crashes when compiling those with XGE.
Change 3160473 on 2016/10/12 by Nick.Shin
remove old emsdk
Change 3160528 on 2016/10/12 by Michael.Trepka
Copy of CL 3160314 from //Fortnite/Main
Fixed incorrect rect initialization in Mac GetDisplayMetrics
Change 3160591 on 2016/10/12 by Josh.Adams
- Fixed wolf coimpiling without stats
#jira UE-37230
Change 3160866 on 2016/10/12 by Dmitry.Rekman
OpenGL: fix swapped arguments.
- Cengiz noticed this while working on one of bugs.
Change 3160978 on 2016/10/12 by Josh.Adams
- Fixed issue with running out of Wolf audio pools on large games
Change 3160979 on 2016/10/12 by Josh.Adams
- Enabled Curl HTTP on Wolf, along with basic SSL (no local cert importing yet)
Change 3161025 on 2016/10/12 by Dmitry.Rekman
Disable poison proxy.
- Malloc::GetAllocationSize() may not account for alignment for mallocs like Binned and Binned2, resulting in a memory stomp.
Change 3161034 on 2016/10/12 by Josh.Adams
-Wolf Http changes - load .pem files if they exist (although they aren't being staged automatically yet)
- Added network pause to make sure its ready before we Http
Change 3161046 on 2016/10/12 by Dmitry.Rekman
TestPAL: adding a test for Malloc::GetAllocationSize().
Change 3161212 on 2016/10/13 by Dan.Mahashin
- Upgraded to new NXCP API. Confirmed to run ok with SunTemple on 0.11.2 SDK.
Change 3161624 on 2016/10/13 by Josh.Adams
- Fixed MAX_PATH usage, should be PLATFORM_MAX_FILEPATH_LENGTH
Change 3161639 on 2016/10/13 by Josh.Adams
- Added curl to main Wolf build since now it's used not just with OSS
Change 3161737 on 2016/10/13 by Josh.Adams
- Added support for staging .pem files for SSL peer verification
Change 3161923 on 2016/10/13 by Dmitry.Rekman
Linux: provide choice between RTLD_GLOBAL/LOCAL when opening DSOs (UE-36716).
- By default, Unreal modules will be opened with RTLD_LOCAL (so the hot reload has a chance to work).
- However, if "ue4_module_options" symbol is exported (a string with comma-separated options), and "linux_global_symbols" is present in that string, RTLD_LAZY will be used.
- DSOs that don't have either ue4_module_options nor are recognized as UE4 modules will be loaded RTLD_GLOBAL.
- PR #2823 by 20tab.
Change 3163532 on 2016/10/14 by Michael.Trepka
Copy of CL 3162466
By default, do not compile Mac OpenGL and Metal SM4 shaders while cooking
#jira UE-37088
Change 3163550 on 2016/10/14 by Josh.Stoddard
Fix key event processing during movies using FDefaultGameMoviePlayer
#jira UE-37294
Change 3163687 on 2016/10/14 by Josh.Adams
- Added a workaround for Wolf crashing inside vswprintf with %p
Change 3163693 on 2016/10/14 by Josh.Adams
- Added a delegate for getting extra on-screen messages (like the Shaders to compile, etc).
Change 3163725 on 2016/10/14 by Josh.Adams
- Added high level Wolf network transition functions for Wolf
Change 3163745 on 2016/10/14 by Josh.Adams
- Wolf OSS changes for new high level networking logic, cleaned up includes, added on screen messages with status
Change 3164455 on 2016/10/17 by Josh.Adams
- SOmehow a file wasn't checked out, but writable. Checking in now
Change 3164630 on 2016/10/17 by Michael.Trepka
Copy of CL 3162062
Replaced FWindowsCursor hack for warping the mouse cursor to the center of the viewport with a better fix for the original problem (users being able to resize the window while the cursor is hidden and the mouse controls the camera). This change removes round window corners in borderless window mode and disables window resizing when the cursor is hidden.
Change 3164975 on 2016/10/17 by Joe.Graf
Changed the New Plugin Wizard to only show plugin types available for that project type (content only or code)
Change 3165213 on 2016/10/17 by Josh.Adams
- Fixed some perf testing by disabling the startup benchmark for UT on non-desktop platforms
Change 3165576 on 2016/10/18 by Dan.Mahashin
- Fix broken colors in QAGame UE-37197: depth write cannot work without depth test being enabled.
Change 3165809 on 2016/10/18 by Josh.Stoddard
Enforce UMaterialExpressionActorPositionWS dependency on primitive uniform buffer #jira UE-37425 #rb chris.bunner
Change 3165948 on 2016/10/18 by Owen.Stupka
Fix exception when creating an exception to say we don't have a 32-bit VC compiler installed.
Change 3166330 on 2016/10/18 by Dmitry.Rekman
Linux: disable XGE on Windows (UE-37446).
- XGE does not seem to handle new clang 3.9.0 toolchain well, with very reproducible crashes.
Change 3166456 on 2016/10/18 by Dmitry.Rekman
Fix build breakage with clang 3.8.1.
- always_inline was still applied to debug builds and as such was ignored.
Change 3166457 on 2016/10/18 by Chris.Babcock
Add missing MultiviewOVR functions for Android deferred
#jira UE-37401
#ue4
#android
Change 3166469 on 2016/10/18 by Dmitry.Rekman
Linux: make target platform modules independent (UE-37370).
- Module load order is different for target platform modules between UE4Editor and UE4Editor-Cmd, and dependent modules may end up being loaded first.
Change 3166755 on 2016/10/18 by Joe.Barnes
[UE-35552] Enable PLATFORM_ENABLE_VECTORINTRINSICS_NEON on Wolf.
Change 3166757 on 2016/10/18 by Joe.Barnes
[UE-35552] Optimized platform specific implementation of some common math functions.
Change 3166761 on 2016/10/18 by Joe.Barnes
Use new 64 bit Power of 2 function.
Change 3167865 on 2016/10/19 by Josh.Adams
- Wolf P2P/NAT stuff working!
- Minor Wolf net mode fixes
Change 3167869 on 2016/10/19 by Josh.Adams
- Moved a blocking net call for Wolf Http into a thread
Change 3168100 on 2016/10/19 by Joe.Barnes
#include <NVN/nvn_CppMethods.h>. Fixes a compiler problem with some inline functions not being available during compile phase.
Change 3168101 on 2016/10/19 by Joe.Barnes
Exposed a function to create a platform based filename
Change 3168141 on 2016/10/19 by Dmitry.Rekman
TestPAL: better test for allocation sizes.
Change 3168144 on 2016/10/19 by Dmitry.Rekman
Fix for FMallocBinned::GetAllocationSize() for aligned allocations.
Redoing SteveR's fix in 4.13/4.14.
Copied from CL# 3165739.
#jira UE-37249
#jira UE-37243
Change 3168213 on 2016/10/19 by Josh.Adams
- Wolf OSS function rename
Change 3168313 on 2016/10/19 by Josh.Adams
Rename/move file(s)
Change 3168691 on 2016/10/20 by Dan.Mahashin
- Fixed application teardown and memory leak:
- NVNCommandContext was failing to free the last frame resources on shutdown (resources were thought to be in use because never actually processed by GPU)
- NVNCommandContext was leaking a FSyncedFrameDestruction at each frame
- NVNTempBlockManager was not freeing all of its temp blocks upon shutdown
Change 3168986 on 2016/10/20 by Josh.Adams
- Removed some log spam
Change 3168990 on 2016/10/20 by Josh.Adams
- Removed dead code
Change 3169091 on 2016/10/20 by Josh.Adams
Moved UT's OnlineGameplayFramework plugin into NotForLicensees so licensees don't need Mcp
Change 3169262 on 2016/10/20 by Josh.Adams
- Updated the OnScreenMessages to use a TMap of severity to message, so we can have multiple colors, etc
- Also has some fixes needed from a merge down (oops)
Change 3169363 on 2016/10/20 by Dmitry.Rekman
TestPAL: final synth test for stomp.
Change 3169436 on 2016/10/20 by Michael.Trepka
Change the minimum supported macOS version setting in Info.plists to 10.11.6
Change 3169510 on 2016/10/20 by Dmitry.Rekman
TestPAL: added stomp test with poison proxy.
Change 3169972 on 2016/10/20 by Dmitry.Rekman
Re-enable PoisonProxy.
Change 3170000 on 2016/10/20 by Dmitry.Rekman
Linux: minor code cleanup.
Change 3170400 on 2016/10/21 by Josh.Adams
- Added a comment with current supported SDK in UEBuildWolf.cs
Change 3170929 on 2016/10/21 by Josh.Adams
- Added generic Elf symbol parser to MemoryProfiler2 app. It uses nm.exe, and any platform that uses it would need to subclass it (which Wolf now does)
Change 3171266 on 2016/10/21 by Dmitry.Rekman
Linux: fix Setup.sh on Ubuntu 16.10 (UE-37621)
Change 3172847 on 2016/10/24 by Josh.Adams
- Added a null Material check to the recent change to UMaterialExpressionActorPositionWS
#jira UE-37730
Change 3173535 on 2016/10/25 by Josh.Adams
- Helping clean up some misplaced files, since obliterate caused problems with BulletProofSync
[CL 3174242 by Josh Adams in Main branch]
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2946506 on 2016/04/18 by Steven.Hutton
Update to Crash Reporter buggs table to add new search fields and inclusion of packages needed for e-mail reports.
Change 3017807 on 2016/06/17 by Chris.Wood
Improved Crash Report Process folder delete code as it could sometimes fail.
[UE-30349] - Crash Report Process is leaving crashes in the landing zone that build up and block the queue
Also added logging to Slack when stop request received instead of just when stop is complete.
Change 3019367 on 2016/06/20 by Chris.Wood
Improve Crash Report Process logging to track bad reads from S3.
Also, better logging when CleanReport fails to delete folders.
Change 3019376 on 2016/06/20 by Steve.Robb
Clarification of assert message and comments which talk about 'null' TFunctions.
Tidy-up of dead code.
Change 3019409 on 2016/06/20 by Steve.Robb
New Find and FindByPredicate algorithms for finding stuff in arbitrary containers.
Change 3022658 on 2016/06/22 by Chris.Wood
Discarding duplicated crash reports earlier in read from Data Router process to avoid clashes in the landing zone (CRP v1.1.11)
[UE-30349] - Crash Report Process is leaving crashes in the landing zone that build up and block the queue
Also improved logging to Slack with better layout, fixed event ordering and counting duplicates.
Change 3022840 on 2016/06/22 by Steve.Robb
Skipped UHT attributes removed.
Change 3022907 on 2016/06/22 by Robert.Manuszewski
Fixing crash when adding a new C++ class to project
#jira UE-32333
Change 3023169 on 2016/06/22 by Steve.Robb
Checks for UTHINGs in skipped preprocessor blocks.
Fixes for skipped UTHINGs and some other parsing accidents.
#jira UE-31627
Change 3023239 on 2016/06/22 by Steve.Robb
Fix for JSON date parsing reported here: https://udn.unrealengine.com/questions/299342/fdatetime-json-serialization-bug.html
Change 3026812 on 2016/06/24 by Mieszko.Zielinski
Marked FEnvQueryInstance::AddItemData UEnvQueryItemType_Point specialization as AIMODULE_API #UE4
Change 3028235 on 2016/06/27 by Robert.Manuszewski
PR #2535: BUGFIX: FPS pop-up updates when loading new stat file (Contributed by projectgheist)
Change 3028282 on 2016/06/27 by Steve.Robb
Fix for missing UFUNCTION check in skipped preprocessor blocks.
#jira UE-31627
Change 3028284 on 2016/06/27 by Steve.Robb
Debuggability improvements and coding standards changes.
Change 3028343 on 2016/06/27 by Steve.Robb
Fix for UHT error in WEX.
#jira UE-32464
Change 3028393 on 2016/06/27 by Steve.Robb
Fix for hot reload of enums finding the old enum.
Fix to stop SPropertyEditorNumeric caching the enum flags.
#jira UE-31658
Change 3030362 on 2016/06/28 by Robert.Manuszewski
Fixing hang when cooking.
Change 3030462 on 2016/06/28 by Steve.Robb
Assert added to PackageTools::GetFilteredPackageList() to help with catching a bug reported in the wild.
#jira UE-32001
Change 3034341 on 2016/06/30 by Robert.Manuszewski
Modified crash handling code (on Windows) to handle two threads crashing at the same time properly. Previously the second crash would force the process to exit before generating the crash report.
Added 'debug twothreadsgpf' command to test the functionality.
Change 3034342 on 2016/06/30 by John.Mahoney
Fix for crash when loading an empty cached asset registry.
#jira UE-32232
Change 3035599 on 2016/07/01 by Chris.Wood
Added support for CrashType string to Crash Report Process. CRP v1.1.12
[UE-30592] - Crash Reporter should determine crash type on client and pass string to server
Also fixes problem with reports falling back on the legacy WER metadata when a crash context exists. They now only read the error message from metadata if available and keep crash context data when possible.
Added in missing crash context parameters that have been added to clients but not known by the server.
Change 3035787 on 2016/07/01 by John.Mahoney
Fix for crash when DuplicateRedirects does not contain the DependentObject when saving dependencies. It will still fall through to the assertion below, but it will now fail with a useful error message instead of a generic 'Pair != nullptr' from Map.h.
#jira UE-30189
Change 3036933 on 2016/07/04 by Steve.Robb
Proper forwarding constructor for FAsyncTask.
Change 3036938 on 2016/07/04 by Steve.Robb
Fix for CDO hot reload corrupting memory when replacing references inside structs.
#jira UE-29335
Change 3036960 on 2016/07/04 by Steve.Robb
Fix for FAnsiAllocator::ResizeAllocation when resizing to zero.
Change 3037423 on 2016/07/05 by Steve.Robb
FModuleManager::UnloadOrAbandonModuleWithCallback split into two instead of switching behavior with a bool.
Change 3037464 on 2016/07/05 by Steve.Robb
HotReload.cpp cleanup:
Deep nesting flattened.
Linear array searches replaced with maps.
FHotReloadModule::GetGameModules made into a non-member function and split into two.
Comment and coding standard fixes.
Change 3037741 on 2016/07/05 by John.Mahoney
Fix for COTF not checking the correct timestamps on startup.
#jira UE-31023
Change 3037846 on 2016/07/05 by Steve.Robb
Fix for compile button disappearing on a bad compile.
#jira UE-31575
Change 3037994 on 2016/07/05 by Steve.Robb
Static analysis fixes:
warning C6308: 'realloc' might return null pointer: assigning null pointer to 'Data', which is passed as an argument to 'realloc', will cause the original memory block to be leaked.
Change 3039186 on 2016/07/06 by Robert.Manuszewski
Enabling crash callstack logging by default.
Change 3039220 on 2016/07/06 by Steve.Robb
Static analysis fixes:
warning C28159: Consider using 'InitiateSystemShutdownEx' instead of 'ExitWindowsEx'. Reason: Legacy API. Rearchitect to avoid Reboot
warning C6001: Using uninitialized memory 'UserNameLength'
warning C6001: Using uninitialized memory 'DomainNameLength'
Change 3039230 on 2016/07/06 by Steve.Robb
Fix for VC internal compiler errors.
Change 3039237 on 2016/07/06 by Steve.Robb
Static analysis fix: warning C6385: Reading invalid data from 'Path': the readable size is '400' bytes, but 'PathCurrentDepth' bytes may be read.
Change 3039287 on 2016/07/06 by Steve.Robb
Static analysis fixes:
warning C6509: Invalid annotation: 'return' cannot be referenced in some contexts
warning C6101: Returning uninitialized memory '*lpdwExitCode'. A successful path through the function does not set the named _Out_ parameter.
warning C6387: '_Param_(1)' could be '0': this does not adhere to the specification for the function 'IMoniker::BindToStorage'.
warning C6387: '_Param_(1)' could be '0': this does not adhere to the specification for the function 'IMoniker::BindToObject'.
warning C6031: Return value ignored: 'CoCreateInstance'.
Change 3039359 on 2016/07/06 by Graeme.Thornton
Compile error fix for FAsyncTask, courtesy of SteveR
Change 3039534 on 2016/07/06 by Steve.Robb
Static analysis fix: warning C6319: Use of the comma-operator in a tested expression causes the left argument to be ignored when it has no side-effects.
Change 3039545 on 2016/07/06 by Steve.Robb
Static analysis fix: warning C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value. Results might not be an expected value.
Change 3039578 on 2016/07/06 by Steve.Robb
Static analysis fix: warning C6263: Using _alloca in a loop: this can quickly overflow stack.
Change 3039623 on 2016/07/06 by Steve.Robb
Static analysis fixes:
warning C6011: Dereferencing NULL pointer 'X'
warning C6308:'realloc' might return null pointer: assigning null pointer to 'X', which is passed as an argument to 'realloc', will cause the original memory block to be leaked.
warning C6385: Reading invalid data from 'X': the readable size is 'Y' bytes, but 'Z' bytes may be read.
warning C6386: Buffer overrun while writing to 'X': the writable size is 'Y' bytes, but 'Z' bytes might be written.
warning C28182: Dereferencing NULL pointer. 'X' contains the same NULL value as 'Y' did.
Change 3039630 on 2016/07/06 by John.Mahoney
Fix for crash when spawning an actor using a template object that has instance components. UActorComponent::PostInitProperties was adding itself to the owner's InstanceComponents array, resulting in a realloc of that array and invalidating the reference that the owner's ObjectInitializer was trying to replace while instantiating that property. The new instance component will be added to the array as part of the owner's initialization anyway, so it is not necessary to do it here.
#jira UE-29123
Change 3039664 on 2016/07/06 by Steve.Robb
Static analysis fixes:
warning C6386: Buffer overrun while writing to 'NewKeys': the writable size is 'NewIndexSize*4' bytes, but '8' bytes might be written.
warning C6386: Buffer overrun while writing to 'NewHeapIndexes': the writable size is 'NewIndexSize*4' bytes, but '8' bytes might be written.
Change 3039673 on 2016/07/06 by Steve.Robb
Static analysis fix: warning C6011: Dereferencing NULL pointer 'v'.
Change 3039690 on 2016/07/06 by Steve.Robb
Static analysis fixes:
warning C6011: Dereferencing NULL pointer 'X'.
warning C6246: Local declaration of 'X' hides declaration of the same name in outer scope.
warning C6262: Function uses '121180' bytes of stack: exceeds /analyze:stacksize '81940'. Consider moving some data to heap.
warning C6263: Using _alloca in a loop: this can quickly overflow stack.
Change 3040868 on 2016/07/07 by Graeme.Thornton
Config based class stripping for server builds
Change 3040872 on 2016/07/07 by Graeme.Thornton
Remove "return false" NeedsLoadForServer functions from engine code
Change 3040997 on 2016/07/07 by Steve.Robb
Static analysis fixes:
warning C6011: Dereferencing NULL pointer 'Landscape'.
warning C6011: Dereferencing NULL pointer 'rhs.Allocation.LayerInfo'.
warning C6011: Dereferencing NULL pointer 'lhs.Allocation.LayerInfo'.
Change 3041004 on 2016/07/07 by Steve.Robb
Static analysis fix: warning C6336: Arithmetic operator has precedence over question operator, use parentheses to clarify intent.
Change 3041014 on 2016/07/07 by Steve.Robb
Static analysis fix: warning C6287: Redundant code: the left and right sub-expressions are identical.
Change 3041111 on 2016/07/07 by Steve.Robb
Removal of an obsolete error message about INI file case sensitivity.
Change 3041150 on 2016/07/07 by Steve.Robb
Static analysis fix: warning C6289: Incorrect operator: mutual exclusion over || is always a non-zero constant. Did you intend to use && instead?
Change 3041274 on 2016/07/07 by Steve.Robb
Static analysis fixes: warning C6001: Using uninitialized memory 'X'.
Change 3041294 on 2016/07/07 by Chris.Wood
Fixed protocol buffer and decompression errors in Crash Report Process (v.1.1.14)
[UE-32151] - High number of crashes read from S3 by Crash Report Process are failing to unpack
Size of buffer received from S3 is incorrect for some records. Fixed read problems by using size header value instead of stream length.
Increased buffer size for decompression as this was sometimes too small.
Modified S3 reading code to look for multiple records in each downloaded file.
Change 3041472 on 2016/07/07 by Steve.Robb
Static analysis fixes:
warning C6294: Ill-defined for-loop: initial condition does not satisfy test. Loop body not executed.
warning C6201: Index '1' is out of valid index range '0' to '0' for possibly stack allocated buffer 'NewHistory.Nodes'.
Change 3043074 on 2016/07/08 by John.Mahoney
Fix for COTF incorrectly reconstructing the original asset path based on the sandbox path when the game name differs from the game folder name.
Fix for COTF GetFiles not handling absolute GameDir paths properly.
#jira UE-31023
Change 3044461 on 2016/07/11 by Steve.Robb
Static analysis fix: warning C6386: Buffer overrun while writing to 'Attributes': the writable size is '16384' bytes, but '-8' bytes might be written.
Change 3044470 on 2016/07/11 by Steve.Robb
Static analysis fix: warning C6011: Dereferencing NULL pointer 'Node.Sequence'.
Change 3044476 on 2016/07/11 by Steve.Robb
Static analysis fix: warning C6011: Dereferencing NULL pointer 'Property'.
Change 3044551 on 2016/07/11 by Steve.Robb
Static analysis fix: warning C28182: Dereferencing NULL pointer. 'Node' contains the same NULL value as 'KeyAreaNode' did.
Change 3044664 on 2016/07/11 by Steve.Robb
Static analysis fixes:
warning C6011: Dereferencing NULL pointer 'ToLandscape->SplineComponent'.
warning C28182: Dereferencing NULL pointer. 'SplinesComponent' contains the same NULL value as 'Landscape->SplineComponent' did.
warning C6011: Dereferencing NULL pointer 'Landscape->SplineComponent'.
warning C6385: Reading invalid data from 'out': the readable size is 'sizeof(kiss_fft_cpx)*Dims[0]*Dims[1]' bytes, but '16' bytes may be read.
Change 3044716 on 2016/07/11 by Steve.Robb
Static analysis fix: warning C6385: Reading invalid data from 'this->ScreenSize': the readable size is '32' bytes, but '-4' bytes may be read.
Change 3044717 on 2016/07/11 by Steve.Robb
Static analysis fix: warning C28182: Dereferencing NULL pointer. 'Window' contains the same NULL value as 'ElementType * Window=AllWindows.FindByPredicate((*FStaticMeshEditorTest::RunTest::<lambda_46fd0093f3912289e870263afe1fcb2e>(ExpectedTitle)))' did.
This appears to be a false positive.
Change 3044787 on 2016/07/11 by Steve.Robb
Static analysis fixes:
warning C6011: Dereferencing NULL pointer 'FbxObject'.
warning C28182: Dereferencing NULL pointer. 'Node' contains the same NULL value as 'RigidMeshNode' did.
warning C28182: Dereferencing NULL pointer. 'Node' contains the same NULL value as 'Result' did.
Change 3045933 on 2016/07/12 by Steve.Robb
Overloading support for TSharedPtr, TSharedRef and TWeakPtr.
Change 3045960 on 2016/07/12 by Robert.Manuszewski
Fixing a crash in Portal (and any other program that uses UObjects and GCs, with the exception of UHT) caused by classes not having their token stream assembled.
Change 3045963 on 2016/07/12 by Steve.Robb
PLATFORM_COMPILER_HAS_EXPLICIT_OPERATORS, FORCEINLINE_EXPLICIT_OPERATOR_BOOL and SAFE_BOOL_OPERATORS macros removed.
THasOperatorEquals and THasOperatorNotEquals traits moved to their own header.
Change 3045967 on 2016/07/12 by Steve.Robb
Initializer list support for TArray and TSet.
Change 3045968 on 2016/07/12 by Robert.Manuszewski
Fixing an ensure after typing 'stat dumphitches' in console.
Change 3045992 on 2016/07/12 by Robert.Manuszewski
Making sure CoreUObject headers are included for programs that don't include the engine (fixing MinidumpDiagnostics CIS failure)
Change 3047870 on 2016/07/13 by Steven.Hutton
Updated CRW to entity framework with repository models. #rb none
Change 3047871 on 2016/07/13 by Steven.Hutton
Add repository models #rb none
Change 3049468 on 2016/07/14 by Steven.Hutton
Fix broken project files. #rb none
#lockdown Nick.Penwarden
[CL 3050320 by Robert Manuszewski in Main branch]
Ben Marsh
Josh Adams
Robert Manuszewski
Matthew Griffin
Jaroslaw Palczynski