#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3351920 on 2017/03/17 by Leigh.Swift
#jira OPP-6870: [Crash] Assertion failed: ctx->ReadOffset + length <= (uint32)ctx->CompressedData.Num() [File:D:\Build\++Portal+Release-Live+Compile\Sync\Engine\Source\Runtime\ImageWrapper\Private\PngImageWrapper.cpp] [Line: 420]
Instead of asserting for an incorrect data size for png image being loaded, set an error on the wrapper object.
This will result in the slate brush rendering as white box, and errors going to the log which include the png resource path.
Change 3350561 on 2017/03/16 by Justin.Sargent
Updated the Slate standalone D3D renderer to be more fault tolerant.
Added new HasLostDevice() function to SlateRenderer.
If the launcher detects that it has lost the device context it will attempt to perform a full rebuild of the UI and Presentation layers, but also a full reboot of slate application and the renderer.
The launcher will attempt to re-establish the device context for 5 minutes if not interrupted by the user. If the user interacts with the launcher while attempting to re-establish the device context it will instead pop up a system dialog explaining it is having issues with the video card and then will close the application.
Change 3341299 on 2017/03/10 by Richard.Fawcett
Validate JSON files as we're pushing to EMS
Added a flexible validation framework to the system files (EMS) sync operation.
Implemented a JSON validator which by default will validate .json files.
Adds a "ValidationRules" property to the EMS sync config file to allow each product to define its own regex patterns for filenames which should be validated with each validator.
Configured launcher's EMS to validate .product, .v?product, .layout, .sdmeta and .panel files as JSON.
The great news is that this validation actually discovered a minor syntactical issue with Wex.v2product during testing, which is also fixed with this submission. \o/
#epicfriday
Change 3336908 on 2017/03/08 by Leigh.Swift
#jira OPP-5126: All disk size checks for BPS installations should be handled internally to BPS, the Portal code should not need to check this and can only do so less accurately.
Removing disk space checks from portal code which block installers from running. NB: There is still a check in selective download code which provides tooltip information only.
Moving BuildPatchInstaller disk size check to the file constructor, which is the class that most accurately knows the required amount of space. The disk check now occurs after resume and just before we start to write data.
A secondary disk check is also made if a file fails to construct so that we can detect problems caused by change in available disk space.
Disk space error message extended to include useful information for the user.
Change 3323366 on 2017/02/27 by Richard.Fawcett
Fix reference to Newtonsoft in Publishing.Automation.
Change 3323205 on 2017/02/27 by Wes.Fudala
Adding language support to the windows installer.
Significantly expandes OneSky upload functionality.
OPP-5438 Launcher installer should support the same language set supported by the launcher.
Change 3316926 on 2017/02/22 by Richard.Fawcett
Prevent Amazon S3 download glitches from issuing warnings until half of the maximum retries have been attempted.
In practice, when we download thousands of files, we _do_ get failures which need to be retried. This means that pretty much all jobs result in warnings, which isn't appropriate. This should turn jobs green again, and only warn us when things look unusual.
#jira OPP-6607
Change 3315996 on 2017/02/21 by Justin.Sargent
Incrementing Portal version number
I'm incrementing this earlier than normal due to a need to depend on a new version number for EMS layout change versioning.
Change 3312760 on 2017/02/20 by Wes.Fudala
Users can now select desired environment/region from the UI.
New login screen.
Adds slid out settings menu to login screen.
Adds region and language selection to the settings menu.
Adds support for PortalRegions ini.
Adds DefaultPortalRegions ini.
Adds RegionRepository, RegionPublisher, RegionSelectService, and RegionIdentificationService.
Adds region select option in debugtools general section.
Adds RegionSelectService unit test with associated mocks.
Changes the way all backend connections are configured so that values are now pulled from config files.
Renames product region selector files to avoid some confusion with portal region files.
Updated EmsConfigUpdater and HotfixManager so they support optional overwrite and save of ini files.
Region publisher now restricts regions that require permissions in shipping builds.
Fixes a bug causing items to get stuck in the download queue UI after we failed to obtain a manifest when reaching out the the backend.
#jira OPP-6121, OPP-5809
Change 3311664 on 2017/02/20 by Andrew.Brown
Added GetTypeHash support for FDelegateHandle
Change 3311505 on 2017/02/20 by Richard.Fawcett
Rename/move file(s)
Change 3309004 on 2017/02/17 by Chad.Garyet
adding in additional platforms for the BuildPlugin commandline
Change 3299188 on 2017/02/13 by Leigh.Swift
#jira OPP-6711: [CRASH] Assertion failed: IsComplete()
Race condition in portal hack allowed an installer to attempt to execute complete delegate before being complete.
Change 3294197 on 2017/02/09 by Richard.Fawcett
Adding ValidPrereqIds.json
This is needed now because the script to enforce correct prereq ids reaches out to Perforce to access this file!
#jira OPP-6583
Change 3294059 on 2017/02/09 by Richard.Fawcett
Fix comment on PostBuild parameter to reference correct name of "Manifest" property.
Change 3293377 on 2017/02/08 by Richard.Fawcett
Remove need for a metadata file containing name of generated manifest when using randomized manifest filenames.
Change 3282865 on 2017/02/02 by Richard.Fawcett
Simplify params to BuildGraph's ChunkTask / PostBuildTask
Also, downgrade warnings to simple log messages when falling back to legacy manifest filename construction to ease transition into randomized manifest filenames for game teams.
#jira OPP-6435
Change 3282809 on 2017/02/02 by Leigh.Swift
#jira OPP-6564: BPT will crash if the FileIgnoreList input instructs the build streamer to ignore every build file.
A race condition for getting to the first scanner creation code, vs the build stream exiting with no data. If the former wins, a scanner will be created without enough data to scan.
Scanners are now no longer created if the buildstream provided no data.
Change 3280848 on 2017/02/01 by Leigh.Swift
#jira OPP-3864: BuildPatchServices will log a FATAL error on shutdown even if it's fine to be shutting down.
When BPS is shutdown, it will only set error states and cancellation logic if any installers are actually created.
Change 3280839 on 2017/02/01 by Leigh.Swift
Fixing whitespace damage incoming from Dev-Staging
Change 3280820 on 2017/02/01 by Andrew.Brown
Copying //Portal/Dev-Main-Staging to Main (//Portal/Main)
Change 3280797 on 2017/02/01 by Leigh.Swift
#jira OPP-6649: BPS sends undocumented analytics events.
Adding documentation for the following events:
Patcher.Error.Download
Patcher.Warning.ChunkAborted
Patcher.Error.Cache
Patcher.Error.Construction
Patcher.Error.Prerequisites
Change 3278887 on 2017/01/31 by Richard.Fawcett
Downgrade cleanup warnings to normal log output.
The conditions which used to trigger these warnings are now considered to be normal behavior, in a world in which we carry out cross-app game promotions.
This results in a perma-yellow state for cleanup, which is unhelpful.
#nojira
Change 3278738 on 2017/01/31 by Richard.Fawcett
Tweak Conan launch parameters
Change 3277066 on 2017/01/30 by Richard.Fawcett
Remove temporary code which cleans up P:\Builds\UnrealEngineLauncher\BuildGraph, as the location no longer exists.
Change 3274907 on 2017/01/27 by Leigh.Swift
#jira OPP-6615: Receiving a whisper while in game may minimize game client.
Refactoring SWindow ActivateOnFirstShown bool to be ActivationPolicy to give more accurate control.
This also allows fixing of misuses of previous ActivateOnFirstShown variables in the implementations, which appear to mostly be interpreting it as 'AlwaysActivate'.
The upgrade path is therefore ActivateOnFirstShown true/false becomes ActivationPolicy Always/Never.
Moving initial minimize and maximise logic for FWindowsWindow into the Show() call on first show to gain control of activation and respect the provided policy.
Refactoring existing uses to use the new variables/functions instead.
The refactor of existing code is focused on preserving current always activate behaviour as opposed to changing behaviour to actually only activate on first show.
Change 3273466 on 2017/01/26 by Alex.Fennell
New build of OpenSSL libraries #JIRA OPP-6408
PriceEngine configuration and fixes for bugs it introduced.
Change 3268045 on 2017/01/23 by Richard.Fawcett
Re-adding Funcom folk to Conan chunk notification emails
Change 3267709 on 2017/01/23 by Richard.Fawcett
Fix launch arguments for Conan Exiles editor.
Temporarily remove FunCom recipients from notification list to avoid spamming.
Change 3265774 on 2017/01/20 by Chad.Garyet
Merge of Engine/Build/Buildfarm over to //Portal from Dev-Build
Change 3264674 on 2017/01/19 by Alex.Fennell
On demand catalog requests
Change 3263654 on 2017/01/19 by Leigh.Swift
#jira OPP6562: Support looking up tagging and sdmeta info and using it in build diff output
Adding tag use understanding to the manifest diff tool of BPT.
Adding Selective Download feature support to PPT for it's diff tool, making use of portal's metadata for the feature.
Change 3263623 on 2017/01/19 by Richard.Fawcett
Fix issue where ManifestFilename is not always available at post build time.
#jira OPP-6606
Change 3262013 on 2017/01/18 by Richard.Fawcett
Remote potential for success email being sent on third party chunk failure
Change 3261914 on 2017/01/18 by Richard.Fawcett
Fix for user content generation job not specifying a manifest filename.
Change 3261800 on 2017/01/18 by Richard.Fawcett
Implement streaming S3 downloads to disk, rather than just to memory
This is needed because C# has a 2 billion maximum array dimension, so files > 2GB can't be downloaded using the existing code.
Change 3261675 on 2017/01/18 by Richard.Fawcett
Support for overriding, or generating randomized unique manifest filenames to avoid automated harvesting from CDN
BuildGraph's ChunkTask takes three new parameters ...
* ManifestFilename (string) - The filename of the manifest to produce. If omitted, the value of RandomizeManifestFilename will determine how the manifest filename is determined.
* RandomizeManifestFilename (bool) - If true, we'll generate a random, unique manifest filename. If false (default), we'll use legacy behavior of combining app name and build version.
* LocalManifestDir (string) - Required if RandomizedManifestFilename is true. This directory will receive local copies of any manifest file produced, and a metadata file containing the name of the most recently produced manifest
BuildGraph's PostBuildTask takes two new parameters ...
* ManifestFilename (string) - The filename of the manifest to post. If omitted, we'll use the value from the metadat file in LocalManifestDir is this is set, otherwise use legacy behavior.
* LocalManifestDir (string) - A directory containing local copies of manifest files, along with a metadata file containing the name of the manifest file produced by the most recent ChunkTask operation.
Support added to the launcher build script's to use the new parameters to randomize its manifest filename, and post the randomized filename to MCP.
Use of a contructor of BuildPatchToolStagingInfo which does not specify a manifest filename is now considered deprecated, and will output a warning.
Remove requirement of having a BuildPatchToolStagingInfo when performing a chunking operation, instead just passing in the specific values we need from it as parameters in their own right.
Remove support for non-chunk based manifests from C# wrapper, as these are no longer supported in BuildPatchTool itself.
#jira OPP-6432
Change 3261647 on 2017/01/18 by Leigh.Swift
Adding some cleanup to the end of some BPT functional tests so that they do not affect proceeding tests and cause red-herring warning output.
Change 3261639 on 2017/01/18 by Richard.Fawcett
Update app name of Conan to ConanExiles to match back-end catalog.
Fix Conan launch exe and args so that launcher can detect when product is running. Was previously using a batch file which terminates after launching editor.
Change 3258815 on 2017/01/16 by Wes.Fudala
UTM and product info will be parsed from installer name and passed to the launcher. UTM info will be passed along as part of all analytics events.
#jira OPP-6404: Add user funnel tracking
Change 3258809 on 2017/01/16 by Wes.Fudala
Back out changelist 3258800.
Backing out changes that were intended to be made in a different stream.
Change 3258800 on 2017/01/16 by Wes.Fudala
App version is now also appended to user agent string.
Change 3256999 on 2017/01/13 by Richard.Fawcett
Fix issue where JSON file included in Publishing csproj is not reliably copied to output folder on build farm.
Change 3256941 on 2017/01/13 by Richard.Fawcett
Move configuration for Third Party build pipeline out of code and into its own configuration file.
#epicfriday
Change 3255072 on 2017/01/12 by Richard.Fawcett
Add additional logging around multithreaded upload of files to S3.
Fix bug ensuring that the failure of any single part of multi-part upload results in the whole file being failed.
#jira OPP-6392
Change 3253672 on 2017/01/11 by Richard.Fawcett
Add support for third-party Conan editor.
Alter third party process so it doesn't crash if version.txt doesn't already exist in the third party S3 bucket, to allow us to setup in advance of third party publishing their first version.
Change 3251901 on 2017/01/10 by Barnabas.McManners
Compile fix on mac, fix for hidden method in AutomationTest define. Without this GoogleMock.spec.cpp wont compile on mac.
#nojira
#ReviewedBy Leigh.Swift
Change 3250907 on 2017/01/09 by Justin.Sargent
Changed the automation controller to uses a non-zero exit code when performing a 'quit' command if tests failed.
Change 3245328 on 2017/01/03 by Justin.Sargent
Enabling the logic to lowercase all C++ members exposed to javascript.
Added additional to-lowering behavior to UObject binding.
#jira OPP-6494
Change 3240667 on 2016/12/20 by Andrew.Brown
Copying //Tasks/Portal/Dev-OPP-6109-DedicatedServer to Dev-Main (//Portal/Dev-Main)
Change 3236972 on 2016/12/15 by Bob.Ferreira
Updating compliation changes for AutomationDriver
Change 3236567 on 2016/12/15 by Richard.Fawcett
Ensure that third party product chunking uses latest CL across our P4 depot in its version number.
Change 3236188 on 2016/12/15 by Richard.Fawcett
Combine all launcher purchases into single workflow using the new quickPurchase API call as the initial request.
#jira OPP-6257
Change 3231134 on 2016/12/12 by Alex.Fennell
Improving fail case handling for the waiting room service
#jira OPP-5648
Change 3228514 on 2016/12/09 by Richard.Fawcett
Change filetype
Change 3227080 on 2016/12/08 by Barnabas.McManners
Merging CL 3226840 from Dev Editor
Fixing a bug in FText formatting where it would ignore the rebuild and Rebuild as Source arguments for the format string itself
#jira OPP-6485
Change 3219810 on 2016/12/02 by Ben.Marsh
UAT: Fix unzip output being completely discarded. Switch it to just be verbose instead.
Change 3219602 on 2016/12/02 by Ben.Marsh
Add the -q (quiet) option to the Mac unzip command, since it's creating too much log output to be useful.
[CL 3355309 by Justin Sargent in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
warning C4996: 'FOutputDevice::FormatLogLine': Please use FOutputDeviceHelper::FormatLogLine. Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.
#lockdown nick.penwarden
#rb barnabas.mcmanners
[CL 3035430 by Leigh Swift in Main branch]
Also, remove -nopatchdelete mode, as it no longer makes sense now that we don't update timestamps.
#jira OPP-3947
#reviewedby Leigh.Swift
[CL 2680221 by Richard Fawcett in Main branch]
To avoid possible ambiguity between a filename and the output including the size, we now split the filename from the size with a tab.
#reviewedby Leigh.Swift
[CL 2487800 by Richard Fawcett in Main branch]
