izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity
44,315 Commits 23 Branches 254 Tags
777dffe8ff8d52d7eb7894deab386c816a48f80f
Commit Graph

5 Commits

Author SHA1 Message Date
Ben Marsh
20bf0eb6a1 Updating copyright notices to 2017 (copying from //Tasks/UE4/Dev-Copyright-2017). 
#rb none
#lockdown Nick.Penwarden

[CL 3226823 by Ben Marsh in Main branch]
 2016-12-08 08:52:44 -05:00
Ben Marsh
4ba423868f Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) 
#lockdown Nick.Penwarden
#rb none

==========================
MAJOR FEATURES + CHANGES
==========================

Change 3209340 on 2016/11/23 by Ben.Marsh

	Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.

	Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.

	  * Every header now includes everything it needs to compile.
	        * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
	        * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
	  * Every .cpp file includes its matching .h file first.
	        * This helps validate that each header is including everything it needs to compile.
	  * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
	        * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
	        * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
	  * No engine code explicitly includes a precompiled header any more.
	        * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
	        * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.

	Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.

[CL 3209342 by Ben Marsh in Main branch]
 2016-11-23 15:48:37 -05:00
Max Chen
888c42933d Copying //UE4/Dev-Sequencer to //UE4/Dev-Main (Source: //UE4/Dev-Sequencer @ 3178529) 
#lockdown Nick.Penwarden
#rb none

==========================
MAJOR FEATURES + CHANGES
==========================

Change 3149443 on 2016/10/03 by Max.Preussner

	MediaAssets: Better parameter names for MediaPlayer BP functions

Change 3149756 on 2016/10/03 by Max.Chen

	Sequence Recorder: Set some settings to be clamped at 0 (sequence length, recording delay, audio gain, audio input buffer size, nearby actor recording proximity)

	#jira UE-35233

Change 3149795 on 2016/10/03 by Max.Chen

	Curve Editor: Set tangent to user when flattening or straightening tangents only when the tangent mode is auto and the interp mode is cubic.

	#jira UE-36734

Change 3150378 on 2016/10/04 by Max.Preussner

	PS4Media: Made video buffer sizes for file and HLS sources configurable (UE-36807)

	#jira UE-36807

Change 3151414 on 2016/10/05 by Max.Chen

	Sequencer: Fix case where restoring the last view target was getting skipped. It should always restore if the camera object and the unlock if camera actor object is null.

	#jira UE-35285

Change 3152038 on 2016/10/05 by Max.Preussner

	UdpMessaging: Code & documentation modernization pass

Change 3152471 on 2016/10/05 by Max.Chen

	Cine Camera: Don't enable/disable actor ticking based soley on actor tracking since actor ticking is needed for other purposes. Instead, always enable actor ticking and only update actor tracking on tick if necessary. This fixes a
bug where the cine camera actor won't tick if you hook in event tick.

	#jira UE-36625

Change 3152692 on 2016/10/05 by Max.Preussner

	Messaging: API code & documentation modernization pass

	Mostly removed shared pointer/ref typedefs as they prevent forward declarations and increase include complexity.

Change 3153824 on 2016/10/06 by Max.Preussner

	Messaging: Renamed IConnectionBasedMessagingModule to ITcpMessagingModule and moved it into TcpMessaging

	I recommend that we refactor this API. The dependency should be reversed, i.e. instead of AndroidDeviceDiscovery depending on the TcpMessaging plug-in module, the Engine should provide a central registry that device discovery
modules can notify, and that message transport plug-ins can register with and listen to OnConnectionAdded/Removed events etc. That way it supports an arbitrary number of transport plug-ins, and the Engine is not coupled to any of them. This
functionality is not necessarily related to messaging, and the Messaging API is transport agnostic anyway. I'll think about this some more.

Change 3153826 on 2016/10/06 by Max.Preussner

	Messaging: Removed remaining typedefs in IMessageTracer to enable forward declaration and reduce include dependencies

Change 3153857 on 2016/10/06 by Max.Chen

	Sequencer: Set snap time to dragged key on by default.

Change 3153980 on 2016/10/06 by Max.Preussner

	SessionServices: Removed typedefs; code and documentation modernization pass

Change 3154313 on 2016/10/06 by Max.Chen

	Sequencer: Set the paste keys time to the current time, rather than the mouse time.

Change 3154332 on 2016/10/06 by Max.Chen

	Sequencer: Remove click to rename shot functionality in the shot thumbnail. Added rename shot to the shot context menu.

Change 3154377 on 2016/10/07 by Max.Chen

	Sequencer: Add ability to step to beginning and ends of sections/shots using the hotkeys: , and .

Change 3154788 on 2016/10/07 by Max.Chen

	Sequencer: Fix offsets that created when moving multiple sections. The offsets were being created because section bounds were being generated for all sections except for the current section. Instead, they should be computed for all
sections except for any that aren't being moved.

	#jira UE-29152

Change 3159274 on 2016/10/11 by Max.Preussner

	Core: Documentation fixes

Change 3159275 on 2016/10/11 by Max.Preussner

	UdpMessaging: Added missing header

Change 3160746 on 2016/10/12 by Max.Preussner

	MediaAssets: Added BP functions to query width, height, and aspect ratio of UMediaTexture instances

	#jira UE-37241

Change 3160975 on 2016/10/12 by Max.Preussner

	PS4Media: Better logging for SetRate failures

Change 3160995 on 2016/10/12 by Max.Preussner

	MediaPlayerEditor: Fixed Media player selection is ignored if media specifies player overrides (UE-37248)

	#jira UE-37248

Change 3161066 on 2016/10/12 by Max.Preussner

	PS4Media: Enforcing minimum 8 byte alignment for media allocations

Change 3161069 on 2016/10/12 by Max.Preussner

	PS4Media: Fixed log spam when setting play rate to current rate

Change 3162567 on 2016/10/13 by Max.Preussner

	PS4Media: Made track switching code more readable

Change 3163447 on 2016/10/14 by Max.Preussner

	PS4Media: Fixed array out of bounds assertions

Change 3163772 on 2016/10/14 by Max.Preussner

	MfMedia: Fixed a number of timing related issues

Change 3163980 on 2016/10/15 by Max.Chen

	Sequencer: Remove folder name numeric padding so that the naming convention is similar to creating objects in the level.

Change 3164581 on 2016/10/17 by Andrew.Rodham

	Sequencer: Ensure global pre-animated state is restored in reverse order

Change 3164582 on 2016/10/17 by Andrew.Rodham

	Sequencer: Ensure pre animated state is restored for all actor components before saving default state

Change 3164583 on 2016/10/17 by Andrew.Rodham

	Sequencer: Re-enabled support for pre and post roll

Change 3165464 on 2016/10/17 by Max.Chen

	Sequencer: Default number frame handles to 0 so that there's no change in behavior when rendering out a master sequence of shots. Handle frames need to enabled explicitly by the user.

	Copy from Release-4.14

	#jira UE-37416

Change 3165483 on 2016/10/17 by Max.Chen

	Sequencer: Enable restore state for attach section completion

Change 3165771 on 2016/10/18 by Andrew.Rodham

	Sequencer: Force evaluate when rendering thumbnails

	#jira UE-37321

Change 3166057 on 2016/10/18 by Andrew.Rodham

	Sequencer: Only set defaults for tracks that have no keys, and where the requested default has changed

	#jira UE-37285

Change 3166218 on 2016/10/18 by Max.Preussner

	MediaPlayerEditor: Failure opening media, even though it opened successfully (UE-37470)

	#jira UE-37470

Change 3166247 on 2016/10/18 by Max.Preussner

	WmfMedia: Showing progress bar while media is being resolved

Change 3166289 on 2016/10/18 by Max.Preussner

	MfMedia: Showing progress bar while media is being resolved

Change 3166993 on 2016/10/18 by Max.Preussner

	MfMedia: Fixed info string not reset on media close.

Change 3166999 on 2016/10/19 by Max.Preussner

	Media: Fixed NV12 and NV21 support

Change 3167008 on 2016/10/19 by Max.Preussner

	Media: Removed vertical NV12 alignment

Change 3167029 on 2016/10/19 by Max.Preussner

	WmfMedia: Temp fix for RGB32 encoded AVIs rendering upside-down and too bright (UE-37505)

	#jira UE-37505

Change 3168593 on 2016/10/19 by Max.Chen

	Sequencer: Change paste at time to local time, so that the paste happens in the local time of the sequence rather than the global time if pasting in a shot level sequence.

Change 3168626 on 2016/10/19 by Max.Chen

	Sequencer: Clamp to view bounds should snap to frame if frame snapping is on.

Change 3168627 on 2016/10/19 by Max.Chen

	Sequencer: Initialize working and view range to be 10% larger than playback range.

Change 3168760 on 2016/10/20 by Max.Preussner

	Media: Revamped media texture buffer management to support padded frames

	Added support for Windows bitmap buffers.
	Fixed a number of format, conversion and/or looping issues in WmfMedia and MfMedia.
	Not all shaders have been updated yet.

Change 3169640 on 2016/10/20 by Max.Chen

	Sequencer: Add current camera to FLevelSequencePlayerSnapshot. Adjust DefaultBurnIn to include a few more parameters like focal length and focus distance.

	#jira UE-37407

Change 3170677 on 2016/10/21 by Max.Chen

	Movie Scene Capture: Add toggle to override engine scalability settings to cinematic scalability.

	#jira UE-36560

Change 3170710 on 2016/10/21 by Max.Preussner

	Media: Optimized handling of RGB input

Change 3170712 on 2016/10/21 by Max.Preussner

	Media: Fixed NV21 conversion shader scaling

Change 3170923 on 2016/10/21 by Max.Preussner

	UBT: Copied XboxOne project generator fix from Fortnite CL# 3170868

Change 3171494 on 2016/10/23 by Max.Chen

	Sequencer: Fix fbx export from master sequence not finding bound objects.

	#jira UE-35752

Change 3171506 on 2016/10/23 by Max.Chen

	Sequencer: Draw where in and out points of the shot section are, just like subsequences do. Change to only draw the green starting line if StartOffset is negative.

	#jira UE-35473

Change 3171743 on 2016/10/24 by Andrew.Rodham

	Editor: Added support for detail customizations on root structs
	  - Also added the ability to add external struct data onto a detail category builder, and property type customization.

Change 3171752 on 2016/10/24 by Andrew.Rodham

	Sequencer: Fixed spawnable ownership
	  - Spawnables are no longer destroyed when the cursor leaves the master playback range.
	  - Spawnable ownership now operates as it previously did before the evaluation rework.
	  - bIgnoreOwnershipInEditor has been removed since its existence was a work around for when we didn't evaluate sub sequences from the master sequence.
	  - FMovieSceneSequenceID is now a struct so that it can be used in array properties
	  - Meta data now exists for each segment of an evaluation field. Currently this only includes the sub sequence IDs that exist at that time, but it may be expanded to include all evaluation entities (tracks + sections) in future so
we don't have to calculate that at runtime.

Change 3171756 on 2016/10/24 by Andrew.Rodham

	Sequencer: Added ability to trigger events with parameters
	  - It's now possible to supply an event payload on event track keys which are to be passed to a given event. The structure must match the signature of the event, or a warning will be emitted.
	  - Added a templated TGenericKeyArea, TKeyFrameManipulator and TCurveInterface that allow to generic manipulation of keyframe section data. In time we will port the other key areas over to this representation.
	    - This new architecture affords the common manipulation of time-based keyframes in a value-agnostic manner.

Change 3172935 on 2016/10/24 by Max.Preussner

	MediaPlayerEditor: Fixed MediaPlayer asset not being dirtied when creating media sound wave or texture for it

Change 3173947 on 2016/10/25 by Max.Preussner

	SlateRemote: Disabled plug-in, but enabled server by default

Change 3174510 on 2016/10/26 by Max.Chen

	Sequencer: Fix slomo track crash

	#jira UE-37802

Change 3174698 on 2016/10/26 by Andrew.Rodham

	UMG: Fixed objects bound to a panel slot animating their slot's content instead of the slot itself

	#jira UE-37775

Change 3174780 on 2016/10/26 by Max.Preussner

	MediaAssets: Accepting decoder defined buffer dimensions for RGB buffers

Change 3174789 on 2016/10/26 by Max.Preussner

	MediaPlayerEditor: Showing desired player name instead of current player name if no media loaded

Change 3174817 on 2016/10/26 by Max.Preussner

	WmfMedia: Added support for Motion JPEG (MJPG)

Change 3174825 on 2016/10/26 by Max.Preussner

	WmfMedia: Added support for non-RGB32 uncompressed formats

Change 3174834 on 2016/10/26 by Max.Preussner

	MediaPlayerAssets: Allow pausing while buffering media

Change 3174886 on 2016/10/26 by Andrew.Rodham

	Core: Fixed range test that was testing incorrect behavior

Change 3174889 on 2016/10/26 by Andrew.Rodham

	Sequencer: Fixed AssignActor behavior
	  - Also ensure that cached object state is invalidated when playback context changes

	#jira UE-37798

Change 3174905 on 2016/10/26 by Andrew.Rodham

	Sequencer: Changed assert when failing to create an audio component to a log message
	  - Audio no longer plays when GEngine->UseSound() is false

	#jira UE-37772

Change 3174980 on 2016/10/26 by Andrew.Rodham

	Sequencer: Remove warning when event endpoint could not be found for a given context

	#jira UE-37824

Change 3175001 on 2016/10/26 by Andrew.Rodham

	Sequencer: Evaluate sequence with EMovieScenePlaybackStatus::Jumping on Pause.
	  - Also protect Pause() against reentrancy when being called from an event

Change 3175012 on 2016/10/26 by Max.Chen

	Sequence Recorder: Fixes an empty working and view range after recording.

	On StopRecording() update playback range after nullifying the current sequence so that the playback range isn't empty.
	Added SetViewRange and SetWorkingRange.

	#jira UE-34191

Change 3177760 on 2016/10/28 by Max.Chen

	Sequence Recorder: Don't update the current sequence name if it's already set. This fixes a bug where if you pass in a sequence name to record to, it gets reset to the name in the sequence recorder settings.

	#jira UE-37808

Change 3178529 on 2016/10/28 by Max.Chen

	Matinee to Level Sequence: Added interface to extend the matinee to level sequence converter

	#jira UE-37328
	#2864

[CL 3178562 by Max Chen in Main branch]
 2016-10-28 15:04:38 -04:00
Max Chen
4cde9c20a0 Copying //UE4/Dev-Sequencer to //UE4/Main 
==========================
MAJOR FEATURES + CHANGES
==========================

Change 2875025 on 2016/02/20 by Andrew.Rodham

	Sequencer: Cinematic viewport improvements
	  - Added optional letterbox overlay (defaults to 2.35:1)
	  - Added ability to change safe frame colors
	  - Added selected tracks' keys to the transport range
	  - Added buttons for jumping between selected tracks' keyframes on the transport controls
	  - Removed black padding around the viewport where possible
	  - Added ability to specify whether a combo button/menu anchor should close when its parent receives focus
	  - Separated logic of FGroupedKeyArea into FSequencerKeyCollection, so it can be used independently
	  - Added playback range to the viewport frame numbers
	  - All frame numbers are now spin boxes

	#jira UE-26429

Change 2875026 on 2016/02/20 by Thomas.Sarkanen

	Added console commands for recording sequences

	Changed plugin to a developer plugin so we can load it when the editor is in -game mode.
	Added Exec commands.
	Added some more logging to help diagnose problems when using commands.
	Added loading/saving of config for recorder settings (stored in Editor.ini).
	Also disabled controls in recorder window when recording.
	Added auto-saving of assets when in non-editor modes.
	Moved animation settings from UnrealEd to Engine module.

Change 2875036 on 2016/02/20 by Max.Chen

	Sequencer: Call RedrawAllViewports instead of RedrawLevelEditingViewports. In particular, this fixes some update issues when editing values in the key editors.

	#jira UE-26960

Change 2875046 on 2016/02/20 by Max.Preussner

	Sequencer: Fix so that clicking on UMG Animations doesn't dirty the scene.

	#jira UE-26249

Change 2875047 on 2016/02/20 by Max.Chen

	Sequencer: Add option to toggle display of channel colors/lines. View->Channel Colors

Change 2877138 on 2016/02/23 by Max.Chen

	Sequencer: Select corresponding track node when selecting key or section. Removed active/inactive selection since it was only being used in deletion and the rules for deletion are now dependent upon what is selected - delete keys and sections before deleting outliner nodes.

Change 2877143 on 2016/02/23 by Thomas.Sarkanen

	Added new math function: WindRelativeAnglesDegrees

	Given two angles in degrees, 'wind' the angle in Angle1 so that it avoids >180 degree flips.
	Good for winding rotations previously expressed as quaternions into a euler-angle representation.

Change 2877147 on 2016/02/23 by Thomas.Sarkanen

	Added the ability to import sequencer transforms from the root node of an animation sequence

	Intended for use after re-importing animations from DCC tools.
	Available in the right-click menu for transform tracks.
	Also added FindTrackBinding to UMovieScene so track bindings can be recovered from tracks.

Change 2877163 on 2016/02/23 by Max.Chen

	Sequencer: Add option to create keyframe sections as infinite. Sequencer defaults to true, UMG defaults to false.

Change 2877165 on 2016/02/23 by Max.Preussner

	Sequencer: Drawing vertical position lines when dragging keys

Change 2878748 on 2016/02/23 by Max.Chen

	Curve Editor: Switch curve type to user when flatting or straightening tangents.

	#jira UE-27277

Change 2878799 on 2016/02/23 by Frank.Fella

	Sequencer - Add folders support to the outliner.

Change 2880769 on 2016/02/24 by Andrew.Rodham

	Sequencer: Added ability to override runtime spawnable ownership in sequencer
	  - This is exposed as an option on spawnables "Keep Alive Outside Playback Range (In Sequencer)"
	  - Enabling this will stop spawnables from being destroyed when scrubbing outside of the playback range

	#jira UE-27205

Change 2880770 on 2016/02/24 by Thomas.Sarkanen

	Sequencer: Added countdown and recording indicator display when recording

	Also fixed extra popups added post-PIE when animation recordings auto shutdown.

Change 2880782 on 2016/02/24 by Max.Chen

	Sequencer: Snapping now also uses the current time as a possible snap time.

	#jira UE-26306

Change 2880793 on 2016/02/24 by Max.Chen

	Sequencer: Add +Animation to Animation track so that it's consistent with all other tracks that have a + button.

Change 2880812 on 2016/02/24 by Max.Chen

	Sequencer: Fix adjusting the leading edge of a shot section so that it cuts into the shot rather than adjusts the start time.

	#jira UE-26306

Change 2881624 on 2016/02/25 by Andrew.Rodham

	Changing shader version GUID to fix corrupt shaders in ddc

Change 2882408 on 2016/02/25 by Thomas.Sarkanen

	Asset/actors stored in TLazyObjectPtrs can now reference game content from engine

	This is a legitimate use case as lazy object ptrs are designed to reference assets/actors cross-domain.

Change 2882409 on 2016/02/25 by Thomas.Sarkanen

[CL 2899785 by Max Chen in Main branch]
 2016-03-08 16:55:04 -05:00
Max Chen
dfad80bd9e Copying //UE4/Dev-Sequencer to Dev-Main (//UE4/Dev-Main) 
==========================
MAJOR FEATURES + CHANGES
==========================

Change 2800717 on 2015/12/11 by Max.Chen

	Sequencer: Sort the key times for drawing to fix path trajectory.
	#jira UE-24331

Change 2803299 on 2015/12/15 by Max.Chen

	Sequencer: Fix property names so that they're the display names. For example, "DepthOfFieldFStop" now reads as "Aperture F Stop"

Change 2804586 on 2015/12/15 by Max.Chen

	Sequencer: Add zoom in/out with shortcuts underscore and equals.

Change 2811823 on 2015/12/23 by Max.Preussner

	Editor: Added UI action for creating new content browser folders; code cleanup; removed dead code

	Based on GitHub PR #1809 by artemavrin (https://github.com/EpicGames/UnrealEngine/pull/1809)

	#github: 1809

Change 2811839 on 2015/12/23 by Max.Preussner

	StereoPanorama: Code cleanup pass

	Based on GitHub PR# 1756 by ETayrienHBO (https://github.com/EpicGames/UnrealEngine/pull/1756)

	Also:
	- NULL to nullptr
	- namespaced enums to enum classes
	- consistent whitespace, line breaks and parentheses

	#github: 1756

Change 2819172 on 2016/01/07 by Andrew.Rodham

	Sequencer: Marquee and move modes are now automatically activated based on sequencer hotspot

Change 2819176 on 2016/01/07 by Andrew.Rodham

	Sequencer: Various cosmetic fixes

	  - Added icons to tracks
	  - Removed SAnimationOutlinerTreeNode dependency from FSequencerDisplayNode (to enable future customization of shot/event track etc)
	  - Added spacer nodes between top level display nodes
	  - Various hover states and highlights

Change 2819445 on 2016/01/07 by Andrew.Rodham

	Sequencer: Rendering out a capture from the composition graph now renders at the correct size even if r.ScreenPercentage is not 100.
	#jira UE-24920

Change 2820747 on 2016/01/08 by Andrew.Rodham

	Sequencer: Added option to close the editor when capturing starts
	#jira UE-21932

Change 2827701 on 2016/01/13 by Max.Preussner

	Media: Updating audio track specs each frame to better support streaming media and variable streams.

Change 2828465 on 2016/01/14 by Max.Preussner

	Media: Better visualization of unknown media durations

Change 2828469 on 2016/01/14 by Max.Preussner

	Media: Checking URL scheme on URLs that didn't pass the file extension filter

Change 2834888 on 2016/01/19 by Max.Preussner

	Core: TQueue modernization pass

Change 2834934 on 2016/01/19 by Max.Preussner

	Core: Implemented TTripleBuffer for triple buffers.

Change 2834950 on 2016/01/19 by Max.Preussner

	Core: Added unit tests for TTripleBuffer dirty flag

Change 2835488 on 2016/01/20 by Max.Preussner

	Core: More descriptive method names, initialization constructor, unit tests for TTripleBuffer

Change 2837515 on 2016/01/20 by Max.Chen

	Sequencer: Command line options for custom passes.

Change 2837517 on 2016/01/20 by Max.Chen

	Sequencer: Fix crash in visibility track instance on PIE.

Change 2837518 on 2016/01/20 by Max.Chen

	Sequencer: Add option to lock to frame rate while playing.
	#jira UETOOL-475

Change 2837523 on 2016/01/20 by Max.Chen

	Sequencer: Capture thumbnail on level sequence asset save.

Change 2837527 on 2016/01/20 by Max.Chen

	Sequencer: Added preroll for subsequences. Refactor instance update to combine data in EMovieSceneUpdateData.
	#jira UE-25380

Change 2837537 on 2016/01/20 by Max.Chen

	Sequencer: Add sequencer transport controls back into viewports.
	#jira UE-25460

Change 2837561 on 2016/01/20 by Max.Chen

	Sequencer: Added ability to convert a possessable to a spawnable

	  - This option is available for any root-level possessable object bindings
	  - It will currently delete the existing possessable (we could make this behaviour optional in future)
	  - There is currently no check to sett if the actor is possessed by subsequent sub-sequences. If this is the case, using a possessable, or externally owned spawnable would be a better bet.

Change 2837565 on 2016/01/20 by Max.Chen

[CL 2858958 by Max Chen in Main branch]
 2016-02-08 13:35:28 -05:00