#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3061854 on 2016/07/22 by Bob.Tellez
Duplicate CL#3058653 //Fortnite/Main
#UE4 Now actually removing deprecated pins from non-blueprint graphs. Also MarkPendingKill now happens in UEdGraphNode's BeginDestroy instead of its destructor to ensure supporting code can safely access references to other UObjects.
Change 3068095 on 2016/07/28 by Maciej.Mroz
#jira UE-32942 BP Nativization: Reduce the size of executable files
Private and protected properties have PrivatePropertyOffset (PPO) function in .generated.h. This function allows the nativized code to access the property without using UProperty.
-It reduces the size of executable file (added by nativized plugin) about 10%. The OrionGame.exe (development config) is 6MB smaller.
-It reduces the number of FindField function calls and stativ variables in the nativized code.
List of inaccessible properties (that cannot be accessed using PPO) is logged while cooking (with nativization enabled).
Change 3070569 on 2016/07/29 by Bob.Tellez
Duplicating CL#3070518 from //Fortnite/Main
#UE4 Deprecated pin removal logic is now exclusively in UEdGraphNode::PostLoad. DeprecatedPinWatches fixup is now done in K2Node::PostLoad.
Change 3081792 on 2016/08/08 by Dan.Oconnor
Widget and Animation blueprint diffing is no longer experimental, added warning explaining shortcomings. This is preferrable because the text diff is basically useless
#jira UE-1234
Change 3081865 on 2016/08/09 by Dan.Oconnor
build fix
#jria UE-1234
Change 3082839 on 2016/08/09 by Bob.Tellez
Duplicating CL#3082835 from //Fortnite/Main
#UE4 Fix an issue where changing an array property in the defaults will leave the custom property chain stale until it is compiled, causing a crash in some circumstances.
Change 3083367 on 2016/08/09 by Dan.Oconnor
Fix for actors detaching when compiling a blueprint, needed to read attachment data before actors are destroyed, in case we're attached to another instance of the same type. Deemed too risky for 4.13.
#jira UE-33278
Change 3083825 on 2016/08/10 by Maciej.Mroz
#jira UE-34372 [CrashReport] UE4Editor_CoreUObject!StaticAllocateObject() [uobjectglobals.cpp:2102]
VariableNames are validated at the begining of FKismetCompilerContext::Compile, because the validation requires CDO.
Removed legacy code from FBlueprintEditorUtils::RenameMemberVariable.
Change 3084313 on 2016/08/10 by Maciej.Mroz
#jira UE-33883 Packaging with Nativize Blueprint Assets Causes Uninitialized Defaults
Change 3085572 on 2016/08/11 by Maciej.Mroz
#jira UE-34436 Ensures when copy/pasting linked anim bp nodes
Redone cl#3085568 from 4.13 branch
FGraphObjectTextFactory doesn't call compilation (it is called later by FBlueprintEditor::PasteNodesHere, when all nodes are pasted). CallFunction can be pasted even when it's function doesn't exist. The function could be created from a CustomEvent node, that was also pasted (so it wasn't compiled yet).
Change 3087171 on 2016/08/12 by Maciej.Mroz
BP Nativization:
- FCustomThunkTemplates functions have the same declarations as original functions in Kismet Array Library
- Properly declared scope of final functions
- "AdditionalPublicDependencyModuleNames" option in "BlueprintNativizationSettings" (applied in Orion)
Change 3088713 on 2016/08/15 by Ben.Cosh
This updates the tunnel boundary compile time code to catch end of thread execution inside tunnels and provide instrumentation for it.
#Jira UE-33563 - Macros without any outputs do not have their stats listed when called from a Keypress Event when profiling.
#Proj BlueprintGraph, BlueprintProfiler, Kismet, KismetCompiler, UnrealEd
Change 3088734 on 2016/08/15 by Ben.Cosh
Minor change to the changes submitted in CL 3088713 after finding an issue during use.
#Jira UE-33563 - Macros without any outputs do not have their stats listed when called from a Keypress Event when profiling.
#Proj BlueprintGraph, BlueprintProfiler, Kismet, KismetCompiler, UnrealEd
Change 3091248 on 2016/08/16 by Dan.Oconnor
Removing unused function
Change 3091555 on 2016/08/17 by Maciej.Mroz
#jira UE-34745 [CrashReport] UE4Editor_BlueprintGraph!UEdGraphSchema_K2::CreateSubstituteNode() [edgraphschema_k2.cpp:5601]
Fixed unsafe code.
Change 3091767 on 2016/08/17 by Ben.Cosh
Minor refresh on the threshold settings interface to allow more immediate visualisation of thresholds.
#Jira UE-33572 - BP Profiler - Refresh heatmap coloring when thresholds changed.
#Jira UE-33702 - BP Profiler - Custom heatmap thresholds appear to be broken
#Jira UE-33698 - BP Profiler: Default heatmaps to on
#Proj Kismet, BlueprintProfiler
Reviewer notes:
- Added an interfacel to indicate if performance thresholds have changed in BlueprintProfilerSettings so we can action changes
- Added code to force update heat interfaces in the blueprintprofiler if thresholds are dirty.
- Modified the BlueprintProfilerToolbar to reflect the above changes and only save settings when the combo dialog is closed ( saving on change makes the sliders unusable )
- Fixed the custom thresholds ( made them reciprical ) for testing.
- Node heatmaps default to average
- Heatmap display modes now get saved to the config
Change 3091770 on 2016/08/17 by Ben.Cosh
Refresh on the blueprint profiler node heatmaps
#Jira UE-34802 - Fix the blueprint profiler node heatmaps, the current visualisation is first pass prototype.
#Proj GraphEditor, EditorStyle
Reviewer notes:
- Quick update on the node heatmaps moving to a more graph editor sympathetic approach in code
- Removed the old interfaces and added a new overlay pass in the grapheditor processed before the node shadow brushes.
- Now the nodes have an outline/glow heatmap that doesn't color the node body ( I have an alternate set of images that also color the body if we decide on we still want that )
Change 3091972 on 2016/08/17 by Ben.Cosh
Changing the blueprint profiler heatmap displays to be full node colorisation.
#Jira none
Change 3092515 on 2016/08/17 by Ryan.Rauschkolb
Fixed Struct Ref pin in UK2Node_SetFieldsInStruct can be split when optional pins are visible
#UE-34060
Change 3093644 on 2016/08/18 by Maciej.Mroz
#jira UE-31754 BP interface signature change doesn't update child Blueprint
- Introduced FCustomCompilationSettingsMap. FKismetEditorUtilities::CompileBlueprint can compile many blueprints (due to reinstaning), now we can specify separate compilation settings for each BP.
- Simplified FKismetEditorUtilities::CompileBlueprint parameters list
- FunctionEntry and FunctionResult nodes depends on Interface (if they implement a function , that was declared in the interface).
- Interface is primary source of function signature (previously it was parent class)
- When an Interface is compiled all BPs, that implement it, have refreshed nodes in proper order.
- FBlueprintEditor::Compile ensures, that all parent classes of current BP are up-to-date
Change 3093694 on 2016/08/18 by samuel.proctor
Adding members to QA Test UDS
Change 3096778 on 2016/08/22 by Mike.Beach
Fixing Dev-BP CIS - closing bracket was mistakenly removed (thanks auto-merge).
Change 3097150 on 2016/08/22 by Mike.Beach
When converting function entry/exit nodes from an interface, set the replacement user-defined pins "DesiredDirection" properly (we now reject pins that don't match the expected direction, and user-defined pins created this way were setup wrong).
#jira UE-34985
Change 3097878 on 2016/08/23 by Ryan.Rauschkolb
BP Profiler: Fixed stack overflow when compiling tunnels that contain loops
#jira UE-34767
Change 3098294 on 2016/08/23 by Maciej.Mroz
#jira UE-30031, UE-34760, UE-34761
- Use Delta Serialization when exporting UDS value as text
- Default Values of Local Variables (of UDS type) are refreshed while BP regeneration
- Importing struct from text uses property guid (see CustomFindProperty)
Change 3098599 on 2016/08/23 by Ryan.Rauschkolb
Fixed option for split struct pin not appearing in context menu
#jira UE-35108
[CL 3100065 by Mike Beach in Main branch]
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2716841 on 2015/10/05 by Mike.Beach
(WIP) Cleaning up how we setup script assets for replacement on cook (aligning more with the Blueprint conversion tool).
#codereview Maciej.Mroz
Change 2719089 on 2015/10/07 by Maciej.Mroz
ToValidCPPIdentifierChars handles propertly '?' char.
#codereview Dan.Oconnor
Change 2719361 on 2015/10/07 by Maciej.Mroz
Generated native code for AnimBPGC - some preliminary changes.
Refactor: UAnimBlueprintGeneratedClass is not accessed directly in runtime. It is accessed via UAnimClassInterface interface.
Properties USkeletalMeshComponent::AnimBlueprintGeneratedClass and UInterpTrackFloatAnimBPParam::AnimBlueprintClass were changed into "TSubclassOf<UAnimInstance> AnimClass"
The UDynamicClass also can deliver the IAnimClassInterface interface. See UAnimClassData, IAnimClassInterface::GetFromClass and UDynamicClass::AnimClassImplementation.
#codereview Lina.Halper, Thomas.Sarkanen
Change 2719383 on 2015/10/07 by Maciej.Mroz
Debug-only code removed
Change 2720528 on 2015/10/07 by Dan.Oconnor
Fix for determinsitc cooking of async tasks and load asset nodes
#codereview Mike.Beach, Maciej.Mroz
Change 2721273 on 2015/10/08 by Maciej.Mroz
Blueprint Compiler Cpp Backend
- Anim Blueprints can be converted
- Various fixes/improvements
Change 2721310 on 2015/10/08 by Maciej.Mroz
refactor (cl#2719361) - no "auto" keyword
Change 2721727 on 2015/10/08 by Mike.Beach
(WIP) Setup the cook commandlet so it handles converted assets, replacing them with generated classes.
- Refactored the conversion manifest (using a map over an array)
- Centralized destination paths into a helper struct (for the manifest)
- Generating an Editor module that automatically hooks into the cook process when enabled
- Loading and applying native replacments for the cook
Change 2723276 on 2015/10/09 by Michael.Schoell
Blueprints duplicated for PIE will no longer register as dependencies to other Blueprint.
#jira UE-16695 - Editor freezes then crashes while attempting to save during PIE
#jira UE-21614 - [CrashReport] Crash while saving during PIE - FKismetEditorUtilities::CompileBlueprint() kismet2.cpp:736
Change 2724345 on 2015/10/11 by Ben.Cosh
Blueprint profiler at first pass, this includes the ability to instrument specific blueprints with realtime editor stat display.
#UEBP-21 - Profiling data capture and storage
#UEBP-13 - Performance capture landing page
#Branch UE4
#Proj BlueprintProfiler, BlueprintGraph, EditorStyle, Kismet, UnrealEd, CoreUObject, Engine
Change 2724613 on 2015/10/12 by Ben.Cosh
Incremental update for blueprint profiler to fix the way some of the reported stats cascade through events and branches and additionally some missed bits of code are refactored/removed.
#Branch UE4
#Proj BlueprintProfiler
#info Whilst looking into this I spotted the reason why the stats seem so erratic, There appears to be an issue with FText's use of EXPERIMENTAL_TEXT_FAST_DECIMAL_FORMAT which I have reported, but ideally disable this locally until a fix is integrated.
Change 2724723 on 2015/10/12 by Maciej.Mroz
Constructor of a dynamic class creates CDO.
#codereview Robert.Manuszewski
Change 2725108 on 2015/10/12 by Mike.Beach
[UE-21891] Minor fix to the array shuffle() function; now processes the last entry like all the others.
Change 2726358 on 2015/10/13 by Maciej.Mroz
UDataTable is properly saved even if its RowStruct is null.
https://udn.unrealengine.com/questions/264064/crash-using-hotreload-in-custom-datatable-cdo-clas.html
Change 2727395 on 2015/10/13 by Mike.Beach
(WIP) Second pass on the Blueprint conversion pipeline; setting it up for more optimal (speedier) performance.
* Using stubs for replacements (rather than loading dynamic replacement).
* Giving the cook commandlet more control (so a conversion could be ran directly).
* Now logging replacements by old object path (to account for UPackage replacement queries).
* Fix for [UE-21947], unshelved from CL 2724944 (by Maciej.Mroz).
#codereview Maciej.Mroz
Change 2727484 on 2015/10/13 by Mike.Beach
[UE-22008] Fixing up comment/tooltip typo for UActorComponent::bAutoActivate.
Change 2727527 on 2015/10/13 by Mike.Beach
Downgrading an inactionable EdGraph warning, while adding more info so we could possibly determine what's happening.
Change 2727702 on 2015/10/13 by Dan.Oconnor
Fix for crash in UDelegateProperty::GetCPPType when called on a function with no OwnerClass (events)
Change 2727968 on 2015/10/14 by Maciej.Mroz
Since ConstructorHelpers::FClassFinder is usually static, the loaded class should be in root set, to prevent the pointer stored in ConstructorHelpers::FClassFinder from being obsolete.
FindOrLoadClass behaves now like FindOrLoadObject.
#codereview Robert.Manuszewski, Nick.Whiting
Change 2728139 on 2015/10/14 by Phillip.Kavan
Made accessors to get the Function Entry's flags for the generated UFunction and for retrieval of the final skeleton class's UFunction's flags.
#jira UE-17804 - Overridden functions in Child Blueprints cannot be converted to/from pure functions
[CL 2635959 by Michael Schoell in Main branch]
Shifted a lot of pin adding functionality from Blueprint Details customizion to the nodes themselves or BlueprintEditorUtils.
#jira UE-11334 - Dragging a pin to a node that can add pins (function entry/exit, custom events...) should add a pin of the type to the node.
[CL 2497224 by Michael Schoell in Main branch]
Rob asked me to back out GENERATED_*_BODY -> GENERATED_BODY change for now until the "_Validate and _Implementation auto-generation" discussion is over.
#codereview Robert.Manuszewski
[CL 2481343 by Jaroslaw Palczynski in Main branch]
Details view supports displaying UProperties from external UStruct's that are not a property of a UObject.
#jira UE-2246 - BP: Local function variables need to support default values
[CL 2383580 by Michael Schoell in Main branch]
this change introduces enforcement of 'const-correctness' into implemented function graphs.
summary:
if you have a function declared in C++ like this:
UFUNCTION(BlueprintImplementableEvent)
int32 MyFunctionThatReturnsSomeValue() const;
if you implement that (BPIE) function in a Blueprint that's parented to that native class, it will now be flagged as 'const'. this makes any properties of 'self' read-only within the context of that graph, which means the compiler will emit an error if you try to set a property or otherwise call a non-const, non-static function with 'self' as the target.
if there happens to already be an implemented const function in a Blueprint that was in place prior to this change, the compiler will emit a warning instead of an error, in order to allow existing Blueprints that may currently be "violating" const within the context of a const BPIE function to still compile, while still alerting to issues that should probably be addressed.
notes:
1) this also applies to BlueprintNativeEvent (BPNE) implementations, and also when implementing BPIE/BPNE interface methods that are also declared as const
2) a const BPIE/BPNE function with no return value and no output parameters will be implemented as a "normal" impure function, and not as an event as in the non-const case
3) a const BPIE/BPNE function with a return value and/or output parameters will currently be implemented as a pure function, regardless of whether or not BlueprintCallable is specified
4) this CL also retains some consolidation of static function validation code that i had previously done, mostly to allow static functions to more easily be whitelisted for const function graphs
#codereview Nick.Whiting, Michael.Noland
[CL 2368059 by Phillip Kavan in Main branch]
#change Deprecated UK2Node_LocalVariable
#change UK2Node_LocalVariable will replace itself with a Get and any Assign nodes it is hooked up to with a Set node, will also delete itself from Animation rule graphs that they should not have been allowed to be placed in
#ttp 332158 - BP: Make local variables use standard get / set nodes, instead of the assigned named local nodes
[CL 2068725 by Michael Schoell in Main branch]
ttp333765 Function libraries that use blueprint nodes requiring a worldcontextobject cause ensures in cooked builds
#codereview Nick.Whiting
[CL 2060114 by Maciej Mroz in Main branch]
#add Added UEdGraphNode::GetNodeNativeTitle to return a native title for a node.
#add Added UEdGraphNode::GetNodeSearchTitle to return the native and localized title for a node, together, for searching.
#add Can hold "alt" over a node (in the graph panel, or the palette) to see the native name of the node.
#ttp 331252 - Blueprints: Editor: L10N: Blueprints need to consistently show localized node names and when searching need to search both the localized name and the native name
#codereview justin.sargent
[CL 2044506 by Michael Schoell in Main branch]
