daniel lamb
772c886aab
Fixed crash in diff cook commandlet.
...
#rb Andrew.Grant
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: daniel.lamb
#ROBOMERGE-SOURCE: CL 5558994 via CL 5559027 via CL 5560253 via CL 5561251
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5582860 by daniel lamb in Dev-Anim branch]
2019-03-27 01:21:23 -04:00
pj kack
356d13a15d
Copying task stream Dev-cook to Main
...
Integrate all cook -iterate optimizations from //UE4/Dev-core/...
Test Scenario:
1) BuildCookStageAndRun with these arguments: -platform=Win64 -configuration=Development
2) CookIterate with these arguments: -run=Cook -CookCultures=en -TargetPlatform=WindowsClient -unversioned -stdout -unattended -iterate
Wall Time Results (as an average of running step 2) two times):
Before: ~09:40 (580 seconds) cook commandlet time
After: ~02:30 (150 seconds) cook commandlet time
=> 07:10 (430 seconds ) faster, i.e. a ~ 3.9x speedup
Win32 FileSystem Results:
Before: 1.5 million GetFileAttribute calls and 1.2 million FindNextFile calls
After: 35 0000 GetFileAttribute calls and 1.6 million FindNextFile calls
=> ~400 000 calls to FindNextFile replaces ~1.5 million calls to GetFileAttribute
#rb none
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: pj.kack
#ROBOMERGE-SOURCE: CL 5533504 via CL 5533655 via CL 5536177
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5544910 by pj kack in Dev-Anim branch]
2019-03-25 17:31:43 -04:00
marc audy
6da4e4cfba
Fix crash on shutdown depending on order of globals being destroyed
...
#jira
#rnx
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5494625 via CL 5494635 via CL 5494639 via CL 5497857 via CL 5497991
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5512109 by marc audy in Dev-Anim branch]
2019-03-22 17:38:27 -04:00
dan oconnor
fb1cdcf04f
Avoid resetting bExportLoadFailed when an object is destroyed, allows exports to stay invalidated after a GC call. Also we now invalidate exports for nodes replaced via ReplaceOldNodeWithNew
...
#rb Robert.Manuszewski
#jira UE-70904
#lockdown Cristina.Riveron
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: dan.oconnor
#ROBOMERGE-SOURCE: CL 5497598 in //UE4/Release-4.22/... via CL 5497599
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5512020 by dan oconnor in Dev-Anim branch]
2019-03-22 17:38:01 -04:00
robert manuszewski
78bf2cb7f4
Fixing crash when the engine tries to open content saved with a newer engine version
...
#jira UE-71880
#rb none
#lockdown cristina.riveron
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5496341 in //UE4/Release-4.22/... via CL 5496403
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5512004 by robert manuszewski in Dev-Anim branch]
2019-03-22 17:37:57 -04:00
marc audy
0ba5ad88f1
Rework sparse delegate storage to not use uobject annotation and manage its own map and lock state. This eliminates unnnecessary annotation cache overhead and ensures entire operation on map is completed while the lock is in place rather than copying per-object map out of the annotation and then moving modified inner per-object map back in to the annotation as two separately locked actions.
...
#rnx
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5483896 via CL 5483909 via CL 5483913 via CL 5487278 via CL 5487454
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5507513 by marc audy in Dev-Anim branch]
2019-03-22 17:12:17 -04:00
steve robb
6e246488a8
Fix for warnings about engine classes being hot reloaded when they haven't even changed.
...
#jira UE-71581
#rb none
[FYI] jamie.dale
#lockdown cristina.riveron
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 5459196 in //UE4/Release-4.22/... via CL 5459199
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5475456 by steve robb in Dev-Anim branch]
2019-03-20 13:21:48 -04:00
steve robb
0cd3824548
Fix to stop UClass CDOs trying to have their token streams reassembled on hot reload.
...
#rb robert.manuszewski
#jira UE-71566
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 5415461 in //UE4/Release-4.22/... via CL 5415463
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5418435 by steve robb in Dev-Anim branch]
2019-03-15 13:01:58 -04:00
bob tellez
c4f769d554
#UE4 Remove redundant call to DetachFromLinkers. It was causing a crash when using EDL
...
[FYI] Robert.Manuszewski
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 5407194 via CL 5407308 via CL 5407320
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5412155 by bob tellez in Dev-Anim branch]
2019-03-15 06:11:39 -04:00
robert manuszewski
3484106455
Restoring accidentally commented out code
...
#rb none
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5401325 via CL 5404234 via CL 5404237
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5411577 by robert manuszewski in Dev-Anim branch]
2019-03-15 05:58:41 -04:00
robert manuszewski
522018e5cd
Fixing a crash when detaching linkers from serialize context
...
#rb none
#jira UE-69177
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5402557
2019-03-15 05:55:19 -04:00
robert manuszewski
291d15cf4c
Fixing issues with objects not being serialized before they are being ConditionallyPostLoaded by other objects and LoadContext related crashes
...
#rb none
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5399372 via CL 5400965 via CL 5401943
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5410707 by robert manuszewski in Dev-Anim branch]
2019-03-15 05:40:52 -04:00
robert manuszewski
34fae63f6d
Fixing issues with objects not being serialized before they are being ConditionallyPostLoaded by other objects and LoadContext related crashes
...
#rb none
#jira UE-69177
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5401696 in //UE4/Release-4.22/... via CL 5401697
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5410704 by robert manuszewski in Dev-Anim branch]
2019-03-15 05:40:49 -04:00
bob tellez
3662798f89
#UE4 Disabling an assert as a workaround until Core team can investigate
...
[FYI] Rob.Manuszewski
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 5377088 via CL 5377214 via CL 5378944
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5382523 by bob tellez in Dev-Anim branch]
2019-03-13 10:24:13 -04:00
marc audy
c413a56e21
Fix sparse multicast delegates operating on the wrong object when binding, removing, or clearing on an object from another object's blueprint.
...
#jira
#rnx
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5370086 via CL 5370286 via CL 5373422 via CL 5377685
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5382170 by marc audy in Dev-Anim branch]
2019-03-13 10:13:09 -04:00
jamie dale
6e87ede71b
Fixed containers failing to gather required instance overrides
...
If a container element is overridden on an instance, then the entire container is serialized into the instance with different keys than the archetype. This means that all elements of a container need to be gathered if any elements within the container have changed.
#jira UE-71447
#rb Francis.Hurteau
#rnx
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 5371132 in //UE4/Release-4.22/... via CL 5371133
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5382007 by jamie dale in Dev-Anim branch]
2019-03-13 10:06:39 -04:00
arciel rekman
ea6a919665
Fix clang builds.
...
#rb none
[FYI] Robert.Manuszewski
#jira none
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: arciel.rekman
#ROBOMERGE-SOURCE: CL 5369429 in //UE4/Release-4.22/... via CL 5369431
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5381982 by arciel rekman in Dev-Anim branch]
2019-03-13 10:06:01 -04:00
robert manuszewski
e926662380
Allow the deterministic cook commandlet to open cooked content in the editor regardless of the 'cook.AllowCookedDataInEditorBuilds' ini setting
...
#rb none
#jira UE-71333
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5368203 in //UE4/Release-4.22/... via CL 5369004
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5381946 by robert manuszewski in Dev-Anim branch]
2019-03-13 10:04:37 -04:00
robert manuszewski
cd0ca564ae
Fixing a crash when the engine fails to open a package for comparison in the deterministic cooking commandlet
...
#rb none
#jira UE-71333
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5368036 in //UE4/Release-4.22/... via CL 5369001
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5381945 by robert manuszewski in Dev-Anim branch]
2019-03-13 10:04:35 -04:00
ben marsh
bb48e5fd04
Core: Fix pop-up dialogs when loading corrupt assets in unattended sessions, causing jobs to hang on build machines.
...
[FYI] Steve.Robb
#jira UE-71404
#rb none
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5365414 in //UE4/Release-4.22/... via CL 5368510
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5381928 by ben marsh in Dev-Anim branch]
2019-03-13 10:04:08 -04:00
sorin gradinaru
fca14ba901
UE-70402 Mobile projects crash with Event Driven Loader disabled
...
#jira UE-70402
#iOS
#Android
#4.22
#rb Jack.Porter
- when running the editor, changing the EDL flag is not reflected in the cooker (it will continue with the value read when the editor started)
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: sorin.gradinaru
#ROBOMERGE-SOURCE: CL 5348553 in //UE4/Release-4.22/... via CL 5364763
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5381644 by sorin gradinaru in Dev-Anim branch]
2019-03-13 09:51:58 -04:00
Thomas Sarkanen
bb193db1aa
Merging //UE4/Dev-Main to Dev-Anim (//UE4/Dev-Anim) @ CL 5356908
...
#rb none
[CL 5360337 by Thomas Sarkanen in Dev-Anim branch]
2019-03-11 12:18:32 -04:00
marc audy
12818f40be
Override GetCPPType in the multicast delegate TProperty specialization as the new hierarchy was using the TProperty version instead of the UMulticastDelegateProperty version.
...
This fixes nativization crash generating code for a multicast delegate.
#rb Phillip.Kavan
#rnx
#jira
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5313198 via CL 5313199 via CL 5315969 via CL 5316036
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5330321 by marc audy in Dev-Anim branch]
2019-03-06 18:38:29 -05:00
marc audy
adbce8a066
Provide a comment at the check that will occur if a sparse delegate is used on the stack so user has better understanding of why it is checking.
...
#rnx
#jira
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5313147 via CL 5313158 via CL 5315966 via CL 5316033
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5330316 by marc audy in Dev-Anim branch]
2019-03-06 18:38:27 -05:00
david harvey
0721e22a16
[LLM] adding some missing tags to clean up EngineMisc LLM category.
...
#rb anthony.bills
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: david.harvey
#ROBOMERGE-SOURCE: CL 5312123 via CL 5315400 via CL 5315473
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)
[CL 5329467 by david harvey in Dev-Anim branch]
2019-03-06 18:34:18 -05:00
