Commit Graph

709 Commits

Author SHA1 Message Date
dan oconnor
fd918f6084 Avoid unnecessary alloca call when not calling remote functions, remove unused parameter from UObject::GetFunctionCallspace
Upgrade notes: second parameter of GetFunctionCallspace overrides should be removed - it served no purpose
#rb Michael.Noland

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: dan.oconnor
#ROBOMERGE-SOURCE: CL 6635880 via CL 6639399 via CL 6639673
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6754029 by dan oconnor in Dev-Anim branch]
2019-05-31 18:30:57 -04:00
ben zeigler
783d29a698 Fix obj refs code by merging parts of CL 5365249 and 5536455 as 6542056 conflicted with a change in framework. This fixes an infinite recursion crash in obj refs and changes it so you don't need to pass the GC collector to AddReferencedObjects but doesn't include the deprecation changes or setting the debug name on streamablemanager
[CODEREVIEW] bob.tellez


#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.zeigler
#ROBOMERGE-SOURCE: CL 6578103 via CL 6581750 via CL 6581772
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v363-6677109)

[CL 6699980 by ben zeigler in Dev-Anim branch]
2019-05-31 12:50:48 -04:00
bob tellez
b06ca21b0b #UE4 Better FGCObject reporting in obj refs. FGCObject names are now reported in the "obj refs" console command, provided that they pass in FGCObject::GGCObjectReferencer as the referencer when calling AddReferencedObjects. FGCObjects may now also implement GetReferencerPropertyName to describe more details about how it references an object.
#ROBOMERGE-VERSION: 348-6547088
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 6542056 via CL 6542588 via CL 6542593
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 6568946 by bob tellez in Dev-Anim branch]
2019-05-18 11:12:37 -04:00
nick darnell
1b43fbbb03 Adding const variants of some of the more common AddReferencedObject(s) functions to allow for FGCObjects to store const pointers to UObjects or collections and report those references easily, otherwise people make the mistake of creating local ptrs that can't be nulled out correctly.
#rb Robert.Manuszewski
[FYI] Dan.Hertzka

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 5830834 via CL 5830835 via CL 5835213 via CL 5835996
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5875741 by nick darnell in Dev-Anim branch]
2019-04-12 21:09:15 -04:00
bob tellez
bd38d54667 #UE4 Improve logging when assets fail to load. Failing to get the package linker will now produce fewer redundant log messages and all failure messages will include the asset that failed to load as well as the asset that was requesting the linker where possible.
#rb Robert.Manuszewski

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 5713888 via CL 5714486 via CL 5714487
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5721617 by bob tellez in Dev-Anim branch]
2019-04-03 21:43:47 -04:00
marc audy
0ba5ad88f1 Rework sparse delegate storage to not use uobject annotation and manage its own map and lock state. This eliminates unnnecessary annotation cache overhead and ensures entire operation on map is completed while the lock is in place rather than copying per-object map out of the annotation and then moving modified inner per-object map back in to the annotation as two separately locked actions.
#rnx

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5483896 via CL 5483909 via CL 5483913 via CL 5487278 via CL 5487454
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5507513 by marc audy in Dev-Anim branch]
2019-03-22 17:12:17 -04:00
steve robb
6e246488a8 Fix for warnings about engine classes being hot reloaded when they haven't even changed.
#jira UE-71581
#rb none
[FYI] jamie.dale
#lockdown cristina.riveron

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 5459196 in //UE4/Release-4.22/... via CL 5459199
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5475456 by steve robb in Dev-Anim branch]
2019-03-20 13:21:48 -04:00
robert manuszewski
34fae63f6d Fixing issues with objects not being serialized before they are being ConditionallyPostLoaded by other objects and LoadContext related crashes
#rb none
#jira UE-69177

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5401696 in //UE4/Release-4.22/... via CL 5401697
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5410704 by robert manuszewski in Dev-Anim branch]
2019-03-15 05:40:49 -04:00
marc audy
c413a56e21 Fix sparse multicast delegates operating on the wrong object when binding, removing, or clearing on an object from another object's blueprint.
#jira
#rnx

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5370086 via CL 5370286 via CL 5373422 via CL 5377685
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5382170 by marc audy in Dev-Anim branch]
2019-03-13 10:13:09 -04:00
Thomas Sarkanen
bb193db1aa Merging //UE4/Dev-Main to Dev-Anim (//UE4/Dev-Anim) @ CL 5356908
#rb none

[CL 5360337 by Thomas Sarkanen in Dev-Anim branch]
2019-03-11 12:18:32 -04:00
marc audy
12818f40be Override GetCPPType in the multicast delegate TProperty specialization as the new hierarchy was using the TProperty version instead of the UMulticastDelegateProperty version.
This fixes nativization crash generating code for a multicast delegate.
#rb Phillip.Kavan
#rnx
#jira

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5313198 via CL 5313199 via CL 5315969 via CL 5316036
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5330321 by marc audy in Dev-Anim branch]
2019-03-06 18:38:29 -05:00
marc audy
adbce8a066 Provide a comment at the check that will occur if a sparse delegate is used on the stack so user has better understanding of why it is checking.
#rnx
#jira

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5313147 via CL 5313158 via CL 5315966 via CL 5316033
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5330316 by marc audy in Dev-Anim branch]
2019-03-06 18:38:27 -05:00
marc audy
d5232114b6 Dynamic Multicast delegates can now specify that their storage be stored in a sparse allocation for delegates that are expected to be bound rarely. The memory usage of an unbound sparse delegate is 1 byte instead of 16 bytes (for the empty array), however, a bound sparse delegate will have access overhead to retrieve the invocation list from the sparse object annotation.
The definition of the delegate type must specify the class and property name of the delegate that will use it and the type cannot be used outside of that context or just on the stack.
UMulticastDelegateProperty is now abstract and has 2 subclasses (UMulticastDelegateInlineProperty and UMulticastDelegateSparseProperty). The SparseProperty SignatureFunction will be a USparseDelegateFunction.
The sparse delegates do not work correctly with the python bindings at this point, but this will be visited soon.
#rb Michael.Noland
#jira

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5295832 via CL 5306530 via CL 5306657
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5322213 by marc audy in Dev-Anim branch]
2019-03-06 18:02:30 -05:00
Helge Mathee
157f5167e4 Documentating "DocumentationPolicy" meta tag for inside ObjectMacros.h
#rb lina.halper

[CL 5312098 by Helge Mathee in Dev-Anim branch]
2019-03-06 08:29:36 -05:00
Thomas Sarkanen
474bc576ee Merging //UE4/Dev-Main to Dev-Anim (//UE4/Dev-Anim) @ CL 5236305
#rb none
#jira none

[CL 5236785 by Thomas Sarkanen in Dev-Anim branch]
2019-02-28 04:41:36 -05:00
jamie dale
444c93c75c Editor Utilities now respond to editor requests to cleanse object instances by clearing their references to any objects pending purge
This fixes crashes where they would take references to things like an actor within a world, and then the active editor world was changed (which verifies against GC reference leaks).

#jira UE-69150
[FYI] Michael.Noland
#rb Lauren.Ridge

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 4987801 in //UE4/Release-4.22/... via CL 4987804
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5043990 by jamie dale in Dev-Anim branch]
2019-02-18 14:21:31 -05:00
robert manuszewski
f135298d0b Fixing CIS
#rb none

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 4981798 via CL 4981801 via CL 4982121 via CL 4984555
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5043880 by robert manuszewski in Dev-Anim branch]
2019-02-18 14:20:25 -05:00
robert manuszewski
94a526423e Reduced Linker annotations memory usage by introducing new annotation array type that can reclaim memory from object ranges that no longer require the annotation
#rb none

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 4981648 via CL 4981653 via CL 4982090 via CL 4984532
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5043868 by robert manuszewski in Dev-Anim branch]
2019-02-18 14:20:09 -05:00
louisphilippe seguin
dde69c9505 Added an Error log when DOREPLIFETIME is not called on a replicated property inside GetLifetimeReplicatedProps
If you intentionally don't want to replicate this property, use the DISABLE_REPLICATED_PROPERTY to silence the Error (see cl 4962290 for the macros)

#rb ryan.gerleve
#jira UE-2686

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: louisphilippe.seguin
#ROBOMERGE-SOURCE: CL 4963253 via CL 4964116 via CL 4969310
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5027924 by louisphilippe seguin in Dev-Anim branch]
2019-02-16 04:08:59 -05:00
louisphilippe seguin
b8c78dab0b Added DISABLE_REPLICATED_PROPERTY macro to explicitely disable the replication of a networked property in GetLifetimeReplicatedProps.
This is needed since we will start warning when we detect replicated properties not registered in GetLifetimeReplicatedProps

Added DISABLE_ALL_CLASS_REPLICATED_PROPERTIES macro to disable the replication of ALL replicated properties of a given class

Added RESET_REPLIFETIME macro that allows you to reenable a networked property that was Disabled in a base class.


#rb ryan.gerleve, peter.engstorm, jon.nabozny
#jira UE-2686

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: louisphilippe.seguin
#ROBOMERGE-SOURCE: CL 4962290 via CL 4963576 via CL 4965559
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5027271 by louisphilippe seguin in Dev-Anim branch]
2019-02-16 03:58:55 -05:00
simon therriault
e05a2751b0 FFilePath: Adding metadata to support relative path to project directory
#rb chris.gagnon
#jira UE-69621

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: simon.therriault
#ROBOMERGE-SOURCE: CL 4948231 in //UE4/Release-4.22/... via CL 4948232
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5023401 by simon therriault in Dev-Anim branch]
2019-02-16 02:52:09 -05:00
robert manuszewski
6dd5da9614 Fixed cases where some objects would not get PostLoaded when playing standalone game or running uncooked server
#jira UE-69177
#rb none

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 4930034 in //UE4/Release-4.22/... via CL 4930037
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5019545 by robert manuszewski in Dev-Anim branch]
2019-02-16 01:57:26 -05:00
ben zeigler
0846459989 #jira UE-69547 Header/comment cleanup for UObjectGlobals, several comments were factually incorrect
Removed duplicate comments from cpp per coding standard
[CODEREVIEW] robert.manuszewski
#rb None

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.zeigler
#ROBOMERGE-SOURCE: CL 4915839 in //UE4/Release-4.22/... via CL 4915853
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5016625 by ben zeigler in Dev-Anim branch]
2019-02-16 01:13:29 -05:00
ben zeigler
dc8db2cdff #jira UE-69547 Header/comment cleanup for UObject, UObjectBase, UObjectBaseUtility, ObjectMacros, and NoExportTypes
There should be no functionality changes
#rb steve.robb

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.zeigler
#ROBOMERGE-SOURCE: CL 4915771 in //UE4/Release-4.22/... via CL 4915833
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5016623 by ben zeigler in Dev-Anim branch]
2019-02-16 01:13:27 -05:00
Lina Halper
f7baa58bc9 Merging //UE4/Dev-Main to Dev-Anim (//UE4/Dev-Anim)
#fyi: Laurent.Delayen, James.Hopkin
#rb: none

[CL 4923303 by Lina Halper in Dev-Anim branch]
2019-02-06 14:35:56 -05:00