Commit Graph

34305 Commits

Author SHA1 Message Date
andrew rodham
09ae5e945e Disable copying of FConstPawnIterator to prevent the possibility of a double deletion
- This vulnerability is largely unseen due to the prevalence of RVO and copy-elision, but some code (specifically TConstPawnArray) was resulting in a copy of the iterator, and subsequent double deletion of the actor iterator as a result.
  - Ideally FConstPawnIterator would not rely on heap allocated pointers so heavily, but I think the safest fix of least risk is to define move operators, and delete its copy constructors.
  - UE-75216 itself regressed in 6548275

#jira UE-75216
#rb Marc.Audy, Steve.Robb

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: andrew.rodham
#ROBOMERGE-SOURCE: CL 6783798 via CL 6788219 via CL 6799002
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6821332 by andrew rodham in Dev-Anim branch]
2019-06-03 19:11:52 -04:00
andrew rodham
dc4ec3c24c Changed take and sequence recorders to use the correct property name rather than the property's display text for its property lookup
#jira UE-75334
#rb Mike.Zyracki

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: andrew.rodham
#ROBOMERGE-SOURCE: CL 6783005 via CL 6785800 via CL 6798995
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6821328 by andrew rodham in Dev-Anim branch]
2019-06-03 19:11:33 -04:00
andrew grant
2a34cf287c Moved ExportIPA script from project-k to common engine code.
Fixed issue wher eif dependencies caused a platform implementation to be processed twice it'd warn even if they were identical

(Needed for next Fortnite-specific CL).

[at]josh.adams
#rb na

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 6763211 via CL 6763215 via CL 6763217 via CL 6763219 via CL 6763240 via CL 6763246
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6820758 by andrew grant in Dev-Anim branch]
2019-06-03 19:00:32 -04:00
Jurre deBaare
6c25554a05 AltSkinWeights - Crash - Reimporting Base Mesh while previewing Skin Weight Profile causes editor to crash
#fix Clear and reset profile when reimporting skeletal mesh
#jira UE-74041
#rb Alexis.Matte

[CL 6800649 by Jurre deBaare in Dev-Anim branch]
2019-06-03 11:04:25 -04:00
Jurre deBaare
83a5b7b45c Add a reset to defaults button to Merge Actors window
#fix Ensure we do not use the CDO as the object we inspect in the tool detailsview, rather duplicate the CDO so per-property checks with the default actually works
#misc Clean up objects whenever the MergeActor module shuts down
#jira UE-70728
#rb Martin.Wilson

[CL 6800064 by Jurre deBaare in Dev-Anim branch]
2019-06-03 10:43:50 -04:00
Jurre deBaare
593cbf10b3 Add Curve via Anim Modifiers not working
#fix Make sure we call MarkRawDataAsModified, to ensure the curve data is updated
#jira UE-62114
#rb Martin.Wilson

[CL 6798773 by Jurre deBaare in Dev-Anim branch]
2019-06-03 09:54:17 -04:00
rob gay
569ff29407 Add back nuked branch.
#rb none

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 6762883 in //UE4/Main/...
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6797355 by rob gay in Dev-Anim branch]
2019-06-03 09:21:52 -04:00
rob gay
13df2ef94b Fix build from merge conflict. Required exposing WaveInstance getter on ActiveSound (internal member hiding conflicted with newly refactored code for Audio Debugger)
#rb none
[FYI] Kevin.Neilson
[FYI] Aaron.Mcleran
[FYI] Ethan.Geller

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 6762865 in //UE4/Main/...
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6797348 by rob gay in Dev-Anim branch]
2019-06-03 09:21:48 -04:00
Jurre deBaare
7666457294 #jira
UE-69860
No progress bar is shown when building HLOD clusters from the outliner

[CL 6796894 by Jurre deBaare in Dev-Anim branch]
2019-06-03 09:16:01 -04:00
rob gay
bb65455273 Fix bad merge
#rb none

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 6761715 in //UE4/Main/...
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6796834 by rob gay in Dev-Anim branch]
2019-06-03 09:14:58 -04:00
rob gay
856eacc21b - Fix late-triggering issue with oneshots that don't start immediately due to gain stages summing to zero volume on WaveInstance construction/initialization
- Clean-up/clarify WaveInstance lifetime by immediately removing null tpair entries that stick around during stopping phase of ActiveSounds
- Clean-up/clarify requirement of a WaveInstance subscribing to ActiveSound's WaveInstance map on construction
#rb ethan.geller
[FYI] aaron.mcleran

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 6757952 via CL 6761146 via CL 6761676
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6796599 by rob gay in Dev-Anim branch]
2019-06-03 09:12:11 -04:00
rob gay
64f4687b23 - Move PlayWhenSilent to virtualization mode enum
- Add ability to disable virtualization as a user on a sound (defaults to 'restart' which restarts a sound if its a loop)
- General USoundBase Display clean-up
- Clean-up/Delete unused booleans on USoundCue
#rb ethan.geller

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 6759785 in //UE4/Main/...
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6796327 by rob gay in Dev-Anim branch]
2019-06-03 09:09:07 -04:00
ben marsh
a4564e6593 Fix problems creating a new plugin in a project with a unique build environment.
#jira UE-75202
#rb none

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 6759642 in //UE4/Main/...
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6796322 by ben marsh in Dev-Anim branch]
2019-06-03 09:08:50 -04:00
david hamm
c3fe784e64 Rework log statements for easier searching
#rb kyle.langley
[FYI] derek.ehrman
#rnx

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: david.hamm
#ROBOMERGE-SOURCE: CL 6744735 via CL 6758100 via CL 6758333
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6796061 by david hamm in Dev-Anim branch]
2019-06-03 09:05:20 -04:00
michael kirzinger
9032d5c1c3 [iOS] Add method to query if we have the recording permission
[REVIEW] [at]josh.adams

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: michael.kirzinger
#ROBOMERGE-SOURCE: CL 6724734 via CL 6724792 via CL 6740114 via CL 6740134 via CL 6757061 via CL 6757305
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6795930 by michael kirzinger in Dev-Anim branch]
2019-06-03 09:00:05 -04:00
ben salem
965aa6c605 Add the ability to declare additional artifact directories to copy over in addition to /saved/
#rb clayton.langford

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.salem
#ROBOMERGE-SOURCE: CL 6739909 via CL 6739922 via CL 6757015 via CL 6757271
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6795913 by ben salem in Dev-Anim branch]
2019-06-03 08:59:37 -04:00
nick darnell
937d66506d Fixing the compile issue in the generated class to reference a defined variable for the class to use that the widget was generated as part of.
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 6724641 via CL 6724704 via CL 6755124 via CL 6755474
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6795651 by nick darnell in Dev-Anim branch]
2019-06-03 08:51:16 -04:00
nick darnell
8600ae6be7 Fixing non-unity compile of the Contrast option.
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 6722631 via CL 6722755 via CL 6755080 via CL 6755418
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6795632 by nick darnell in Dev-Anim branch]
2019-06-03 08:50:38 -04:00
bob tellez
995bf24af8 #Fortnite Temporary CIS fix
[FYI] Nick.Darnell

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 6690723 via CL 6690729 via CL 6753364 via CL 6753808
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6795392 by bob tellez in Dev-Anim branch]
2019-06-03 08:43:15 -04:00
michael dupuis
08761e4ded Fixed importing a heightmap in non layer mode, as we would lock the heightmaps, but due to order of execution we would never unlock before trying to lock again in another mode.
#rb richard.malo

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: michael.dupuis
#ROBOMERGE-SOURCE: CL 6688708 via CL 6753319 via CL 6753780
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6795380 by michael dupuis in Dev-Anim branch]
2019-06-03 08:42:58 -04:00
sebastien lussier
97a1e22978 #rb none
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: sebastien.lussier
#ROBOMERGE-SOURCE: CL 6688128 via CL 6753309 via CL 6753776
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6795376 by sebastien lussier in Dev-Anim branch]
2019-06-03 08:42:55 -04:00
helge mathee
6014eee653 #jira UE-75162
ControlRig: Support for comment blocks
Comments were not part of the MVC layer - this change is adding them back in.

#rb none

Merging

//Tasks/Fortnite/Dev-UEA-ControlRig/...

to //Fortnite/Main/Dev-UEA-ControlRig/...

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 6685421 via CL 6752148 via CL 6752571
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6795234 by helge mathee in Dev-Anim branch]
2019-06-03 08:37:46 -04:00
nick darnell
df364839ac Slate - Introducing a way to control the contrast of the UI when rendering, to help developers comply with CVAA, and general accessibility concerns it's valuable to be able to allow users to adjust the contrast of a game's UI, so any element affected by Gamma Correction, will also be affected by any contrast. This setting does not enhance the contrast of the scene.
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 6685381 via CL 6685386 via CL 6752118 via CL 6752511
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6795223 by nick darnell in Dev-Anim branch]
2019-06-03 08:37:20 -04:00
nick darnell
285fca4942 Slate - Adding additional navigation information when we do perform navigation we report what system is performing the navigate, was it direct, a boundry condition, did it use the hittest grid...etc.
Slate - Also found a bug where we're not using the world switcher before calling the handler for some navigation options.


#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 6685364 via CL 6685366 via CL 6752052 via CL 6752454
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6795206 by nick darnell in Dev-Anim branch]
2019-06-03 08:36:57 -04:00
jack porter
63140a3343 Add a 1ms sleep to a busy wait on iOS when we can't get a backbuffer. Solves overheating on iPhone X and other 30 fps devices.
#rb Dmitriy.Dyomin

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: jack.porter
#ROBOMERGE-SOURCE: CL 6685313 via CL 6685314 via CL 6685315 via CL 6685316 via CL 6751307 via CL 6751841
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v365-6733468)

[CL 6795187 by jack porter in Dev-Anim branch]
2019-06-03 08:36:33 -04:00