Commit Graph

13 Commits

Author SHA1 Message Date
matt peters
04cbe6e180 ObjectPropertyTest fixes:
1) Fix for test package names not starting with proper prefix
2) Fix incompatible value that is passed into CheckValidObject to NOT be the outer of the fallback objecte. The incompatible value now gets renamed by CheckValidObject, and renaming the outer of the fallback object would break the test.
#rnx
#rb Joe.Pribele

[CL 26500255 by matt peters in 5.3 branch]
2023-07-20 18:51:09 -04:00
joe pribele
627db198b3 change to FObjectPtrProperty::Identical to avoid loading lazy loaded objects
https://p4-swarm.epicgames.net/reviews/25288349
#rb zousar.shaker
#preflight 64598eb5023fe5d3ad6df74d

[CL 25381637 by joe pribele in ue5-main branch]
2023-05-08 20:13:30 -04:00
kirill zorin
a58d329c4d Update TObjectPtr unit tests to assert against specific pointers (instead of all pointers) due to upcoming ARO changes.
#rb joe.pribele
#preflight 644ae1066638b912841d8bc1

[CL 25223794 by kirill zorin in ue5-main branch]
2023-04-27 17:20:13 -04:00
robert manuszewski
1e90746cb9 Redo 24852317:
Making sure non-nullable object properties have a default object value assigned to them in case of serialization errors
+ Adding backwards compatibility support to optional properties

#preflight 643015e17536ac6b78a4466e
#rb Maxime.Mercier, Steve.Robb

[CL 25021794 by robert manuszewski in ue5-main branch]
2023-04-13 03:41:03 -04:00
maxime mercier
70455f6f92 [Backout] - CL24868633
[FYI] Robert.Manuszewski
Original CL Desc
-----------------------------------------------------------------
Redo 24852317:

Making sure non-nullable object properties have a default object value assigned to them in case of serialization errors

#preflight 642549ebe11ce5214ff0a196
#rb Steve.Robb

[CL 24938058 by maxime mercier in ue5-main branch]
2023-04-05 17:59:13 -04:00
robert manuszewski
0730f2484b Redo 24852317:
Making sure non-nullable object properties have a default object value assigned to them in case of serialization errors

#preflight 642549ebe11ce5214ff0a196
#rb Steve.Robb

[CL 24869143 by robert manuszewski in ue5-main branch]
2023-03-31 06:43:52 -04:00
joe pribele
4fe33224d4 fix for failing tests on console
#preflight 640a442270639dfc946b595c

[CL 24581784 by joe pribele in ue5-main branch]
2023-03-09 15:57:35 -05:00
joe pribele
a7673567fe change to FObjectPropertyBase ParseObjectPropertyValue and FindImportedObject to take in a TObjectPtr<UObject> instead of UObject
added `SetObjectPtrPropertyValue(void* PropertyValueAddress, TObjectPtr<UObject> Value)`

this allows objects to be imported from text without resolving the object
#preflight 640900fa8832f48a4dc62ee4

[CL 24567650 by joe pribele in ue5-main branch]
2023-03-08 16:56:59 -05:00
joe pribele
db7a692cc7 second attempt to fix for performance problem when converting arrays of TObjectPtr to UObject*
changed the access tracking to a bulk operation api to allow for single calls instead of O(n) calls
#preflight 63fe5fc7ac6c61e2b553e9a9

[CL 24449378 by joe pribele in ue5-main branch]
2023-02-28 15:26:26 -05:00
joe pribele
6d1d492c29 [Backout] - CL24432584
#fyi joe.pribele
Original CL Desc
-----------------------------------------------------------------
fix for performance problem when converting arrays of TObjectPtr to UObject*
changed the access tracking to a bulk operation api to allow for single calls instead of O(n) calls
#preflight 63fd1de9f43e53f6811a37af

[CL 24436160 by joe pribele in ue5-main branch]
2023-02-27 19:54:50 -05:00
joe pribele
bcc680cfa3 fix for performance problem when converting arrays of TObjectPtr to UObject*
changed the access tracking to a bulk operation api to allow for single calls instead of O(n) calls
#preflight 63fd1de9f43e53f6811a37af

[CL 24432584 by joe pribele in ue5-main branch]
2023-02-27 16:37:45 -05:00
joe pribele
6c2bc21bac changed FObjectProperty::SerializeItem to not cause object handle reads
#preflight 63d837e91f0aa8a2897477ee

[CL 23916733 by joe pribele in ue5-main branch]
2023-01-30 16:52:28 -05:00
joe pribele
39de1fde02 changed FObjectPropertyBase::CheckValidObject to not resolve FObjectPtr fields to do validation
this is needed for feature work with validation of accessing asset pointers during serialization

https://p4-swarm.epicgames.net/reviews/23782822

#rb zousar.shaker
#fyi francis.hurteau
#preflight 63cf06efd83c1837b14e2aeb

[CL 23823212 by joe pribele in ue5-main branch]
2023-01-23 17:33:10 -05:00