Commit Graph

5227 Commits

Author SHA1 Message Date
andrew scheidecker
575bbaf801 Fix for unversioned serialization of arrays of optionals (or other cases where an optional property might be nested in a container).
Also fix a memory leak when doing unversioned serialization of properties with destructors and default values: "loading as zero" doesn't call the destructor on the value being overwritten, and so isn't safe to use for properties that require destruction.
#rb Devin.Doucette, Robert.Manuszewski

[CL 26706194 by andrew scheidecker in 5.3 branch]
2023-07-31 10:47:04 -04:00
dan oconnor
4e978a9711 Revert behavior introduced in 12669682, but avoid discarding InstancedSubobjects that have been loaded by FLinkerLoad, this ensures that objects with deferred intitializers have their instanced references fixed up by FObjectInitializer::InstanceSubobjects
#rb Phillip.Kavan
#jira UE-189361

[CL 26647270 by dan oconnor in 5.3 branch]
2023-07-27 13:57:00 -04:00
andrew scheidecker
81a1fe0a01 Cherry pick various changelists adding FOptionalProperty to CoreUObject.
#ushell-cherrypick of 26132976 by andrew.scheidecker
#ushell-cherrypick of 26180430 by andrew.scheidecker
#ushell-cherrypick of 26180927 by andrew.scheidecker
#ushell-cherrypick of 26184877 by andrew.scheidecker
#ushell-cherrypick of 26281078 by Johan.Torp
#ushell-cherrypick of 26346541 by andrew.scheidecker

[CL 26605123 by andrew scheidecker in 5.3 branch]
2023-07-26 09:52:42 -04:00
Francis Hurteau
a65b82ea75 Truncation warning fixes for CoreUObject
#jira UE-166274, UE-127233
#rb Devin.Doucette, Paul.Chipchase

[CL 26553302 by Francis Hurteau in 5.3 branch]
2023-07-24 15:56:25 -04:00
dan oconnor
20bec88a70 Publish soft path literals to reference collectors that run over bytecode
#jira UE-190820
#rb Matt.Peters

[CL 26518828 by dan oconnor in 5.3 branch]
2023-07-21 13:52:32 -04:00
nick edwards
0f6539f105 Added an additional FAssetRegistryTag constructor that leverages move semantics to efficiently transfer the value string into the member variable, potentially eliminating an extra copy operation
#rb matt.peters

[CL 26512923 by nick edwards in 5.3 branch]
2023-07-21 11:16:35 -04:00
matt peters
04cbe6e180 ObjectPropertyTest fixes:
1) Fix for test package names not starting with proper prefix
2) Fix incompatible value that is passed into CheckValidObject to NOT be the outer of the fallback objecte. The incompatible value now gets renamed by CheckValidObject, and renaming the outer of the fallback object would break the test.
#rnx
#rb Joe.Pribele

[CL 26500255 by matt peters in 5.3 branch]
2023-07-20 18:51:09 -04:00
wouter burgers
819bfd6807 PackageReload: Optimized ReloadPackages by doing a pre-pass using FReferencerFinder::GetAllReferencers to get all potential referencers and only inspecting those when fixing up references. The potential referencers set is expanded as new packages get (re)loaded through the FCoreUObjectDelegates::OnObjectsReplaced and FCoreUObjectDelegates::OnObjectConstructed delegates, whilst garbage collected packages end up being skipped through the use of TWeakObjectPtrs.
#rnx

[CL 26481227 by wouter burgers in 5.3 branch]
2023-07-20 07:21:59 -04:00
jason weiler
184c5b7467 Fix for type-mismatched leading to a fatal error when compiling, cooking, and loading level data. Now resets non-nullable properties to an instandce of the CDO.
#rb robert.manuszewski, maxime.mercier

[CL 26465198 by jason weiler in 5.3 branch]
2023-07-19 13:33:31 -04:00
francis hurteau
ff155fc3c5 Temporarily disable validation ensure in ResetLoaders until fixed with zenloader usage
#rb trivial
[FYI] Andrew.Phillips, Danny.Couture

[CL 26408401 by francis hurteau in 5.3 branch]
2023-07-17 11:25:39 -04:00
matt peters
99a470b696 Cooker: DiffWriterArchive: Fix a bug after refactor with FArchiveStackTraceIgnoreScope no longer being respected. Change DiffWriterArchive to report all messages to a message callback rather than logging them directly. Future users of DiffWriterArchive will store the messages rather than logging them.
#rb Zousar.Shaker
#rnx

[CL 26324633 by matt peters in 5.3 branch]
2023-06-29 15:39:12 -04:00
jamie dale
02b747b262 Added a category type that can be used with FMessageDialog to control the icon used by the in-editor dialog
Note: This doesn't impact any OS specific dialogs

Breaking: FCoreDelegates::ModalErrorMessage is now called FCoreDelegates::ModalMessageDialog and takes an extra EAppMsgCategory argument

#jira
#rb Dave.Belanger

[CL 26322797 by jamie dale in 5.3 branch]
2023-06-29 14:55:10 -04:00
dan oconnor
289ca8dee9 Mirror 26199461
Use the PostConstructLinkNext pointer to initialize properties that aren't CPF_ZeroConstructor, rather than just starting at FirstPropertyToInit and initializing every remaining property (often redundantly)
Relevant CLs: 86560, 1444860, 1447974
#rb Phillip.Kavan

[CL 26274564 by dan oconnor in 5.3 branch]
2023-06-27 19:02:40 -04:00
ben zeigler
b6c1009c59 Improve comments on LazyObjectPtr to make the limitations clear and warn about future deprecation in favor of SoftObjectPtr
#rb jonathan.bard
#jira UE-100304

[CL 26269249 by ben zeigler in 5.3 branch]
2023-06-27 16:22:22 -04:00
matt peters
0977b18100 FArchiveStackTrace: Deprecate the public interface and move it into a private helper class of DiffPackageWriter.
#rb Zousar.Shaker
#rnx

[CL 26268983 by matt peters in 5.3 branch]
2023-06-27 16:11:26 -04:00
robert millar
d747f70387 Disable PIE soft object path fixup tests outside of editor.
#rb none

[CL 26261899 by robert millar in 5.3 branch]
2023-06-27 12:54:28 -04:00
andrew phillips
b8dee74917 Adding CVar to control the Archetype cache usage
[CL 26254444 by andrew phillips in 5.3 branch]
2023-06-27 07:35:57 -04:00
rob perren
fd7a0e8786 Fix zenloader state progression when mixing cooked and uncooked assets
#rnx
#rb PJ.Kack

#ushell-cherrypick of 26178601 by danny.couture to fix issues seen in "Test Content Worker Docker Image Win64"

[CL 26234854 by rob perren in 5.3 branch]
2023-06-26 11:29:03 -04:00
matt peters
5baf660781 Cooker OnlyEditorOnly: ExternalActors: Mark ExternalActors as not explorable explorable until they are loaded by the map package. The map package may skip the loading of some of them. Thsi will prevent us exploring and marking for cook all of the dependencies of a GameFeature used by a disabled Actor using that GameFeature. Modify the graph traversal so that we can mark the Actor as explorable later at the point where it loads.
#rb Zousar.Shaker
#rnx

[CL 26201140 by matt peters in 5.3 branch]
2023-06-22 20:26:45 -04:00
Jerome Delattre
7a66dda9e2 Adjust Log verbosity settings for UObject Class tests so test automation framework caught errors.
#rnx
#rb trivial

[CL 26196774 by Jerome Delattre in 5.3 branch]
2023-06-22 18:21:47 -04:00
Jerome Delattre
fa5b4c8898 Force warning as error in UObject class analysis tests
#rnx
#rb trivial

[CL 26180908 by Jerome Delattre in 5.3 branch]
2023-06-22 09:48:19 -04:00
danny couture
3118d8a25c Fix assert in zenloader steps now that we have multiple paths where states can come from
#rnx
#rb Francis.Hurteau

[CL 26129555 by danny couture in 5.3 branch]
2023-06-20 14:32:41 -04:00
robert millar
7e799d29c3 Propagate set of request ids for FlushAsyncLoading into inner loops.
#rb francis.hurteau,danny.couture,pj.kack

[CL 26106853 by robert millar in 5.3 branch]
2023-06-19 17:48:33 -04:00
ben zeigler
91cca48849 CoreUObject deprecation cleanup pass to remove functions and classes deprecated before 5.0
This change does not remove things like PackageGuid that are still used in some cases
#rb matt.peters

[CL 26096387 by ben zeigler in 5.3 branch]
2023-06-19 13:39:27 -04:00
andrew scheidecker
461248e710 Fix VC static analyzer "dereferencing NULL pointer" warning.
#rb Matt.Peters

[CL 26089130 by andrew scheidecker in 5.3 branch]
2023-06-19 09:49:13 -04:00