Commit Graph

400 Commits

Author SHA1 Message Date
benoit gadreau
7c004866a5 New TRS Gizmo updates
- arcball rotation: the rotation is computed using a spherical+hyperbolic projection (see code for more explanation)
    - indirect manipulation via MMB: hit parts are stored per mode then are used to drive the proper drag function
    - defered drag function: in order to avoid notifications storm, the drag functions can be applied on tick instead using a pending function
    - a single default TRS gizmo is now created when needed (instead of creating several thru selection changed or when the gizmo manager was ticking) and its visibility is set based on rules

TODO
    - UEditorInteractiveGizmoManager is now closer to UInteractiveGizmoManager so I don't think we need ActiveEditorGizmos, CachedGizmoMap, etc. that are not used anymore. This should be cleaned in another CL
    - UEditorTransformGizmo::OnGizmoTransformBegin should set the current axis (needed for some modes, including IKRig) but this is disabled for now has there are some side effects with dragging (this will be treated in another CL)


#jira UE-152973
#jira UE-161236
#rb brooke.hubert zach.rammell

[CL 27751789 by benoit gadreau in ue5-main branch]
2023-09-11 09:54:48 -04:00
aditya ravichandran
dac7ba088b TEDS-Outliner Integration: Add initial support for populating the Outliner using TEDS queries.
#jira UE-187140
#rb ronald.koppers, zach.rammell

[CL 27180769 by aditya ravichandran in ue5-main branch]
2023-08-17 14:48:51 -04:00
logan buchy
87012153c4 Remove TypedElementViewportInteractionGizmoManipulation from TypedElement ViewportInteraction
* The same functionality is provided by the GizmoManipulationStarted and GizmoManipulationStopped.
* This simplifies the interface and removes the bespoke parameter added to branch between when manipulation starts and when it is ongoing to avoid expensive rendering invalidations
* There are some clients of TypedElementViewportInteractionGizmoManipulation::ApplyDeltaToActor, this CL does not address usage of this function.  Doing so will require further adoption of TypedElements among those systems

#jira UE-187188
#rb Brooke.Hubert

[CL 25964466 by logan buchy in ue5-main branch]
2023-06-13 17:28:30 -04:00
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
jason hoerner
2a816e5ad4 Further optimization for moving actor with many static mesh components. Only invalidate the static lighting cache at the start of a move operation. We don't invalidate the cache in "GizmoManipulationStarted", because the user can click on a handle (calling the start function) without actually moving, which should have no effect. So a flag is used to detect the first time "GizmoManipulationDeltaUpdate" is called, and subsequent calls can skip repeatedly invalidating the lighting cache.
With this fix, on my machine, the cost of moving a blueprint with 1000 items drops from 45 ms to 7 ms.  Baseline tick is 8 ms (120 fps) when idling, so the results while moving improve from 19 fps to 65 fps.  The remaining time is mostly split between physics and navigation update.  Invalidating the static lighting cache is so costly because it both invalidates the render state of every item, and notifies packages of the change.

#jira UE-147154
#rnx
#rb jamie.dale
#preflight 63ff4748e32cdb7d9aacab16

[CL 25050136 by jason hoerner in ue5-main branch]
2023-04-14 17:02:21 -04:00
zach rammell
9d13ddaedc Allow asset factories to be registered at runtime
Also expand usage of placement system to ensure these factories are used in more places

#rb brooke.hubert
#preflight 642cad951d19c0312aec3e7a

[CL 24938100 by zach rammell in ue5-main branch]
2023-04-05 18:00:20 -04:00
ben hoffman
bb84fa8791 Forward input axis events to the Editor World extension collection and give extensions an opportunity to consume input.
#jira UE-178279
#rb me
#preflight 6414c4ebca2afe3ee6b1adb1

[CL 24872034 by ben hoffman in ue5-main branch]
2023-03-31 11:28:53 -04:00
kevin ortegren
b02be63173 Drag&Drop a cubemap onto a mesh in the editor now generates a compiling material
#preflight 64231af7973e6096701a590e
[REVIEW] [at]massimo.tristano

[CL 24832835 by kevin ortegren in ue5-main branch]
2023-03-29 04:40:27 -04:00
dan parkes
df08722387 [UEFN] Improve Audio Player device viewport focus functionality
#rb max.hayes stu.mckenna michael.galetzka
#preflight 64109b84924023147d3f59e5

[CL 24643691 by dan parkes in ue5-main branch]
2023-03-14 16:39:55 -04:00
zach bethel
5ad5368df1 Removing unused 'ViewParent' feature and other dead code.
#rb krzysztof.narkowicz
#preflight 640a3f3e482188d710bc19a2

[CL 24581280 by zach bethel in ue5-main branch]
2023-03-09 15:33:59 -05:00
brooke hubert
ee6dce9a30 Fix a couple of issues where packages were aggressively dirtied
- Call cancel on the transaction if it is actually a camera movement input
 - Reset package dirty state when a widget drag is cancelled (for example with escape key)

#rb jamie.dale
#preflight 63f3e55c6a22bef8c0a8dded

[CL 24331749 by brooke hubert in ue5-main branch]
2023-02-20 20:22:21 -05:00
brooke hubert
68b178d11f Backout CL 24196898
#rb trivial
#rnx

[CL 24217677 by brooke hubert in ue5-main branch]
2023-02-14 14:21:30 -05:00
brooke hubert
f685dd39fd Fix a couple of issues where packages were aggressively dirtied
- Call cancel on the transaction if it is actually a camera movement input
 - Reset package dirty state when a widget drag is cancelled (for example with escape key)

#rb jamie.dale
#preflight 63e69de8816a1dff9ffe2d87

[CL 24201120 by brooke hubert in ue5-main branch]
2023-02-13 22:02:24 -05:00
Charles deRousiers
338b5c153b Merge BlendMode and BlendModeStrata to reduce code divergence, and ease maintenance.
#rb sebastien.hillaire
#jira none
#preflight 63c03173c77f50e3b47ed2bd

[CL 23683231 by Charles deRousiers in ue5-main branch]
2023-01-13 14:19:13 -05:00
brooke hubert
b10947c3c0 Fix an issue where pitch would never lock in the level editor when rotating the perspective camera
#Jira UE-90691
[REVIEW] [at]editor-framework [at]lauren.barnes
#preflight 63c03b220225f00e14896184

[CL 23667627 by brooke hubert in ue5-main branch]
2023-01-12 14:43:50 -05:00
Charles deRousiers
5c44593f0d Abstract blendmode lookup to ease blend mode compatibility with Strata.
#rb sebastien.hillaire
#jira none
#preflight 6398964335203bc7aa695e10

[CL 23492252 by Charles deRousiers in ue5-main branch]
2022-12-13 10:44:43 -05:00
jonathan bard
a93ae3fc20 Fixed height preview mode activation/deactivation and preview mesh cycling
#rb ruslan.idrisov
#jira UE-169712
#lockdown jeanmichel.dignard
#preflight 637c32e8cc307d6fa592ab54

robomerge[FN_EngineMerge] -UE5-RES

[CL 23235198 by jonathan bard in ue5-main branch]
2022-11-22 10:06:49 -05:00
henrik karlsson
d5026d4d83 Strategical submit which adds includes in preparation for coming change which removes includes in headers
#preflight 636531a1581dc906bce283d1
#rb none

[CL 22994620 by henrik karlsson in ue5-main branch]
2022-11-04 16:37:48 -04:00
Thomas Sarkanen
d9c2b172f7 Skeleton compatibility improvements
Skeleton compatibility is now bi-directional. Specifying a compatible skeleton A -> B now implies B -> A.
Skeleton compatibility is now an editor-only concern. The runtime will attempt to do the 'best it can' via name -> name mappings. Only the editor will prevent assigning incompatible skeletons in (e.g.) asset pickers etc.
Skeleton compatibility checks in editor can now be disabled in the editor preferences (and each asset picker now has a checkbox option in its view settings that allows for quick access to this).

Moves FSkeletonRemapping to its own file (which is now private).
Skeleton remappings are now generated on demand on worker threads just before animation decompression and stored in a registry, guarded by FRWScopeLock for thread-safety.

Fixed some anim BP compiler edge cases where asset references on pins were not getting preloaded correctly, causing skeletons to be erroneously reported as missing.

Exposed the current asset registry filter in SAssetView so that menu extensions can access it (and use it to provide context)

#jira UE-166054
#jira UE-167355
#rb Jurre.deBaare,John.vanderBerg
#preflight 635902602e6690262afa86f9

[CL 22878911 by Thomas Sarkanen in ue5-main branch]
2022-11-01 06:25:59 -04:00
philippe deseve
93c7347a69 Add FContentBundleEditingContext to activate a ContentBundle in a specific scope.
Allows to disable a content bundle after a plugin actors was Drag n dropped

#rb richard.malo

[CL 22823543 by philippe deseve in ue5-main branch]
2022-10-28 00:29:55 -04:00
brooke hubert
ff68894594 [Mode Manager] Fix a regression where ActorsDuplicatedNotify was not called in some cases
#Jira UE-149375
#rb lauren.barnes
#lockdown jeanmichel.dignard
#preflight 6357589f3d41a4455a800bc8

robomerge[FN_EngineMerge] -UE5-RES

[CL 22798570 by brooke hubert in ue5-main branch]
2022-10-26 19:11:47 -04:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
Dan Thompson
7b15828416 Fix for dragging a texture on a cube when a material already exists, and some protection against redirects in similar cases.
#rb matt.peters
#rb jason.stasik
#preflight 6351a5d9f92c325024c634e5

[CL 22669030 by Dan Thompson in ue5-main branch]
2022-10-20 16:14:02 -04:00
dave jones2
8eeb8bfe5f UE-160860 - Fix UnrealEd Module truncation warnings
Part 3 of N

#jira UE-160860
#preflight 6348a349204d7f312b70632c
#rb andrew.davidson

[CL 22602879 by dave jones2 in ue5-main branch]
2022-10-18 12:28:35 -04:00
lonnie li
3b3485f961 LevelEditor: Expose bCurrentlyEditingThroughMovementWidget to allow for more immediate lighting updates when interactively editing the level.
#rb daniel.wright

[CL 22408839 by lonnie li in ue5-main branch]
2022-10-07 16:35:52 -04:00