Commit Graph

66 Commits

Author SHA1 Message Date
garrett conti
38227ba6f4 [UEFN Support][Engine][Feedback Context Editor]
- Added new Important visibility slow tasks to override visibility of other tasks (making them invisible and the Important task visible in its place)
- Added a new loop that looks specifically for a the new Important tasks and adjusted the existing loop to insert the default tasks in the remaining slots.

[REVIEW] Josh, Bryan, Andrew, Cory

#jira: https://jira.it.epicgames.com/browse/FORT-599030

#testing: Converted the DBZ map which has a lot of progress bar changes to make sure the progress bars still work correctly and the new Important child tasks also show up (Including invisible tasks staying invisible).

Also tried increasing the number of sub loading bars just to make sure that code still worked as well.
And profiled the code to see if performance would be affected (the function still only took a micro second on average since the stack rarely gets past 10 elements and I have not seen it get to 20)

Tested to make sure an empty text important task did not break anything and made sure default tasks were inserted before, in-between, and after important tasks correctly

#preflight: https://horde.devtools.epicgames.com/job/645129ebc86798f650b8d71e

[CL 25309641 by garrett conti in ue5-main branch]
2023-05-02 18:25:16 -04:00
mark lintott
e63c334048 EpicStudioAnalytics plugin rewrite
High Level Vision:
https://docs.google.com/document/d/13R4nJ2UNMJZlf6JCjYssFMSY-5CrURazE4tqxW77yBw/edit#heading=h.bpycydduomgi

Details of changes:
Removed "most" references to FStudioAnalytics from Engine code.
Deprecated use of FStudioAnalytics::FireEvent_Loading(), will deprecate FStudioAnalytics in due course.
Added FAnalyticsFlowTracker to the engine code base based on the flow system used in UEFN.
Added explicit DDC Resource and DDC Summary events to track DDC usage by resource type.
Moved common Editor analytics callbacks into EpicStudioAnalytics plugin
Added a variety of delegates to the engine code to so that analytics capture can be defined in the plugin code or within the game code instead of the engine code ( eg. load map, editor initialization, cooking, slow task )
Added JSON serializer for analytics events to provide facility to capture analytics in restriced environments ( eg. UEFN CookWorker ). Though this fetaure is not enabled yet.
This will temporarily break Loading and Cooking analytics for Lyra, ShooterGame, CitySample but not Fortnite or UEFN. The remainder will need to be "fixed up" in UE5/Main once the changes have propogated (stakeholders have been notified)

[FYI] zousar.shaker, devin.doucette, eric.knapik, francis.hurteau
#rb wes.hunt
#preflight 643e45150a5a4b944e603be8

[CL 25083739 by mark lintott in ue5-main branch]
2023-04-18 07:16:36 -04:00
mark lintott
44f10e93db Added a default MapName to SlowTask and EditorBoot events so we can use filtering by MapName more appropriately in Grafana
#rb trivial
#preflight 642456a0b72410fc1745b091

[CL 24839717 by mark lintott in ue5-main branch]
2023-03-29 13:23:58 -04:00
devin doucette
cc99d6c295 Logging: Added structured logging support to non-platform feedback contexts
#jira UE-152840
#preflight 63b4824f717a593ee7f1e245
#rb Zousar.Shaker
#rnx

[CL 23570675 by devin doucette in ue5-main branch]
2023-01-03 17:15:30 -05:00
christopher waters
0270a5f287 Moving FDeferredCleanupInterface and accompanying types to RenderDeferredCleanup.h to remove global dependencies on RenderThread.h
#preflight 6393481ebb6fefa472ddeae0

[CL 23475364 by christopher waters in ue5-main branch]
2022-12-11 23:11:39 -05:00
henrik karlsson
4a5e13525d Fixed non-unity non-pch compile errors
#preflight skipped
#rb none

[CL 22788359 by henrik karlsson in ue5-main branch]
2022-10-26 16:22:34 -04:00
dave jones2
70034eb577 UE-160860 - Fix UnrealEd Module truncation warnings
Part 2 of N

#jira UE-160860
#preflight 634451b56732684595b74177
#rb andrew.davidson

[CL 22601794 by dave jones2 in ue5-main branch]
2022-10-18 11:54:15 -04:00
dave jones2
c166fadeee UE-160860 - Fix UnrealEd Module truncation warnings
Part 1 of N

#jira UE-160860
#preflight 6331d582b20e73a0983f88cd
#rb andrew.davidson

[CL 22217608 by dave jones2 in ue5-main branch]
2022-09-27 23:50:36 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
danny couture
ef17e2595d Add insight tag to editor feedback context update
#rb trivial
#preflight 622b38290a614dcb0ceed5e8

[CL 19352912 by danny couture in ue5-main branch]
2022-03-11 07:54:56 -05:00
aurel cordonnier
34f55d3a4a Merge from Release-Engine-Test @ 17946149 to UE5/Main
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17949667 by aurel cordonnier in ue5-main branch]
2021-10-27 15:14:40 -04:00
geoff evans
f29dce2cf3 FApp::HasFocus() API to unify checking focus state
This is a defensive change to more uniformly gate conditions of various pathways that want to "nice" CPU consumption when the application is not the foreground application (doesn't "Have Focus"). In benchmarking scenarios we don't want a focus-grabbing application to cause change in behavior while taking performance measurements. This could be in local workstation benchmarking where other foreground apps will naturally come to the front or in data center build where antics that might otherwise be completely unknowable could impact benchmark measurements.

This change was formulated after finding some "nice" CPU conditionals that were instrumented, but not all of them are. This change aims to prevent having to instrument, profile, and mitigate each condition separately.

#rnx
#jira none
#rb francis.hurteau, brandon.schaefer
#preflight 611ec9248ff55400018d5018

[CL 17463345 by geoff evans in ue5-main branch]
2021-09-08 16:29:44 -04:00
danny couture
1ff405cb3a Skip FlushRenderingCommand in slowtask tick when there is nothing to cleanup
#rnx
#rb Francis.Hurteau

[CL 16857570 by danny couture in ue5-main branch]
2021-07-14 20:20:41 -04:00
matt kuhlenschmidt
fd2d59745e Updated windows splash screen. Mac and Linux may not look correct but will be fixed by engineers familar with those platforms
[FYI] louise.rasmussen

#ROBOMERGE-SOURCE: CL 15919682 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15921227 by matt kuhlenschmidt in ue5-main branch]
2021-04-05 15:05:46 -04:00
jason nadro
6629bd5cf7 Editor splash screen improvements.
- Fixed a bug in the splash screen that would only show the root most scoped slow task resulting in only "Initializing..." displaying.  Now we work from the back of the array (top of the stack) to pull the innermost scoped slow task message.  This results in more log messages displaying.
- Display the splash screen percentage leftmost justified to avoid it jumping around due to the length of the message.
- Adding messages to the global shader scoped slow tasks.
- Fixed a bug where blocking material compilation wasn't displaying a message to the splash screen.  Simply adding a FScopedSlowTask will not update the UI's display message.  The UI is only updated when EnterProgressFrame is called.

#rb Matt.Kuhlenschmidt
[REVIEW]
#jira none

#ROBOMERGE-SOURCE: CL 15624861 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v777-15581079)

[CL 15624912 by jason nadro in ue5-main branch]
2021-03-05 11:46:13 -04:00
matt kuhlenschmidt
9e482fe7c6 Cleanup progress bar styles and fix slow task not showing the secondary progress bars
#ROBOMERGE-SOURCE: CL 15379156 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15383280 by matt kuhlenschmidt in ue5-main branch]
2021-02-10 19:52:17 -04:00
JeanMichel Dignard
48612c4242 Fixed slowtask secondary bar displaying the same text as the main bar
#rb Matt.Kuhlenschmidt

[CL 14836140 by JeanMichel Dignard in ue5-main branch]
2020-12-02 12:49:49 -04:00
Matt Kuhlenschmidt
a354c86d42 Build Progress widget reskin
[CL 14492605 by Matt Kuhlenschmidt in ue5-main branch]
2020-10-14 12:13:10 -04:00
Matt Kuhlenschmidt
43d7d4c2c6 Slowtask dialog and progress bar update
[CL 14463619 by Matt Kuhlenschmidt in ue5-main branch]
2020-10-09 15:09:19 -04:00
Marcus Wassmer
3b81cf8201 Merging using //UE5/Main_to_//UE5/Release-Engine-Staging @14384769
autoresolved files
#rb none

[CL 14384911 by Marcus Wassmer in ue5-main branch]
2020-09-24 00:43:27 -04:00
Marc Audy
11f5b21210 Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
#rnx

[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
Nick Darnell
c44d4eb8c2 Editor - Adding a 'Studio Analytics' class to the engine. The purpose is to allow studios to gather analytics about their internal development - for example, time to load the editor, or time to open different types of assets. Licensees must create their own IAnalyticsProvider and assign it to the studio analytic static, otherwise it does nothing by default.
Added timing information to record when PIE starts.

#rb none

#ROBOMERGE-OWNER: Nick.Darnell
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 11104590 via CL 11104688 via CL 11104690
#ROBOMERGE-BOT: (v640-11091645)

[CL 11104846 by Nick Darnell in Main branch]
2020-01-24 10:14:26 -05:00
dave belanger
8cc930fd44 Support slow task cancellation checks with nested tasks and throughout the slow task lifescope (and after its lifescope; before a new root slow task is created).
#rb Andrew.Rodham


#ROBOMERGE-SOURCE: CL 10878671 via CL 10878776
#ROBOMERGE-BOT: (v626-10872990)

[CL 10878784 by dave belanger in Main branch]
2020-01-06 11:28:14 -05:00
ryan durand
627baf970a Updating copyright for Engine Editor.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869241 via CL 10869527 via CL 10869904
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870586 by ryan durand in Main branch]
2019-12-26 15:33:43 -05:00
JeanMichel Dignard
d4f0f4d3f2 Copying //UE4/Dev-Enterprise @ cl 9420543 to Dev-Main (//UE4/Dev-Main)
#rb none

[CL 9420574 by JeanMichel Dignard in Main branch]
2019-10-04 13:11:45 -04:00