Commit Graph

533 Commits

Author SHA1 Message Date
brooke hubert
105727f1ab [Editor Viewport] Add a cvar to disable invalidate on each SIE frame. Mouse clicks and other times a viewport would get invalidated should still occur.
r.Editor.Viewport.InvalidateEachSIEFrame (default to on to preserve behavior)

#Jira UE-194527
#rb ronald.koppers

[CL 27772634 by brooke hubert in ue5-main branch]
2023-09-11 17:45:02 -04:00
stan hormell
37bad2d07b [Backout] - CL27731288 - CIS / Build Errors
[FYI] Josh.Adams
Original CL Desc
-----------------------------------------------------------------
- Deprecated GetSectionPrivate and FindOrAddSection, and accessors in FConfigFile that could return a non-const FConfigSection (this is so we can track modifications to config values)
- Added AddToSection, RemoveKeyFromSection, etc to replace directly accessing a FConfigSection
- Fixed up Epic code for the deprecations (at least the majority, some projects that aren't built by Horde presubmit may have some that we will address going forward)
#jira UE-194955
#rb david.harvey and various others

[CL 27745141 by stan hormell in ue5-main branch]
2023-09-10 22:58:21 -04:00
josh adams
a8a9a0b759 - Deprecated GetSectionPrivate and FindOrAddSection, and accessors in FConfigFile that could return a non-const FConfigSection (this is so we can track modifications to config values)
- Added AddToSection, RemoveKeyFromSection, etc to replace directly accessing a FConfigSection
- Fixed up Epic code for the deprecations (at least the majority, some projects that aren't built by Horde presubmit may have some that we will address going forward)
#jira UE-194955
#rb david.harvey and various others

[CL 27731364 by josh adams in ue5-main branch]
2023-09-08 17:58:55 -04:00
jack porter
cf52ad35af Added new PerPlatformConfig class flag indicating the config properties can be overridden in a Platform/PlatformEngine.ini file.
When a class is marked PerPlatformConfig, in the editor the class will be loaded from the platform inis of the current PreviewPlatform on load, and when the PreviewPlatform is changed, LoadConfig will be called to reload the settings from the platform ini file.
#rb Florin.Pascu, Josh.Adams

[CL 27273113 by jack porter in ue5-main branch]
2023-08-22 11:52:23 -04:00
julien stjean
7d9b5aeb59 Fixed an issue where the data validation was not able to execute some editor utility validator because some module where not loaded by default that those editor utility might depends on.
Extracted an function on the default EditorEngine to load the module that are loaded by default when it is initialized. This can now be used to load those module in some commandlet without the need to initiliaze the EditorEngine.

The DataValidationCommandlet now load those editor modules if it found an validator that is made via an EditorUtility.

#jira UE-191040
#rb JeanLuc.Corenthin

[CL 27002021 by julien stjean in ue5-main branch]
2023-08-10 14:38:04 -04:00
david harvey
bdb4199eeb Remove unnecessary WindowsHWrapper.h & MinWindows.h include - both files will be automatically included by AllowWindowsPlatformTypes.h
#jira UE-152863
#rnx
#rb Josh.Adams

[CL 26912096 by david harvey in ue5-main branch]
2023-08-08 05:50:53 -04:00
jamie dale
e1575ff4a2 Added a category type that can be used with FMessageDialog to control the icon used by the in-editor dialog
Note: This doesn't impact any OS specific dialogs

Breaking: FCoreDelegates::ModalErrorMessage is now called FCoreDelegates::ModalMessageDialog and takes an extra EAppMsgCategory argument

#jira
#rb Dave.Belanger

[CL 26322954 by jamie dale in ue5-main branch]
2023-06-29 14:57:59 -04:00
matt peters
bfb911478a Cooker: Hidden Dependencies diagnostics: Add scopes to suppress false-positive hidden dependencies. Share the DebugOnlyEditorOnly code to remove other false-positives using analysis of the saved package.
#rb Zousar.Shaker
#rnx

[CL 26261281 by matt peters in ue5-main branch]
2023-06-27 12:35:20 -04:00
logan buchy
87012153c4 Remove TypedElementViewportInteractionGizmoManipulation from TypedElement ViewportInteraction
* The same functionality is provided by the GizmoManipulationStarted and GizmoManipulationStopped.
* This simplifies the interface and removes the bespoke parameter added to branch between when manipulation starts and when it is ongoing to avoid expensive rendering invalidations
* There are some clients of TypedElementViewportInteractionGizmoManipulation::ApplyDeltaToActor, this CL does not address usage of this function.  Doing so will require further adoption of TypedElements among those systems

#jira UE-187188
#rb Brooke.Hubert

[CL 25964466 by logan buchy in ue5-main branch]
2023-06-13 17:28:30 -04:00
joe pribele
17a9c2dc99 deprecated Engine::FindAndPrintStaleReferencesToObject as it was moved FReferenceChainSearch
https://p4-swarm.epicgames.net/reviews/25629892

#rb robert.millar
#preflight 646ff13227390642750296ec

[CL 25646604 by joe pribele in ue5-main branch]
2023-05-26 12:38:28 -04:00
Dmitriy Dyomin
c295434c9b Do not auto-generate GBuffer layout for mobile platforms. Mobile uses hardcoded layout anyway
#jira none
#preflight 6452002dd863ba2621026312

[CL 25314792 by Dmitriy Dyomin in ue5-main branch]
2023-05-03 02:55:51 -04:00
dan oconnor
0c1887c835 Load ScriptableEditorWidgets alongside Blutilities and UMGEditor, as it is now owns the DetailsView that used to be in UMGEditor, this fixes projects that were using the DetailsView (which was moved in 25196253) project implicitly via the engine dependencies on UMGEditor
#preflight 644b04cc693defa68dadcf8e
#rb Matt.Hoffmann

[CL 25238090 by dan oconnor in ue5-main branch]
2023-04-28 15:36:25 -04:00
KristofMorva
a9a86e44cc Make SyncBrowserToObjects use const arrays and add SyncBrowserToObject
#rb aditya.ravichandran, karen.jirak, sebastian.arleryd
#preflight 644a985b1c2846595ca00477

#ushell-cherrypick of 25215024 by kristof.morva1

[CL 25216466 by KristofMorva in ue5-main branch]
2023-04-27 11:58:53 -04:00
jason hoerner
2a816e5ad4 Further optimization for moving actor with many static mesh components. Only invalidate the static lighting cache at the start of a move operation. We don't invalidate the cache in "GizmoManipulationStarted", because the user can click on a handle (calling the start function) without actually moving, which should have no effect. So a flag is used to detect the first time "GizmoManipulationDeltaUpdate" is called, and subsequent calls can skip repeatedly invalidating the lighting cache.
With this fix, on my machine, the cost of moving a blueprint with 1000 items drops from 45 ms to 7 ms.  Baseline tick is 8 ms (120 fps) when idling, so the results while moving improve from 19 fps to 65 fps.  The remaining time is mostly split between physics and navigation update.  Invalidating the static lighting cache is so costly because it both invalidates the render state of every item, and notifies packages of the change.

#jira UE-147154
#rnx
#rb jamie.dale
#preflight 63ff4748e32cdb7d9aacab16

[CL 25050136 by jason hoerner in ue5-main branch]
2023-04-14 17:02:21 -04:00
sebastien lussier
b503f6a134 Make sure to assign a unique label to new actors that are created without a factory
- In OFPA, actors without a factory had their name uniqueness tested using the object FName (with the appended UID part...) , so the name was always considered unique
- Added an explicit call to FActorLabelUtilities::SetActorLabelUnique(), which does the correct tests
#rb philippe.deseve

[CL 25018383 by sebastien lussier in ue5-main branch]
2023-04-12 19:07:30 -04:00
jason nadro
9b778be14c Force all viewports to have focus so Auto LOD updating works again. This is to fix issues with CL#22566736
- This will re-introduce LOD flicker between viewports.

#rb Jeremy.Moore
#jira UE-180761
#preflight 6435b68b2909bc56c8e88412

[CL 24999505 by jason nadro in ue5-main branch]
2023-04-11 17:55:04 -04:00
dave belanger
8b3cdfad65 [UEFN] Support removing multiple project references simultaneously
#rb none
#preflight 6421fe25973e609670b97de9

[CL 24814605 by dave belanger in ue5-main branch]
2023-03-27 23:42:48 -04:00
jeanfrancois dube
313acab7d1 Actor Instance Guids: actor instance guids are now always available in AActor::RegisterAllComponents.
#rb patrick.enfedaque
[FYI] stephen.holmes
#preflight 641de8f8a86ae7cbcc6f6bec

[CL 24789971 by jeanfrancois dube in ue5-main branch]
2023-03-24 18:45:14 -04:00
arciel rekman
04d4d916fe Fix Android VR Preview issues (UE-176854).
- Prevent wrong feature level from being used while in preview.
- Also while at it, remove the filtering out of a alpha blend mode on mobile, because mobile renderer no longer uses alpha to store depth.

#rb Erica.Stella, Jules.Blok
#jira UE-176854
[REVIEW] [at]Erica.Stella, [at]Rob.Srinivasiah, [at]Jules.Blok
#preflight 6418766b3d275ade388f1b58

[CL 24723912 by arciel rekman in ue5-main branch]
2023-03-20 17:15:40 -04:00
zach bethel
5ad5368df1 Removing unused 'ViewParent' feature and other dead code.
#rb krzysztof.narkowicz
#preflight 640a3f3e482188d710bc19a2

[CL 24581280 by zach bethel in ue5-main branch]
2023-03-09 15:33:59 -05:00
patrick enfedaque
46530814a9 OnLoadedActorRemoved: Avoid deselect of actors with a root selection parent
#rb richard.malo, jeanfrancois.dube
#preflight 6407a71cfb10f393c20df66c
#rnx

[CL 24557986 by patrick enfedaque in ue5-main branch]
2023-03-08 07:39:01 -05:00
Matt Peters
7bbd3c4bf0 Cooker,AssetRegistry,AssetManager: Remove deprecation handling for fields deprecated in 5.1 and earlier.
Make AssetManager required; engine startup gives a fatal error if AssetManager is not present.
#rn Minor, Cooking
#rb Zousar.Shaker
#preflight 63ffd322df66ed5fc11d963e

[CL 24493164 by Matt Peters in ue5-main branch]
2023-03-02 19:37:50 -05:00
Florin Pascu
106ea7508c Preparation changes for removing FeatureLevel from World
FeatureLevel is Deprecated
Add Setter/Getter for FeatureLevel
NextStep: Make GetFeatureLevel returns DDSPI::GetFeatureLevel, remove FeatureLevel memberfrom UWorld
#jira UE-168551
#rb christopher.waters
#preflight 63ff5e49f43e53f6811c86a4

[CL 24461796 by Florin Pascu in ue5-main branch]
2023-03-01 09:41:33 -05:00
yuriy odonnell
e1b0d852cc Remove the dedicated option to disable real-time viewports when the editor in the background. Use the existing bThrottleCPUWhenNotForeground option instead, but ignore all the extra special conditions that are handled by UEditorEngine::ShouldThrottleCPUUsage()
#rb Rex.Hill
#preflight 63fd408cf43e53f6813198ed

[CL 24437250 by yuriy odonnell in ue5-main branch]
2023-02-27 21:22:02 -05:00
yuriy odonnell
4afa486b0a Add an option to disable real-time viewports when the Editor process is in the background (off by default)
#preflight 63f91486dd78dd50f695651e
#rb Rex.Hill

[CL 24412802 by yuriy odonnell in ue5-main branch]
2023-02-24 19:03:02 -05:00